Re: [Libreoffice online] Interested in Contribution

2015-04-08 Thread Ioan Radu
Welcome Gokul, to get the source code and build it follow https://www.libreoffice.org/about-us/source-code/ For start you can try an easy hack https://wiki.documentfoundation.org/Easy_Hacks Code documentation can be found at: https://wiki.documentfoundation.org/Development + https://wiki.openoff

Re: Ursache Vladimir license statement

2015-02-11 Thread Ioan Radu
Hello Vladimir, I have added you to developers list https://wiki.documentfoundation.org/Development/Developers#U On Tue, Feb 10, 2015 at 10:24 PM, Vladimir wrote: > All of my past & future contributions to LibreOffice may be > licensed under the MPLv2/LGPLv3+ dual license. > > > PS: I do contra

[Libreoffice-commits] core.git: svtools/source

2014-11-05 Thread Ioan Radu
svtools/source/config/colorcfg.cxx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit 6cc8ed7d64b4c01550539170c1848f1152e433af Author: Ioan Radu Date: Sun Nov 2 13:07:00 2014 +0200 fdo#60906 - Make color configuration consistent

[PATCH] fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO

2013-06-14 Thread Ioan Radu (via Code Review)
deletions(-) -- To view, visit https://gerrit.libreoffice.org/4286 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If89af70767c3fdc4b1d0cb5e51033ca98583bc5d Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan

[PATCH] fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO

2013-05-15 Thread Ioan Radu (via Code Review)
uno::Reference< rendering::XTextLayout > xTextLayout( mxTextLayout ); @@ -1749,8 +1747,8 @@ bool OutlineAction::render( const ::basegfx::B2DHomMatrix& rTransformation ) const { -RTL_LOGFILE_CONTEXT( aLog, "::cppcanvas::internal

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-05-03 Thread Ioan Radu (via Code Review)
SAL_WARN_IF(!xMeta.is(), "xmloff.text", "xml:id: not XMetadatable"); GetImport().SetXmlId(xMeta, m_sXmlId); if (m_bHaveAbout) { GetImport().AddRDFa(xMeta, m_sAbout, m_sProperty, m_sContent, m_sDatatype); } -OSL_ENSURE(!xEnum->hasMoreElements(), "xml:id: > 1 paragraph?"); +SAL_WARN_IF(xEnum->hasMoreElements(), "xmloff.text", "xml:id: > 1 paragraph?"); } } catch (const uno::Exception &) { -OSL_TRACE("XMLParaContext::~XMLParaContext: exception"); +SAL_INFO("xmloff.text", "XMLParaContext::~XMLParaContext: exception"); } } @@ -2265,7 +2264,7 @@ } break; default: -DBG_ASSERT( !this, "What's this" ); +SAL_WARN_IF( this, "xmloff.text", "What's this" ); break; } } @@ -2368,10 +2367,10 @@ i_rImport.GetTextImport()->GetTextListHelper() ); if (m_ListId.isEmpty()) { -OSL_ENSURE( i_rImport.GetODFVersion() != "1.2", "invalid numbered-paragraph: no list-id (1.2)" ); +SAL_WARN_IF( i_rImport.GetODFVersion() == "1.2", "xmloff.text", "invalid numbered-paragraph: no list-id (1.2)" ); m_ListId = rTextListsHelper.GetNumberedParagraphListId(m_Level, StyleName); -OSL_ENSURE(!m_ListId.isEmpty(), "numbered-paragraph: no ListId"); +SAL_WARN_IF(m_ListId.isEmpty(), "xmloff.text", "numbered-paragraph: no ListId"); if (m_ListId.isEmpty()) { return; } @@ -2379,7 +2378,7 @@ m_xNumRules = rTextListsHelper.EnsureNumberedParagraph( i_rImport, m_ListId, m_Level, StyleName); -OSL_ENSURE(m_xNumRules.is(), "numbered-paragraph: no NumRules"); +SAL_WARN_IF(!m_xNumRules.is(), "xmloff.text", "numbered-paragraph: no NumRules"); i_rImport.GetTextImport()->GetTextListHelper().PushListContext( this ); } -- To view, visit https://gerrit.libreoffice.org/3771 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I80aca85562e4a43fded5c37f9895e51f79e42c14 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-21 Thread Ioan Radu (via Code Review)
ex.Message, RTL_TEXTENCODING_ASCII_US ).getStr()); +SAL_WARN("xmloff.chart", "Exception caught, Message: " << ex.Message ); } } return bResult; @@ -721,7 +712,7 @@ } catch( const uno

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-16 Thread Ioan Radu (via Code Review)
hXMLExport::_ExportMasterStyles() { // not available in chart -DBG_WARNING( "Master Style Export requested. Not available for Chart" ); +SAL_INFO("xmloff.chart", "Master Style Export requested. Not available for Chart" ); } void SchXMLExport::_ExportAutoStyles() @@ -3650,7 +3621,7 @@ } else { -OSL_FAIL( "Couldn't export chart due to wrong XModel (must be XChartDocument)" ); +SAL_WARN("xmloff.chart", "Couldn't export chart due to wrong XModel (must be XChartDocument)" ); } } } @@ -3706,7 +3677,7 @@ } catch( const beans::UnknownPropertyException & ) { -OSL_FAIL( "Property ChartRangeAddress not supported by ChartDocument" ); +SAL_WARN("xmloff.chart", "Property ChartRangeAddress not supported by ChartDocument" ); } } } @@ -3716,7 +3687,7 @@ } else { -OSL_FAIL( "Couldn't export chart due to wrong XModel" ); +SAL_WARN("xmloff.chart", "Couldn't export chart due to wrong XModel" ); } } @@ -3731,7 +3702,7 @@ try { Reference< chart2::data::XDataProvider > xDataProvider( xChartDoc->getDataProvider() ); -OSL_ENSURE( xDataProvider.is(), "No DataProvider" ); +SAL_WARN_IF( !xDataProvider.is(), "xmloff.chart", "No DataProvider" ); if( xDataProvider.is()) { Reference< chart2::data::XDataSource > xDataSource( lcl_pressUsedDataIntoRectangularFormat( xChartDoc, mbHasCategoryLabels )); @@ -3777,11 +3748,7 @@ catch( const uno::Exception & ex ) { (void)ex; // avoid warning for pro build -OSL_FAIL( OUStringToOString( -OUString( "Exception caught. Type: " ) + -OUString::createFromAscii( typeid( ex ).name()) + -OUString( ", Message: " ) + -ex.Message, RTL_TEXTENCODING_ASCII_US ).getStr()); +SAL_WARN("xmloff.chart", "Exception caught. Type: " << OUString::createFromAscii( typeid( ex ).name()) << ", Message: " << ex.Message); } } -- To view, visit https://gerrit.libreoffice.org/3423 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie5d3ae7d2c5dbaaed30d0b39740748845c9f1641 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-07 Thread Ioan Radu (via Code Review)
ght IllegalArgumentException reason %s", -OUStringToOString( e.Message, RTL_TEXTENCODING_ASCII_US ).pData->buffer ); +SAL_INFO("xmlscript.xmlflat", "BasicSourceCodeElement::endElement: caught IllegalArgumentException reason " << e.Message ); }

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-04-02 Thread Ioan Radu (via Code Review)
tion::setCursor: no window!" ); if ( !pWindow ) continue; diff --git a/vbahelper/source/vbahelper/vbashape.cxx b/vbahelper/source/vbahelper/vbashape.cxx index 98a697d..adeafac 100644 --- a/vbahelper/source/vbahelper/vbashape.cxx +++ b/vbahelper/source/vbahelper/vbashape.cxx @@ -116,7 +116,7 @@ OUString sShapeType; uno::Reference< drawing::XShapeDescriptor > xShapeDescriptor( xShape, uno::UNO_QUERY_THROW ); sShapeType = xShapeDescriptor->getShapeType(); -OSL_TRACE("ScVbaShape::getType: %s", OUStringToOString( sShapeType, RTL_TEXTENCODING_UTF8 ).getStr() ); +SAL_INFO("vbahelper","ScVbaShape::getType: " << sShapeType); // office::MsoShapeType::msoDiagram to "com.sun.star.drawing.GroupShape" if( sShapeType == "com.sun.star.drawing.GroupShape" ) return office::MsoShapeType::msoGroup; -- To view, visit https://gerrit.libreoffice.org/3179 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I20f539bd9fa62bef2e9a2a82b59e0b15f4efdd48 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-03-10 Thread Ioan Radu (via Code Review)
c; @@ -1086,7 +1088,7 @@ bool TcgSttbf::Read( SvStream &rS) { -OSL_TRACE("TcgSttbf::Read() stream pos 0x%x", rS.Tell() ); +SAL_INFO("sw.ww8","TcgSttbf::Read() stream pos 0x" << rS.Tell() ); nOffSet = rS.Tell(); Tcg255SubStruct::Read(

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-02-06 Thread Ioan Radu (via Code Review)
SAL_INFO("xmlsecurity.helper","XSecController::setSignatureValue: no signature"); return; } InternalSignatureInformation &isi = m_vInternalSignatureInformations.back(); @@ -235,13 +236,13 @@ { if (m_vInternalSignatureInformations.empty()) { -OSL_TRACE("XSecController::setDigestValue: no signature"); +SAL_INFO("xmlsecurity.helper","XSecController::setDigestValue: no signature"); return; } InternalSignatureInformation &isi = m_vInternalSignatureInformations.back(); if (isi.signatureInfor.vSignatureReferenceInfors.empty()) { -OSL_TRACE("XSecController::setDigestValue: no signature reference"); +SAL_INFO("xmlsecurity.helper","XSecController::setDigestValue: no signature reference"); return; } SignatureReferenceInformation &reference = @@ -253,7 +254,7 @@ { if (m_vInternalSignatureInformations.empty()) { -OSL_TRACE("XSecController::setDate: no signature"); +SAL_INFO("xmlsecurity.helper","XSecController::setDate: no signature"); return; } InternalSignatureInformation &isi = m_vInternalSignatureInformations.back(); @@ -265,7 +266,7 @@ { if (m_vInternalSignatureInformations.empty()) { -OSL_TRACE("XSecController::setId: no signature"); +SAL_INFO("xmlsecurity.helper","XSecController::setId: no signature"); return; } InternalSignatureInformation &isi = m_vInternalSignatureInformations.back(); @@ -276,7 +277,7 @@ { if (m_vInternalSignatureInformations.empty()) { -OSL_TRACE("XSecController::setPropertyId: no signature"); +SAL_INFO("xmlsecurity.helper","XSecController::setPropertyId: no signature"); return; } InternalSignatureInformation &isi = m_vInternalSignatureInformations.back(); -- To view, visit https://gerrit.libreoffice.org/2010 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib47c4b4c9604bca1f8a635dd01bb89702b47b591 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-02-04 Thread Ioan Radu (via Code Review)
L_TEXTENCODING_ASCII_US).getStr() << " = " << OUStringToOString( e.Message, RTL_TEXTENCODING_ASCII_US ).getStr() ); } return Reference< XAnimationNode >(); diff --git a/sd/source/ui/framework/configuration/ConfigurationTracer.cxx b/sd/source/ui/framework/configuration/ConfigurationTracer.cxx index b591c80..74839b9 100644 --- a/sd/source/ui/framework/configuration/ConfigurationTracer.cxx +++ b/sd/source/ui/framework/configuration/ConfigurationTracer.cxx @@ -21,6 +21,7 @@ #include "ConfigurationTracer.hxx" #include +#include "sal/log.hxx" using namespace ::com::sun::star::uno; using namespace ::com::sun::star::drawing::framework; @@ -32,16 +33,16 @@ const char* pMessage) { #ifdef DEBUG -OSL_TRACE("%s at %p {", pMessage, rxConfiguration.get()); +SAL_INFO("sd.ui","" << pMessage << " at " << rxConfiguration.get() << " {"); if (rxConfiguration.is()) { TraceBoundResources(rxConfiguration, NULL, 0); } else { -OSL_TRACE("empty"); +SAL_INFO("sd.ui","empty"); } -OSL_TRACE("}"); +SAL_INFO("sd.ui","}"); #else (void)rxConfiguration; (void)pMessage; @@ -65,7 +66,7 @@ ::rtl::OUString sLine (aResourceList[nIndex]->getResourceURL()); for (int i=0; ihttps://gerrit.libreoffice.org/1986 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6504abf50f6193db52d101ec856bcaf1ee2a982c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-01-21 Thread Ioan Radu (via Code Review)
; "::" << methodname << PARAMFILLER << "returnValue = " << retVal); } inline void DBG_PRINT_EXIT(const char * classname, const char * methodname, int retVal) { -OSL_TRACE("<<< %s::%s%sreturnValue = %d", classname, methodname, PARAMFILLER, ret

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2013-01-08 Thread Ioan Radu (via Code Review)
aParams, "IPmt", rPar.Get( 0 ) ); } RTLFUNC(FV) @@ -3101,7 +3102,7 @@ aParams[ 3 ] <<= pv; aParams[ 4 ] <<= type; -CallFunctionAccessFunction( aParams, OUString( "FV" ), rPar.Get( 0 ) ); +CallFunctionAccessFunction( aParams, "FV", rPar.Get(

[PATCH] fdo#43157 - Clean up OSL_ASSERT, DBG_ASSERT

2012-12-30 Thread Ioan Radu (via Code Review)
od not found! (NULL)" ); +SAL_WARN_IF( !pMethod, "basctl.basicide","Method not found! (NULL)" ); aSeqMethods.getArray()[ iTarget++ ] = pMethod->GetName(); } } -- To view, visit https://gerrit.libreoffice.org/1519

[PATCH] fdo#39440 - cppcheck cleanliness

2012-12-30 Thread Ioan Radu (via Code Review)
Set: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#39440 - cppcheck cleanliness

2012-12-29 Thread Ioan Radu (via Code Review)
rit-Change-Id: Ic019cb11b87cd51e7ffd1fb8f16b79dff381936c Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Cppcheck reports an assignment which isn't used in sd/source/ui/func/fupage.cxx

2012-12-28 Thread Ioan Radu
Hello Julien, but it is used, it is an array *sal_uInt16 p1 = pPtr[0], p2 = pPtr[1]; while(pPtr[2] && (pPtr[2] - p2 == 1))* On Thu, Dec 27, 2012 at 4:43 PM, julien2412 wrote: > Hello, > > Cppcheck reported this: > [sd/source/ui/func/fupage.cxx:243]: (style) Variable 'pPtr' is assigned a > val

[PATCH] rtl:: prefix removal from configmgr

2012-12-10 Thread Ioan Radu (via Code Review)
unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I88bb0beec718a7fe38c61220aa61401419f23b42 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list

[PATCH] rtl:: removal in fpicker

2012-12-08 Thread Ioan Radu (via Code Review)
https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd2eb59ff7d70fd3df42f063fcca781ef89b7d12 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list

[PATCH] fdo#39625 Make existing cppunittests work

2012-10-08 Thread Ioan Radu (via Code Review)
-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] fdo#39625 Make existing cppunittests work

2012-09-08 Thread Ioan Radu (via Code Review)
Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Make existing cppunittests work

2012-09-08 Thread Ioan Radu (via Code Review)
: I2f4e831cea0213a07f440bb00e0302eb1c4d7dc1 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Ioan Radu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

License statement

2012-08-22 Thread Ioan Radu
All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice