reat experience. The
community is very welcoming and helpful to newcomers who seriously want
to contribute. While working on LibreOffice, I learned a lot of
relevant software development lessons, met some great people, and had fun.
Good luck!
--
On 08/21/2012 10:50 AM, Michael Meeks wrote:
Thanks for applying, and working dilligently; hopefully you can spread
the news about how cool it is to hack on LibreOffice for GSOC and
we'll have you & your friends back again next year ? :-) All the best,
Michael.
I've already been telling people
of LibreOffice.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 08/17/2012 07:20 PM, Kohei Yoshida wrote:
Interesting thing is, we used to have similar performance problem with
styles import with Excel files. And I did take a very similar approach
to what you just tried. The difference is that, I set the styles
directly to ScDocument using the same data
is xmloff because it's methods are all pretty high
up there still as far as callgrind time is concerned. (Strings,
lookups, etc.)
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 08/15/2012 10:45 PM, Daniel Bankston wrote:
On 08/15/2012 09:36 PM, Daniel Bankston wrote:
These multiple calls to ScCellRangesBase::GetMarkData are happening
because the data that ScCellRangesBase::GetMarkData gets is being
reset every time a style range is added. I'm trying to s
On 08/15/2012 09:36 PM, Daniel Bankston wrote:
These multiple calls to ScCellRangesBase::GetMarkData are happening
because the data that ScCellRangesBase::GetMarkData gets is being
reset every time a style range is added. I'm trying to see if we can
stop resetting this data and just a
y before next Monday, :-) but I may be able to do a partial
conversion in this area or at least find some fix to prevent wasted time
here.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.fre
/source/filter/oox/workbookhelper.cxx | 20 +--
6 files changed, 65 insertions(+), 18 deletions(-)
New commits:
commit 2892dab25d266ff81162ed91744b89f26299a004
Author: Daniel Bankston
Date: Tue Aug 7 04:21:54 2012 -0500
Convert xlsx unnamed database range import to direct sc
sc/source/filter/xml/xmlcelli.cxx | 47 --
sc/source/filter/xml/xmlcelli.hxx |2 +
2 files changed, 27 insertions(+), 22 deletions(-)
New commits:
commit cc5b8609490637e3a19761a965af9fdd47310954
Author: Daniel Bankston
Date: Tue Jul 31 00:26:05 2012
sc/source/filter/oox/workbookhelper.cxx |8
1 file changed, 8 insertions(+)
New commits:
commit 3c95101f43a8abb2a644fa2bdb3468cda5e459b0
Author: Daniel Bankston
Date: Tue Jul 31 06:43:06 2012 -0500
Prevent broadcasts to gain xlsx formula import performance boost
oox
sc/source/filter/xml/xmlcelli.cxx | 47 --
sc/source/filter/xml/xmlcelli.hxx |2 +
2 files changed, 27 insertions(+), 22 deletions(-)
New commits:
commit 17e8bcbca919b3ca7cac2bf9c5bac4d4ef504232
Author: Daniel Bankston
Date: Tue Jul 31 00:26:05 2012
rg/libreoffice/core/commit/?id=42c58d9ce4f33b047feb1e94e60f165360d96209
You may have pulled before David pushed it.
If I remember correctly, after getting that commit, you'll need to make
clean and make within sc. Then you can try top level make again.
--Daniel Bankston
<http://cgit.freed
/source/ui/docshell/docsh.cxx |2 +-
7 files changed, 20 insertions(+), 15 deletions(-)
New commits:
commit f4b6cc0d3d7bb762f3778c3230ec17c25a991f3e
Author: Daniel Bankston
Date: Sat Jul 28 03:24:57 2012 -0500
Improve matrix import performance without breaking dependent cells
(-)
New commits:
commit 5a14b6bb09bd054589deec1a58d96fe5fc562f0c
Author: Daniel Bankston
Date: Sat Jul 21 03:03:42 2012 -0500
Use correct date/datetime format for formula cells and value cells.
Change-Id: I37816eba909caa71aca95c5181daeea1751b6c5a
diff --git a/sc/source/filter/xml
|3 +--
5 files changed, 11 insertions(+), 23 deletions(-)
New commits:
commit 1283ad599c6ecb8dbfaefd1d74d948de9c2def96
Author: Daniel Bankston
Date: Sat Jul 21 03:03:42 2012 -0500
Use correct date/datetime format for formula cells and value cells.
Change-Id
mdds/0001-help-compiler-select-the-right-overload-of-vector-in.patch | 52
++
mdds/makefile.mk |5
2 files changed, 56 insertions(+), 1 deletion(-)
New commits:
commit ee1e3004506083a86b6bf9c3dabd21427cf8e935
Author: David Tardon
:
commit 61c39eae570d6d6040b65bfe93127b30e6080cc8
Author: Daniel Bankston
Date: Thu Jul 19 17:26:35 2012 -0500
Display blank cell instead of zero in matrix cells with blank text result
Change-Id: Id9d17403717e42b91b1f45b0a081e2fb5a27c06e
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b
:
commit 7c7bbed45a883d10002879914e0fcbe84a0b1100
Author: Daniel Bankston
Date: Thu Jul 19 17:26:35 2012 -0500
Display blank cell instead of zero in matrix cells with blank text result
Change-Id: Id9d17403717e42b91b1f45b0a081e2fb5a27c06e
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b
:
commit d632a932fe67ec21cd66377cb03d5203a8e34ab4
Author: Daniel Bankston
Date: Sat Jul 14 00:53:07 2012 -0500
Revert "Fix for ods matrix import performance"
This reverts commit cb14c160489254298eb03f7406107e06395943d1.
This approach causes problems with chained m
On 07/13/2012 11:14 AM, Eike Rathke wrote:
So, after import, is a complete matrix already set as a result when
SetMatColsRows() is called? And if so, how? Or are only individual
results set at the cells? In which case setting the formula cell's
matrix dimension indeed should overwrite the result
:
commit cb14c160489254298eb03f7406107e06395943d1
Author: Daniel Bankston
Date: Fri Jul 13 00:27:36 2012 -0500
Fix for ods matrix import performance
Our latest changes that recalculate volatile formulas at the end of import
resulted in several seconds performance loss on a large
insertions(+), 16 deletions(-)
New commits:
commit 68eb65f19d4f3fb564ac993e8b2f37fb33d685c3
Author: Daniel Bankston
Date: Thu Jul 12 22:37:39 2012 -0500
Fix broken ODS column width import fdo#51446
Change-Id: I43b6558de6e92b0fe40a38b5f2417bebad2b7f8b
diff --git a/sc/source/filter
insertions(+), 16 deletions(-)
New commits:
commit d54be48d4ca7d17ae454a1b32ba897963a3ea836
Author: Daniel Bankston
Date: Thu Jul 12 22:37:39 2012 -0500
Fix broken ODS column width import fdo#51446
Change-Id: I43b6558de6e92b0fe40a38b5f2417bebad2b7f8b
diff --git a/sc/source/filter
sc/source/filter/xml/xmlimprt.cxx |2 --
sc/source/ui/docshell/docsh.cxx |3 ++-
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit f760f6875f22f1e6d0b782d8f6aee4250835b2a4
Author: Daniel Bankston
Date: Thu Jul 12 08:48:40 2012 -0500
Disable adjust height flag
sc/source/core/data/cell.cxx |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 513635e6993145accc008edccdb5d497f4ccecc6
Author: Daniel Bankston
Date: Thu Jul 12 08:23:54 2012 -0500
Check for more cases of functions that should always be recalculated
changes in the attached diff prevent this from happening, which gives
us back our performance. Is this approach ok?
Respectfully,
Daniel Bankston
diff --git a/sc/inc/cell.hxx b/sc/inc/cell.hxx
index 9499084..9f55491 100644
--- a/sc/inc/cell.hxx
+++ b/sc/inc/cell.hxx
@@ -474,7 +474,7 @@ public
sc/inc/cell.hxx |1 -
1 file changed, 1 deletion(-)
New commits:
commit 476a99d24918a7a1ffa86c94cb68a46c6a094a8a
Author: Daniel Bankston
Date: Wed Jul 11 18:12:27 2012 -0500
Remove method that is no longer needed
I added this method recently, but it is no longer needed
sc/source/filter/xml/XMLStylesImportHelper.cxx | 18 ++
sc/source/filter/xml/XMLStylesImportHelper.hxx |1 +
2 files changed, 19 insertions(+)
New commits:
commit beb8319ccaa0513daef03fbe995fb8775bf0b0c9
Author: Daniel Bankston
Date: Wed Jul 11 17:48:00 2012 -0500
sc/source/filter/xml/xmlcelli.cxx | 29 ++---
sc/source/filter/xml/xmlcelli.hxx |8
2 files changed, 22 insertions(+), 15 deletions(-)
New commits:
commit 1d6d2a56abfd28ff2e16855bdbaf7e64e17e92a4
Author: Daniel Bankston
Date: Wed Jul 11 17:33:25 2012
sc/source/filter/xml/xmlcelli.cxx |1 +
sc/source/filter/xml/xmlimprt.cxx |3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 243c7d512c49ca2d5d561ac9ebb2d6754027743e
Author: Daniel Bankston
Date: Wed Jul 11 16:49:19 2012 -0500
Distinguish between DATE and
|2 ++
sc/source/ui/docshell/docsh.cxx|2 ++
6 files changed, 47 insertions(+), 18 deletions(-)
New commits:
commit 58d870236487e09a7ffd6676854306d90ff5b31a
Author: Daniel Bankston
Date: Wed Jul 11 01:54:46 2012 -0500
Add test for volatile functions for ODS import
Change
sc/qa/unit/data/contentCSV/matrix2.csv |7 +--
sc/qa/unit/data/ods/matrix.ods |binary
sc/source/filter/xml/xmlcelli.cxx |3 ---
3 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 1651e7b7ff0f97bf738bf5b210e1c97e201627a1
Author: Daniel Bankston
Date
(-)
New commits:
commit 191c4bf8a6ee43bbac25f5a0f83181c74fac8390
Author: Daniel Bankston
Date: Sun Jul 8 12:57:36 2012 -0500
Fix problem with cached matrix formula results that contain errors
Change-Id: I9277714780e00e311e6e81a9de6e4d39409d5c9b
diff --git a/sc/source/filter/xml
insertions(+), 115 deletions(-)
New commits:
commit 9e639de0f9a7db8fb9cc48ca1e8036bb8f910811
Author: Daniel Bankston
Date: Sun Jul 8 11:26:52 2012 -0500
Use cached formula results for matrices
Change-Id: Ia77a94184c3d598f16a2f51d996f4c7058d9e303
diff --git a/sc/source/core/tool
sc/source/filter/xml/xmlcelli.cxx | 12 ++--
sc/source/ui/docshell/docsh.cxx |5 -
2 files changed, 14 insertions(+), 3 deletions(-)
New commits:
commit 7dd4d50687d7c94673e6d9f62b54054b1b817027
Author: Daniel Bankston
Date: Sat Jul 7 07:15:21 2012 -0500
Use indexOf
.cxx |2 -
11 files changed, 73 insertions(+), 16 deletions(-)
New commits:
commit c4bd67a09aff578be00e85c90cc056023387ca26
Author: Daniel Bankston
Date: Fri Jul 6 22:30:54 2012 -0500
Use text:p value if cached formula result is Err:### or #N/A
This should be removed
/docshell/docsh.cxx | 14 +-
7 files changed, 18 insertions(+), 21 deletions(-)
New commits:
commit 93319669a0c7892af96221bc1e832ba01c5e2d54
Author: Daniel Bankston
Date: Thu Jul 5 18:15:45 2012 -0500
Use cached formula results instead of recalculating
This commit
Sorry, I meant to also CC Kohei and mailing list.
I having trouble trying to think of a way to prevent ScFormulaCells from
being set dirty without my hackish ScDocument libreoffice-generated-doc
flag.
During the import of the functions.ods unit test file, ScFormulaCells are
set dirty at th
3, and it would
prevent me from adding my own ScDocument libreoffice-generated-doc flag.
What do you guys think?
Respectfully,
Daniel Bankston
#0 ScFormulaCell::SetDirtyVar (this=0x8ee6db8) at /home/dbank/code/git/libo_gsoc-calc-perf2/sc/source/core/data/cell.cxx:1833
#1 0xada3b635 i
On 07/03/2012 04:46 PM, Daniel Bankston wrote:
If an ScFormulaCell is set to dirty, it will be re-Interpreted
(recalculated). The goal is to avoid this during ODS import of a
LibreOffice generated document and instead use cached formula results
imported from the document itself to achieve
o see if callgrind will tell me anything with this test document.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
/filter/xml/xmlimprt.cxx | 12 --
sc/source/ui/docshell/docsh.cxx|2 -
7 files changed, 54 insertions(+), 45 deletions(-)
New commits:
commit 7a0fba0b0225f59f8c38b245cb21b81750271e26
Author: Daniel Bankston
Date: Tue Jul 3 03:06:29 2012 -0500
Use imported formula results
On 06/29/2012 11:20 AM, Daniel Bankston wrote:
While there were no bugzilla bugs directly related to ODS import
performance, Markus did find
https://bugs.freedesktop.org/show_bug.cgi?id=47106 which is about
performance while calc is already running, and may be closely related
to our
On 06/29/2012 10:47 AM, Kohei Yoshida wrote:
Not knowing what you are working on at the moment (sorry, been away
for far too long), it could be your next task if you don't have
anything else more urgent.
The last thing I worked on was avoiding recalculating row heights during
ODS import and in
On 06/29/2012 10:39 AM, Kohei Yoshida wrote:
That said, doing what Eike suggests will be a good intermediate step
even if we decide to prompt the user in the end.
So does that mean this is my next task? :-)
--Daniel
___
LibreOffice mailing list
Libr
unnecessarily recalculating formula results
even though we have imported formula results at our disposal?
Respectfully,
Daniel Bankston
#0 ScInterpreter::Interpret (this=0x19aca60) at /home/dbank/code/git/libo/libo_gsoc-calc_perf2_cg/sc/source/core/tool/interpr4.cxx:3712
#1 0x7fffde699d0f in
fully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
:
commit a2abf16d605b9e4b4437124a08fc312e81ae33af
Author: Daniel Bankston
Date: Mon Jun 25 01:21:26 2012 -0500
Stop calculating row heights and instead use imported row heights only
Change-Id: I1a5e33c292fb915e61511efbdb9ce4a0cfd7265f
diff --git a/sc/source/filter/xml/xmlimprt.cxx
b
d out, I can truly test the changes I made that use
the imported row heights. After that, I can see about handling the
cases where there is no row height to import. (In such a case, should we
calculate the row height or use a default row height?)
Respectfully,
Daniel Ban
sc/qa/unit/subsequent_filters-test.cxx | 87 +
1 file changed, 36 insertions(+), 51 deletions(-)
New commits:
commit a2a99a169f5395f41a9ee7f75dd4856ea42a5ee5
Author: Daniel Bankston
Date: Thu Jun 21 00:32:19 2012 -0500
Change sc subseq unit tests to use
On 06/20/2012 02:04 PM, Joel Madero wrote:
Thanks I'll look through those links. One thing I noticed on the wiki
is that it says to do this:
cd /opt/libreoffice/program
when I install from source it never installs there so I was confused
for a second (or two). I think maybe updating the wiki
On 06/20/2012 01:45 PM, Daniel Bankston wrote:
Also take a lot at this about gdb and libo if you haven't already:
https://wiki.documentfoundation.org/Development/How_to_debug
Take a "look". :-)
___
LibreOffice mailing l
On 06/20/2012 01:42 PM, Daniel Bankston wrote:
On 06/20/2012 12:55 PM, Joel Madero wrote:
I think this is a basic question but how do I go about putting on
breakpoints and then how do I "use" the breakpoints to determine
things like what variables are being called on? This st
Thanks in advance, learning as I go.
Joel
Hi, Joel,
From RMS himself: http://www.unknownroad.com/rtfm/gdbtut/gdbbreak.html
Markus let me know about this handy cheat sheet:
http://darkdust.net/files/GDB%20Cheat%20Sheet.pdf
--Daniel Bankston
___
L
sc/source/filter/xml/xmlcelli.cxx | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
New commits:
commit cb1b6e89995196e3dc61dc46d3207d410058638e
Author: Daniel Bankston
Date: Tue Jun 19 16:42:54 2012 -0500
Clean up logic a bit for formula cell ODS import
--
5 files changed, 40 insertions(+), 297 deletions(-)
New commits:
commit 74dd823ebdc6910529f5b916780ace49121c04ea
Author: Daniel Bankston
Date: Mon Jun 18 16:04:36 2012 -0500
Use better variable and method names for ScMyTables current cell position
Change-Id
On 06/18/2012 10:12 AM, Joel Madero wrote:
Thanks for the heads up. Marking bug as RESOLVED. Hopefully can get
some higher priority things patched soon. Not going to lie, I was
excited for my first patch, wife didn't understand ;)
Joel
Congrats :-)
/filter/xml/xmltabi.hxx |4 -
6 files changed, 75 insertions(+), 141 deletions(-)
New commits:
commit 8d4d75c7d67832c65472d48637d1a200682c4d5f
Author: Daniel Bankston
Date: Sat Jun 16 04:42:05 2012 -0500
Remove subtable import code since sc core doesn't support it
Chan
sc/source/filter/xml/xmlcelli.cxx | 297 +-
sc/source/filter/xml/xmlcelli.hxx |7
2 files changed, 141 insertions(+), 163 deletions(-)
New commits:
commit 3da9e8832632c4d7123e1e3f326eec2c1ab4f27b
Author: Daniel Bankston
Date: Fri Jun 15 01:08:05 2012
sc/qa/unit/data/ods/formats.ods|binary
sc/qa/unit/subsequent_filters-test.cxx | 23 ++-
2 files changed, 22 insertions(+), 1 deletion(-)
New commits:
commit c2601d8c5f1736d72966f57090a9729988390d29
Author: Daniel Bankston
Date: Wed Jun 13 17:51:58 2012 -0500
On 06/14/2012 07:03 AM, Daniel Bankston wrote:
So it seems either I should make the import conditionally use my
OUString replacement for simple text and XTextCursor
withXMLParaContext for complicated text, or I should abandon it all
together for now. Do you think it would be worth it to
cMyTables and see if I can convert the use of the
XShape interface.
Also there is the use of XAttributeList, but I think that is too deeply
ingrained throughout all import.
So what do you think is the highest priority right now?
Respectfu
some code from
validate.cxx, Markus was the one that was working in this area
directly. So Markus would be the one to check with. Regardless, I
think that I would be ok just to send the patch to the mailing list, and
we can take a look.
Respectfully,
Daniel Ban
On 06/12/2012 03:23 PM, Joel Madero wrote:
Hi All,
Wondering if the behavior of opengrok is what is expected. My issue is
that when I click on a variable name it takes me to the search page of
opengrok and puts in the name as the description instead of as a full
search. This rarely (actually n
think perhaps this was a work in progress for Markus? I just
wanted to bring it to both of your attention to avoid unnecessary
problems and confusion. Then again maybe you have already communicated
about it?
Respectfully,
Daniel Bankston
___
LibreO
Check this out: http://cgit.freedesktop.org/libreoffice/core/refs/tags.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
end of school semester work. Ever since I remembered it, it's been
bothering me, so I'd like to at least finish the database ranges at some
point. (And whatever else you think should fall under this easyhack.)
Very respectfully,
Daniel Bankston
>From 51b83940b602f75800ed0e80216
kend and, Kohei, enjoy your vacation!
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
++-
sc/source/filter/xml/xmlcelli.hxx| 12 -
6 files changed, 311 insertions(+), 122 deletions(-)
New commits:
commit 8a7fce7e9f522c44d4207eef4becbd32a8148719
Author: Daniel Bankston
Date: Sat Jun 9 06:53:23 2012 -0500
Remove unused variables and parameters
. This is
part of what open source is all about, right? We look out for each
other. Didn't someone once say something along the lines, "given enough
eyeballs, all bugs are shallow"? :-)
Respectfully,
Daniel Bankston
___
LibreOffice
On 06/08/2012 01:14 AM, David Ostrovsky wrote:
Hi Daniel,
trying to send it to once time again.
Regards
David
Looks good to me, but please let someone else concur (preferably one of
the calc gurus).
Respectfully,
Daniel Bankston
___
LibreOffice
Regardless, I defer to Markus's comments.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On 06/08/2012 12:24 AM, Joel Madero wrote:
Thanks for pointing that out, correction:
https://bugs.freedesktop.org/show_bug.cgi?id=43192
On Thu, Jun 7, 2012 at 10:20 PM, Daniel Bankston
<mailto:daniel.dev.libreoff...@gmail.com>> wrote:
On 06/07/2012 10:58 PM, Joel Mad
Thanks all,
Joel
Hi, Joel,
Maybe I misunderstand, but I think you accidentally linked the wrong bug
report.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
bViewShell::UpdateNumberFormatter was forgotten.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
spectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
|6 +---
sc/source/filter/xml/xmlrowi.cxx |4 +--
6 files changed, 36 insertions(+), 24 deletions(-)
New commits:
commit 870bccb97838e175febf22b8103503097c59bf58
Author: Daniel Bankston
Date: Tue Jun 5 21:30:25 2012 -0500
Fix repeating columns
deletions(-)
New commits:
commit b91e54a89586717fef49531d9626fbd2c75cf24e
Author: Daniel Bankston
Date: Tue Jun 5 02:17:07 2012 -0500
Replace CellAddress with ScAddress in ScXMLTableRowCellContext::EndElement()
Replaced CellAddress with ScAddress in EndElement() and adjusted related
06/01/2012 02:56 AM, Daniel Bankston wrote:
I think most of the other methods will follow fine from there except
for GetCurrentXDrawPage() and GetCurrentXShapes() which are separate
from the merge method concern. These methods get into things like
xmloff's XMLShapeImportHelper. Do we
sc/source/filter/xml/xmlsubti.cxx | 187 --
sc/source/filter/xml/xmlsubti.hxx |7 -
2 files changed, 2 insertions(+), 192 deletions(-)
New commits:
commit 5d757936fa06330f0abfd4a0c77521b7d4f5f7b4
Author: Daniel Bankston
Date: Mon Jun 4 11:11:00 2012
On 06/01/2012 02:56 AM, Daniel Bankston wrote:
I think before I can move forward, I need to know what to do about
ScMyTables::IsMerged(), ScMyTables::DoMerge(), and
ScMyTables::UnMerge(). ScMyTables references its own merge methods,
but I'm not sure what would cause these methods
eexamine
ScMyTables::SetTableStyle() at some point.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
deletions(-)
New commits:
commit 9e62caee992f9c352f1a8e7ea6772ae998fd309a
Author: Daniel Bankston
Date: Fri Jun 1 00:52:51 2012 -0500
Convert GetRealCellPos and calls to use ScAddress
Change-Id: Ic7a6ad82b5b4938ef67ddf8e62372635044cd5b2
diff --git a/sc/source/filter/xml
in print preview mode even
less so.
I personally can't ever remember having the desire to load or save a
document while in print preview nor can I fathom a reason to do so.
Respectfully,
Daniel Bankston
___
LibreOffice mailing list
LibreO
On 05/26/2012 10:22 AM, Markus Mohrhard wrote:
Hey Daniel,
2012/5/26 Daniel Bankston:
Hi, Kohei and Markus,
I pushed my changes to ScXMLTableRowCellContext::DoMerge() where I have
removed the ScDocFunc layer and simplified the whole method in general.
Great. I will have a look at it on
On 05/26/2012 10:58 AM, Michael Meeks wrote:
On Sat, 2012-05-26 at 17:24 +0200, Markus Mohrhard wrote:
That is not planned. Only during import all the code in ScDocFunc does
not make much sense. We neither need to repaint areas nor do we need
undo/redo code.
Cool - yes, it's a nonsense
ccessfully compile and pass sc unit
tests. Also, when I manually run calc and open a spreadsheet with
merged cells, I see that the file is imported correctly.
Can you see anything that I might have missed or incorrectly removed?
Thanks.
Respectfully,
Danie
sc/source/filter/xml/xmlcelli.cxx | 71 --
sc/source/filter/xml/xmlcelli.hxx |1
2 files changed, 8 insertions(+), 64 deletions(-)
New commits:
commit c827d7b23bdccc1adfb8b44ec04ea2b6503d57f5
Author: Daniel Bankston
Date: Sat May 26 02:54:41 2012
sc/source/filter/xml/xmlsubti.cxx |3 ---
1 file changed, 3 deletions(-)
New commits:
commit 0aa62e9e29e3db9f479c8662b5c606ed8386df11
Author: Daniel Bankston
Date: Fri May 25 21:39:24 2012 -0500
Remove header includes that are no longer used.
Change-Id
sc/source/filter/xml/xmlsubti.cxx | 26 +++---
1 file changed, 15 insertions(+), 11 deletions(-)
New commits:
commit 89a6f4d896a591273b555b72886d1e5ab1516eb9
Author: Daniel Bankston
Date: Fri May 25 21:07:41 2012 -0500
Remove ScDocFunc layer on ODS import for
14be196c746fe307ddc7b4abbedf00df62c7dcac
Author: Daniel Bankston
Date: Fri May 25 17:22:21 2012 -0500
Remove unnecessary code in ODS import for matrix and merge
MyScTables matrix methods and ScXMLTableRowCellContext merge methods used
getCellRangePosition() (that was adopted from ScCellRangeObj) which contains
Author: Daniel Bankston
Date: Fri May 25 02:36:28 2012 -0500
Convert ScMyTables matrix methods to use direct Sc calls
Change-Id: I345d938b80e5c68f9db20cf032fed9966df44936
diff --git a/sc/source/filter/xml/xmlcelli.cxx
b/sc/source/filter/xml/xmlcelli.cxx
index 89bf499..e7e0bf4 100644
sc/source/filter/xml/xmlcelli.cxx | 119 +-
sc/source/filter/xml/xmlsubti.cxx |3
sc/source/filter/xml/xmlsubti.hxx |2
3 files changed, 56 insertions(+), 68 deletions(-)
New commits:
commit 1ddcc44190a690a3ac221a8c4b38d830046f03ef
Author: Daniel
b249c549b57e56f2f5aba69dce4a139107fbbaa7
Author: Daniel Bankston
Date: Thu May 24 06:05:15 2012 -0500
Convert ODS import merge methods to use direct Sc calls
During ODS import, ScXMLTableRowCellContext::DoMerge() and
ScXMLTableRowCellContext::IsMerged() are used to handle merged cells
On 05/11/2012 05:15 PM, Kohei Yoshida wrote:
Hi there,
I just did a quick comparison of the load time of one large-ish xlsx
document that contains a bunch of number and string cells just to see
how much difference Daniel's initial changes have made. Here is the
result: on the latest master bran
sc/source/filter/oox/worksheethelper.cxx | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
New commits:
commit 09c095bbc9dd44d9dc46e09d6fd75d56edda42d8
Author: Daniel Bankston
Date: Fri May 11 12:04:14 2012 -0500
Replace extra XFormulaTokens call with direct ScDocument
sc/source/filter/oox/worksheethelper.cxx | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
New commits:
commit f356710356a7bc8b524ef12c862777fb8ee17782
Author: Daniel Bankston
Date: Fri May 11 10:37:44 2012 -0500
Get cell instance once and use c++style cast
sc/source/filter/oox/worksheethelper.cxx | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
New commits:
commit 1ef72f5bf48516113b0f3b25e52d124229a792b2
Author: Daniel Bankston
Date: Thu May 10 17:12:09 2012 -0500
Removed sneaky evil tabs.
Change-Id
sc/source/filter/oox/worksheethelper.cxx |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
New commits:
commit 3248f6f3a304279f0bd1daf798aef7e614589520
Author: Daniel Bankston
Date: Thu May 10 15:56:59 2012 -0500
Remove extra XText call and pass string directly to ScDocument
1 - 100 of 117 matches
Mail list logo
