On Mon, Apr 23, 2012 at 2:39 PM, Stephan Bergmann wrote:
> Only 0002-WaE-Clang-unused-variable.patch and
> 0003-WaE-Clang-unused-variable.patch I did not push. Can you change them as
> I suggested above (or just let me know if you want me to do that)?
I attached updated patches which use SAL_WAR
On Mon, Apr 23, 2012 at 2:39 PM, Stephan Bergmann wrote:
> Pushed most of these now:
> 0001-WaE-Clang-empty-forloop-body.patch: trivially fixed tabs to spaces
Sorry for that, the file doesn't have mode declarations for Emacs like
they usually do, probably because it's a ll file.
> 0005-WaE-Clang
I tried to build with Clang and --enable-werror to see if that finds
any bugs. Attached are results so far; there is still quite some to
compile and Clang also consistently crashes on a file.
All this is with self compiled Clang from trunk revision 152134 from 6
March 2012.
Only patch 6 solves a
On Fri, Mar 23, 2012 at 9:00 AM, Stephan Bergmann wrote:
> That looks like a compiler error. Have you tried with a plain
> (non-OpenSUSE) GCC 4.6.2, too? (What's also odd is the mention of
> "lockbyte.css" -- is that a typo of yours, or is that a temporary file that
> specific compiler generates
is. I think
GCC only does the analysis to warn about uninitialized variables when
compiled with optimization, but still: am I the only one with this GCC
version that compiled with optimization and --enable-werror?
From 78d778a79cfe2292d03ac30bee825147cc56ead9 Mon Sep 17 00:00:00 2001
From: Catalin
I was wondering why Emacs inserts tabs instead of spaces when changing
sal.py. See attached patch for the reason :-)
From d9e2eec409178263456574db015652497c9475ce Mon Sep 17 00:00:00 2001
From: Catalin Iacob
Date: Wed, 7 Mar 2012 23:01:05 +0100
Subject: [PATCH] Don't use Makefile Emacs mod
but osl_FileStatus_Mask_FileURL was not set when
retrieving it so the file url is invalid
Similarly, for $6 osl_FileStatus_Mask_FileURL is not set but
osl_FileStatus_Mask_FileURL is therefore the link target is valid and
can be printed
From 3f11d4862254238ee39fcc64ef53e8d12e431cd5 Mon Sep 17 00:00:
On Thu, Feb 23, 2012 at 1:59 PM, Michael Meeks wrote:
> Yep - looks good to me - thanks for that :-) any chance you can commit
> and send the results of 'git format-patch -1 HEAD' ?
I did commit and use format-patch, in fact the "It's safe to remove
the check..." was the part of the commit
It's safe to remove the check since CreateCell is only called by
CreateContentAction, CreateGeneratedActions and SetDependencies in the
same file and those in turn are only called by CreateChangeTrack only
if pDoc is not NULL.
---
.../filter/xml/XMLChangeTrackingImportHelper.cxx | 33
On Mon, Feb 13, 2012 at 4:37 PM, Michael Meeks wrote:
All my future contributions to LibreOffice are licensed under LGPLv3+ / MPL.
I'll also add myself to the wiki.
> So it sounds like you did an excellent job; what's next ? an easy hack
> perhaps ? or more unused code ? :-)
It would be
---
unusedcode.easy |3 ---
xmloff/inc/xmloff/txtimp.hxx |7 ---
xmloff/source/text/txtimp.cxx | 36
3 files changed, 0 insertions(+), 46 deletions(-)
diff --git a/unusedcode.easy b/unusedcode.easy
index db9233b..60da3ef 100644
---
---
unusedcode.easy|3 -
xmlsecurity/source/helper/xsecctl.cxx | 64
xmlsecurity/source/helper/xsecctl.hxx | 10 -
xmlsecurity/source/helper/xsecsign.cxx | 30 ---
4 files changed, 0 insertions(+), 107 deletions(-
---
unusedcode.easy|6 ---
xmlsecurity/inc/xmlsecurity/xmlsignaturehelper.hxx | 11 -
xmlsecurity/source/helper/xmlsignaturehelper.cxx | 47
3 files changed, 0 insertions(+), 64 deletions(-)
diff --git a/unusedcode.easy b/unus
searched: .c .cpp .cc .cxx .m .hpp .hh .h .hxx. How sure can I be that
this covers all their possible uses in LibreOffice code base? Could
it be that some Java code is calling those methods via JNI for
example?
Thanks!
[1] https://bitbucket.org/eliben/pss/overview
[2] http://betterthangrep.com/
Catalin
14 matches
Mail list logo
