[PATCH] more fix for fdo#62399

2013-03-31 Thread Faisal al-otaibi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3145 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/3145/1 more fix for fdo#62399 this will fix the border position, when the borders from the same side are different in c

[Libreoffice-commits] core.git: expat/StaticLibrary_expat.mk openssl/ExternalProject_openssl.mk

2013-03-31 Thread Peter Foley
expat/StaticLibrary_expat.mk |1 + openssl/ExternalProject_openssl.mk |3 --- 2 files changed, 1 insertion(+), 3 deletions(-) New commits: commit 9ff0ee4905068cbc85acf85da1b3ef762b324ed7 Author: Peter Foley Date: Sun Mar 31 16:41:05 2013 -0400 fix gold warning about hidden s

[PUSHED] Use local utility functions instead of SbxSimpleCharClass

2013-03-31 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3132 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3132 To unsubscribe, vi

[Libreoffice-commits] core.git: basic/source

2013-03-31 Thread Arnaud Versini
basic/source/sbx/sbxexec.cxx | 58 +++ 1 file changed, 26 insertions(+), 32 deletions(-) New commits: commit bb52f5b2bf6613a18d6c035058bc2a049a9da7bc Author: Arnaud Versini Date: Sun Mar 31 11:49:01 2013 +0200 Use local utility functions instead o

Contribution

2013-03-31 Thread Giacomo Picchiarelli
All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license -- Giacomo Picchiarelli ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PATCH] Comment translation GER-ENG in sw/source/ui/utlui/ (Part 3)

2013-03-31 Thread Matthias Freund (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3144 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/3144/1 Comment translation GER-ENG in sw/source/ui/utlui/ (Part 3) Change-Id: I33a96565553a78e30f4d6af0b4b92371188d053e

Objective-C / Cocoa - NSMenu - FirstResponder key bindings

2013-03-31 Thread V Stuart Foote
We have a group of LibreOffice Bugs in the OS X builds related to keyboard accelerators (-A, -C, -V): fdo#49853 fdo#55914 fdo#60790 f

[PATCH] vcl: convert some fprintf to SAL_INFO

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3143 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/3143/1 vcl: convert some fprintf to SAL_INFO Change-Id: I4b9a20e62e8e137a1bfaa1c654307f15c33e3d3c --- M sal/inc/sal/log

[PATCH] fdo#38838 : Replacement of String with OUString in core/char...

2013-03-31 Thread Prashant Pandey (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3142 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/42/3142/1 fdo#38838 : Replacement of String with OUString in core/chart2 Change-Id: I7abf9649a0c5997cebfe3463ce9b633ab59bf

[Libreoffice-commits] core.git: dbaccess/source

2013-03-31 Thread Julien Nabet
dbaccess/source/ui/dlg/indexdialog.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5ed1dbb51a4393be4ee1587f5ded103515139e9a Author: Julien Nabet Date: Sun Mar 31 22:23:32 2013 +0200 coverity#735355: Operands don't affect result Change-Id: I772d353

[PATCH] coverity#704129: Operands don't affect result

2013-03-31 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3141 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/41/3141/1 coverity#704129: Operands don't affect result Change-Id: I6faf86c3a41296ba4a267a58d7d0814e526b85a8 --- M sw/sour

[Libreoffice-commits] core.git: l10ntools/source

2013-03-31 Thread Zolnai Tamás
l10ntools/source/cfgmerge.cxx | 59 +- l10ntools/source/helper.cxx |3 ++ 2 files changed, 5 insertions(+), 57 deletions(-) New commits: commit c4745302f3bf6e9d4f94033391979deb8437c788 Author: Zolnai Tamás Date: Sun Mar 31 22:10:05 2013 +0200

Re: Google Summer of Code

2013-03-31 Thread Markus Mohrhard
Hey, 2013/3/31 Pratyush Nalam > Hi > > ** ** > > I am Pratyush Nalam, an undergraduate sophomore from IIT Bombay, India. I > want to participate in Google Summer of Code with LibreOffice and I was > going through the FAQs and the wiki. Stupid as this may sound, I didn’t > find anywhere how

Google Summer of Code

2013-03-31 Thread Pratyush Nalam
Hi I am Pratyush Nalam, an undergraduate sophomore from IIT Bombay, India. I want to participate in Google Summer of Code with LibreOffice and I was going through the FAQs and the wiki. Stupid as this may sound, I didn't find anywhere how to get a copy of the code so that I can start on one of th

Re: [PUSHED] [PATCH] vincent: fix the spell error: change "unkown" to "unknown"

2013-03-31 Thread vincent
thanks Thomas, I am trying to get familar with gerrit. Thanks for helping me the code-review. I am new to libreoffice and a GSOC appliant for the idea: Implement a "about:config" functionality thanks vincent From: Thomas Arnhold Date: 2013-03-30 17:45 To: vincentgsoc2013 CC: libreoffice

[PUSHED] Remove commented code in odk/examples

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3138 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3138 To unsubscribe, vis

[Libreoffice-commits] core.git: 3 commits - odk/examples

2013-03-31 Thread Chr . Rossmanith
odk/examples/cpp/counter/counter.cxx | 36 --- odk/examples/java/Inspector/SourceCodeGenerator.java | 10 - 2 files changed, 1 insertion(+), 45 deletions(-) New commits: commit d7a301476dfbec6a70e45808602838078bad780a Author: Chr. Rossmanith Date: Sun Ma

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread Thomas Arnhold
On 31.03.2013 15:49, Regina Henschel wrote: Draw a sphere from the set of predefined 3D-objects and set the line style to continues to see the segments. Set "Segments Vertical" to 8 to see, which part of the drawing is affected by "Vertical". In Version 4.0.1.2 (Build ID: 84102822e3d61eb989ddd32

[PATCH] Remove commented code in odk/examples

2013-03-31 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3138 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/38/3138/1 Remove commented code in odk/examples Change-Id: I8b28729d3cc632426efac02028f0d0e332243012 --- M odk/examples/cp

[Libreoffice-commits] core.git: odk/examples

2013-03-31 Thread Chr . Rossmanith
odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.h |4 ++-- odk/examples/cpp/counter/counter.cxx|6 +++--- odk/examples/java/Inspector/SourceCodeGenerator.java|4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 14d9096

[Libreoffice-commits] core.git: 6 commits - instsetoo_native/util Makefile.in odk/Zip_odkcommon.mk odk/Zip_odkexamples.mk solenv/gbuild

2013-03-31 Thread David Tardon
Makefile.in |3 +- instsetoo_native/util/openoffice.lst.in |4 +-- odk/Zip_odkcommon.mk| 12 -- odk/Zip_odkexamples.mk | 11 - solenv/gbuild/AllLangResTarget.mk |9 +-- solenv/gbuild/Componen

[Libreoffice-commits] core.git: l10ntools/Executable_cfgex.mk l10ntools/Executable_localize.mk l10ntools/Executable_propex.mk l10ntools/Executable_stringex.mk l10ntools/Executable_transex3.mk l10ntool

2013-03-31 Thread Zolnai Tamás
l10ntools/Executable_cfgex.mk |3 l10ntools/Executable_localize.mk |2 l10ntools/Executable_propex.mk |2 l10ntools/Executable_stringex.mk |3 l10ntools/Executable_transex3.mk |3 l10ntools/Executable_treex.mk |3 l10ntools/Executable_uiex.mk

[ABANDONED] coverity#983561: Arguments in wrong order

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#983561: Arguments in wrong order .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/3126 To unsubscribe, visit https://gerrit.libreoffice

[ABANDONED] coverity#704245 Logically dead code

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704245 Logically dead code .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2949 To unsubscribe, visit https://gerrit.libreoffice.org/s

[ABANDONED] coverity#704300 Logically dead code

2013-03-31 Thread Julien Nabet (via Code Review)
Julien Nabet has abandoned this change. Change subject: coverity#704300 Logically dead code .. Patch Set 1: Abandoned -- To view, visit https://gerrit.libreoffice.org/2976 To unsubscribe, visit https://gerrit.libreoffice.org/s

[Libreoffice-commits] dictionaries.git: Dictionary_sr.mk

2013-03-31 Thread Andras Timar
Dictionary_sr.mk |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 66a5a2e03573ab1862db1965f7b9c5419db3decd Author: Andras Timar Date: Sun Mar 31 18:46:36 2013 +0200 fix Serbian dictionary makefile Change-Id: I49e678fc586c2352e9df805e8e32e64560514

[Libreoffice-commits] core.git: dictionaries

2013-03-31 Thread Andras Timar
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6ea8d4a55c3693d75da32af7e9a40a79bac99fa7 Author: Andras Timar Date: Sun Mar 31 18:46:36 2013 +0200 Updated core Project: dictionaries 66a5a2e03573ab1862db1965f7b9c5419db3decd diff --git a/dicti

[Libreoffice-commits] dictionaries.git: Branch 'libreoffice-4-0' - Dictionary_sr.mk

2013-03-31 Thread Andras Timar
Dictionary_sr.mk |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit ed5335630cc99820e55cf3808b09c7e1458f875f Author: Andras Timar Date: Sun Mar 31 18:46:36 2013 +0200 fix Serbian dictionary makefile Change-Id: I49e678fc586c2352e9df805e8e32e64560514

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - dictionaries

2013-03-31 Thread Andras Timar
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 809b61da30473a5bffc88a20ffd418bc0db486ca Author: Andras Timar Date: Sun Mar 31 18:46:36 2013 +0200 Updated core Project: dictionaries ed5335630cc99820e55cf3808b09c7e1458f875f diff --git a/dicti

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - dictionaries

2013-03-31 Thread Goran Rakic
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 382f094a067b8bd6dffc511ae3f6cdc0145c1868 Author: Goran Rakic Date: Sat Mar 30 02:17:19 2013 +0100 Updated core Project: dictionaries 590930ea3268158e9c185b24c212fec6fa5291aa diff --git a/dictio

[PUSHED] Comment translation GER-ENG in sw/source/ui/utlui/ PART2

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3129 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3129 To unsubscribe, vis

[Libreoffice-commits] core.git: sw/source

2013-03-31 Thread Matthias Freund
sw/source/ui/utlui/glbltree.cxx | 70 ++-- sw/source/ui/utlui/gloslst.cxx | 24 + sw/source/ui/utlui/initui.cxx | 23 - sw/source/ui/utlui/initui.hrc |2 - sw/source/ui/utlui/navicfg.cxx |2 - sw/source/ui/utlui/navipi

[PUSHED] Remove commented code in component.cxx (odk)

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3137 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3137 To unsubscribe, vis

[PUSHED] fdo#62096 Replace O(U)String compareTo with ==

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3136 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3136 To unsubscribe, vis

[Libreoffice-commits] core.git: odk/examples

2013-03-31 Thread Chr . Rossmanith
odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/component.cxx | 40 -- 1 file changed, 40 deletions(-) New commits: commit 7b0a2c0a6f1c671e1b7711752083a73aa905d18f Author: Chr. Rossmanith Date: Sat Mar 30 21:30:52 2013 +0100 Remove commented code in com

[Libreoffice-commits] core.git: framework/source

2013-03-31 Thread Efe Gürkan YALAMAN
framework/source/fwe/xml/toolboxdocumenthandler.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 52770659d33f8f08a769043392cfb5a926019fef Author: Efe Gürkan YALAMAN Date: Sun Mar 31 17:27:57 2013 +0300 fdo#62096 Replace O(U)String compareTo wit

[Libreoffice-commits] core.git: 5 commits - Library_merged.mk sal/osl sfx2/source solenv/gbuild vcl/unx

2013-03-31 Thread Peter Foley
Library_merged.mk |3 --- sal/osl/unx/module.cxx |2 +- sfx2/source/appl/appinit.cxx |6 +- solenv/gbuild/AllLangResTarget.mk |2 +- solenv/gbuild/LinkTarget.mk|2 +- sol

[PATCH] Remove commented code in component.cxx (odk)

2013-03-31 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3137 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/37/3137/1 Remove commented code in component.cxx (odk) Change-Id: I559b91d465ab298b033b0866b3044a17038cc501 --- M odk/exa

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread Regina Henschel
Hi, convert to 3D rotation object has the wrong left-right orientation too. Has something else bee changed in version 4.1? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/

[Libreoffice-commits] core.git: odk/examples

2013-03-31 Thread Chr . Rossmanith
odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/addon.cxx |6 +++--- odk/examples/DevelopersGuide/Components/Addons/ProtocolHandlerAddon_cpp/component.cxx |2 +- odk/examples/DevelopersGuide/Components/CppComponent/service1_impl.cxx

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - c1/e8fbb282a2e17b5f358e856e0c950af3093df1

2013-03-31 Thread Xisco Fauli
c1/e8fbb282a2e17b5f358e856e0c950af3093df1 |1 + 1 file changed, 1 insertion(+) New commits: commit 1d2edcaa2d3c3577fbb9d110273663b24ea5cc67 Author: Xisco Fauli Date: Sun Mar 31 16:41:17 2013 +0200 Notes added by 'git notes add' diff --git a/c1/e8fbb282a2e17b5f358e856e0c950af3093df1

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 47/8b3a28a282e9525b8164b743b7503974259546

2013-03-31 Thread Xisco Fauli
47/8b3a28a282e9525b8164b743b7503974259546 |1 + 1 file changed, 1 insertion(+) New commits: commit 79261539432002f22e83cefd66892c481276a88d Author: Xisco Fauli Date: Sun Mar 31 16:39:36 2013 +0200 Notes added by 'git notes add' diff --git a/47/8b3a28a282e9525b8164b743b7503974259546

[PATCH] fdo#62096 Replace O(U)String compareTo with ==

2013-03-31 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3136 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/36/3136/1 fdo#62096 Replace O(U)String compareTo with == Change-Id: Id89b7eeb09b5cd7cee449cd1a20fb13b630f29c4 --- M framew

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 42/e6ec353f68123486ea72d5f3c7a9f447d5e58b

2013-03-31 Thread Xisco Fauli
42/e6ec353f68123486ea72d5f3c7a9f447d5e58b |1 + 1 file changed, 1 insertion(+) New commits: commit 6d6b38713f9fba90a41916ff46fa51f4d5ef2ac2 Author: Xisco Fauli Date: Sun Mar 31 16:38:12 2013 +0200 Notes added by 'git notes add' diff --git a/42/e6ec353f68123486ea72d5f3c7a9f447d5e58b

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 18/9fe5d0857f429b031aa6fc32949f5d4638bac7

2013-03-31 Thread Xisco Fauli
18/9fe5d0857f429b031aa6fc32949f5d4638bac7 |1 + 1 file changed, 1 insertion(+) New commits: commit 5885edb08299d9eb707643b8f5784e1f41eed114 Author: Xisco Fauli Date: Sun Mar 31 16:36:41 2013 +0200 Notes added by 'git notes add' diff --git a/18/9fe5d0857f429b031aa6fc32949f5d4638bac7

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 81/17a318f8116ee37159c16cd35538bbe853f792

2013-03-31 Thread Xisco Fauli
81/17a318f8116ee37159c16cd35538bbe853f792 |1 + 1 file changed, 1 insertion(+) New commits: commit e4a012c38d45318dfa89436612118bf5db42beaa Author: Xisco Fauli Date: Sun Mar 31 16:34:46 2013 +0200 Notes added by 'git notes add' diff --git a/81/17a318f8116ee37159c16cd35538bbe853f792

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - eb/86e4a8ebcc8e105bd4950ed94c2e529320de4c

2013-03-31 Thread Xisco Fauli
eb/86e4a8ebcc8e105bd4950ed94c2e529320de4c |1 + 1 file changed, 1 insertion(+) New commits: commit 1e74279a1c1b4a4aa7b7ad56abe3d1242468e530 Author: Xisco Fauli Date: Sun Mar 31 16:33:34 2013 +0200 Notes added by 'git notes add' diff --git a/eb/86e4a8ebcc8e105bd4950ed94c2e529320de4c

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 45/fc638e2fcb644aa4df5b1a62c4ddccac111802

2013-03-31 Thread Xisco Fauli
45/fc638e2fcb644aa4df5b1a62c4ddccac111802 |1 + 1 file changed, 1 insertion(+) New commits: commit 17c66414a18d9468066e4144e9a38719d0ee8368 Author: Xisco Fauli Date: Sun Mar 31 16:32:21 2013 +0200 Notes added by 'git notes add' diff --git a/45/fc638e2fcb644aa4df5b1a62c4ddccac111802

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - 25/86f214e48d0d63bd5a83addd48a285ee38e92f

2013-03-31 Thread Xisco Fauli
25/86f214e48d0d63bd5a83addd48a285ee38e92f |1 + 1 file changed, 1 insertion(+) New commits: commit 388496ceb85683b1a09498d98751b1c90e467bce Author: Xisco Fauli Date: Sun Mar 31 16:29:30 2013 +0200 Notes added by 'git notes add' diff --git a/25/86f214e48d0d63bd5a83addd48a285ee38e92f

[Libreoffice-commits] core.git: Branch 'refs/notes/commits' - f1/fe15fd8cfc00fe9bb894783f9ffb228d12568d

2013-03-31 Thread Xisco Fauli
f1/fe15fd8cfc00fe9bb894783f9ffb228d12568d |1 + 1 file changed, 1 insertion(+) New commits: commit 1c2fc5fba7c3f58a619afbcfe18134ee3630264d Author: Xisco Fauli Date: Sun Mar 31 16:28:14 2013 +0200 Notes added by 'git notes add' diff --git a/f1/fe15fd8cfc00fe9bb894783f9ffb228d12568d

[Libreoffice-commits] core.git: 9 commits - filter/source oox/source sd/source svx/source sw/source

2013-03-31 Thread Armin Le Grand
filter/source/msfilter/escherex.cxx | 49 --- filter/source/msfilter/svdfppt.cxx |6 + oox/source/vml/vmlshapecontext.cxx | 35 +++- sd/source/filter/eppt/pptexanimations.cxx |2 sd/source/filter/p

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread Regina Henschel
Hi Arnold, Thomas Arnhold schrieb: Hi Regina, you're right, the other methods are using the order (fVer, fHor), like createUnitSpherePolyPolygon() does. So the definition is correct: inline B3DPoint getPointFromCartesian(double fVer, double fHor) But on the call side it's used like: aNew.app

Re: Build broken

2013-03-31 Thread Chris Sherlock
Ah... guess I should have thought of that :-) Chris On Sun, Mar 31, 2013 at 11:52 PM, Tor Lillqvist wrote: > make clean helps. (if you have the patience, you can do "make > foo.clean" for each module that depend on icu.) > > --tml ___ LibreOffice maili

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread Thomas Arnhold
Hi Regina, you're right, the other methods are using the order (fVer, fHor), like createUnitSpherePolyPolygon() does. So the definition is correct: inline B3DPoint getPointFromCartesian(double fVer, double fHor) But on the call side it's used like: aNew.append(getPointFromCartesian(fHor, fVe

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread Regina Henschel
Hi Julian, I put you in CC, because I don't know whether my post to the list needs moderation again. julien2412 schrieb: Hi Regina, I knew I was right to submit this patch for review and not push it directly :-) In fact, I just picked up a coverity report and took a look to Opengrok (see htt

[PUSHED] Multiple typo fixes, small code changes

2013-03-31 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3135 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3135 To unsubscribe, vis

Re: Build broken

2013-03-31 Thread Tor Lillqvist
make clean helps. (if you have the patience, you can do "make foo.clean" for each module that depend on icu.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice-commits] core.git: sw/source

2013-03-31 Thread Chris Sherlock
sw/source/core/access/acccontext.cxx |4 - sw/source/core/access/accframe.cxx | 58 +-- sw/source/core/access/accfrmobjmap.cxx |2 sw/source/core/access/accmap.cxx | 44 ++-- sw/source/core/access/accnotextfra

Build broken

2013-03-31 Thread Chris Sherlock
I folks, after the upgrade of icu, it appears that the build is breaking: /usr/bin/make -j 1 -rs -f /home/chris/repos/LibreOffice/core/Makefile.gbuild [build MOD] accessibility [build MOD] animations [build MOD] avmedia [build LNK] Executable/transex3 /home/chris/repos/LibreOffice/core/solver/unxl

[Libreoffice-commits] core.git: 2 commits - vcl/source

2013-03-31 Thread Tomaž Vajngerl
vcl/source/filter/jpeg/jpeg.cxx |3 +- vcl/source/filter/jpeg/jpeg.h |2 - vcl/source/filter/jpeg/jpeg.hxx |5 ++- vcl/source/filter/jpeg/jpegc.c | 60 ++-- 4 files changed, 34 insertions(+), 36 deletions(-) New commits: commit 2c04523b5bb8

[PATCH] Typo fixes, small code changes

2013-03-31 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3135 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/35/3135/1 Typo fixes, small code changes * Corrected spelling errors in comments * In accpara.cxx, SwAccessibleParagraph::

[PATCH] fdo#62470 fix the table format dialog reading

2013-03-31 Thread Faisal al-otaibi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3134 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/34/3134/1 fdo#62470 fix the table format dialog reading this will fix the wrong reading in table format borders dialog. C

[PATCH] fdo#62470 fix the input change when the table RTL

2013-03-31 Thread Faisal al-otaibi (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3133 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/33/3133/1 fdo#62470 fix the input change when the table RTL this fix the wrong borders changes when the table RTL. Change

[PUSHED] Serbian dictionary updated to 2013.03.30

2013-03-31 Thread Andras Timar (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3120 Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3120 To unsubscribe, visit

[Libreoffice-commits] core.git: dictionaries

2013-03-31 Thread Goran Rakic
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 47ebfd8381a11b8d544193783702d057a33a8c52 Author: Goran Rakic Date: Sat Mar 30 02:17:19 2013 +0100 Updated core Project: dictionaries 52f4aa133ba3d7703c4982a21e567fd92abcbfd0 Serbian dic

[PUSHED] Lightproof and Hunspell updates for pt-BR

2013-03-31 Thread Andras Timar (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3130 Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3130 To unsubscribe, visit

[Libreoffice-commits] core.git: dictionaries

2013-03-31 Thread Olivier Hallot
dictionaries |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 89926510da746fb55720304503f586ff5e8b2663 Author: Olivier Hallot Date: Sat Mar 30 21:28:52 2013 -0300 Updated core Project: dictionaries b128def79cc0520515ea99db4fb9f8cc3d95f54d Lightpro

Re: [PATCH] coverity#983561: Arguments in wrong order

2013-03-31 Thread julien2412
Hi Regina, I knew I was right to submit this patch for review and not push it directly :-) In fact, I just picked up a coverity report and took a look to Opengrok (see http://opengrok.libreoffice.org/search?q=getPointFromCartesian&project=core&defs=&refs=&path=&hist=). Ovbiously, I know nothing ab

[PUSHED] Correct typos in sw README

2013-03-31 Thread Andras Timar (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/3131 Approvals: Andras Timar: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/3131 To unsubscribe, visit

[PATCH] Use local utility functions instead of SbxSimpleCharClass

2013-03-31 Thread Arnaud Versini (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3132 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/32/3132/1 Use local utility functions instead of SbxSimpleCharClass Change-Id: I7c4bc8cc44c0b4e78feb55dcd2c15b82c414e0ef -

[Libreoffice-commits] core.git: sw/README

2013-03-31 Thread Chris Sherlock
sw/README |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 96942af2a8dd19a14ab3cfc4635e428bd257d320 Author: Chris Sherlock Date: Sun Mar 31 20:47:59 2013 +1100 Correct typos in sw README Change-Id: I61323685b33817a2641713455bac1a079687cb4d Reviewed

[PATCH] Correct typos in sw README

2013-03-31 Thread Chris Sherlock (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/3131 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/31/3131/1 Correct typos in sw README Change-Id: I61323685b33817a2641713455bac1a079687cb4d --- M sw/README 1 file changed,

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-03-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 53030, which changed state. Bug 53030 Summary: Calc deletes current sheet, not right-clicked on sheet when trying to delete opposite directionality sheets https://bugs.freedesktop.org/show_bug.cgi?id=53030 Wh

Trying to locate who/what fixed fdo#53030

2013-03-31 Thread Lior Kaplan
Hi, The good news is that fdo#53030 "Calc deletes current sheet, not right-clicked on sheet when trying to delete opposite directionality sheets" is fixed between 4.0.0 and 4.0.1, the problem is who/what fixed it (I'm just curious ...). Any help / references would be great. Kaplan __