[Libreoffice-commits] .: 2 commits - sfx2/source starmath/source

2013-01-13 Thread Libreoffice Gerrit user
sfx2/source/doc/objstor.cxx |8 +++- starmath/source/mathmlimport.cxx |6 +++--- 2 files changed, 6 insertions(+), 8 deletions(-) New commits: commit 56c4deae00e42719652b3f8cc3375180d7fd801e Author: Stephan Bergmann Date: Sat Jan 12 23:18:28 2013 +0100 -Werror,-Wtautologi

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2013-01-13 Thread Marc-André Laverdière
Quick question: is this code security-sensitive at all? I know that there has been some security issues related to one compiler (Microsoft's) that was optimizing away the memset in some cases. So the suggested workaround was a loop. Reference: Writing Secure Code. The other question is: Are we st

[Libreoffice-commits] .: 2 commits - cui/source editeng/inc editeng/source sax/inc sax/source svx/inc svx/source sw/Library_sw.mk sw/source unusedcode.easy vcl/source

2013-01-13 Thread Libreoffice Gerrit user
cui/source/inc/numpages.hxx |1 cui/source/tabpages/numpages.cxx|7 editeng/inc/editeng/editobj.hxx | 13 - editeng/source/editeng/editobj.cxx | 246 editeng/source/editeng/editobj2.hxx | 15 - sax/inc/sax/tools/c

[Libreoffice-commits] .: sw/source

2013-01-13 Thread Libreoffice Gerrit user
sw/source/ui/config/modcfg.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 2ab24c8f11d20892532da8601ff76f22e0a05a5b Author: Julien Nabet Date: Sun Jan 13 22:23:09 2013 +0100 Fix 2 scopes can be reduced Change-Id: Ieb216aff08307ca684e11dbd7f59d

[Libreoffice-commits] .: canvas/source unusedcode.easy

2013-01-13 Thread Libreoffice Gerrit user
canvas/source/cairo/cairo_textlayout.cxx |9 - canvas/source/cairo/cairo_textlayout.hxx |1 - unusedcode.easy |1 - 3 files changed, 11 deletions(-) New commits: commit 6086949c9e29339d097585137e571aa780c24257 Author: Julien Nabet Date: Sun Jan 13 2

[PATCH] Replace [Uni|Xub]String with OUString in vcl, svtools, toolkit

2013-01-13 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1667 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/67/1667/1 Replace [Uni|Xub]String with OUString in vcl,svtools,toolkit Change-Id: I9e6cd6cd6726a1377b46fea773fe5c16aa26ba7

[PATCH] Replace [Uni|Xub]String with OUString in vcl

2013-01-13 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1666 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/66/1666/1 Replace [Uni|Xub]String with OUString in vcl Change-Id: I7cbefa72010cc3e49a93db5b2cbf49cfb08061f7 --- M vcl/inc/

Re: About idlc/source/idlccompile.cxx

2013-01-13 Thread Ruslan Kabatsayev
Hi, On Sun, Jan 13, 2013 at 9:01 PM, julien2412 wrote: > Hello, > > Taking a look at this cppcheck report: > dlc/source/idlccompile.cxx > 198 nullPointer error Possible null pointer dereference: source - > otherwise > it is redundant to check it against null. Looks like a false-positi

Re: [ANN] LibreOffice 4.0.0.1 RC1 available

2013-01-13 Thread Rainer Bielefeld
Hi all, I hoped to be able to do lots of tests with 4.0.0.1, but I see a horrible number of crashes under WIN without any common characteristic, I can't use this version furthermore for anything similar to normal work. Any chance that someone suffering from similar problems can contribute Cr

About idlc/source/idlccompile.cxx

2013-01-13 Thread julien2412
Hello, Taking a look at this cppcheck report: dlc/source/idlccompile.cxx 198 nullPointer error Possible null pointer dereference: source - otherwise it is redundant to check it against null. I don't understand the function "sal_Bool copyFile(const OString* source, const OString& target

Stepping back from The Document Foundation

2013-01-13 Thread Florian Monfort
Hi all, I've decided recently that I would stop watching Document Foundation activities. Indeed I've found myself completely overloaded with work from School and Red Hat, so I cannot properly contribute. I must also admit that this decisions comes with a reflection I make myself more and more: I

[REVIEW for 4.0 and 3.6] Missing parenthesis in ucb/source/ucp/file/bc.cxx

2013-01-13 Thread julien2412
Hello, Cppcheck detected this: ucb/source/ucp/file/bc.cxx 1175clarifyConditionstyle Boolean result is used in bitwise operation. Clarify expression with parentheses 1173 // Inserts the content, which has the flag m_bIsFresh 1174 1175 if( ! m_nState & NameForInserti

[Libreoffice-commits] .: ucb/source

2013-01-13 Thread Libreoffice Gerrit user
ucb/source/ucp/file/bc.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a2dd3feaea16a765956aecacdd6cc21ab5404a5b Author: Julien Nabet Date: Sun Jan 13 15:52:23 2013 +0100 Add missing parenthesis Like this since 29/06/2001 (5ef2de612d973bc747ff4a107

[Bug 44446] LibreOffice 3.6 most annoying bugs

2013-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Mihkel Tõnnov changed: What|Removed |Added Depends on||58283 --- Comment #195 from Mihkel Tõnno

[PATCH] Modify constructor, remove setters + unused define

2013-01-13 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1665 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/65/1665/1 Modify constructor, remove setters + unused define Change-Id: Ibf878c44ae761e59a04b6d5023296c5918cbf85e --- M sd

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Ruslan Kabatsayev changed: What|Removed |Added Depends on||58562 Blocks|58562

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Ruslan Kabatsayev changed: What|Removed |Added Blocks||58562 --- Comment #77 from Ruslan Ka

Re: [libreoffice-l10n] [ANN] LibreOffice 4.0.0 Beta2 available

2013-01-13 Thread Serg Bormant
Hi Stephan, thanks for your answer > FYI, mention of GnomeVFSContentProvider would also need to be removed from > the > /org.openoffice.ucb.Configuration/ContentProviders/Local/SecondaryKeys/Office/ProviderData > configuration list in the LO installation's share/registry/main.xcd. but as I can se