[PUSHED] Change in core[libreoffice-3-6]: Let's not return here to prevent memory leak.

2013-01-11 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1654 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1654 To unsubscribe, vi

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 0490372a127b03dde0397009758289e94862a662 Author: Kohei Yoshida Date: Fri Jan 11 12:51:13 2013 -0500 Let's not return here to prevent memory leak. There are several he

Re: Cppcheck reports

2013-01-11 Thread julien2412
Hi bfo, I don't have access to this ftp but if someone wants to do it, no problem for me :-) About regenerating once a while, since it takes some time to retrieve all these reports, I can propose about once by week. (each time with master sources + cppcheck git updated of course :-)) Julien --

[PATCH] Change in core[libreoffice-4-0]: make the list box a bit larger, fdo#58609

2013-01-11 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1660 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/60/1660/1 make the list box a bit larger, fdo#58609 Change-Id: I862ee7e20a7e534286785a12508a6442f78c --- M sc/source/u

[PATCH] Change in core[libreoffice-4-0]: fix icon set rendering information creation, fdo#58610

2013-01-11 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1661 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/61/1661/1 fix icon set rendering information creation, fdo#58610 Change-Id: Iad5dec601b54893ed809ab908671698919779ddb ---

[Libreoffice-commits] .: sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/src/condformatdlg.src |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit d928a8198a4ec9a45228b18bfb221195bdae6bbd Author: Markus Mohrhard Date: Sat Jan 12 07:31:03 2013 +0100 make the list box a bit larger, fdo#58609 Change-Id: I862ee

[Libreoffice-commits] .: 2 commits - sc/source vcl/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/core/data/colorscale.cxx |1 - sc/source/ui/condformat/condformatdlgentry.cxx |2 ++ vcl/source/window/split.cxx|2 +- 3 files changed, 3 insertions(+), 2 deletions(-) New commits: commit 0f6adf7a8cbccdb0a2697176a6e0e8cf58edd5fe Author: Markus

[Libreoffice-commits] .: basctl/source

2013-01-11 Thread Libreoffice Gerrit user
basctl/source/basicide/baside2b.cxx | 16 basctl/source/basicide/layout.cxx |5 +++-- basctl/source/basicide/linenumberwindow.cxx |3 ++- 3 files changed, 13 insertions(+), 11 deletions(-) New commits: commit 200e0c8d88fc68defebbd7b79fd4d1d2e1b9c6bd Au

[PATCH] Change in core[libreoffice-4-0]: fix a bunch of more crashes when setting personas

2013-01-11 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1659 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/59/1659/1 fix a bunch of more crashes when setting personas Change-Id: I6c2c398e074a41c3173bff57bc12496b4c2032b4 --- M bas

[Libreoffice-commits] .: sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 13d50871e328a640a5baa283cf669407738e8cdd Author: Kohei Yoshida Date: Sat Jan 12 00:30:49 2013 -0500 Maybe this will make the Windows tinderbox happy... Change-Id: I9e83

[PATCH] Change in core[libreoffice-4-0]: fix crash with new personas when notifying windows

2013-01-11 Thread Markus Mohrhard (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1658 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/58/1658/1 fix crash with new personas when notifying windows Change-Id: I41e4c747c4662fb066746c0ca87d17ea6742080e --- M vc

[Libreoffice-commits] .: 3 commits - comphelper/source sc/source vcl/source

2013-01-11 Thread Libreoffice Gerrit user
comphelper/source/container/embeddedobjectcontainer.cxx |2 +- sc/source/ui/src/scfuncs.src|2 +- vcl/source/window/split.cxx |6 +- 3 files changed, 7 insertions(+), 3 deletions(-) New commits: commit ab3c544633612a2079a918b

[Libreoffice-commits] .: sc/qa

2013-01-11 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) New commits: commit 16ab898a4139ab1743f68caec86aaa2fb2ba10e0 Author: Eike Rathke Date: Sat Jan 12 01:08:34 2013 +0100 at least use correct test data ... Change-Id: Icb5bb6110

[libreoffice-dev] - Scalc extension ported to accept data over socket

2013-01-11 Thread Rai, Neeraj
Hi All, I was able to extend the earlier simple extension using Scalc.java ported to C++ , with a lot of help from all of you. It now accepts data over socket from a standalone uno client (based on examples/cpp/remoteclient.cxx) I have used the osl::socket for communication. There is a macro sta

[ANN] LibreOffice 4.0.0 RC1 available

2013-01-11 Thread Thorsten Behrens
Dear Community, The Document Foundation is pleased to announce the first release candidate of our upcoming LibreOffice 4.0. The 4.0 will be our fifth major release in just over two years, and comes with a nice set of new features. Please be aware that LibreOffice 4.0 RC1 is not ready for productio

Re: [libreoffice-l10n] Translation of the names of the keys on Windows

2013-01-11 Thread Xuacu
Hi Since we have Asturian keyboard available under Linux, LibO Help is translated to match such translated keys, so no problem with that. Hopefully, somewhere in the future Asturian kb will be available as Unicode standard keyboard, which may ease i18n/l10n work. We are working on that, and perha

[Libreoffice-commits] .: sc/qa

2013-01-11 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit c34ca5c2a638476b76ae448b16a13358fd2be926 Author: Eike Rathke Date: Sat Jan 12 00:16:32 2013 +0100 make this compile with a not so recent code base Change-Id: I9b3f8ca9c5af326735f

Re: [libreoffice-l10n] Translation of the names of the keys on Windows

2013-01-11 Thread Xuacu
Hi! Based on spanish keyboard, I guess this is Asturian keyboard translation: static const struct KeysNameReplacement aImplReplacements_Asturian[] = { { KEY_BACK, "Retrocesu" }, { KEY_ENTER, "Intro" }, { KEY_SPACEBAR, "Espaciu" }, { KEY_HOME, "Aniciu" },

fdo#57950: More chained appends in dbaccess

2013-01-11 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#57950: More chained appends in dbaccess .. Patch Set 4: Abandoned Will send again. -- To view, visit https://gerrit.libreoffice.org/1564 To unsubscribe, visit https:

fdo#57950: Remove chained appends in dbaccess

2013-01-11 Thread Marcos Souza (via Code Review)
Marcos Souza has abandoned this change. Change subject: fdo#57950: Remove chained appends in dbaccess .. Patch Set 1: Abandoned I will send this again rebased, and aiehtout any oatch that depends on this. -- To view, visit ht

[Libreoffice-commits] .: sc/qa

2013-01-11 Thread Libreoffice Gerrit user
sc/qa/unit/ucalc.cxx | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) New commits: commit 1593c48768511472bf4038b8fe90d31aa2487e2c Author: Stephan Bergmann Date: Fri Jan 11 23:28:27 2013 +0100 Actually call testFuncIFERROR TODO: Commented out for

Re: Cppcheck reports

2013-01-11 Thread bfo
julien2412 wrote > Also, I uploaded detailed reports, I meant all files concerned by cppcheck > reports + index page with links on source files "htmlized" > You'll find it there: > http://serval2412.free.fr/cppcheck_reports.tar.bz2 > Just uncompress and browse Hi! Could this be placed at http://de

gifread.cxx: Netscape 2.0

2013-01-11 Thread Christina Roßmanith
Hi, during RTL_CONSTASCII... cleaning I came across this lines in vcl/source/filter/igif/gifread.cxx: if( (aAppId == "NETSCAPE") && (aAppCode == "2.0") && (cSize == 3) )... Will this condition ever be true? Christina ___ LibreOffice mailing list

[Libreoffice-commits] .: formula/source

2013-01-11 Thread Libreoffice Gerrit user
formula/source/core/resource/core_resource.src |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 3201c72db76fb1baabe9becf32e7788a88fe66ac Author: Eike Rathke Date: Fri Jan 11 21:47:25 2013 +0100 fdo#56124 IFERROR IFNA function names were swapped Cha

Cppcheck reports

2013-01-11 Thread julien2412
Hello, Since I build master sources and use cppcheck (C/C++ static analyzer) quite regularly, I thought someone could be interested by cppcheck reports. So, I updated today my master sources and launched cppcheck (git updated today) on the sources (except "sal" because of a freeze). Here the resul

[PUSHED] Resolves: fdo#58865 hard-coded LibreOffice strings

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1656 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1656 To unsubscribe, visi

[Libreoffice-commits] .: sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/docsh.cxx |4 +++- sc/source/ui/src/globstr.src|2 +- sc/source/ui/src/optdlg.src |2 +- 3 files changed, 5 insertions(+), 3 deletions(-) New commits: commit e610e5f28e4b2b774a897ee7cf6d8098ade30a7f Author: Caolán McNamara Date: Fri Jan 11 12:38:03 20

[PATCH] Change in core[libreoffice-4-0]: split out the ComboBox code that determines the positioning ...

2013-01-11 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1657 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/57/1657/1 split out the ComboBox code that determines the positioning of subwidgets and re-use it to get a better calculat

[PATCH] Resolves: fdo#58865 hard-coded LibreOffice strings

2013-01-11 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1656 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/56/1656/1 Resolves: fdo#58865 hard-coded LibreOffice strings Change-Id: Ie03106c3089f6d1bc0172a2e2c702b5725e55acf --- M sc

[Libreoffice-commits] .: sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 823ab0f98c81e68847b7a0e0667329c679b37f6c Author: Michael Stahl Date: Fri Jan 11 19:55:45 2013 +0100 ScDBDocFunc::UpdatePivotTable: -Werror=deprecated-declarations

Re: [REVIEW-4-0] oxygen-gtk support version ...

2013-01-11 Thread Noel Power
On 10/01/13 17:41, Michael Meeks wrote: Hi there, I cleaned up the version bits (as well as I could in a back-portable way for 4.0 - really we should drive this all from one setting in configure.in IMHO). I'd like to get the result into -4-0 if someone could review/ pick these t

[PATCH] Fixes image drop shadow export to DOCX.

2013-01-11 Thread Eilidh McAdam (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1655 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/55/1655/1 Fixes image drop shadow export to DOCX. Word has problems if the effect extent element is omitted. This gets the

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - scripting/source

2013-01-11 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit f49e469d93749547520ae34c52d26f17bcc32cf7 Author: Stephan Bergmann Date: Fri Jan 11 18:29:14 2013 +0100 fdo#59249: String literal needs a "b" prefix in Pyhton 3 as

[Libreoffice-commits] .: scripting/source

2013-01-11 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 9dec0c79011a0c09068d86fba9387c67da84a39b Author: Michael Stahl Date: Fri Jan 11 19:07:08 2013 +0100 fdo#59249: mailmerge.py: some more bytes vs. str mangling

[Libreoffice-commits] .: 2 commits - sw/inc sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/inc/hhcwrp.hxx | 32 ++--- sw/source/ui/lingu/hhcwrp.cxx | 240 +- 2 files changed, 136 insertions(+), 136 deletions(-) New commits: commit f902073e4790ab3de1d48758d4e38ba583809030 Author: Matteo Casalin Date: Fri Jan 11 19:07:05 2013 +

[PATCH] Change in core[libreoffice-3-6]: Let's not return here to prevent memory leak.

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1654 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/54/1654/1 Let's not return here to prevent memory leak. There are several heap objects that are deleted at the end of the

Re: [REVIEW 4-0] Re: Adding hyphenation patterns for Swedish

2013-01-11 Thread Niklas Johansson
Thank you for creating the patch, I hope that I'll be able to do it myself the next time. :) Regards, Niklas Johansson Petr Mladek skrev 2013-01-10 12:19: Hi Niklas, I have added the dictionary into master, see http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=9cfd4282a7a522bed2

[PATCH] Change in core[libreoffice-4-0]: Let's not return here to prevent memory leak.

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1653 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/53/1653/1 Let's not return here to prevent memory leak. There are several heap objects that are deleted at the end of the

[Libreoffice-commits] .: 2 commits - sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx | 146 +++-- sc/source/ui/inc/dbdocfun.hxx |2 sc/source/ui/view/dbfunc3.cxx |2 sc/source/ui/view/gridwin2.cxx |2 4 files changed, 146 insertions(+), 6 deletions(-) New commits: commit d99abd61a9091

[PATCH] Change in core[libreoffice-4-0]: fdo#53487 SwUndoInsert: take care of fieldmarks when deletin...

2013-01-11 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1652 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/52/1652/1 fdo#53487 SwUndoInsert: take care of fieldmarks when deleting field chars The problem was that while SwUndoInser

[Libreoffice-commits] .: scripting/source

2013-01-11 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit ac56d9373a66378a04048993ed5aec65cf39f149 Author: Stephan Bergmann Date: Fri Jan 11 18:32:04 2013 +0100 Can't convert 'Enum' resp. 'bytes' object to str implicitly

[Libreoffice-commits] .: scripting/source

2013-01-11 Thread Libreoffice Gerrit user
scripting/source/pyprov/mailmerge.py |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 7a7e19c166df326c45f76a142b478b0629f784c9 Author: Stephan Bergmann Date: Fri Jan 11 18:29:14 2013 +0100 fdo#59249: String literal needs a "b" prefix in Pyhton 3 as

[Libreoffice-commits] .: writerfilter/source

2013-01-11 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/DomainMapperTableHandler.cxx |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 194ba3a2cacbb5438dfcb8fb35167055e01ca251 Author: Pierre-Eric Pelloux-Prayer Date: Fri Jan 11 17:40:39 2013 +0100 docx import: fix incorrect nested table

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/core/undo/unins.cxx | 21 + 1 file changed, 21 insertions(+) New commits: commit f132eaa5a6ec6fd3051442bda9caf94a3341c680 Author: Miklos Vajna Date: Fri Jan 11 17:32:18 2013 +0100 fdo#53487 SwUndoInsert: take care of fieldmarks when deleting field chars

[PUSHED] doc export: add unit test for bug i106749

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1646 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1646 To unsubscribe, visit h

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/ww8export/data/new-page-styles.doc |binary sw/qa/extras/ww8export/ww8export.cxx|9 + 2 files changed, 9 insertions(+) New commits: commit 1874df3041789729478ef99ff156ccee489c6a7a Author: Pierre-Eric Pelloux-Prayer Date: Thu Jan 10 18:42:38 2013 +0100

[PUSHED] sw unit test: add call to CalcLayout before using the layout

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1645 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1645 To unsubscribe, visit h

[PUSHED] doc export: add unit test for fdo#56513

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1644 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1644 To unsubscribe, visit h

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/inc/swmodeltestbase.hxx |1 + 1 file changed, 1 insertion(+) New commits: commit 87c66e9e3d7ab1351fac8db9aad80ed01e7634b6 Author: Pierre-Eric Pelloux-Prayer Date: Thu Jan 10 18:41:05 2013 +0100 sw unit test: add call to CalcLayout before using the layout Change-I

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/ww8export/data/fdo56513.doc |binary sw/qa/extras/ww8export/ww8export.cxx |9 + 2 files changed, 9 insertions(+) New commits: commit 40e0a5d73a5b7a0f23015ee481a94639400f581d Author: Pierre-Eric Pelloux-Prayer Date: Thu Jan 10 16:10:53 2013 +0100 doc export: ad

[PUSHED] sw unit test: layout dump must be resetted in 'reload' metho...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1643 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1643 To unsubscribe, visit h

[Libreoffice-commits] .: sw/qa

2013-01-11 Thread Libreoffice Gerrit user
sw/qa/extras/inc/swmodeltestbase.hxx |5 + 1 file changed, 5 insertions(+) New commits: commit 58aeb8e6aadd8511a700ec1c289bdc229f7592c9 Author: Pierre-Eric Pelloux-Prayer Date: Thu Jan 10 16:29:58 2013 +0100 sw unit test: layout dump must be resetted in 'reload' method Ot

Re: Extending Dictionaries

2013-01-11 Thread Samuel Mehrbrodt
Thanks! I've extended it a bit and added a list of Contacts with the Maintainers of the Dictionaries found in the READMEs. I hope that this will encourage people to help update the dictionaries. But the list is not complete, and there may be errors, so everyone feel free to update or correct

[PUSHED] Change in core[libreoffice-3-6]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1651 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1651 To unsubscribe, visit h

[PUSHED] fdo#56124 add functions IFERROR and IFNA to calc as in ODFF1...

2013-01-11 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1522 Objections: Eike Rathke: Do not submit -- To view, visit https://gerrit.libreoffice.org/1522 To unsubscribe, visit https://gerrit.libreof

[Libreoffice-commits] .: 2 commits - formula/inc formula/source sc/inc sc/qa sc/source sc/util

2013-01-11 Thread Libreoffice Gerrit user
formula/inc/formula/compiler.hrc | 42 ++--- formula/inc/formula/errorcodes.hxx |3 formula/inc/formula/opcode.hxx |2 formula/source/core/api/FormulaCompiler.cxx| 77 +++-- formula/source/core/api/token.cxx | 22 +- fo

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/source/ui/docshell/dbdocfun.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1975fe4be8347d244643a0fbab20357485d41522 Author: Kohei Yoshida Date: Thu Jan 10 23:48:17 2013 -0500 fdo#59084: Sync dimension members after reloading the group data.

Re: Failure to build 3.6 branch

2013-01-11 Thread Alexander Thurgood
Le 11/01/13 14:57, Alexander Thurgood a écrit : > >> I'd rather guess simply a bug in the compiler (since it's on Mac, it's the >> old gcc-4.0.1, right?). Try if the file compiles successfully with 'make >> DEBUG=1', that will disable optimizations. >> No joy, still fails at exactly the same

[Libreoffice-commits] .: cui/source

2013-01-11 Thread Libreoffice Gerrit user
cui/source/tabpages/chardlg.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit eccae3ee63cc561c0b0ace0b95e9a2344081bb9c Author: Takeshi Abe Date: Sat Jan 12 00:42:38 2013 +0900 Drop deserted m_aTransparentText Its usage was gone with adda1a25f248586b46682bb9e19cd7a

Re: [PATCH] doc export: add unit test for bug i106749

2013-01-11 Thread Michael Meeks
Hi Korrawit, On Fri, 2013-01-11 at 21:58 +0700, Korrawit Pruegsanusak wrote: > Do we have a license to use this file? (no offense of course! :) I'm most concerned about the source files; having said that this is not an appropriate forum to raise legal concerns - please spam the legal@ ali

[PUSHED] Use member initializer list in constructor

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1640 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1640 To unsubscribe, visit h

[PUSHED] Prefix class data members

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1639 Approvals: Noel Power: Verified; Looks good to me, approved Michael Stahl: Verified; Looks good to me, approved -- To view, visit https

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/ui/lingu/hhcwrp.cxx | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) New commits: commit 40cfbd62e9f3aa52036a339cbbc9e542647017d3 Author: Matteo Casalin Date: Thu Jan 10 23:36:51 2013 +0100 Use member initializer list in constructor

[Libreoffice-commits] .: sw/inc sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/inc/hhcwrp.hxx | 32 ++--- sw/source/ui/lingu/hhcwrp.cxx | 232 +- 2 files changed, 132 insertions(+), 132 deletions(-) New commits: commit 6704bb8eb0ac93da96cf58aac28c4f04e794dfd6 Author: Matteo Casalin Date: Thu Jan 10 23:13:16 2013 +

[PATCH] Change in core[libreoffice-3-6]: fdo#59084: Sync dimension members after reloading the group ...

2013-01-11 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1651 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/1651/1 fdo#59084: Sync dimension members after reloading the group data. Else the syncing would end up syncing to the o

Re: [PATCH] doc export: add unit test for bug i106749

2013-01-11 Thread Korrawit Pruegsanusak
Hello all, On Fri, Jan 11, 2013 at 8:44 PM, Pierre-Eric Pelloux-Prayer (via Code Review) wrote: > I have submitted a patch for review: > https://gerrit.libreoffice.org/1646 > doc export: add unit test for bug i106749 IMHO it's great to have many unit tests as possible :), but I wonder ... >

[Libreoffice-commits] .: sal/osl

2013-01-11 Thread Libreoffice Gerrit user
sal/osl/all/log.cxx | 36 1 file changed, 24 insertions(+), 12 deletions(-) New commits: commit 4fbf6df784529d48cf194a2d9c495ffb47933d59 Author: Stephan Bergmann Date: Fri Jan 11 15:46:47 2013 +0100 Fix workaround for thead-unsafe getenv again

Re: Writing new Clang plugins (Re: replacing OUString::valueOf(static_cast) ??)

2013-01-11 Thread Jean-Noël Rouvignac
2013/1/11 Lubos Lunak > On Friday 11 of January 2013, Jean-Noël Rouvignac wrote: > > 2013/1/10 Lubos Lunak > > > > > > > Unless all you want to convert is only places which do the > explicit > > > > > > > > > > cast, this will need a (fairly simple) Clang plugin. > > > > > > > > Sure, if you fe

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58531, which changed state. Bug 58531 Summary: FILEOPEN: Reload no longer refreshes external links in 4.0 https://bugs.freedesktop.org/show_bug.cgi?id=58531 What|Removed |Added

[Libreoffice-commits] .: 3 commits - compilerplugins/clang compilerplugins/README writerfilter/source

2013-01-11 Thread Libreoffice Gerrit user
compilerplugins/README |2 +- compilerplugins/clang/plugin.cxx|5 ++--- writerfilter/source/ooxml/model.xml |5 - 3 files changed, 3 insertions(+), 9 deletions(-) New commits: commit 03910bdfd964ee34bdd93fda3339908cad2b01f4 Author: Luboš Luňák Date: Fri Jan

Re: Failure to build 3.6 branch

2013-01-11 Thread Alexander Thurgood
Le 10/01/13 19:06, Lubos Lunak a écrit : Hi Lubos, > I'd rather guess simply a bug in the compiler (since it's on Mac, it's the > old gcc-4.0.1, right?). Try if the file compiles successfully with 'make > DEBUG=1', that will disable optimizations. > No, it is actually gcc 4.2.1, but I'll tr

Writing new Clang plugins (Re: replacing OUString::valueOf(static_cast) ??)

2013-01-11 Thread Lubos Lunak
On Friday 11 of January 2013, Jean-Noël Rouvignac wrote: > 2013/1/10 Lubos Lunak > > > > > Unless all you want to convert is only places which do the explicit > > > > > > > > cast, this will need a (fairly simple) Clang plugin. > > > > > > Sure, if you feel like writing one. > > > > Actually, I'

[Libreoffice-commits] .: sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/filter/ww8/rtfexport.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3527efa7e078ce11ac537d8f8591b159c05e760f Author: Tor Lillqvist Date: Fri Jan 11 15:43:56 2013 +0200 Output version number as text, not binary Change-Id: I1ada5bd38a55fa

[PATCH] sax: add methods to duplicate current top marker and reapply...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1648 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/1648/1 sax: add methods to duplicate current top marker and reapply it later The need for this is ooxml: we need to hav

[PATCH] docx export: also export rPr in (paragraph mark stylin...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1649 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/1649/1 docx export: also export rPr in (paragraph mark styling) Change-Id: I179363e7d0acc3d6a1f95dcfe975275a9243e863 -

[PATCH] doc export: add unit test for fdo#56513

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1644 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/44/1644/1 doc export: add unit test for fdo#56513 Change-Id: Ie87648368f877af56878bc83fe3d5ece66f77304 --- A sw/qa/extras/

[PATCH] docx export: add test case for paragraph mark export

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1650 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/1650/1 docx export: add test case for paragraph mark export Change-Id: I2701ee12221460f8ff19397ea215cc1484648d18 --- A

[PATCH] sw unit test: layout dump must be resetted in 'reload' metho...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1643 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/43/1643/1 sw unit test: layout dump must be resetted in 'reload' method Otherwise tests relying on layout dumps will parse

[PATCH] docx export: invalid sectPr added at the beginning of the do...

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1647 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1647/1 docx export: invalid sectPr added at the beginning of the doc This reverts commit 60fa5057039d2413d56813df4d45e5

[PATCH] doc export: add unit test for bug i106749

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1646 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/1646/1 doc export: add unit test for bug i106749 Change-Id: I1df4cbb013d94cff7ae5195427044b1e1b2d8895 --- A sw/qa/extra

[PATCH] sw unit test: add call to CalcLayout before using the layout

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1645 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1645/1 sw unit test: add call to CalcLayout before using the layout Change-Id: Ibb3f8175729cb579a687275a11884c397152fe9

office ipc: use timeout pipe feature when connecting to self

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: office ipc: use timeout pipe feature when connecting to self .. Patch Set 1: Abandoned Not needed anymore. -- To view, visit https://gerrit.libreoffice.org

sal: add timeout option when using pipe in connect mode

2013-01-11 Thread Pierre-Eric Pelloux-Prayer (via Code Review)
Pierre-Eric Pelloux-Prayer has abandoned this change. Change subject: sal: add timeout option when using pipe in connect mode .. Patch Set 1: Abandoned Not needed anymore. -- To view, visit https://gerrit.libreoffice.org/1310

Re: replacing OUString::valueOf(static_cast) ??

2013-01-11 Thread Lubos Lunak
On Friday 11 of January 2013, Noel Grandin wrote: > On 2013-01-10 15:55, Lubos Lunak wrote: > > - There's no need for valueOfChar(). There is already OUString ctor from > > sal_Unicode, so the valueOf() overload for it is just making an obvious > > thing complicated. Code using it can be converted

[Libreoffice-commits] .: apache-commons/ExternalProject_apache_commons_codec.mk apache-commons/ExternalProject_apache_commons_httpclient.mk apache-commons/ExternalProject_apache_commons_lang.mk apache

2013-01-11 Thread Libreoffice Gerrit user
apache-commons/ExternalProject_apache_commons_codec.mk |5 - apache-commons/ExternalProject_apache_commons_httpclient.mk |5 - apache-commons/ExternalProject_apache_commons_lang.mk |5 - apache-commons/ExternalProject_apache_commons_logging.mk|5 - config_host.mk.in

Re: replacing OUString::valueOf(static_cast) ??

2013-01-11 Thread Stephan Bergmann
On 01/11/2013 01:02 PM, Jan Holesovsky wrote: - It's a question if we really need 'OUString::valueOfBool( foo )' instead of simply 'foo ? OUString( "true" ) : OUString( "false" )' (such a pity the string literals handling doesn't allow "foo ? "true" : "false"' ). I wonder how many places in the c

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Jean-Baptiste Faure changed: What|Removed |Added Depends on||58998 --- Comment #76 from Jean-Ba

Re: replacing OUString::valueOf(static_cast) ??

2013-01-11 Thread Jan Holesovsky
Hi Noel, Noel Grandin píše v Pá 11. 01. 2013 v 14:12 +0200: > > Or did you mean something different? > OK, in that case, I'll drop the valueOfChar() methods. If others agree too - would you please mark the valueOf( sal_Unicode ) and valueOf( sal_Bool ) as deprecated when you are at that? [And w

Re: replacing OUString::valueOf(static_cast) ??

2013-01-11 Thread Noel Grandin
On 2013-01-11 14:02, Jan Holesovsky wrote: Noel Grandin píše v Pá 11. 01. 2013 v 08:46 +0200: - There's no need for valueOfChar(). There is already OUString ctor from sal_Unicode, so the valueOf() overload for it is just making an obvious thing complicated. Code using it can be converted to us

[Libreoffice-commits] .: 2 commits - config/config_version.h.in configure.ac sc/source sw/source vcl/inc

2013-01-11 Thread Libreoffice Gerrit user
config/config_version.h.in | 12 configure.ac |8 sc/source/filter/xml/xmlstyle.cxx |6 +++--- sw/source/filter/ww8/rtfexport.cxx | 12 +++- vcl/inc/svdata.hxx |3 --- 5 files changed, 30 insertions(+), 11

[Libreoffice-commits] .: src/docrecord.py src/docstream.py

2013-01-11 Thread Miklos Vajna
src/docrecord.py | 21 + src/docstream.py |5 - 2 files changed, 25 insertions(+), 1 deletion(-) New commits: commit 614d9656f45bb48580eee2453b13b351b12a0bcd Author: Miklos Vajna Date: Fri Jan 11 13:02:56 2013 +0100 dump SttbListNames diff --git a/src/docrec

Re: replacing OUString::valueOf(static_cast) ??

2013-01-11 Thread Jan Holesovsky
Hi Noel, Noel Grandin píše v Pá 11. 01. 2013 v 08:46 +0200: > > - There's no need for valueOfChar(). There is already OUString ctor from > > sal_Unicode, so the valueOf() overload for it is just making an obvious > > thing > > complicated. Code using it can be converted to use the ctor instead.

[PUSHED] Change in core[libreoffice-4-0]: fdo#58531: Register cells with external references at compil...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1631 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1631 To unsubscribe, visit h

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/inc sc/source

2013-01-11 Thread Libreoffice Gerrit user
sc/inc/compiler.hxx |1 + sc/inc/externalrefmgr.hxx|4 ++-- sc/source/core/tool/compiler.cxx | 31 +++ 3 files changed, 34 insertions(+), 2 deletions(-) New commits: commit 260f1b19ce7340b02fce5aea948caa61ee128f44 Author: Kohei Yoshida D

Re: replacing OUString::valueOf(static_cast) ??

2013-01-11 Thread Michael Meeks
On Fri, 2013-01-11 at 08:46 +0200, Noel Grandin wrote: > That seems like it would have some backwards compatibility issues, but I > suppose we could mark them as deprecated for a time before actually > removing them. Sure - well, since they're in-lined I think this is prolly a sensible

[Libreoffice-commits] .: src/docrecord.py src/docstream.py test/doc

2013-01-11 Thread Miklos Vajna
src/docrecord.py | 67 +- src/docstream.py |5 +++- test/doc/list.doc |binary test/doc/list.rtf | 49 +++ test/doc/test.py |6 5 files changed, 120 insertions(+), 7 deletions(-) New commit

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 58699, which changed state. Bug 58699 Summary: Impress remote doesn't close https://bugs.freedesktop.org/show_bug.cgi?id=58699 What|Removed |Added --

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - cppcanvas/source

2013-01-11 Thread Libreoffice Gerrit user
cppcanvas/source/mtfrenderer/emfplus.cxx | 45 +++ 1 file changed, 45 insertions(+) New commits: commit 7850822b27981ce46d16532267975b3a91f91102 Author: Radek Doulik Date: Thu Jan 10 15:58:30 2013 +0100 implemented EmfPlusRecordTypeFillPie record Cha

[PUSHED] Change in core[libreoffice-4-0]: fdo#57938 SwPaM::HasReadonlySel: commented text ranges are n...

2013-01-11 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1629 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1629 To unsubscribe, visit h

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2013-01-11 Thread Libreoffice Gerrit user
sw/source/core/crsr/pam.cxx |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) New commits: commit 5a0dc1d1fdeac4b06b39ea616374d3f81b6be8a9 Author: Miklos Vajna Date: Thu Jan 10 16:21:55 2013 +0100 fdo#57938 SwPaM::HasReadonlySel: commented text ranges are not read-only

  1   2   >