[PATCH] Create OUString::valueInt, valueBool and valueChar function ...

2013-01-09 Thread Noel Grandin (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1625 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1625/1 Create OUString::valueInt, valueBool and valueChar function templates. Cleans up the call sites by hiding the ne

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Stephan Bergmann
On 01/09/2013 05:02 PM, Lubos Lunak wrote: So that other people don't have to search: According to my reading of the standard (mainly 13.3.3.1.1 and 13.3.3.2 [*]), this is because when choosing which conversion for overloaded functions is better, the standard treats all integer conversions[**]

[Libreoffice-commits] .: bridges/source

2013-01-09 Thread Libreoffice Gerrit user
bridges/source/cpp_uno/gcc3_linux_arm/uno2cpp.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit b3aad508592e8febab229150a5ba284a3f186a97 Author: Tor Lillqvist Date: Thu Jan 10 09:07:41 2013 +0200 Be truthful to the compiler about registers clobbered by asm s

Re: FYI: Make for faster windows build

2013-01-09 Thread Noel Grandin
On 2013-01-09 22:52, Lubos Lunak wrote: I knew there was one more thing I wanted to mention. The make we have in dev-tools actually doesn't build with WINDOWS32 #define (both as in that the #define doesn't get set by configure and that if it's explicitly set the code doesn't compile successful

RE: fdo#40465 fix to maintain focus whilst zooming

2013-01-09 Thread Winfried Donkers
Hi Ruslan, Thank you for your feed back. > Could this behavior be changed so that not cursor governs current focus, but > the place which the user has last scrolled to? Yes I am going to do just that, see the recent comments in fdo#40465 itself. > Should I make a bug report for this? No, that

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Noel Grandin
On Wed, Jan 9, 2013 at 7:58 PM, Michael Meeks wrote: > At least in my mind :-) but we're starting to bike-shed here... I > didn't see anyone volunteering to do the actual batch cleanup there ;-) > > Doesn't sound that hard - some regular expression magic will do most of the work. The har

[Libreoffice-commits] .: 2 commits - sd/source svx/source

2013-01-09 Thread Libreoffice Gerrit user
sd/source/ui/dlg/custsdlg.cxx |8 svx/source/xoutdev/xattr2.cxx |6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) New commits: commit 469cec21f7da6a680897615f912d137f94e62ee9 Author: Ivan Timofeev Date: Thu Jan 10 09:34:42 2013 +0400 fix Search->indexOf conversi

[Libreoffice-commits] .: sc/source

2013-01-09 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlexprt.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit d158a09e56e3944458d63a6c572f60dbe4632dad Author: Markus Mohrhard Date: Thu Jan 10 03:59:57 2013 +0100 handle shapes anchored to the wrong sheet without crash, fdo#58858 Change-Id: I0

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 --- Comment #75 from Joren De Cuyper --- I nominate "Bug 59183 - EDITING: Copy 4 or more slides then crash" because of the regression with 3.6 branch; -- You are receiving this mail because: You are on the CC list for the bug. _

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Joren De Cuyper changed: What|Removed |Added Depends on||59183 -- You are receiving this mail

[Libreoffice-commits] .: 2 commits - solenv/gdb writerfilter/source

2013-01-09 Thread Libreoffice Gerrit user
solenv/gdb/libreoffice/sw.py |2 ++ writerfilter/source/dmapper/DomainMapper_Impl.cxx |8 +++- 2 files changed, 9 insertions(+), 1 deletion(-) New commits: commit e521930ea1c855c236efb67793e540d07c201d35 Author: Michael Stahl Date: Thu Jan 10 00:43:12 2013 +010

RE: [libreoffice-dev] - building difficulties with C++ extension,addIn

2013-01-09 Thread Rai, Neeraj
Hi Stephan, I was able to get a complete addin working with help from sample code from Kohei. Please find the example attached. It is just a dummy update to 60K entries (12sec). Much faster than DocumentLoader and SimpleBootsrap mechanism that I tried earlier. Thanks all for help. Neeraj _

RE: [libreoffice-dev] - questions about calc extension

2013-01-09 Thread Rai, Neeraj
Hi Kohei, I looked a little more into your code and copied the getactiveSheet function. Now it takes 12s. I am happy. Sorry for the spam - you have good code sitting there. Thanks Neeraj -Original Message- From: Rai, Neeraj [ICG-MKTS] Sent: Wednesday, January 09, 2013 6:03 PM To: 'libre

RE: [libreoffice-dev] - questions about calc extension

2013-01-09 Thread Rai, Neeraj
Hi Kohei, I figured out my bug. I was storing the context in a const Reference <> & const and it was going out of scope and being reclaimed after the constructor. After changing it to normal Reference <>, everything is fine. Thanks again for your time and patience. Hope you didn't have to waste a

fdo#36800-Find & replace does not search single cell

2013-01-09 Thread Eike Rathke (via Code Review)
Eike Rathke has abandoned this change. Change subject: fdo#36800-Find & replace does not search single cell .. Patch Set 3: Abandoned No follow-up since a month. -- To view, visit https://gerrit.libreoffice.org/1222 To unsubs

Re: Failure to build 3.6 branch

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Ruslan Kabatsayev wrote: > Hi all, > > I was trying to build latest libreoffice-3-6 branch, and got > compilation failure. Here's output: > > _ > [ build CXX ] unotools/source/streaming/streamwrap.cxx > /fastdocs/p

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - unotools/source

2013-01-09 Thread Libreoffice Gerrit user
unotools/source/misc/fontcvt.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 35ddd4eecf3db609368428470dff74188e59b037 Author: Michael Meeks Date: Mon Dec 17 20:19:47 2012 + 32bit compile fix for OString::valueOf usage. Conflicts:

License statement

2013-01-09 Thread secmail
  All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license.   Best regards, Eldan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] Change in core[libreoffice-4-0]: fdo#58539: Correctly set cached matrix formula result.

2013-01-09 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1623 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1623 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - formula/inc formula/source sc/inc sc/source

2013-01-09 Thread Libreoffice Gerrit user
formula/inc/formula/FormulaCompiler.hxx |3 +- formula/source/core/api/FormulaCompiler.cxx |2 - sc/inc/cell.hxx |5 sc/inc/compiler.hxx |4 +-- sc/inc/formularesult.hxx|2 + sc/inc/token.hxx

Re: [libreoffice-dev] - questions about calc extension

2013-01-09 Thread Rai, Neeraj
Hi Kohei, 1. I think I see what you are doing, but having trouble making it work. --- my understanding of your code and the issue I face below - The create_XXX is passed the ComponentContext and you store it for future. I tried the same but the calls to xContext->getServiceManager() aborts my

Re: FYI: Make for faster windows build

2013-01-09 Thread Tor Lillqvist
> I have no idea what difference that'd make, I think there's Win32-specific > code instead of fork(), I don't know if there's any Win32-specific stat() > replacement or whether that'd make a noticeable difference. It is quite possible that avoiding the Cygwin stat() and instead using Win32 API to

[Libreoffice-commits] .: src/docrecord.py src/docstream.py

2013-01-09 Thread Miklos Vajna
src/docrecord.py | 61 +++ src/docstream.py |5 +++- 2 files changed, 65 insertions(+), 1 deletion(-) New commits: commit 82098141b68aa00f5335c8b6e1083b6d7e8f4557 Author: Miklos Vajna Date: Wed Jan 9 22:05:12 2013 +0100 dump PlcfSp

Re: [PATCH] Change in core[libreoffice-4-0]: fdo#58539: Correctly set cached matrix formula result.

2013-01-09 Thread Kohei Yoshida
On 01/09/2013 01:07 PM, Kohei Yoshida (via Code Review) wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1623 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1623/1 fdo#58539: Correctly set cached matrix formula

[Libreoffice-commits] .: sal/qa

2013-01-09 Thread Libreoffice Gerrit user
sal/qa/rtl/strings/test_ostring_concat.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 6880e2d31a38d5f4b44ba4f5b4a2b3e361a66312 Author: Luboš Luňák Date: Wed Jan 9 21:40:40 2013 +0100 hack for apple's gcc-4.0.1 bug My self-built 4.0.1 on Linux handles this f

Re: FYI: Make for faster windows build

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Lubos Lunak wrote: > Looks what I found under the tree! Faster make for Cygwin. Granted, I had > put it there first, but still nice. > > Those of you who build on Windows, you might want to pull again from > git://gerrit.libreoffice.org/dev-tools.git and update yo

[Libreoffice-commits] .: extensions/source

2013-01-09 Thread Libreoffice Gerrit user
extensions/source/bibliography/bibbeam.cxx |6 - extensions/source/bibliography/bibconfig.cxx | 130 +-- extensions/source/bibliography/bibcont.cxx |1 extensions/source/bibliography/bibload.cxx | 27 ++--- extensions/source/bibliography/bibmod.cxx|

[Libreoffice-commits] .: vcl/win

2013-01-09 Thread Libreoffice Gerrit user
vcl/win/source/window/salframe.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f5d047dcb80d760d46e90a1dacad206ddf55d827 Author: Luboš Luňák Date: Wed Jan 9 21:29:52 2013 +0100 second try with wcscpy() On mingw sal_Unicode is not wchar_t (see sa

[Libreoffice-commits] .: canvas/source

2013-01-09 Thread Libreoffice Gerrit user
canvas/source/factory/cf_service.cxx| 39 +- canvas/source/null/null_canvasbitmap.cxx| 12 canvas/source/null/null_canvascustomsprite.cxx | 12 canvas/source/null/null_canvasfont.cxx | 12 canvas/source/null/null_spritecanvas.cxx|4 canvas/sour

[Libreoffice-commits] .: vcl/win

2013-01-09 Thread Libreoffice Gerrit user
vcl/win/source/window/salframe.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0a28778e9a2a02382ab5ccd79035500334504f17 Author: Luboš Luňák Date: Wed Jan 9 21:12:29 2013 +0100 mingw tinderbox doesn't know wcscpy_r() Moreover, according to MSDN,

Re: LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Jean-Baptiste Faure
Hi Leif, Le 09/01/2013 20:14, leif a écrit : > Hi, > It still doesn't work for me. > Tried with daily built from today. The last available build 32 bits for Linux is http://dev-builds.libreoffice.org/daily/libreoffice-4-0/Linux-x86_10-Release-Configuration/current/ that is yesterday 2013-01-08 at

Re: compile error in neon

2013-01-09 Thread Cor Nouws
Hi Jean-Baptiste, Jean-Baptiste Faure wrote (09-01-13 20:29) I had the same building problem today : Neon is necessary if you want have persona working. I solved it with the help of Kendy and Bjoern by removing --with-system-openssl from my autogen.lastrun Thanks, doing that now too, although

Re: FYI: Make for faster windows build

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Lubos Lunak wrote: > Looks what I found under the tree! Faster make for Cygwin. Granted, I had > put it there first, but still nice. Oh well, looks like somebody actually does develop LO on Windows :). So on a related note, two more things that might be helpful

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Jean-Baptiste Faure
Hi, Le 09/01/2013 09:54, Petr Mladek a écrit : > Jean-Baptiste Faure píše v St 09. 01. 2013 v 06:22 +0100: >> Le 09/01/2013 02:16, Pedro a écrit : >>> Petr Mladek wrote I took the approval from Cor, Olivier, Adolfo, Michael, and pushed into 4-0 branch for 4.0.0.1 build. >>> >>> That mean

Re: compile error in neon

2013-01-09 Thread Jean-Baptiste Faure
Hi Cor, Le 07/06/2012 23:16, Cor Nouws a écrit : > Cor Nouws wrote (07-06-12 22:14) > >> Should I add --disable-neon to autogen.lastrun ? >> (will find out soon, probably...) > > Still building, so that looks fine. > Should a check for neon be added to the autogen.sh ? > I had the same buildin

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Jean-Baptiste Faure
Hi Kendy, Le 09/01/2013 14:21, Jan Holesovsky a écrit : > [...] > Not sure if I manage to do the async loading + preview for 4.0, > though :-( But showing the URL at least should be doable - is that > enough? For me it is enough, because we have a preview in Firefox. It is not exactly the same,

[PUSHED] Change in core[libreoffice-4-0]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1617 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1617 To unsubscribe, visi

[PUSHED] Change in core[libreoffice-3-6]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1618 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1618 To unsubscribe, visi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/qa writerfilter/source

2013-01-09 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo58933.rtf | 28 + sw/qa/extras/rtfimport/rtfimport.cxx | 12 ++ writerfilter/source/rtftok/rtfdocumentimpl.cxx |7 +++--- 3 files changed, 44 insertions(+), 3 deletions(-) New commits: commit 075a1e6fdaebd441be

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - writerfilter/source

2013-01-09 Thread Libreoffice Gerrit user
writerfilter/source/rtftok/rtfdocumentimpl.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 10a6a58e8d55f5d6c1ce7b6cba38f710b6edab6f Author: Miklos Vajna Date: Wed Jan 9 15:29:29 2013 +0100 fdo#58933 RTF import: avoid fake pars / cells when having gr

LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread leif
Hi, It still doesn't work for me. Tried with daily built from today. When I select either background image or Persona and closes the dialogue, nothing happens. Content of the chosen values are not stored. Something is stored to registrymodifications.xcu though. I can see three relevant entries

Re: FYI: Make for faster windows build

2013-01-09 Thread Tor Lillqvist
> I've implemented built-in support for some simple commands used by gbuild > such as > mkdir or cp, YEEEAH! --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Failure to build 3.6 branch

2013-01-09 Thread Alex Thurgood
Le 09/01/2013 19:46, Ruslan Kabatsayev a écrit : Hi Ruslan, > I was trying to build latest libreoffice-3-6 branch, and got > compilation failure. Here's output: > > _ > [ build CXX ] unotools/source/streaming/streamwrap.cxx > /fastdocs/programm

Re: FYI: Make for faster windows build

2013-01-09 Thread Kohei Yoshida
On 01/09/2013 02:01 PM, Lubos Lunak wrote: Faster make for Cygwin. Excellent! Thank you thank you thank you. -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mail

FYI: Make for faster windows build

2013-01-09 Thread Lubos Lunak
Looks what I found under the tree! Faster make for Cygwin. Granted, I had put it there first, but still nice. Those of you who build on Windows, you might want to pull again from git://gerrit.libreoffice.org/dev-tools.git and update your make. I've implemented built-in support for some simpl

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - instsetoo_native/util solenv/inc

2013-01-09 Thread Libreoffice Gerrit user
instsetoo_native/util/openoffice.lst | 40 +-- solenv/inc/minor.mk |4 +-- 2 files changed, 22 insertions(+), 22 deletions(-) New commits: commit cf9458096264f19cdd46e1543747e2d9dab90f8f Author: Petr Mladek Date: Wed Jan 9 19:53:14 2013 +0

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - desktop/source

2013-01-09 Thread Libreoffice Gerrit user
desktop/source/app/cmdlineargs.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit c695c0fdd15d70d26ac8f4a82dde515372df32c2 Author: Caolán McNamara Date: Mon Jul 9 12:51:16 2012 +0100 Resolves: rhbz#838368 --view ignored while -view accepted and

Re: [libreoffice-dev] - questions about calc extension

2013-01-09 Thread Kohei Yoshida
On 01/09/2013 01:12 PM, Rai, Neeraj wrote: Q1. When I try to use the xContext = cppu::bootstrap() in a calc extension, app terminate with throwing an exception : cppu::BootstrapException It works well in standalone exec. Yes, that's only for "standalone exec" (or whatever we are

[libreoffice-dev] - questions about calc extension

2013-01-09 Thread Rai, Neeraj
Q1. When I try to use the xContext = cppu::bootstrap() in a calc extension, app terminate with throwing an exception : cppu::BootstrapException It works well in standalone exec. What is the correct way to get a handle to spreadsheet in extension code. Q2. I came across an example e

[PATCH] Change in core[libreoffice-4-0]: fdo#58539: Correctly set cached matrix formula result.

2013-01-09 Thread Kohei Yoshida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1623 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/23/1623/1 fdo#58539: Correctly set cached matrix formula result. During the import, a cached matrix value only has an empt

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Michael Meeks
On Wed, 2013-01-09 at 18:26 +0100, Lubos Lunak wrote: > > but you'll at least implicitly cast the same way on all platforms (since > > the sal types don't map to arbitrary types, but to types of a particular > > size). > > The explicit cast will also always be the same way on all platforms.

Re: fdo#40465 fix to maintain focus whilst zooming

2013-01-09 Thread Ruslan Kabatsayev
Hi, Your change, though looks good in principle, appears to lead to some usability problems: suppose while reading a document you've placed cursor somewhere (or even didn't move it), then you scroll several pages up/down from that place, and now need to see current page in more detail. You Zoom it

Re: GTK theming: oxygen-gtk support broken

2013-01-09 Thread Tor Lillqvist
> Regarding version information, there is solver/*/inc/*minor.mk And of course the very file name of that "*minor.mk" contains the mysterious three-digits-no-separators number which is a relic from conventions in the OOo EIS/MWS/CWS days;) > (make-level > variables VERSIONMAJOR, VERSIONMINOR, etc

[Libreoffice-commits] .: src/docrecord.py src/docstream.py test/doc

2013-01-09 Thread Miklos Vajna
src/docrecord.py | 31 ++- src/docstream.py |4 ++-- test/doc/sections.doc |binary test/doc/test.py |7 +++ 4 files changed, 23 insertions(+), 19 deletions(-) New commits: commit f922c24a1c0e7bf2f7e330503eb37f2d99f39b75 Author: Miklos Vajn

[PATCH] add rule for generating fresh pot (po template) files

2013-01-09 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1622 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/22/1622/1 add rule for generating fresh pot (po template) files Moved from translations' custom makefile. Change-Id: Ife5

Re: gmake: CXXFLAGS override gb_Library_add_cxxflags

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Stephan Bergmann wrote: > On 01/09/2013 03:41 PM, Petr Mladek wrote: > > + openSUSE uses: > > > > CXXFLAGS=-fomit-frame-pointer ... > > What do you mean with "openSUSE uses [that]"? Is the env var preset > when you run a shell? Why would openSUSE do that in th

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Michael Stahl wrote: > On 09/01/13 17:02, Lubos Lunak wrote: > > Is there really such a big difference between > > OUString::valueOf( sal_Int32( 0 )) > > and > > OUString::valueOfInt32( 0 ) > > it has the advantage of being explicit in what type it expects; howev

Re: [libreoffice-dev] - building difficulties with C++ extension, addIn

2013-01-09 Thread Stephan Bergmann
On 01/09/2013 05:31 PM, Rai, Neeraj wrote: Not sure if this is related to any restructuring you guys are planning, but as of this moment, the wiki I used is down. http://wiki.openoffice.org This may be legacy and the info may belong elsewhere, or maybe Oracle owns it and finally decided to take

Re: [Libreoffice-ux-advise] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread Michel Renon
Hi all, Le 08/01/2013 11:07, Jan Holesovsky a écrit : Hi Cor, Cor Nouws píše v Po 07. 01. 2013 v 22:56 +0100: Idea looks great to me and is an invitement for futher enhancements in the future :-) I gues the code in a daily from 2012-12-28 (1) is not yet complet? I see the option page, but ch

Re: gmake: CXXFLAGS override gb_Library_add_cxxflags

2013-01-09 Thread Stephan Bergmann
On 01/09/2013 03:41 PM, Petr Mladek wrote: + openSUSE uses: CXXFLAGS=-fomit-frame-pointer ... What do you mean with "openSUSE uses [that]"? Is the env var preset when you run a shell? Why would openSUSE do that in the first place? Stephan __

Re: GTK theming: oxygen-gtk support broken

2013-01-09 Thread Ruslan Kabatsayev
Hi, On Wed, Jan 9, 2013 at 4:51 PM, Michael Meeks wrote: > Hi Ruslan, > > On Sat, 2013-01-05 at 22:59 +0300, Ruslan Kabatsayev wrote: >> What about such a simple change, which will let us set LibO version >> once and for all GTK theme calls: > > I guess we could do; we'd want to produce a

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Noel Grandin
On Wed, Jan 9, 2013 at 6:45 PM, Michael Stahl wrote: > better to add a new overloaded function, say valueOfInt, and have > overloads for all possible C++ integral types, all of which produce > strings with numbers. using that consistently would also solve the > problem of accidentally calling v

[Libreoffice-commits] .: 2 commits - svx/source sw/source

2013-01-09 Thread Libreoffice Gerrit user
svx/source/svdraw/svdview.cxx |2 +- sw/source/ui/uno/unoatxt.cxx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) New commits: commit c57906c8f614047a488eea6eb77c535bf90a889e Author: Luboš Luňák Date: Wed Jan 9 18:02:32 2013 +0100 OUString::valueOf sal_Int32 cast onc

[PATCH] Change in core[libreoffice-3-6]: Fix oo_sdk_ure_home calculation in SDK's cfgWin.js

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1619 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/19/1619/1 Fix oo_sdk_ure_home calculation in SDK's cfgWin.js This appears to be broken at least since bde5b815873450dc9520

[PATCH] Change in core[libreoffice-4-0]: Fix oo_sdk_ure_home calculation in SDK's cfgWin.js

2013-01-09 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1620 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/20/1620/1 Fix oo_sdk_ure_home calculation in SDK's cfgWin.js This appears to be broken at least since bde5b815873450dc9520

[PUSHED] Added asianphoneticguide.ui

2013-01-09 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1384 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1384 To unsubscribe, vi

[Libreoffice-commits] .: sw/uiconfig sw/UI_swriter.mk

2013-01-09 Thread Libreoffice Gerrit user
sw/UI_swriter.mk |1 sw/uiconfig/swriter/ui/asianphoneticguide.ui | 286 +++ 2 files changed, 287 insertions(+) New commits: commit 21be5156d45139d27a1ec18367ed271fdc9373a3 Author: Gokul Date: Mon Dec 17 13:43:38 2012 +0300 Added a

[Libreoffice-commits] .: odk/cfgWin.js

2013-01-09 Thread Libreoffice Gerrit user
odk/cfgWin.js | 50 +- 1 file changed, 1 insertion(+), 49 deletions(-) New commits: commit 0c22641b4c44938924187ddfb945f494a183ba47 Author: Stephan Bergmann Date: Wed Jan 9 17:45:09 2013 +0100 Fix oo_sdk_ure_home calculation in SDK's cfgWi

[Libreoffice-commits] .: sw/AllLangResTarget_sw.mk sw/inc sw/source sw/uiconfig sw/UI_swriter.mk

2013-01-09 Thread Libreoffice Gerrit user
sw/AllLangResTarget_sw.mk |1 sw/UI_swriter.mk|1 sw/inc/fldui.hrc|1 sw/inc/swabstdlg.hxx|2 sw/source/ui/dbui/dbtree.cxx| 26 +++ sw/source/ui/dialog/swdlgfact.

Re: Availability of the SDK?

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Stephan Bergmann wrote: > * appears to offer SDK in > some cases (like > _on_10.6.8/2013-01-09_08.08.08/master~2013-01-09_08.08.08_LibO-Dev_4.1.0.

[Libreoffice-commits] bin/push_nightlies.sh

2013-01-09 Thread Libreoffice Gerrit user
bin/push_nightlies.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 76e258540aed3cc1b1ae7e92599e07ab3dd1bea1 Author: Luboš Luňák Date: Wed Jan 9 17:47:42 2013 +0100 push also dev .msi Presumably the -path is there to filter out those .msi files

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Michael Stahl
On 09/01/13 17:02, Lubos Lunak wrote: > On Wednesday 09 of January 2013, Michael Meeks wrote: >> On Wed, 2013-01-09 at 16:10 +0200, Noel Grandin wrote: >>> maybe we need >>>OUString::valueOfInt32(sal_Int32) >>> that does the cast for us? >>> >>> At least it'll be less noisy, > > Is there real

Re: [PUSHED 4.0] LATE FEATURE: Personas in LibreOffice

2013-01-09 Thread khagaroth
It's useless without support for font color settings. Black text on black persona isn't exactly great UX experience. Though to be fair, even with support for this, some of the personas have rather weird color combinations when checked in Firefox. On Wed, Jan 9, 2013 at 2:38 PM, Stefan Knorr (Astr

[PATCH] Change in core[libreoffice-3-6]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1618 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/1618/1 fdo#58933 RTF import: avoid fake pars / cells when having graphic inside cells Regression from 8063e36115a11ddf3

RE: [libreoffice-dev] - building difficulties with C++ extension,addIn

2013-01-09 Thread Rai, Neeraj
Hi Stephan, Thanks for taking this up. I wasn't aware that examples didn't get built with make or make check. Time is not a big issue as long as it gets to the right place, and it seems like you are pushing it in right direction. I noticed that you are listed UNO,sal,config contact. Hope it is o

[PATCH] Change in core[libreoffice-4-0]: fdo#58933 RTF import: avoid fake pars / cells when having gr...

2013-01-09 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1617 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/1617/1 fdo#58933 RTF import: avoid fake pars / cells when having graphic inside cells Regression from 8063e36115a11ddf3

[Libreoffice-commits] .: formula/inc formula/source sc/inc sc/source

2013-01-09 Thread Libreoffice Gerrit user
formula/inc/formula/FormulaCompiler.hxx |3 +- formula/source/core/api/FormulaCompiler.cxx |2 - sc/inc/cell.hxx |5 sc/inc/compiler.hxx |4 +-- sc/inc/formularesult.hxx|2 + sc/inc/token.hxx

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - .gitreview

2013-01-09 Thread Libreoffice Gerrit user
.gitreview |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 58035222f58b1049d16dea1860fee696818de70e Author: Miklos Vajna Date: Wed Jan 9 17:24:56 2013 +0100 .gitreview: set defaultbranch for this branch correctly Change-Id: I839b5b500136f426edeb4573be

[PUSHED] Remove some RTL_* macros, rtl:: prefixes and simplification ...

2013-01-09 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1572 Approvals: Luboš Luňák: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1572 To unsubscribe, visit

[Libreoffice-commits] .: dbaccess/source

2013-01-09 Thread Libreoffice Gerrit user
dbaccess/source/ui/querydesign/querycontroller.cxx | 170 + dbaccess/source/ui/uno/copytablewizard.cxx | 139 +++-- dbaccess/source/ui/uno/unosqlmessage.cxx |8 3 files changed, 143 insertions(+), 174 deletions(-) New commits: commit b7d0dd

Availability of the SDK?

2013-01-09 Thread Stephan Bergmann
Availability of the SDK product appears not to be on par with the main LibreOffice product: * allows to download the "Software development kit (SDK)" for the browser's platform only (linking directly to

[PATCH] Change in core[libreoffice-4-0]: resolved fdo#58503 restore awkward handling of empty locale ...

2013-01-09 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1616 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/1616/1 resolved fdo#58503 restore awkward handling of empty locale for legacy Partly reverts d7a5ec62e91ce3dc5b78481525

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Lubos Lunak
On Wednesday 09 of January 2013, Michael Meeks wrote: > On Wed, 2013-01-09 at 16:10 +0200, Noel Grandin wrote: > > maybe we need > >OUString::valueOfInt32(sal_Int32) > > that does the cast for us? > > > > At least it'll be less noisy, Is there really such a big difference between OUString::v

[Libreoffice-commits] .: lingucomponent/source linguistic/inc linguistic/source linguistic/workben

2013-01-09 Thread Libreoffice Gerrit user
lingucomponent/source/hyphenator/altlinuxhyph/hyphen/hyphenimp.cxx |8 +- lingucomponent/source/lingutil/lingutil.cxx|2 lingucomponent/source/spellcheck/macosxspell/macspellimp.mm|4 - lingucomponent/source/spellcheck/spell/sspellimp.cxx

[PUSHED] Converted Exchange Databases widgets .ui

2013-01-09 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1595 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1595 To unsubscribe, vi

[Libreoffice-commits] .: sw/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
sw/uiconfig/swriter/ui/exchangedatabases.ui | 286 1 file changed, 286 insertions(+) New commits: commit a0bf71323741c5c58b77651fe656c73419dbf09f Author: Abdulelah Alarifi Date: Tue Jan 8 14:02:49 2013 +0300 Converted Exchange Databases widgets .ui C

[REVIEW 4.0] Template manager fixes

2013-01-09 Thread Cedric Bosdonnat
Hi all, I have some patches fixes various tiny bugs in the new template manager pending review for integration in 4.0. Could someone review them? I first tried to push them to gerrit: https://gerrit.libreoffice.org/1610 https://gerrit.libreoffice.org/1611 And then some more arrived, and I wi

[Libreoffice-commits] .: sfx2/source

2013-01-09 Thread Libreoffice Gerrit user
sfx2/source/doc/templatedlg.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3c08052394409a9c8aac07557a343070235672e7 Author: Cédric Bosdonnat Date: Wed Jan 9 16:41:58 2013 +0100 Template Manager: delete popup menus in the proper order Change-Id:

Re: Funding Wishlist

2013-01-09 Thread Jonathan Aquilina
Hey guys I have a zippy imac atm which is just sitting on my desk not being used with ample space and ram. I would be more then willing to help set that up as a necessary tinderbox but its running osx 10.7 on it. Let me know if you guys would benefit from having that as a tinderbox at all. Regards

Re: GTK theming: oxygen-gtk support broken

2013-01-09 Thread Michael Meeks
On Wed, 2013-01-09 at 15:47 +0100, Stephan Bergmann wrote: > Regarding version information, there is solver/*/inc/*minor.mk > (make-level variables VERSIONMAJOR, VERSIONMINOR, etc.) and there is > solenv/inc/version.hrc including versionlist.hrc (#defines for VERSION, > SUBVERSION, etc.).

[PATCH] Change in core[libreoffice-3-6]: fdo#58242: sw: fix more crashes when not on SwTxtNode

2013-01-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1615 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/1615/1 fdo#58242: sw: fix more crashes when not on SwTxtNode In getCrsrPropertyValue etc.; also add a unit test for the

Re: replacing OUString::valueOf(static_cast) ??

2013-01-09 Thread Michael Meeks
On Wed, 2013-01-09 at 16:10 +0200, Noel Grandin wrote: > maybe we need >OUString::valueOfInt32(sal_Int32) > that does the cast for us? > > At least it'll be less noisy, and we can document in one place why > it's necessary. Looks less error prone to me; doesn't suffer from odd side-

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/source/core/unocore/unocrsrhelper.cxx | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) New commits: commit e5add879def40a7695fb506b42c024ef9f776062 Author: Noel Power Date: Wed Jan 9 14:40:10 2013 +0100 fdo#58242: getCrsrPropertyValue: fix crashes w

[Libreoffice-commits] .: sw/AllLangResTarget_sw.mk sw/inc sw/source sw/uiconfig

2013-01-09 Thread Libreoffice Gerrit user
sw/AllLangResTarget_sw.mk|1 sw/inc/helpid.h |1 sw/source/ui/inc/glosbib.hxx | 46 +++-- sw/source/ui/inc/misc.hrc|3 sw/source/ui/misc/glosbib.cxx| 180 ++-- sw/source/ui/misc/glosb

[Libreoffice-commits] .: sw/inc sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/inc/viewopt.hxx |8 sw/source/ui/config/caption.cxx |2 +- sw/source/ui/config/fontcfg.cxx |8 sw/source/ui/config/modcfg.cxx | 12 ++-- sw/source/ui/config/optpage.cxx | 22 +++--- sw/source/ui/config/viewopt.cxx |2 +-

Re: Funding Wishlist

2013-01-09 Thread Michael Meeks
On Wed, 2013-01-09 at 15:59 +0100, Lubos Lunak wrote: > Hello, I'd like to ask, is there any plan to have such a mac machine? Or > preferably a shared mac build host where developers could test their changes > or find out more about tinderboxes breakages (which are sometimes rather hard > to d

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - sw/qa sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/qa/complex/writer/CheckTable.java | 32 + sw/source/core/unocore/unocrsrhelper.cxx | 39 +-- sw/source/core/unocore/unoobj.cxx|4 +++ sw/source/core/unocore/unoobj2.cxx |7 +++-- 4 files changed, 67 insertions(+),

[Libreoffice-commits] .: 2 commits - sw/qa sw/source

2013-01-09 Thread Libreoffice Gerrit user
sw/qa/complex/writer/CheckTable.java | 32 + sw/source/core/unocore/unocrsrhelper.cxx | 39 +-- sw/source/core/unocore/unoobj.cxx|4 +++ sw/source/core/unocore/unoobj2.cxx |7 +++-- 4 files changed, 67 insertions(+),

Re: Funding Wishlist

2013-01-09 Thread Lubos Lunak
On Wednesday 21 of November 2012, Thorsten Behrens wrote: > Marc Paré wrote: > > We are seriously looking at different teams' wishlists. Please do > > take a little time out of your busy schedule and speak to your teams > > about any funding for items that you think may be of importance to > > your

[Libreoffice-commits] .: sw/qa writerfilter/source

2013-01-09 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo58933.rtf | 28 + sw/qa/extras/rtfimport/rtfimport.cxx | 12 ++ writerfilter/source/rtftok/rtfdocumentimpl.cxx |7 +++--- 3 files changed, 44 insertions(+), 3 deletions(-) New commits: commit 555bc780c831142200

  1   2   >