[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2013-01-01 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Rainer Bielefeld changed: What|Removed |Added Depends on||58909 --- Comment #65 from Rainer Bie

[Libreoffice-commits] .: basic/source cui/source editeng/source linguistic/source sc/source sd/source sfx2/source svtools/source svx/source sw/source unotools/source

2013-01-01 Thread Libreoffice Gerrit user
basic/source/comp/loops.cxx|8 basic/source/comp/token.cxx| 10 -- basic/source/sbx/sbxscan.cxx |9 - cui/source/tabpages/tpbitmap.cxx |8 editeng/source/items/frmitems.cxx |8 linguistic/sour

[PATCH] The problem is that the process handle is freed regardless o...

2013-01-01 Thread Christopher Copits (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1530 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/1530/1 The problem is that the process handle is freed regardless of whether osl_executeProcess was successful or not.

[Libreoffice-commits] .: desktop/source

2013-01-01 Thread Libreoffice Gerrit user
desktop/source/deployment/inc/dp_misc.h |1 desktop/source/deployment/manager/dp_extensionmanager.cxx |2 desktop/source/pkgchk/unopkg/unopkg_app.cxx | 95 ++ desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx| 27 +-- desktop/sourc

Re: Wrong indentation which leads to segfault in sc/source/ui/docshell/docfunc.cxx

2013-01-01 Thread julien2412
BTW, it's not cppcheck which had safe iterator since it just allow to scan sources. I rather think it's "--enable-dbgutil" in autogen.lastrun which triggered safe iterator. Julien -- View this message in context: http://nabble.documentfoundation.org/Wrong-indentation-which-leads-to-segfault-in

[PUSHED] RTL_CONSTASCII_(U)STRINGPARAM removed in avmedia

2013-01-01 Thread Norbert Thiebaud (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1528 Approvals: Norbert Thiebaud: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1528 To unsubscribe, v

[PATCH] convert nss to gbuild

2013-01-01 Thread Peter Foley (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1529 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/1529/1 convert nss to gbuild Change-Id: I59edc4c437abccc201823d97f1cbec230d273b05 --- M RepositoryExternal.mk M config_

added Converter::convertColor with opacity parameter

2013-01-01 Thread Norbert Thiebaud (via Code Review)
Norbert Thiebaud has abandoned this change. Change subject: added Converter::convertColor with opacity parameter .. Patch Set 2: Abandoned re-abandon for now -- To view, visit https://gerrit.libreoffice.org/1526 To unsubscrib

added token for handling of svg:linearGradient and svg:radia...

2013-01-01 Thread Norbert Thiebaud (via Code Review)
Norbert Thiebaud has abandoned this change. Change subject: added token for handling of svg:linearGradient and svg:radialGradient .. Patch Set 2: Abandoned re-abandon for now -- To view, visit https://gerrit.libreoffice.org/

[Libreoffice-commits] .: avmedia/source

2013-01-01 Thread Libreoffice Gerrit user
avmedia/source/framework/mediacontrol.cxx |4 ++-- avmedia/source/quicktime/framegrabber.mm |6 +++--- avmedia/source/quicktime/manager.mm |6 +++--- avmedia/source/quicktime/player.mm|6 +++--- avmedia/source/quicktime/window.mm|6 +++--- 5 files changed

added Converter::convertColor with opacity parameter

2013-01-01 Thread Norbert Thiebaud (via Code Review)
Norbert Thiebaud has restored this change. Change subject: added Converter::convertColor with opacity parameter .. Patch Set 1: Restored need it for a while... do not submit -- To view, visit https://gerrit.libreoffice.org/15

added token for handling of svg:linearGradient and svg:radia...

2013-01-01 Thread Norbert Thiebaud (via Code Review)
Norbert Thiebaud has restored this change. Change subject: added token for handling of svg:linearGradient and svg:radialGradient .. Patch Set 1: Restored need it for a while: do not submit -- To view, visit https://gerrit.li

added token for handling of svg:linearGradient and svg:radia...

2013-01-01 Thread via Code Review
Christina Roßmanith has abandoned this change. Change subject: added token for handling of svg:linearGradient and svg:radialGradient .. Patch Set 1: Abandoned pushed accidentally -- To view, visit https://gerrit.libreoffice.

added Converter::convertColor with opacity parameter

2013-01-01 Thread via Code Review
Christina Roßmanith has abandoned this change. Change subject: added Converter::convertColor with opacity parameter .. Patch Set 1: Abandoned pushed accidentally -- To view, visit https://gerrit.libreoffice.org/1526 To unsubs

[PATCH] added token for handling of svg:linearGradient and svg:radia...

2013-01-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1527 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/1527/1 added token for handling of svg:linearGradient and svg:radialGradient Change-Id: I38014a8d9e21359cb943f813484478

[PATCH] RTL_CONSTASCII_(U)STRINGPARAM removed in avmedia

2013-01-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1528 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/1528/1 RTL_CONSTASCII_(U)STRINGPARAM removed in avmedia Change-Id: Id9ae8600d7f688bd733148663ef501b6ba2bc7d1 --- M avme

[PATCH] added Converter::convertColor with opacity parameter

2013-01-01 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1526 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/26/1526/1 added Converter::convertColor with opacity parameter Change-Id: I0f3759d8f75f2739b2815c37e8c81bc97e097ec8 --- M

[REVIEW for 4.0 and 3.6] fdo#47466 FORMATTING: Autoformat empty rows causes app to crash

2013-01-01 Thread julien2412
Hello, I don't reproduce the problem with 4.0 sources (I don't know why) but I can reproduce it with 3.6 sources. Anyway, would it be possible to cherry-pick f843850ee9994653673ef5591aae875d7fb22fed ? (it's just some 2 lacking braces) Julien -- View this message in context: http://nabble.docu

[Libreoffice-commits] .: icu/ExternalProject_icu.mk redland/ExternalProject_raptor.mk redland/ExternalProject_rasqal.mk redland/ExternalProject_redland.mk

2013-01-01 Thread Libreoffice Gerrit user
icu/ExternalProject_icu.mk |6 +++--- redland/ExternalProject_raptor.mk |4 ++-- redland/ExternalProject_rasqal.mk |4 ++-- redland/ExternalProject_redland.mk |4 ++-- 4 files changed, 9 insertions(+), 9 deletions(-) New commits: commit cdb86989d118eb9944537be5178275c6d8

[PATCH] fdo#58919 - Cursor is at Left when Table is converted to RTL...

2013-01-01 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1525 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/25/1525/1 fdo#58919 - Cursor is at Left when Table is converted to RTL in Impress Change-Id: I783af7134eec8045735a939a1322

[PUSHED] Added bulletsandnumbering .ui

2013-01-01 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1352 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1352 To unsubscribe, vi

[Libreoffice-commits] .: tools/CustomTarget_reversemap.mk

2013-01-01 Thread Libreoffice Gerrit user
tools/CustomTarget_reversemap.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0ce5edfbcf8d404afd5f2fbf4376cc94521a541a Author: Luboš Luňák Date: Tue Jan 1 17:19:54 2013 +0100 no non-ordering dependencies on /.dir As that'd be like forcing a rema

[PUSHED] fdo#58651 improve layout/spacing of positionpage.ui

2013-01-01 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1472 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1472 To unsubscribe, vi

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - cui/uiconfig

2013-01-01 Thread Libreoffice Gerrit user
cui/uiconfig/ui/positionpage.ui | 300 ++-- 1 file changed, 165 insertions(+), 135 deletions(-) New commits: commit 5ee54bcb9c7713c7233b0bb9f7671c6e61047585 Author: Jack Leigh Date: Sun Dec 23 00:06:57 2012 + fdo#58651 improve layout/spacing of pos

[Libreoffice-commits] .: cui/uiconfig

2013-01-01 Thread Libreoffice Gerrit user
cui/uiconfig/ui/positionpage.ui | 300 ++-- 1 file changed, 165 insertions(+), 135 deletions(-) New commits: commit e350815692a9f660f2dabddc0f76262697b64a1b Author: Jack Leigh Date: Sun Dec 23 00:06:57 2012 + fdo#58651 improve layout/spacing of pos

Re: Wrong indentation which leads to segfault in sc/source/ui/docshell/docfunc.cxx

2013-01-01 Thread julien2412
Thank you John for your investigation about all this. In fact, I was leafing through some cppcheck reports. To simplify, I pushed some slight fixes in sc/source/core/tool/autoform.cxx (see http://cgit.freedesktop.org/libreoffice/core/commit/?id=2e1abe1c59b1121ffb5d46afe82ce985cb70c4db). So now w

[Libreoffice-commits] .: sc/source

2013-01-01 Thread Libreoffice Gerrit user
sc/source/ui/docshell/docfunc.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit f843850ee9994653673ef5591aae875d7fb22fed Author: Julien Nabet Date: Tue Jan 1 16:23:16 2013 +0100 fdo#47466 FORMATTING: Autoformat empty rows causes app to crash Thank you John LeMoyn

[Libreoffice-commits] .: sc/source

2013-01-01 Thread Libreoffice Gerrit user
sc/source/core/tool/autoform.cxx | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) New commits: commit 2e1abe1c59b1121ffb5d46afe82ce985cb70c4db Author: Julien Nabet Date: Tue Jan 1 15:17:21 2013 +0100 Fix some 'bRet' is reassigned a value before the old one has been used

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - cui/source sfx2/source solenv/inc

2013-01-01 Thread Libreoffice Gerrit user
cui/source/dialogs/about.src |2 +- sfx2/source/appl/app.src |2 +- solenv/inc/minor.mk |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 51d43bd1b9189b0510a4d4ce392f5ac234441948 Author: Andras Timar Date: Tue Jan 1 14:42:33 2013 +0100 Bu

[Libreoffice-commits] .: cui/source sfx2/source solenv/inc

2013-01-01 Thread Libreoffice Gerrit user
cui/source/dialogs/about.src |2 +- sfx2/source/appl/app.src |2 +- solenv/inc/minor.mk |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) New commits: commit 4f21a0de363116cde65151d09ef4af9aff08886c Author: Andras Timar Date: Tue Jan 1 14:42:33 2013 +0100 Bu

linux / solaris vs other *nix file handling in sal/osl/unx/file.c

2013-01-01 Thread Riccardo Magliocchetti
Hello, does anyone know why linux and solaris are using pread / pwrite syscalls while other unixes are using read + lseek? The code is at least FileHandle_Impl::writeAt which AFAIU is the base for the osl_* file functions. Googling a bit shows that postgresql discussed the issue in 2003 and

[PATCH] fdo#55582 writer, calc: insert shapes also when shapes selec...

2013-01-01 Thread Lennard Wasserthal (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1524 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/1524/1 fdo#55582 writer, calc: insert shapes also when shapes selected In writer, Pasting shapes overwrote others that

[PUSHED] Minimal fix fdo#58766 Macro Recorder opt not saved

2013-01-01 Thread Tor Lillqvist (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1523 Approvals: Tor Lillqvist: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1523 To unsubscribe, visi

[Libreoffice-commits] .: svtools/source

2013-01-01 Thread Libreoffice Gerrit user
svtools/source/config/miscopt.cxx | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) New commits: commit 4ae569eb3e6d587aed6885b46c78f0d9bcbbb0b2 Author: LeMoyne Castle Date: Mon Dec 31 00:18:35 2012 -0700 Minimal fix fdo#58766 Macro Recorder opt not saved

[Libreoffice-commits] .: 2 commits - pyuno/CustomTarget_python_shell.mk pyuno/CustomTarget_pyversion.mk pyuno/Executable_python_wrapper.mk pyuno/Module_pyuno.mk pyuno/zipcore

2013-01-01 Thread Libreoffice Gerrit user
pyuno/CustomTarget_python_shell.mk | 25 +++-- pyuno/CustomTarget_pyversion.mk| 37 - pyuno/Executable_python_wrapper.mk |8 pyuno/Module_pyuno.mk |2 -- pyuno/zipcore/mac.sh |9

[Libreoffice-commits] .: 4 commits - i18npool/inc sd/source vcl/inc

2013-01-01 Thread Libreoffice Gerrit user
i18npool/inc/textconversion.hxx |2 ++ sd/source/ui/dlg/RemoteDialog.cxx |4 ++-- vcl/inc/ios/salgdicommon.hxx | 30 -- vcl/inc/ios/salprn.h |2 +- 4 files changed, 21 insertions(+), 17 deletions(-) New commits: commit ae5c574ac24ed897

[Libreoffice-commits] .: configure.ac

2013-01-01 Thread Libreoffice Gerrit user
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 61e0deb8c5200cdc66a8d6215a462e433f1804da Author: Stephan Bergmann Date: Tue Jan 1 12:13:23 2013 +0100 Obsolete AM_CONFIG_HEADER -> AC_CONFIG_HEADERS (cf.

[Libreoffice-commits] .: i18npool/inc

2013-01-01 Thread Libreoffice Gerrit user
i18npool/inc/collator_unicode.hxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit 5275fabcb0c3941e32c23b9a9f66f395ab10b251 Author: Tor Lillqvist Date: Tue Jan 1 11:31:05 2013 +0200 WaE: private field 'hModule' is not used Change-Id: If3fc6937e66e9261255a9b197f995d9

[Libreoffice-commits] .: 4 commits - configure.ac solenv/gbuild

2013-01-01 Thread Libreoffice Gerrit user
configure.ac | 16 +--- solenv/gbuild/AllLangResTarget.mk|4 ++-- solenv/gbuild/Helper.mk |2 +- solenv/gbuild/InstallModuleTarget.mk |2 +- solenv/gbuild/SdiTarget.mk |2 +- solenv/gbuild/TargetLocations.mk | 1