[PATCH] Added Table Properties Widget

2012-12-29 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1511 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/11/1511/1 Added Table Properties Widget Change-Id: I019b99e6194458b8b311b0cc3f2e231ef898ece0 --- A sw/uiconfig/swriter/ui/

Added tableproperties.ui

2012-12-29 Thread gokul s (via Code Review)
gokul s has abandoned this change. Change subject: Added tableproperties.ui .. Patch Set 2: Abandoned Have Resubmitted the patch -- To view, visit https://gerrit.libreoffice.org/1347 To unsubscribe, visit https://gerrit.libre

[PUSHED] fdo#39440 - cppcheck cleanliness

2012-12-29 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1508 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1508 To unsubscribe, vi

[Libreoffice-commits] .: sc/source ucb/workben

2012-12-29 Thread Libreoffice Gerrit user
sc/source/ui/vba/vbahelper.cxx |2 +- ucb/workben/ucb/ucbdemo.cxx|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit c5132e30fb09477aa46d810dd86727b3aa8cf20e Author: Radu Ioan Date: Sun Dec 30 02:47:09 2012 +0200 fdo#39440 - cppcheck cleanliness

[PATCH] fdo#39440 - cppcheck cleanliness

2012-12-29 Thread Ioan Radu (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1508 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/08/1508/1 fdo#39440 - cppcheck cleanliness Correct some strings Change-Id: Ic019cb11b87cd51e7ffd1fb8f16b79dff381936c ---

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 --- Comment #64 from Rainer Bielefeld --- Add "Bug 58863 - FILEOPEN .xlsx: "IF" condition not calculated": very basic function, additional functions might be affected. -- You are receiving this mail because: You are on the CC list for the bug.

[Libreoffice-commits] .: sc/source

2012-12-29 Thread Libreoffice Gerrit user
sc/source/core/data/fillinfo.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 26a0979711f89915508359a9804765d934631ec2 Author: Julien Nabet Date: Sat Dec 29 19:42:57 2012 +0100 bHOver isn't used in second loop and afterwards See http://nabble.documentfoundation.

Re: Questions about function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx

2012-12-29 Thread Markus Mohrhard
Hey, > In function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx, what's the > use to process "bHOver" variable in while (bVOver) ? It is unused. Just copy pasted code from the bHOver case. > I thought about these too: > - declaring nOverlap before the 2 loops, it would avoid to declare it

[PUSHED] Added Digital signature widgets .ui

2012-12-29 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1351 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1351 To unsubscribe, vi

[Libreoffice-commits] .: sw/uiconfig

2012-12-29 Thread Libreoffice Gerrit user
sw/uiconfig/swriter/ui/digitalsignature.ui | 227 sw/uiconfig/swriter/ui/selectcertificate.ui | 205 + 2 files changed, 432 insertions(+) New commits: commit 86c2f4690b1fc5c65c1d36ca140ba65654debfca Author: Gokul Date: Sun Dec 16 10:49:19

Questions about function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx

2012-12-29 Thread julien2412
Hello, In function lcl_GetMergeRange sc/source/core/data/fillinfo.cxx, what's the use to process "bHOver" variable in while (bVOver) ? I thought about these too: - declaring nOverlap before the 2 loops, it would avoid to declare it each time in the else of both loops. - bVOver treatment is useles

RE: [libreoffice-accessibility] where's the accessibility?

2012-12-29 Thread V Stuart Foote
Tom, Probably, I'm pretty certain this issue has actually been with us since the Java JRE 1.6 -> JRE 1.7 crossover. It impacts usability with AT because large segments of the GUI are no longer functional with screen and brail readers under JRE 1.7's Java Accessibility API even though the JAB is

[Libreoffice-commits] .: sc/source tools/source vcl/unx

2012-12-29 Thread Libreoffice Gerrit user
sc/source/core/data/column2.cxx |2 +- sc/source/core/data/conditio.cxx|5 ++--- sc/source/core/data/documen8.cxx|5 ++--- sc/source/core/data/fillinfo.cxx|2 +- sc/source/ui/condformat/colorformat.cxx |3 +-- tools/source/inet/inetstrm.cxx

[PATCH] Simple fix for fdo#58766

2012-12-29 Thread LeMoyne Castle (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1506 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/1506/1 Simple fix for fdo#58766 Load (and thereby Commit) of the last misc. config item in the define block was broken

[PATCH] Cleanup OUString, macros, includes, etc in desktop

2012-12-29 Thread LeMoyne Castle (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1505 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/1505/1 Cleanup OUString, macros, includes, etc in desktop Removed OUString macros, excess namespace stuff, unused inclu

[PUSHED] Remove rtl prefixes and some RTL_CONST* from basic

2012-12-29 Thread Olivier Hallot (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1504 Approvals: Olivier Hallot: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1504 To unsubscribe, vis

[Libreoffice-commits] .: basic/qa

2012-12-29 Thread Libreoffice Gerrit user
basic/qa/cppunit/test_scanner.cxx | 78 +++--- 1 file changed, 39 insertions(+), 39 deletions(-) New commits: commit b2e5700d0961d8f2e2f0596fb309eb3d1006193f Author: Marcos Paulo de Souza Date: Sat Dec 29 12:59:16 2012 -0200 Remove rtl prefixes and some R

[PUSHED] Remove last usage of RTL_CONSTASCII_STRINGPARAM in basctl

2012-12-29 Thread Olivier Hallot (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1502 Approvals: Olivier Hallot: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1502 To unsubscribe, vis

[PUSHED] Remove last RTL_CONSTASCII_STRINGPARAM from animations

2012-12-29 Thread Olivier Hallot (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1501 Approvals: Olivier Hallot: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1501 To unsubscribe, vis

[Libreoffice-commits] .: basctl/source

2012-12-29 Thread Libreoffice Gerrit user
basctl/source/basicide/moduldl2.cxx |4 ++-- basctl/source/basicide/scriptdocument.cxx |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 1d1abd28c2d4aab7c6ccfe94e49bd974fa5982bf Author: Marcos Paulo de Souza Date: Sat Dec 29 11:32:51 2012 -0200

[Libreoffice-commits] .: animations/source

2012-12-29 Thread Libreoffice Gerrit user
animations/source/animcore/targetpropertiescreator.cxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 85f27205f41e7b6e63ea7fa0de9e3cb6a15b9bae Author: Marcos Paulo de Souza Date: Sat Dec 29 11:15:01 2012 -0200 Remove last RTL_CONSTASCII_STRINGPARA

[PUSHED] Remove last RTL_CONSTASCII_* from accessibility

2012-12-29 Thread Olivier Hallot (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1500 Approvals: Olivier Hallot: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1500 To unsubscribe, vis

[Libreoffice-commits] .: accessibility/bridge accessibility/source

2012-12-29 Thread Libreoffice Gerrit user
accessibility/bridge/source/java/WindowsAccessBridgeAdapter.cxx |4 ++-- accessibility/source/standard/vclxaccessiblebutton.cxx |6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) New commits: commit d204c1a47ef7215ca3e1ef198e81d9eeaed2095a Author: Marcos Paulo de Souza

[PATCH] Remove rtl prefixes and some RTL_CONST* from basic

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1504 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/1504/1 Remove rtl prefixes and some RTL_CONST* from basic Change-Id: If15d7c97de5295ea7d7f341e6b34acbfc917218d Signed-o

[Libreoffice-commits] .: cli_ure/CliNativeLibrary_cli_cppuhelper.mk cli_ure/Library_cli_cppuhelper_native.mk shell/Library_recentfile.mk

2012-12-29 Thread Libreoffice Gerrit user
0 files changed New commits: commit a7ef93ed1b6b19bc343c71eb9b16f8616517e6a6 Author: Peter Foley Date: Sat Dec 29 09:57:54 2012 -0500 drop executable bit Change-Id: I092a8183b7aa044cc6e55df91ac1109e269d8b8e diff --git a/cli_ure/CliNativeLibrary_cli_cppuhelper.mk b/cli_ure/CliNa

[PATCH] fdo#57950: Remove chained append and simplify strings

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1503 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/1503/1 fdo#57950: Remove chained append and simplify strings No need to two strings here, since just destFolder is used

[PATCH] Remove last RTL_CONSTASCII_STRINGPARAM from animations

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1501 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/1501/1 Remove last RTL_CONSTASCII_STRINGPARAM from animations Change-Id: Ib774bc7f70492910a2f3e7ac3088c4e07127b563 Sign

[PATCH] Remove last usage of RTL_CONSTASCII_STRINGPARAM in basctl

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1502 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/1502/1 Remove last usage of RTL_CONSTASCII_STRINGPARAM in basctl Change-Id: I5bc79699e794de47611d785b9ae48b4badf9f2f6 S

[Libreoffice-commits] .: 3 commits - external/Package_mingw_dlls.mk external/Package_msms.mk external/Package_msvc_dlls.mk i18npool/CustomTarget_breakiterator.mk mythes/ExternalPackage_mythes.mk Repos

2012-12-29 Thread Libreoffice Gerrit user
Repository.mk |1 - RepositoryExternal.mk | 16 i18npool/CustomTarget_breakiterator.mk | 10 -- mythes/ExternalPackage_mythes.mk |3 --- 4 files changed, 8 insertions(+), 22 deletions(-) New commits: commit 27a66

[PATCH] Fix calls to SfxPoolItem* Put with a Which-ID of sal_false

2012-12-29 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1499 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/1499/1 Fix calls to SfxPoolItem* Put with a Which-ID of sal_false Change-Id: I39914909fd394532e7a32c791d4480530393c1c0

[PATCH] Remove last RTL_CONSTASCII_* from accessibility

2012-12-29 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1500 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/1500/1 Remove last RTL_CONSTASCII_* from accessibility Change-Id: Icb8f66c9f6ad70828aa55580a1f3aae8b2af1593 Signed-off-

When the software using SDK is started, Calc under operation is an abnormal end.

2012-12-29 Thread Miday
Hi, I contributes for the first time. I released the software which operates by Ubuntu. This software processes the data copied from Calc. This software referred to DocumentLoader.cxx of example and was created. LibreOffice SDK and gtk is used. This software is displaying and creating the book

[PATCH] Fix wrong bracketing

2012-12-29 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1498 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/98/1498/1 Fix wrong bracketing Wrong bracketing, item is put at a which-id of sal_false. Change-Id: Ic4216519d74de75690b2

libreoffice@lists.freedesktop.org

2012-12-29 Thread julien2412
Thank you David, I applied your suggestion, see https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=cf068828d334fcb0998755118e262d16c9db5b3a Julien -- View this message in context: http://nabble.documentfoundation.org/Cppcheck-false-positive-eg-PropEntry-operator-should-return-Prop

[Libreoffice-commits] .: lingucomponent/source

2012-12-29 Thread Libreoffice Gerrit user
lingucomponent/source/languageguessing/simpleguesser.cxx |7 ++- lingucomponent/source/languageguessing/simpleguesser.hxx |6 +++--- 2 files changed, 9 insertions(+), 4 deletions(-) New commits: commit cf068828d334fcb0998755118e262d16c9db5b3a Author: Julien Nabet Date: Sat Dec 29 1

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - extras/CustomTarget_autocorr.mk filter/Configuration_filter.mk filter/CustomTarget_svg.mk i18npool/CustomTarget_localedata.mk officecfg/CustomTarget

2012-12-29 Thread Libreoffice Gerrit user
RepositoryExternal.mk | 20 ++-- extras/CustomTarget_autocorr.mk |2 filter/Configuration_filter.mk|4 filter/CustomTarget_svg.mk|2 i18npool/CustomTarget_localedata.mk |2 officecfg/CustomTarget_registry.mk|2 readlicense_

[PATCH] Change if-statements to switch

2012-12-29 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1497 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/97/1497/1 Change if-statements to switch The bit-values do overlap, 3rd and 4th case were never reached. Change-Id: Iaaf3

[Libreoffice-commits] .: 3 commits - extras/CustomTarget_autocorr.mk filter/Configuration_filter.mk filter/CustomTarget_svg.mk i18npool/CustomTarget_breakiterator.mk i18npool/CustomTarget_localedata.m

2012-12-29 Thread Libreoffice Gerrit user
Repository.mk |4 RepositoryExternal.mk | 96 -- extras/CustomTarget_autocorr.mk|2 filter/Configuration_filter.mk |4 filter/CustomTarget_svg.mk |2 i18npool/CustomTarget_breakiterator.mk |

[PATCH] Fix wrong default return values

2012-12-29 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1496 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/96/1496/1 Fix wrong default return values Change-Id: Iba1a46b91a79e41fae1661d9d3742d6195e4c4dc --- M cui/source/tabpages/p

[Libreoffice-commits] .: sw/CppunitTest_sw_swdoc_test.mk

2012-12-29 Thread Libreoffice Gerrit user
sw/CppunitTest_sw_swdoc_test.mk |3 +++ 1 file changed, 3 insertions(+) New commits: commit 2f0e0daf9b94dcb15af84c4a00682d14ebfc5000 Author: David Tardon Date: Sat Dec 29 12:11:47 2012 +0100 sw_swdoc_test needs more services Change-Id: Ia548732840d0fb15ee567629045ab430855cf84

[Libreoffice-commits] .: l10ntools/source

2012-12-29 Thread Libreoffice Gerrit user
l10ntools/source/po.cxx | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) New commits: commit 07e15b1ff368e4168e72e61bb924a6760b81d89f Author: Zolnai Tamás Date: Sat Dec 29 11:18:05 2012 +0100 po.cxx: use static and const to increase efficiency Change-

libreoffice@lists.freedesktop.org

2012-12-29 Thread David Tardon
Hi, On Thu, Dec 27, 2012 at 01:12:27PM -0800, julien2412 wrote: > Thank you Lubos for the reference. > So I won't change these since it could generate some regressions if badly > done. > > About first report, I meant that = operator is a priori for assignment not > for comparison. So even if the

[Libreoffice-commits] .: filter/source tools/inc tools/source unotools/inc unotools/source

2012-12-29 Thread Libreoffice Gerrit user
filter/source/xsltdialog/xmlfiltertestdialog.cxx | 90 ++- tools/inc/tools/tempfile.hxx |3 tools/source/fsys/tempfile.cxx | 114 +- unotools/inc/unotools/tempfile.hxx |3 unotools/source/ucbhelper/tempfile.cxx

Last call: Hackfest travel refunds

2012-12-29 Thread Florian Effenberger
Hello, this is a last call to send your travel refund requests for the Munich Hackfest to treasu...@documentfoundation.org as soon as possible. I'd like to initiate payments early next year, so participants have their money in time. If you have questions, feel free to poke me directly offlis