fdo#56124 add calc functions IFERROR and IFNA as in ODFF1.2

2012-12-24 Thread Norbert Thiebaud (via Code Review)
Norbert Thiebaud has abandoned this change. Change subject: fdo#56124 add calc functions IFERROR and IFNA as in ODFF1.2 .. Patch Set 1: Abandoned no follow-up from author -- To view, visit https://gerrit.libreoffice.org/1116 T

[PUSHED] Fix for rtfexport subsequenttest

2012-12-24 Thread Norbert Thiebaud (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1464 Approvals: Norbert Thiebaud: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1464 To unsubscribe, vi

[Libreoffice-commits] .: sw/source

2012-12-24 Thread Libreoffice Gerrit user
sw/source/filter/ww8/rtfattributeoutput.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 2d8a50d3f8a5af914e2e184796bfab05df52c539 Author: LeMoyne Castle Date: Fri Dec 21 09:20:16 2012 -0700 Fix for rtfexport subsequenttest was re-using previous dat

[PUSHED] OUString cleanup in editeng/acessibility

2012-12-24 Thread Norbert Thiebaud (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1471 Approvals: Norbert Thiebaud: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1471 To unsubscribe, vi

[PUSHED] OUString cleanup in editeng/acessibility

2012-12-24 Thread Norbert Thiebaud (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1469 Approvals: Thomas Arnhold: Verified; Looks good to me, but someone else must approve Norbert Thiebaud: Verified; Looks good to me, approve

[PUSHED] OUString cleanups in editeng/accessibility

2012-12-24 Thread Norbert Thiebaud (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1468 Approvals: Thomas Arnhold: Verified; Looks good to me, but someone else must approve Norbert Thiebaud: Verified; Looks good to me, approve

[Libreoffice-commits] .: editeng/source

2012-12-24 Thread Libreoffice Gerrit user
editeng/source/accessibility/AccessibleImageBullet.cxx | 38 - 1 file changed, 19 insertions(+), 19 deletions(-) New commits: commit 071b7eea798acfbe765c462c5d5b9a45abd13f63 Author: Olivier Hallot Date: Sat Dec 22 18:00:14 2012 -0200 OUString cleanup in editeng/acessibil

[Libreoffice-commits] .: editeng/source

2012-12-24 Thread Libreoffice Gerrit user
editeng/source/accessibility/AccessibleParaManager.cxx|2 - editeng/source/accessibility/AccessibleSelectionBase.cxx |1 editeng/source/accessibility/AccessibleStaticTextBase.cxx | 25 ++ 3 files changed, 13 insertions(+), 15 deletions(-) New commits: commit cd54670045

[Libreoffice-commits] .: editeng/source

2012-12-24 Thread Libreoffice Gerrit user
editeng/source/accessibility/AccessibleComponentBase.cxx| 10 - editeng/source/accessibility/AccessibleContextBase.cxx | 39 ++--- editeng/source/accessibility/AccessibleEditableTextPara.cxx | 88 ++-- editeng/source/accessibility/AccessibleHyperlink.cxx|6 edit

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-12-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 --- Comment #188 from iveand --- Added 54275: this bug prevents Ubuntu Linux users (not confirmed for other distros) to be able to save documents to mounted gvfs samba shares (when navigating via nautilus sidebar menu). Seems very critical for a

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-12-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 iveand changed: What|Removed |Added Depends on||54275 -- You are receiving this mail because:

[Libreoffice-commits] .: 2 commits - sw/inc sw/source

2012-12-24 Thread Libreoffice Gerrit user
sw/inc/shellio.hxx |2 sw/source/filter/inc/fltshell.hxx| 42 +-- sw/source/filter/inc/wrtswtbl.hxx| 12 ++--- sw/source/filter/inc/wwstyles.hxx|2 sw/source/filter/writer/writer.cxx |6 +- sw/source/filter/writer/wrtswtbl.cxx |

[PUSHED] Do not run autogen.sh if we don't want to. (for help, clean, ...

2012-12-24 Thread Peter Foley (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1479 Approvals: Peter Foley: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1479 To unsubscribe, visit h

[Libreoffice-commits] .: Makefile.in

2012-12-24 Thread Libreoffice Gerrit user
Makefile.in |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit ae20a668cc3a26da59d1dcd752a9c0be79196599 Author: Matúš Kukan Date: Sun Dec 23 20:36:29 2012 +0100 Do not run autogen.sh if we don't want to. (for help, clean, distclean) Change-Id: Ic2

[PUSHED] merge Makefile and Makefile.top again

2012-12-24 Thread Peter Foley (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1478 Approvals: Peter Foley: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1478 To unsubscribe, visit h

[Libreoffice-commits] .: Makefile.in

2012-12-24 Thread Libreoffice Gerrit user
Makefile.in |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6763a59564c3b34c46e4acd8ea9f5feb42f35969 Author: Peter Foley Date: Mon Dec 24 17:39:09 2012 -0500 connectivity is now a gbuild module Change-Id: I2c0b387aed6ae229f9ebe4e8b30abea37884a657 dif

[Libreoffice-commits] .: Makefile.in Makefile.top

2012-12-24 Thread Libreoffice Gerrit user
Makefile.in | 403 +-- Makefile.top | 390 - 2 files changed, 394 insertions(+), 399 deletions(-) New commits: commit 0e6212c81a837180db5b8ea29d0d2a529b4b1924 Author: Matúš Kukan

[Libreoffice-commits] .: 5 commits - cli_ure/source configure.ac

2012-12-24 Thread Libreoffice Gerrit user
cli_ure/source/climaker/climaker_app.cxx | 16 cli_ure/source/climaker/climaker_emit.cxx |3 configure.ac | 739 +- 3 files changed, 359 insertions(+), 399 deletions(-) New commits: commit 4a3018e4eceb981aadbadbe3eadff4c17f018357

[PUSHED] merge packimages into postprocess

2012-12-24 Thread Peter Foley (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1476 Approvals: Peter Foley: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1476 To unsubscribe, visit h

[Libreoffice-commits] .: android/prj instsetoo_native/prj Makefile.top packimages/CustomTarget_images.mk packimages/Makefile packimages/Module_packimages.mk packimages/pack packimages/Package_images.m

2012-12-24 Thread Libreoffice Gerrit user
Makefile.top |8 RepositoryModule_ooo.mk |1 android/prj/build.lst |2 instsetoo_native/prj/build.lst|2 packimages/CustomTarget_images.mk | 84 packimages/Makefile |7 packimag

[Libreoffice-commits] .: sdext/source

2012-12-24 Thread Libreoffice Gerrit user
sdext/source/pdfimport/config/pdf_types.xcu |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit f0549b519dda504ada91ca6aaba25d22b5d786f6 Author: Peter Foley Date: Mon Dec 24 13:18:03 2012 -0500 fix postprocess xcu warning /home/peter/libreoffice/solver/un

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread Julien Nabet
On 24/12/2012 18:29, Norbert Thiebaud wrote: On Mon, Dec 24, 2012 at 8:45 AM, julien2412 wrote: Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a straightforward patch:

Re: Using memset or other way in sal/osl/unx/security.c

2012-12-24 Thread Julien Nabet
On 24/12/2012 18:08, Norbert Thiebaud wrote: On Mon, Dec 24, 2012 at 8:59 AM, julien2412 wrote: Hello, In sal/osl/unx/security.c, I noticed these: 278 sal_Bool SAL_CALL osl_getHomeDir(oslSecurity Security, rtl_uString **pustrDirectory) 279 { 280 sal_Bool bRet=sal_False;

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread Norbert Thiebaud
On Mon, Dec 24, 2012 at 8:45 AM, julien2412 wrote: > Hello, > > By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment > function, I wonder if we could replace the for loop by a memset to optimize > a bit. > So here's a straightforward patch: > diff --git a/sal/typesconfig/types

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread julien2412
Riccardo Magliocchetti wrote > Il 24/12/2012 15:45, julien2412 ha scritto: >> diff --git a/sal/typesconfig/typesconfig.c >> b/sal/typesconfig/typesconfig.c >> index 473f07a..ef52c5f 100644 >> --- a/sal/typesconfig/typesconfig.c >> +++ b/sal/typesconfig/typesconfig.c >> @@ -262,11 +262,9 @@ int GetA

Re: Using memset or other way in sal/osl/unx/security.c

2012-12-24 Thread Norbert Thiebaud
On Mon, Dec 24, 2012 at 8:59 AM, julien2412 wrote: > Hello, > > In sal/osl/unx/security.c, I noticed these: > 278 sal_Bool SAL_CALL osl_getHomeDir(oslSecurity Security, rtl_uString > **pustrDirectory) > 279 { > 280 sal_Bool bRet=sal_False; > 281 sal_Char pszDirectory[PATH_M

Re: [PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread Riccardo Magliocchetti
Il 24/12/2012 15:45, julien2412 ha scritto: Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a straightforward patch: diff --git a/sal/typesconfig/typesconfig.c b/sal/type

[Libreoffice-commits] .: 3 commits - accessibility/source framework/source sd/source

2012-12-24 Thread Libreoffice Gerrit user
accessibility/source/extended/textwindowaccessibility.cxx |2 +- framework/source/jobs/jobresult.cxx |4 +--- framework/source/services/pathsettings.cxx|4 +--- framework/source/services/substitutepathvars.cxx |2 +- framework/source/u

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - svx/source

2012-12-24 Thread Libreoffice Gerrit user
svx/source/svdraw/svdobj.cxx | 32 1 file changed, 32 insertions(+) New commits: commit 917616f1e15f06533f7380a309b1ccea0920f8f6 Author: David Tardon Date: Mon Dec 24 12:47:19 2012 +0100 fdo#56980, fdo#58267 don't leave stale SdrObject refs around

[PATCH] Change in core[libreoffice-3-6]: fdo#57678 fix import of RTF_PARD between RTF_CELL and RTF_RO...

2012-12-24 Thread Miklos Vajna (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1482 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/1482/1 fdo#57678 fix import of RTF_PARD between RTF_CELL and RTF_ROW (cherry picked from commits 6fc868c6535932bedfa0fc

[Libreoffice-commits] .: svx/source

2012-12-24 Thread Libreoffice Gerrit user
svx/source/svdraw/svdobj.cxx | 32 1 file changed, 32 insertions(+) New commits: commit 31b93b8600a3e219d33173aa68d9ab570e477e50 Author: David Tardon Date: Mon Dec 24 12:47:19 2012 +0100 fdo#56980, fdo#58267 don't leave stale SdrObject refs around

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/qa writerfilter/source

2012-12-24 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo57678.rtf | 34 + sw/qa/extras/rtfimport/rtfimport.cxx | 10 +++ writerfilter/source/rtftok/rtfdocumentimpl.cxx | 12 +--- 3 files changed, 52 insertions(+), 4 deletions(-) New commits: commit f9c0deef40a59095c61

Using memset or other way in sal/osl/unx/security.c

2012-12-24 Thread julien2412
Hello, In sal/osl/unx/security.c, I noticed these: 278 sal_Bool SAL_CALL osl_getHomeDir(oslSecurity Security, rtl_uString **pustrDirectory) 279 { 280 sal_Bool bRet=sal_False; 281 sal_Char pszDirectory[PATH_MAX]; 282 283 pszDirectory[0] = '\0'; 373 sal_Bool

License Statement

2012-12-24 Thread Abdulelah Saad Alarifi
Hi, All of my past & future contributions to LibreOffice may be licensed under the MPL 1.1/LGPLv3+ dual license. Regards Abdulelah Al-Arifi Warning: This message and its attachment, if any, are confidential and may contain information protected by law. If you are not the intended recipient,

Questions about Bug 39370:RTL / LTR and right/left alignment buttons' icons should not be reversed in RTL interface.

2012-12-24 Thread Manal M. Alhassoun
Hello all, Here is the bug's page: https://bugs.freedesktop.org/show_bug.cgi?id=39370 1- First, In the RTL UI, Does the toolbar automatically flips the order and alignment of its items ? 2- I'm thinking to solve this bug by adding a new Formatting Toolbar for the RTL UI that have the buttons

[PATCH] Replace loop by memset in sal/typesconfig/typesconfig.c

2012-12-24 Thread julien2412
Hello, By taking a look at the file sal/typesconfig/typesconfig.c, GetAlignment function, I wonder if we could replace the for loop by a memset to optimize a bit. So here's a straightforward patch: diff --git a/sal/typesconfig/typesconfig.c b/sal/typesconfig/typesconfig.c index 473f07a..ef52c5f

[Libreoffice-commits] .: sw/qa writerfilter/source

2012-12-24 Thread Libreoffice Gerrit user
sw/qa/extras/rtfimport/data/fdo57678.rtf | 34 + sw/qa/extras/rtfimport/rtfimport.cxx | 10 +++ writerfilter/source/rtftok/rtfdocumentimpl.cxx | 12 +--- 3 files changed, 52 insertions(+), 4 deletions(-) New commits: commit 4a507f732d82c188ad8

WIP fdo#56124 add IFERROR and IFNA to calc

2012-12-24 Thread Winfried Donkers (via Code Review)
Winfried Donkers has abandoned this change. Change subject: WIP fdo#56124 add IFERROR and IFNA to calc .. Patch Set 1: Abandoned final code will be submitted separately -- To view, visit https://gerrit.libreoffice.org/1343 To

Re: [libreoffice-marketing] Latest Hardware and OS

2012-12-24 Thread Tom Davies
Hi :)  No.  At least i think the answer to that is no I think "how many might" is a moving target.  At the moment those devices are probably not seen as good things to use to edit documents.  Pi is more about learning programming and building bits of hardware.  Android is more about just c

[PATCH] Code enhancement remove duplicate code from presenter consol...

2012-12-24 Thread abdulmajeed ahmed (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1480 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/1480/1 Code enhancement remove duplicate code from presenter console Change-Id: Ibbb131b64c66307d38a135ac570c1e2ed37bef