[PATCH] Added Digital signature widgets .ui

2012-12-15 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1351 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/1351/1 Added Digital signature widgets .ui Change-Id: Ide3a4f97ff229edc6c1cab8f62a66b43c33439d1 --- A sw/uiconfig/swrit

Re: [REVIEW 3-6] fix for fdo#56742 , ScRangeList::UpdateReference does not handle URM_COPY

2012-12-15 Thread Markus Mohrhard
Hey Eike, > >> [1] fixes [2] which is more or less a problem in >> ScRangeList::UpdateReference but we can't safely change it as there >> might be some users that rely on this behavior. So we just map >> URM_COPY to URM_MOVE which does the right thing in our case too. > > Hmm.. sure it doesn't int

Re: [REVIEW 3-6] fix for fdo#56742 , ScRangeList::UpdateReference does not handle URM_COPY

2012-12-15 Thread Eike Rathke
Hi Markus, On Saturday, 2012-12-15 15:28:49 +0100, Markus Mohrhard wrote: > [1] fixes [2] which is more or less a problem in > ScRangeList::UpdateReference but we can't safely change it as there > might be some users that rely on this behavior. So we just map > URM_COPY to URM_MOVE which does the

[Libreoffice-commits] .: postprocess/CustomTarget_config.mk

2012-12-15 Thread Libreoffice Gerrit user
postprocess/CustomTarget_config.mk |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 3bbe79eef841ae4a756593557641e32fa28c0184 Author: Matúš Kukan Date: Sun Dec 16 01:14:38 2012 +0100 postprocess: execute packconfig.pl inside postprocess/packconfig directory

Re: additional calc functions produce warnings

2012-12-15 Thread Eike Rathke
Hi tino, On Friday, 2012-12-14 22:22:40 +, tino wrote: > > Now I can see them with that obvious tip. Resource > > RID_PRICING_DEFFUNCTION_NAME is empty in > > scaddins/source/pricing/pricing.src > > Ah yes, thanks for that. I left that empty because I assumed this was > optional and I didn't

Re: Question about sc/source/ui/view/cellsh.cxx

2012-12-15 Thread Eike Rathke
Hi julien2412, On Saturday, 2012-12-15 01:30:04 -0800, julien2412 wrote: > Either first bDisable is useless or the result of it should be used for the > next line? Indeed, that's missing a condition like in the other cases. http://cgit.freedesktop.org/libreoffice/core/commit/?id=63e10bf2383d22a5

[Libreoffice-commits] .: sc/source

2012-12-15 Thread Libreoffice Gerrit user
sc/source/ui/view/cellsh.cxx |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) New commits: commit 63e10bf2383d22a5b3fafd95a688c2389f0076bc Author: Eike Rathke Date: Sat Dec 15 23:42:45 2012 +0100 check conditions before checking for matrix fragment Was omitted in

[PATCH] add script to regenerate pch files

2012-12-15 Thread Peter Foley (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1350 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/1350/1 add script to regenerate pch files based on a script by Lubos Lunak (http://article.gmane.org/gmane.comp.documen

[Libreoffice-commits] .: sc/source

2012-12-15 Thread Libreoffice Gerrit user
sc/source/filter/oox/formulabase.cxx | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) New commits: commit 9a0bc6d06e30377d2ddf05bf5975dc8c850c8f97 Author: Eike Rathke Date: Sat Dec 15 23:29:35 2012 +0100 add missing *IFS pieces to Excel filter These we

Re: Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread Mat M
Le Sat, 15 Dec 2012 21:43:41 +0100, Markus Mohrhard a écrit: Hey Mat, [...] Maybe your confusion comes from using ^ at the wrong place. Try git diff 4f901a2f451a552853c1dd38309dd55b22616fdd^..4f901a2f451a552853c1dd38309dd55b22616fdd Dammit! Git should know it and fix it by himself! :

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Jean-Baptiste Faure changed: What|Removed |Added Depends on||58284 --- Comment #50 from Jean-Ba

[PUSHED] postprocess: convert to gbuild

2012-12-15 Thread Fridrich Strba (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1080 Approvals: Fridrich Strba: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1080 To unsubscribe, visi

Re: Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread Markus Mohrhard
Hey Mat, >> >> >> Implemented a correct version with >> 4f901a2f451a552853c1dd38309dd55b22616fdd. > > > Sorry but what I see in 4f901a2f45 is the same thing as Julien pasted in his > mail. > It rollback the good version: I don't understand your question. I changed the code to use OR in one place

Re: Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread Mat M
Hello Markus Le Sat, 15 Dec 2012 15:39:26 +0100, Markus Mohrhard a écrit: Hey, I noticed these lines in file sc/source/core/data/colorscale.cxx (because cppcheck report indicates that bNeedUpdate is reassigned before to be used line 641) 637 void ScDataBarFormat::DataChanged(const

Re: LO 4.0 beta1+ builds but fails to install

2012-12-15 Thread Jean-Baptiste Faure
Hi Andras, Le 15/12/2012 18:38, Andras Timar a écrit : > [...] >> I tested it on master and it worked fine, I'll see if there is a >> problem on libreoffice-4-0 and I'll fix it ASAP. Thanks for testing. Thank you very much. > I did not see any problem with my make dev-install. I built it from > sc

Re: LO 4.0 beta1+ builds but fails to install

2012-12-15 Thread Andras Timar
Hi, On Sat, Dec 15, 2012 at 5:31 PM, Andras Timar wrote: > Hi, > > On Sat, Dec 15, 2012 at 4:43 PM, Jean-Baptiste Faure > wrote: >> Hi, >> >> The problem is in this commit : >> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=49b9318873151d25478095bd66ef1cd40c86ba67 >> >> Up to previo

[PATCH] Changed Writer follow-up Styles for "Title" and "Quotations"

2012-12-15 Thread Samuel Mehrbrodt (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1349 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/1349/1 Changed Writer follow-up Styles for "Title" and "Quotations" "Text body" is the most sensible follower for these

[PATCH] fdo#44216 Prompt if objects from dropped slide should be fix...

2012-12-15 Thread Rodolfo Ribeiro Gomes (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1348 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/1348/1 fdo#44216 Prompt if objects from dropped slide should be fixed in aspect ratio Change-Id: I76f8b13f5e275fa4b59ad

Re: LO 4.0 beta1+ builds but fails to install

2012-12-15 Thread Andras Timar
Hi, On Sat, Dec 15, 2012 at 4:43 PM, Jean-Baptiste Faure wrote: > Hi, > > The problem is in this commit : > https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=49b9318873151d25478095bd66ef1cd40c86ba67 > > Up to previous commit > (https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h

Re: LO 4.0 beta1+ builds but fails to install

2012-12-15 Thread Jean-Baptiste Faure
Hi, The problem is in this commit : https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=49b9318873151d25478095bd66ef1cd40c86ba67 Up to previous commit (https://gerrit.libreoffice.org/gitweb?p=core.git;a=commit;h=c0476ad5b0aa8758603b4a2b9f6f8feed130b1b4) no problem to install, at this comm

Re: LO 4.0 beta1+ builds but fails to install

2012-12-15 Thread Arnaud Versini
I confirm the issue on Ubuntu 2012/12/15 Jean-Baptiste Faure > Hi Andras, > > I got the following error messages, it seems that qtz is involved : > > > : PROGRESSTEXTCOLOR=255,255,255 > > : > > : > > : > > : > > : Setting Root Module: gid_Module_Root > > : Using spellchecker file: > > /home/jbf

Re: Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread Julien Nabet
On 15/12/2012 15:39, Markus Mohrhard wrote: Hey, I noticed these lines in file sc/source/core/data/colorscale.cxx (because cppcheck report indicates that bNeedUpdate is reassigned before to be used line 641) 637 void ScDataBarFormat::DataChanged(const ScRange& rRange) 638 { 639

Re: Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread Markus Mohrhard
Hey, > I noticed these lines in file sc/source/core/data/colorscale.cxx > (because cppcheck report indicates that bNeedUpdate is reassigned before to > be used line 641) > > 637 void ScDataBarFormat::DataChanged(const ScRange& rRange) > 638 { > 639 bool bNeedUpdate = false; > 6

[REVIEW 3-6] fix for fdo#56742 , ScRangeList::UpdateReference does not handle URM_COPY

2012-12-15 Thread Markus Mohrhard
Hey, [1] fixes [2] which is more or less a problem in ScRangeList::UpdateReference but we can't safely change it as there might be some users that rely on this behavior. So we just map URM_COPY to URM_MOVE which does the right thing in our case too. Regards, Markus [1] http://cgit.freedesktop.o

Question about vcl/source/window/builder.cxx

2012-12-15 Thread julien2412
Hello, Keeping on with cppcheck, I found this on vcl/source/window/builder.cxx 1892 else if (sKey == "pack-type") 1893 { 1894 VclPackType ePackType = (sValue[0] == 'e' || sValue[0] == 'e') ? VCL_PACK_END : VCL_PACK_START; 1895 pCu

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 57895, which changed state. Bug 57895 Summary: UI: Conditional Formatting for cells shown incorrectly and and incompletely in CF dialog https://bugs.freedesktop.org/show_bug.cgi?id=57895 What|Removed

[Libreoffice-commits] .: 3 commits - .gitignore Module_tail_build.mk RepositoryModule_ooo.mk solenv/gbuild

2012-12-15 Thread Libreoffice Gerrit user
.gitignore |1 - Module_tail_build.mk| 22 +++--- RepositoryModule_ooo.mk | 22 +++--- solenv/gbuild/Helper.mk |2 +- solenv/gbuild/Module.mk |2 +- 5 files changed, 24 insertions(+), 25 deletions(-) New commits: commit 798d758577f3

[PATCH] Added tableproperties.ui

2012-12-15 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1347 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/1347/1 Added tableproperties.ui Change-Id: I228c3c5e52096492eda3ea8ae65bb659fcf688e6 --- M sw/UI_swriter.mk A sw/uiconf

LO 4.0 beta1+ builds but fails to install

2012-12-15 Thread Jean-Baptiste Faure
Hi Andras, I got the following error messages, it seems that qtz is involved : > : PROGRESSTEXTCOLOR=255,255,255 > : > : > : > : > : Setting Root Module: gid_Module_Root > : Using spellchecker file: > /home/jbf/LibO/master/solver/unxlngx6.pro/bin/spellchecker_selection.txt > : Collected spellchec

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Roman Eisele changed: What|Removed |Added Depends on||58328 --- Comment #49 from Roman Eisele

[Libreoffice-commits] .: 2 commits - mysqlc/source solenv/inc

2012-12-15 Thread Libreoffice Gerrit user
mysqlc/source/makefile.mk |2 +- solenv/inc/rules.mk |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit fb7bb64f5b0abe48146498d2f05713a61e4a706c Author: Andras Timar Date: Sat Dec 15 10:28:51 2012 +0100 fdo#58145 dmake rule for ulf localization was n

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - mysqlc/source solenv/inc

2012-12-15 Thread Libreoffice Gerrit user
mysqlc/source/makefile.mk |2 +- solenv/inc/rules.mk |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 0cf259c9fbf10187306999b35126e92b32a57752 Author: Andras Timar Date: Sat Dec 15 10:37:52 2012 +0100 fdo#58156 use WITH_LANG_LIST instead of WITH_LA

Question about sc/source/ui/view/cellsh.cxx

2012-12-15 Thread julien2412
Hello, In sc/source/ui/view/cellsh.cxx, we have these lines: 150 case FID_FILL_TO_RIGHT: // fill to left / right 151 { 152 bDisable = !bSimpleArea || (nCol1 == 0 && nCol2 == 0); 153 bDisable = pDoc->HasSelectedBlockMatrixF

Question about sc/source/core/data/colorscale.cxx

2012-12-15 Thread julien2412
Hello, I noticed these lines in file sc/source/core/data/colorscale.cxx (because cppcheck report indicates that bNeedUpdate is reassigned before to be used line 641) 637 void ScDataBarFormat::DataChanged(const ScRange& rRange) 638 { 639 bool bNeedUpdate = false; 640 641

[Libreoffice-commits] .: oox/source

2012-12-15 Thread Libreoffice Gerrit user
oox/source/vml/vmlshapecontainer.cxx |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit 5931dbb53ebb2ff1e5670ad6537a41f996c0277c Author: Julien Nabet Date: Sat Dec 15 09:34:06 2012 +0100 Oups changed this file by error Change-Id: I9bf2a5f260828ed5

[PUSHED] Change in core[libreoffice-3-6]: Take extra cache/uno_packages/*.tmp_/*properties files into ...

2012-12-15 Thread Miklos Vajna (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1313 Approvals: Miklos Vajna: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1313 To unsubscribe, visit

[Libreoffice-commits] .: oox/source ucb/source

2012-12-15 Thread Libreoffice Gerrit user
oox/source/vml/vmlshapecontainer.cxx |7 +-- ucb/source/ucp/webdav/webdavresponseparser.cxx | 10 +- 2 files changed, 10 insertions(+), 7 deletions(-) New commits: commit b82b9a93caaf27855d6059885de29d1989a1907d Author: Julien Nabet Date: Sat Dec 15 09:31:09 2012 +0

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - desktop/source

2012-12-15 Thread Libreoffice Gerrit user
desktop/source/migration/services/oo3extensionmigration.cxx | 25 ++-- 1 file changed, 14 insertions(+), 11 deletions(-) New commits: commit 6e963da804ed6f222a4a6c5f373d7ea6532d75ad Author: Stephan Bergmann Date: Tue Dec 4 18:11:58 2012 +0100 Take extra cache/uno_packages/*.tmp_

[PUSHED] Change in core[libreoffice-3-6]: Do extra check on source range to make sure no funny things ...

2012-12-15 Thread Markus Mohrhard (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1345 Approvals: Markus Mohrhard: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1345 To unsubscribe, vis

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-12-15 Thread Libreoffice Gerrit user
sc/source/core/data/dpcache.cxx |5 + sc/source/core/data/dpshttab.cxx |8 2 files changed, 13 insertions(+) New commits: commit 82b03180e66559c53911c404af455ca0d3505948 Author: Kohei Yoshida Date: Fri Dec 14 22:34:38 2012 -0500 Do extra check on source range to make