[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Emir Sarı changed: What|Removed |Added Depends on||57433 -- You are receiving this mail becaus

[PUSHED] String -> OUString in filter

2012-12-10 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1295 -- To view, visit https://gerrit.libreoffice.org/1295 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[PUSHED] Remove UniString from uui module

2012-12-10 Thread David Tardon (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1292 -- To view, visit https://gerrit.libreoffice.org/1292 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType:

[Libreoffice-commits] .: 2 commits - filter/source uui/source

2012-12-10 Thread Libreoffice Gerrit user
filter/source/xsltdialog/xmlfiltertabdialog.cxx | 26 +++- uui/source/logindlg.cxx |8 +++ 2 files changed, 16 insertions(+), 18 deletions(-) New commits: commit a0c0b8cad98c8da86ba4d44c1c0a3bd84ffc465a Author: Ricardo Montania Date: Tue De

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 57906, which changed state. Bug 57906 Summary: BUGZILLAASSISTANT: Submit fails with error message "It looks like you didn't come from the right page ..." https://bugs.freedesktop.org/show_bug.cgi?id=57906 Wha

[Libreoffice-commits] .: Branch 'feature/improvexlsximport' - sc/source

2012-12-10 Thread Libreoffice Gerrit user
sc/source/core/tool/address.cxx | 17 + sc/source/ui/view/gridwin.cxx | 15 ++- 2 files changed, 31 insertions(+), 1 deletion(-) New commits: commit c7239b29c9a6d27572e943c285f397c1a67b795b Author: Kohei Yoshida Date: Mon Dec 10 22:30:31 2012 -0500 Get HY

[PATCH] String -> OUString in filter

2012-12-10 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1295 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/95/1295/1 String -> OUString in filter Change-Id: I9041129289c24c4ee8a7a6d50e34b785969e8204 --- M filter/source/xsltdialog

[PATCH] Remove RTL_* from uui

2012-12-10 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1294 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/94/1294/1 Remove RTL_* from uui Change-Id: I411133e81a9b548aaef2333c705c1376f45304d7 Signed-off-by: Marcos Paulo de Souza

Documentation required

2012-12-10 Thread Rushi Shukla
Hello If available may I please get a documentation of some .cxx and .hxx files listed in the mail ? I am going through a lot of such files and am still having trouble to understand as to how a particular function works and what is the purpose of it . If you would be so kind as to reply to this ma

Re: Addin exceptions in SvStream

2012-12-10 Thread Eike Rathke
Hi Norbert, On Monday, 2012-12-10 17:38:34 -0600, Norbert Thiebaud wrote: > Am I thinking of something else or the current syntax is: > > if( ! (*stream>>meh)) > { > /* error */ > } > ... > > iow the >> operator return a boolean that indicate the sucess or > failure of the >> operation... No

[PATCH] Remove (RTL_CONSTASCII_USTRINGPARAM from lotuswordpro

2012-12-10 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1293 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/93/1293/1 Remove (RTL_CONSTASCII_USTRINGPARAM from lotuswordpro Change-Id: I4912ffc42edbfa1456835e61163812c371eb14c6 Signe

Re: Addin exceptions in SvStream

2012-12-10 Thread Norbert Thiebaud
On Mon, Dec 10, 2012 at 3:41 PM, Michael Meeks wrote: > Hi Marc, > > On Mon, 2012-12-10 at 10:27 -0500, Marc-André Laverdière wrote: >> I am doing some proactive hardening of the image filters these days, >> and I have to say that there is a lot of code like this: >> >> *stream >> meh; > >

[PUSHED] Change in core[libreoffice-3-6]: fdo#57780: sw: lcl_ArrangeLowers: register drawing ...

2012-12-10 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1290 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1290 To unsubscribe, vis

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source

2012-12-10 Thread Libreoffice Gerrit user
sw/source/core/layout/tabfrm.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 1ca23f2674d1c46ad8629f657a0c9a67a5551679 Author: Michael Stahl Date: Mon Dec 10 20:52:55 2012 +0100 fdo#57780: sw: lcl_ArrangeLowers: register drawing ... ... objects

[PATCH] Remove UniString from uui module

2012-12-10 Thread Marcos Souza (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1292 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/92/1292/1 Remove UniString from uui module Change-Id: I6eb52f42c3364970553015492b9c488c04febed6 Signed-off-by: Marcos Paul

[Libreoffice-commits] .: sal/inc

2012-12-10 Thread Libreoffice Gerrit user
sal/inc/rtl/strbuf.hxx | 15 +++ sal/inc/rtl/ustrbuf.hxx | 15 +++ 2 files changed, 30 insertions(+) New commits: commit 17b272effc206875fe4165e58d6452f0ecd8 Author: Luboš Luňák Date: Mon Dec 10 23:51:22 2012 +0100 operator+ for stringbuffer Th

Custom Styles in Writer

2012-12-10 Thread Rushi Shukla
Hello This might be a no-brainer but can you please tell me exactly which list or arrray stores the Custom Styles made by the user under the 'Styles and Formatting' section of Writer ? .hxx and .cxx files I am studying right now (if this helps in any way) 1) http://opengrok.libreoffice.org/xref/

Re: [PUSHED] Replacing '__LOADONCALLAPI' with 'SAL_CALL' definition

2012-12-10 Thread Lubos Lunak
On Monday 10 of December 2012, Michael Meeks wrote: > On Mon, 2012-12-10 at 08:08 -0800, Christos Strubulis wrote: > > Would you like to have a look at the attached patch? What is > > your opinion now? > > Lubos asked you to: > > > - SAL_CALL is already defined in sal/inc/sal/types.h , so the

Re: Addin exceptions in SvStream

2012-12-10 Thread Michael Meeks
Hi Marc, On Mon, 2012-12-10 at 10:27 -0500, Marc-André Laverdière wrote: > I am doing some proactive hardening of the image filters these days, > and I have to say that there is a lot of code like this: > > *stream >> meh; Which is IMHO intrinsically broken; I'd prefer to see that as:

[PUSHED] Replacing '__LOADONCALLAPI' with 'SAL_CALL' definition

2012-12-10 Thread Michael Meeks
Hi there, Thanks for the updated patch :-) On Mon, 2012-12-10 at 08:08 -0800, Christos Strubulis wrote: > I haven't deleted helpcontent2 yet but I will do it before the > next autogen and compilation. I removed it from the patch and pushed. > Would you like to have a look at th

[Libreoffice-commits] .: extensions/workben filter/qa filter/source sc/source sc/workben sd/source svx/source sw/source tools/inc vcl/source

2012-12-10 Thread Libreoffice Gerrit user
extensions/workben/pythonautotest.cxx |2 +- extensions/workben/pythontest.cxx |2 +- extensions/workben/testcomponent.cxx|2 +- filter/qa/cppunit/filters-pict-test.cxx |2 +- filter/qa/cppunit/filters-tga-test.cxx |2 +- fil

[PATCH] rtl:: prefix removal from configmgr

2012-12-10 Thread Ioan Radu (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1291 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/91/1291/1 rtl:: prefix removal from configmgr - removed rtl:: prefix - removed RTL_CONSTASCII_USTRINGPARAM - corrected som

[PATCH] Change in core[libreoffice-3-6]: fdo#57780: sw: lcl_ArrangeLowers: register drawing ...

2012-12-10 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1290 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/90/1290/1 fdo#57780: sw: lcl_ArrangeLowers: register drawing ... ... objects at the right page. This was effectively disa

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-12-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 46716, which changed state. Bug 46716 Summary: Some formulas are lost by "DOCX" import filter. https://bugs.freedesktop.org/show_bug.cgi?id=46716 What|Removed |Added ---

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - cui/source editeng/inc editeng/source

2012-12-10 Thread Libreoffice Gerrit user
cui/source/tabpages/autocdlg.cxx |4 editeng/inc/editeng/svxacorr.hxx | 33 +++ editeng/source/misc/SvXMLAutoCorrectExport.cxx |4 editeng/source/misc/SvXMLAutoCorrectImport.cxx |5 editeng/source/misc/svxacorr.cxx | 226 +

[Bug 54157] LibreOffice 3.7/4.0 most annoying bugs

2012-12-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Bug 54157 depends on bug 55570, which changed state. Bug 55570 Summary: autocorrect slow-down https://bugs.freedesktop.org/show_bug.cgi?id=55570 What|Removed |Added -

[Libreoffice-commits] .: 2 commits - cui/source editeng/inc editeng/source

2012-12-10 Thread Libreoffice Gerrit user
cui/source/tabpages/autocdlg.cxx |4 editeng/inc/editeng/svxacorr.hxx | 33 +++ editeng/source/misc/SvXMLAutoCorrectExport.cxx |4 editeng/source/misc/SvXMLAutoCorrectImport.cxx |5 editeng/source/misc/svxacorr.cxx | 226 +

[PUSHED] Change in core[libreoffice-4-0]: no need for wget/curl when not fetching anything

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1289 Approvals: Matúš Kukan: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1289 To unsubscribe, vis

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sw/source

2012-12-10 Thread Libreoffice Gerrit user
sw/source/core/layout/tabfrm.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit 37fdcc35941283d01e44ec2d04742ab2652e9d5f Author: Michael Stahl Date: Mon Dec 10 20:52:55 2012 +0100 fdo#57780: sw: lcl_ArrangeLowers: register drawing ... ... objects

[Libreoffice-commits] .: sw/source

2012-12-10 Thread Libreoffice Gerrit user
sw/source/core/layout/tabfrm.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit c479ccc438edeb7197a2d05bdb99067365d7bac0 Author: Michael Stahl Date: Mon Dec 10 20:52:55 2012 +0100 fdo#57780: sw: lcl_ArrangeLowers: register drawing ... ... objects

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - configure.ac

2012-12-10 Thread Libreoffice Gerrit user
configure.ac |6 ++ 1 file changed, 6 insertions(+) New commits: commit 491f8c5b2422a3ca7ff23e80ac4fb70a37cb8adb Author: Bjoern Michaelsen Date: Mon Dec 10 19:06:48 2012 +0100 no need for wget/curl when not fetching anything Change-Id: I097675450a0eed87eccf90356c816574856

[Libreoffice-commits] .: 0 commits -

2012-12-10 Thread Libreoffice Gerrit user
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 0 commits -

2012-12-10 Thread Libreoffice Gerrit user
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'cppunit-1-13' - 0 commits -

2012-12-10 Thread Libreoffice Gerrit user
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] Changes to 'feature/improvexlsximport'

2012-12-10 Thread Libreoffice Gerrit user
New branch 'feature/improvexlsximport' available with the following commits: commit f76b185817308f3be5b704fa779fe919d4395dd7 Author: Noel Power Date: Mon Dec 10 18:51:49 2012 + hack to import hyperlink into formula cells Change-Id: I3ad0f63c3adb2ea33bcb2e54c9725d7b2e9f01a2 com

[PATCH] Change in core[libreoffice-4-0]: no need for wget/curl when not fetching anything

2012-12-10 Thread via Code Review
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1289 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/89/1289/1 no need for wget/curl when not fetching anything Change-Id: I097675450a0eed87eccf90356c81657485609d13 --- M conf

[Libreoffice-commits] .: configure.ac

2012-12-10 Thread Libreoffice Gerrit user
configure.ac |6 ++ 1 file changed, 6 insertions(+) New commits: commit 3c64d866379c3ae78b95b68fffe62685037da707 Author: Bjoern Michaelsen Date: Mon Dec 10 19:06:48 2012 +0100 no need for wget/curl when not fetching anything Change-Id: I097675450a0eed87eccf90356c816574856

[Libreoffice-commits] .: solenv/gbuild

2012-12-10 Thread Libreoffice Gerrit user
solenv/gbuild/platform/com_MSC_class.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c74fe188b178fab821084bb82d4574f77dc2e1ce Author: Tor Lillqvist Date: Mon Dec 10 19:33:43 2012 +0200 Create executables that can be run on Windows XP Specify subsys

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - odk/examples

2012-12-10 Thread Libreoffice Gerrit user
odk/examples/DevelopersGuide/ProfUNO/CppBinding/office_connect.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 60baf6eeea7a7d601a75901b07f70f5e79dc9afe Author: Stephan Bergmann Date: Mon Dec 10 18:23:28 2012 +0100 Fix SDK example Change-Id: Ide65bcf203f78d1e8d328

[Libreoffice-commits] .: qadevOOo/tests

2012-12-10 Thread Libreoffice Gerrit user
qadevOOo/tests/java/mod/_sc/ScAccessiblePageHeaderArea.java | 47 ++-- 1 file changed, 9 insertions(+), 38 deletions(-) New commits: commit ee433794558b1a1e31dc8dddb77e117608ea1428 Author: Stephan Bergmann Date: Mon Dec 10 18:25:09 2012 +0100 Revert "Use XNotifyingDispatch to av

[Libreoffice-commits] .: 2 commits - odk/examples sal/inc

2012-12-10 Thread Libreoffice Gerrit user
odk/examples/DevelopersGuide/ProfUNO/CppBinding/office_connect.cxx |1 + sal/inc/rtl/instance.hxx |2 ++ sal/inc/rtl/stringutils.hxx|2 ++ 3 files changed, 5 insertions(+) New commits: commit 67a624f47f2

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - source/fr

2012-12-10 Thread Libreoffice Gerrit user
source/fr/helpcontent2/source/text/shared/optionen.po |1 + source/fr/officecfg/registry/data/org/openoffice/Office/UI.po |1 + source/fr/svx/source/dialog.po|1 + 3 files changed, 3 insertions(+) New commits: commit 7bedb66aace7979064f69df8df20

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - translations

2012-12-10 Thread Libreoffice Gerrit user
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6407957c65c1d0c254470178f00e949628df16bc Author: Andras Timar Date: Mon Dec 10 18:20:35 2012 +0100 Updated core Project: translations 7bedb66aace7979064f69df8df2038fb197dc270 fdo#58068 fix i

[Libreoffice-commits] .: source/fr

2012-12-10 Thread Libreoffice Gerrit user
source/fr/helpcontent2/source/text/shared/optionen.po |1 + source/fr/officecfg/registry/data/org/openoffice/Office/UI.po |1 + source/fr/svx/source/dialog.po|1 + 3 files changed, 3 insertions(+) New commits: commit 85f724f5aa1d6a59662a7d1c7ea4

[Libreoffice-commits] .: translations

2012-12-10 Thread Libreoffice Gerrit user
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 16dcaa433dcff4a9eb3401eebc1735f6b8748d0d Author: Andras Timar Date: Mon Dec 10 18:20:35 2012 +0100 Updated core Project: translations 85f724f5aa1d6a59662a7d1c7ea406a641814bd2 fdo#58068 fix i

Re: Master Documents

2012-12-10 Thread Michael Meeks
Hi David, On Mon, 2012-12-10 at 09:12 -0500, David Burleigh wrote: > I'm trying to find a way to do on purpose what I once did by accident > (but I don't know how I did it). I have a master document containing ... This is the developers list; please ask questions only related to developme

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - odk/examples sal/inc

2012-12-10 Thread Libreoffice Gerrit user
odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.cxx | 39 -- odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.h | 24 +++--- odk/examples/cpp/complextoolbarcontrols/exports.cxx |4 - sal/inc/osl/diagnose.h|4

[PUSHED] Change in core[libreoffice-3-6]: fdo#52240 added [hr-HR] date acceptance patterns D/M/Y; D/M

2012-12-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1288 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1288 To unsubscribe, visit

[PUSHED] Change in core[libreoffice-3-6]: fdo#52240 added [no-NO] date acceptance patterns D.M; D/M/Y; D...

2012-12-10 Thread Kohei Yoshida (via Code Review)
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1287 Approvals: Kohei Yoshida: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1287 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - i18npool/source

2012-12-10 Thread Libreoffice Gerrit user
i18npool/source/localedata/data/hr_HR.xml |2 ++ 1 file changed, 2 insertions(+) New commits: commit 7d311177597d2f7e3bdf19a56b9f862da83588f4 Author: Eike Rathke Date: Mon Dec 10 14:36:31 2012 +0100 fdo#52240 added [hr-HR] date acceptance patterns D/M/Y;D/M As per https://bug

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - i18npool/source

2012-12-10 Thread Libreoffice Gerrit user
i18npool/source/localedata/data/no_NO.xml |4 1 file changed, 4 insertions(+) New commits: commit 12281897cc5fa72357b6bce16d18d0356c7213d5 Author: Eike Rathke Date: Mon Dec 10 14:29:03 2012 +0100 fdo#52240 added [no-NO] date acceptance patterns D.M;D/M/Y;D/M;D/M Y Also r

[Libreoffice-commits] .: sc/workben

2012-12-10 Thread Libreoffice Gerrit user
sc/workben/celltrans/parse.py | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) New commits: commit 1a2ea259717e8cebf9744ceb92acc34efaef443b Author: László Németh Date: Mon Dec 10 17:08:23 2012 +0100 some Python 3.3 port (not important for LO 4.0)

Re: [PATCH] Replacing '__LOADONCALLAPI' with 'SAL_CALL' definition

2012-12-10 Thread Christos Strubulis
Hi, ok thank you for your advice and guidelines. I haven't deleted helpcontent2 yet but I will do it before the next autogen and compilation. Would you like to have a look at the attached patch? What is your opinion now? Christos. On Mon, 2012-12-10 at 13:24 +0100, Lubos Lunak wrote: > On Sun

Re: [PATCH][PUSHED] Bookmark.ui and Numberformat.ui

2012-12-10 Thread Caolán McNamara
On Mon, 2012-12-03 at 07:10 +, Gokul Swaminathan wrote: ... > manually converted the bookmark and numberformat widgets I finally adapted the code to use the numberformat .ui on Friday, forgot to mention that I think. Was a little tricky because I wanted to keep the icons on the buttons so had

Re: [Libreoffice-qa] 4.0 Test week/marathon Re: [...-qa] 3.7 bug hunt party ?

2012-12-10 Thread Cor Nouws
Hi Joel, Joel Madero wrote (09-12-12 04:50) I'm doing edits to the page, for anyone with experience with QA, please thanks! add your name to the "list of experts" where users can directly ping us if they have questions about their progress. Hopefully this way the good idea - will do the s

[Libreoffice-commits] .: configure.ac

2012-12-10 Thread Libreoffice Gerrit user
configure.ac | 37 ++--- 1 file changed, 2 insertions(+), 35 deletions(-) New commits: commit 02e2202894652751f59a0709e1b767e8ed2ab30c Author: Luboš Luňák Date: Mon Dec 10 16:15:39 2012 +0100 do not try to use -std=c++11 after all The very sam

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sc/Library_sc.mk sc/source

2012-12-10 Thread Libreoffice Gerrit user
sc/Library_sc.mk |1 sc/source/core/data/global.cxx |2 + sc/source/core/inc/random.hxx| 29 + sc/source/core/tool/interpr1.cxx |3 +- sc/source/core/tool/random.cxx | 53 +++ 5 files changed, 87 inser

Addin exceptions in SvStream

2012-12-10 Thread Marc-André Laverdière
Hello everyone, I am doing some proactive hardening of the image filters these days, and I have to say that there is a lot of code like this: *stream >> meh; if (! stream->good()) return sal_False; It is very cluttered to do this for _every_ read. A simpler way would be to have opt-in excepti

[Libreoffice-commits] .: 3 commits - graphite/graphite2.issue1115.patch.1 graphite/graphite2.narrowing.patch.1 graphite/UnpackedTarball_graphite.mk odk/examples sal/inc

2012-12-10 Thread Libreoffice Gerrit user
graphite/UnpackedTarball_graphite.mk |3 graphite/graphite2.issue1115.patch.1 | 22 + graphite/graphite2.narrowing.patch.1 | 22 - odk/examples/cpp/complextoolbarcontrols/MyProtocolHandler.cxx | 39 --

[Libreoffice-commits] .: 5 commits - sfx2/inc sfx2/source

2012-12-10 Thread Libreoffice Gerrit user
sfx2/inc/sfx2/templateabstractview.hxx |6 - sfx2/inc/sfx2/templatelocalview.hxx|2 sfx2/inc/sfx2/templatelocalviewitem.hxx|2 sfx2/inc/sfx2/templateremoteviewitem.hxx |2 sfx2/inc/sfx2/templateview.hxx |6 - sfx2/inc/sfx2/te

[Libreoffice-commits] .: Branch 'distro/suse/suse-3.6' - oox/source

2012-12-10 Thread Libreoffice Gerrit user
oox/source/drawingml/theme.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 1c0af12bf1bc378e3e0c87be9840f41e89783f22 Author: Radek Doulik Date: Mon Dec 10 16:07:43 2012 +0100 for lnRef idx 0 is valid index into style matrix Change-Id: Idfca

[Libreoffice-commits] .: sfx2/uiconfig sw/uiconfig

2012-12-10 Thread Libreoffice Gerrit user
sfx2/uiconfig/ui/templatemanagementdialog.ui | 216 ++ sw/uiconfig/swriter/ui/templatemanagement.ui | 221 --- 2 files changed, 216 insertions(+), 221 deletions(-) New commits: commit 9fe54eda44769b38ab0c149abcdc6a12ae187280 Author: Caolán McNama

[PUSHED] Manual convertion of templatemanagement.ui

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1286 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1286 To unsubscribe, vis

[Libreoffice-commits] .: sw/uiconfig

2012-12-10 Thread Libreoffice Gerrit user
sw/uiconfig/swriter/ui/templatemanagement.ui | 221 +++ 1 file changed, 221 insertions(+) New commits: commit 3d788245347f4160eed7c60ee85b47e6a61e9888 Author: Gokul Date: Mon Dec 10 15:21:27 2012 +0300 Manual convertion of templatemanagement.ui Change-Id:

[PUSHED] docx import/export non-breaking hyphen and soft hyphen

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1279 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1279 To unsubscribe, vis

[Libreoffice-commits] .: sw/source writerfilter/source

2012-12-10 Thread Libreoffice Gerrit user
sw/source/filter/ww8/docxattributeoutput.cxx |8 writerfilter/source/ooxml/OOXMLFastContextHandler.cxx |4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) New commits: commit 1b0d9fa747c4a7fcdcd1c057bc2b31345f4bfe76 Author: Lennard Date: Sun Dec 9 16:29:47 2012

Re: static clang source code analysis (Code Review Requested)

2012-12-10 Thread John Smith
Hi, So now that people know how to generate these reports, lets hope they are going to be put to good use ! ;) - John Smith. On Mon, Dec 10, 2012 at 9:19 AM, Miklos Vajna wrote: > Hi John, > > On Fri, Dec 07, 2012 at 04:41:48PM +0100, John Smith > wrote: >> The clang analyzer how-to is here

Re: Using config_xxx.h instead of -DHAVE_XXX

2012-12-10 Thread Stephan Bergmann
On 12/10/2012 02:41 PM, Michael Meeks wrote: On Mon, 2012-12-10 at 14:25 +0100, Stephan Bergmann wrote: Collateral damage in SDK was my fear, too, so I wanted to have a look at it, only to see that it is already significantly broken in LO 4.0 anyway. Will have a stab at fixing it... N

[Libreoffice-commits] .: officecfg/registry sc/inc sc/source

2012-12-10 Thread Libreoffice Gerrit user
officecfg/registry/schema/org/openoffice/Office/Calc.xcs | 30 +++ sc/inc/formulaopt.hxx| 13 +++ sc/inc/globstr.hrc |4 sc/inc/scmod.hxx |4 sc/source/core/tool/form

[Libreoffice-commits] .: solenv/gbuild

2012-12-10 Thread Libreoffice Gerrit user
solenv/gbuild/gbuild.help.txt |3 +++ 1 file changed, 3 insertions(+) New commits: commit 688c668003739042c2431ec3f7a94d6b3ac6998a Author: Luboš Luňák Date: Mon Dec 10 15:15:21 2012 +0100 little help for userfriendly gbuild make targets Change-Id: I6b650781b11163eb99828d0d

Master Documents

2012-12-10 Thread David Burleigh
I'm trying to find a way to do on purpose what I once did by accident (but I don't know how I did it). I have a master document containing links to many subdocuments, and I would like to export the entire contents to a normal ".odt" file in editable form. I tried File>Export then choose File Type "

[PATCH] Change in core[libreoffice-3-6]: fdo#52240 added [no-NO] date acceptance patterns D.M; D/M/Y; D...

2012-12-10 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1287 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/1287/1 fdo#52240 added [no-NO] date acceptance patterns D.M;D/M/Y;D/M;D/M Y Also referenced by nb-NO and ny-NO Changes

[PUSHED] userfriendly make targets for build and clean

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1253 Approvals: Luboš Luňák: Verified; Looks good to me, approved Peter Foley: Looks good to me, but someone else must approve David Ostrovsk

[PATCH] Change in core[libreoffice-3-6]: fdo#52240 added [hr-HR] date acceptance patterns D/M/Y; D/M

2012-12-10 Thread Eike Rathke (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1288 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/1288/1 fdo#52240 added [hr-HR] date acceptance patterns D/M/Y;D/M As per https://bugs.freedesktop.org/show_bug.cgi?id=5

[Libreoffice-commits] .: solenv/gbuild

2012-12-10 Thread Libreoffice Gerrit user
solenv/gbuild/AllLangResTarget.mk |1 + solenv/gbuild/AllLangZip.mk |1 + solenv/gbuild/CliLibrary.mk |1 + solenv/gbuild/CliNativeLibrary.mk |1 + solenv/gbuild/CliUnoApi.mk|1 + solenv/gbuild/Configuration.mk|2 ++ solenv/gbuild/CppunitTest.mk

[Libreoffice-commits] .: Branch 'libreoffice-4-0' - 2 commits - i18npool/source

2012-12-10 Thread Libreoffice Gerrit user
i18npool/source/localedata/data/hr_HR.xml |2 ++ i18npool/source/localedata/data/no_NO.xml |4 2 files changed, 6 insertions(+) New commits: commit 9cce41e668de5b50e05d762b88f3bbafb3bb641a Author: Eike Rathke Date: Mon Dec 10 14:36:31 2012 +0100 fdo#52240 added [hr-HR] date a

[PUSHED] IsDbg() is no longer called

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1277 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1277 To unsubscribe, vis

[Libreoffice-commits] .: cui/source

2012-12-10 Thread Libreoffice Gerrit user
cui/source/options/treeopt.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit a7320cbe406c0276a3c113a1adac93ed7a894dc2 Author: Caolán McNamara Date: Mon Dec 10 14:01:42 2012 + de:Interner Test -> en:Internal Test Change-Id: I39210b28a098292d

[Libreoffice-commits] .: 2 commits - i18npool/source

2012-12-10 Thread Libreoffice Gerrit user
i18npool/source/localedata/data/hr_HR.xml |2 ++ i18npool/source/localedata/data/no_NO.xml |4 2 files changed, 6 insertions(+) New commits: commit b1184f8a4e4a3949d38407c5f1d5155c2c2b42d5 Author: Eike Rathke Date: Mon Dec 10 14:36:31 2012 +0100 fdo#52240 added [hr-HR] date a

[Libreoffice-commits] .: sw/source

2012-12-10 Thread Libreoffice Gerrit user
sw/source/core/inc/txtfrm.hxx |5 - sw/source/core/text/txtio.cxx | 18 +++--- 2 files changed, 3 insertions(+), 20 deletions(-) New commits: commit 9d09dcfd23e70adb4834253f697c479dab4cf673 Author: Takeshi Abe Date: Sun Dec 9 20:08:29 2012 +0900 IsDbg() is no longer

[Libreoffice-commits] .: configure.ac

2012-12-10 Thread Libreoffice Gerrit user
configure.ac |1 - 1 file changed, 1 deletion(-) New commits: commit 5abad485f0efa4e71f99d47e6d053298102eb2b3 Author: Luboš Luňák Date: Mon Dec 10 15:00:11 2012 +0100 remove AC_DEFINE(HAVE_CXX0X) There should be no #ifdef for that anyway (given compiler support each fe

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - odk/configure.pl odk/setsdkenv_unix

2012-12-10 Thread Libreoffice Gerrit user
0 files changed New commits: commit f6934334358004c2ab4a520769d314083de59460 Author: Stephan Bergmann Date: Tue Jun 5 17:19:25 2012 +0200 Make setsdkenv_unix executable instead of configure.pl Change-Id: I1efc684f3476cd20bd2ae5efcf603ab2e6adf83a (cherry picked from commit 7d2

[PUSHED] fdo#38895 fix toggling of numbering separator on Autocaption...

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1272 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1272 To unsubscribe, vis

[Libreoffice-commits] .: sw/source

2012-12-10 Thread Libreoffice Gerrit user
sw/source/ui/config/optload.cxx | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) New commits: commit 5cb4004a443910c6eefb0b58f1fc4ed3e20ba36c Author: Jack Leigh Date: Sat Dec 8 21:12:23 2012 + fdo#38895 fix toggling of numbering separator on Autocaption page

Re: Using config_xxx.h instead of -DHAVE_XXX

2012-12-10 Thread Michael Meeks
On Mon, 2012-12-10 at 14:25 +0100, Stephan Bergmann wrote: > Collateral damage in SDK was my fear, too, so I wanted to have a look at > it, only to see that it is already significantly broken in LO 4.0 > anyway. Will have a stab at fixing it... Nice. If we could make the SDK samples bu

[PUSHED] rtl:: removal in fpicker

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1270 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1270 To unsubscribe, vis

[PUSHED] migrate 'Insert Caption' dialog to .ui file

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1266 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1266 To unsubscribe, vis

[Libreoffice-commits] .: sw/inc sw/source sw/uiconfig

2012-12-10 Thread Libreoffice Gerrit user
sw/inc/helpid.h |1 - sw/source/ui/frmdlg/cption.cxx |2 +- sw/uiconfig/swriter/ui/insertcaption.ui |5 + 3 files changed, 6 insertions(+), 2 deletions(-) New commits: commit 8f7855b61a29e47db70be92541422594ad99d13f Author: Caolán McNamara Date:

[Libreoffice-commits] .: sw/inc sw/source sw/uiconfig sw/UI_swriter.mk

2012-12-10 Thread Libreoffice Gerrit user
sw/UI_swriter.mk|1 sw/inc/globals.hrc |6 sw/source/ui/app/app.src| 21 + sw/source/ui/config/optload.cxx | 16 + sw/source/ui/frmdlg/cption.cxx | 221 ++--- sw/source/ui/frmdlg/cption.hrc

Re: Using config_xxx.h instead of -DHAVE_XXX

2012-12-10 Thread Stephan Bergmann
On 12/08/2012 11:24 PM, Michael Meeks wrote: Some care/thought should be given to ensuring that the URE/ODK still exports whatever limited set of these defines we need [ to be fair the ODK needs some real dunging out action - and should have it's samples built as we compile to stop it fro

[PUSHED] - correct variable-names

2012-12-10 Thread via Code Review
Hi, Thank you for your patch! It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/1267 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/1267 To unsubscribe, vis

[Libreoffice-commits] .: sd/source

2012-12-10 Thread Libreoffice Gerrit user
sd/source/ui/toolpanel/controls/MasterPageContainer.cxx | 10 +- sd/source/ui/toolpanel/controls/MasterPageDescriptor.cxx |6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) New commits: commit 20778d72fe4c785ebe9039767afa07f35b045541 Author: Rob Snelders Date: Fri Dec 7

Re: Installing our CLI DLLs on Windows XP SP3 with .NET 2.0 and 3.5 (but no newer) fails

2012-12-10 Thread Tor Lillqvist
> It is not a strong requirement. If system does not meet this > requirement, then CLI stuff will not be installed (silently). Ah, good, that sounds ideal then! (And finally then we might perhaps get some bug reports about it, "why doesn't it work any more in LO 4.0" ;) --tml

[Libreoffice-commits] .: config_host.mk.in configure.ac solenv/gbuild solenv/inc

2012-12-10 Thread Libreoffice Gerrit user
config_host.mk.in|1 configure.ac | 52 +-- solenv/gbuild/platform/macosx.mk |2 - solenv/gbuild/platform/unxgcc.mk |2 - solenv/inc/unxgcc.mk |2 - 5 files changed, 49 insertions(+), 10 deletion

Re: Putting support for precompiled headers back in

2012-12-10 Thread Lubos Lunak
On Monday 10 of December 2012, Michael Stahl wrote: > On 10/12/12 12:54, Lubos Lunak wrote: > > - lack of a tinderbox to test it - I intend to switch #6 to use it and > > see how it works in practice > > hopefully we'll get faster tinderbox turnarounds too... Actually, #6 has been doing increment

Re: Installing our CLI DLLs on Windows XP SP3 with .NET 2.0 and 3.5 (but no newer) fails

2012-12-10 Thread Andras Timar
On Mon, Dec 10, 2012 at 1:17 PM, Tor Lillqvist wrote: > >> Either we can bump this (REQUIRED_DOTNET_VERSION) to 4.0.0.0 > > We could do that, but on the other hand, as you say, given how rarely > used the LibreOffice CLI stuff is likely to be anyway, it would be a > bit silly to require the newest

Re: Putting support for precompiled headers back in

2012-12-10 Thread Michael Stahl
On 10/12/12 12:54, Lubos Lunak wrote: > The argument for PCH (MSVC2010 non-debug build): > > $ time make xmloff ENABLE_PCH= > real4m52.828s > $ time make xmloff ENABLE_PCH=TRUE > real2m9.293s that looks sufficiently convincing for me :) > The arguments against PCH seem to be: > - conf

[PATCH] Manual convertion of templatemanagement.ui

2012-12-10 Thread gokul s (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/1286 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/1286/1 Manual convertion of templatemanagement.ui Change-Id: I499e9c1bfb23ac7e437eaa366dfee2016afd1d36 --- A sw/uiconfi

Re: [PATCH] Replacing '__LOADONCALLAPI' with 'SAL_CALL' definition

2012-12-10 Thread Lubos Lunak
On Sunday 09 of December 2012, Christos Strubulis wrote: > Ok thanks. I thought that this command would commit to the official > repository and not locally. > > Is this right now? Yes, that's right. There are still two minor issues with the patch though: - your email in the commit is invalid ( "

Re: Installing our CLI DLLs on Windows XP SP3 with .NET 2.0 and 3.5 (but no newer) fails

2012-12-10 Thread Tor Lillqvist
> You probably built with .NET 4.0 SDK. Well, I tried hard not to, and the versions I see output by the tools don't indicate that 4.0 would be used, but yeah, either I didn't look in the right place or somehow otherwise that crept in. (Also the TDF build of the 4.0.0 beta1 has the same problem.)

  1   2   >