Re: [HELP] Base Windows-specific issues (Hackfest?)

On 05.11.2012 08:23, Norbert Thiebaud wrote: On Sat, Nov 3, 2012 at 5:09 AM, David Ostrovsky wrote: >I pushed a complete unit test for ado driver (based on mdb files that was >attached to this issue). That is a problem your unit test modify the source tree by changing TS0001018407.mdb which i

[Libreoffice-commits] .: connectivity/Module_connectivity.mk

connectivity/Module_connectivity.mk | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) New commits: commit 33973b8185b2808fe1e158aa2cd6b68d657fd9ce Author: David Ostrovsky Date: Mon Nov 5 08:38:13 2012 +0100 disable ado test to make tinderbox happy Change-Id: I2c

Re: [HELP] Base Windows-specific issues (Hackfest?)

On Sat, Nov 3, 2012 at 5:09 AM, David Ostrovsky wrote: > I pushed a complete unit test for ado driver (based on mdb files that was > attached to this issue). That is a problem your unit test modify the source tree by changing TS0001018407.mdb which in turn break the tinderbox has it fail to pull

[REVIEW 3.6] fdo 53070 freeze/hang of base when opening MS Access files/ connecting to ADO source

David Ostrovsky fixed this; thank you very much David! I propose to push this to version 3.6 as well, as the bug is a regression and it severely limits the use of Base. Winfried ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://l

[PUSHED] sal_Bool to bool

Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/979 Approvals: Norbert Thiebaud: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/979 To unsubscribe,

[Libreoffice-commits] .: sw/inc sw/source

sw/inc/txatritr.hxx | 14 +++--- sw/source/core/txtnode/txatritr.cxx | 18 +- 2 files changed, 16 insertions(+), 16 deletions(-) New commits: commit efda195ac9a5f52c7df9dba1ace6c53b8da0f260 Author: Matteo Casalin Date: Sun Nov 4 11:38:23 2012 +0100

Change ucb_Unicode to sal_Unicode

Norbert Thiebaud has abandoned this change. Change subject: Change ucb_Unicode to sal_Unicode .. Patch Set 2: Abandoned obsolete -- To view, visit https://gerrit.libreoffice.org/888 To unsubscribe, visit https://gerrit.libreof

rtl::OUString to OUString in basctl

Norbert Thiebaud has abandoned this change. Change subject: rtl::OUString to OUString in basctl .. Patch Set 1: Abandoned obsolete -- To view, visit https://gerrit.libreoffice.org/766 To unsubscribe, visit https://gerrit.libre

Proposal for fdo#42974 and moz/zipped also

Norbert Thiebaud has abandoned this change. Change subject: Proposal for fdo#42974 and moz/zipped also .. Patch Set 1: Abandoned no response from author to reviewers + wget from configure _not_ a good idea indeed -- To view, v

bnc#759197: adjust chart layout distance

Norbert Thiebaud has abandoned this change. Change subject: bnc#759197: adjust chart layout distance .. Patch Set 1: Abandoned no response from author to reviewer's comments -- To view, visit https://gerrit.libreoffice.org/581

[PATCH] basic: String -> OUString

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/988 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/88/988/1 basic: String -> OUString Change-Id: I42479b4bade5111e38d69f04c889c166f340d5ba --- M basctl/source/basicide/baside

static clang source code analysis (Code Review Requested)

Hi, Here's a clang static source code analysis of the latest git sources : http://dev-builds.libreoffice.org/clang_reports/master~2012-11-04_17.27.13/ Regards, John Smith. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

[Libreoffice-commits] .: 5 commits - sc/source

sc/source/filter/excel/xecontent.cxx | 65 ++--- sc/source/filter/excel/xestream.cxx|2 - sc/source/filter/excel/xestyle.cxx |2 - sc/source/filter/inc/xecontent.hxx |2 - sc/source/filter/xml/xmlcondformat.cxx | 32 sc/sou

[Libreoffice-commits] .: config_host.mk.in configure.ac lcms2/ExternalPackage_lcms2.mk lcms2/ExternalProject_lcms2.mk lcms2/Makefile lcms2/makefile.mk lcms2/Module_lcms2.mk lcms2/prj lcms2/UnpackedTar

Makefile.top |4 - Module_tail_build.mk |2 RepositoryExternal.mk | 31 +++-- RepositoryModule_ooo.mk|2 config_host.mk.in |2 configure.ac |6 - lcms2/ExternalPackage_l

[PATCH] Make HangulHanjaConversion an abstract class

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/987 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/87/987/1 Make HangulHanjaConversion an abstract class Change-Id: Ie39801fc14a66af8b338188c74af9f6e52031e60 --- M editeng/in

[Libreoffice-commits] .: configure.ac

configure.ac |3 +++ 1 file changed, 3 insertions(+) New commits: commit c4c160a4519f20d50e7189ef92aac99b83c4cc6a Author: Norbert Thiebaud Date: Sun Nov 4 15:50:39 2012 -0600 libcms2: mac has issue with long long Change-Id: Ibd1ec8d540597e611609dafdffb39266a2ec064d diff --gi

[Libreoffice-commits] .: configure.ac lcms2/ExternalPackage_lcms2.mk lcms2/prj libcdr/ExternalProject_libcdr.mk RepositoryExternal.mk

RepositoryExternal.mk| 14 -- configure.ac |2 ++ lcms2/ExternalPackage_lcms2.mk |8 ++-- lcms2/prj/build.lst |3 +-- libcdr/ExternalProject_libcdr.mk |1 + 5 files changed, 18 insertions(+), 10 deletions(-) New comm

[Libreoffice-commits] .: sw/source

sw/source/core/txtnode/txtedt.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 94a6776e2ae4e61bc58081ff6d734890f1458c5a Author: Matteo Casalin Date: Sun Nov 4 21:34:41 2012 +0100 Remove unused local variable Change-Id: Ib8dc3b5b37c8777acca3f16ece81f4e1c01c582d dif

infrastructure heads-up

Hello, I wanted to give all of you a quick infrastructure heads-up. You might have seen that from time to time, there are certain hiccups, which is due to the fact that in the last weeks, the popularity of our sites and therefore the use of the infrastructure has *heavily* increased. After so

[REVIEW 3-6] fix duplicate cond format rendering

Hey, the attached patch fixes a copy&paste error in the duplicate cond format code. Regards, Markus 0001-fix-copy-paste-error-fdo-55673.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesk

libreoffice@lists.freedesktop.org

Hey, the attached patch fixes a problem with conditional formats during copy&paste. They are correctly copied but later the cell objects are deleted and without the patch we also delete the conditional formats again. Regards, Markus 0001-only-delete-cond-formats-if-the-correct-attributes-a.patc

[PATCH] cppCheck: Possible inefficient checking for emptiness

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/986 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/86/986/1 cppCheck: Possible inefficient checking for emptiness Change-Id: Ief04fa81abbba9e66353c57eb586f864c37deed0 Signed-

Convert some UniString to OUString

Julien Nabet has abandoned this change. Change subject: Convert some UniString to OUString .. Patch Set 1: Abandoned No problem for not submitting it. Thank you for your feedback Ivan. -- To view, visit https://gerrit.libreoff

[PATCH] Change in core[libreoffice-3-6]: Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::E...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/985 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/85/985/1 Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::Execute Change-Id: I98f246b2bafcf2669a8f6c3ec4c86ccee56

[PUSHED] Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::E...

Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/984 Approvals: Norbert Thiebaud: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/984 To unsubscribe,

[Libreoffice-commits] .: sw/source

sw/source/ui/shells/drwtxtex.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit c954e6e1317f82e06fac66556674bc066b429469 Author: Arnaud Versini Date: Sun Nov 4 17:27:13 2012 +0100 Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::Execute

[PATCH] Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::E...

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/984 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/84/984/1 Fix fdo#56603 by NULL pointer checking in SwDrawTextShell::Execute Change-Id: I2dffbac1450682e4d116f10ca86a2837514

[PATCH] cppCheck: Various clean-up

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/983 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/83/983/1 cppCheck: Various clean-up xfdrawstyle.cxx: correct a copy/paste typo in constructor number.cxx: remove an unused

Re: [REVIEW 3-6][PUSHED] Fix incorrect shifting of cell notes.

2012/11/2 Kohei Yoshida : > > > On Fri, Nov 2, 2012 at 11:09 AM, Kohei Yoshida > wrote: >> >> Hi there, >> >> Please review and cherry-pick >> >> >> https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=e8487c8a3f3ece74143928352e1e8a7dfb72d424 >> >> to the 3-6 branch. This fixes incorre

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - sc/source

sc/source/core/data/table2.cxx | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) New commits: commit d7e30b7745ad14a4d0d17b279bb020af06463604 Author: Kohei Yoshida Date: Fri Nov 2 13:27:31 2012 -0400 Correctly handle cell note shifting when immediate row/

[Libreoffice-commits] .: 11 commits - sc/inc sc/source

sc/inc/conditio.hxx|6 + sc/inc/globstr.hrc |8 +- sc/source/core/data/conditio.cxx | 76 ++--- sc/source/filter/oox/condformatbuffer.cxx | 52 + sc/source/filter/xml/xmlcondf

[PATCH] Convert some UniString to OUString

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/982 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/82/982/1 Convert some UniString to OUString Change-Id: I527e818fa7f3ec0ee8dc8ba0103071cea8b6d4ca --- M desktop/source/deplo

[PATCH] Bug 55430 - EDITING: Single mouse click selection of element completely drawn in front of selected filled area impossible

Hi, can someone please help to get a volunteer's patch for this DRAW bug to Master? Thank you Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/m

[Libreoffice-commits] .: lcms2/ExternalPackage_lcms2.mk

lcms2/ExternalPackage_lcms2.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 057ce1fe2911f51be97199bf95e175db8aebfa42 Author: Norbert Thiebaud Date: Sun Nov 4 08:41:12 2012 -0600 lcms2: fix deliver for Mac Change-Id: Iee360073d30e490231b4383720d95bd

[Libreoffice-commits] .: 2 commits - lpsolve/ExternalProject_lpsolve.mk lpsolve/UnpackedTarball_lpsolve.mk

lpsolve/ExternalProject_lpsolve.mk |2 +- lpsolve/UnpackedTarball_lpsolve.mk | 10 +- 2 files changed, 10 insertions(+), 2 deletions(-) New commits: commit a7d34af344900233ba08aee2a56a3daf85ab2421 Author: Norbert Thiebaud Date: Sun Nov 4 08:05:10 2012 -0600 lpsolve: missing

[Libreoffice-commits] .: config_host.mk.in configure.ac lcms2/ExternalPackage_lcms2.mk lcms2/ExternalProject_lcms2.mk lcms2/Makefile lcms2/makefile.mk lcms2/Module_lcms2.mk lcms2/prj lcms2/UnpackedTar

Makefile.top |2 Module_tail_build.mk |1 RepositoryExternal.mk |6 +- RepositoryModule_ooo.mk|1 config_host.mk.in |1 configure.ac |7 -- lcms2/ExternalPackage_lcms2.mk | 28 + lcms2

[Libreoffice-commits] .: lpsolve/ExternalPackage_lpsolve.mk

lpsolve/ExternalPackage_lpsolve.mk |9 + 1 file changed, 5 insertions(+), 4 deletions(-) New commits: commit 198a18b246ac8105cd868138e0ba172f8e83c0d5 Author: Norbert Thiebaud Date: Sun Nov 4 07:13:50 2012 -0600 avoid 'else ifeq' construct in make Change-Id: I075313f99

gerrit downtime on Tuesday

Hello, in order to apply a necessary RAM upgrade, and in order to install outstanding packages, we need to shut down the host that powers gerrit for maintenance. Next Tuesday, November 6th, between 1200 and 1800 UTC gerrit will be on a scheduled downtime. We expect the host t

[Libreoffice-commits] .: mysqlc/source

mysqlc/source/registry/data/org/openoffice/Office/DataAccess/Drivers.xcu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5140baaa0283a87b8d78601619e0a58fe14adc01 Author: Andras Timar Date: Sun Nov 4 13:11:18 2012 +0100 MySQL Connector display name Ch

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - l10ntools/source

l10ntools/source/lngmerge.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit f28d71c29b83a0899922c8f32da0fa05458882e2 Author: Andras Timar Date: Sat Nov 3 00:35:14 2012 +0100 escape quotes, unescape double escaped quotes fdo#56648 Change-Id: I

[PATCH] Reinsert usings for OString and OUString

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/981 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/81/981/1 Reinsert usings for OString and OUString I have not investigated the details, but making a full build (make clean;

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 41996, which changed state. Bug 41996 Summary: EDITING: Drag and Drop Slides impossible with KDE https://bugs.freedesktop.org/show_bug.cgi?id=41996 What|Removed |Added -

[Libreoffice-commits] .: lpsolve/ExternalPackage_lpsolve.mk

lpsolve/ExternalPackage_lpsolve.mk |1 - 1 file changed, 1 deletion(-) New commits: commit 9ce3dea2fa630680f0648da77f9828281079abc4 Author: Julien Nabet Date: Sun Nov 4 12:27:56 2012 +0100 Revert last commit Change-Id: I45496eb188339092e7b718064b9a2e88d2d9dd01 diff --git a/l

[Libreoffice-commits] .: lpsolve/ExternalPackage_lpsolve.mk

lpsolve/ExternalPackage_lpsolve.mk |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 376c1dfffe1c87f87265f8d22d484fd6bb6185dd Author: Julien Nabet Date: Sun Nov 4 12:00:38 2012 +0100 Try to fix a missing endif blindly Change-Id: I05474288e19b9bf6d7cad

[PATCH] Remove unnecessary #include

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/980 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/80/980/1 Remove unnecessary #include Change-Id: I3c33ce1eecad649c3d23719b51d51057d41d9a2e --- M sw/source/ui/lingu/hhcwrp.c

[PATCH] sal_Bool to bool

Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/979 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/79/979/1 sal_Bool to bool Change-Id: I8a4890c6b0e466417387a09259e32dff57c640d6 --- M sw/inc/txatritr.hxx M sw/source/core/t

[Libreoffice-commits] .: basic/source

basic/source/basmgr/basmgr.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 99ddd576935c6114d00e5a51756d3dd78070af58 Author: Julien Nabet Date: Sun Nov 4 11:12:48 2012 +0100 Fix .Len -> getLength Change-Id: Ibe3e97a6fa59098b9234e4aae04118abc4e37eea

Re: no functional TinderBox for master/3-7 full Windows builds

> Found a recommended source and copied the missing dll into the > C:\Program File (x86)\LOdev 3.7\program directory. > > http://www.dll-files.com/dllindex/dll-files.shtml?msvcr100d > "Recommended source"? Surely downloading random DLLs that are "missing" from "helpful" sites and plonking them all