[Libreoffice-commits] .: reportbuilder/java wizards/com

2012-10-09 Thread Libreoffice Gerrit user
reportbuilder/java/com/sun/star/report/SDBCReportData.java | 11 reportbuilder/java/com/sun/star/report/SOImageService.java |1 reportbuilder/java/com/sun/star/report/pentaho/SOFormulaParser.java

[Libreoffice-commits] .: 5 commits - sc/inc sc/source

2012-10-09 Thread Libreoffice Gerrit user
sc/inc/colorscale.hxx | 10 + sc/source/core/data/colorscale.cxx | 13 -- sc/source/filter/excel/xecontent.cxx | 22 ++-- sc/source/filter/excel/xeextlst.cxx| 22 ++-- sc/source/filter/inc/xecontent.hxx |3 sc/sour

[Libreoffice-commits] .: 3 commits - sc/source

2012-10-09 Thread Libreoffice Gerrit user
sc/source/ui/condformat/condformatdlg.cxx | 52 +++--- 1 file changed, 33 insertions(+), 19 deletions(-) New commits: commit c20486fbffaa2d5ff20dad668c0f28b2c5f20e39 Author: Markus Mohrhard Date: Wed Oct 10 03:39:39 2012 +0200 prevent flickering when clicking at

[Libreoffice-commits] .: 4 commits - sc/source

2012-10-09 Thread Libreoffice Gerrit user
sc/source/ui/condformat/condformatdlg.cxx | 47 +- sc/source/ui/condformat/condformatdlgentry.cxx |6 sc/source/ui/inc/condformatdlg.hxx |8 - sc/source/ui/inc/condformatdlgentry.hxx|9 - sc/source/ui/inc/funcutl.hxx | 188

On support for Ideographic Variation Sequences

2012-10-09 Thread Takeshi Abe
Hi all, I am now wondering how we can approach support for ideographic variation sequences (IVS) in LibreOffice, which has been long requested as you can see at [1]. So far, having read [2] about Mozilla's case, I think HarfBuzz looks promising for the purpose. And employing the library has alre

[Libreoffice-commits] .: sw/inc sw/source

2012-10-09 Thread Libreoffice Gerrit user
sw/inc/SwStyleNameMapper.hxx| 10 +++--- sw/source/core/doc/SwStyleNameMapper.cxx| 26 - sw/source/core/docnode/ndnotxt.cxx |2 - sw/source/core/docnode/node.cxx |4 +- sw/source/core/layout/atrfrm.cxx

[Libreoffice-commits] .: binfilter/bf_svtools binfilter/inc

2012-10-09 Thread Libreoffice Gerrit user
binfilter/bf_svtools/source/misc/svt_ehdl.cxx | 54 -- binfilter/inc/bf_svtools/ehdl.hxx |8 +-- 2 files changed, 30 insertions(+), 32 deletions(-) New commits: commit a8de7ee56a3c8375c585db364dac5f67d72ea97a Author: Michael Stahl Date: Wed Oct 10 00:2

[Libreoffice-commits] .: svl/source

2012-10-09 Thread Libreoffice Gerrit user
svl/source/numbers/numfmuno.cxx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) New commits: commit 61b94e06ef5a822e0dbe24528bc5d4d112a2547b Author: Caolán McNamara Date: Tue Oct 9 23:13:29 2012 +0100 These are now already OUStrings, so no need for extra te

[Libreoffice-commits] .: svtools/inc svtools/source

2012-10-09 Thread Libreoffice Gerrit user
svtools/inc/svtools/toolpanelopt.hxx |3 --- svtools/source/config/toolpanelopt.cxx | 10 -- 2 files changed, 13 deletions(-) New commits: commit 2a680739f8dfe123316a69a9c85030f784ca1f22 Author: Caolán McNamara Date: Tue Oct 9 23:05:23 2012 +0100 AddListenerLink/RemoveLis

[Libreoffice-commits] .: linguistic/source

2012-10-09 Thread Libreoffice Gerrit user
linguistic/source/dicimp.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 321fec4eead0f674ca16ef55c624812d3906b355 Author: Caolán McNamara Date: Tue Oct 9 23:04:37 2012 +0100 restore saveEntries ebf82e52c945f8c2a7c021b547064e5bbeadfe2f cut a little too deep

[PUSHED] Remove more unused methods

2012-10-09 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/837 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/837 To unsubscribe, v

[Libreoffice-commits] .: svtools/source unusedcode.easy

2012-10-09 Thread Libreoffice Gerrit user
svtools/source/config/toolpanelopt.cxx | 29 - unusedcode.easy|2 -- 2 files changed, 31 deletions(-) New commits: commit ac8d3988890e0dbd19afb496033725a9878a86cc Author: Marcos Paulo de Souza Date: Sun Oct 7 21:23:27 2012 -0300 Re

[PUSHED] Kill use of macro LINGU_EXCEPTIONS

2012-10-09 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/778 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/778 To unsubscribe, v

[Libreoffice-commits] .: lingucomponent/source linguistic/source

2012-10-09 Thread Libreoffice Gerrit user
lingucomponent/source/spellcheck/macosxspell/macspellimp.mm |8 --- lingucomponent/source/spellcheck/spell/sspellimp.cxx|8 --- linguistic/source/dicimp.cxx| 27 linguistic/source/hyphdsp.cxx | 16 --

[Libreoffice-commits] .: svl/source svtools/source

2012-10-09 Thread Libreoffice Gerrit user
svl/source/numbers/zformat.cxx |2 +- svtools/source/misc/ehdl.cxx | 40 +--- 2 files changed, 10 insertions(+), 32 deletions(-) New commits: commit 55149144cb926513ef250c87fdf0c59e11e2f6cf Author: Michael Stahl Date: Tue Oct 9 23:32:18 2012 +0200

[Libreoffice-commits] .: lotuswordpro/source

2012-10-09 Thread Libreoffice Gerrit user
lotuswordpro/source/filter/lwpcharacterstyle.cxx |2 - lotuswordpro/source/filter/lwpfrib.cxx | 44 --- lotuswordpro/source/filter/lwpfribheader.hxx |9 lotuswordpro/source/filter/lwplaypiece.hxx |5 -- lotuswordpro/source/filter/lwpobjtag

[PUSHED] Remove useless code

2012-10-09 Thread via Code Review
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/777 Approvals: Caolán McNamara: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/777 To unsubscribe, v

[Libreoffice-commits] .: 2 commits - compilerplugins/Makefile-clang.mk xpdf/makefile.mk xpdf/xpdf-no-writable-literals.patch

2012-10-09 Thread Libreoffice Gerrit user
compilerplugins/Makefile-clang.mk|4 xpdf/makefile.mk |2 +- xpdf/xpdf-no-writable-literals.patch | 21 + 3 files changed, 26 insertions(+), 1 deletion(-) New commits: commit 98a6d76f1eb20346828056b906bd775c8247e992 Author: Luboš Luňák

[PUSHED] String->OUString in SVL::SvNumberFormat calendar methods

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/772 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/772 To unsubscribe, vis

[Libreoffice-commits] .: svl/inc svl/source

2012-10-09 Thread Libreoffice Gerrit user
svl/inc/svl/zformat.hxx|8 svl/source/numbers/zformat.cxx | 28 ++-- 2 files changed, 18 insertions(+), 18 deletions(-) New commits: commit 68abd6d9258975e9ef1155f726fe4c12bb0918e2 Author: Noel Grandin Date: Fri Oct 5 09:08:24 2012 +0200 Stri

[PUSHED] String->OUString in svl::ImpSvNumFor::GetNewCurrencySymbol m...

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/771 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/771 To unsubscribe, vis

[PUSHED] String->OUString in svl::SvNumberFormat::GetMappedFormatstri...

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/770 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/770 To unsubscribe, vis

[Libreoffice-commits] .: svl/inc svl/source svx/source

2012-10-09 Thread Libreoffice Gerrit user
svl/inc/svl/zformat.hxx |4 ++-- svl/source/numbers/numfmuno.cxx |9 + svl/source/numbers/zforfind.cxx |6 +++--- svl/source/numbers/zforlist.cxx |8 svl/source/numbers/zformat.cxx | 14 +++--- svx/source/items/numfmtsh.cxx |2 +- 6 files c

[Libreoffice-commits] .: svl/inc svl/source

2012-10-09 Thread Libreoffice Gerrit user
svl/inc/svl/zformat.hxx|2 - svl/source/numbers/zformat.cxx | 48 - 2 files changed, 25 insertions(+), 25 deletions(-) New commits: commit be5f517a37086ee270a954cf8461585be7c39242 Author: Noel Grandin Date: Fri Oct 5 08:15:43 2012 +0200

[PUSHED] String->OUString in tools::ErrorContext

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/769 Approvals: Michael Stahl: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/769 To unsubscribe, vis

[Libreoffice-commits] .: sd/source svtools/inc svtools/source test/source tools/inc tools/source uui/source

2012-10-09 Thread Libreoffice Gerrit user
sd/source/filter/html/htmlex.cxx |8 ++-- sd/source/filter/html/htmlex.hxx |2 - svtools/inc/svtools/ehdl.hxx |8 ++-- svtools/source/misc/ehdl.cxx | 53 test/source/bootstrapfixture.cxx |2 - tools/inc/tools/errinf.hxx |

[Libreoffice-commits] .: jfreereport/prj

2012-10-09 Thread Libreoffice Gerrit user
jfreereport/prj/d.lst |2 -- 1 file changed, 2 deletions(-) New commits: commit 227d385fcdaf30ef4bd294d99b088ef533372d58 Author: David Ostrovsky Date: Tue Oct 9 23:04:13 2012 +0200 jfreereport clean d.lst after gbuildification Change-Id: I58114ca1229b2d02a80b3908a740bffc65f75

[Libreoffice-commits] .: sfx2/source

2012-10-09 Thread Libreoffice Gerrit user
sfx2/source/dialog/tabdlg.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit bf59cceafd05dba74e4fc3a3f5fdc8098bb1a95b Author: Caolán McNamara Date: Tue Oct 9 22:02:44 2012 +0100 fix blank dialogs: now need to explicitly call show on containers Change-Id: I803f808

[Libreoffice-commits] .: configure.in

2012-10-09 Thread Libreoffice Gerrit user
configure.in |4 1 file changed, 4 insertions(+) New commits: commit 8e610f6148c89d931d264b81fb1f5736e45c8a93 Author: Luboš Luňák Date: Tue Oct 9 22:56:16 2012 +0200 explicitly fail with --enable-compiler-plugins if compiler is not clang Change-Id: I7c21730486f74b44b7

[PUSHED] Add a 'fromIndex' parameter to OUString::replaceAll

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/768 -- To view, visit https://gerrit.libreoffice.org/768 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

[Libreoffice-commits] .: sal/inc sal/rtl sal/util

2012-10-09 Thread Libreoffice Gerrit user
sal/inc/rtl/ustring.h | 23 +++ sal/inc/rtl/ustring.hxx|8 +--- sal/rtl/source/ustring.cxx | 10 +- sal/util/sal.map |1 + 4 files changed, 38 insertions(+), 4 deletions(-) New commits: commit 7ef1190c3e9422998d89df2cf8fcf30bddfc1a03

Re: Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version `GLIBCXX_3.4.11' not found (required by /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)

2012-10-09 Thread ChrSchultz
I created a symbolic link from the system libstdc++.so.6 to the /opt/libreoffice3.6/ure/lib/libstdc++.so.6 and the are no warnings more ... Many greatings Christoph -- View this message in context: http://nabble.documentfoundation.org/Gtk-WARNING-opt-libreoffice3-6-program-ure-link-lib-libstd

[PATCH] Review corrections in basctl/.../basobj3.cxx

2012-10-09 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/851 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/51/851/1 Review corrections in basctl/.../basobj3.cxx Change-Id: I905e85ce9d754047ad287c9dd3caa92427b25b0d --- M basctl/sou

[Libreoffice-commits] .: Branch 'feature/killsdf' - l10ntools/source

2012-10-09 Thread Libreoffice Gerrit user
l10ntools/source/po.cxx | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit 1ef83f535f638ddfa7f2ad0533f88c37e7bcbeef Author: Zolnai Tamás Date: Tue Oct 9 22:31:23 2012 +0200 Use _t suffix for typedef Change-Id: I8501739e9fb1b184facebc406ed6e20d

[Libreoffice-commits] .: Branch 'feature/killsdf' - l10ntools/source

2012-10-09 Thread Libreoffice Gerrit user
l10ntools/source/po.cxx| 427 + l10ntools/source/propmerge.cxx |8 2 files changed, 229 insertions(+), 206 deletions(-) New commits: commit 63af8783bcb418e72e59f5faf3a070701b828845 Author: Zolnai Tamás Date: Tue Oct 9 22:05:24 2012 +0200

[PUSHED] Resolves: fdo#55367 wrong convertion factor for "tspm"

2012-10-09 Thread Eike Rathke (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/849 Approvals: Eike Rathke: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/849 To unsubscribe, visit

[Libreoffice-commits] .: scaddins/source

2012-10-09 Thread Libreoffice Gerrit user
scaddins/source/analysis/analysishelper.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 6f35bbfe408f662a74101598e71d6b2970796036 Author: Julien Nabet Date: Tue Oct 9 20:57:40 2012 +0200 Resolves: fdo#55367 wrong convertion factor for "tspm" Change

[PATCH] fdo#48873 clean unused icons

2012-10-09 Thread leighman (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/850 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/50/850/1 fdo#48873 clean unused icons Change-Id: Ia797808dcee0cee53f72c5bda62297130e04e85e --- D icon-themes/galaxy/dbacces

[PATCH] Resolves: fdo#55367 wrong convertion factor for "tspm"

2012-10-09 Thread Julien Nabet (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/849 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/49/849/1 Resolves: fdo#55367 wrong convertion factor for "tspm" Change-Id: If37ef46ab009b9886fefd0ca071bd81dd68e25fc --- M

Windows building and /proc/registry

2012-10-09 Thread julien2412
I noticed that if launch cygwin with admin rights, there's no problem to access registry keys (and read VCExpress/Visual Studio) I sent a post here: http://cygwin.1069669.n5.nabble.com/Registry-keys-not-only-accessible-when-user-tc93406.html Julien -- View this message in context: http://nab

Re: [PATCH] fdo#55367 CALC FUNCTION CONVERT_ADD wrong conversion factor for "tspm"

2012-10-09 Thread julien2412
Finally, I submitted for review since there were no pb with "tsp". Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-fdo-55367-CALC-FUNCTION-CONVERT-ADD-wrong-conversion-factor-for-tspm-tp4011932p4012371.html Sent from the Dev mailing list archive at Nabble.com

[PATCH] Change in core[libreoffice-3-6]: RepositoryExternal: internal libpng requires zlib as well

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/848 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/48/848/1 RepositoryExternal: internal libpng requires zlib as well (cherry picked from commit 398ce44c54b26b31eb826c150926f

[PATCH] Change in core[libreoffice-3-6]: fdo#55526: fix import of RTF \brdrhair:

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/847 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/47/847/1 fdo#55526: fix import of RTF \brdrhair: This is a hairline border that should be mapped to a non-zero width border

[PATCH] Change in core[libreoffice-3-6]: add editeng::ConvertBorderWidthFromWord:

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/846 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/46/846/1 add editeng::ConvertBorderWidthFromWord: Replace the 2 duplicate implementations of this in ww8 and writerfilter w

[Libreoffice-commits] .: sw/qa

2012-10-09 Thread Libreoffice Gerrit user
sw/qa/extras/odfexport/data/first-header-footer.odt |binary sw/qa/extras/odfexport/odfexport.cxx| 22 +++ sw/qa/extras/ww8export/data/first-header-footer.doc |binary sw/qa/extras/ww8export/ww8export.cxx| 23 4 files changed

[PATCH] Change in core[libreoffice-3-6]: fdo#54648: WW8 export: test that FlyFrm actually has layout ...

2012-10-09 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/845 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/845/1 fdo#54648: WW8 export: test that FlyFrm actually has layout frm The bugdoc has 2 "hidden" drawing objects that are

[Libreoffice-commits] .: 3 commits - editeng/inc editeng/source sw/source writerfilter/source

2012-10-09 Thread Libreoffice Gerrit user
editeng/inc/editeng/borderline.hxx |5 + editeng/source/items/borderline.cxx | 89 ++- sw/source/filter/ww8/wrtw8esh.cxx|4 + sw/source/filter/ww8/ww8par6.cxx | 76 --- writerfilter/source/dm

Re: [PATCH] Introducing compiler plugin support

2012-10-09 Thread Caolán McNamara
On Tue, 2012-10-09 at 17:26 +0200, Lubos Lunak wrote: > - there is a warning about unused variables of types marked SAL_WARN_UNUSED > plus some C++ std classes ; quite a number of hits. Feel free to tag all > those Point, Rectangle, etc. classes with it too, as long as it's certain for > the cla

Re: [PATCH] Introducing compiler plugin support

2012-10-09 Thread Michael Stahl
> On Monday 08 of October 2012, Michael Stahl wrote: >> On 05/10/12 18:22, Lubos Lunak wrote: >>> +$(CLANGOUTDIR)/compileplugin.so: $(2) >>> +$(CLANGOUTDIR)/compileplugin.so: CLANGOBJS += $(2) >>> + >>> +$(CLANGOUTDIR)/compileplugin.so: $(CLANGOBJS) >> >> there's a bit of redundancy there. > > Th

[Libreoffice-commits] .: 2 commits - helpcontent2/helpers helpcontent2/source

2012-10-09 Thread Libreoffice Gerrit user
helpcontent2/helpers/help_hid.lst | 56 -- helpcontent2/source/text/shared/00/0200.xhp| 45 helpcontent2/source/text/shared/01/password_dlg.xhp|7 - helpcontent2/source/text/shared/explorer/database/0503.xhp

Re: the inevitable C formatting/brace style flamewar

2012-10-09 Thread Lubos Lunak
On Friday 17 of August 2012, Jan Holesovsky wrote: > Hi Michael, > > Michael Stahl píše v Čt 16. 08. 2012 v 19:07 +0200: > > if memory serves i've reviewed 2 patches in the last 3 months or so that > > added a statement to a 1-line then or else clause that was indented but > > did not have braces,

Re: [PATCH] Introducing compiler plugin support

2012-10-09 Thread Lubos Lunak
On Friday 05 of October 2012, Lubos Lunak wrote: > Hello, > > attached is my implementation of basic build support for using Clang > compiler plugin during building LO. I'm posting it here first in case our > build system people have different ideas to how I have integrated it in the > build syst

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - 3 commits - android/Bootstrap android/experimental

2012-10-09 Thread Libreoffice Gerrit user
android/Bootstrap/Makefile.shared |3 android/experimental/DocumentLoader/Makefile |1 android/experimental/LibreOffice4Android/Makefile | 1

[PUSHED] ::rtl::OUString to OUString in basctl

2012-10-09 Thread Muthu Subramanian K (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/835 -- To view, visit https://gerrit.libreoffice.org/835 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

[PUSHED] Some OUString and RTL_CONST refactoring

2012-10-09 Thread Muthu Subramanian K (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/836 -- To view, visit https://gerrit.libreoffice.org/836 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

[PUSHED] More ::rtl::OUString to OUString in basctl

2012-10-09 Thread Muthu Subramanian K (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/834 -- To view, visit https://gerrit.libreoffice.org/834 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

[PUSHED] rtl::OUString to OUString in basctl

2012-10-09 Thread Muthu Subramanian K (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/767 -- To view, visit https://gerrit.libreoffice.org/767 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: me

[Bug 54157] LibreOffice 3.7 most annoying bugs

2012-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Roman Eisele changed: What|Removed |Added Depends on||55807 --- Comment #17 from Roman Eisele

[Libreoffice-commits] .: oox/source

2012-10-09 Thread Libreoffice Gerrit user
oox/source/ppt/slidefragmenthandler.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 4874a0dcbfe56028d5ac7f44bb994837eb003c35 Author: Radek Doulik Date: Tue Oct 9 11:24:28 2012 +0200 added safety check Change-Id: I05ca3e5b176202d26c2f2e45cc674ea549

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - android/experimental

2012-10-09 Thread Libreoffice Gerrit user
android/experimental/DocumentLoader/Makefile | 188 --- 1 file changed, 1 insertion(+), 187 deletions(-) New commits: commit 84e01cf1c2584dc399d635eeda06003d7d520545 Author: Tor Lillqvist Date: Tue Oct 9 14:42:06 2012 +0300 Just use the wildcard function to list a

[Libreoffice-commits] .: starmath/README

2012-10-09 Thread Libreoffice Gerrit user
starmath/README |3 +++ 1 file changed, 3 insertions(+) New commits: commit 9040130ade07bc1b6757a48928ad01a3510865f0 Author: Andras Timar Date: Tue Oct 9 13:44:39 2012 +0200 add link to detailed module description to Math's README Change-Id: I930f8729a58fb8cd3209df2ad1b112150

[Libreoffice-commits] .: cui/README

2012-10-09 Thread Libreoffice Gerrit user
cui/README |8 1 file changed, 8 insertions(+) New commits: commit 138f1159c4ad2d742385c986efd36d9489d185ad Author: Miklos Vajna Date: Tue Oct 9 13:27:32 2012 +0200 cui: add initial README Change-Id: I4334373637834d04b28a01891b7728a32060cf3a diff --git a/cui/README

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - solenv/gbuild

2012-10-09 Thread Libreoffice Gerrit user
solenv/gbuild/platform/ANDROID_ARM_GCC.mk| 115 -- solenv/gbuild/platform/ANDROID_GODSON_GCC.mk | 71 - solenv/gbuild/platform/ANDROID_INTEL_GCC.mk | 71 - solenv/gbuild/platform/android.mk| 141 +++ 4 files

[Libreoffice-commits] .: icon-themes/README

2012-10-09 Thread Libreoffice Gerrit user
icon-themes/README |5 - 1 file changed, 5 deletions(-) New commits: commit fd5c4df7a2a3ebbad5611346bb43fe909424ff17 Author: Andras Timar Date: Tue Oct 9 12:05:27 2012 +0200 remove obsoleted instruction from icon themes' README Change-Id: Id6e7f7dea6284af1b94c2616c9c83f88

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - sw/source

2012-10-09 Thread Libreoffice Gerrit user
sw/source/ui/dialog/swdialmgr.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit 128f12719757eec2b346068446223961f50ae496 Author: Tor Lillqvist Date: Tue Oct 9 12:21:38 2012 +0300 Do the de-duplication of pSwResMgr a bit differently Let the cod

[Libreoffice-commits] .: Branch 'feature/android-single-dso' - android/experimental

2012-10-09 Thread Libreoffice Gerrit user
android/experimental/DocumentLoader/Makefile|9 + android/experimental/DocumentLoader/native-code.cxx | 16 2 files changed, 25 insertions(+) New commits: commit 9f4dccb81d85571c1785adeb675680b41d3a11ee Author: Tor Lillqvist Date: Tue Oct 9 12:27:22 2012

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #387 from Timon --- If we speak about academic usage, then there is another Bug 53961 with OLE https://bugs.freedesktop.org/show_bug.cgi?id=53961 It also present in AOO and confirmed there https://issues.apache.org/ooo/show_bug.cgi?id

[Libreoffice-commits] .: sw/source

2012-10-09 Thread Libreoffice Gerrit user
sw/source/ui/dialog/swdialmgr.cxx |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) New commits: commit a6ab8927c74d512675dcc174b0d179f02a4c64d6 Author: Tor Lillqvist Date: Tue Oct 9 12:21:38 2012 +0300 Do the de-duplication of pSwResMgr a bit differently Let the cod

Re: [REVEIW 3-6][PUSHED] fix import/export of column widths fdo#55623

2012-10-09 Thread Noel Power
Hi Markus On 09/10/12 04:50, Markus Mohrhard wrote: Hey Noel, 2012/10/4 Noel Power : [...] please think about cherry-picking http://cgit.freedesktop.org/libreoffice/core/commit/?id=8e753f8446554822d97969b0c18eba6cb9d79e26 Pushed to 3-6 with my sign-off. thanks, appreciated :-) However I n

[Libreoffice-commits] .: scp2/source setup_native/prj setup_native/source

2012-10-09 Thread Libreoffice Gerrit user
scp2/source/ooo/file_library_ooo.scp | 11 scp2/source/ooo/windowscustomaction_ooo.scp| 10 setup_native/prj/build.lst |1 setup_native/source/win32/customactions/rebase/makefile.mk | 82 setup_native/source/wi

[Libreoffice-commits] .: sc/source

2012-10-09 Thread Libreoffice Gerrit user
sc/source/ui/inc/condformatdlg.hrc |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 77f8ca714250f83ecf501a6ecbd23c9849ab6a70 Author: Markus Mohrhard Date: Tue Oct 9 10:58:58 2012 +0200 same identifier for different resources Change-Id: Ibe80f6ec6e85942

Rebasing (Was: dbghelp.dll fails on rebase (on Windows))

2012-10-09 Thread Tor Lillqvist
> Again, I wonder how essential / useful this whole rebasing thing is > any more in this day... But yeah, I know that suggesting we stop doing > it will bring up arguments that essentially say "if it might be useful > for even one percent of our userbase, we should keep doing it". After the recent

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Roman Eisele changed: What|Removed |Added Depends on||50774 --- Comment #386 from Roman Eisele

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 --- Comment #138 from Roman Eisele --- (In reply to comment #137) > Nominating Bug 50774 with autonumeration (problems in TOC) > https://bugs.freedesktop.org/show_bug.cgi?id=50774 Agree: really annoying, a killer for academic etc. usage. However

[Libreoffice-commits] .: vcl/source

2012-10-09 Thread Libreoffice Gerrit user
vcl/source/control/fixed.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 1e456c0cb1e0d635713b1e0ad8ca6cfa3950f547 Author: Michael Stahl Date: Tue Oct 9 10:49:43 2012 +0200 vcl: -Werror=return-type Change-Id: I82d7041ca12dffb946758b667d02ba2d9aa7c4bc diff --git a

[Libreoffice-commits] .: 4 commits - config_host.mk.in configure.in download external/prj external/rebase postprocess/prj postprocess/rebase

2012-10-09 Thread Libreoffice Gerrit user
config_host.mk.in |1 configure.in | 11 - download | 24 -- external/prj/d.lst|2 external/rebase/README_rebase.exe |1 postprocess/prj/build.lst |7 postprocess/rebase/coffbase.txt |

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 55710, which changed state. Bug 55710 Summary: CRASH FILEOPEN particular .ods with Conditional Formatting https://bugs.freedesktop.org/show_bug.cgi?id=55710 What|Removed |Added

[Libreoffice-commits] .: 5 commits - configure.in cppuhelper/source cui/source sd/source sw/source

2012-10-09 Thread Libreoffice Gerrit user
configure.in |2 +- cppuhelper/source/shlib.cxx |4 cui/source/factory/dlgfact.cxx| 14 +++--- cui/source/factory/dlgfact.hxx|4 ++-- sd/source/ui/dlg/sddlgfact.cxx| 10 +- sd/source/ui/dlg/sddlgfact.hxx|4 ++-- sw

[Libreoffice-commits] .: svtools/source

2012-10-09 Thread Libreoffice Gerrit user
svtools/source/filter/exportdialog.cxx |1 - svtools/source/filter/exportdialog.hrc |1 - svtools/source/filter/exportdialog.hxx |1 - svtools/source/filter/exportdialog.src |6 -- 4 files changed, 9 deletions(-) New commits: commit f9a12d8dd35882b5d58a12b70ff8d2f9ee8b6acf Aut

[PUSHED] Get ride of not used macros in filter

2012-10-09 Thread Thomas Arnhold (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/843 Approvals: Thomas Arnhold: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/843 To unsubscribe, vi

[Libreoffice-commits] .: filter/source

2012-10-09 Thread Libreoffice Gerrit user
filter/source/config/cache/filterfactory.cxx | 30 --- filter/source/msfilter/msdffimp.cxx |8 --- filter/source/xsltdialog/xmlfileview.cxx |6 - 3 files changed, 44 deletions(-) New commits: commit ad181973af9be0b5bea129ef9a1976b379681e66 Au

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-09 Thread Michael Meeks
Hi Tor, On Tue, 2012-10-09 at 09:29 +0300, Tor Lillqvist wrote: > Anyway, my main point was not that we should drop the "lcl_" prefix, > but that we should make these functions *actually* local, also for the > tool-chain, i.e. either static or in anonymous namespaces. Amen - we should sta

Re: fdo#51004: some progress and 10 years old bug pending

2012-10-09 Thread d . ostrovsky
Hi Michael, Quoting Michael Meeks : Of course - it would be -lovely- to have a native C++ unit test in dbaccess/qa/extras/ that we could use to do a few queries on a sample mork file and add that to our regression test suite :-) having more native-code dbaccess/ tests as a harness others can b

[Libreoffice-commits] .: svtools/source

2012-10-09 Thread Libreoffice Gerrit user
svtools/source/filter/exportdialog.cxx | 158 + svtools/source/filter/exportdialog.hrc |6 - svtools/source/filter/exportdialog.hxx |6 - svtools/source/filter/exportdialog.src | 52 -- 4 files changed, 6 insertions(+), 216 deletions(-) New commi

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-09 Thread Bjoern Michaelsen
On Tue, Oct 09, 2012 at 08:59:47AM +0300, Tor Lillqvist wrote: > Where did this lcl_ convention come from? http://wiki.openoffice.org/wiki/Writer_Code_Conventions#free_functions_and_methods > The lcl_ prefix has no meaning to a compiler or linker. If the intent is to > make such functions file-lo

[Libreoffice-commits] .: svtools/source

2012-10-09 Thread Libreoffice Gerrit user
svtools/source/filter/exportdialog.cxx | 14 -- svtools/source/filter/exportdialog.hrc |1 - svtools/source/filter/exportdialog.hxx |1 - svtools/source/filter/exportdialog.src |7 --- 4 files changed, 23 deletions(-) New commits: commit e8624cc0e2777ffcc7d06bd76ff73

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-10-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 54259, which changed state. Bug 54259 Summary: FILESAVE: When saving in MSWord .doc format, some table cells unmerged so data not shown properly https://bugs.freedesktop.org/show_bug.cgi?id=54259 What|Rem

Re: What features of LO are non-ODFv1.2?

2012-10-09 Thread Tor Lillqvist
I wrote: > Surely any ODF implementation is free to *display* documents however it > wishes, even if it would implement (in the sense of "round-trip") the > document exactly. The *rendering* is completely unspecified by ODF, > isn't it? Michael Stahl replied: > rendering is quite constrained by

[Libreoffice-commits] .: vcl/inc vcl/source

2012-10-09 Thread Libreoffice Gerrit user
vcl/inc/vcl/fixed.hxx | 10 +- vcl/source/control/button.cxx |6 +-- vcl/source/control/fixed.cxx | 67 +++--- 3 files changed, 62 insertions(+), 21 deletions(-) New commits: commit cd5d41470d0657ee6fb05e93aea58adeb8afc0e5 Author: Caolán M

[PUSHED-3-6] fix for fdö#55710, don't insert pointer twice into a ptr_set

2012-10-09 Thread Fridrich Strba
Looks OK to my little brain. Pushed Thanks F. On 09/10/12 08:54, Markus Mohrhard wrote: > Hey, > > the attached patch prevents inserting the same pointer into a ptr_set. > The result of inserting it a second time is that on the second pointer > delete is called which in the end invalidates both

Re: Is the lcl_LocalFunction naming convention useful?

2012-10-09 Thread Lubos Lunak
On Tuesday 09 of October 2012, Miklos Vajna wrote: > On Tue, Oct 09, 2012 at 09:29:45AM +0300, Tor Lillqvist wrote: > > > > Where did this lcl_ convention come from? From a codebase that is ridden with Hungarian notation and other eye-"pleasing" features? > > But how is the fact that you see t

[REVIEW-3-6] fix for fdö#55710, don't insert pointer twice into a ptr_set

2012-10-09 Thread Markus Mohrhard
Hey, the attached patch prevents inserting the same pointer into a ptr_set. The result of inserting it a second time is that on the second pointer delete is called which in the end invalidates both the data behind the pointer and also the already existing entry in the ptr_set. The patch is a 3-6

Re: [PATCH][PUSHED] LibreOffice - add Croatian [hr-HR] genitive case month names

2012-10-09 Thread sensei
On 10/08/2012 11:58 AM, Eike Rathke wrote: > Hi sensei, > > On Monday, 2012-10-08 01:55:56 +0200, sensei wrote: > >> This patch add Croatian [hr-HR] genitive case month names to LibreOffice; > > Thanks, committed to master > http://cgit.freedesktop.org/libreoffice/core/commit/?id=46caf0e07b42fa8

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

2012-10-09 Thread Libreoffice Gerrit user
sc/source/filter/xml/xmlstyli.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit d126dcfe359782a6229156f7cbdb20e642b63a5e Author: Markus Mohrhard Date: Tue Oct 9 08:46:31 2012 +0200 don't insert the same pointer twice into a ptr_set, fdo#55710 Si