Re: widget layout status

2012-09-26 Thread David Tardon
Hi, On Wed, Sep 26, 2012 at 04:42:54PM +0100, Caolán McNamara wrote: > I've been fixing up the remaining pesky problems. e.g. re-doing the > printer dialog and sorting out the painfully opaque tab-through-controls > logic in the light of intermediate layout widgets and I'm fairly happy > with how

Re: [PUSHED 3-6] For msi installer, only default-select a subset of dictionaries

2012-09-26 Thread Stephan Bergmann
On 09/24/2012 12:25 AM, Andras Timar wrote: I experienced strange behaviour with en-US-hu-ro 3 language build, English dictionary was not selected. When I built all languages, it worked as expected. So, I pushed these patches to libreoffice-3-6 branch, because they seem to work nicely in release

[PATCH] Change in core[libreoffice-3-6]: No dictionaries were preselected for en_US langpack

2012-09-26 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/707 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/707/1 No dictionaries were preselected for en_US langpack ...as gm_Langpack_r_en_US was explicitly excluded from langs[]

[Libreoffice-commits] .: setup_native/source

2012-09-26 Thread Libreoffice Gerrit user
setup_native/source/win32/customactions/sellang/sellang.cxx | 160 +--- 1 file changed, 70 insertions(+), 90 deletions(-) New commits: commit 8cb7464130634551fd2f043efc14f8f8f8bdf447 Author: Stephan Bergmann Date: Thu Sep 27 08:31:41 2012 +0200 No dictionaries were preselected fo

Re: [SOLVED] Re: Master failed to compile on scp2 module

2012-09-26 Thread David Tardon
Hi, On Wed, Sep 26, 2012 at 11:06:13AM -0700, julien2412 wrote: > Just to say that after a "git pull -r", it's compiling right now. > I don't know which commit fixed the problem but it's ok. Commit 8d08ebb6c639cb419c97ae745ce626eee1bd4601. I am sorry for that--I was not avare that the 'private' m

Re: Adding Extension for Experimental Thai Spelling

2012-09-26 Thread Nathan Wells
Thanks Martin, 1. If you are shutting off the ICU breakiterator for text following, we > should probably also do it for text preceding. Thus if there is a ZWSP or > ZWNBSP (U+2060 WJ) anywhere in a text then ICU break iteration is disabled > for the whole sentence. Yes, I think you are right. I

[Libreoffice-commits] .: sw/inc sw/source

2012-09-26 Thread Libreoffice Gerrit user
sw/inc/crsrsh.hxx| 16 +++--- sw/inc/node.hxx |2 - sw/source/core/crsr/crsrsh.cxx | 44 +++ sw/source/core/crsr/crstrvl.cxx |2 - sw/source/core/crsr/trvltbl.cxx | 14 ++-- sw/source/core/docnod

Re: Adding Extension for Experimental Thai Spelling

2012-09-26 Thread Nathan Wells
Hello Again, Thank you all for your input! This is a deeper problem than I first thought...sorry for the delayed response, but I hope a solution can be found, even though the current ICU breakiterator is not at 100% for Khmer. Here are some new ideas, ordered by desirability, with number one bei

[PATCH] String to OUString in basctl

2012-09-26 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/706 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/06/706/1 String to OUString in basctl Change-Id: I52ce4fcf4b02746df898c7fbbf57a58b274dd0b2 --- M basctl/source/basicide/bas

[Libreoffice-commits] .: Branch 'feature/calc-xml-source' - sc/AllLangResTarget_sc.mk sc/source

2012-09-26 Thread Libreoffice Gerrit user
sc/AllLangResTarget_sc.mk |1 + sc/source/ui/src/xmlsourcedlg.src |2 +- sc/source/ui/xmlsource/xmlsourcedlg.cxx |5 - 3 files changed, 6 insertions(+), 2 deletions(-) New commits: commit 75b006b9cb7828ed628efcae759405b3daf4ab05 Author: Kohei Yoshida Date: W

[Libreoffice-commits] .: Branch 'feature/calc-xml-source' - sc/source

2012-09-26 Thread Libreoffice Gerrit user
sc/source/ui/src/xmlsourcedlg.src | 19 +++ 1 file changed, 19 insertions(+) New commits: commit 558e9b49d0e7bdbf90524a7d72326325a46d849a Author: Kohei Yoshida Date: Wed Sep 26 21:06:00 2012 -0400 I forgot to add this. Change-Id: Idf3600f0194326365e90fbf683cd213

[PATCH] ::rtl::OUString cleanup in basctl

2012-09-26 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/705 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/05/705/1 ::rtl::OUString cleanup in basctl Change-Id: Icb6f04d6ad22f1652abbb399beb08645daf8b9c9 --- M avmedia/source/gstrea

[Libreoffice-commits] .: Branch 'feature/calc-xml-source' - 2 commits - sc/inc sc/source

2012-09-26 Thread Libreoffice Gerrit user
sc/inc/sc.hrc |1 + sc/inc/scabstdlg.hxx|8 sc/source/ui/attrdlg/scdlgfact.cxx | 12 ++-- sc/source/ui/attrdlg/scdlgfact.hxx | 10 ++ sc/source/ui/inc/xmlsourcedlg.hrc |3 ++- sc/source/ui/inc/xm

[REVIEW-3-6] fix for fdo#55022, crash when opening the test file in ScDBQueryDataIterator

2012-09-26 Thread Markus Mohrhard
Hey, [1] fixes a crash when opening the test file. The problem is that we dereference a past the end element. The code was always wrong but we fixed another bug in this part of the code for 3-6 so that it now crashes. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=7

[Libreoffice-commits] .: Branch 'feature/calc-xml-source' - sc/Library_scui.mk sc/source

2012-09-26 Thread Libreoffice Gerrit user
sc/Library_scui.mk |1 + sc/source/ui/inc/xmlsourcedlg.hrc | 14 ++ sc/source/ui/inc/xmlsourcedlg.hxx | 19 +++ sc/source/ui/xmlsource/xmlsourcedlg.cxx | 13 + 4 files changed, 47 insertions(+) New commits: commit

[Libreoffice-commits] .: Branch 'feature/calc-xml-source' - sc/source

2012-09-26 Thread Libreoffice Gerrit user
sc/source/ui/inc/cellsh.hxx |1 + sc/source/ui/view/cellsh1.cxx |5 + sc/source/ui/view/cellsh2.cxx |2 +- 3 files changed, 7 insertions(+), 1 deletion(-) New commits: commit dc94f80727fe18f5e00417b0f23ba09e80d14d6b Author: Kohei Yoshida Date: Wed Sep 26 17:41:01 2012 -0400

[Libreoffice-commits] .: 6 commits - solenv/bin

2012-09-26 Thread Libreoffice Gerrit user
solenv/bin/modules/installer.pm | 41 +++ solenv/bin/modules/installer/epmfile.pm | 200 +- solenv/bin/modules/installer/exiter.pm | 72 -- solenv/bin/modules/installer/scriptitems.pm | 28 ++ solenv/bin/modules/installer/worker.pm | 307 --

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - vcl/inc vcl/source

2012-09-26 Thread Libreoffice Gerrit user
vcl/inc/vcl/layout.hxx|6 ++ vcl/source/window/dialog.cxx |4 ++-- vcl/source/window/dlgctrl.cxx | 18 +- vcl/source/window/layout.cxx | 26 ++ 4 files changed, 43 insertions(+), 11 deletions(-) New commits: commit 8372d258ad499162

[Libreoffice-commits] .: Branch 'feature/calc-xml-source' - 2 commits - configure.in officecfg/registry sc/inc sc/sdi sc/source sc/uiconfig svx/inc svx/sdi

2012-09-26 Thread Libreoffice Gerrit user
configure.in |2 officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |5 sc/inc/sc.hrc | 10 sc/inc/sccommands.h |1

[PUSHED] Change in core[libreoffice-3-6]: rhbz#827695: sw: prevent crashes after incomplete print:

2012-09-26 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/699 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/699 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/inc sw/source

2012-09-26 Thread Libreoffice Gerrit user
sw/inc/printdata.hxx |2 +- sw/inc/unotxdoc.hxx |5 +++-- sw/source/core/view/printdata.cxx |5 + sw/source/ui/uno/unotxdoc.cxx | 26 ++ 4 files changed, 27 insertions(+), 11 deletions(-) New commits: commit 47014647eced4864

[PUSHED] Change in core[libreoffice-3-6]: Clean up option processing

2012-09-26 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/700 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/700 To unsubscribe, visit

[PUSHED] sal_Bool to bool conversion in accessibility

2012-09-26 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/701 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/701 To unsubscribe, visit

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - desktop/scripts desktop/source desktop/unx vcl/inc

2012-09-26 Thread Libreoffice Gerrit user
desktop/scripts/soffice.sh | 16 - desktop/source/app/app.cxx | 35 ++- desktop/source/app/cmdlineargs.cxx | 18 - desktop/source/app/cmdlineargs.hxx |6 desktop/source/app/cmdlinehelp.cxx |7 desktop/source/app/cmdlinehelp.hxx |2 deskt

[Libreoffice-commits] .: accessibility/inc accessibility/source

2012-09-26 Thread Libreoffice Gerrit user
accessibility/inc/accessibility/helper/IComboListBoxHelper.hxx | 22 - accessibility/inc/accessibility/helper/listboxhelper.hxx | 24 +- accessibility/source/standard/vclxaccessiblelist.cxx |4 - 3 files changed, 25 insertions(+), 25 deletions(-) New commi

[PUSHED] Import shadow effect properties for shapes in docx.

2012-09-26 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/702 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/702 To unsubscribe, visit

[PUSHED] DOCX image drop shadow testcase.

2012-09-26 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/704 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/704 To unsubscribe, visit

[PUSHED] Apply shadow effect to graphics when importing from docx.

2012-09-26 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/703 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/703 To unsubscribe, visit

Re: widget layout status

2012-09-26 Thread Caolán McNamara
On Wed, 2012-09-26 at 17:47 +0100, Michael Meeks wrote: > Hi Caolan, > I appreciate the goodness underneath; having said that - I think the UI > guys will prolly want to add a little more aesthetic padding in places > to the 'after' screenshots. Luckily they can do that themselves in > glade

[Libreoffice-commits] .: sw/qa

2012-09-26 Thread Libreoffice Gerrit user
sw/qa/extras/ooxmlimport/data/imgshadow.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 20 +++- 2 files changed, 19 insertions(+), 1 deletion(-) New commits: commit 63a7550931c88ce06e4ab6f258121061c1f2dcf2 Author: Eilidh McAdam Date: Wed Sep 26 18:07:31 2012 +01

[Libreoffice-commits] .: writerfilter/source

2012-09-26 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/GraphicImport.cxx | 46 ++ writerfilter/source/dmapper/PropertyIds.cxx |1 writerfilter/source/dmapper/PropertyIds.hxx |1 3 files changed, 48 insertions(+) New commits: commit e1a509f4a362d21248b439c99e3b55f4fa9ba1bd Author: Eil

[Libreoffice-commits] .: oox/inc oox/Library_oox.mk oox/source

2012-09-26 Thread Libreoffice Gerrit user
oox/Library_oox.mk|2 oox/inc/oox/drawingml/drawingmltypes.hxx |3 + oox/inc/oox/drawingml/effectproperties.hxx| 53 +++ oox/inc/oox/drawingml/effectpropertiescontext.hxx | 41 +++ oox/inc/oox/drawingml/shape

[Libreoffice-commits] .: cui/source svx/inc svx/source

2012-09-26 Thread Libreoffice Gerrit user
cui/source/inc/transfrm.hxx | 10 ++ cui/source/tabpages/transfrm.cxx | 61 ++ cui/source/tabpages/transfrm.hrc |2 - cui/source/tabpages/transfrm.src | 21 + svx/inc/svx/dialcontrol.hxx |6 +++ svx/source/dialog/dial

Re: another version of the patches

2012-09-26 Thread Kohei Yoshida
On 09/26/2012 01:06 PM, Markus Mohrhard wrote: Hey Kohei, ok, so the patches this time a bit better. I cleaned all the whitespace errors. There are no tabs anymore and the last patch converts all line endings to unix line endings. Sadly it is only possible to apply them with --ignore-whitespace

[SOLVED] Re: Master failed to compile on scp2 module

2012-09-26 Thread julien2412
Just to say that after a "git pull -r", it's compiling right now. I don't know which commit fixed the problem but it's ok. Julien -- View this message in context: http://nabble.documentfoundation.org/Master-failed-to-compile-on-scp2-module-tp4009273p4009440.html Sent from the Dev mailing list

[Libreoffice-commits] .: sc/source

2012-09-26 Thread Libreoffice Gerrit user
sc/source/core/data/dociter.cxx |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) New commits: commit 70412d0f3f7979d3d069be8121d49dbb96775cce Author: Markus Mohrhard Date: Wed Sep 26 20:01:20 2012 +0200 don't access out of bound array index, fdo#55022 Change-Id: Ica0

[ANN] LibreOffice 3.6.2 RC2 test builds available

2012-09-26 Thread Fridrich Strba
Hi *, for the upcoming new version 3.6.2, the RC2 builds now start to be available on pre-releases. This build is slated to be second release candidate build on the way towards 3.6.2, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.6_release Build

[Libreoffice-commits] .: solenv/gbuild

2012-09-26 Thread Libreoffice Gerrit user
solenv/gbuild/platform/WNT_INTEL_MSC.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 83fc0c59037fa743c3ebc58e784eef3d120ffc2e Author: Michael Stahl Date: Wed Sep 26 19:34:14 2012 +0200 solenv: revert more of 599a94827e2b3957db3abf758d48ff7b3977e2f2

[PATCH] Apply shadow effect to graphics when importing from docx.

2012-09-26 Thread Eilidh McAdam (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/703 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/03/703/1 Apply shadow effect to graphics when importing from docx. Graphical objects imported into a text document do not s

[PATCH] DOCX image drop shadow testcase.

2012-09-26 Thread Eilidh McAdam (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/704 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/04/704/1 DOCX image drop shadow testcase. Change-Id: I27fdf0abff997d31ae8814812f7af1ec15af --- A sw/qa/extras/ooxmlimpo

[PATCH] Import shadow effect properties for shapes in docx.

2012-09-26 Thread Eilidh McAdam (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/702 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/02/702/1 Import shadow effect properties for shapes in docx. Change-Id: I0cfd6b45be268d688b7389c79c5e9ad7f48eb12d --- M oox

[Libreoffice-commits] .: 2 commits - i18npool/source instsetoo_native/inc_ooohelppack instsetoo_native/inc_ooolangpack instsetoo_native/inc_openoffice instsetoo_native/inc_sdkoo instsetoo_native/inc_u

2012-09-26 Thread Libreoffice Gerrit user
i18npool/source/isolang/langid.pl |2 instsetoo_native/inc_ooohelppack/windows/msi_templates/ActionTe.idt |2 instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt |2 instsetoo_native/inc_ooohelppack/windows/msi_templates/Error.idt

Re: widget layout status

2012-09-26 Thread Michael Meeks
Hi Caolan, On Wed, 2012-09-26 at 16:42 +0100, Caolán McNamara wrote: > I've been fixing up the remaining pesky problems. e.g. re-doing the > printer dialog and sorting out the painfully opaque tab-through-controls > logic in the light of intermediate layout widgets and I'm fairly happy > with how

Re: Regarding PDF Export

2012-09-26 Thread Michael Meeks
Hi Sagar, On Wed, 2012-09-26 at 13:19 +0300, Sagar Srivastava wrote: > Greetings of the day !!! Greetings. It would really help to have a 'git diff' / patch to show where you're at. > mpaParent( < What value should be passed here, in order to access the > following, as It crashes with 0

Re: uninitialized member warnings ?

2012-09-26 Thread Stephan Bergmann
On 09/26/2012 03:16 PM, Michael Meeks wrote: There is no way for the compiler to decide this in general (unlike Java, C++ does not have restricting rules to allow the compiler to do so). no way ? Note that I wrote "in general." Stephan ___

[PATCH] sal_Bool to bool conversion in accessibility

2012-09-26 Thread Ricardo Montania (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/701 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/01/701/1 sal_Bool to bool conversion in accessibility Change-Id: I79967eea535dc4bd11e725dc854ae8a8f97a2905 --- M accessibil

[Libreoffice-commits] .: 2 commits - solenv/gbuild

2012-09-26 Thread Libreoffice Gerrit user
solenv/gbuild/InstallModuleTarget.mk |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 8d08ebb6c639cb419c97ae745ce626eee1bd4601 Author: David Tardon Date: Wed Sep 26 18:03:33 2012 +0200 drop 'private' from variable defs. Apparently make 3.81 is

Re: widget layout status

2012-09-26 Thread Tomaž Vajngerl
On Wed, Sep 26, 2012 at 5:42 PM, Caolán McNamara wrote: > I've been fixing up the remaining pesky problems. e.g. re-doing the > printer dialog and sorting out the painfully opaque tab-through-controls > logic in the light of intermediate layout widgets and I'm fairly happy > with how things are sh

Re: ww8export tinderbox failure ?

2012-09-26 Thread Caolán McNamara
On Wed, 2012-09-26 at 17:30 +0200, Lubos Lunak wrote: > On Wednesday 26 of September 2012, Miklos Vajna wrote: > > Getting a backtrace with symbols would indeed help, I guess. > > Didn't help me. IIRC the crash is because a component somewhere is not > loaded, leading to a NULL pointer dereferen

widget layout status

2012-09-26 Thread Caolán McNamara
I've been fixing up the remaining pesky problems. e.g. re-doing the printer dialog and sorting out the painfully opaque tab-through-controls logic in the light of intermediate layout widgets and I'm fairly happy with how things are shaping up. So, here's a little documentation and some screenshots

Re: ww8export tinderbox failure ?

2012-09-26 Thread Lubos Lunak
On Wednesday 26 of September 2012, Miklos Vajna wrote: > On Tue, Sep 25, 2012 at 12:16:25PM +0100, Caolán McNamara wrote: > > The continual crash on the ww8 export on two of the Linux tinderboxes, > > what's up with that ? I think llunak mentioned he was able to reproduce > > it sometimes ? > > >

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - helpcontent2/helpers helpcontent2/source

2012-09-26 Thread Libreoffice Gerrit user
helpcontent2/helpers/help_hid.lst |3 --- helpcontent2/source/text/shared/01/0410.xhp | 15 +++ 2 files changed, 7 insertions(+), 11 deletions(-) New commits: commit 96a77e33c6352323801c073c0af2402f1e3601b6 Author: Caolán McNamara Date: Wed Sep 26 16:22:58

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - 3 commits - cui/AllLangResTarget_cui.mk cui/source cui/uiconfig cui/UI_cui.mk svx/inc svx/source vcl/inc vcl/source

2012-09-26 Thread Libreoffice Gerrit user
cui/AllLangResTarget_cui.mk |1 cui/UI_cui.mk|1 cui/source/dialogs/charmap.hrc | 41 - cui/source/dialogs/charmap.src | 131 cui/source/dialogs/cuicharmap.cxx| 199 cui/source/factory/dlgf

[REVIEW 3-6] Fix autofilter crasher on OS X

2012-09-26 Thread Kohei Yoshida
Hi, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f373a002df2f083109bb7b2e0987258b6e2f9c4 backported to 3-6, and I would be willing to sign off. The problem is that this is a Mac specific code, and I can't verify this. Could someone with OS X please verify and ch

[Libreoffice-commits] .: bridges/source

2012-09-26 Thread Libreoffice Gerrit user
bridges/source/cpp_uno/gcc3_linux_intel/callvirtualmethod.cxx |2 ++ 1 file changed, 2 insertions(+) New commits: commit dccddcc20b0b873ca182983506d97b500edfe4f1 Author: Luboš Luňák Date: Wed Sep 26 16:55:37 2012 +0200 make gcc-uno bridge work with both gcc-4.7 and clang I

Re: Windows installer fails (on master)

2012-09-26 Thread Kohei Yoshida
On 09/26/2012 09:21 AM, Andras Timar wrote: 2012/9/26 Kohei Yoshida : Hi there, This is just FYI that the Windows installer from the latest master (as of yesterday) currently fails. Here is what I get: http://people.freedesktop.org/~kohei/win7-master-installer-fail.png https://bugs.freedeskt

[Libreoffice-commits] .: solenv/gbuild

2012-09-26 Thread Libreoffice Gerrit user
solenv/gbuild/platform/ANDROID_ARM_GCC.mk| 71 solenv/gbuild/platform/ANDROID_GODSON_GCC.mk | 71 solenv/gbuild/platform/ANDROID_INTEL_GCC.mk | 71 solenv/gbuild/platform/android.mk| 79

[Libreoffice-commits] .: sw/qa

2012-09-26 Thread Libreoffice Gerrit user
sw/qa/extras/inc/bordertest.hxx |8 +++- sw/qa/extras/odfexport/odfexport.cxx |2 -- sw/qa/extras/odfimport/odfimport.cxx |8 +++- sw/qa/extras/ooxmlexport/ooxmlexport.cxx |2 -- sw/qa/extras/ooxmlimport/ooxmlimport.cxx |2 -- sw/qa/extras/rtfexport/rtf

Re: [PATCH] fdo#43497 Editing the first or last name clears initials.

2012-09-26 Thread Noel Power
Hi Chris On 22/09/12 17:47, Christopher Copits (via Code Review) wrote: Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/673 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/73/673/1 fdo#43497 Editing the first or last nam

Re: uninitialized member warnings ?

2012-09-26 Thread Lubos Lunak
On Wednesday 26 of September 2012, Michael Meeks wrote: > On Tue, 2012-09-25 at 14:26 +0200, Stephan Bergmann wrote: > > > Neato :-) the deeper question - as to why no warnings are popping out > > > of the compiler for this when (surely) it's a trivial thing to check / > > > warn for - is more co

[Libreoffice-commits] .: 2 commits - solenv/gbuild

2012-09-26 Thread Libreoffice Gerrit user
solenv/gbuild/Helper.mk |6 ++ solenv/gbuild/Library.mk |1 + solenv/gbuild/StaticLibrary.mk |1 + solenv/gbuild/TargetLocations.mk |8 solenv/gbuild/gbuild.mk |4 ++-- 5 files changed, 14 insertions(+), 6 deletions(-) New commits: comm

Re: [PUSHED] Easyhack 50089

2012-09-26 Thread Miklos Vajna
Hi Douglas, On Mon, Sep 17, 2012 at 08:10:04AM +, "Miklos Vajna (via Code Review)" wrote: > Thank you for your patch! :-) It has been merged to LibreOffice. It turns out we have no license statement from you, could you send a mail, containing "All my current and past contributions made to

Re: Windows installer fails (on master)

2012-09-26 Thread Andras Timar
2012/9/26 Kohei Yoshida : > Hi there, > > This is just FYI that the Windows installer from the latest master (as > of yesterday) currently fails. Here is what I get: > > http://people.freedesktop.org/~kohei/win7-master-installer-fail.png https://bugs.freedesktop.org/show_bug.cgi?id=55290 Andras _

Windows installer fails (on master)

2012-09-26 Thread Kohei Yoshida
Hi there, This is just FYI that the Windows installer from the latest master (as of yesterday) currently fails. Here is what I get: http://people.freedesktop.org/~kohei/win7-master-installer-fail.png I'm not very familiar with the Windows installer implementation, so I'm hoping someone who is mo

Re: uninitialized member warnings ?

2012-09-26 Thread Michael Meeks
On Tue, 2012-09-25 at 14:26 +0200, Stephan Bergmann wrote: > > Neato :-) the deeper question - as to why no warnings are popping out > > of the compiler for this when (surely) it's a trivial thing to check / > > warn for - is more concerning. > > Such a warning option has never been there AFAI

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - 2 commits - cui/source vcl/source

2012-09-26 Thread Libreoffice Gerrit user
cui/source/dialogs/cuicharmap.cxx | 126 +- cui/source/inc/cuicharmap.hxx | 20 +- vcl/source/window/window.cxx |3 3 files changed, 66 insertions(+), 83 deletions(-) New commits: commit d88f5cda87f15803630052fdf07516a16eb88051 Author: Caol

Re: dbghelp.dll fails on rebase (on Windows)

2012-09-26 Thread Kohei Yoshida
Hi Tor, On Wed, Sep 26, 2012 at 4:00 AM, Tor Lillqvist wrote: > Again, I wonder how essential / useful this whole rebasing thing is > any more in this day... But yeah, I know that suggesting we stop doing > it will bring up arguments that essentially say "if it might be useful > for even one perc

[Libreoffice-commits] .: vcl/aqua

2012-09-26 Thread Libreoffice Gerrit user
vcl/aqua/source/a11y/aqua11ywrapper.mm |4 1 file changed, 4 insertions(+) New commits: commit 3376f682a77c16f4da63dc14c45d294425e5ba8a Author: Tor Lillqvist Date: Wed Sep 26 16:01:09 2012 +0300 Silly workaround for fdo#55156 I feel dirty now. Change-Id: I1cafb0

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 54827, which changed state. Bug 54827 Summary: FILEOPEN: File open from NTFS Filesystem- crashes Write -version 3.6 ,3..6.1 https://bugs.freedesktop.org/show_bug.cgi?id=54827 What|Removed

Re: [PUSHED-3-6] adjustment of Calc default options dialog

2012-09-26 Thread Michael Meeks
On Sat, 2012-08-25 at 14:49 +0200, Jean-Baptiste Faure wrote: > Le 25/08/2012 12:44, Arnaud Versini a écrit : > > Pushed in master, thanks for the patch. > Thank you Arnaud. > > Is this patch a good candidate for a backport to 3.6 ? Just for the record, I see Kohei committed it some whil

[Libreoffice-commits] .: vcl/source

2012-09-26 Thread Libreoffice Gerrit user
vcl/source/app/settings.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 171e4298422f91c47d6ce71599e86376083ea3aa Author: Michael Stahl Date: Wed Sep 26 13:49:08 2012 +0200 MiscSettings::SetEnableATToolSupport: adapt WNT code to bool Change-Id: I21

Re: [PUSHED] sal_Bool to bool conversions

2012-09-26 Thread Stephan Bergmann
On 09/26/2012 12:21 PM, Noel Power wrote: On 26/09/12 11:11, Noel Power wrote: On 25/09/12 13:48, Noel Grandin wrote: These patches do some sal_Bool to bool conversions. One of the patches drops 2 unused sal_Bool fields. They have passed a full make check. the looked ok to me, will push all (

[Libreoffice-commits] .: configure.in

2012-09-26 Thread Libreoffice Gerrit user
configure.in | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) New commits: commit bacc9ed75e4e290ed0909445dfd8ec1e659fde97 Author: Michael Stahl Date: Wed Sep 26 13:29:24 2012 +0200 configure.in: remove obsolete --with-mozilla-version... ...and bitrotted c

[Libreoffice-commits] .: 3 commits - configure.in idlc/inc idlc/source

2012-09-26 Thread Libreoffice Gerrit user
configure.in| 28 idlc/inc/idlc/astexpression.hxx |2 +- idlc/source/astexpression.cxx | 24 idlc/source/parser.y|2 +- 4 files changed, 14 insertions(+), 42 deletions(-) New commits: commit a8bb6d

[Libreoffice-commits] .: 3 commits - afms/Zip_fontunxafm.mk cairo/prj configure.in gdk-pixbuf/prj solenv/gbuild

2012-09-26 Thread Libreoffice Gerrit user
afms/Zip_fontunxafm.mk |4 cairo/prj/build.lst |2 +- configure.in|1 + gdk-pixbuf/prj/build.lst|2 +- solenv/gbuild/LinkTarget.mk |4 ++-- 5 files changed, 9 insertions(+), 4 deletions(-) New commits: commit 4f07689050ffdffb473daa7217728a

[PATCH] Change in core[libreoffice-3-6]: Clean up option processing

2012-09-26 Thread Stephan Bergmann (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/700 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/00/700/1 Clean up option processing * Support --version on non-UNX, too. * Consistently show the first unknown option and

Re: License Statement!

2012-09-26 Thread Michael Meeks
Hi Lennard, On Wed, 2012-09-26 at 12:52 +0200, Lennard Wasserthal wrote: > I HAD put such a blanket statement in the commit message of my bug fix > (gerrit) submission. My mistake. Thanks for the blanket statement - it makes my life easier not to have to correlate and check one statement

[PATCH] Change in core[libreoffice-3-6]: rhbz#827695: sw: prevent crashes after incomplete print:

2012-09-26 Thread Michael Stahl (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/699 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/99/699/1 rhbz#827695: sw: prevent crashes after incomplete print: If the last page is not printed for whatever reason, then

Re: [PUSHED][REVIEW 3-6] Proper placements of complex categories (fdo#55298)

2012-09-26 Thread Noel Power
On 25/09/12 01:59, Kohei Yoshida wrote: Hi there, Here is another request for backport related to chart. I'd like http://cgit.freedesktop.org/libreoffice/core/commit/?id=8baaff5c798984b0fa7fe7a764491ca27765623e backported to 3-6 to fix https://bugs.freedesktop.org/show_bug.cgi?id=55298 O

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - chart2/source

2012-09-26 Thread Libreoffice Gerrit user
chart2/source/tools/ExplicitCategoriesProvider.cxx | 12 1 file changed, 8 insertions(+), 4 deletions(-) New commits: commit f665c41f2dfeedeee34f2a7024432083ed809a18 Author: Kohei Yoshida Date: Mon Sep 24 16:09:10 2012 -0400 fdo#55298: We should only treat empty values as c

[Libreoffice-commits] .: 4 commits - sal/rtl solenv/gbuild svtools/source sw/inc sw/source

2012-09-26 Thread Libreoffice Gerrit user
sal/rtl/source/uri.cxx | 34 ++-- solenv/gbuild/platform/WNT_INTEL_MSC.mk |1 svtools/source/misc/transfer.cxx|2 - sw/inc/printdata.hxx|2 - sw/inc/unotxdoc.hxx |5 ++-- sw/source/core/

[Libreoffice-commits] .: tail_build/prj

2012-09-26 Thread Libreoffice Gerrit user
tail_build/prj/build.lst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit bc12497e360a150cb41d108b53d4f4be31758779 Author: Matúš Kukan Date: Wed Sep 26 12:52:19 2012 +0200 tail_build: forgot to remove xsltml dependency Change-Id: Ia832b5474204e5c5a40

Re: [PUSHED] [REVIEW 3-6] Fix for fdo#55297 - chart complex category regression

2012-09-26 Thread Noel Power
On 25/09/12 01:53, Kohei Yoshida wrote: Hi, I'd like http://cgit.freedesktop.org/libreoffice/core/commit/?id=b174048ebd041175efd121751fddfb053d476c80 backported to 3-6 in order to fix https://bugs.freedesktop.org/show_bug.cgi?id=55297 which is a regression against 3.5. pushed Noel _

[Libreoffice-commits] .: Branch 'libreoffice-3-6' - chart2/source

2012-09-26 Thread Libreoffice Gerrit user
chart2/source/view/axes/VCartesianAxis.cxx | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) New commits: commit 0a01bd496037bb34f90b7baf9d7bd8a46eea762f Author: Kohei Yoshida Date: Mon Sep 24 15:29:01 2012 -0400 fdo#55297: Fix regression in chart complex category p

[Libreoffice-commits] .: vcl/aqua

2012-09-26 Thread Libreoffice Gerrit user
vcl/aqua/source/a11y/aqua11yfocustracker.cxx | 15 ++- vcl/aqua/source/a11y/aqua11ywrapper.mm |7 ++- 2 files changed, 20 insertions(+), 2 deletions(-) New commits: commit 5f373a002df2f083109bb7b2e0987258b6e2f9c4 Author: Tor Lillqvist Date: Wed Sep 26 13:42:54 2012

License Statement!

2012-09-26 Thread Lennard Wasserthal
I HAD put such a blanket statement in the commit message of my bug fix (gerrit) submission. But, since I did it wrongly before, here again: All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license - Lennard Wasserthal Greetings - Lennard Wasse

Re: [PARTIALLY-PUSHED][PATCH] sal_Bool to bool conversions

2012-09-26 Thread Noel Power
On 26/09/12 11:11, Noel Power wrote: On 25/09/12 13:48, Noel Grandin wrote: Hi These patches do some sal_Bool to bool conversions. One of the patches drops 2 unused sal_Bool fields. They have passed a full make check. the looked ok to me, will push all (waiting for build to complete) except 0

[Libreoffice-commits] .: 7 commits - desktop/source i18npool/inc i18npool/source oox/inc oox/source padmin/source sax/source sdext/source vcl/inc vcl/source xmlhelp/source

2012-09-26 Thread Libreoffice Gerrit user
desktop/source/app/app.cxx|2 - i18npool/inc/numberformatcode.hxx |2 - i18npool/source/numberformatcode/numberformatcode.cxx |6 ++--- oox/inc/oox/drawingml/textspacing.hxx |6 ++--- oox/source/drawingml/textspacingco

[Libreoffice-commits] .: solenv/gbuild

2012-09-26 Thread Libreoffice Gerrit user
solenv/gbuild/AllLangZip.mk |3 +++ solenv/gbuild/CliAssembly.mk |9 + solenv/gbuild/CliLibrary.mk |6 ++ solenv/gbuild/CliNativeLibrary.mk|6 ++ solenv/gbuild/CliUnoApi.mk |6 ++ solenv/gbuild/ComponentTarget.mk |

Re: commit message cites wrong bug

2012-09-26 Thread Michael Meeks
Hi Terrence, On Tue, 2012-09-25 at 07:59 -0700, Terrence Enger wrote: > http://nabble.documentfoundation.org/commit-message-cites-wrong-bug-tp4009211.html Oddly I didn't get the bulk of your mail. Commit messages are a permanent part of our commit history and simply cannot be mod

Re: [PATCH] sal_Bool to bool conversions

2012-09-26 Thread Noel Power
On 25/09/12 13:48, Noel Grandin wrote: Hi These patches do some sal_Bool to bool conversions. One of the patches drops 2 unused sal_Bool fields. They have passed a full make check. the looked ok to me, will push all (waiting for build to complete) except 0004-sal_Bool-bool.patch which makes ch

[Libreoffice-commits] .: sw/qa

2012-09-26 Thread Libreoffice Gerrit user
sw/qa/extras/ooxmlimport/data/n780843.docx |binary sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 23 +++ 2 files changed, 23 insertions(+) New commits: commit 601fd489995e9fd422d8c0fd47d8433413f95eaf Author: Miklos Vajna Date: Wed Sep 26 11:51:47 2012 +0200 n#780843

[PUSHED] sal_Bool to bool and some rtl::OUStrings in avmedia

2012-09-26 Thread Noel Power (via Code Review)
Hi, Thank you for your patch! :-) It has been merged to LibreOffice. If you are interested in details, please visit https://gerrit.libreoffice.org/697 Approvals: Noel Power: Verified; Looks good to me, approved -- To view, visit https://gerrit.libreoffice.org/697 To unsubscribe, visit

[Libreoffice-commits] .: avmedia/inc avmedia/source

2012-09-26 Thread Libreoffice Gerrit user
avmedia/inc/avmedia/mediaitem.hxx|8 avmedia/source/framework/mediaitem.cxx | 12 ++-- avmedia/source/gstreamer/gstframegrabber.cxx | 10 +- avmedia/source/gstreamer/gstframegrabber.hxx | 10 +- avmedia/source/win/player.hxx

[Libreoffice-commits] .: sc/qa sc/source

2012-09-26 Thread Libreoffice Gerrit user
sc/qa/unit/data/xlsx/formats.xlsx|binary sc/qa/unit/subsequent_filters-test.cxx |2 -- sc/source/filter/inc/numberformatsbuffer.hxx |3 ++- sc/source/filter/inc/stylesbuffer.hxx|1 + sc/source/filter/oox/numberformatsbuffer.cxx |6 ++ sc/source/filter

[Libreoffice-commits] .: writerfilter/source

2012-09-26 Thread Libreoffice Gerrit user
writerfilter/source/dmapper/PropertyMap.cxx | 29 1 file changed, 29 insertions(+) New commits: commit 211916f86585cb4f6258eb30e0474e4c21cd37f1 Author: Miklos Vajna Date: Wed Sep 26 11:14:04 2012 +0200 n#780843 fix docx import of cont section's header/footer

[Libreoffice-commits] .: desktop/scripts desktop/source desktop/unx vcl/inc

2012-09-26 Thread Libreoffice Gerrit user
desktop/scripts/soffice.sh | 16 - desktop/source/app/app.cxx | 35 ++- desktop/source/app/cmdlineargs.cxx | 18 - desktop/source/app/cmdlineargs.hxx |6 desktop/source/app/cmdlinehelp.cxx |7 desktop/source/app/cmdlinehelp.hxx |2 deskt

Re: LO 3.6.2 : about Manage dialog from Conditional Formatting

2012-09-26 Thread Tomaž Vajngerl
On Tue, Sep 25, 2012 at 6:58 AM, Jean-Baptiste Faure wrote: > If nothing is possible, I think the better thing to do is to remove the > button Edit from the Manage dialog. I think this is the best thing to do in this case - there is even a bug because of this edit button. If you click edit -> rem

[Libreoffice-commits] .: Branch 'feature/cmclayouttrans' - helpcontent2/helpers helpcontent2/source

2012-09-26 Thread Libreoffice Gerrit user
helpcontent2/helpers/help_hid.lst| 23 --- helpcontent2/source/text/swriter/01/0610.xhp | 72 +++ 2 files changed, 36 insertions(+), 59 deletions(-) New commits: commit 3e08253f0cae98c2f71a3328f247c251dbd1b3ac Author: Caolán McNamara Date: Wed S

Re: LO 3.6.2 : about Manage dialog from Conditional Formatting

2012-09-26 Thread Michael Meeks
Hi there, On Wed, 2012-09-26 at 06:35 +0200, Jean-Baptiste Faure wrote: > Nobody interested to test and answer? Sigh - people are busy; in particular Markus - whose baby this is has just put in a great chunk of bug-fixing work for 3.6.2 / 3.6.3 to improve lots of conditional formatting co

  1   2   >