[Libreoffice-commits] .: sc/source

2012-09-15 Thread Libreoffice Gerrit user
sc/source/core/data/table2.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 78e35a68b23830debc574431c18f1b7637a513c8 Author: Markus Mohrhard Date: Sun Sep 16 04:06:37 2012 +0200 only delete cond formats when attributes are deleted, fdo#54748 Chan

[PATCH] checksize.pl chokes on empty files created by __debug_instal...

2012-09-15 Thread Christian Lohmaier (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/630 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/30/630/1 checksize.pl chokes on empty files created by __debug_install_post… …that is /usr/lib/rpm/mageia/find-debuginfo.sh

sal/config.g sal/types.h and sal/osl/rtl includes in general

2012-09-15 Thread Norbert Thiebaud
Stephan, in commit e9689e4fdcf876e7bcaf564e060a3512e0fe9ef3 you said: Revert "saldllapi.h is really not included outside of sal itself" This reverts commit 2dfe34ce0efef6ec0412130a32f755657710363d: * "not every header needs to include sal/types.h" * sal/config.h is the header to always include

[Libreoffice-commits] .: sd/qa

2012-09-15 Thread Libreoffice Gerrit user
sd/qa/unit/regression-test.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 7389140c1a7a2f5b370f0a54f460c70b6fa55261 Author: Julien Nabet Date: Sun Sep 16 00:48:05 2012 +0200 Prefer prefix ++/-- operators for non-primitive types Change-Id: I4028296

[Libreoffice-commits] .: sd/source

2012-09-15 Thread Libreoffice Gerrit user
sd/source/ui/remotecontrol/Server.cxx |8 1 file changed, 4 insertions(+), 4 deletions(-) New commits: commit 1e088494853ee93ded3fcefab23052fb7f07f620 Author: Julien Nabet Date: Sun Sep 16 00:46:24 2012 +0200 Prefer prefix ++/-- operators for non-primitive type Chang

[Libreoffice-commits] .: 3 commits - sal/inc sal/osl sal/Package_inc.mk sal/textenc solenv/gbuild solenv/inc

2012-09-15 Thread Libreoffice Gerrit user
sal/Package_inc.mk |1 + sal/inc/osl/conditn.h|5 - sal/inc/osl/detail/file.h|4 sal/inc/osl/diagnose.h |5 +++-- sal/inc/osl/diagnose.hxx |

Re: Cppcheck Dangerous iterator usage after erase()-method

2012-09-15 Thread julien2412
Thank you Markus. I commited and pushed on master. (see https://gerrit.libreoffice.org/gitweb?p=core.git;a=commitdiff;h=0d40167cec11faee1488397fa323ae4511ac2050) It seems to be only on master so no need to cherry-pick for other branches. Julien -- View this message in context: http://nabble.d

[Libreoffice-commits] .: sw/source

2012-09-15 Thread Libreoffice Gerrit user
sw/source/core/text/blink.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 0d40167cec11faee1488397fa323ae4511ac2050 Author: Julien Nabet Date: Sat Sep 15 21:19:26 2012 +0200 Fix iterator management Thank you Markus for your feedback Change

Re: Cppcheck Dangerous iterator usage after erase()-method

2012-09-15 Thread Markus Mohrhard
Hey, > > Here are the lines: > 178 void SwBlink::FrmDelete( const SwRootFrm* pRoot ) > 179 { > 180 for( SwBlinkList::iterator it = aList.begin(); it != > aList.end(); ) > 181 { > 182 if( pRoot == (*it).GetRootFrm() ) > 183 aList.erase( it ); >

[Libreoffice-commits] .: ucb/source

2012-09-15 Thread Libreoffice Gerrit user
ucb/source/ucp/odma/odma_content.cxx |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) New commits: commit 084d40d601e407fde2cba7458ea29665052c4a55 Author: Michael Meeks Date: Sat Sep 15 19:51:09 2012 +0100 fix odma plugin for new ucbhelper API Change-Id: I40c58967a

[PATCH] Easyhack 50089

2012-09-15 Thread Douglas Rodrigues de Almeida (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/629 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/29/629/1 Easyhack 50089 UI accelerator keys missing in sections Table Design and Slide Transition of task pane. I chose c

Cppcheck Dangerous iterator usage after erase()-method

2012-09-15 Thread julien2412
Hello, Cppcheck reported this: [sw/source/core/text/blink.cxx:183]: (error) Dangerous iterator usage after erase()-method. Here are the lines: 178 void SwBlink::FrmDelete( const SwRootFrm* pRoot ) 179 { 180 for( SwBlinkList::iterator it = aList.begin(); it != aList.end(); ) 18

Attention Committers with feature/branches. Make sure you don't lose important work

2012-09-15 Thread Norbert Thiebaud
Dear Committers, As you know we switched our 'primary' git repo from Freedesktop to gerrit. Now freedesktop is a read only replicate of the repos hosted in gerrit. But this is still not a full replication because there exist feature/branch on freedesktop that are not known to gerrit. Right know t

Re: Re: How to change Calc default to NOT add 1 when drag-copying a cell

2012-09-15 Thread Markus Mohrhard
This mailing list is for discussions around Libreoffice development and hacking Libreoffice source code. User questions please to the users or discuss mailing list. 2012/9/15 Roger Davis : > Anything that will allow me to set the drag copy to NOT add 1 to the copied > cell... > > On 09/15/12, Luuk

Re: Re: How to change Calc default to NOT add 1 when drag-copying a cell

2012-09-15 Thread Roger Davis
Anything that will allow me to set the drag copy to NOT add 1 to the copied cell...   On 09/15/12, Luuk-3 [via Document Foundation Mail Archive] wrote:   On 15-09-2012 02:18, Roger Davis wrote: > should have it.  In my understanding, Libre Office shoul

[Bug 54157] LibreOffice 3.7 most annoying bugs

2012-09-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Arnaud Versini changed: What|Removed |Added Depends on||54744 --- Comment #9 from Arnaud Versin

Re: build failure after libcmis update

2012-09-15 Thread Christian Lohmaier
Hi David, *, On Fri, Sep 14, 2012 at 5:19 PM, David Tardon wrote: > [… I propose to add --touch to tar options, so the files are > extracted with modification times set to extraction time. According to > tar's changelog, this option exists since 1995, so it should be > supported on all our platfo

[Libreoffice-commits] .: 5 commits - accessibility/source chart2/source comphelper/source lotuswordpro/source sal/qa

2012-09-15 Thread Libreoffice Gerrit user
accessibility/source/extended/accessibleiconchoicectrl.cxx | 23 -- accessibility/source/extended/accessiblelistbox.cxx | 22 - accessibility/source/extended/accessiblelistboxentry.cxx| 10 +--- chart2/source/con

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-09-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 35079, which changed state. Bug 35079 Summary: EDITING: Drawing element completely in mouse selection frame not selected https://bugs.freedesktop.org/show_bug.cgi?id=35079 What|Old Value

[Bug 44446] LibreOffice 3.6 most annoying bugs

2012-09-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=6 Michel Rudelle changed: What|Removed |Added Depends on||54621 --- Comment #120 from Michel Rude

[PATCH] fdo#54858: fix UNO service conversion

2012-09-15 Thread Ivan Timofeev (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/628 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/28/628/1 fdo#54858: fix UNO service conversion regression from 197a79e57131c976a489882479a679ba2ab61b82 Change-Id: I3fbba4

[Bug 54157] LibreOffice 3.7 most annoying bugs

2012-09-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=54157 Roman Eisele changed: What|Removed |Added Depends on||54858 --- Comment #8 from Roman Eisele 2

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-09-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #380 from Roman Eisele 2012-09-15 08:32:04 UTC --- For the record: Lionel Elie Mamane has added * Bug 54930 - “EDITING Report builder: mouse-resize control allows to move top of control to out of section” * Bug 54933 - “EDITING Repo

[Libreoffice-commits] .: UnoControls/source

2012-09-15 Thread Libreoffice Gerrit user
UnoControls/source/controls/progressmonitor.cxx |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) New commits: commit f5beefb2eaf4bc513aebdc11355890dff3f040fa Author: Julien Nabet Date: Sat Sep 15 10:29:37 2012 +0200 Fix some "Variables reassigned a value before the old one

Re: How to change Calc default to NOT add 1 when drag-copying a cell

2012-09-15 Thread Luuk
On 15-09-2012 02:18, Roger Davis wrote: should have it. In my understanding, Libre Office should mirror or excel (pun intended) the Microsquish effort, so as to be fully compatible. Thanks! Can a setting 'try NOT mirror Excel, but let LO behave better than Excel' be added tooo ? ;) ___

[PATCH] fdo#34792 - Fix for truncated field labels in Bibliography d...

2012-09-15 Thread Sagar Srivastava (via Code Review)
Hi, I have submitted a patch for review: https://gerrit.libreoffice.org/627 To pull it, you can do: git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/27/627/1 fdo#34792 - Fix for truncated field labels in Bibliography database dialog Change-Id: I256b2b0ad508faed68c9faf0df6