Cppcheck reports "Same expression on both sides of '|'" on basctl module

Hello, On master, cppcheck reported this : [basctl/source/basicide/bastypes.cxx:269] -> [basctl/source/basicide/bastypes.cxx:269]: (style) Same expression on both sides of '|'. Here are the lines : 266 BasicDockingWindow::BasicDockingWindow( Window* pParent, const ResId& rResId ) : 267

Cppcheck reports "Same expression on both sides" in writerfilter module

Hello, On master repo, cppcheck reported this : [writerfilter/source/filter/ImportFilter.cxx:227] -> [writerfilter/source/filter/ImportFilter.cxx:227]: (style) Same expression on both sides of '||' Here are the lines : 225 sal_Bool WriterFilter_supportsService( const OUString& ServiceName ) t

[ANDROID-UI-PATCH] Starting of code for menu list for potential start center.

Attached is a simple patch that starts adding code for a menu list for potentially start center, or can be adapted very easily for another purpose. >From 8b875381fb23751e12f904e72f5bfef56fe17dbc Mon Sep 17 00:00:00 2001 From: Jonathan Aquilina Date: Sat, 7 Apr 2012 22:09:14 +0200 Subject: [PATC

[REVIEW:3-5] "Redundant assignment" in oox

Hello, Cppcheck reported this : [oox/source/vml/vmlformatting.cxx:251]: (warning) Redundant assignment of "nModToken" in switch Here are the lines : 249 switch( AttributeConversion::decodeToken( aColorIndex.copy( 0, nOpenParen ) ) ) 250 { 251 cas

Re: [PATCH] Remove unused constructor for ParametricPolyPolygon.

More unused code cleanup. Perhaps the remaining 2 constructors could also be merged into one; I haven't looked into this one. (Apologies for the missing attachment.) 0001-Remove-unused-constructor-for-ParametricPolyPolygon.patch Description: Binary data _

Re: [PATCH] Kill VbaFontBase::get/setUnderline

On Sat, Apr 7, 2012 at 8:36 PM, Miklos Vajna wrote: > Hi Gábor, > > On Sat, Apr 07, 2012 at 07:30:42PM +0200, Gábor Stefanik > wrote: >> Unused code removal. > > Hm, are you sure this is right, without removing the > Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply > removing

[PATCH] Remove unused constructor for ParametricPolyPolygon.

More unused code cleanup. Perhaps the remaining 2 constructors could also be merged into one; I haven't looked into this one. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Kill VbaFontBase::get/setUnderline

Hi Gábor, On Sat, Apr 07, 2012 at 07:30:42PM +0200, Gábor Stefanik wrote: > Unused code removal. Hm, are you sure this is right, without removing the Underline attribute from oovbaapi/ooo/vba/XFontBase.idl? (But simply removing an attribute from there may break the ABI, I'm not sure.) > Signed

[PATCH] - Add UI directory with android eclipse project to the android directory

Attached find my very first patch to get the android eclipse project I have into core on master. Please note this is highly under developed and still needs integration of the rest of the Core code via the NDK. All my past present and future contributions are licensed according to the licenses

[PATCH] Kill VbaFontBase::get/setUnderline

Unused code removal. Signed-off-by: Gábor Stefanik 0001-Kill-vbaFontBase-get-setUnderline.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Build failed on cairo (Win32)

Hi, If you talk about master repository, there have been some commits recently which could help : http://cgit.freedesktop.org/libreoffice/core/commit/?id=6219ff898a8c3ae6b7abe4272b4b68cc986093e4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=e20fa170160e1bb1953ad171e092edfb3de531af I woul

[PATCH] Partial fix for Bug 30711

Hi, Attached is a patch partially fixing Bug 30711. When the user has not chosen to use OpenDocument format with extensions, text input fields are now exported in a format OOo understands. Please let me know if there are any major issues with how I am doing things before I work on addressing the