Re: extraordinary stoc/ thrash ...

2012-04-02 Thread Tor Lillqvist
>        What would be ultimately nice would be to rid ourselves of this > XRegistry 'stuff' and have a simple XML file, read into some simple > structures, and added to a couple of hashes for the common lookup > patterns we want. Or, for files that are static in a distributed LO (i.e. not modifie

Re: string / size bits ... #2 ...

2012-04-02 Thread Enrico Weigelt
Hi, > I don't want to spoil the fun much for you :) , but I expect the > number of > string allocations to go down when RTL_CONSTASCII_* stops being used > in favor > of string literals, and further down after whenever I get to > implementing the > efficient operator+. So you may be profiling a

Re: extraordinary stoc/ thrash ...

2012-04-02 Thread Enrico Weigelt
> What would be ultimately nice would be to rid ourselves of this > XRegistry 'stuff' and have a simple XML file, read into some simple > structures, and added to a couple of hashes for the common lookup > patterns we want. Is there any chance of doing that separately, so we > can sever the

[PATCH] EasyHack Bug 46610

2012-04-02 Thread Daniel Bankston [danthedev]
Hello, everyone, I have attached my patches for EasyHack Bug 46610. Here is a little more information on what I did and found out: For both versions of the Region class's Union, Intersect, Exclude, and XOr, I changed the return types from sal_Bool to void. Then I searched vcl for all callers

[Libreoffice] License statement

2012-04-02 Thread Daniel Bankston [danthedev]
Hello, everyone, I look forward to getting to know you all and contributing to LibreOffice. I provide all past, present, and future contributions to LibreOffice under the terms of the LGPLv3+ and MPL license. Respectfully, Daniel Bankston ___ LibreO

[PATCH] Some String replacements in starmath

2012-04-02 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozil

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Eike Rathke
Hi Caolán, On Monday, 2012-04-02 20:10:23 +0100, Caolán McNamara wrote: > On Mon, 2012-04-02 at 19:31 +0200, Eike Rathke wrote: > > Bah, I initially overlooked that the patch also changes the general > > char.txt, not only char_in.txt > > > > We have a problem here, as that changes behavior for

[PATCH] fdo#46390: EasyHack: Move VERBOSE to OSL_DEBUG_LEVEL

2012-04-02 Thread Rob Snelders
Hi, I have created 2 little patches. The first one is to start on the bug fdo#46390. The other patch solves also some build-errors I got when turning on the debug-mode. Also is rRequestData removed. It isn't defined in the class as far as I can see. It should be the aKey because that holds the

Re: [REVIEW] Correct errobar position when selecting standard desviation

2012-04-02 Thread Rafael Dominguez
On Mon, Apr 2, 2012 at 5:05 PM, Rafael Dominguez wrote: > This patch corrects the positioning of the errorbars when selecting a > standard desviation error type. > The current behaviour is centering the bar at the value of the standard > desviation, the expected behaviour should be centered around

Re: Need help in UNO

2012-04-02 Thread Regina Henschel
Hi Szabolcs, Dézsi Szabolcs schrieb: Hi all! I'm working on Bug 34423 (more of a feature request). There's this extension called OpenOffice Toolbox on the bug's page. It implements image rotation. I want to port that to C++. I added a menu item to the right click menu of the image (Rotate...<

[PUSHED] Re: [PATCH] Convert SV_PTRARR with std::deque

2012-04-02 Thread Michael Stahl
On 26/03/12 17:01, Kohei Yoshida wrote: > On Sat, 2012-03-24 at 23:41 +0100, Bartosz wrote: >> Hi >> >> I converted the SV PTRARR to std::deque in sw component. >> Could you please check and push this path? >> This and later contributions is licensed under MPL 1.1 / GPL v3+ / LGPL v3+. hi Bartosz,

[REVIEW] Correct errobar position when selecting standard desviation

2012-04-02 Thread Rafael Dominguez
This patch corrects the positioning of the errorbars when selecting a standard desviation error type. The current behaviour is centering the bar at the value of the standard desviation, the expected behaviour should be centered around the data point. The patch should also be cherry picked to 3.5 s

[PUSHED] Re: [PATCH] conver tools/table.hxx usage to std::set in EditorWindow class in basctl module

2012-04-02 Thread Michael Stahl
On 29/03/12 18:46, Noel Grandin wrote: > Hi > > License is on file. > > Including this patch (and the last 2 from today), there is only 1 place > in the codebase still using the tools/table.hxx class sounds good! (but probably it's used in binfilter, we can move it into binfilter repo then, so

[PUSHED] Re: [PATCH] convert tools/table.hxx to std::set in Calendar class in svtools module

2012-04-02 Thread Michael Stahl
On 29/03/12 18:16, Noel Grandin wrote: > Hi > > License is on file. > > Regards, Noel Grandin thanks, pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=e5a916d8e79a3d105040f3fb832134bf7b32 ___ LibreOffice mailing list Libre

Re: extraordinary stoc/ thrash ...

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 22:06 +0100, Michael Meeks wrote: > I'm also curious if the performance issue here (this code features > reasonably high on a startup profile IIRC) might be related to the > multiple '.rdb' file code (?). Following that line of attack, with every string allocat

Re: Need help in UNO

2012-04-02 Thread Miklos Vajna
On Mon, Apr 02, 2012 at 08:20:18PM +0200, Dézsi Szabolcs wrote: > > Not sure if you noticed that the RotationDescriptor service is > > deprecated, just in case you plan to spend too much time on it. ;) > > > Yes, I noticed it, I think I have to use Transformation (?). > > This is just a test t

extraordinary stoc/ thrash ...

2012-04-02 Thread Michael Meeks
Hi there, Digging through the string logs, trying to make sense of the extremely intense thrash around this SINGLETON/ stuff, I was curious to get rather deep stacks, cf. appended trace. AFAICS the purpose of this code is mostly to turn a pretty simple, pretty flat XML structure,

Re: intermittent flaw in gnumake deps on Win32 ..

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 22:12 +0200, Michael Stahl wrote: > Kendy told me on IRC that he has fixed the filter-showIncludes.pl on > master so that it writes to a temp file and when that is complete, moves > it over the target .d dep-file, which should hopefully prevent this kind > of problem in the f

Re: [PATCH][REVIEW] gbuild conversion: module cpputools

2012-04-02 Thread David Ostrovsky
Hi David, thank you for your comments. Here is another try. As you haven't merged feature/gbuild_components branch to master I let "gb_Executable_add_api" in place: As you suggested the next modules to convert are: idlc, l10ntools, rdbmaker, soltools, unodevtools David PS: contribution notice.

Re: [REVIEW-3-5] [PUSHED 3-5] fix for fdo#44337, margin information are not symmetric in sc

2012-04-02 Thread Kohei Yoshida
On Mon, Apr 2, 2012 at 4:21 PM, Michael Stahl wrote: > pushed [2] (but not [1] because i'll leave that to people who know sc) And I pushed [1] as well. I already talked with Markus about this, and this only removes the little hack we put in which is no longer needed. >> [1] >> http://cgit.fre

Re: [REVIEW-3-5] fix for fdo#44337, margin information are not symmetric in sc

2012-04-02 Thread Michael Stahl
On 02/04/12 19:38, Markus Mohrhard wrote: > Hey, > > [1] removes an old ugly hack for n#361358 which is no longer needed. I > checked with Kohei and the old patch was necessary for xls import but > we now use the saved row height during xls import. Without this hackw > e have again a symmetric mar

[PUSHED] Re: [REVIEW 3-5] fdo#47326 fix RTF import of mixed super/nonsuper text

2012-04-02 Thread Michael Stahl
On 30/03/12 15:05, Miklos Vajna wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=f84e0e6b1b0ec5f52ee963a62ac420cd872a771e > > Regression from 3.4, due to not handling the \nosupersub RTF keyword. > > I'm attaching a backport of the patch for -3-5 (plain cherry-pick won't > work as

Re: intermittent flaw in gnumake deps on Win32 ..

2012-04-02 Thread Michael Stahl
On 30/03/12 13:05, Matúš Kukan wrote: > On 30 March 2012 11:36, Michael Meeks wrote: >>Regina's problem comes down to a corrupt .d file. >> >>Any ideas how that could happen ? are these generated by a pipeline ? >> are we failing to delete them if a compile fails mid-flow ? > > Th

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

2012-04-02 Thread Albert Thuswaldner
Hi Markus, On Sat, Mar 31, 2012 at 18:36, Markus Mohrhard wrote: > And had to revert it immediately. We can use initializer lists because > older gcc versions don't know this feature. I got spammed by nearly > every of our tinderbox. I tried to fix them but the whole patch is > build around that

Re: [PUSHED 3-5] fdo#34324 Math icon color bug

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 21:04 +0200, Andras Timar wrote: > It works, too, I tried. Would you push it? Pushed to master and -3-5. Thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___

[PATCH] fdo#39749: calc unit test writing

2012-04-02 Thread karthik padmanabhan
Hi , I'm submitting a patch for the easy hack 39749. I have written one test that tests the RenameTable() function in ScDocFunc class Thanks and Regards Karthik 0001-Test-cases-for-ScDocFunc-RenameTable.patch Description: Binary data ___ LibreOffice m

Re: [PATCH] Translate German comments in frmcrsr.cxx

2012-04-02 Thread Philipp Weissenbacher
Here you go: 25db817c873bb7f2548d7f8d7fdc65194d306755 That really makes it a bit cleaner, will do that right away in the future. Philipp On 2 April 2012 21:24, Michael Meeks wrote: > > On Mon, 2012-04-02 at 21:08 +0200, Philipp Weissenbacher wrote: > > Pushed now. > > If s.o. still feels like

Re: [PATCH] Fix memory errors in SwWW8ImplReader

2012-04-02 Thread Caolán McNamara
On Mon, 2012-04-02 at 20:50 +0200, Lubos Lunak wrote: > Miklos has already fixed Read_UL(), but your patch lists more places. Could > you check why those places needed the change and make them read the proper > sizes according to what the .doc spec says? FWIW the sprm itself (for >= winword ver

Re: [REVIEW-3-5-2] fdo#46728

2012-04-02 Thread Eike Rathke
Hi Michael, On Monday, 2012-04-02 20:29:24 +0100, Michael Meeks wrote: > On Mon, 2012-04-02 at 20:51 +0200, Eike Rathke wrote: > > On Monday, 2012-04-02 07:21:10 +0200, Markus Mohrhard wrote: > > > > another very ugly glitch with the multibar feature, see fdo#46728 and > > > > fix > > > > http:/

Re: intermittent flaw in gnumake deps on Win32 ..

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 13:32 -0400, Kevin Hunter wrote: > :-) No worries. I am often not sure whether to say "Hi" when responding > back and forth in email discussions on a list. Is it a "formal" > interaction? A friendly interaction? An engineer's "optimal" interaction? Hopefully fr

Re: [REVIEW-3-5-2] fdo#46728

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 20:51 +0200, Eike Rathke wrote: > On Monday, 2012-04-02 07:21:10 +0200, Markus Mohrhard wrote: > > > another very ugly glitch with the multibar feature, see fdo#46728 and fix > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ae64e4b0c23f209410fe84df041c9445234df7

Re: [PATCH] Translate German comments in frmcrsr.cxx

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 21:08 +0200, Philipp Weissenbacher wrote: > Pushed now. > If s.o. still feels like taking a look. :-) it looked lovely to me. Things like: -// 8626: kein SwTxtCursor::SetRightMargin( sal_False ); -// statt dessen steht ein SwSetToRightMargin im _Uni

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Caolán McNamara
On Mon, 2012-04-02 at 19:31 +0200, Eike Rathke wrote: > Bah, I initially overlooked that the patch also changes the general > char.txt, not only char_in.txt > > We have a problem here, as that changes behavior for Thai and Lao with > existing ICU versions. Would be worth adding some sample text t

Re: [PATCH] Translate German comments in frmcrsr.cxx

2012-04-02 Thread Philipp Weissenbacher
Pushed now. If s.o. still feels like taking a look. Philipp On 28 March 2012 14:37, Philipp Weissenbacher wrote: > Hi all, > Kindly asking for a review of my translation of frmcrsr.cxx. > > Thanks i

Re: [REVIEWED 3-5] fdo#34324 Math icon color bug

2012-04-02 Thread Andras Timar
2012/4/2 Michael Meeks : > > On Mon, 2012-04-02 at 15:06 +0200, Andras Timar wrote: >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=b36a42fb831b853120928e05dcf322898a92a731 >> This commit fixes fdo#34324. Icon of LibreOffice Math was in >> grayscale, and was displayed with wrong colors (

Re:

2012-04-02 Thread Simos Xenitellis
On Mon, Apr 2, 2012 at 8:53 PM, Michel Basilieres wrote: > http://dalemarsden.com/.. > It forwards to a page at a russian website. That page is currently down. In any case, do not click on the URL. Simos ___ LibreOffice mailing list LibreOffice@l

Re: [REVIEW-3-5-2] fdo#46728

2012-04-02 Thread Eike Rathke
Hi Markus, On Monday, 2012-04-02 07:21:10 +0200, Markus Mohrhard wrote: > > another very ugly glitch with the multibar feature, see fdo#46728 and fix > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ae64e4b0c23f209410fe84df041c9445234df74 > > Looks fine. I checked it and it only affe

Re: [PUSHED] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

2012-04-02 Thread Stephan Bergmann
On 03/30/2012 05:06 PM, Noel Grandin wrote: Sending this patch to you directly because none of the normal file upload services are visible to me at the moment (one of the joys of living in South Africa). I've updated only the IDL files you listed. Pushed now as

Re: [PATCH] Fix memory errors in SwWW8ImplReader

2012-04-02 Thread Lubos Lunak
On Monday 02 of April 2012, Arnaud Versini wrote: > Hi, > > It was only to make sure we don't overread the array, and because of the > valgrind message. > > Sorry No need to be sorry, handling the .doc format is nothing trivial :). I was only curious if you did the patch based only on valgrind o

Re: [PUSHED] EasyHack, fdo#46808, Adapt UNO services to new style, Part 1

2012-04-02 Thread Stephan Bergmann
On 04/02/2012 08:48 PM, Stephan Bergmann wrote: Pushed the udkapi part now ...and marking thread as such ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Part 1

2012-04-02 Thread Stephan Bergmann
On 03/27/2012 04:42 PM, Noel Grandin wrote: Patch to update makefiles attached. Pushed the udkapi part now as (the offapi part is now covered by a redone patch). Thanks, Stephan On 2012-03-2

RE: Need help in UNO

2012-04-02 Thread Dézsi Szabolcs
> Not sure if you noticed that the RotationDescriptor service is > deprecated, just in case you plan to spend too much time on it. ;) Yes, I noticed it, I think I have to use Transformation (?). This is just a test to see if I can do it with RotateAngle (like in extension), after that I can us

Re: Need help in UNO

2012-04-02 Thread Miklos Vajna
On Mon, Apr 02, 2012 at 07:23:52PM +0200, Dézsi Szabolcs wrote: > I'm working on Bug 34423 (more of a feature request). > There's this extension called OpenOffice Toolbox on the bug's page. It > implements image rotation. I want to port that to C++. > I added a menu item to the right click menu

Re: [PATCH] Fix memory errors in SwWW8ImplReader

2012-04-02 Thread Arnaud Versini
Hi, It was only to make sure we don't overread the array, and because of the valgrind message. Sorry Le 2 avril 2012 15:04, Lubos Lunak a écrit : > On Saturday 31 of March 2012, Arnaud Versini wrote: > > Hi, > > > > This patch prevent and fix memory issue in SwWW8ImplReader. > > Did you base

[PUSHED] Re: [PATCH] Remove unused HTMLMODE_FIRSTLINE

2012-04-02 Thread Lubos Lunak
On Sunday 01 of April 2012, Harri Pitkänen wrote: > HTMLMODE_FIRSTLINE was disabled in all HTML export modes. It seems to > have been used to add first line indent for paragraphs in Netscape > version 3 but all currently available export modes use CSS for that. Patch looks good to me, pushed, tha

[no subject]

2012-04-02 Thread Michel Basilieres
http://dalemarsden.com/wordpress/wp-content/plugins/podpress/optional_files/wp1.5_2.0/wp-admin/02efpk.html";> http://dalemarsden.com/wordpress/wp-content/plugins/podpress/optional_files/wp1.5_2.0/wp-admin/02efpk.html___ LibreOffice mailing list LibreOff

[PUSHED] Re: [PATCH] Replace List with std:vector

2012-04-02 Thread Lubos Lunak
On Sunday 01 of April 2012, Rafael Dominguez wrote: > 0001-Replace-List-with-std-vector-EPPTHyperlink.patch Looks good, pushed, thank you. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fre

[REVIEW-3-5] fix for fdo#44742, xls cell border import and export use different width settings

2012-04-02 Thread Markus Mohrhard
Hey, [1] prevents that cell borders are incorrectly saved to xls after import from xls. The problem is that one of the old go-oo patches changed the defaults for xls import but did not adjust the values for xls export. I now moved the border width information into a common header file so that thes

[REVIEW-3-5] fix for fdo#44337, margin information are not symmetric in sc

2012-04-02 Thread Markus Mohrhard
Hey, [1] removes an old ugly hack for n#361358 which is no longer needed. I checked with Kohei and the old patch was necessary for xls import but we now use the saved row height during xls import. Without this hackw e have again a symmetric margin and old documents are imported correctly. [2] fix

Re: intermittent flaw in gnumake deps on Win32 ..

2012-04-02 Thread Kevin Hunter
At 1:21pm -0400 Mon, 02 Apr 2012, Regina Henschel wrote: Should be "Hi Kevin". Please excuse. :-) No worries. I am often not sure whether to say "Hi" when responding back and forth in email discussions on a list. Is it a "formal" interaction? A friendly interaction? An engineer's "optimal

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Eike Rathke
Hi Tomáš, On Monday, 2012-04-02 18:53:16 +0200, Tomáš Chvátal wrote: > I commited the patch to the master, as the distros will mostly add icu49 now > and libreoffice is the only offender that wont compile against it now please > review the patch for 3-5 branch and commit if applicable. [1] Bah

Re: build failure: sc_ucalc.test - cppunittester abort trap (core dumped)

2012-04-02 Thread Lubos Lunak
On Sunday 01 of April 2012, R Skinner wrote: > On 03/31/12 18:49, Lubos Lunak wrote: > > If you use the Clang compiler, then I somehow doubt you'll manage to > > get 3.4.5 working with that. In fact I'm even surprised the link mentions > > 3.5 as usable with Clang, since I had to do several fixes

Need help in UNO

2012-04-02 Thread Dézsi Szabolcs
Hi all! I'm working on Bug 34423 (more of a feature request). There's this extension called OpenOffice Toolbox on the bug's page. It implements image rotation. I want to port that to C++. I added a menu item to the right click menu of the image (Rotate... <- will call a dialog), now it just rot

Re: string / size bits ... #2 ...

2012-04-02 Thread Lubos Lunak
On Monday 02 of April 2012, Michael Meeks wrote: > On Fri, 2012-03-30 at 15:21 +0100, Michael Meeks wrote: > > I up-loaded the output of my string debug for a writer start: > > And discovered there was a bazillion problems with it, in particular > the handling of OUStrings, having nailed

Re: intermittent flaw in gnumake deps on Win32 ..

2012-04-02 Thread Regina Henschel
Should be "Hi Kevin". Please excuse. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: intermittent flaw in gnumake deps on Win32 ..

2012-04-02 Thread Regina Henschel
Hi Kervin, Kevin Hunter schrieb: At 7:56am -0400 Fri, 30 Mar 2012, Christian Lohmaier wrote: On Fri, Mar 30, 2012 at 1:05 PM, Matúš Kukan wrote: On 30 March 2012 11:36, Michael Meeks wrote: Regina's problem comes down to a corrupt .d file. [...] One more data-point, that file was exactly 4096

Re: build failure: sc_ucalc.test - cppunittester abort trap (core dumped)

2012-04-02 Thread R Skinner
On 03/31/12 18:49, Lubos Lunak wrote: On Saturday 31 of March 2012, Albert Thuswaldner wrote: Hi, Sorry, I'm not much of help... On Thu, Mar 29, 2012 at 13:29, R Skinner wrote: [I tried at the users list but was advised I should post here instead] Hi, I'm new here, and I'm driven here by d

Re: build failure: sc_ucalc.test - cppunittester abort trap (core dumped)

2012-04-02 Thread R Skinner
On 03/31/12 18:49, Lubos Lunak wrote: On Saturday 31 of March 2012, Albert Thuswaldner wrote: Hi, Sorry, I'm not much of help... On Thu, Mar 29, 2012 at 13:29, R Skinner wrote: [I tried at the users list but was advised I should post here instead] Hi, I'm new here, and I'm driven here by d

[PATCH] Remove unused HTMLMODE_FIRSTLINE

2012-04-02 Thread Harri Pitkänen
HTMLMODE_FIRSTLINE was disabled in all HTML export modes. It seems to have been used to add first line indent for paragraphs in Netscape version 3 but all currently available export modes use CSS for that. Harri>From 26abdf32a398dc2bfcea60e751e0a1b3edb984c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q

Re: build failure: sc_ucalc.test - cppunittester abort trap (core dumped)

2012-04-02 Thread R Skinner
On 03/31/12 15:58, Alexander Thurgood wrote: Le 29/03/12 13:29, R Skinner a écrit : Hi again, For what its worth, the build from master is currently failing for me at the same point in the sc cppunit tests on Linux 32bit Ubuntu Oneiric, despite repeated cleans and pulls from git master, so it w

Re: intermittent flaw in gnumake deps on Win32 ..

2012-04-02 Thread Kevin Hunter
At 7:56am -0400 Fri, 30 Mar 2012, Christian Lohmaier wrote: On Fri, Mar 30, 2012 at 1:05 PM, Matúš Kukan wrote: On 30 March 2012 11:36, Michael Meeks wrote: Regina's problem comes down to a corrupt .d file. [...] One more data-point, that file was exactly 4096 bytes large: Wha

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Stephan Bergmann
On 04/02/2012 05:49 PM, Markus Mohrhard wrote: 2012/4/2 Stephan Bergmann: And once these better tests offer coverage comparable to the old ones, we can finally ditch them. I would prefer an incremental process here, but that is just my opinion. I think it makes sense every time a interface is

Re: Exception specifications on functions useless?

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 11:59 +0200, Lubos Lunak wrote: > Could this be please added to the next TSC agenda ? Yep, pushed & will invite you to the meeting :-) ATB, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___

Re: [REVIEW 3-5] Re: build breaks - icu49 ?

2012-04-02 Thread Tomáš Chvátal
Ok, I commited the patch to the master, as the distros will mostly add icu49 now and libreoffice is the only offender that wont compile against it now please review the patch for 3-5 branch and commit if applicable. [1] Cheers Tom [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=0

Re: Android UI work

2012-04-02 Thread Tor Lillqvist
> Tor do you still feel like this is worth including even on a mobile device > or bypassing all together? As long as we don't have a way to *create* text/spreadsheet/presentation contents from scratch, I don't see the point in having a Start Centre in a non-desktop LO-based app. I.e. there shouldn

Re: string / size bits ... #2 ...

2012-04-02 Thread Eike Rathke
Hi Michael, On Monday, 2012-04-02 15:25:58 +0100, Michael Meeks wrote: > How we get 81k allocations of a string containing '/' is somewhat > curious ;-) My first shoot would be configuration paths ... Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer

[GSoC] Almost away for 3 weeks

2012-04-02 Thread Cedric Bosdonnat
Hi all, I'll be on paternity leave during the next three weeks starting today. For any question regarding GSoC administration, please ask Fridrich, or make sure you have the both of us in the email loop. I'll have some internet connection, so I'll be able to read my email from time to time and I'

Re: Android UI work

2012-04-02 Thread Jonathan Aquilina
Tor do you still feel like this is worth including even on a mobile device or bypassing all together? On 02/04/2012 17:57, Tor Lillqvist wrote: So the startcenter was not for when all documents are closed, but when it is launched. (hence the name) Ah. Yes of course, silly me. Good that I am no

Re: Android UI work

2012-04-02 Thread Jonathan Aquilina
On 02/04/2012 16:59, Christian Lohmaier wrote: Hi *, On Mon, Apr 2, 2012 at 4:06 PM, Tor Lillqvist wrote: so for the native Mac GUI port in OOo 3.0 the Start Centre was designed (in its fully gradiented glory) so it can be shown to those posh Mac users in the case when no document is opened.

[no subject]

2012-04-02 Thread Michel Basilieres
http://www.marketersbase.com/wp-includes/theme-compat/02efpk.html";> http://www.marketersbase.com/wp-includes/theme-compat/02efpk.html___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Re: build breaks - icu49 ?

2012-04-02 Thread Eike Rathke
Hi Tomáš, On Saturday, 2012-03-31 21:52:06 +0200, Tomáš Chvátal wrote: > Gentoo dev reporting the issue actually tried to write patch. [1] > It is backported from ICU upstream. [2] > Let me know if it is correct enough for commiting and I will do it. > > [1] http://people.apache.org/~Arfrever/li

Re: Android UI work

2012-04-02 Thread Tor Lillqvist
> So the startcenter was not for when all documents are closed, but when > it is launched. (hence the name) Ah. Yes of course, silly me. Good that I am not ashamed to admit it when I have been talking crack. --tml ___ LibreOffice mailing list LibreOffic

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||44725 --- Comment #261 from Rainer Bi

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #260 from Rainer Bielefeld 2012-04-02 08:50:00 PDT --- Add "Bug 44725 - VIEWING: Heading - Footer - Pagebreak lines appear somewhere in the page". It's harmless and acceptable for a x.x.0, but not acceptable for x.x.3 and a daunting

Re: proposed easyhack: converting c++ unit tests from JUnit to CppUnit

2012-04-02 Thread Markus Mohrhard
2012/4/2 Stephan Bergmann : > On 04/02/2012 01:29 PM, Noel Grandin wrote: >> >> So moving them to CppUnit would at least be a step in the right direction? > > > I don't think simply rewriting them from Java to C++ in their current form > is worth it.  It would be better to replace them with better

Re: Headless for everything in build? (Re: [Libreoffice-commits] .: hwpfilter/CppunitTest_hwpfilter_test_hwpfilter.mk)

2012-04-02 Thread Stephan Bergmann
On 04/02/2012 12:27 PM, Lubos Lunak wrote: I have checked that adding --headless to all cppunittests passes make check fine, and at least some tinderboxes build without any UI available, so I think it makes sense to simply use it always and not require manual addition to every single test. Comm

Re: string / size bits ... #2 ...

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 16:52 +0200, Noel Grandin wrote: > To make it easier to find culprits, perhaps you could add a feature to > your script ? Checkout sal/rtl/source/strimp.hxx and instrument the _NEW piece to your heart's content. Potentially it'd be good to out-line that into a concre

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||32948 -- Configure bugmail: https://

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-04-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on|32948 | -- Configure bugmail: https://bugs.

[REVIEWED 3-5] fdo#34324 Math icon color bug

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 15:06 +0200, Andras Timar wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=b36a42fb831b853120928e05dcf322898a92a731 > This commit fixes fdo#34324. Icon of LibreOffice Math was in > grayscale, and was displayed with wrong colors (blue instead of white) > in Qui

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

2012-04-02 Thread Stephan Bergmann
On 03/28/2012 12:26 PM, Tor Lillqvist wrote: MARKER: These services are not intended to be instantiated via their service names. How is it in general with service names, if one browses services.rdb (either of them), one doesn't have to look long to notice components that have identical service

Re: [PATCH] Make LibreOffice waterproof

2012-04-02 Thread Andrew Higginson
On 02/04/12 11:31, Michael Meeks wrote: > > On Sun, 2012-04-01 at 19:08 +0200, Jesús Corrius wrote: >> * Resistance of operative parts. Immersion in 10 cm of water with a >> force of 5 N perpendicular to the About Box for 10 minutes. > > Is that the old, or the new Andrew Higginson About Bo

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

2012-04-02 Thread Stephan Bergmann
On 04/02/2012 04:15 PM, Michael Stahl wrote: i wonder, this XInitialization always seemed to be like some backward compatibility kludge, would it be possible to get rid of this for LO4 and pass the arguments to the C++ ctor of the implementing class directly or at least a static factory method or

Legal stuff

2012-04-02 Thread karthik padmanabhan
All of my past and future contributions to the LibreOffice project are under LGPLv3+/GPLv3+/MPL until further notice. Regards Karthik Anantha Padmanabhan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

[PUSHED] registry key in SDK installer

2012-04-02 Thread Michael Meeks
On Mon, 2012-04-02 at 15:03 +0200, Andras Timar wrote: > This commit fixes a (potential) problem in SDK's Windows installer. > The install location of corresponding LibreOffice version could not be > detected correctly. Looks reasonable to me :-) Thanks ! Michael

Re: [CFT] Windows native file/folder picker (fop/fps)

2012-04-02 Thread Christian Lohmaier
Hi *, On Mon, Apr 2, 2012 at 4:55 PM, Michael Stahl wrote: > [...] > it would be great if somebody could test if both native folder and file > picker still work as they did before (e.g. compare with 3.5 branch) on > the various supported Windows releases. Nor sure whether it is still an issue, b

Re: Android UI work

2012-04-02 Thread Christian Lohmaier
Hi *, On Mon, Apr 2, 2012 at 4:06 PM, Tor Lillqvist wrote: >> so for the native Mac GUI port in OOo 3.0 the Start >> Centre was designed (in its fully gradiented glory) so it can be shown >> to those posh Mac users in the case when no document is opened. > > ("posh"?) > > Oh, odd, as that's not h

Re: Fwd: [tdf-discuss] LibreOffice Version Mismatch/Conflict

2012-04-02 Thread Andras Timar
Hi Petr, 2012/4/2 Petr Mladek : >> As far as I remember, I introduced the VERSIONMICRO variable before >> 3.5 feature freeze, and it is used only in File Version field of >> Windows executables. The same is true for VERSIONMAJOR and >> VERSIONMINOR. It is safe to bump them, when necessary. > > Goo

[CFT] Windows native file/folder picker (fop/fps)

2012-04-02 Thread Michael Stahl
hi all, some weeks ago on master (5142e628b563a9876e8884c5dd4914eff4a2f307) i've merged 2 Windows-only DLLs, namely the contents of the "fop" library into "fps": "fop" implements a native Windows folder picker, while "fps" implements a native Windows file picker; now both file and folder picker a

Re: string / size bits ... #2 ...

2012-04-02 Thread Noel Grandin
To make it easier to find culprits, perhaps you could add a feature to your script? Use some kind of variable to select a specific string, and then store the callstack every time that string gets allocated, using backtrace() Then dump the top 100 call-stacks using backtrace_symbols() Brute forc

Legal stuff

2012-04-02 Thread Brennan T Vincent
All of my past and future contributions to the LibreOffice project are under LGPLv3+/GPLv3+/MPL until further notice. --Brennan Vincent ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffi

[PATCH] Fix RTF list level text follow

2012-04-02 Thread Brennan T Vincent
Miklos, > Except this: is this really needed? As far as I see, it's not used. You are correct, of course. I had added those lines before I fully understood how the code worked, and forgotten to remove them. I have updated my patch and formatted it correctly. 0001-Fix-RTF-levelfollow-import-and-e

Re: Font rendering oddities: is this already known?

2012-04-02 Thread Caolán McNamara
On Fri, 2012-03-30 at 16:22 -0300, Olivier Hallot wrote: > Hi > > The image in the link below shows some font oddities in all applications > of LibreOffice Is this something new ? (hopefully not). For the case of writer itself, and the differences from pdf and on-screen etc, one piece of code tha

string / size bits ... #2 ...

2012-04-02 Thread Michael Meeks
On Fri, 2012-03-30 at 15:21 +0100, Michael Meeks wrote: > I up-loaded the output of my string debug for a writer start: And discovered there was a bazillion problems with it, in particular the handling of OUStrings, having nailed that - it now has some considerable error due to 'Str

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

2012-04-02 Thread Caolán McNamara
On Mon, 2012-04-02 at 16:15 +0200, Michael Stahl wrote: > would it be possible to get rid of this for LO4 and pass the arguments > to the C++ ctor of the implementing class I guess one potential gotcha is that you can't call virtual methods on your in-construction object in a C++ ctor while ::init

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

2012-04-02 Thread Michael Stahl
On 28/03/12 12:11, Stephan Bergmann wrote: > * CTORS accessible.AccessBridge: This service being of interface type > XInitialization looks strange. (XInitialization is more of an internal > interface, so that instances of such a service can obtain arguments when > being constructed. Explicit

[PATCH] remove unused code (oox)

2012-04-02 Thread Petr Vorel
Hi there, removed unused classes from oox. Regards, Petr >From b4350501d1fe85da2cce5750b480e33eb6409301 Mon Sep 17 00:00:00 2001 From: Petr Vorel Date: Mon, 2 Apr 2012 11:40:06 +0200 Subject: [PATCH] remove unused code (oox) --- oox/inc/oox/dump/dumperbase.hxx | 18 -- oox/inc/oox/dump/o

Re: [PATCH] EasyHack, fdo#46808, Adapt UNO services to new style, Parts 2 through 5

2012-04-02 Thread Michael Stahl
On 28/03/12 12:26, Tor Lillqvist wrote: >> MARKER: These services are not intended to be instantiated via their service >> names. > > How is it in general with service names, if one browses services.rdb > (either of them), one doesn't have to look long to notice components > that have identical s

Re: [PATCH] Fix memory errors in SwWW8ImplReader

2012-04-02 Thread Miklos Vajna
Hi Lubos, On Mon, Apr 02, 2012 at 03:04:22PM +0200, Lubos Lunak wrote: > You are right that reading of some of the sprm's is broken, but looking at > the first problem with the test document in Read_UL(), it is called with nId > = 0x246D, which is sprmPFContextualSpacing, and the .doc spec for

Re: Android UI work

2012-04-02 Thread Tor Lillqvist
> so for the native Mac GUI port in OOo 3.0 the Start > Centre was designed (in its fully gradiented glory) so it can be shown > to those posh Mac users in the case when no document is opened. ("posh"?) Oh, odd, as that's not how "normal" Mac apps work, is it? If you have no documents open in Te

  1   2   >