Re: [PATCH][PUSHED] Convert SV_DECL_VARARR, SV_IMPL_VARARR with std::deque

Thanks for the patch. Pushed it in. Nice to see the great cleanup :) Cheers Fridrich On 16/03/12 23:41, Bartosz wrote: > Hi > > I converted the SV VARARR to std::deque in sw component. > > Could you please check and push this path? > > This and later contributions is licensed under MPL 1.1 /

Re: [PATCH][PUSHED] convert tools/table.hxx to std::map in Chart2PositionMap class

Pushed, thanks. Fridrich On 16/03/12 13:58, Noel Grandin wrote: > Hi > > License in on file. This patch applies on top of my cleanup patches from > earlier today. > > Regards, Noel Grandin > > Disclaimer: http://www.peralex.com/disclaimer.html > > > > ___

Re: [PATCH][PUSHED] code cleanup in chart2uno.cxx in SC module

Thanks for the patch. Pushed now. Cheers Fridrich On 16/03/12 08:49, Noel Grandin wrote: > Hi > > License statement is on file. > > This series is a precursor to more tools/table.hxx removal, but I > thought I'd push the code cleanup series separately to make it easier to > review. > > Regard

Re: [PATCH] SVG import: keep aspect ratio when transforming viewbox to viewport

Thanks, Christina, for this one. Pushed it. In case you want to fix some more SVG import bugs, I spoke with someone who did some stess-testing :) Fridrich On 17/03/12 22:14, Chr. Rossmanith wrote: > Hi, > > bug 47451 has a test doc (svg) attached which isn't imported correctly > by LibreOffice.

Re: [PATCH][PUSHED] convert tools/table.hxx usage to std::map in Basic IDE module

Thanks, pushed. Fridrich On 20/03/12 09:05, Noel Grandin wrote: > Hi > > License is on file. > > Passes make check and some UI testing. > > Regards, Noel Grandin > > Disclaimer: http://www.peralex.com/disclaimer.html > > > > ___ > LibreOffice mai

Re: [PATCH][PUSHED] convert tools/table.hxx usage in sc/filters

Thanks for the patches. I pushed them right now. Nice to see your work. Cheers Fridrich On 19/03/12 10:28, Noel Grandin wrote: > Hi > > Two patches, one for sc/filters/html and one for sc/filters/rtf > > License is on file. > > I think I'm about 3 patches away from finishing off tools/table.

Re: [PATCH][PUSHED] maTransform had to go ( was always = identity)

Thanks for this one. Pushed. Fridrich On 20/03/12 20:49, Chr. Rossmanith wrote: > No maTransform in PresenterSprite anymore. > > Christina > > Am 20.03.2012 16:07, schrieb Caolán McNamara: >> On Tue, 2012-03-20 at 15:24 +0100, Chr. Rossmanith wrote: >>> At least it doesn't change the position o

Re: [PATCH] [WIP] fdo#45747 - [EasyHack] remove the limitation to 3 sort entries in calc

Hey Albert, > I will check this patch tomorrow. A quick look through the patch did > not show any serious problems only some small nit-picks that I will > change while reviewing. > Ok. So as promised I reviewed the patch now. Sadly there are some more problems than I thought after my first quick

Re: Questions about Bug 33773 (chart)

Hello Rafael, >> > >> > 1.- How i should handle export/import??? It seems ODF 1.2 and below, >> > only >> > support working with Y error bars, >> > XLS import/export code, already supports having both bars. Tested it by >> > exporting to xls and then importing it. >> > >> > Is there any way we can

Turn fdo#45283 into a GSOC-project?

Hi, Read on IRC today: [19:43] kohei: we have all these eager GSOC students, and not enough tasks :-) If this is really the case, one idea is maybe to turn this into a GSOC-project? https://bugs.freedesktop.org/show_bug.cgi?id=45283 I have not been able to start on this anyway (not even asked

Re: Questions about Bug 33773 (chart)

On Tue, Mar 20, 2012 at 10:45 PM, Markus Mohrhard < markus.mohrh...@googlemail.com> wrote: > Hello Rafael, > > 2012/3/21 Rafael Dominguez : > > Hello, i been working on bug 33773 for a few days already, and i got to > the > > point where i can display and manipulate > > X Error bars, but theres a

Re: Bug 45522: rtf export, Crash when copying table between Writer and other LibreOffice programs

On Thu, 2012-03-08 at 17:23 +0100, Dézsi Szabolcs wrote: > Hi! > > https://bugs.freedesktop.org/show_bug.cgi?id=45522 > > There's an attached odt file with a table in it. Copying the table to > other LO programs (Calc, etc) causes LO to crash. > After inspection I realized that the problem is in

Make watchdog (Re: Build failure on Windows/MSVC because of embedserv)

On Monday 19 of March 2012, Michael Meeks wrote: > On Mon, 2012-03-19 at 07:33 +0100, Lubos Lunak wrote: > > Oh, I see. I've already noticed this myself, and that's a good > > explanation for Voreppe's (lack of) builds. That's a rather bad bug for > > tinderbox builds, and we really could use a ti

Re: Litmus, a proposal

On Wed, Mar 21, 2012 at 02:27:20PM +0100, Bjoern Michaelsen wrote: > The first and most important one is: it is behind its own login -- and that > prevents the casual bypasser to get involved and interested. IMHO, we > absolutely need to change that. The testcases should be browsable without a > lo

License statement

Following on from my previous email.. this applies to all contributions I have made in my capacity as Debian developer: All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. Regards Chris ___

License statement - credativ

credativ has a general policy of contributing code to open source projects under the terms of the license of that project. All contributions past, present, and future (while this choice of project license is in place) made to LibreOffice from the credativ group are available under the terms the M

Re: Building master on Windows. Installer fails.

On Wed, 2012-03-21 at 16:03 +0200, Tor Lillqvist wrote: > > btw I did a windows build yesterday that finished this morning ( slow > > machine ) that installs correctly, you should hopefully be ok > > Does it even run correctly? Am I the only one for who it doesn't start? ;( Well, I just finished

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

Thanks. But you know that no matter how good you make the instructions, users will __always__ find a way to misread them :-) On Wed, Mar 21, 2012 at 17:31, Stephan Bergmann wrote: > On 03/21/2012 04:19 PM, Noel Grandin wrote: >> >> On Wed, Mar 21, 2012 at 14:44, Stephan Bergmann >>  wrote: >>> >

[PUSHED 3-5] Re: Bug 45522: rtf export, Crash when copying table between Writer and other LibreOffice programs

On 21/03/12 16:31, Caolán McNamara wrote: > On Thu, 2012-03-08 at 17:23 +0100, Dézsi Szabolcs wrote: >> Hi! >> >> https://bugs.freedesktop.org/show_bug.cgi?id=45522 >> >> There's an attached odt file with a table in it. Copying the table to >> other LO programs (Calc, etc) causes LO to crash. >> Af

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

On 03/21/2012 04:19 PM, Noel Grandin wrote: On Wed, Mar 21, 2012 at 14:44, Stephan Bergmann wrote: offapi/type_reference/types.rdb. (Btw, you did replace the com.sun.star.script.Converter from the example with your actual com.sun.star.script.Engine, did you?) Aaah, that would be the problem.

Re: [PUSHED] Replace SV_DECL_PTRARR_DEL by ptr_vector in ww8par2.cxx

On 03/21/2012 12:42 PM, Stephan Bergmann wrote: I noticed a few things I addressed with follow up "Further clean up of previous patch," however: What I forgot to mention, sw/source/filter/ww8/ww8p

Re: Litmus, a proposal

On 03/21/2012 02:27 PM, Bjoern Michaelsen wrote: when the topic of getting testcases for LibreOffice into Ubuntus Checkbox, I finally got myself a Litmus account. I defered that before as "yet another login" I did not want to use. Having a look at it now, I find it quite simple and useful -- it i

[ANN] LibreOffice 3.5.2 RC1 test builds available

Hi *, for the upcoming new version 3.5.2, the RC1 builds now start to be available on pre-releases. This build is slated to be first release candidate build on the way towards 3.5.2, please refer to our release plan timings here: http://wiki.documentfoundation.org/ReleasePlan#3.5_release Builds

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

On Wed, Mar 21, 2012 at 14:44, Stephan Bergmann wrote: > offapi/type_reference/types.rdb.  (Btw, you did replace the > com.sun.star.script.Converter from the example with your actual > com.sun.star.script.Engine, did you?) Aaah, that would be the problem. I assumed that because of it's name "Conv

Re: Exception specifications on functions useless?

On 03/21/2012 03:33 PM, Caolán McNamara wrote: On Wed, 2012-03-21 at 10:04 +0100, Stephan Bergmann wrote: it would IMO be nice to nevertheless have information about functions' exception behaviour around, in a form suitable for mechanical verification. (For example by disabling GCC's -fno-enfor

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #248 from choffardet 2012-03-21 07:52:49 PDT --- (In reply to comment #246) > (In reply to comment #245) > > @choffardet: > Here we only can list LibO Bugzilla bugs. Please check whether that's already > reported, if not please file

Re: Exception specifications on functions useless?

On Wed, 2012-03-21 at 10:04 +0100, Stephan Bergmann wrote: > it would IMO be nice to nevertheless have information about functions' > exception behaviour around, in a form suitable for mechanical > verification. (For example by disabling GCC's -fno-enforce-eh-specs > for --enable-dbgutil builds.)

Re: [Libreoffice-commits] .: Initial experiments with static linking of (some) components / services

> Why not rather leverage the existing .component file prefix > attribute, combining all the component_getFactory functions into the one > single executable (disambiguating them via prefixes), and tell the UNO > shared library loader to not bother with multiple libs, but just call the > relevant _c

Re: Building master on Windows. Installer fails.

On 21/03/12 14:03, Tor Lillqvist wrote: btw I did a windows build yesterday that finished this morning ( slow machine ) that installs correctly, you should hopefully be ok Does it even run correctly? Am I the only one for who it doesn't start? ;( yup, or at least I get to the start center backi

Re: Building master on Windows. Installer fails.

> btw I did a windows build yesterday that finished this morning ( slow > machine ) that installs correctly, you should hopefully be ok Does it even run correctly? Am I the only one for who it doesn't start? ;( --tml ___ LibreOffice mailing list LibreOf

Re: Building master on Windows. Installer fails.

On 21/03/12 13:01, Kohei Yoshida wrote: On Wed, Mar 21, 2012 at 8:58 AM, Michael Stahl wrote: On 21/03/12 13:55, Kohei Yoshida wrote: make[1]: *** No rule to make target `/cygdrive/c/libo/core-master/workdir/wntmsci12.pro/CxxObject/ucb/source/ucp/odma/odma_provider.o', needed by `/cygdrive/c

Re: [Libreoffice-commits] .: Initial experiments with static linking of (some) components / services

On 03/20/2012 11:02 PM, Tor Lillqvist wrote: commit 25d114eec4d451acdda1ddff4c8ed9d47ba6275f Author: Tor Lillqvist Date: Tue Mar 20 23:18:55 2012 +0200 Initial experiments with static linking of (some) components / services Start with the first service needed when running sc's filte

Re: [PUSHED][PATCH] Compilation fix - GTK print dialog headers for GTK < 2.14

On Tue, 2012-03-20 at 17:58 -0400, David Bolen wrote: > This fell out when I was working on my last patch for sub-menu icons. > Initially building with GTK failed on my system due to a missing > gtkunixprint.h header, which I worked around by just manually > disabling ENABLE_GTK_PRINT. > > Afterwa

Litmus, a proposal

Hi all, when the topic of getting testcases for LibreOffice into Ubuntus Checkbox, I finally got myself a Litmus account. I defered that before as "yet another login" I did not want to use. Having a look at it now, I find it quite simple and useful -- it is very well suited to be the tool to get o

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 vitriol changed: What|Removed |Added Depends on||47355 --- Comment #247 from vitriol 2012-03-2

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #246 from Rainer Bielefeld 2012-03-21 06:03:38 PDT --- (In reply to comment #245) @choffardet: Here we only can list LibO Bugzilla bugs. Please check whether that's already reported, if not please file a new LibO Bugzilla Bug! --

Re: Building master on Windows. Installer fails.

On Wed, Mar 21, 2012 at 8:58 AM, Stephan Bergmann wrote: > On 03/21/2012 01:55 PM, Kohei Yoshida wrote: >> >> make[1]: *** No rule to make target >> >> `/cygdrive/c/libo/core-master/workdir/wntmsci12.pro/CxxObject/ucb/source/ucp/odma/odma_provider.o', >> needed by >> `/cygdrive/c/libo/core-master/

Re: Building master on Windows. Installer fails.

On Wed, Mar 21, 2012 at 8:58 AM, Michael Stahl wrote: > On 21/03/12 13:55, Kohei Yoshida wrote: > >> make[1]: *** No rule to make target >> `/cygdrive/c/libo/core-master/workdir/wntmsci12.pro/CxxObject/ucb/source/ucp/odma/odma_provider.o', >> needed by >> `/cygdrive/c/libo/core-master/workdir/wnt

Re: Building master on Windows. Installer fails.

On 21/03/12 13:55, Kohei Yoshida wrote: > make[1]: *** No rule to make target > `/cygdrive/c/libo/core-master/workdir/wntmsci12.pro/CxxObject/ucb/source/ucp/odma/odma_provider.o', > needed by > `/cygdrive/c/libo/core-master/workdir/wntmsci12.pro/LinkTarget/Library/iucpodma1.lib'. > Anyone has an

Re: Building master on Windows. Installer fails.

On 03/21/2012 01:55 PM, Kohei Yoshida wrote: make[1]: *** No rule to make target `/cygdrive/c/libo/core-master/workdir/wntmsci12.pro/CxxObject/ucb/source/ucp/odma/odma_provider.o', needed by `/cygdrive/c/libo/core-master/workdir/wntmsci12.pro/LinkTarget/Library/iucpodma1.lib'. Meanwhile fixed

Re: Building master on Windows. Installer fails.

On Tue, Mar 20, 2012 at 4:56 PM, Andras Timar wrote: > Hi Kohei, > > 2012/3/20 Kohei Yoshida : >> Hi there, >> >> I decided to give master a try on Windows once again.  The good news >> is that, it just built flawlessly without ever needing my >> intervention.  The bad news is that, the installer

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

On 03/21/2012 01:06 PM, Noel Grandin wrote: I modified types.rdb using the script referenced there, but still got an error. That's why I asked for a patch, to see what's wrong with your modified offapi/type_reference/types.rdb. (Btw, you did replace the com.sun.star.script.Converter from the

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #245 from choffardet 2012-03-21 05:25:46 PDT --- please, consider this bug : https://issues.apache.org/ooo/show_bug.cgi?id=58415 this bug is also in libreoffice and is a very annoying bug... -- Configure bugmail: https://bugs.fr

Re: [UX advise] Key navigation in ValueSet controls

Hi Matteo, Stefan, Great that you care for this, Matteo! And of course that you helped with discussing, Stefan. I'm a bit late: trouble to keep in track with the various topics in the community, but found this important enough to read and try to add some thoughts. Sorry if it is a bit too late

Re: Exception specifications on functions useless?

On Wed, Mar 21, 2012 at 12:33:13PM +0100, Stephan Bergmann wrote: > But that is completely unrelated to whether you can only throw > derivations of std::exception or also things like int 5. Yes, sorry for mixing that in. The problem is can-throw-by-default. If one would be required to spec what on

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

Hi I was just using Engine as a testbed, but yes, I should probably pick a non-deprecated one :-) I modified types.rdb using the script referenced there, but still got an error. Regards, Noel Grandin On Wed, Mar 21, 2012 at 09:46, Stephan Bergmann wrote: > On 03/21/2012 08:38 AM, Stephan Bergm

Re: About LO Mac OS bugs which appear if accessibility options enabled

Le 21/03/12 12:47, Norbert Thiebaud a écrit : Hi Norbert, > I've add --with-symbols to my Mac tinderbox... the next daily build > should have them... hope this help That would be great, thanks :-) !! Alex ___ LibreOffice mailing list LibreOffice@li

Re: About LO Mac OS bugs which appear if accessibility options enabled

On Wed, Mar 21, 2012 at 5:26 AM, julien2412 wrote: > Hello, > > Concerning Mac OS bugs which appear if accessibility options enabled (eg > https://bugs.freedesktop.org/show_bug.cgi?id=47368, see comment 5), is there > a MacOs build with symbols available ? > I don't have a Mac but some people (Ale

Re: [PUSHED] Replace SV_DECL_PTRARR_DEL by ptr_vector in ww8par2.cxx

On 03/18/2012 11:02 AM, Arnaud Versini wrote: This patch replace SV_DECL_PTRARR_DEL by a simple ptr_vector in sw/source/filter/ww8/ww8par2.cxx. I will continue on the same way in this folder if there is no issue with this patch. Patch looks good. (At least, taking

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #244 from Michael Meeks 2012-03-21 04:34:25 PDT --- Great nomination Roman - thanks for that ! :-) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You

Re: Exception specifications on functions useless?

On 03/21/2012 12:28 PM, Bjoern Michaelsen wrote: On Wed, Mar 21, 2012 at 11:54:09AM +0100, Stephan Bergmann wrote: It does *not* add "another _untyped_ return path," at least not any more so than it would do if throwable types in C++ were restricted to some specific subset. Thats exactly the p

Re: Exception specifications on functions useless?

On Wed, Mar 21, 2012 at 11:54:09AM +0100, Stephan Bergmann wrote: > It does *not* add "another _untyped_ return path," at least not any more so > than it would do if throwable types in C++ were restricted to some specific > subset. Thats exactly the point. In a statically typed environment the def

Re: Exception specifications on functions useless?

On 03/21/2012 11:37 AM, Michael Stahl wrote: for the case where it is a good idea to check exceptions (e.g. Java UNO bridge, which cannot throw exceptions to the Java side that are not declared on the interface), a runtime catch-all check should be sufficient also. Yep, guards to catch attempts

Re: Exception specifications on functions useless?

On 03/21/2012 11:23 AM, Bjoern Michaelsen wrote: For the most part I would agree here. C++ exceptions are broken by design. Allowing any kind of object (not even exception) to be thrown by default in a function adds another _untyped_ return path (as if every function would return a void* in addit

Re: [PUSHED] [PATCH]fdo45671 set initial colours for split buttons

Hi Winfried, I just pushed this, with a small change, namely, I made the line color blue by default (same as in MS Office, again). Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libre

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Roman Eisele changed: What|Removed |Added Depends on||46020 --- Comment #243 from Roman Eisele

Re: Exception specifications on functions useless?

On 20/03/12 22:50, Lubos Lunak wrote: > > Hello, > > I've just found out that exception specification on functions in LO have > been > just pretty comments, for about 10 years. > > Just to make sure what I'm talking about, it's the throw() in e.g. this > > void foo( int a, void* b ) throw(

About LO Mac OS bugs which appear if accessibility options enabled

Hello, Concerning Mac OS bugs which appear if accessibility options enabled (eg https://bugs.freedesktop.org/show_bug.cgi?id=47368, see comment 5), is there a MacOs build with symbols available ? I don't have a Mac but some people (Alex ? :-) ) may help a lot with a Debug build (eg to retrieve a u

Re: Exception specifications on functions useless?

Hi all, On Tue, Mar 20, 2012 at 10:50:02PM +0100, Lubos Lunak wrote: > - boost, and pretty much everybody else it seems, do not consider it worth > the > hassle of specifying what a function may or may not throw, except for > flagging a non-inline method as not throwing any exception at all as

Re: Exception specifications on functions useless?

On 03/21/2012 08:40 AM, Tor Lillqvist wrote: I think a large part of our hackers, certainly of new ones, might have more experience of Java than C++. They might think that C++ is more like Java, and that the throw clauses are crucial to be exactly right (for some value of "right"), and then waste

Re: Exception specifications on functions useless?

On 03/20/2012 10:50 PM, Lubos Lunak wrote: I've just found out that exception specification on functions in LO have been just pretty comments, for about 10 years. [...] I found out by compiling LO with Clang, running it and having it crash where gcc-compiler version had no problem. Stephan

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

On 03/21/2012 08:38 AM, Stephan Bergmann wrote: On 03/21/2012 06:46 AM, Noel Grandin wrote: All I did was modify Engine.idl to read published service Engine : com::sun::star::script::XEngine; So you did not modify offapi/type_reference/types.rdb as described at

Re: Exception specifications on functions useless?

>  Opinions on this? I am in favour of removing the throw specifications. Especially after reading your link (and what it links to, like http://www.gotw.ca/publications/mill22.htm ). I think a large part of our hackers, certainly of new ones, might have more experience of Java than C++. They migh

Re: fdo#46808 - [Easy Hack] Adapt UNO services to new-style

On 03/21/2012 06:46 AM, Noel Grandin wrote: All I did was modify Engine.idl to read published service Engine : com::sun::star::script::XEngine; So you did not modify offapi/type_reference/types.rdb as described at