Re: [REVIEWED] [PUSHED 3-5] fix for fdo#46816, don't show error message for empty range name in Define Names

On Fri, Mar 2, 2012 at 7:13 PM, Markus Mohrhard wrote: > [1] improves the dialog a bit. The error message is a bit misleading > and we can just use the disabled Add button as sign that you can't add > an empty range name. > [1] > http://cgit.freedesktop.org/libreoffice/core/commit/?id=6e93e78c8

Re: [REVIEWED] [PUSHED 3-5] fix for fdo#46825, crash copying a chart

On Fri, Mar 2, 2012 at 7:08 PM, Markus Mohrhard wrote: > Hey, > > [1] fixes a crash when you copy a chart in the document. The problem > is that you should not create a uno::Sequence with new because the > uno::Sequence copy c'tor is creating a flat copy. This will later > result in a double delet

[REVIEW] fix for fdo#46816, don't show error message for empty range name in Define Names

Hey, [1] improves the dialog a bit. The error message is a bit misleading and we can just use the disabled Add button as sign that you can't add an empty range name. It would be nice if this could be cherry-picked to 3-5 and maybe 3-5-1. Regards, Markus [1] http://cgit.freedesktop.org/libreoff

[REVIEW] fix for fdo#46825, crash copying a chart

Hey, [1] fixes a crash when you copy a chart in the document. The problem is that you should not create a uno::Sequence with new because the uno::Sequence copy c'tor is creating a flat copy. This will later result in a double delete. I think the patch is quite save and fixes a crash and therefore

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #217 from mariosv 2012-03-02 16:04:31 PST --- (In reply to comment #211) > When I hide a row and then copy the remaining rows Calc will also copy the > hide > rows. As I know this only works with rows hidden by filters not if is hi

Re: [REVIEW 3-5] Custom Shapes compile speedup ... #2

On Fri, 2012-03-02 at 20:46 +0100, Radek Doulik wrote: > On Fri, 2012-03-02 at 19:51 +0100, Radek Doulik wrote: > > thanks. The patch looks good to me. Pushed. I just pushed a lot more of this stuff to master, basically out-lining all those (exception throwing => hard-to-optimise) object

[PUSHED 3-5-1] Simple UI fix

On Fri, 2012-03-02 at 11:10 +0100, Petr Mladek wrote: > One more review needed for 3-5-1 branch. We got one on IRC & pushed it to -3-5-1. Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot

Reduce duplicate code: PrinterJob::writeProlog

Hi, static const sal_Char pProlog[] and static const sal_Char pSO52CompatProlog[] share about 90% of their content (2 out of 84 lines differ). I could split the prolog in three parts: part 1 and 3 identical for both variables and part 2 varies with m_pGraphics->getStrictSO52Compatibility()

Re: Disabling Temporary Files?

On Fri, 2012-03-02 at 14:31 -0500, Marc-André Laverdière wrote: > I will do that investigation. Just a quick question: if the original > file was password-protected, will the temp files be similarly be > protected? Almost certainly not :-) but theoretically they could be of course.

Re: [REVIEW 3-5] Custom Shapes compile speedup ...

Hi again, On Fri, 2012-03-02 at 19:51 +0100, Radek Doulik wrote: > Hi Michael, > > thanks. The patch looks good to me. Pushed. > > It doesn't change the properties data, so it shouldn't break anything. I > guess I will cook another sample document containing all presets for > easier future testi

Re: "LibreOffice 3.5 does not work anymore"

Hi Luc, Luc Castermans wrote (02-03-12 19:53) Libo 3.5 and also 3.5rc1 do not start anymore. Attached message I get. "LibreOffice 3.5 does not work anymore" Looks pretty dramatic. How can I find out what's wrong? Best mail to QA-list with some more details. Or look in BugZilla http://w

Re: Disabling Temporary Files?

Hello, I will do that investigation. Just a quick question: if the original file was password-protected, will the temp files be similarly be protected? On 2012-02-28 1:57 PM, "Michael Stahl" wrote: > On 28/02/12 19:46, Marc-André Laverdière wrote: > > Hello, > > > > I need to ensure that data con

Re: EasyHack: perl / autogen.sh should backup autogen.lastrun

Hi, thanks for the tip. This is an improved (hopefully) version of the patch =) Cheers! 2012/2/29 Michael Meeks > Hi there, > > On Wed, 2012-02-29 at 11:58 +0100, Thomas Collerton wrote: > > this patch accomplishes what the EasyHack requests =) > > Thanks - pushed it :-) > >Perso

Re: [PATCH] [REVERTED] fdo#46193: Let the user copy error message from error dialog

>> OK, so I think the consensus is that the patch should be reverted, and >> that Dézsi is kindly asked to re-design the UI for this (as such nice >> and wanted) functionality? Done. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org h

Re: [REVIEW 3-5] Custom Shapes compile speedup ...

Hi Michael, thanks. The patch looks good to me. Pushed. It doesn't change the properties data, so it shouldn't break anything. I guess I will cook another sample document containing all presets for easier future testing. Cheers Radek On Fri, 2012-03-02 at 17:44 +, Michael Meeks wrote: > Hi

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

On Fri, 2012-03-02 at 18:23 +0200, Tor Lillqvist wrote: > OK, so I think the consensus is that the patch should be reverted, and > that Dézsi is kindly asked to re-design the UI for this (as such nice > and wanted) functionality? Yep :-) Michael. -- michael.me...@suse.c

[REVIEW 3-5] Custom Shapes compile speedup ...

Hi guys, I'd like to propose this for cherry-picking: http://cgit.freedesktop.org/libreoffice/core/commit/?id=f291fb57d087de41385a22dfacd8b694d8b9abc7 the rather large and tedious patch it generates is this: http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4157cefc5416eb

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

On Fri, 2012-03-02 at 16:00 +0100, Stephan Bergmann wrote: > And when/if we replace the sal C API with a C++ one in LO 4 (where a > memory allocation function, if we would still need a home-grown one > anyway, would naturally throw bad_alloc) Yeah, back the O[UString contents with direct new/del

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||46901 --- Comment #216 from Rainer Bi

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

OK, so I think the consensus is that the patch should be reverted, and that Dézsi is kindly asked to re-design the UI for this (as such nice and wanted) functionality? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.free

[REVIEW-3-4] Fix for fdo#34209

Hi there, somewhat ugly but effective fix for not showing credits etc. on Mac. Got independently fixed by Stephan's 3layer-cleanup on -3-5, so no need for action there. I need one review. Cheers, -- Thorsten diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp index

License Statememnt

As generic as possible ;) All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. cheers Andreas -- Andreas Proschofsky Gentoo Developer Twitter: @suka_hiroaki Identi.ca: @suka Google+: https://plus.google.com/110305043

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

Hi all, first: Dézsi, it's great that you care about our UI! Michael wrote... >        Copying the text to the clipboard is a real minority use-case and > doesn't deserve a prominent button in every dialog IMHO. As one of the UX-advise guys, I have to agree with that. Gnome solve the same proble

Re: [PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

you are correct, I will spin a new patch. On 2012-03-02 17:42, Ivan Timofeev wrote: Hi, > -DECLARE_TABLE( SwBookmarkNodeTable, SvPtrarr* ) > +typedef std::multimap SwBookmarkNodeTable; ... > +SwBookmarkNodeTable aBkmkNodePos; ... > -SvPtrarr* pArr = (m_pImpl->pBkmkNodePos) ? > -

Re: [PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

Hi, > -DECLARE_TABLE( SwBookmarkNodeTable, SvPtrarr* ) > +typedef std::multimap SwBookmarkNodeTable; ... > +SwBookmarkNodeTable aBkmkNodePos; ... > -SvPtrarr* pArr = (m_pImpl->pBkmkNodePos) ? > -m_pImpl->pBkmkNodePos->Get( nNd ) : 0; > -if( pArr ) > +SwBookmarkNodeTabl

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||46532 --- Comment #215 from Rainer Bi

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

On 03/01/2012 03:42 PM, Lubos Lunak wrote: On Wednesday 29 of February 2012, Caolán McNamara wrote: But ok, it's too much to just abort in every case. I think however that whether to abort or try to recover does not actually depend on the class where the problem occurs, but on where the class i

Re: minutes of ESC call ...

On 03/02/2012 11:35 AM, Michael Stahl wrote: On 02/03/12 10:32, Michael Meeks wrote: On Fri, 2012-03-02 at 09:29 +0100, Stephan Bergmann wrote: Micheal, I think I still don't understand what you are up to here. What does logging have to do with XUnoTunnel ? Correct me if I'm wrong, b

Re: [PATCH] [PUSHED] fdo#46501: EasyHack: cleanup SimpleResMgr ...

Thanks, pushed. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: {PATCH] [PUSHED] Convert tools/table.hxx to std::vector and std::map in CUI module

Thanks, pushed to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[bjoern.michael...@canonical.com: minutes of gerrit.documentfoundation.org call 2012-03-01]

Hi there, gerrit call minutes from my scribblings: present: Robert, Norbert, Bjoern topics: - gerrit is up and running - against postgresql AA - set-up back-up solution for postgresql (Robert, ETA next week) - bouncycastle ssh-server: is it secure? - google is using it, s

[PUSHED 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

On Fri, 2012-03-02 at 13:00 +0200, Tor Lillqvist wrote: > At first I stared a bit at the rename 3076,5124; but apparently > that is legal Perl. And hmm, why wouldn't it be, numbers are numbers, :-) I checked the id's too & cherry-picked it to libreoffice-3-5-1. Thanks,

{PATCH] Convert tools/table.hxx to std::vector and std::map in CUI module

Hi Convert tools/table.hxx to std::vector and std::map in CUI module Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html 0001-Convert-tools-table-to-std-vector-and-std-map-i

Re: [REVIEW][3-5-1][3-4] nsplugin broken due to typo

On Thu, 2012-03-01 at 09:39 +0100, Stephan Bergmann wrote: > Only thing missing (since 2004) is to actually use them... Filed > "[Easy Hack] Adapt > UNO services to new-style" now. Nice work :-) Thanks for that, hopefully some enthus

Re: [REVOKED] Fix for fdo#562027, lp#562027, deb#632920: Quickstarter breaks log out

On Tue, Feb 28, 2012 at 02:38:29PM +0100, Bjoern Michaelsen wrote: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=5279616d50b0394e8ec6d8e2109471ca649412b7 revoking this review request for now: patch is incomplete. Best, Bjoern ___ LibreO

Bugzilla queries and NEEDINFO state

Hi, I have just fixed the queries at https://wiki.documentfoundation.org/Release_Criteria#Blocker_Bug_Nomination to accept the "new" NEEDINFO status. They show a bit more bugs now. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.fre

[PATCH] fdo#46501: EasyHack: cleanup SimpleResMgr ...

Hi! I deleted the constructor which uses OUString as suggested here: https://bugs.freedesktop.org/show_bug.cgi?id=46501 Szabolcs From f69fd5cb5e8cbe05a3b87b9b5adfd8494a9a4bab Mon Sep 17 00:00:00 2001 From: Szabolcs Dezsi Date: Fri, 2 Mar 2012 13:30:28

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||46843 -- Configure bugmail: https://bugs.

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #214 from Petr Mladek 2012-03-02 03:06:09 PST --- Add bug 46843: Base Queries loose sorting-order when reopening for editing -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this m

Re: [REVIEW 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

+1 from me too. At first I stared a bit at the rename 3076,5124; but apparently that is legal Perl. And hmm, why wouldn't it be, numbers are numbers, they don't need quoting, and sure, a number can be used directly as a file name if that is what the file's name is, a numeric string;) --tml __

Re: [REVIEW 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

Rubber-stamping for 3-5 branch. 2 more review needed for 3-5-1 Cheers F. On 02/03/12 11:03, Andras Timar wrote: > Hi, > > This was a bug in our multi language Windows Installer, users from > Hong Kong saw Simplified Chinese install wizard instead of Traditional > Chinese. I tested and the same

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

On 2 March 2012 11:31, Tor Lillqvist wrote: > Is there a way to do "make clean" only for the host platform, not the > build platform? Is there a way to make clean only for object files, > and especially not the stuff generated from IDL files? Well, I would push: --- a/Makefile +++ b/Makefile @@

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

> Maybe the best way out for me would be to make it ignore dependencies > completely (not generate and not use any .d files), and do "make > clean" more often, Is there a way to do "make clean" only for the host platform, not the build platform? Is there a way to make clean only for object files,

Re: minutes of ESC call ...

On 02/03/12 10:32, Michael Meeks wrote: > > On Fri, 2012-03-02 at 09:29 +0100, Stephan Bergmann wrote: >> Micheal, I think I still don't understand what you are up to here. What >> does logging have to do with XUnoTunnel ? > > Correct me if I'm wrong, but as soon as we start doing bridgin

Re: [PUSHED:3-5] Fix for fdo#40320

Markus Mohrhard píše v Út 28. 02. 2012 v 02:59 +0100: > Hello Kohei, > > 2012/2/24 Kohei Yoshida : > > On Fri, 2012-02-24 at 14:59 -0500, Kohei Yoshida wrote: > >> Hi there, > >> > >> Please review the following commit > >> > >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=67f37b1de7e64

Re: What could be the problem when make gets into a loop in sax, continuously compiling facreg.cxx?

Eek, in tail_build it is even worse; there I now see it looping, continuously recompiling some dozens of files in sw, unoxml, sfx2 etc and rebuilding the dependencies of some libraries "[build DEP]". Sigh. It had been doing that for the whole night;) Maybe the best way out for me would be to make

Re: how to change the compile-time default settings, like page setting to B5

On Fri, 2012-03-02 at 09:26 +0800, huqitu du wrote: > I found > this > http://ask.libreoffice.org/question/433/how-do-i-change-my-default-font-from-times-new > > but this is not me wanted, I want to change default settings from > source file, so I can make a installer, and when I install Office

Re: [PUSHED 3-5] Simple UI fix

Michael Meeks píše v Čt 01. 03. 2012 v 05:53 +: > On Thu, 2012-03-01 at 00:28 +0100, Stefan Knorr (Astron) wrote: > > Can you please review the following one-liner for inclusion in the 3.5 > > branch? > > Sure - looks sensible; pushed :-) > > > (I don't know if it's too late for 3.5.1

[REVIEW 3-5-1] fdo#46181 fix installer language for zh-HK and zh-MO

Hi, This was a bug in our multi language Windows Installer, users from Hong Kong saw Simplified Chinese install wizard instead of Traditional Chinese. I tested and the same happened when locale was set to Macau S.A.R., so I made the patch below. Sorry for the sloppy indentation, I fixed that in th

Re: [PUSHED][3-5] don't try to update range names twice in ScDocument::TransferTab

Kohei Yoshida píše v Čt 01. 03. 2012 v 12:59 -0500: > On Thu, 2012-03-01 at 14:40 +0100, Markus Mohrhard wrote: > > Missed the attachment, You can find the commit at > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=1b93146d442bb8396126d6106f05a5bb0ee9fffa > > Pushed to the 3-5 branch wi

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #213 from Petr Mladek 2012-03-02 01:48:28 PST --- (In reply to comment #212) > (In reply to comment #211) > > When I hide a row and then copy the remaining rows Calc will also copy the > > hide > > rows. > > I'm not sure if this is

[Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #212 from Mihkel Tõnnov 2012-03-02 01:37:36 PST --- (In reply to comment #211) > When I hide a row and then copy the remaining rows Calc will also copy the > hide > rows. I'm not sure if this is a feature or a bug, but for now, the

Re: minutes of ESC call ...

On Fri, 2012-03-02 at 09:29 +0100, Stephan Bergmann wrote: > Micheal, I think I still don't understand what you are up to here. What > does logging have to do with XUnoTunnel ? Correct me if I'm wrong, but as soon as we start doing bridging - which is necessary for logging - then instea

Re: Weird code found by clang

> Probably it should be pFields != pFieldsEnd ? See original commit: > http://opengrok.libreoffice.org/xref/core/svtools/source/dialogs/addresstemplate.cxx?a=true&r=447a63cfb6d6d3dff63af72490a4c0b96295db6d#250 Ah yes. That variable had then been removed as unused (which it was), while the right th

Re: [PATCH] [PUSHED] fdo#46193: Let the user copy error message from error dialog

On Thu, 2012-03-01 at 22:56 +0100, Andras Timar wrote: > Copy to Clipboard what? My changes? You know what I mean. What do you > think, how this feature can be improved? Should it be a small icon > with help text "Copy text from this dialog to clipboard", or should it > be conditional? So

Re: Exception cost on string allocations ...

On 02/29/2012 05:29 PM, Michael Meeks wrote: So - I did some more analysis, and re-compiled all of LibreOffice both with and without the attached patch - analysing all 287 shared libraries we get: $ du -b -c ../../without-stripped/program/*.so | tail ... 171373684 total $ du -b -c

Copyright attribution

All of my past & future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license, including the go-oo code. Michael knew this already :-) Thanks Ken Foskey ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http:

Re: minutes of ESC call ...

On 03/01/2012 10:25 PM, Michael Meeks wrote: On Thu, 2012-03-01 at 20:47 +0100, Stephan Bergmann wrote: AA: + l/strace-alike for UNO (Stephan) On a more constructive note ;) the above already exists, in the form of

Re: [PATCH] instance of SV_DECL_VARARR_SORT -> std::set

As Matúš already is an established contributor I won't semi-automatically just push this patch, but want to wait for our C++ / STL experts (I am not) to actually review it... --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lis

Re: [PATCH] Replace String by OUString

Looks fine, and can the sFontName variable and the single assignment to it be deleted even, I don't see it being used anywhere? Does it still compile after that? Please check and follow up. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop

Re: [PATCH] [PUSHED] Convert SvPtrarr and tools/table.hxx usage in sw module.

[PUSHED] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Convert SvPtrarr and tools/table.hxx usage in sw module.

Thanks, pushed to master. (Small wish: Please format the git commit comment according to conventions: One short (less than 79 characters) first line that summarizes the commit, followed if necessary by a blank line and one or several paragraphs, with max 79 character line length.) --tml