[PUSHED] Re: [REVIEW][3-5-1][3-4] nsplugin broken due to typo

2012-02-29 Thread Rene Engelhard
On Thu, Mar 01, 2012 at 05:21:26AM +, Michael Meeks wrote: > > On Wed, 2012-02-29 at 23:24 +0100, Rene Engelhard wrote: > > -mxRemoteMSF->createInstance( > > ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccessw")) > > ), > > +mxRemoteMSF->cr

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread Tommy
On Thu, 01 Mar 2012 06:34:02 +0100, Michael Meeks wrote: On Wed, 2012-02-29 at 21:22 +0100, Tommy wrote: the 2nd longer freeze related to autocorrect is present in LibO 3.4.5 and earlier versions So - please file a bug, add your auto-correct file and the explanation of how to re

Re: unhandled exception / abort etc. ...

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 21:02 +0100, Stephan Bergmann wrote: > On 02/29/2012 05:58 PM, Michael Meeks wrote: > > And no crash handler. I guess I have a linkoo'd build perhaps something > > there is causing grief. > > Does not sound completely unlikely. I routinely use --disable-linkoo.

[PUSHED][3-5][REVIEW][3-5-1] fdo#46340 add more insanity to SdrGrafObj::getInputStream so it doesn't crash as much

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 22:56 +0100, Michael Stahl wrote: > propose the following for libreoffice-3-5, which fixes > a crash regression in 3.5 when saving pictures. ... > if you are thoroughly confused by now, then you have reached an accurate > understanding of the situation. So - the patch

License for my contributions

2012-02-29 Thread André Schnabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, although I stated this for my (minimal) contributions to LibO already, one contribtuion submitted in the past to go-oo did not have an explicit license statement. So here we go again: All of my past & future contributions to LibreOffice may be li

[PUSHED][3-5-1][3-4] nsplugin broken due to typo

2012-02-29 Thread Michael Meeks
On Thu, 2012-03-01 at 07:41 +0200, Tor Lillqvist wrote: > >You have my ack for -3-5-1 - I think you need one more. Nice catch. > > +1 from me. Picked to libreoffice-3-5-1 :-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant id

[PUSHED 3-5] Simple UI fix

2012-02-29 Thread Michael Meeks
On Thu, 2012-03-01 at 00:28 +0100, Stefan Knorr (Astron) wrote: > Can you please review the following one-liner for inclusion in the 3.5 branch? Sure - looks sensible; pushed :-) > (I don't know if it's too late for 3.5.1 already, but it's very Well - it's a bit of a cosmetic fi

Re: [REVIEW][3-5-1][3-4] nsplugin broken due to typo

2012-02-29 Thread Tor Lillqvist
>        You have my ack for -3-5-1 - I think you need one more. Nice catch. +1 from me. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: Adding file to icon theme

2012-02-29 Thread Michael Meeks
Hi Andrew, On Wed, 2012-02-29 at 20:07 +, Andrew Higginson wrote: > I want to add a file to the brand/ folder in the icon-themes, what > files do I need to edit in order to add this new file and so it gets > packed into the zips? There are two ways; either you need to mention it in an

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 21:22 +0100, Tommy wrote: > the 2nd longer freeze related to autocorrect is present in LibO 3.4.5 and > earlier versions So - please file a bug, add your auto-correct file and the explanation of how to repeat it, and perhaps mention it in Julien's similar issue: ht

Re: [REVIEW][3-5-1][3-4] nsplugin broken due to typo

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 23:24 +0100, Rene Engelhard wrote: > -mxRemoteMSF->createInstance( > ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.ucb.SimpleFileAccessw")) > ), > +mxRemoteMSF->createInstance( > ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.

Re: [REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 22:53 +, Noel Power wrote: > and for 3-5-1 ( or is it too late ) ? Looks a bit scary for 3.5.1 after RC1 surely ? or has this been well-tested elsewhere ? > if so a further +1 from me, coincidently I made the same change locally > today whilst investigating a l

[PATCH] Translate German comments

2012-02-29 Thread Philipp Weissenbacher
Hi all, I'd like to have a second set of eye-ball on these translations. Thanks, Philipp 0001-Translate-German-comments-fix-some-whitespace.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.

Re: [ANN] LibreOffice 3.5.1 RC1 available

2012-02-29 Thread Jean-Baptiste Faure
Hi Thorten, Le 29/02/2012 23:09, Thorsten Behrens a écrit : > Jean-Baptiste Faure wrote: >> AFAIK the fix for https://bugs.freedesktop.org/show_bug.cgi?id=46658 >> will be available only for the RC2. Am I right ? >> > Yep, good point - added to the Linux section of the release notes at > > htt

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 34209, which changed state. Bug 34209 Summary: Help - Credits dialog does not open https://bugs.freedesktop.org/show_bug.cgi?id=34209 What|Old Value |New Value ---

[Review 3-5] Simple UI fix

2012-02-29 Thread Stefan Knorr (Astron)
Hey, Can you please review the following one-liner for inclusion in the 3.5 branch? (I don't know if it's too late for 3.5.1 already, but it's very simple, so if there are enough people to review this, then having it in 3.5.1 would certainly be cool.) http://cgit.freedesktop.org/libreoffice/core/

Re: [REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Noel Power
and for 3-5-1 ( or is it too late ) ? if so a further +1 from me, coincidently I made the same change locally today whilst investigating a large import doc, definitely improved the import time Noel On 29/02/12 22:09, Michael Stahl wrote: the following fixes a performance regression in OOo 3.

Re: libreoffice + clang == success

2012-02-29 Thread Tor Lillqvist
FYI, I also decided to start doing the iOS builds using clang. Using --enable-werror I have had to add some more patches to boost and cppunit, for unused parameters, though. Will commit within some days. --tml ___ LibreOffice mailing list LibreOffice@lis

libreoffice + clang == success

2012-02-29 Thread Baptiste Daroussin
Hi I think some of you might be interested with this information: short version: libreoffice 3.5.x builds and run sucessfully with clang 3.0 and (upcoming) 3.1 long version: On FreeBSD I completly fail at building libreoffice 3.5 using gcc, may that be from the old 4.2.1 we provide by default or

[PUSHED 3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Bjoern Michaelsen
On Wed, Feb 29, 2012 at 11:09:28PM +0100, Michael Stahl wrote: > https://issues.apache.org/ooo/show_bug.cgi?id=115684 > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=7c7d5c0eec4efb95d18b735fb9df4754ba9d8b1f Looking good. Reviewed, pushed. Best, Bjoern __

[REVIEW][3-5-1][3-4] nsplugin broken due to typo

2012-02-29 Thread Rene Engelhard
Hi, The nsplugin is broken in 3.4.5 and 3.5.0 - we just discussed this on IRC: 22:58 <@_rene_> mmh, I think the nsplugin is broken 22:58 <@_rene_> in both 3.4.5 and 3.5.0 22:59 <@_rene_> opens a separate LO window with *startcenter* instead of the document 22:59 <@_rene_> no idea, but... 22:59 <

[UX advise] Key navigation in ValueSet controls

2012-02-29 Thread Matteo Casalin
Hi all, lately I've been working on ValueSet code, which is used in several controls (e.g. color selection, color configuration, columns selection in writer...), doing some cleanups. When the code will be more manageable I plan to fix some little bugs (selection/focus). Looking at the (no

Re: [ANN] LibreOffice 3.5.1 RC1 available

2012-02-29 Thread Thorsten Behrens
Jean-Baptiste Faure wrote: > AFAIK the fix for https://bugs.freedesktop.org/show_bug.cgi?id=46658 > will be available only for the RC2. Am I right ? > Yep, good point - added to the Linux section of the release notes at http://wiki.documentfoundation.org/Releases/3.5.1/RC1#Installation feel f

[REVIEW][3-5] i#115684 SfxItemPool performance regression

2012-02-29 Thread Michael Stahl
the following fixes a performance regression in OOo 3.4; i have actually fixed this before in OOo times but the fix somehow got lost in the CWS process overhead... ah, the issue for it was this: https://issues.apache.org/ooo/show_bug.cgi?id=115684 http://cgit.freedesktop.org/libreoffice/core/com

[REVIEW][3-5] fix STL assertion in vcl graphite code

2012-02-29 Thread Michael Stahl
this patch fixes a STL assertion in GraphiteLayout::expandOrCondense; since i don't know how the multitude of arrays in there are supposed to be used, i thought it's probably a good idea to check the size of the array that will be indexed in the next line, as opposed to one that isn't mentioned in

[REVIEW][3-5][3-4] more problems in SwRootFrm dtor

2012-02-29 Thread Michael Stahl
due to CWS swlayoutrefactoring there is another problem in SwRootFrm destruction, which has been found with valgrind: the children of the root frame are only destroyed by the base class destructors, so since every layout frame has a pointer to the SwRootFrm they may access its members after the Sw

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Eike Rathke
Hi Kevin, On Wednesday, 2012-02-29 15:38:30 +0100, Kevin André wrote: > >>      return ((nYear % 4) == 0) > >> -        && !(((nYear % 100) == 0) || ((nYear % 400) == 0)); > >> +        && (((nYear % 100) != 0) || ((nYear % 400) == 0)); > > Why still that many parentheses? Couldn't it be simply:

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Kevin André
On Wed, Feb 29, 2012 at 18:07, Lionel Elie Mamane wrote: > On Wed, Feb 29, 2012 at 03:38:30PM +0100, Kevin André wrote: >> On Wed, Feb 29, 2012 at 14:56, Lionel Elie Mamane wrote: >>> On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: >      return ((nYear % 4) == 0) -      

[REVIEW][3-5][3-5-1] fdo#46340 add more insanity to SdrGrafObj::getInputStream so it doesn't crash as much

2012-02-29 Thread Michael Stahl
propose the following for libreoffice-3-5, which fixes a crash regression in 3.5 when saving pictures. before fd95f1ab6220c6a530fd2e4e727417f504a5db51 it used to work this way: the getInputStream would call one of 3 duplicated GetDocumentStream methods, which would then create an XInputStream and

Re: SVG: debugging svg export

2012-02-29 Thread Chr. Rossmanith
Oh, I didn't pay attention to the closing '/>'. In the other cases was always closed with a . Christina Am 29.02.2012 11:02, schrieb Thorsten Behrens: Chr. Rossmanith wrote: The tag opened in the line marked with ** is never closed. (It should be closed by the destructor.) Hi Christina - h

Re: [ANN] LibreOffice 3.5.1 RC1 available

2012-02-29 Thread Lionel Elie Mamane
On Wed, Feb 29, 2012 at 10:14:43PM +0100, Jean-Baptiste Faure wrote: > AFAIK the fix for https://bugs.freedesktop.org/show_bug.cgi?id=46658 > will be available only for the RC2. Am I right ? Yes. -- Lionel ___ LibreOffice mailing list LibreOffice@list

Re: [ANN] LibreOffice 3.5.1 RC1 available

2012-02-29 Thread Jean-Baptiste Faure
Le 29/02/2012 15:26, Thorsten Behrens a écrit : > Dear Community, > > The Document Foundation is happy to announce the first release > candidate of LibreOffice 3.5.1. The upcoming 3.5.1 will be the first > in a series of frequent bugfix releases on our feature-packed 3.5 code > line. Please be awa

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-02-29 Thread Caolán McNamara
On Wed, 2012-02-29 at 17:11 +0100, Lubos Lunak wrote: > Do we actually have code that tries to gracefully handle running out of > memory? Because if not, and I doubt we realistically do[*] Its not O[U]String related, but FWIW vcl/unx/source/gdi/salbmp.cxx has some std::bad_alloc catches from comm

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread Tommy
On Wed, 29 Feb 2012 21:22:47 +0100, Tommy wrote: the 2nd longer freeze related to autocorrect is present in LibO 3.4.5 and earlier versions and 3.5.0 as well ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedes

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread Tommy
On Wed, 29 Feb 2012 14:50:32 +0100, Tommy wrote: again, using a "virgin" portable LibreOffice 3.5 ( http://www.winpenpack.com/main/download.php?view.1338 ) has no start-typing-freeze in my user experience. let me partially retract this statement... after more accurate test I found that even

Adding file to icon theme

2012-02-29 Thread Andrew Higginson
Hi, I want to add a file to the brand/ folder in the icon-themes, what files do I need to edit in order to add this new file and so it gets packed into the zips? Thanks -- Andrew Higginson ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org

Re: unhandled exception / abort etc. ...

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 05:58 PM, Michael Meeks wrote: And no crash handler. I guess I have a linkoo'd build perhaps something there is causing grief. Does not sound completely unlikely. I routinely use --disable-linkoo. Stephan ___ LibreOffice mailin

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-02-29 Thread Alex Thurgood
Le 29/02/2012 17:52, Stephan Bergmann a écrit : Hi Stephan, But if you do not pass it any configure switches, it should not build module libxslt at all? What branch, master or libreoffice-3-5? What do config.log and config_host.mk say about libxslt? Sorry, by default setup, I meant the OSX

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread julien2412
Hi Tommy, I read your post but I can answer only rarely from my day work + there were no questions (or perhaps I missed it :-) ) I'm compiling right now master sources because I reproduced this freeze on master too. I also must recompile from scratch 3.5 because I don't know if lightproof is used

Re: Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread Lubos Lunak
On Wednesday 29 of February 2012, Lionel Elie Mamane wrote: >So here's the patch for a boost-free OUString, with manually >implemented const_iterator. > +OSL_ASSERT( p <= s->getLength() ); OSL_ASSERT() is obsolete, use normal assert(). -- Lubos Lunak l.lu...@suse.cz _

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread Tommy
On Wed, 29 Feb 2012 13:38:37 +0100, julien2412 wrote: You're absolutely right ! :-) I opened a bug (see https://www.libreoffice.org/bugzilla/show_bug.cgi?id=46765). I attached the lsof diff and some detailed info about my config and the options I use in autogen.lastrun Julien. hi julien. did

Re: Small note on static analyzer, includes and build times...

2012-02-29 Thread Michael Meeks
Hi Albert, On Mon, 2012-02-27 at 23:07 +0100, Albert Thuswaldner wrote: > There has been some interesting discussions here on the mailinglist > about static analyzer tools, unused includes and the impact of the This looks like some interesting research :-) > Anyway, I have not analyzed t

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 36547, which changed state. Bug 36547 Summary: Impress: Rendering problems with some .odp files https://bugs.freedesktop.org/show_bug.cgi?id=36547 What|Old Value |New Value --

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36547, which changed state. Bug 36547 Summary: Impress: Rendering problems with some .odp files https://bugs.freedesktop.org/show_bug.cgi?id=36547 What|Old Value |New Value --

Re: Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread Lionel Elie Mamane
On Wed, Feb 29, 2012 at 02:57:09PM +0100, Stephan Bergmann wrote: > On 02/29/2012 11:49 AM, Lionel Elie Mamane wrote: >>2) I add a const_iterator interface to rtl::OUString. Instead of >>coding it manually to use iterateCodePoints, I again reuse the >>power of boost. >>That's also mor

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Lionel Elie Mamane
On Wed, Feb 29, 2012 at 03:38:30PM +0100, Kevin André wrote: > On Wed, Feb 29, 2012 at 14:56, Lionel Elie Mamane wrote: >> On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: >>>      return ((nYear % 4) == 0) >>> -        && !(((nYear % 100) == 0) || ((nYear % 400) == 0)); >>> +      

Re: unhandled exception / abort etc. ...

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 17:00 +0100, Stephan Bergmann wrote: > Strange. At least for my (--enable-dbgutil) master build, following the > instructions of fdo#46340 *does* lead to a restart with crash dialog and > document recovery. Interesting; well - I built with make ENABLE_SYMBOLS=true

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 11:56 AM, Alexander Thurgood wrote: My build on OSX Server 10.6.8 (x86) (default setup, no ports, etc) has been failing for the last 2 days in libxslt, cf. attached log file. But if you do not pass it any configure switches, it should not build module libxslt at all? What branch

Exception cost on string allocations ...

2012-02-29 Thread Michael Meeks
Hi guys, On Wed, 2012-02-29 at 15:28 +0100, Lubos Lunak wrote: > First, so that we have some numbers, libmswordlo.so debug build, but compiled > with -O2 -g0 : So - I did some more analysis, and re-compiled all of LibreOffice both with and without the attached patch - analysing all 287 s

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-02-29 Thread Lubos Lunak
On Wednesday 29 of February 2012, Stephan Bergmann wrote: > On 02/29/2012 03:28 PM, Lubos Lunak wrote: > > On Wednesday 29 of February 2012, Stephan Bergmann wrote: > >> However, there are also situations where bad input (malicious or > >> otherwise) would cause an application to request excessive

[REVIEW -3-5] RTF import of drwaing objects regressions

2012-02-29 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=bbef8b4 and http://cgit.freedesktop.org/libreoffice/core/commit/?id=fa9e867 These two commits implement RTF control words which were already supported in 3.4 - they apply cleanly to 3-5 in this order. Thanks, Miklos ___

Re: unhandled exception / abort etc. ...

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 03:29 PM, Michael Meeks wrote: So - it took me a while to get around to this, but luckily while I was chasing: https://bugs.freedesktop.org/show_bug.cgi?id=46340 I hit this. Interestingly on Linux we do get some (not particularly helpful) console debug: $

Re: [protoPATCH] "safe" numeric casts with explicit min/max

2012-02-29 Thread Kohei Yoshida
HI Stephan, On Wed, 2012-02-29 at 15:25 +0100, Stephan Bergmann wrote: > On 02/29/2012 12:13 PM, Lionel Elie Mamane wrote: > > Background: we have in sc/source/filter/inc/ftools.hxx supposedly > > "safe" casts that are (according to the Doxygen documentation) > > supposed to be safer than just sta

Re: [protoPATCH] "safe" numeric casts with explicit min/max

2012-02-29 Thread Kohei Yoshida
On Wed, 2012-02-29 at 11:50 +, Caolán McNamara wrote: > On Wed, 2012-02-29 at 12:13 +0100, Lionel Elie Mamane wrote: > > Background: we have in sc/source/filter/inc/ftools.hxx supposedly > > "safe" casts that are (according to the Doxygen documentation) > > supposed to be safer than just static

Re: Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 03:28 PM, Lubos Lunak wrote: On Wednesday 29 of February 2012, Stephan Bergmann wrote: However, there are also situations where bad input (malicious or otherwise) would cause an application to request excessive amounts of memory to do a single task (e.g., open a document), and at l

Re: [PATCH] fdo#46343 fix opening of 8-bit encoded filenames

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 12:29 PM, Michael Meeks wrote: Looks ok to me; the problem is that we might give people the idea that not using UTF-8 for file-names everywhere is a supported and/or legitimate configuration option - when it is -emphatically- not :-) At least as long as everything is consi

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Kevin André
On Wed, Feb 29, 2012 at 14:56, Lionel Elie Mamane wrote: > On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: > >> From 0666b5dca1a210ce7abc61a522a59c48661fe664 Mon Sep 17 00:00:00 2001 >> From: Kohei Yoshida >> Date: Tue, 28 Feb 2012 22:01:52 -0500 >> Subject: [PATCH] Correctly calcu

unhandled exception / abort etc. ...

2012-02-29 Thread Michael Meeks
Hi there, On Tue, 2012-02-21 at 16:55 +0100, Stephan Bergmann wrote: > On 02/21/2012 04:07 PM, Michael Meeks wrote: > >> In my experience, such exceptions typically indicate a programming error > >> (either in actual program code, or in the way the bits of the program > >> are combined into an ins

Checking string allocations (was Re: String literals, ASCII vs UTF-8)

2012-02-29 Thread Lubos Lunak
First, so that we have some numbers, libmswordlo.so debug build, but compiled with -O2 -g0 : 4627576 - without any extra checks in OUString 4625248 - with abort() 4642216 - with std::bad_alloc Yes, adding abort() there somehow makes it a tiny bit smaller, search me why. For std::bad_alloc

[ANN] LibreOffice 3.5.1 RC1 available

2012-02-29 Thread Thorsten Behrens
Dear Community, The Document Foundation is happy to announce the first release candidate of LibreOffice 3.5.1. The upcoming 3.5.1 will be the first in a series of frequent bugfix releases on our feature-packed 3.5 code line. Please be aware that LibreOffice 3.5.1 RC1 is not ready for production us

Re: [protoPATCH] "safe" numeric casts with explicit min/max

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 12:13 PM, Lionel Elie Mamane wrote: Background: we have in sc/source/filter/inc/ftools.hxx supposedly "safe" casts that are (according to the Doxygen documentation) supposed to be safer than just static_cast. As fdo#39589 uncovered, they are actually so buggy as to be *less* safe.

Re: Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 02:57 PM, Stephan Bergmann wrote: On 02/29/2012 11:49 AM, Lionel Elie Mamane wrote: 2) I add a const_iterator interface to rtl::OUString. Instead of coding it manually to use iterateCodePoints, I again reuse the power of boost. But I have in my git history a manually-coded version

Re: [PUSHED] Re: [REVIEW 3-5][PATCH] Fix leap year calculation

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 14:53 +0100, Michael Stahl wrote: > pushed the fix plus a unit test for leap years to master, ^ Lovely ! :-) Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___

Re: [PUSHED][PATCH] fix building dictionaries when PERL_UNICODE environment

2012-02-29 Thread Caolán McNamara
On Fri, 2012-02-24 at 17:28 +0100, Petr Vorel wrote: > First I thought it would be better to recode all of them to utf8. But > these files are taken from ispell, aren't they? Do we want to increase > diversity from upstream? For hunspell dictionaries, the .aff files contain the encoding for the

Re: Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 11:49 AM, Lionel Elie Mamane wrote: 2) I add a const_iterator interface to rtl::OUString. Instead of coding it manually to use iterateCodePoints, I again reuse the power of boost. But I have in my git history a manually-coded version based on iterateCodePoints if for som

Re: [REVIEWED 3-5-1][PATCH] Fix leap year calculation

2012-02-29 Thread Lionel Elie Mamane
On Tue, Feb 28, 2012 at 10:10:10PM -0500, Kohei Yoshida wrote: > From 0666b5dca1a210ce7abc61a522a59c48661fe664 Mon Sep 17 00:00:00 2001 > From: Kohei Yoshida > Date: Tue, 28 Feb 2012 22:01:52 -0500 > Subject: [PATCH] Correctly calculate leap year. > With the old code, year 2000 would not be a le

[PUSHED] Re: [REVIEW 3-5][PATCH] Fix leap year calculation

2012-02-29 Thread Michael Stahl
On 29/02/12 04:10, Kohei Yoshida wrote: > Hi there, > > The attached patch fixes a bug in our current leap year calculation > code. It is based on the algorithm posted on wikipedia[1], and seems to > correctly identify year 2000 as a leap year. > > Without this, Calc would convert 2000-2-29 into

Re: String literals, ASCII vs UTF-8

2012-02-29 Thread Noel Grandin
I would expect that filters should be validating their inputs. By the time that we get a bad_alloc, it's too late to recover properly. Unless we're talking about someday running filters in a separate process, and then validating the document they generate, in which case the main process would re

Re: String literals, ASCII vs UTF-8

2012-02-29 Thread Eike Rathke
Hi Stephan, On Wednesday, 2012-02-29 08:42:35 +0100, Stephan Bergmann wrote: > However, there are also situations where bad input (malicious or > otherwise) would cause an application to request excessive amounts > of memory to do a single task (e.g., open a document), and at least > in theory th

Re: [REVIEW 3-5, 3-5-1] Fix leap year calculation

2012-02-29 Thread Niko Rönkkö
Hi The fix is correct so +1 from me if that counts. -- RN ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #209 from Ulrich Moser 2012-02-29 05:17:59 PST --- Added Bug 46769 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug.

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Noel Power changed: What|Removed |Added Depends on|46498 | --- Comment #208 from Noel Power 2012-02-

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread julien2412
You're absolutely right ! :-) I opened a bug (see https://www.libreoffice.org/bugzilla/show_bug.cgi?id=46765). I attached the lsof diff and some detailed info about my config and the options I use in autogen.lastrun Julien. -- View this message in context: http://nabble.documentfoundation.org/Tr

Re: [REVIEW 3-5][PATCH] Fix leap year calculation

2012-02-29 Thread Eike Rathke
Hi Kohei, On Tuesday, 2012-02-28 22:10:10 -0500, Kohei Yoshida wrote: > The attached patch fixes a bug in our current leap year calculation > code. It is based on the algorithm posted on wikipedia[1], and seems to > correctly identify year 2000 as a leap year. Sure, count my sign-off in for all

Re: python gdb plugin traceback: No type named sal_uInt16.

2012-02-29 Thread Riccardo Magliocchetti
Hi Michael, Michael, Il 29/02/2012 13:02, Michael Stahl ha scritto: On 29/02/12 12:48, Michael Meeks wrote: Hi Riccardo, On Wed, 2012-02-29 at 09:23 +0100, Riccardo Magliocchetti wrote: i have this traceback every time i open a core. It does not harm but it is a bit annoying. Does anyone have

Re: Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread Rene Engelhard
Hi, On Wed, Feb 29, 2012 at 12:48:16PM +0100, Lionel Elie Mamane wrote: > On Wed, Feb 29, 2012 at 03:24:33AM -0800, julien2412 wrote: > > Just for the remind but perhaps you had already noticed the Boost version > > included in LO is 1.44 > > There's a flag in autogen to use Boost from system (--w

Re: python gdb plugin traceback: No type named sal_uInt16.

2012-02-29 Thread Michael Stahl
On 29/02/12 12:48, Michael Meeks wrote: > Hi Riccardo, > > On Wed, 2012-02-29 at 09:23 +0100, Riccardo Magliocchetti wrote: >> i have this traceback every time i open a core. It does not harm but it >> is a bit annoying. Does anyone have a clue on how to fix that? > > I guess the code is i

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 39026, which changed state. Bug 39026 Summary: Recent Documents list does not work https://bugs.freedesktop.org/show_bug.cgi?id=39026 What|Old Value |New Value ---

Re: [protoPATCH] "safe" numeric casts with explicit min/max

2012-02-29 Thread Caolán McNamara
On Wed, 2012-02-29 at 12:13 +0100, Lionel Elie Mamane wrote: > Background: we have in sc/source/filter/inc/ftools.hxx supposedly > "safe" casts that are (according to the Doxygen documentation) > supposed to be safer than just static_cast. As fdo#39589 uncovered, > they are actually so buggy as to

Re: python gdb plugin traceback: No type named sal_uInt16.

2012-02-29 Thread Michael Meeks
Hi Riccardo, On Wed, 2012-02-29 at 09:23 +0100, Riccardo Magliocchetti wrote: > i have this traceback every time i open a core. It does not harm but it > is a bit annoying. Does anyone have a clue on how to fix that? I guess the code is in solenv/gdb/libreoffice/ > #1 0x7f1648443b0

Re: Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread Lionel Elie Mamane
On Wed, Feb 29, 2012 at 03:24:33AM -0800, julien2412 wrote: > Just for the remind but perhaps you had already noticed the Boost version > included in LO is 1.44 > There's a flag in autogen to use Boost from system (--with-system-boost) see > thread http://nabble.documentfoundation.org/About-Boost-1

Re: [PUSHED:3-5-1] PostgreSQL regression wrt 3.5.0: privileges via groups

2012-02-29 Thread Lionel Elie Mamane
On Mon, Feb 27, 2012 at 11:01:56PM +0100, Michael Stahl wrote: > On 27/02/12 14:16, Michael Meeks wrote: >> On Mon, 2012-02-27 at 13:45 +0100, Lionel Elie Mamane wrote: >>> Forgot to regenerate the patch after last-minute fix before sending >>> email... Missing closing parenthesis in previous patc

Re: EasyHack: perl / autogen.sh should backup autogen.lastrun

2012-02-29 Thread Michael Meeks
Hi there, On Wed, 2012-02-29 at 11:58 +0100, Thomas Collerton wrote: > this patch accomplishes what the EasyHack requests =) Thanks - pushed it :-) Personally, I'd have split out the 'write_args' type functionality below that into a method of it's own, and added a read_args / wri

Re: [PATCH] fdo#46343 fix opening of 8-bit encoded filenames

2012-02-29 Thread Michael Meeks
On Tue, 2012-02-28 at 20:59 +0100, Andras Timar wrote: > The attached patch is from bugzilla, Alex Prokofiev made it. It looks > OK to me, but I'd like to ask a 2nd review before push. > > https://bugs.freedesktop.org/show_bug.cgi?id=46434 Looks ok to me; the problem is that we might giv

Re: [PATCH] convert SV_DECL_PTRARR_DEL to boost::ptr_vector in sc/inc/viewuno.hxx

2012-02-29 Thread Noel Grandin
Hi New patch with recommended fixes attached. I wonder, would it not be better to convert this type of listener-list thing to boost::ptr_set? - no chance of accidentally adding duplicates - O(1) deletion Regards, Noel Grandin On 2012-02-24 18:33, Ivan Timofeev wrote: Hi Noel, From: Noel G

Re: Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread julien2412
Just for the remind but perhaps you had already noticed the Boost version included in LO is 1.44 There's a flag in autogen to use Boost from system (--with-system-boost) see thread http://nabble.documentfoundation.org/About-Boost-1-48-td3757059.html. There's the Spirit history here : http://www.bo

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 39026, which changed state. Bug 39026 Summary: Recent Documents list does not work https://bugs.freedesktop.org/show_bug.cgi?id=39026 What|Old Value |New Value ---

[protoPATCH] "safe" numeric casts with explicit min/max

2012-02-29 Thread Lionel Elie Mamane
Background: we have in sc/source/filter/inc/ftools.hxx supposedly "safe" casts that are (according to the Doxygen documentation) supposed to be safer than just static_cast. As fdo#39589 uncovered, they are actually so buggy as to be *less* safe. Back in November, I wrote a prototype _actually_ saf

Re: Trying to understand why LO seems freezed for some seconds when a module is started

2012-02-29 Thread Alexander Thurgood
Le 28/02/12 11:56, Michael Meeks a écrit : Hi all, > It'd be great to get a bug opened to collect the detailed information > on this. Clearly we don't want such delays when you start typing. > Just to add my 2c worth, I can also confirm that this happens on Mac too, and always on first

EasyHack: perl / autogen.sh should backup autogen.lastrun

2012-02-29 Thread Thomas Collerton
Hello all, this patch accomplishes what the EasyHack requests =) From f8d4e76d5ac123264f22a79ecf6dcc766c3bab5d Mon Sep 17 00:00:00 2001 From: Thomas Collerton Date: Wed, 29 Feb 2012 11:50:02 +0100 Subject: [PATCH] fdo#46565: perl / autogen.sh should backup autogen.lastrun --- autogen.sh |4 +

Re: String literals, ASCII vs UTF-8

2012-02-29 Thread Stephan Bergmann
On 02/29/2012 10:57 AM, Michael Meeks wrote: Having said all this - I think we can agree that if we are calling this new 'createFromAscii_WithLength' method - which is (currently) only called during these magic constructors for compile time constants, that the chance of having a 4Gb compi

Re: [REVIEW 3-5, 3-5-1] Make libxslt link the right libxml on mac ppc

2012-02-29 Thread Alexander Thurgood
Le 28/02/12 21:17, Stephan Bergmann a écrit : Hi Stephan, > > But that is inside an .IF "$(OS)"=="WNT" block, isn't it? Also, at > least for my Mac OS X 10.6 x86 tests, the existing libxslt/makefile.mk > seemed to already work fine with --without-system-libxml (probably due > to the > My buil

Using a real parser generator to parse numbers (and dates)

2012-02-29 Thread Lionel Elie Mamane
In the context of fdo#41166 (a bug in how our numbers/date parser handles ambiguities), I thought "wouldn't it be better if we used a proper parser generator and wrote a proper grammar instead of a hand-coded parser"? It would be easier to debug, easier to maintain, easier to read, ... and thus pro

Re: dropping STAR_ENABLE_FILE_LOCKING environmental variable

2012-02-29 Thread Michael Meeks
On Wed, 2012-02-29 at 10:23 +, Caolán McNamara wrote: > We don't seem to have documented STAR_ENABLE_FILE_LOCKING anywhere, and > random web searches don't seem to show that its generally known, :-) > Any uses of it, e.g. now defunct > http://cgit.freedesktop.org/libreoffice/build/t

Re: Question: How do I rasterize an SVG to a BitmapEx

2012-02-29 Thread Thorsten Behrens
Andrew Higginson wrote: > So if I am getting the SVG from the brand/ folder in the galaxy icon theme, > what should I use to read it? > Hi Andrew, ok, some code pointers - look into vcl/source/app/brand.cxx, Application::LoadBrandBitmap() on how to get to the brand dir - note those $BRAND_BASE_DI

Re: String literals, ASCII vs UTF-8

2012-02-29 Thread Stephan Bergmann
On 02/28/2012 02:39 PM, Stephan Bergmann wrote: On 02/28/2012 12:30 PM, Lubos Lunak wrote: PS: Any idea why ' OUString foo() { return "foo";} ' does not work, even though the ctor is not explicit? I can't recall a reason why a return value would need to be different from the other cases. Looks

dropping STAR_ENABLE_FILE_LOCKING environmental variable

2012-02-29 Thread Caolán McNamara
digging around I came across getenv("STAR_ENABLE_FILE_LOCKING") in tools. I was aware of SAL_ENABLE_FILE_LOCKING, but unaware of STAR_ENABLE_FILE_LOCKING We don't seem to have documented STAR_ENABLE_FILE_LOCKING anywhere, and random web searches don't seem to show that its generally known, Any u

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-29 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #207 from tommy27 2012-02-29 02:18:50 PST --- @Raphaël I think that all 3.4 most annying bugs the will not be fixed in LibO 3.4.6 (last release of the 3.4.x series) will be then moved into the 3.5 list -- Configure bugmail: https://

[PATCH] Convert SV_DECL_VARARR_SORT and SV_IMPL_VARARR_SORT with std::set

2012-02-29 Thread Bartosz
Hi. I forgot to add [PATCH] tag. I converted the SV_DECL_VARARR_SORT and SV_IMPL_VARARR_SORT with ::std::set. I also made some optimization (cppcheck). Could you please check this patch and push it into libreoffice. License statement is on file. Thanks in advance Bartosz diff --git a/edit

[UX ADVICE] Key navigation in ValueSet controls

2012-02-29 Thread Matteo Casalin
Hi all, lately I've been working on ValueSet code, which is used in several controls (e.g. color selection, color configuration, columns selection in writer...), doing some cleanups. When the code will be more manageable I plan to fix some little bugs (selection/focus). Looking at the (no

  1   2   >