[PUSHED] Re: [REVIEW in progress] dereference of a null pointer in xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx

2012-02-17 Thread julien2412
I commited and pushed on master only the fix you quoted (commit 140c90f4302303faf146c4a509acfb1d21c26164). Now if I well understood what you said, this function needs more work. So I suppose I don't need to ask if it could be useful to push this fix on 3.5 Julien. -- View this message in context:

[PATCH] Remove unused code (13)

2012-02-17 Thread Elton Chung
Hi, This patch removes 9 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com --

Re: [PATCH] SwDocStub now prints out parameters

2012-02-17 Thread Mihályi Dániel
Hi, It is, :) but i don't understand something. If it is about creating a child class then why is that we have to have not only virtual methods? With regards, Daniel 2012/2/18 Markus Mohrhard : > Hello Daniel > >> What do you mean by relevant methods? >> > > Good question. I think that at least

Re: [PATCH] Translated german comments in sw/source/core/layout/

2012-02-17 Thread Thorsten Behrens
Philipp Weissenbacher wrote: > BTW: I'm reviewing the first five patches. > Started from the other end, patch 22 and 21 are pushed to master. Slightly tweaked a few things, mostly if instead of when (a rather common error we Germans commit), and sometimes went a bit further away from a verbatim t

Disappearing graphics in Write: where to look (bug 33393)

2012-02-17 Thread Andrew Douglas Pitonyak
While updating LO documentation using the latest release of LO, most of the embedded graphics just disappeared so I have been looking at this: https://www.libreoffice.org/bugzilla/show_bug.cgi?id=33393 I spent a few hours poking around the generated files trying to understand what happened.

Re: [PATCH] SwDocStub now prints out parameters

2012-02-17 Thread Markus Mohrhard
Hello Daniel > What do you mean by relevant methods? > Good question. I think that at least all protected and public method should be in there but it should not be a problem if there are also the private methods in it. Cedric and I had some rough ideas in Brussels what we want to do and now we n

Re: [ANN] Referencing bugs in commits

2012-02-17 Thread Markus Mohrhard
Hey, 2012/2/17 Lionel Elie Mamane : > On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote: > >> whenever you are committing / pushing to git, and you >> reference the bugs.freedesktop.org bug in the commit message, it will >> automatically appear as a comment in the bug :-) > > It seems

[PATCH] Removed unused code from avmedia module

2012-02-17 Thread Bartolomé Sánchez Salado
Hi, I removed unused code from avmedia module (unusedcode.easy) Removed functions: avmedia::priv::MediaWindowBaseImpl::getStopTime() const avmedia::priv::MediaWindowBaseImpl::setRate(double) avmedia::priv::MediaWindowBaseImpl::setStopTime(double) Bartolomé Sánchez. From 5973baf060e6923fdac8a6a74

Re: [PUSHED] Remove unused code in core/svx/source/dialog/_contdlg.cxx

2012-02-17 Thread Thorsten Behrens
Thanks a lot, pushed. Keep 'em coming, -- Thorsten pgpiLVIhoD1ix.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ANN] Referencing bugs in commits

2012-02-17 Thread Jan Holesovsky
Hi Lionel, Lionel Elie Mamane píše v Pá 17. 02. 2012 v 09:23 +0100: > > whenever you are committing / pushing to git, and you > > reference the bugs.freedesktop.org bug in the commit message, it will > > automatically appear as a comment in the bug :-) > > It seems not to happen this morning. In

[REVIEW in progress] dereference of a null pointer in xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx

2012-02-17 Thread Thorsten Behrens
julien2412 wrote: > Here again a message I caught from clang : > /home/julien/compile-libreoffice/libo/xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx:152:26: > warning: Access to field 'parent' results in a dereference of a null pointer > (loaded from variable 'pEncryptedData') > xmlNo

Re: [PATCH] SwDocStub now prints out parameters

2012-02-17 Thread Mihályi Dániel
Hi, What do you mean by relevant methods? With regards, Daniel 2012/2/17 Markus Mohrhard : > Hey, > > 2012/2/15 Markus Mohrhard : >> Hey, >> >> thanks a lot for your great work here. >> > > > after discussing the problems a bit more with Cedric we noticed that > it might be better to try first

[REVIEW][3-4][3-5] Re: [REVIEW 3-4] fdo#39510 crash on closing document with footnotes

2012-02-17 Thread Michael Stahl
On 22/09/11 18:51, Bjoern Michaelsen wrote: > Hi Cedric, Hi Caolan, > > could you please review: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=ac1912ecb13709082026428d2b2a56c4915b939f > > for backporting to -3-4? It kills the footnotes before killing the rest > of the layout saving

[PATCH] Remove unused code in core/svx/source/dialog/_contdlg.cxx

2012-02-17 Thread Björgvin Ragnarsson
See attached file, Björgvin Ragnarsson From 200d27b57eb9e6439c85d49a0cd7870bb6eacab1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rgvin=20Ragnarsson?= Date: Fri, 17 Feb 2012 23:19:28 + Subject: [PATCH] Remove unused code in core/svx/source/dialog/_contdlg.cxx --- svx/source/dialog/_con

[REVIEW][3-5] misc fixes for -3-5

2012-02-17 Thread Michael Stahl
some misc commits, mostly crashes fixed while loading ~2000 presumed ODT documents (looking at actual patches reveals expecting people to set bug attachment mime types correctly is unrealistic), proposed for libreoffice-3-5: plugin crashes: http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [PUSHED] Remove unused methods from PDFI

2012-02-17 Thread Kate Goss
On 17 February 2012 11:21, Thorsten Behrens wrote: > Kate Goss wrote: > > Yes, he did - thanks Thorsten. Christian - if you are able to set me up > > with access, that would be lovely :) > > > Hi Kate, > > glad you hear you want to look into this - first step is to clone > the git repo > > git cl

Re: Adding Extension for Experimental Thai Spelling

2012-02-17 Thread Richard Wordingham
On Fri, 17 Feb 2012 14:10:21 + Caolán McNamara wrote: > On Thu, 2012-02-16 at 23:24 +, Richard Wordingham wrote: > Indeed, yeah, I suppose, assuming its as complicated as "Thai", that > the right direction would be for someone to write for icu new > dictionary-based breakiterators for the

Re: [PATCH] SwDocStub now prints out parameters

2012-02-17 Thread Markus Mohrhard
Hey, 2012/2/15 Markus Mohrhard : > Hey, > > thanks a lot for your great work here. > after discussing the problems a bit more with Cedric we noticed that it might be better to try first a version where we create empty stub methods for all relevant methods. Do you think that is something you coul

Re: Tinderbox failure, Win-x86@7-MinGW, MASTER, last success: 2012-02-17 07:15:03

2012-02-17 Thread Rene Engelhard
On Fri, Feb 17, 2012 at 09:00:31PM +, ke...@suse.cz wrote: [...] > d40a7f1 make gengal work again is the breaking one. > [ info ALL ] Currently known executables: bestreversemap bmp bmpsum > cppunit/cppunittester crashrep_com g2g gencoll_rule genconv_dict gendict > genindex_data guiload

Re: [PATCH] Removed unused code from vcl module

2012-02-17 Thread Michael Meeks
On Thu, 2012-02-16 at 17:13 +0100, Dézsi Szabolcs wrote: > Hi! I removed unused code from vcl module (used unusedcode.easy) Pushed; thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ Libr

[PUSHED] Removed unused code from svl, svtools and sfx2

2012-02-17 Thread Michael Meeks
On Thu, 2012-02-16 at 14:11 +0100, Dézsi Szabolcs wrote: > I removed some unused code from modules svl, svltools and sfx2 Pushed; thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreO

Re: Changing chart defaults in calc

2012-02-17 Thread Michael Meeks
Hi Dominic, On Thu, 2012-02-16 at 11:30 -0500, Dominic Woolf wrote: > I'm new to this list and don't know my way around the LO code or data > files, but I'm happy to help put some time into developing a solution > to this problem if someone could give me a few pointers about how to > get started.

[PUSHED] Remove unused code in SvxSearchDialog

2012-02-17 Thread Michael Meeks
Hi there, On Thu, 2012-02-16 at 21:39 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Thanks - pushed :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___

[PUSHED] EasyHack 42790: get rid of PRODUCT define/build system variable

2012-02-17 Thread Michael Meeks
Hi there, On Wed, 2012-02-15 at 23:36 -0800, jumbo444 wrote: > This is my first patch, so please let me know if I did something wrong. :) It looks lovely :-) > Preprocessor constant PRODUCT is replaced by !DBG_UTIL > Contributed under LGPLv3+ / MPL 1.1 or later. Thanks for that

Re: windows / cygwin - libreoffice-3-5 compiler error

2012-02-17 Thread Michael Meeks
Hi Walter, On Fri, 2012-02-17 at 22:10 +0100, walter wrote: > Compiling: np_sdk/mozsrc/npwin.cpp > > C:/LO35/np_sdk/mozsrc/npwin.cpp(171) : error C2440: 'return' : cannot > convert from 'const char *' to 'char *' I just pushed an explicit cast to master that (I hope) 'fixes' this, at lea

Re: windows / cygwin - libreoffice-3-5 compiler error

2012-02-17 Thread Rene Engelhard
On Fri, Feb 17, 2012 at 10:23:16PM +0100, Rene Engelhard wrote: > On Fri, Feb 17, 2012 at 10:10:19PM +0100, walter wrote: > >C:/LO35/np_sdk/mozsrc/npwin.cpp(171) : error C2440: 'return' : cannot > >convert from 'const char *' to 'char *' > > Yes. Make that const char* in npwin.cxx. Forgot

Re: [REVIEW-3-5] fdo#40665 use CJKAnalyzer for ko, zh-CN, and zh-TW, too

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 21:49 +0100, Andras Timar wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=7636d37f8f9c53d694c4fe38581f3b495d53670e > Caolán suggested this fix in the CLucene thread. I tried it, and > indeed, it solved fdo#40665 (free text search did not work in Chinese > hel

windows / cygwin - libreoffice-3-5 compiler error

2012-02-17 Thread walter
= (1/1) Building module np_sdk = Entering /cygdrive/c/LO35/np_sdk/mozsrc Compiling: np_sdk/mozsrc/npwin.cpp C:/LO35/np_sdk/mozsrc/npwin.cpp(171) : error C2440: 'return' : cannot convert from 'const char *' to 'char *' Conversion loses qualifiers dmake:

dereference of a null pointer in xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx

2012-02-17 Thread julien2412
Hello, Llvm compiler brings a lot of useful info about potential problems. Here again a message I caught from clang : /home/julien/compile-libreoffice/libo/xmlsecurity/source/xmlsec/nss/xmlencryption_nssimpl.cxx:152:26: warning: Access to field 'parent' results in a dereference of a null pointer (

[REVIEW-3-5] fdo#40665 use CJKAnalyzer for ko, zh-CN, and zh-TW, too

2012-02-17 Thread Andras Timar
Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=7636d37f8f9c53d694c4fe38581f3b495d53670e Caolán suggested this fix in the CLucene thread. I tried it, and indeed, it solved fdo#40665 (free text search did not work in Chinese help). Please cherry pick to 3-5. Thanks, Andras ___

Re: [PATCH] fdo#42790: Easyhack: get rid of PRODUCT define/build system variable

2012-02-17 Thread jumbo444
I updated issue page to propose this patch. Laurent BP - LibreOffice 3.5.0 -- View this message in context: http://nabble.documentfoundation.org/PATCH-fdo-42790-Easyhack-get-rid-of-PRODUCT-define-build-system-variable-tp3749409p3754736.html Sent from the Dev mailing list archive at Nabble.co

Re: [REVIEWED-3-5] fdo#46167 fix path of shell extension dll in registry

2012-02-17 Thread khagaroth
Good news, the crashloop I had was still with a 3.5beta and I didn't test since. Now I repeated the test with the release version of 3.5 and it's not crashing anymore and the property page is working. ___ LibreOffice mailing list LibreOffice@lists.freedes

Re: Hosting LibreOffice online

2012-02-17 Thread drew
On Fri, 2012-02-17 at 17:54 +0100, Sophie Gautier wrote: > Hi Drew, > On 16/02/2012 06:50, drew wrote: > [...] > > > > Just to wrap this thread up, I suppose. > > > > Well, after adding --enable-gtk3 it works. > > > > Had some issues related to the firewall, but got around that - turned it > > off

Re: [REVIEWED-3-5] fdo#46167 fix path of shell extension dll in registry

2012-02-17 Thread Andras Timar
2012/2/17 khagaroth : > Reading this, it should fix my bug > https://bugs.freedesktop.org/show_bug.cgi?id=43708, if so, please > close it. > > Also a warning, make sure to actually test it on Windows, when I > locally fixed this by editing the installer with Orca, I got a > Explorer crashloop cause

Re: [REVIEWED-3-5] fdo#46167 fix path of shell extension dll in registry

2012-02-17 Thread khagaroth
Reading this, it should fix my bug https://bugs.freedesktop.org/show_bug.cgi?id=43708, if so, please close it. Also a warning, make sure to actually test it on Windows, when I locally fixed this by editing the installer with Orca, I got a Explorer crashloop caused by shlxthdl.dll after installatio

[PUSHED] Removed unused code

2012-02-17 Thread Michael Meeks
Hi Peter, On Fri, 2012-02-17 at 18:15 +0100, Petr Vorel wrote: > I removed a little bit of unused code (unusedcode.easy). Thanks for that, I pushed it ! :-) > This is my first contribution. This and any other is of course made > available under the MPL/LGPLv3+. Do you think you

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

2012-02-17 Thread Michael Meeks
Hi Matus, On Wed, 2012-02-15 at 01:05 +0100, Matúš Kukan wrote: > It's going quite well. With tml's patch [1] we can add more. > He is doing great job, mostly in the android branch as he already said. Cool :-) yep, I saw. > Current tail_build "blocker" is connectivity/. Peter was working

[REVIEWED] vcl: consolidate common objects in Library_vcl.mk

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 17:54 +0100, Riccardo Magliocchetti wrote: > Store objects from vcl/generic and vcl/headless in a couple of > variables so we don't need to repeat the quite long list for every > target that uses them. Drat - I just near duplicated as I pushed your other patch :-) >

Re: [PATCH] Translated german comments in sw/source/core/layout/

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 11:26 +0100, David Vogt wrote: > We're still not quite done, but here's what we have so far. Wow - this looks like some brilliant work :-) I imagine when Cedric gets over being flamed by some intersection of those guys who want a new UI, but don't want the UI to chan

[PATCH] Removed unused code

2012-02-17 Thread Petr Vorel
Hi there, I removed a little bit of unused code (unusedcode.easy). This is my first contribution. This and any other is of course made available under the MPL/LGPLv3+. Regards, Petr >From 445f0c71e523f06f42f622d401b8d9af22b159d3 Mon Sep 17 00:00:00 2001 From: Petr Vorel Date: Fri, 17 Feb 201

Re: [OUTDATED][PATCH]fdo#44516 improved label and business card document creation (2/3)

2012-02-17 Thread Ivan Timofeev
Marking this as [OUTDATED] for convenience, I don't know what is the preferred tag for the outdated patches. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

2012-02-17 Thread Michael Meeks
Hi Tor, On Tue, 2012-02-14 at 19:23 +0200, Tor Lillqvist wrote: > In the feature/android branch I have added the fw[eiklm], sfx, sb, svt > and tk libraries to libmerged. Working on verifying that the last > addition didn't break anything; I found a nice direct reference to the > name "tk" in > ht

[PATCH]fdo44516 improved label and business card document creation (final)

2012-02-17 Thread Winfried Donkers
Attached the final fix for the problems that showed after my first patch for fdo44516. Fix 2/3 that I submitted on februari 16 need not be pushed; changes in that fix are overwritten by the final fix. WinfriedFrom cec5b45badbc8755d091fbc3b7574cd60d7b504b Mon Sep 17 00:00:00 2001 From: Winfried D

Re: [PATCH] Translated german comments in sw/source/core/layout/

2012-02-17 Thread Philipp Weissenbacher
Hello you two! Thanks for the big amount of work. I know how tiresome it is to translate this oververbose German to something that makes sense in English. That and the technical jargon make translating it quite time intensive. So kudos for that much work! I think that it'd be much easier to revie

[PATCH] vcl: consolidate common objects in Library_vcl.mk

2012-02-17 Thread Riccardo Magliocchetti
Store objects from vcl/generic and vcl/headless in a couple of variables so we don't need to repeat the quite long list for every target that uses them. The vcl/headless files currently are used only by the android port but the plan is to share them with the headless stuff i'm cooking. I've do

Re: Hosting LibreOffice online

2012-02-17 Thread Sophie Gautier
Hi Drew, On 16/02/2012 06:50, drew wrote: [...] Just to wrap this thread up, I suppose. Well, after adding --enable-gtk3 it works. Had some issues related to the firewall, but got around that - turned it off (not likely a good long term solution :-) WebSocket support was (is) an issue. - Win7

[PUSHED] x11 / cairo-less build try #3

2012-02-17 Thread Michael Meeks
Hi Riccardo, On Wed, 2012-02-15 at 17:55 +0100, Riccardo Magliocchetti wrote: > this is another update on building libreoffice without need to link > against X11 or toolkits in general. The aim is to ease the deploy > server side where less dependencies needed the better. Great :-) so - I

Re: [REVIEW-3-5] [PUSHED] Fix for cut-off presentations on Mac

2012-02-17 Thread Tor Lillqvist
> would someone please review >  http://cgit.freedesktop.org/libreoffice/core/commit/?id=fdfeb21102e85f94a1ecb22fb376e1875319765e > and cherry-pick for -3-5 Done. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesk

Re: Building LibreOffice on Windows

2012-02-17 Thread Tor Lillqvist
> Projects like this have to > battle the "embrace, extend, extinguish" philosophy of commercial interests. What makes you think only commercial entities have that philosophy? As far as I know Linux, also embraces and extends POSIX, for instance, and has more or less managed to extinguish quite ma

[REVIEW-3-5] Fix for cut-off presentations on Mac

2012-02-17 Thread Thorsten Behrens
Hi there, would someone please review http://cgit.freedesktop.org/libreoffice/core/commit/?id=fdfeb21102e85f94a1ecb22fb376e1875319765e and cherry-pick for -3-5 - it fixes https://bugs.freedesktop.org/show_bug.cgi?id=45584 by restoring the prior state (3.4.x and before) of not shipping cairo

Re: Building LibreOffice on Windows

2012-02-17 Thread Randall G. Arnold
On February 16, 2012 at 11:23 AM "Jesús Corrius" wrote: > Hi guys, > > > If at all possible, rather run Ubuntu (or some other Linux distro) inside a > > VMWare virtual machine on your Windows desktop. > > We should encourage Windows developers to join the project to have a > better Windows ver

[REVIEWED-3-5] fdo#46167 fix path of shell extension dll in registry

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 13:12 +0100, Andras Timar wrote: > http://cgit.freedesktop.org/libreoffice/core/commit/?id=2786c354ce4f7ff215fffe83ef242ee3b411fb13 Looks right to me, picked to -3-5. Thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, iti

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 16:06 +0100, Riccardo Magliocchetti wrote: > FYI, I'm actually using these two files to build headless. Which reminds me - I should review your patch ;-) sorry ... > vcl/unx/generic/printer/jobdata \ > vcl/unx/generic/printer/ppdparser \ > > I don't actua

[PUSHED] Removed unused code from cppcanvas module

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 14:07 +0100, Dézsi Szabolcs wrote: > Hi, i removed unused code from cppcanvas module (unusedcode.easy) Thanks for that; pushed ! :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot

[PUSHED] Removed unused code from drawinglayer

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 13:22 +0100, Dézsi Szabolcs wrote: > Hi, I removed unused function from module drawinglayer. > (unusedcode.easy) Thanks for that :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45584, which changed state. Bug 45584 Summary: presentation view defective https://bugs.freedesktop.org/show_bug.cgi?id=45584 What|Old Value |New Value ---

[PUSHED] [core/editeng/source/items/borderline.cxx:514] -> [core/editeng/source/items/borderline.cxx:509]: (style) Found duplicate branches for if and else.

2012-02-17 Thread Michael Meeks
Pushed, Thanks, all the patches are nice cleanups. Another thing that would help, would be if you could do: git commit -a ... enter your commit message etc. ... And then mail in the result of: git format-patch -1 master or somesuch - then this ca

[PUSHED] cppcheck's (portability) Extra qualification '::' unnecessary and considered an error by many compilers.

2012-02-17 Thread Michael Meeks
Pushed, and thanks for glupping together several fixes here. Thanks :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://li

[PUSHED] [core/dtrans/source/win32/dtobj/FmtFilter.cxx:485]: (performance) Possible inefficient checking for 'fileList' emptiness.

2012-02-17 Thread Michael Meeks
Pushed, Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] [core/dtrans/source/win32/dtobj/FetcList.cxx:123]: (performance) Possible inefficient checking for 'm_FormatMap' emptiness.

2012-02-17 Thread Michael Meeks
Pushed, Thanks, Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[PUSHED] [core/fpicker/source/win32/filepicker/asynceventnotifier.cxx:243]: (performance) Possible inefficient checking for 'm_EventList' emptiness.

2012-02-17 Thread Michael Meeks
Hi there, On Wed, 2012-02-15 at 23:14 +0100, Mariusz Dykierek wrote: > Possible inefficient checking for 'm_EventList' emptiness. Looks nice ! :-) any chance you can glup a few dozen of these together into each mail ? there is quite some transactional overhead of merging lots of small pat

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Tor Lillqvist
> I doubt it, solaris had moved to a GNOME desktop by default, more or > less, when I left Sun and last used solaris and all of this is > irrelevant under the gtk vclplug. OK, thanks for the technical explanation, if the code in question is obsolete on any reasonable Solaris platform (whose users

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Riccardo Magliocchetti
Hello, Il 17/02/2012 15:39, Caolán McNamara ha scritto: On Fri, 2012-02-17 at 14:34 +, Michael Meeks wrote: On Fri, 2012-02-17 at 14:05 +, Caolán McNamara wrote: In fact we should probably go so far as to drop the "generic" vcl plug altogether and just have the gtk and kde ones.

[REVIEWED] fdo#46166: EasyHack: remove obsolete MSFilterTracer

2012-02-17 Thread Michael Meeks
On Thu, 2012-02-16 at 16:17 +0100, Dézsi Szabolcs wrote: > I removed the MSFilterTracer class as suggested by Caolán McNamara. > Hope it's ok. Patch looks lovely :-) Unfortunately, as you point out in the bug, there is vestigal code in sc/ and sw/ and sd/ that uses it: git grep M

Re: [REVIEW 3-5] Reintroduce pyuno.so wrapper around libpyuno.so

2012-02-17 Thread Michael Meeks
Hi Stephan, On Thu, 2012-02-16 at 18:21 +0100, Stephan Bergmann wrote: > > Rats, missing return value. Now, third attempt, please look at the newly > > attached, slightly modified patch instead. Sigh. > > Ha! What can I say? Still lacks a WaE workaround... So here comes > patch number four.

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Caolán McNamara
On Fri, 2012-02-17 at 14:34 +, Michael Meeks wrote: > On Fri, 2012-02-17 at 14:05 +, Caolán McNamara wrote: > > In fact we should probably go so far as to drop the "generic" vcl plug > > altogether and just have the gtk and kde ones. > > An interesting idea; might be nice to do, thou

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 14:05 +, Caolán McNamara wrote: > In fact we should probably go so far as to drop the "generic" vcl plug > altogether and just have the gtk and kde ones. An interesting idea; might be nice to do, though of course, since so much code is shared anyway between gtk2,

[PUSHED] Remove various unused Perl functions from installer

2012-02-17 Thread Michael Meeks
On Thu, 2012-02-16 at 23:19 +, Tim Retout wrote: > These patches remove some unused functions from installer::worker and > installer::download. Wow - there is a really rather a large chunk of unused cruft in here :-) Thanks for slimming it down ! Michael. --

[PUSHED] Initial cleanup of installer::logger

2012-02-17 Thread Michael Meeks
On Thu, 2012-02-16 at 23:15 +, Tim Retout wrote: > This patch series removes some unused functions from > installer::logger, and merges two very similar functions. Plus > general cleanup. Another nice set of cleans; pushed ... Thanks, Michael. -- michael.m

[PUSHED] Inline and remove installer::sorter

2012-02-17 Thread Michael Meeks
On Thu, 2012-02-16 at 19:30 +, Tim Retout wrote: > as the overhead of map-sort-map is greater than just looking > up the hash values for most workloads. :-) > So this also removes Libreoffice's only Perl unit test. ;) Shame; hopefully we'll get another one, Thanks !

Re: Conversion Borderline2 to Borderline

2012-02-17 Thread Eike Rathke
Hi Dietmar, On Saturday, 2012-02-11 00:30:08 +0100, Dietmar wrote: > But that function actually did not help, because as far as I found out, > TableBorder does not work the way it did before (OOo 2.3), but removes > the lines in most cases. > I am still trying to find the cause (and hoping it's

Re: Building LibreOffice on Windows

2012-02-17 Thread Caolán McNamara
On Thu, 2012-02-16 at 17:19 +0100, Michael Stahl wrote: > well, nobody builds on Windows. because the Windows build is very often > broken. which is because nobody builds on Windows. I build it on occasion, a master from a day or two ago built fine with express 2008 C.

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||44838 -- Configure bugmail

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #188 from sasha.libreoff...@gmail.com 2012-02-17 06:13:37 UTC --- regression since 3.4: ole object inserted in Calc becomes looking corrupted when resize object or save/reload document: Bug 44838 - FORMATTING: Position, size, word wra

Re: Adding Extension for Experimental Thai Spelling

2012-02-17 Thread Caolán McNamara
On Thu, 2012-02-16 at 23:24 +, Richard Wordingham wrote: > I wouldn't expect a dictionary-based line breaker to handle words from > other languages. (There's a whole slew of Mon-Khmer languages in > Thailand, and they mostly use the Thai script when they happen to get > written.) Indeed, yeah

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Caolán McNamara
On Fri, 2012-02-17 at 10:53 +0200, Tor Lillqvist wrote: > > So I would suggest to remove that code wholesale. > > Hmm, but was this code used on Solaris? Have we already removed some > functionality needed (or at least useful) on Solaris then? I doubt it, solaris had moved to a GNOME desktop by

[REVIEW 3-5,3-4] resolved rhbz#794679 use proper Indian Rupee currency symbol U+20B9

2012-02-17 Thread Eike Rathke
Hi, Please review and cherry-pick to 3-5 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=5d6af4f2947432a55324e4f5cc67bca202f939e9 http://cgit.freedesktop.org/libreoffice/core/commit/?id=4e0928278df9e327dac9ac4d0ebf40bf04ef8dd9 http://cgit.freedesktop.org/libreoffice/core/commit/?id

Re: [REVIEW][3-5] Re: Bug 45530 - Accessibility does not work

2012-02-17 Thread Michael Stahl
hi Masataka, it seems you sent this only to me, not to the mailing list, most likely because this mailing list does not change the reply-to header (which means you need to use "Reply to all" or "Reply to list" in your mail client); i'll forward it there... On 15/02/12 15:19, Masataka Shinke wrote

[PATCH] Removed unused code from cppcanvas module

2012-02-17 Thread Dézsi Szabolcs
Hi, i removed unused code from cppcanvas module (unusedcode.easy) removed functions: cppcanvas::BaseGfxFactory::createPolyPolygon(boost::shared_ptr const&, basegfx::B2DPolyPolygon const&) const cppcanvas::BaseGfxFactory::createText(boost::shared_ptr const&, rtl::OUString const&) const cppcanvas

Re: Weird entries in SOLARLIB

2012-02-17 Thread Matúš Kukan
On 17 February 2012 13:05, Tor Lillqvist wrote: > I wonder what the -L../lib that is put into SOLARLIB for many > platforms is supposed to refer to? I believe it is (was) for dmake modules to refer to /$INPATH/lib This could be still needed, but if Mac OS X does not need this, there is no reason

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 13:21 +0200, Tor Lillqvist wrote: > > In the meantime, having un-tested, un-executed, legacy code around for > > a platform we don't support seems pretty pointless to me :-) > > What message does that send to the Solaris porters? To pull their finger out and get it

Re: [PUSHED][REVIEW:3-5] Use ICU break-iterator for Thai Spelling

2012-02-17 Thread Eike Rathke
Hi, On Friday, 2012-02-17 11:30:17 +, Michael Meeks wrote: > On Thu, 2012-02-16 at 23:24 +, Richard Wordingham wrote: > > On Tue, 14 Feb 2012 16:19:17 + > > Caolán McNamara wrote: > > > I think this change: > > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=475d0c59c66fb77

Re: Adding Extension for Experimental Thai Spelling

2012-02-17 Thread Németh László
Hi, 2012/2/17 Richard Wordingham : > It's a vast improvement - it gives LibreOffice a real Thai > spell-checker.  Thank you.  I have one worry for Siamese - Németh László > suggested that there might be a licensing issue back in > http://openoffice.2283327.n4.nabble.com/Thai-line-breaking-td279131

[PATCH] Removed unused code from drawinglayer

2012-02-17 Thread Dézsi Szabolcs
Hi, I removed unused function from module drawinglayer. (unusedcode.easy) removed functions: drawinglayer::attribute::FillBitmapAttribute::FillBitmapAttribute() drawinglayer::attribute::Sdr3DLightAttribute::Sdr3DLightAttribute() drawinglayer::attribute::Sdr3DObjectAttribute::Sdr3DObjectAttribute(

[REVIEW-3-5] fdo#46167 fix path of shell extension dll in registry

2012-02-17 Thread Andras Timar
Hi, http://cgit.freedesktop.org/libreoffice/core/commit/?id=2786c354ce4f7ff215fffe83ef242ee3b411fb13 Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Weird entries in SOLARLIB

2012-02-17 Thread Tor Lillqvist
I wonder what the -L../lib that is put into SOLARLIB for many platforms is supposed to refer to? And why -L$SRC_ROOT/solenv/$OUTPATH/lib is put there two times in some cases, when it probably is not needed at all? For Mac OS X, SOLARLIB contains *only* -L$SRC_ROOT/solver/${OUTPATH}${PROEXT}/lib, a

[REVIEW:3-5] Use ICU break-iterator for Thai Spelling

2012-02-17 Thread Michael Meeks
On Thu, 2012-02-16 at 23:24 +, Richard Wordingham wrote: > On Tue, 14 Feb 2012 16:19:17 + > Caolán McNamara wrote: > > I think this change: > > http://cgit.freedesktop.org/libreoffice/core/commit/?id=475d0c59c66fb7752d230f76130b17145aad0c12 > > should improve matters a lot. > > It's a vas

Re: [PUSHED] Remove unused methods from PDFI

2012-02-17 Thread Thorsten Behrens
Kate Goss wrote: > Yes, he did - thanks Thorsten. Christian - if you are able to set me up > with access, that would be lovely :) > Hi Kate, glad you hear you want to look into this - first step is to clone the git repo git clone git://anongit.freedesktop.org/libreoffice/website (stay on the m

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Tor Lillqvist
> In the meantime, having un-tested, un-executed, legacy code around for > a platform we don't support seems pretty pointless to me :-) What message does that send to the Solaris porters? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Michael Meeks
On Fri, 2012-02-17 at 12:16 +0200, Tor Lillqvist wrote: > > But even then, leaving in just half of it while the rest has already been > > removed would not make much sense IMO. > > Indeed, so should the earlier removal be reverted? If people want to make Solaris (or it's more viable free

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Tor Lillqvist
> But even then, leaving in just half of it while the rest has already been > removed would not make much sense IMO. Indeed, so should the earlier removal be reverted? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.fre

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Stephan Bergmann
On 02/17/2012 09:53 AM, Tor Lillqvist wrote: So I would suggest to remove that code wholesale. Hmm, but was this code used on Solaris? Have we already removed some functionality needed (or at least useful) on Solaris then? Too bad as there recently has been people here talking about supporting

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Tor Lillqvist
> So I would suggest to remove that code wholesale. Hmm, but was this code used on Solaris? Have we already removed some functionality needed (or at least useful) on Solaris then? Too bad as there recently has been people here talking about supporting Solaris? (When I say "Solaris", I mean whiche

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-02-17 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 42772, which changed state. Bug 42772 Summary: Launch of Libreoffice 3.4.4 impossible after update from version 3.4.1 https://bugs.freedesktop.org/show_bug.cgi?id=42772 What|Old Value |N

Re: [ANN] Referencing bugs in commits

2012-02-17 Thread Lionel Elie Mamane
On Tue, Feb 14, 2012 at 04:16:33PM +0100, Jan Holesovsky wrote: > whenever you are committing / pushing to git, and you > reference the bugs.freedesktop.org bug in the commit message, it will > automatically appear as a comment in the bug :-) It seems not to happen this morning. In general, after

Re: [REVIEW] Null pointer passed as an argument to a 'nonnull' parameter in vcl/unx/generic/app/i18n_wrp.cxx

2012-02-17 Thread Stephan Bergmann
On 02/16/2012 11:39 PM, julien2412 wrote: /home/julien/compile-libreoffice/libo/vcl/unx/generic/app/i18n_wrp.cxx:250:9: warning: Null pointer passed as an argument to a 'nonnull' parameter dlclose(g_dlmodule); ^ ~~ 1 warning generated. Here are the lines : 243