Re: [PATCH] Added SwDocStub class

2012-02-14 Thread Markus Mohrhard
Hey, 2012/2/14 Cedric Bosdonnat : > Hello Daniel, > > Thanks for the patch. I'll have a look at it and come back to you later. > > Markus, this is the start of what we were discussing on Sunday evening > after FOSDEM ;) It seems that having a real stub (doing nothing else > than outputing what's h

Re: [Libreoffice-qa] [ANN] Referencing bugs in commits

2012-02-14 Thread Markus Mohrhard
Hey, 2012/2/14 Michael Stahl : > On 14/02/12 17:48, Andras Timar wrote: >> 2012/2/14 Ivan Timofeev : >>> On 14.02.2012 19:31, Michael Meeks wrote: On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote: > > Markus has implemented a nice feature that should help keeping the

Re: qa-build errros on clean code

2012-02-14 Thread Markus Mohrhard
Hey, > I am experiencing problems with building (openSUSE 12.1). > > I have two machine that can build the code. > > One of the machines started acting up last weekend with assertions from > sc/qa/unit/ucalc.cxx  when performings tests. Removing all my changes and > updating the code (./g pull -r

qa-build errros on clean code

2012-02-14 Thread Winfried Donkers
Hi, I am experiencing problems with building (openSUSE 12.1). I have two machine that can build the code. One of the machines started acting up last weekend with assertions from sc/qa/unit/ucalc.cxx when performings tests. Removing all my changes and updating the code (./g pull -r) does not hel

RE: [PUSHED] Re: [PATCH]bug 44516 improved label and business card document creation

2012-02-14 Thread Winfried Donkers
>Pushed that, thank you a lot for that! >http://cgit.freedesktop.org/libreoffice/core/commit/?id=80a72c4cc7edc6b4c0b88d841500617cd733cbf7 >Kendy To my horror the behaviour of the pushed patch is not identical to the patch I tested last week. A newly created label document has all its labels (fram

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-02-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 40113, which changed state. Bug 40113 Summary: Calc Print Preview does not show page background content and formatting https://bugs.freedesktop.org/show_bug.cgi?id=40113 What|Old Value |

Bug 45530 - Accessibility does not work

2012-02-14 Thread Masataka Shinke
Patch of Bug 45530 - Accessibility does not work https://bugs.freedesktop.org/show_bug.cgi?id=45530 -- diff --git scp2/source/ooo/file_ooo.scp scp2/source/ooo/file_ooo.scp index cae313a..e2c0c68 100644 --- scp2/source/ooo/file_ooo.scp +++ scp2/source/ooo/file_ooo.scp @@ -426,6 +426,7 @@ STD_J

[PATCH] Remove unused code

2012-02-14 Thread Björgvin Ragnarsson
Hi, Attached is a patch for removal of unused code in files core/basegfx/source/polygon/b3dpolygontools.cxx and core/basegfx/inc/basegfx/polygon/b3dpolygontools.hxx thanks, Björgvin From 87195b203f05a76f26b383126a514a20a70a69eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rgvin=20Ragnarsson?

EasyHack 39641 looking for its creator [bugzilla-dae...@freedesktop.org: [Bug 39641] [EasyHack] Clean up document type association on Linux]

2012-02-14 Thread Bjoern Michaelsen
Hi there, EasyHack 39641 is looking for its original creator/mentor. Please show up! Best, Bjoern - Forwarded message from bugzilla-dae...@freedesktop.org - Date: Mon, 13 Feb 2012 03:44:06 + From: bugzilla-dae...@freedesktop.org To: bjoern.michael...@canonical.com Subject: [Bug 396

[PATCH] rework of make check, running smoketest and installing - gbuild patches

2012-02-14 Thread Matúš Kukan
Hi all, As already promised on irc I'm proposing gbuild patches for smoketest(oo_native). In smoketestoo_native/ there were commands for installing which I moved to toplevel Makefile. There was also smoketest being run. This I moved to smoketest/ module as regular subsequentcheck target. So there

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

2012-02-14 Thread Matúš Kukan
On 14 February 2012 18:12, Michael Meeks wrote: >        Nice ;-) I was wondering - how are we doing wrt. getting more of the > libraries into tail_build and libmerged ? :-) I wonder could we get > 'basic' into that ? svtools ? some of the 'helper' libraries ? :-) It's going quite well. With tml'

[PATCH] Turn on strictures for some installer Perl modules

2012-02-14 Thread Tim Retout
Hi, I'd like to try to clean up some of the code in the solenv Perl modules - as a first task, I want to turn on 'use strict', which I'd consider a bare minimum for maintainable Perl. Longer-term, Perl::Critic flags up lots of nice stuff, and then there's performance and so on. My first few atte

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Stephan Bergmann
On 02/14/2012 10:39 PM, Josh Heidenreich wrote: Do we need licence blocks in a README? Can we just write the licence in on all pages generated by the script? My (naive?) take on it is that, technically, all the files committed to the git repo are "source files" that should have a legal header.

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Josh Heidenreich
hi, >> So no way to have a (license) comment at the head of a README? Do we need licence blocks in a README? Can we just write the licence in on all pages generated by the script? Also, if you do need a licence block, it can't be the first paragraph of the readme, that's for a summary. Maybe on

[PATCH] Remove unused code from gtkframe

2012-02-14 Thread Kate Goss
Hi, Please find attached a patch to remove a couple of methods listed in unusedcode.easy, from gtkframe. Kate From 85b2e98cb31fc7d8968136bf91c01b5589e7a0dd Mon Sep 17 00:00:00 2001 From: Kate Goss Date: Tue, 14 Feb 2012 21:10:14 + Subject: [PATCH] Remove unused methods from gtkframe Remove

Re: changes in profile path in release notes for 3.5

2012-02-14 Thread Jean-Baptiste Faure
Le 14/02/2012 21:39, Cor Nouws a écrit : > Cor Nouws wrote (12-02-12 17:05) >> Jean-Baptiste Faure wrote (11-02-12 09:04) > >>> On Linux (or Linux Gnome only ???) the profile directory for LO 3.5.0 >>> has been move to ~/.config/libreoffice. This information should be >>> clearly stated in the rel

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Gert van Valkenhoef
Hi all, Thanks for all the replies and comments. Attached is a new bunch of patches against master. I've reworked the helpindexer.cpp code so that it can be used as a library, and I changed xmlhelp/source/cxxhelp/provider/databases.cxx to call it. The good news is that I think this gets rid

Re: poor little bug

2012-02-14 Thread Cor Nouws
Luc Castermans wrote (14-02-12 20:06) I'm this poor little bug left alone in the corner. When will I be solved ? https://bugs.freedesktop.org/show_bug.cgi?id=36681 Luckily it's not alone :-) It's one of the currently 43 open issues in our Bug 37361 - LibreOffice 3.5 most annoying bugs And p

Re: changes in profile path in release notes for 3.5

2012-02-14 Thread Cor Nouws
Cor Nouws wrote (12-02-12 17:05) Jean-Baptiste Faure wrote (11-02-12 09:04) On Linux (or Linux Gnome only ???) the profile directory for LO 3.5.0 has been move to ~/.config/libreoffice. This information should be clearly stated in the release notes for 3.5. Could somebody who knows exactly wha

Congratulations to all LibreOffice hackers and developers

2012-02-14 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all I beg your pardon for this off-topic subject, but I feel obliged to say to all of you, hackers and developers, a big THANK YOU for the wonderful LibreOffice 3.5 you just released. I am pretty sure that the enthousiasm and determination of this

Re: Adding Extension for Experimental Thai Spelling

2012-02-14 Thread Eike Rathke
Hi, On Tuesday, 2012-02-14 16:19:17 +, Caolán McNamara wrote: > We have some customized break iterator rules in LibreOffice, so we're > using those ones and *not* the built-in icu ones. But we lack a > customized Thai one, so we're using some ultra-generic word breaking > stuff for Thai and n

Re: [PUSHED-3-5] fdo#45995 & fdo#45992

2012-02-14 Thread Petr Mladek
Petr Mladek píše v Út 14. 02. 2012 v 17:46 +0100: > Noel Power píše v Út 14. 02. 2012 v 11:11 +: > > On 14/02/12 10:39, Noel Power wrote: > > > handle imported picture attribute from MSO Dialog ( fdo#45995 ) needed > > > for 3.5 ( and possibly 3.4... I need to check that ) > > > core:58255c47b

Re: [PUSHED] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

2012-02-14 Thread Cor Nouws
Michael Meeks wrote (14-02-12 17:31) Incidentally, I really like the patch - and as someone who exits their app often via either a SEGV, or an explicit kill, I'd really like the recently used documents list to work ;-) Big thanks from me too. It's one of those little annoyances that on

poor little bug

2012-02-14 Thread Luc Castermans
I'm this poor little bug left alone in the corner. When will I be solved ? Luc https://bugs.freedesktop.org/show_bug.cgi?id=36681 <>___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [ANN] Referencing bugs in commits

2012-02-14 Thread Jan Holesovsky
Hi Ivan, Ivan Timofeev píše v Út 14. 02. 2012 v 20:33 +0400: > Is it possible somehow include the information about a target version? Oh - great idea :-) Added that to the script; it does some best-effort guess, by saying "It will be available in LibreOffice x.y.z.", where x.y is derived from t

Re: adding getINT64 to comphelper

2012-02-14 Thread Stephan Bergmann
On 02/14/2012 07:17 PM, Lionel Elie Mamane wrote: I guess it would be OK to add getINT64 to comphelper? It already has getINT16 and getINT32. I would rather deprecate those in favour of Any::get(). Stephan ___ LibreOffice mailing list LibreOffice@lis

No page and Columns boundaries in 3.5

2012-02-14 Thread Fernand Vanrie
On the user lists the first complaints about "no" page and column boundaries for LO Writer 3.5 are comming in. For some documents the "new corner layout" can be helpfull but without visible page and column boundaries it becomes very difficult to "place" images and other objects in a mulptiple

adding getINT64 to comphelper

2012-02-14 Thread Lionel Elie Mamane
I guess it would be OK to add getINT64 to comphelper? It already has getINT16 and getINT32. -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH] Remove unused code

2012-02-14 Thread Radek Doulik
Hi Santiago, thanks for you patch, pushed. Cheers Radek On Mon, 2012-02-13 at 21:55 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy > > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org

Re: [ANN] Referencing bugs in commits

2012-02-14 Thread Jan Holesovsky
Hi Pierre-André, Pierre-André Jacquod píše v Út 14. 02. 2012 v 18:02 +0100: > > The bug reference has to have fdo#ABCDE form (where ABCDE is the bug > > number), and has to be at the first line of the commit (it does not > > matter where on that line). > > Sorry, one point is for me not clear: >

Re: [Libreoffice-qa] [ANN] Referencing bugs in commits

2012-02-14 Thread Michael Meeks
On Tue, 2012-02-14 at 20:33 +0400, Ivan Timofeev wrote: > Is it possible somehow include the information about a target version? I guess that -should- be implicit in the branch it is committed to, so - sounds feasible ;-) at least - the expert eye can see that information there already.

Re: [PARTIALLY PUSHED][PATCH] Remove unused code from connectivity::odbc

2012-02-14 Thread Lionel Elie Mamane
On Tue, Feb 14, 2012 at 01:43:11PM +, Caolán McNamara wrote: > On Tue, 2012-02-14 at 06:06 +0100, Lionel Elie Mamane wrote: >> Thanks, but this one should actually be used in >> ODatabaseMetaData::getTableTypes. It is probably a bug that it is not, >> I'll convert getTableTypes to using it >

libreoffice-3-5 not buildable on Windows since yesterday

2012-02-14 Thread Jan Holesovsky
Hi, Just to remind you - the Win86@6-fast tinderbox is a pretty reliable buildbot, and when it reports there is a build problem, it really means it ;-) Yesterday, a commit was pushed that breaks libreoffice-3-5 build on Windows, and the branch is still broken since then. Please, keep in mind tha

Re: [PUSHED] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

2012-02-14 Thread Michael Meeks
On Tue, 2012-02-14 at 18:44 +0200, Muhammad Haggag wrote: > I'm currently investigating fdo#31005: > https://bugs.freedesktop.org/show_bug.cgi?id=31005 Let me read that :-) > I think I'll be focusing on bug fixing (rather than doing cleanup) for > a while, and I'll probably be giving pre

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

2012-02-14 Thread Tor Lillqvist
> I was wondering - how are we doing wrt. getting more of the > libraries into tail_build and libmerged ? In the feature/android branch I have added the fw[eiklm], sfx, sb, svt and tk libraries to libmerged. Working on verifying that the last addition didn't break anything; I found a nice direct r

Re: [Libreoffice-commits] "Remove unused VolumeDevice functions and related code"

2012-02-14 Thread Stephan Bergmann
On 02/05/2012 09:52 PM, François Tigeot wrote: sal/inc/osl/file.h| 43 sal/inc/osl/file.hxx | 28 - sal/osl/unx/file_volume.cxx | 80 -- sal/osl/w32/file_dirvol.cxx | 18 ---

Re: [REVIEW] smoketest -> gbuild, TestExtension.idl needed ?

2012-02-14 Thread Michael Meeks
On Mon, 2012-02-13 at 23:21 +0100, Matúš Kukan wrote: > I'd like to push attached patch. Hopefully it will work also for > others and there is nothing wrong with removing TestExtension.rdb from > TestExtension.oxt. Nice ;-) I was wondering - how are we doing wrt. getting more of the libra

Re: [PUSHED] Remove unused methods from PDFI

2012-02-14 Thread Jan Holesovsky
Hi Kate, Kate Goss píše v Po 13. 02. 2012 v 19:48 +: > The easy hacks do look tempting, but I am new to free software > contributing, and also to git, so I'm getting up to speed on unused > code as a starting point! I enjoyed the 'easy hacks' talk you gave at > FOSDEM, which inspired me to jo

[PATCH] How far can the LO file's contents be stretched?

2012-02-14 Thread Caolán McNamara
On Sun, 2012-02-12 at 21:26 +0100, Johannes Sixt wrote: > The patch below is how far I got. It computes a CRC from the properties > in the automatic style, which is used in the name. In this version, the > count is still used, just in case the CRC is not unique (this should not > be done in the fin

Re: [PATCH] Help - minor updates

2012-02-14 Thread Radek Doulik
Hi Stanislav, On Tue, 2012-02-14 at 16:00 +0100, Stanislav Horáček wrote: > > thanks for your patches! One thing I noticed, is it possible to replace > > StarOffice with LibreOffice instead of OpenOffice in patch #3? > > > > Hi, > > I think it is not good idea, because the text is related to ver

Re: [ANN] Referencing bugs in commits

2012-02-14 Thread Andras Timar
2012/2/14 Ivan Timofeev : > On 14.02.2012 19:31, Michael Meeks wrote: >> >> >> On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote: >>> >>> Markus has implemented a nice feature that should help keeping the bugs >>> up to date: whenever you are committing / pushing to git, and you >> >> >>    

Re: [REVIEW-3-5][REVIEW-3-4] fdo#45995 & fdo#45992

2012-02-14 Thread Petr Mladek
Noel Power píše v Út 14. 02. 2012 v 11:11 +: > On 14/02/12 10:39, Noel Power wrote: > > handle imported picture attribute from MSO Dialog ( fdo#45995 ) needed > > for 3.5 ( and possibly 3.4... I need to check that ) > > core:58255c47b1d540fd2493b4ed132aa7fa82da156e > I sorta got mixed up with

Re: [PUSHED] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

2012-02-14 Thread Muhammad Haggag
On Tue, Feb 14, 2012 at 6:31 PM, Michael Meeks wrote: > >        I've merged it to master, thanks so much for your work here; do you > have another easy hack or some cleanup in your sights next ? :-) usually > things start to occur to people after they've read around the code for a > bit ;-) Than

Re: [ANN] Referencing bugs in commits

2012-02-14 Thread Ivan Timofeev
On 14.02.2012 19:31, Michael Meeks wrote: On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote: Markus has implemented a nice feature that should help keeping the bugs up to date: whenever you are committing / pushing to git, and you ooh ! really lovely :-) Great work Mark

[PUSHED] Removing unused code

2012-02-14 Thread Michael Meeks
On Mon, 2012-02-13 at 22:36 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Thanks ! :-) Michael. -- michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice

[PUSHED] fdo#37775 - EasyHack: Recent Documents not updated by Save & Save As...

2012-02-14 Thread Michael Meeks
Hi Muhammad, On Tue, 2012-02-14 at 10:58 +0200, Muhammad Haggag wrote: > It's possible to solve that without having to update the list on open. > We can intercept the beginning of the "Save As" operation and update > the list with the old document. I uploaded a new patch that does that > (and remo

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Caolán McNamara
On Tue, 2012-02-14 at 17:04 +0100, G.H.M.Valkenhoef, van wrote: > > > I noticed that CJK-based indexing is only enabled for the Japanese > language. Maybe this can be fixed by adding more languages to be > CJK-indexed. Indeed, opengrok for "CJKAnalyzer" and see if running zh-* (and possibly ko)

Re: Adding Extension for Experimental Thai Spelling

2012-02-14 Thread Caolán McNamara
On Mon, 2012-02-13 at 22:39 +, Richard Wordingham wrote: > The spell-checker seems to break up a phrase consisting of just กุหลาบ > into 3 or 4 words. Hmm, so I played around with this and here's what I think is the problem... We have some customized break iterator rules in LibreOffice, so we

Re: [PATCH] Added SwDocStub class

2012-02-14 Thread Cedric Bosdonnat
Hello Daniel, Thanks for the patch. I'll have a look at it and come back to you later. Markus, this is the start of what we were discussing on Sunday evening after FOSDEM ;) It seems that having a real stub (doing nothing else than outputing what's happening) will be tricky. Daniel, may be it wo

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread G.H.M.Valkenhoef, van
On 14-02-12, Andras Timar wrote: > 2012/2/14 Norbert Thiebaud : > > Just a word of encouragement: thanks for working on that, I'm looking > > forward to see the impact on the build with LANG=all :-) > > Me too, and also I wonder, if it fixes > https://bugs.freedesktop.org/show_bug.cgi?id=40665

README.cross patch

2012-02-14 Thread Jonathan Aquilina
Attached find a patch which updates the switches that i used to get autogen.sh to successfully complete when compiling LO for android on linux. All my contributions present and future are Licensed for LGPL an MPL current versions and future versions -- Jonathan Aquilina From 3d6c864bdb81e290e349

Re: [PUSHED 3.4 3.5] fdo#40261: Fix crash in XML Form Document

2012-02-14 Thread Petr Mladek
Jan Holesovsky píše v Pá 10. 02. 2012 v 15:20 +0100: > Hi, > > Can you please review a fix for: > > https://bugs.freedesktop.org/show_bug.cgi?id=40261 > > It targets both libreoffice-3-4, and libreoffice-3-5, please review and > push: Looked and worked fine. I have pushed it into both 3-4 and 3

[PATCH] Added SwDocStub class

2012-02-14 Thread Mihályi Dániel
From c1d1c0cbe28ac55eea80afa97c5f7828324e9ade Mon Sep 17 00:00:00 2001 From: Daniel Mihalyi Date: Tue, 14 Feb 2012 17:33:38 +0100 Subject: [PATCH] Added SwDocStub class --- sw/source/core/doc/docnew.cxx |9 + sw/source/core/layout/layouter.cxx |1 + sw/source/filter/basfl

Re: [ANN] Referencing bugs in commits

2012-02-14 Thread Michael Meeks
On Tue, 2012-02-14 at 16:16 +0100, Jan Holesovsky wrote: > Markus has implemented a nice feature that should help keeping the bugs > up to date: whenever you are committing / pushing to git, and you ooh ! really lovely :-) Great work Markus ! Michael. -- michae

[PUSHED] Re: [PATCH] [REVIEW:3-5,3-4] odbc 64 bits crash

2012-02-14 Thread Michael Stahl
On 14/02/12 15:37, Lionel Elie Mamane wrote: > Yet another odbc on 64 bit crash because of wrong buffer size. This is > supposed to be a SQLLEN but was hardcoded as 4 bytes. > > You can see that e.g. in > connectivity/source/drivers/odbcbase/OPreparedStatement.cxx, > OPreparedStatement::setNull: >

Re: [PUSHED][3-5] Re: [PATCH] [REVIEW:3-5, 3-4] api documentation error

2012-02-14 Thread Andras Timar
2012/2/14 Michael Stahl : > On 14/02/12 15:46, Lionel Elie Mamane wrote: >> I corrected an error (bad link/reference) in the API documentation for >> com::sun::star::sdbc::XDatabaseMetaData. Do we backport that kind of >> things? It would suck somewhat for our on-line version to be wrong >> until a

[PUSHED] Re: [REVIEW] fix RTF import of text frames with exact height

2012-02-14 Thread Michael Stahl
On 14/02/12 11:35, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=e0328096dc21ce12d15db2045074e7860872570f > > Could someone review and cherry-pick to -3-5, please? makes sense; ah, that's one of those controls that encode an extra bit into the sign o

[PUSHED][3-5] Re: [PATCH] [REVIEW:3-5,3-4] api documentation error

2012-02-14 Thread Michael Stahl
On 14/02/12 15:46, Lionel Elie Mamane wrote: > I corrected an error (bad link/reference) in the API documentation for > com::sun::star::sdbc::XDatabaseMetaData. Do we backport that kind of > things? It would suck somewhat for our on-line version to be wrong > until after the release of 3.6. > > So

[PUSHED] Re: [REVIEW 3-5] Adapt SDK to changed paths in LO installation

2012-02-14 Thread Michael Stahl
On 14/02/12 10:48, Stephan Bergmann wrote: > Please review and cherry-pick to libreoffice-3-5 the commit > > > "Resolves rhbz#789622: Adapt SDK to changed paths in LO installation". pushed to libr

[ANN] Referencing bugs in commits

2012-02-14 Thread Jan Holesovsky
Hi, Markus has implemented a nice feature that should help keeping the bugs up to date: whenever you are committing / pushing to git, and you reference the bugs.freedesktop.org bug in the commit message, it will automatically appear as a comment in the bug :-) The bug reference has to have fdo#AB

Re: [PATCH] Help - minor updates

2012-02-14 Thread Stanislav Horáček
> thanks for your patches! One thing I noticed, is it possible to replace > StarOffice with LibreOffice instead of OpenOffice in patch #3? > Hi, I think it is not good idea, because the text is related to version 1.1 and there was no LibreOffice 1.1. S. __

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Andras Timar
2012/2/14 Norbert Thiebaud : > Just a word of encouragement: thanks for working on that, I'm looking > forward to see the impact on the build with LANG=all :-) Me too, and also I wonder, if it fixes https://bugs.freedesktop.org/show_bug.cgi?id=40665 Cheers, Andras

[PATCH] [REVIEW:3-5,3-4] api documentation error

2012-02-14 Thread Lionel Elie Mamane
I corrected an error (bad link/reference) in the API documentation for com::sun::star::sdbc::XDatabaseMetaData. Do we backport that kind of things? It would suck somewhat for our on-line version to be wrong until after the release of 3.6. So I propose we backport this to 3.5, and maybe 3.4, too?

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Norbert Thiebaud
Just a word of encouragement: thanks for working on that, I'm looking forward to see the impact on the build with LANG=all :-) Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffic

[PATCH] [REVIEW:3-5,3-4] odbc 64 bits crash

2012-02-14 Thread Lionel Elie Mamane
Yet another odbc on 64 bit crash because of wrong buffer size. This is supposed to be a SQLLEN but was hardcoded as 4 bytes. You can see that e.g. in connectivity/source/drivers/odbcbase/OPreparedStatement.cxx, OPreparedStatement::setNull: sal_Int8* lenBuf = getLengthBuf (parameterIndex);

Re: faster java compilation (was Re: linking performance

2012-02-14 Thread Noel Grandin
On 2012-02-14 15:49, Michael Stahl wrote: do we _really_ invoke javac once for each source file anywhere? at least in gbuild it's invoked once per jar file (technically, per JavaClassSet that the jar depends upon), which is the only sane way to do it. You are correct sir. But I think I saw

Re: Need help (mentor) while fixing an issue

2012-02-14 Thread Michael Stahl
On 13/02/12 15:19, Jan Holesovsky wrote: > Hi Dag, > > Dag Wieers píše v Pá 10. 02. 2012 v 16:36 +0100: > >> I found a bug in LibreOffice causing style:rel-width and style:rel-height >> not to accept "scale" as a possible value. In fact the behavior seems to >> be to default to 100% if anything

Re: SVG export feature

2012-02-14 Thread Thorsten Behrens
Germano Lector wrote: > Firstly, I just wanna say that I'm not sure if this is the correct > list to post this, > Hi Germano, oh, really, it is - as you're interested in the code itself! :) > Initially, I'm thinking about to improve the SVG export feature, > trying to put some animations to work.

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Thorsten Behrens
Stephan Bergmann wrote: > So no way to have a (license) comment at the head of a README? > Sure - just invent a markup for it on the spot. :) Cheers, -- Thorsten pgpE3XifXWBiz.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lis

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||46038 --- Comment #186 from Rainer Bi

Re: [REVIEW][PUSHED][3.5]fdo#45748 wrong position for page break indicator

2012-02-14 Thread Tor Lillqvist
> Could someone review and cherry-pick -s this commit in 3-5? > http://cgit.freedesktop.org/libreoffice/core/commit/?id=9baee86cbdec44c657d06f355bdba0537fb12a1a Done. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.free

Re: Wrong screenshot in 3.5 features page

2012-02-14 Thread Khaled Hosny
On Tue, Feb 14, 2012 at 02:37:32PM +0100, Andras Timar wrote: > Hi Khaled, > > > 2012/2/14 Khaled Hosny : > > Not sure to which mailing list should I report this, so I'm sending to > > the one I'm subscribed to :) > > > > In http://www.libreoffice.org/download/3-5-new-features-and-fixes/, the > >

Re: faster java compilation (was Re: linking performance

2012-02-14 Thread Michael Stahl
On 14/02/12 13:30, Noel Grandin wrote: > > > On 2012-02-14 14:22, Michael Meeks wrote: >> Perhaps; could it also be that we like to compile with gcc in some >> eight way parallel way, but when it comes to linking, we -really- >> don't want to bog our machine down in that way ? I wonder if we co

[REVIEW][3.5]fdo#45748 wrong position for page break indicator

2012-02-14 Thread Cedric Bosdonnat
Hi all, Could someone review and cherry-pick -s this commit in 3-5? http://cgit.freedesktop.org/libreoffice/core/commit/?id=9baee86cbdec44c657d06f355bdba0537fb12a1a Thanks, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http:/

Re: [REVIEW] [PATCH]bug 44516 improved label and business card document creation

2012-02-14 Thread Jan Holesovsky
Hi Winfried, Winfried Donkers píše v Út 14. 02. 2012 v 07:44 +0100: > Can this patch be pushed to 3.4 and 3.5 branches as well? > The patch addresses problem that go way back in time (pre-LibreOffice at > least). The problem is that it is partially a feature, and introduces new strings :-( - so

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-14 Thread Chr. Rossmanith
Hi, maybe the wiki (Development/String Classes->Favored Methods Utilizing String Literals) should be updated? Otherwise RTL_CONSTASCII_USTRINGPARAM might still show some vital signs... Christina Am 10.02.2012 13:43, schrieb Michael Meeks: Hi Lubos, Rather ill today, but immensely e

Re: [PATCH] Remove unused code from connectivity::odbc

2012-02-14 Thread Caolán McNamara
On Tue, 2012-02-14 at 06:06 +0100, Lionel Elie Mamane wrote: > Thanks, but this one should actually be used in > ODatabaseMetaData::getTableTypes. It is probably a bug that it is not, > I'll convert getTableTypes to using it How about the other one ? C. __

Re: Wrong screenshot in 3.5 features page

2012-02-14 Thread Andras Timar
Hi Khaled, 2012/2/14 Khaled Hosny : > Not sure to which mailing list should I report this, so I'm sending to > the one I'm subscribed to :) > > In http://www.libreoffice.org/download/3-5-new-features-and-fixes/, the > screenshot under "The "Insert Movie and Sound" dialog..." actually is > the one

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Michael Meeks
On Tue, 2012-02-14 at 23:07 +1030, Josh Heidenreich wrote: > > What is the markup format to be used in the READMEs? > > It's a loose copy of the wikimedia syntax used in the wiki, so: > - Paragraphs are separated by a blank line. > - Headings are in the form "== heading ==" (without the quotes) >

Wrong screenshot in 3.5 features page

2012-02-14 Thread Khaled Hosny
Not sure to which mailing list should I report this, so I'm sending to the one I'm subscribed to :) In http://www.libreoffice.org/download/3-5-new-features-and-fixes/, the screenshot under "The "Insert Movie and Sound" dialog..." actually is the one for "Several GTK+ right-to-left interface glitch

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Thorsten Behrens
Josh Heidenreich wrote: > Can it be run standalone, without the rest of doxygen? Could it be run > every commit in that case until the READMEs stablalise a bit (i.e. I > get something in there for every module as a starting point for this > project) > In principle yes, with the current script - no

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 43399, which changed state. Bug 43399 Summary: Address data source wizard only uses evolution https://bugs.freedesktop.org/show_bug.cgi?id=43399 What|Old Value |New Value

faster java compilation (was Re: linking performance (was: Re: OK to get rid of scaddins?))

2012-02-14 Thread Noel Grandin
On 2012-02-14 14:22, Michael Meeks wrote: Perhaps; could it also be that we like to compile with gcc in some eight way parallel way, but when it comes to linking, we -really- don't want to bog our machine down in that way ? I wonder if we could explicitly limit parallelism of linking in some

one-big library approach of mozilla ...

2012-02-14 Thread Michael Meeks
Hi Taras, We're running into some fun performance & development iteration problems with LibreOffice as we plan to merge more libraries together; and I was wondering - how does Mozilla deal with that ? How long does it take your developers to link / go around a development iteratio

SVG export feature

2012-02-14 Thread Germano Lector
Hi all, Firstly, I just wanna say that I'm not sure if this is the correct list to post this, but anyway... here I go: I need to develop some sort of integration with the OpenOffice Impress in order to fully convert an odp presentation to display in an HTML5 page. Initially, I'm thinking about

Re: OK to get rid of scaddins?

2012-02-14 Thread Mark Wielaard
On Tue, Feb 14, 2012 at 10:52:31AM +, Michael Meeks wrote: > On Mon, 2012-02-13 at 16:06 +0100, Michael Stahl wrote: > > >> (of course i don't care if you do it for a special "merged libs" mode, > > >> but C++ development is already a sufficiently unproductive activity that > > >> we shouldn't

[PATCH] convert svxrtf.hxx in editeng module from table.hxx to std::map

2012-02-14 Thread Noel Grandin
Hi License statement already on file. "make check" succeeds. Note that I tried converting these usages to boost::ptr_map, but I ran into entirely undecipherable C++ template errors. (can't wait for template-type-checking aka. concepts to make it into the language). Regards, Noel Grandin D

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Stephan Bergmann
On 02/14/2012 01:37 PM, Josh Heidenreich wrote: What is the markup format to be used in the READMEs? It's a loose copy of the wikimedia syntax used in the wiki, so: - Paragraphs are separated by a blank line. - Headings are in the form "== heading ==" (without the quotes) - Links to modules are

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-14 Thread Josh Heidenreich
Thorsten, Stephan, List, > nope, it's a manual process that I run every once in a while. > Doxygen itself is rather heaviweight, so you really don't want to > run that on a server, let alone for every commit. Can it be run standalone, without the rest of doxygen? Could it be run every commit in th

Re: linking performance (was: Re: OK to get rid of scaddins?)

2012-02-14 Thread Mark Wielaard
Hi, Added Tom to the CC, see thread here: http://thread.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/24055/focus=24096 (Although it seems posts from non-subscribers, aka me, are not allowed, so you won't see my earlier reply there. I'll send it to you separately.) On Tue, Feb 14, 20

Re: linking performance (was: Re: OK to get rid of scaddins?)

2012-02-14 Thread Michael Meeks
Hi Michael, On Tue, 2012-02-14 at 13:07 +0100, Michael Stahl wrote: > the problem is more likely that in tail_build we first compile all the > object files, and only after they have all been built they are linked > into libraries/executables. Perhaps; could it also be that we like to comp

Re: [PATCH] Help - minor updates

2012-02-14 Thread Michael Stahl
On 14/02/12 12:51, Radek Doulik wrote: > Hi Stanislav, > > thanks for your patches! One thing I noticed, is it possible to replace > StarOffice with LibreOffice instead of OpenOffice in patch #3? uhmm, those are compatibility options for ancient versions of SO/OOo, unless you have plans to releas

linking performance (was: Re: OK to get rid of scaddins?)

2012-02-14 Thread Michael Stahl
On 14/02/12 11:52, Michael Meeks wrote: > Hi Michael, > > On Mon, 2012-02-13 at 16:06 +0100, Michael Stahl wrote: (of course i don't care if you do it for a special "merged libs" mode, but C++ development is already a sufficiently unproductive activity that we shouldn't make it even

Re: [EasyHack] #44681 port to CLucene from java/Lucene

2012-02-14 Thread Caolán McNamara
On Tue, 2012-02-14 at 09:45 +0100, G.H.M.Valkenhoef, van wrote: > > > Yes, I found that java code (the HelpIndexer I refer to). I'll work on > a patch to replace the XInvocations of the Java code with calls to my > code. I can try and knock together a skeleton of a conversion of that Java compone

Re: [PATCH] Help - minor updates

2012-02-14 Thread Radek Doulik
Hi Stanislav, thanks for your patches! One thing I noticed, is it possible to replace StarOffice with LibreOffice instead of OpenOffice in patch #3? Cheers Radek On Sun, 2012-02-12 at 20:14 +0100, Stanislav Horáček wrote: > Hello, > > I noticed several parts where current help didn't correspond

Re: sal / gcc conditionals ...

2012-02-14 Thread Stephan Bergmann
On 02/13/2012 06:45 PM, Michael Meeks wrote: * cppu/inc/cppu/macros.hxx: CPPU_GCC3_ALIGN - uh ? I assume this should be just CPPU_GCC_ALIGN and with only one definition in today's world ? We still need two versions of the define, one for __GNUC__ and one for others. The name

Re: Tinderbox failure, last success: 2011-12-05 09:00:13

2012-02-14 Thread Petr Mladek
Kohei Yoshida píše v Po 13. 02. 2012 v 08:53 -0500: > Can we please do something about Fridrich's tinderbox? Its last > successful build is over 2 months ago... > > This tinderbox is singlehandedly increasing the signal-to-noise ratio. I have stopped them yesterday morning. I will enable them on

Re: Grammar checker development for LibreOffice

2012-02-14 Thread Németh László
Hi Cor, Thanks for your feedback. Last year I was involved in Dutch language developments (I worked with the Dutch OpenTaal Foundation to improve Dutch spell checking, sponsored by the Dutch Language Union and the foundation), but I have known the active and excellent open source Dutch language de

[REVIEWED:3-5,3-4] fdo#43399 address data source wizard non-functional if no evolution

2012-02-14 Thread Michael Meeks
Hi Lionel, Gosh VCL's button grouping is an unmitigated horror :-) On Mon, 2012-02-13 at 18:19 +0100, Lionel Elie Mamane wrote: > Attached patch fixes that by including the hidden items in the same > selection group, too. Pushed to libreoffice-3-5 and libreoffice-3-4. Th

Re: [REVIEW-3-5][REVIEW-3-4] fdo#45995 & fdo#45992

2012-02-14 Thread Noel Power
On 14/02/12 10:39, Noel Power wrote: handle imported picture attribute from MSO Dialog ( fdo#45995 ) needed for 3.5 ( and possibly 3.4... I need to check that ) core:58255c47b1d540fd2493b4ed132aa7fa82da156e I sorta got mixed up with my comments about these bugs, this one is indeed ( and I alway

  1   2   >