building master fails on nlpsolver

2012-02-10 Thread Jean-Baptiste Faure
Hi, When building the master (Ubuntu 11.10, x86_64), it fails and says that the problem is inside nlpsolver. If I try to build nlpsolver by make nlpsolver I get the following error messages : > cd nlpsolver && make -j 2 -rs gb_PARTIALBUILD=T > [ build XHP ] help/fr/com.sun.star.comp.Calc.NLPSolve

[PATCH] Remove unused code (9)

2012-02-10 Thread Elton Chung
Hi, This patch removes 11 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of http://mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com -

Re: Conversion Borderline2 to Borderline

2012-02-10 Thread Dietmar
Hi Eike Am Dienstag, den 07.02.2012, 23:50 +0100 schrieb Eike Rathke: > Hi Dietmar, > > On Saturday, 2012-02-04 18:47:40 +0100, Dietmar wrote: > > > is there a method to convert Borderline2 to Borderline (and vice versa), > > I can use in a Java extension? > > Unfortunately not. I have alread

Re: OK to merge the fw? libraries in framework?

2012-02-10 Thread Mathias Bauer
Hi Michael, Am 09.02.2012 11:32, schrieb Michael Meeks: > IMHO the split of GUI code from non-GUI code here would be quite > reasonable if we had a consumer for that. It seems to me that all > headless uses of the code-base end up linking VCL and re-using chunks of > the toolkit anyway thoug

[EasyHack] #44681 port to CLucene from java/Lucene

2012-02-10 Thread Gert van Valkenhoef
Dear LibreOffice developers, Bug: https://bugs.freedesktop.org/show_bug.cgi?id=44681 Attached are initial implementations of the HelpIndexer and HelpSearch in C++ using CLucene, to replace the Java implementations using Lucene. The code that interfaces with Lucene to do the indexing and searc

[PATCH 3/3] Remove unused code in XMLTextImportHelper

2012-02-10 Thread Catalin Iacob
--- unusedcode.easy |3 --- xmloff/inc/xmloff/txtimp.hxx |7 --- xmloff/source/text/txtimp.cxx | 36 3 files changed, 0 insertions(+), 46 deletions(-) diff --git a/unusedcode.easy b/unusedcode.easy index db9233b..60da3ef 100644 ---

[PATCH 2/3] Remove unused code in XSecController

2012-02-10 Thread Catalin Iacob
--- unusedcode.easy|3 - xmlsecurity/source/helper/xsecctl.cxx | 64 xmlsecurity/source/helper/xsecctl.hxx | 10 - xmlsecurity/source/helper/xsecsign.cxx | 30 --- 4 files changed, 0 insertions(+), 107 deletions(-

[PATCH 1/3] Remove unused code in XMLSignatureHelper

2012-02-10 Thread Catalin Iacob
--- unusedcode.easy|6 --- xmlsecurity/inc/xmlsecurity/xmlsignaturehelper.hxx | 11 - xmlsecurity/source/helper/xmlsignaturehelper.cxx | 47 3 files changed, 0 insertions(+), 64 deletions(-) diff --git a/unusedcode.easy b/unus

[PATCH 0/3] Code removal, first contribution

2012-02-10 Thread Catalin Iacob
Contribution under LGPLv3+ / MPL. Since this is my first contribution, I have a question. I grepped for the removed stuff using pss[1], a Python clone of the more famous ack[2] and I told the tool to only grep in C and C++ files, otherwise it takes a lot longer. These extensions are then searched

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45607, which changed state. Bug 45607 Summary: Particular BASIC Macro execution significant slower than with OOo, NeoOffice, Symphony https://bugs.freedesktop.org/show_bug.cgi?id=45607 What|Old Value

Re: minutes of ESC call ...

2012-02-10 Thread Stephan Bergmann
On 02/09/2012 06:54 PM, Michael Meeks wrote: * system stdlibs for Linux universal builds ? (Stephan/Petr) + https://bugs.freedesktop.org/show_bug.cgi?id=45696 + https://bugs.freedesktop.org/show_bug.cgi?id=45074 + problem is - that for generic RPMs/DEBs + w

Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

2012-02-10 Thread Kohei Yoshida
On Fri, 2012-02-10 at 18:23 +0100, Stefan Knorr (Astron) wrote: > Hi Petr, > > > I checked other applications, e.g. pidgin, xchat, gimp, kmail, > > evolution, firefox. They all have [Cancel] button in the about dialog. > > It is in the bottom right corner, like in the other dialogs. It is > > deli

Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

2012-02-10 Thread Ivan Timofeev
On 08.02.2012 23:49, Stephan Bergmann wrote: On 02/08/2012 07:13 PM, Ivan Timofeev wrote: I didn't try German, but see how it looks in Russian in the attached screenshot. The problem is that the new links start with '=' and are quoted. Looks like a bug somewhere. That looks suspiciously like a

Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

2012-02-10 Thread Stefan Knorr (Astron)
Hi Petr, > I checked other applications, e.g. pidgin, xchat, gimp, kmail, > evolution, firefox. They all have [Cancel] button in the about dialog. > It is in the bottom right corner, like in the other dialogs. It is > delimited from the text by a line. So, I did the same, see the attached > screen

Re: [REVIEW][3-4][PUSHED] fdo#36109 in INDIRECT() make a non-existing sheet produce an error again

2012-02-10 Thread Markus Mohrhard
Hey, 2012/2/8 Eike Rathke : > Hi, > > please review and cherry-pick to 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=0240cbf5bad319f82afe8fda9fb9f897e5e33e3d > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=36109 > Looks good to me. Pushed to 3-4 Markus

[REVIEW 3.5 (and maybe 3.4?)] fdo#42771: Fix crash when loading an invalid .fodt

2012-02-10 Thread Jan Holesovsky
Hi, We throw an uncatched exception: https://bugs.freedesktop.org/show_bug.cgi?id=42771 The fix is here: http://cgit.freedesktop.org/libreoffice/core/commit/?id=9951de4a10386a85dc1bfa465304cd0005414b8e Returning a 'I was unable create a cursor' value via throwing runtime exception [in SwXFootn

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 42771, which changed state. Bug 42771 Summary: Crash over invalid ODF https://bugs.freedesktop.org/show_bug.cgi?id=42771 What|Old Value |New Value

Re: [PUSHED 3-4] Couple of wiki-help related patches

2012-02-10 Thread Petr Mladek
Jan Holesovsky píše v Čt 09. 02. 2012 v 17:48 +0100: > Hi Muthu, > > Muthu Subramanian K píše v Čt 09. 02. 2012 v 19:12 +0530: > > > +1 Looks ok to me. > > > > PS: How many sign-off's would we need in these cases (script changes)? > > Just one is enough - so please push to libreoffice-3-x, if y

[PATCH] Remove unused code (8)

2012-02-10 Thread Elton Chung
Hi, This patch removes 10 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email/ IM : el...@elton.tk

[PATCH] Remove unused code (7)

2012-02-10 Thread Elton Chung
Hi, This patch removes another 4 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email/ IM : el...@elton.tk -

[PATCH] Remove unused code (6)

2012-02-10 Thread Elton Chung
Hi, The patch removes 4 unused methods. Best Regards, Elton -- Elton Chung Administrator, Sponsor of http://mirror.layerjet.com Language Maintainer, Tester of ReactOS Project | http://reactos.org Email : el...@layerjet.com ---

Re: [Libreoffice] [PUSHED-partially][PATCH]a better about dialog

2012-02-10 Thread Petr Mladek
Petr Mladek píše v Čt 09. 02. 2012 v 17:39 +0100: > Michael Meeks píše v St 08. 02. 2012 v 15:03 +: > > On Wed, 2012-02-08 at 12:48 +0100, Petr Mladek wrote: > > > Also I am not sure whether the following change is desired: > > > > > > --- cut --- > > > - Text[ en-US ] = "This product was supp

[PATCH] unusedcode.easy: Removed unused code

2012-02-10 Thread Alexander Bergmann
--- editeng/source/editeng/editdoc.cxx |8 editeng/source/editeng/editdoc.hxx |1 - linguistic/source/lngsvcmgr.cxx| 15 --- linguistic/source/lngsvcmgr.hxx|3 --- svtools/inc/svtools/imap.hxx |3 --- svtools/source/edit/svmedit.cxx|6 --

Re: [PUSHED][PATCH V2] convert detdata.cxx in SC module to boost:ptr_vector

2012-02-10 Thread Eike Rathke
Hi Noel, On Thursday, 2012-02-09 15:00:09 +0200, Noel Grandin wrote: > Attached path converts usage of SV_DECL_PTRARR_DEL in > sc/inc/detdata.hxx and associated code to boost::ptr_vector Pushed to master http://cgit.freedesktop.org/libreoffice/core/commit/?id=d4a31e6ae28825a42cb8b1935fdfd777cda4

Re: config_host doesn't set $PATH

2012-02-10 Thread Norbert Thiebaud
On Wed, Feb 8, 2012 at 4:38 AM, Korrawit Pruegsanusak wrote: > Hello Norbert, > > On Wed, Feb 8, 2012 at 17:07, Korrawit Pruegsanusak > wrote: >> Anyway, it doesn't set $PATH - the environment variables - like >> Env.host.sh did in the past, at least in cygwin. > > Sorry. The $PATH is already in

Re: Faster installation suggestion

2012-02-10 Thread Michael Meeks
On Fri, 2012-02-10 at 08:08 +0100, Wim de Lange wrote: > I was always wondering why it takes so long to calculate how much > space is needed, while I have space enough!!! Good question; do you have a UI string from that section so we can try to dig out the code that's doing it ? :-) > Th

Re: New tool for better understanding the codebase, to complement the wiki.

2012-02-10 Thread Thorsten Behrens
Josh Heidenreich wrote: > You can see the result here: > http://thejosh.info/libreoffice/module_readmes/ > So, wow again for this great work - I couldn't resist, and merged that up with the existing doxygen documentation, result is here: http://docs.libreoffice.org/ That stuff is currently gene

Re: [PATCH] New Unit test

2012-02-10 Thread Michael Meeks
Hi there, On Thu, 2012-02-09 at 21:15 +0100, Santiago Martinez wrote: > Hello, in file comphelper/qa/string/test_string.cxx there is a missing > unit test to check the method "islowerAsciiString(rtl::OString > const&)". Attached to this mail there is a patch to add this new test. > Please review.

Need help (mentor) while fixing an issue

2012-02-10 Thread Dag Wieers
Hi, I found a bug in LibreOffice causing style:rel-width and style:rel-height not to accept "scale" as a possible value. In fact the behavior seems to be to default to 100% if anything except percentages are provided. https://bugs.freedesktop.org/show_bug.cgi?id=45884 I reported the bug,

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||43229 -- Configure bugmail

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #179 from sasha.libreoff...@gmail.com 2012-02-10 07:29:46 PST --- regression since 3.4.5 Bug 43229 - Unable to un-protect password protected MS-Word .doc document -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=e

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Jan Holesovsky changed: What|Removed |Added Depends on|42470 | -- Configure bugmail: https://bugs.fr

Re: [PUSHED][3-5] use system stdlibs on Linux by default (fdo#45074, fdo#45696)

2012-02-10 Thread Miklos Vajna
On Fri, Feb 10, 2012 at 03:52:05PM +0100, Petr Mladek wrote: > the bundled stdlibs caused problems with 3rd-party extensions and > exceptions handling. It was decided on the last TSC call to use system > stdlibs for Linux bugs, see > http://lists.freedesktop.org/archives/libreoffice/2012-February/

[PUSHED][PATCH] Remove unused code (4)

2012-02-10 Thread Caolán McNamara
On Thu, 2012-02-09 at 02:44 +0800, Elton Chung wrote: > Hi, > This contribution is licensed under MPL 1.1 / GPL v3+ / LGPL v3+. Thanks for these, pushed now. C. p.s. Well, I did leave out the DDe* ones because at least some are used under windows, and it needs a bit more work to identify if they

[REVIEW][3-5] use system stdlibs on Linux by default (fdo#45074, fdo#45696)

2012-02-10 Thread Petr Mladek
Hi, the bundled stdlibs caused problems with 3rd-party extensions and exceptions handling. It was decided on the last TSC call to use system stdlibs for Linux bugs, see http://lists.freedesktop.org/archives/libreoffice/2012-February/025670.html I did this change in master, see http://cgit.freedes

[PATCH] unusedcode.easy: Removed unused code

2012-02-10 Thread Alexander Bergmann
--- l10ntools/inc/export.hxx |1 - l10ntools/source/merge.cxx | 16 tools/inc/tools/multisel.hxx |2 - tools/source/memtools/multisel.cxx | 45 --- unusedcode.easy| 11 -- vcl/inc/vcl/field.hxx

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 40261, which changed state. Bug 40261 Summary: [CRASH] - EDITing XML Form in Writer Causes crash https://bugs.freedesktop.org/show_bug.cgi?id=40261 What|Old Value |New Value -

[PATCH] Remove unused code (5)

2012-02-10 Thread Elton Chung
Hi, This patch removes 5 unused methods. Please also review and push http://lists.freedesktop.org/archives/libreoffice/2012-February/025571.html (Title: [PATCH] Remove unused code (4)). Best Regards, Elton -- Elton Chung Administrator, Sponsor of http://mirror.layerjet.com Language Maintainer,

[PUSHED]PATCH] unusedcode.easy: Removed unused code

2012-02-10 Thread Caolán McNamara
On Thu, 2012-02-09 at 21:18 +0100, Alexander Bergmann wrote: > --- > .../source/drivers/postgresql/pq_tools.cxx | 14 --- > .../source/drivers/postgresql/pq_tools.hxx |2 - > pyuno/inc/pyuno/pyuno.hxx | 11 -- > pyuno/source/module/pyuno_impl.hxx

[REVIEW 3.4 3.5] fdo#40261: Fix crash in XML Form Document

2012-02-10 Thread Jan Holesovsky
Hi, Can you please review a fix for: https://bugs.freedesktop.org/show_bug.cgi?id=40261 It targets both libreoffice-3-4, and libreoffice-3-5, please review and push the following there: http://cgit.freedesktop.org/libreoffice/core/commit/?id=8912cf30755a2a19d50acc3bb0f5352506638fad The commit

Re: Weird MSVC compilation error

2012-02-10 Thread Jesús Corrius
On Fri, Feb 10, 2012 at 3:12 PM, walter wrote: > Hi, > as I said my cygwin works fine, but I haven't then  'config_host.mk' file > in 'libo' (after a successful build). Many of my problems are probably because I am using a netbook to compile LibO on Windows. The computer also hangs many times dur

windows / cygwin build freezes using --with-lang=it [SOLVED]

2012-02-10 Thread walter
Using a different autogen.sh configuration all work fine and the build process generate the following installer: LibO-Dev_3.5.1rc0_Win_x86_install_en-US_it.msi My autogen.sh #--- ---

R: Weird MSVC compilation error

2012-02-10 Thread walter
Hi, as I said my cygwin works fine, but I haven't then 'config_host.mk' file in 'libo' (after a successful build). regards walter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

R: Weird MSVC compilation error

2012-02-10 Thread walter
I'm using CYGWIN_NT-6.1-WOW64 LAZY 1.7.9(0.237/5/3) 2011-03-29 10:10 i686 Cygwin without any problems. My autogen.sh is: _JOBS_="--with-max-jobs=4" _CPUS_="--with-num-cpus=4" _JUNIT_="--without-junit" _ANT_="--with-ant-home=/cygdrive/c/cygwin/libreoffice/apache-ant-1.8.2" _MOZ_="--disable-build-m

Re: Weird MSVC compilation error

2012-02-10 Thread Jesús Corrius
> Am I hallucinating or is there some weird randomness in the > Cygwin-based MSVC build nowadays? Just a moment ago I saw in > config_host.mk that ILIB didn't contain the ...solver\wntmsci12\lib > entry (which caused libxmlsec linking to fail). I started > investigating, added some debugging printo

Re: Weird MSVC compilation error

2012-02-10 Thread Tor Lillqvist
Oh well, let's hope a "make clean" helps;) I'll see on Monday. Am I hallucinating or is there some weird randomness in the Cygwin-based MSVC build nowadays? Just a moment ago I saw in config_host.mk that ILIB didn't contain the ...solver\wntmsci12\lib entry (which caused libxmlsec linking to fail)

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Michael Meeks
Hi Lubos, Rather ill today, but immensely encouraged by your work: On Thu, 2012-02-09 at 18:16 +0100, Lubos Lunak wrote: > Actually, no need for a week, this one is reasonably simple. Therefore I > challenge RTL_CONSTASCII_USTRINGPARAM to a fight to the death. Its death, > that is.

Re: Same expression on both sides of '|'

2012-02-10 Thread Caolán McNamara
On Thu, 2012-02-09 at 14:32 -0800, julien2412 wrote: > 0aaf3fb6af9dfa91b2597894930fdc8b23041308 > ... replaced this line (there are others) : > DEF_INFO_2( INSERTONLY,DATAENTRY, DATAENTRY, > FORM_VISIBLE, DATA_PROPERTY ), > by > this one : > DEF_INFO_4( INSERTONLY,D

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Lubos Lunak
On Friday 10 of February 2012, Stephan Bergmann wrote: > On 02/10/2012 12:18 PM, Lubos Lunak wrote: > > This is sal/, so the library needs to maintain binary compatibility, > > does it not? That requires adding the OUString overload rather than > > fixing the exiting function. I don't know if the

Re: [PATCH] New Unit test

2012-02-10 Thread Stephan Bergmann
On 02/10/2012 09:01 AM, Jan Holesovsky wrote: Santiago Martinez píše v Čt 09. 02. 2012 v 21:15 +0100: Hello, in file comphelper/qa/string/test_string.cxx there is a missing unit test to check the method "islowerAsciiString(rtl::OString const&)". Attached to this mail there is a patch to add this

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Stephan Bergmann
On 02/10/2012 12:18 PM, Lubos Lunak wrote: This is sal/, so the library needs to maintain binary compatibility, does it not? That requires adding the OUString overload rather than fixing the exiting function. I don't know if the const char* overload really needs the non-const variant as well, b

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Lubos Lunak
On Friday 10 of February 2012, Stephan Bergmann wrote: > On 02/10/2012 11:30 AM, Lubos Lunak wrote: > > +/** > > + * @overload > > + * @since LibreOffice 3.6 > > + */ > > +oslGenericFunction SAL_CALL getFunctionSymbol( const > > ::rtl::OUString& ustrFunctionSymbolName ) const +

Re: Weird MSVC compilation error

2012-02-10 Thread Tor Lillqvist
On 10 February 2012 12:08, Tor Lillqvist wrote: > cl : Command line error D8038 : invalid argument > [...] > -I/cygdrive/c/ooo/git/master/core/writerfilter/inc > [...] I guess it's more likely that the error refers to these bogus Cygwin pathnames. Hmm... --tml ___

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Stephan Bergmann
On 02/10/2012 11:30 AM, Lubos Lunak wrote: diff --git a/sal/inc/osl/module.hxx b/sal/inc/osl/module.hxx index c8d39a2..a7f9c35 100644 --- a/sal/inc/osl/module.hxx +++ b/sal/inc/osl/module.hxx @@ -152,11 +152,28 @@ public: return ( osl_getFunctionSymbol( m_Module, ustrFunctionSymbolName.p

Re: GNU make version

2012-02-10 Thread Michael Stahl
On 10/02/12 11:25, Bjoern Michaelsen wrote: > Hi, > > On Thu, Feb 09, 2012 at 09:23:56PM +, Michael Meeks wrote: >> commit 6055a5df7b6e7452987a9584d10f436ca2d349fd >> Author: Bjoern Michaelsen >> Date: Fri Oct 7 16:40:22 2011 +0200 >> >> no more gbuild loops: break early on nonexistent

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Lubos Lunak
On Friday 10 of February 2012, Stephan Bergmann wrote: > On 02/09/2012 06:16 PM, Lubos Lunak wrote: > > Attached is a patch that removes the need for > > RTL_CONSTASCII_USTRINGPARAM (henceafter called 'macro', because it annoys > > me to write this even in its death warrant) when using the OUStri

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Lubos Lunak
On Thursday 09 of February 2012, Caolán McNamara wrote: > On Thu, 2012-02-09 at 18:16 +0100, Lubos Lunak wrote: > > suggests that OString in fact does not stop at \0's when handling > > strings. I'm kind of baffled by this, I personally consider it a flaw > > that a string class does this, but the

Re: GNU make version

2012-02-10 Thread Bjoern Michaelsen
Hi, On Thu, Feb 09, 2012 at 09:23:56PM +, Michael Meeks wrote: > commit 6055a5df7b6e7452987a9584d10f436ca2d349fd > Author: Bjoern Michaelsen > Date: Fri Oct 7 16:40:22 2011 +0200 > > no more gbuild loops: break early on nonexistent objects (this commit > breaks multi-repo support)

sfx2 deprecated?

2012-02-10 Thread Winfried Donkers
Hello all, I just started working on the 45671-bug series that Astron created to split a lot of color-toolbar buttons. (thank you, Astron) The toolbar buttons are derived from SfxToolBoxControl. In the module readmes (haven't found out yet if

Weird MSVC compilation error

2012-02-10 Thread Tor Lillqvist
cl : Command line error D8038 : invalid argument '-IC:/ooo/git/master/core/solver/wntmsci12/inc/external -IC:/ooo/git/master/core/solver/wntmsci12/inc -IC:/ooo/git/master/core/solenv/inc/wntmsci12 -IC:/ooo/git/master/core/solenv/inc -IC:/ooo/git/master/core/res -IC:/PROGRA~2/Java/JDK16~2.0_2/includ

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Caolán McNamara
On Fri, 2012-02-10 at 11:54 +0200, Tor Lillqvist wrote: > It is a bit sad that the C++ people didn't come up with a new term > when "string" is already so encumbered by history. c-string, p/pascal/length-prefixed string, fucked/belt-and-braces strings ? http://www.joelonsoftware.com/articles/fog0

[PUSHED][PATCH] Remove unused code

2012-02-10 Thread Caolán McNamara
On Thu, 2012-02-09 at 21:02 +0100, Santiago Martinez wrote: > This patch removes unused code as listed in unusedcode.easy Looks good, pushed, thanks for this. C. p.s. of course, my intention was that *elses* utterly useless unused code should go, *mine* of course was a work in progress which I w

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Tor Lillqvist
> I'm kind of baffled by string classes that treat NUL specially.  :) Maybe we should stop overloading the word "string" for both the traditional C style zero byte -terminated string of bytes, and classes in C++ or other object-oriented languages that contain a one-dimensional array of characters

[PATCH] convert table.hxx use in editeng/source/editeng/editdoc.hxx

2012-02-10 Thread Noel Grandin
Hi Convert tools/table.hxx usage in editeng/source/editeng/editdoc.hxx to boost::ptr_map Contributed under LGPLv3+ / MPL 1.1 or later. (And my license statement is on file in the wiki) Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html diff --git a/editeng/source/edi

Re: Obsoleting RTL_CONSTASCII_USTRINGPARAM

2012-02-10 Thread Stephan Bergmann
On 02/09/2012 06:16 PM, Lubos Lunak wrote: Attached is a patch that removes the need for RTL_CONSTASCII_USTRINGPARAM (henceafter called 'macro', because it annoys me to write this even in its death warrant) when using the OUString ctor. Assuming this code compiles also with MSVC[*], the result

[REVIEW 3-5] fix RTF import of page breaks right before text frames

2012-02-10 Thread Miklos Vajna
Hi, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=63dfa72b5eca7be9df3076314055c5c74aa1f4fa It makes the RTF import not ignore page breaks right before text frames. Could somebody sign-off and push to -3-5, please? Thanks, Miklos ___ Lib

Re: Hosting LibreOffice online

2012-02-10 Thread drew
On Thu, 2012-02-09 at 20:23 +, Michael Meeks wrote: > On Thu, 2012-02-09 at 12:56 -0500, drew wrote: > > Hope you don't mind. > > Of course not ! :-) > > > Added Micheal's repo to SuseStudio. > > Neat. > > > From within an OpenSUSE 12.1 (32bit) vm project, go to the Software tab