Re: Patch: Fixed cppcheck messages about rethrowing copy of exception

2012-02-07 Thread Philipp Kloke
To avoid confusion: This patch has been applied in an updated version in commit ba5a460bc15393cc64522f288b7b2b678d6fcc99. Thanks! ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [PATCH V2] more conversion of tools/Table.hxx to std::map in editeng, sc and sw modules

2012-02-07 Thread Stephan Bergmann
On 02/08/2012 07:59 AM, Noel Grandin wrote: This I don't understand - maCharInfoMap is not declared const, so how can I make it mutable? In a const member function, all data members of this are implicitly treated as const, unless they are explicitly marked mutable. Stephan __

Re: [PATCH V2] more conversion of tools/Table.hxx to std::map in editeng, sc and sw modules

2012-02-07 Thread Noel Grandin
On 2012-02-08 08:40, David Tardon wrote: Why not split it into more patches, preferably one for each replaced class? It would make review easier (and it would also make revert of only one of the conversions easier, if it proves necessary ;-) A couple of comments: Sure, will do. IMHO it wou

Re: [PATCH] [PUSHED] Lots of module READMEs; libs-core, libs-gui, components, filter, base, calc

2012-02-07 Thread Josh Heidenreich
David, > And I just pushed the whole lot of it. Sweeet. Cool so I'm re-running the tool again at the moment, but it will be done in a couple of minutes. You can see the result here: http://thejosh.info/libreoffice/module_readmes/ Cheers, Josh ___ Libr

Re: [PATCH] [PUSHED] Lots of module READMEs; libs-core, libs-gui, components, filter, base, calc

2012-02-07 Thread David Tardon
On Wed, Feb 08, 2012 at 12:30:11PM +1030, Josh Heidenreich wrote: > Hi, > > As per my module README porting from wiki and improving project, here > are some more patches which add more READMEs. And I just pushed the whole lot of it. > > I sent an email yesterday, which seems to be missed, so I

Re: [PATCH] convert dptabres.cxx in SC module from SV_DECL_PTRARR_DEL to std::vector

2012-02-07 Thread David Tardon
On Wed, Feb 08, 2012 at 08:22:45AM +0200, Noel Grandin wrote: > how do I do a dbgutil build? Add --enable-dbgutil (and preferably --enable-debug too) to configure args. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freed

Re: [PATCH V2] more conversion of tools/Table.hxx to std::map in editeng, sc and sw modules

2012-02-07 Thread David Tardon
On Tue, Feb 07, 2012 at 05:02:18PM +0200, Noel Grandin wrote: > Hi > > Attached patch converts various places in the editeng, sc and sw > modules from using tools/table.hxx to using std::map Why not split it into more patches, preferably one for each replaced class? It would make review easier (a

Re: [PATCH] convert dptabres.cxx in SC module from SV_DECL_PTRARR_DEL to std::vector

2012-02-07 Thread Noel Grandin
how do I do a dbgutil build? On 2012-02-07 21:00, Markus Mohrhard wrote: Hello Noel, 2012/2/7 Noel Grandin: Hi Note that I did not use boost::ptr_vector because that would have meant switching to using references everywhere, and the existing logic makes use of NULL values, so I left that for

Re: [Review] [Pushed: 3-5] PPTX master slide import problems

2012-02-07 Thread David Tardon
On Tue, Feb 07, 2012 at 04:51:58PM +0530, Muthu Subramanian K wrote: > Hello, > > It would be nice to have > http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd33c0b1cf23020b27db25895eeb380653d734b6 > on 3.5.x (at least on 3.5.1 ?) branch. > > The problem is because we set the master slide

Re: [PATCH] Lots of module READMEs; libs-core, libs-gui, components, filter, base, calc

2012-02-07 Thread Josh Heidenreich
Update: David just pushed 0001-Added-READMEs-for-modules-which-used-to-be-in-libs-c.patch, so don't push it again! On Wed, Feb 8, 2012 at 12:30 PM, Josh Heidenreich wrote: > Hi, > > As per my module README porting from wiki and improving project, here > are some more patches which add more READ

Re: [PATCH] [PUSHED] More READMEs for modules!

2012-02-07 Thread David Tardon
On Tue, Feb 07, 2012 at 02:20:46PM +1030, Josh Heidenreich wrote: > Hi everyone who cares, > > Here is a patch for more READMEs for the modules (yay). I'm about 1/3 > done with this project now. Pushed, thanks. D. ___ LibreOffice mailing list LibreOffi

[PATCH] Lots of module READMEs; libs-core, libs-gui, components, filter, base, calc

2012-02-07 Thread Josh Heidenreich
Hi, As per my module README porting from wiki and improving project, here are some more patches which add more READMEs. I sent an email yesterday, which seems to be missed, so I have included that patch again. I also did a heap more READMEs, thus why there is five patches instead of just one. It

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

2012-02-07 Thread Eike Rathke
Hi, On Sunday, 2012-02-05 19:42:14 -0600, Norbert Thiebaud wrote: > If you have the need to run a specific command that is not covered by > the standard target, but need to have all the environment variable > set, you can do: > make cmd cmd="" In case someone needs (parts of) a sourceable enviro

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

2012-02-07 Thread Markus Mohrhard
Hey, I added the list back again. 2012/2/7 Dag Wieers : > On Tue, 7 Feb 2012, Markus Mohrhard wrote: > >> But keep in mind that this is nothing that will be fast. I needed >> around one week to check a bit more than 4000 files. Anyway it would >> be great if you could help out doing the same for

Re: Conversion Borderline2 to Borderline

2012-02-07 Thread Eike Rathke
Hi Dietmar, On Saturday, 2012-02-04 18:47:40 +0100, Dietmar wrote: > is there a method to convert Borderline2 to Borderline (and vice versa), > I can use in a Java extension? Unfortunately not. > Background is that I have the linestyle and linewidth in Borderline2 and > I want to apply those to

Re: [RFC] x11 / cairo-less build try #2

2012-02-07 Thread Matúš Kukan
Hello there, On 7 February 2012 18:19, Riccardo Magliocchetti wrote: > I've progressed a bit with X11 / cairo less build. Now everything builds but > somethings chokes in make dev-install: > > http://pastebin.com/qsi0wPFR > > Where are these missing files listed? I suppose i have to add some > co

Re: [PUSHED][REVIEW][3-{4,5}] fdo#45115 "double" table border API regression

2012-02-07 Thread Eike Rathke
Hi Michael, On Friday, 2012-02-03 22:38:56 +0100, Michael Stahl wrote: > proposing 2 commits to fix bug in Writer and Calc for libreoffice-3-5 > and libreoffice-3-4: Make sense. > http://cgit.freedesktop.org/libreoffice/core/commit/?id=ef9881001e4ddfa6bfbe7d83f482393bb76d926a > > http://cgit.f

Re: helpcontent2 not building: SOLARSRC undefined

2012-02-07 Thread Andras Timar
Hi Gert, 2012/2/7 Gert van Valkenhoef : > Dear LibreOffice developers, > > After successfully building LO on Sunday, the most recent pull from Git left > me with a failed build. I have re-run ./autogen.sh, but did not have time to > 'make clean && make'. I did 'make helpcontent2.clean && make help

helpcontent2 not building: SOLARSRC undefined

2012-02-07 Thread Gert van Valkenhoef
Dear LibreOffice developers, After successfully building LO on Sunday, the most recent pull from Git left me with a failed build. I have re-run ./autogen.sh, but did not have time to 'make clean && make'. I did 'make helpcontent2.clean && make helpcontent2', but to no avail. The failure log is

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

2012-02-07 Thread Markus Mohrhard
Hey, 2012/2/7 Caolán McNamara : > On Tue, 2012-02-07 at 20:32 +0100, Dag Wieers wrote: >> Do we >> have tests doing automated QA (conversions) to test export filters and are >> we using fuzzing techniques to test our import filters ? > > I've personally been to-date more interested in automated im

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

2012-02-07 Thread Caolán McNamara
On Tue, 2012-02-07 at 20:32 +0100, Dag Wieers wrote: > Do we > have tests doing automated QA (conversions) to test export filters and are > we using fuzzing techniques to test our import filters ? I've personally been to-date more interested in automated import filter tests, typically various bi

Re: Errror building LO lang=it - windows / cygwin

2012-02-07 Thread Andras Timar
2012/2/7 Andras Timar : > 2012/2/7 walter : >> Error in ‘reportbuilder’. >> >> >> >> Please see logs AT http://pastebin.com/u/walterLO >> > > This line is suspicious: > Warning : Can't open > C:/libo/translations/wntmsci12.pro/misc/sdf/reportbuilder/util/localize.sdf > > I think it is a regression

Re: How far can the LO file's contents be stretched?

2012-02-07 Thread Johannes Sixt
Am 06.02.2012 23:32, schrieb Michael Stahl: > i think merge document is probably based on compare documents, and last > i looked at that in Writer it was so horribly broken it would need years > to fix (being based on Writer's horrible redlining is just the start...). Oh no! I'd like to have somet

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

2012-02-07 Thread Dag Wieers
On Tue, 7 Feb 2012, Cor Nouws wrote: But the quick look I had at the rough list in the train this morning, showed crashes and such but as far as I could judge with special documents. Great issues to solve for the next release(s) ... I can demonstrate issues with some filters during conversion

Re: [PATCH] convert dptabres.cxx in SC module from SV_DECL_PTRARR_DEL to std::vector

2012-02-07 Thread Markus Mohrhard
Hello Noel, 2012/2/7 Noel Grandin : > Hi > > Note that I did not use boost::ptr_vector because that would have meant > switching to using references everywhere, and the existing logic makes use > of NULL values, so I left that for a future patch. > It is a good idea to check for these conversions

[PUSHED] Re: [REVIEW 3-5] fdo#45045 fix context sensitive help for Word Count dialog

2012-02-07 Thread Michael Stahl
On 06/02/12 16:18, Andras Timar wrote: > Hi, > > I fixed https://bugs.freedesktop.org/show_bug.cgi?id=45045, help now > jumps to the correct page either when I press F1, or when I press the > Help button. However, the fix looks a bit hackish to me, help for old > modal dialog worked well in 3.4 wi

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

2012-02-07 Thread Cor Nouws
Hi Petr, Petr Mladek wrote (07-02-12 11:01) So, though the overall impression is OK (as is with builds from the master) as long that checking issues from the last weeks is not clear, I would not bet on it. I have the same feeling. (I read your text below as the opposite ;-) ) Well, we hav

Re: [PATCH] [PUSHED] convert dptabres.cxx in SC module from SV_DECL_PTRARR_DEL to std::vector

2012-02-07 Thread Kohei Yoshida
Hi Noel, On Tue, 2012-02-07 at 18:40 +0200, Noel Grandin wrote: > Note that I did not use boost::ptr_vector because that would have meant > switching to using references everywhere, and the existing logic makes > use of NULL values, so I left that for a future patch. There is an easy trick to

Re: [PUSHED][REVIEW][3-4] fdo#37024 forms web layout regression

2012-02-07 Thread Noel Power
On 07/02/12 11:54, Michael Stahl wrote: so we need backport 3 commits for 3.4: fdce768122e54dff8343ab20179f3b1d7c6867e6 2b39501b8ec6affb8afa9c6b93dff434b075e211 9d32497c01475f2b5e5bec756e4dd0ca9f9d4928 pushed this extra one to 3-4 too anyway, like the previous one, assuming the build ( and

Re: [Libreoffice] [PUSHED][REVIEW][3-{4, 5}] fdo#45446 fdo#45449 fdo#45450 fdo#45534: various invalid ODF problems

2012-02-07 Thread Noel Power
Pushed all ( with the exception noted below ) to 3.4 and 3.5 Noel On 07/02/12 11:05, Noel Power wrote: I seem to have invalidated all my build trees, while waiting I saw this unreviewed so to me these look good and make sense, however I don't mark this thread as pushed yet, still awaiting local

[RFC] x11 / cairo-less build try #2

2012-02-07 Thread Riccardo Magliocchetti
Hello, I've progressed a bit with X11 / cairo less build. Now everything builds but somethings chokes in make dev-install: http://pastebin.com/qsi0wPFR Where are these missing files listed? I suppose i have to add some conditionals. Attached all the changes that i have locally, they are di

Re: SfxItemSet::HasItem method

2012-02-07 Thread Kohei Yoshida
On Tue, 2012-02-07 at 17:26 +0100, Miklos Vajna wrote: > I've introduced a few usage of HasItem in > sw/source/filter/ww8/rtfattributeoutput.cxx, so checking if sw builds > after your changes may make sense. ;-) Yup, I've noticed. :-) Thanks for mentioning. sw should build, as I've double-check

Re: Errror building LO lang=it - windows / cygwin

2012-02-07 Thread Andras Timar
Hi, 2012/2/7 walter : > Error in ‘reportbuilder’. > > > > Please see logs AT http://pastebin.com/u/walterLO > This line is suspicious: Warning : Can't open C:/libo/translations/wntmsci12.pro/misc/sdf/reportbuilder/util/localize.sdf I think it is a regression from the 'killing set_soenv project',

[PATCH] convert dptabres.cxx in SC module from SV_DECL_PTRARR_DEL to std::vector

2012-02-07 Thread Noel Grandin
Hi Note that I did not use boost::ptr_vector because that would have meant switching to using references everywhere, and the existing logic makes use of NULL values, so I left that for a future patch. Code is contributed under MPL+/LGPL+/GPL+ Regards, Noel Grandin Disclaimer: http://www.per

Re: SfxItemSet::HasItem method

2012-02-07 Thread Miklos Vajna
On Tue, Feb 07, 2012 at 11:13:44AM -0500, Kohei Yoshida wrote: > But then now that you mention it, maybe you have a point, and I agree > that having an extra & may make it more obvious that it's an optional > argument. > > I'll make that change. I've introduced a few usage of HasItem in sw/sour

Re: [ANNOUNCE] Changes to the build system: Env.Host.sh is dead so is the need to source the environment

2012-02-07 Thread Kohei Yoshida
On Sun, 2012-02-05 at 19:42 -0600, Norbert Thiebaud wrote: > I have pushed a series of commit that completely remove set_soenv.in > and the creation of Env.Host.sh/Env.Build.sh BTW, it's great to not have to source Env.Host.sh for partial module build. :-) I didn't think much about it at the tim

Re: SfxItemSet::HasItem method

2012-02-07 Thread Kohei Yoshida
On Tue, 2012-02-07 at 13:56 +0100, Lubos Lunak wrote: > On Monday 06 of February 2012, Kohei Yoshida wrote: > > Hi there, > > > > I've just added a new method to SfxItemSet to provide an easy way to > > check whether or not an item is already set, and if it's already set, > > get that item. Here i

[PUSHED][PATCH] Fixed cppcheck messages about rethrowing copy of exception

2012-02-07 Thread Caolán McNamara
On Fri, 2012-02-03 at 14:12 +0100, Philipp Kloke wrote: > This is my first patch to LO. Please have a look on it and let me know > if it is ok. Looks good to me. Also looks like Julien pushed this on Sunday. Thanks for this. Can you add yourself to http://wiki.documentfoundation.org/Development/D

Errror building LO lang=it - windows / cygwin

2012-02-07 Thread walter
Error in 'reportbuilder'. Please see logs AT http://pastebin.com/u/walterLO regards walter ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 khagar...@gmail.com changed: What|Removed |Added Depends on|45042 |43644 -- Configure bugmail: https:

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 45042, which changed state. Bug 45042 Summary: The Document Converter wizard is crashing on Windows OSs https://bugs.freedesktop.org/show_bug.cgi?id=45042 What|Old Value |New Value --

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36756, which changed state. Bug 36756 Summary: Impress: External links break in pdf export which includes notes (OO patch available) https://bugs.freedesktop.org/show_bug.cgi?id=36756 What|Old Value

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-02-07 Thread Paolo Marcheschi
Hi do you have any success in compiling Libreoffice on Openindiana ? Greetings Paolo Marcheschi -- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/li

[PATCH V2] more conversion of tools/Table.hxx to std::map in editeng, sc and sw modules

2012-02-07 Thread Noel Grandin
Hi Attached patch converts various places in the editeng, sc and sw modules from using tools/table.hxx to using std::map The one place I was not sure of was the naming the new typedefs in sc/inc/chartpos.hxx, mostly because I have only a vague idea what the code is trying to accomplish. Up

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-02-07 Thread Jonathan Adams
ran out of time ... will try again in a week if the projects I'm on start to lessen. On 7 February 2012 14:40, Paolo Marcheschi wrote: > Hi > Do you have had any success in compiling Libreoffice on Openindiana ? > > Thank you > > Paolo Marcheschi > > __

Re: How to compile Calc

2012-02-07 Thread Tor Lillqvist
> I have check out a new copy of calc libreoffice-3-4 project There is no separate Calc "project" that one could build. You have been mislead by the fact that we used to have the source code split up in a bunch of separate Git repositories, one being called "calc". That doesn't man one would be ab

Re: [Libreoffice] LibreOffice / openIndiana ...

2012-02-07 Thread Paolo Marcheschi
Hi Do you have had any success in compiling Libreoffice on Openindiana ? Thank you Paolo Marcheschi ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 39724, which changed state. Bug 39724 Summary: LibreOffice is not able to load flat xml .ods document any more https://bugs.freedesktop.org/show_bug.cgi?id=39724 What|Old Value |New Valu

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 sasha.libreoff...@gmail.com changed: What|Removed |Added Depends on||42771 -- Configure bugmail

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #176 from sasha.libreoff...@gmail.com 2012-02-07 06:14:17 PST --- regression since 3.3.4 Writer crashes opening fodt file Bug 42771 - Crash over invalid ODF -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email -

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||45117 --- Comment #175 from Petr Mladek 2

Re: SfxItemSet::HasItem method

2012-02-07 Thread Caolán McNamara
On Mon, 2012-02-06 at 14:49 -0500, Kohei Yoshida wrote: > Just FYI. FWIW, sw/source/filter/ww8/writerhelper.hxx HasItem is sort of similar, and there's some other stuff in there (written a long time ago) which might have some utility up higher. No guarantees. C. _

Re: SfxItemSet::HasItem method

2012-02-07 Thread Lubos Lunak
On Monday 06 of February 2012, Kohei Yoshida wrote: > Hi there, > > I've just added a new method to SfxItemSet to provide an easy way to > check whether or not an item is already set, and if it's already set, > get that item. Here is what I've added: > > bool SfxItemSet::HasItem(sal_uInt16 nWhich,

Re: [REVIEW][3-{4, 5}] fdo#37024 forms web layout regression

2012-02-07 Thread Michael Stahl
On 07/02/12 12:39, Noel Power wrote: > Hi Michael > On 02/02/12 13:56, Michael Stahl wrote: >> hi all, >> >> these 2 patches should fix regression fdo#37024 so that forms open in >> web layout again: >> >> this one is from an OOo 3.4 CWS and is in 3-5 already, should fix the >> edit mode half-way,

Re: [Libreoffice] [REVIEW][3-{4, 5}] fdo#37024 forms web layout regression

2012-02-07 Thread Noel Power
Hi Michael On 02/02/12 13:56, Michael Stahl wrote: hi all, these 2 patches should fix regression fdo#37024 so that forms open in web layout again: this one is from an OOo 3.4 CWS and is in 3-5 already, should fix the edit mode half-way, proposed for libreoffice-3-4: 2b39501b8ec6affb8afa9c6b93df

Re: [Libreoffice] [REVIEW][3-{4, 5}] fdo#45446 fdo#45449 fdo#45450 fdo#45534: various invalid ODF problems

2012-02-07 Thread Noel Power
I seem to have invalidated all my build trees, while waiting I saw this unreviewed so to me these look good and make sense, however I don't mark this thread as pushed yet, still awaiting local builds ( for 3.4 I had to manually tweak as git am didn't like some fuzz and some other minor differen

Re: [REVIEW][PUSHED] RTF import: an empty table grid can't have implicit merges

2012-02-07 Thread Cedric Bosdonnat
Hi Miklos, On Tue, 2012-02-07 at 10:25 +0100, Miklos Vajna wrote: > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=75378a82e1a9e921cebe221427baca24cad47baf > > It fixes a crash when implicit mergeded cells and nested tables are > involved. > > Could you sign-off and push to -3-5,

[Review] [Patch] [3.5.x] PPTX master slide import problems

2012-02-07 Thread Muthu Subramanian K
Hello, It would be nice to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd33c0b1cf23020b27db25895eeb380653d734b6 on 3.5.x (at least on 3.5.1 ?) branch. The problem is because we set the master slide name with already existing one (which is not allowed in lo) Thank you so much for

Re: [REVIEW][3-4][3-5][PUSHED] fdo#38745 redline undo regression

2012-02-07 Thread Stephan Bergmann
On 02/07/2012 11:23 AM, Michael Stahl wrote: the fix for this ridiculous bug from the "why C++ is not my favourite language" series needs to go into libreoffice-3-5 and libreoffice-3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=13424b43c25389e303774c3fb2f2beb3e20ceae5 :) Pushed

[REVIEW][3-4][3-5] fdo#38745 redline undo regression

2012-02-07 Thread Michael Stahl
hi all, the fix for this ridiculous bug from the "why C++ is not my favourite language" series needs to go into libreoffice-3-5 and libreoffice-3-4: http://cgit.freedesktop.org/libreoffice/core/commit/?id=13424b43c25389e303774c3fb2f2beb3e20ceae5 ___ L

[Bug 35673] LibreOffice 3.4 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 38745, which changed state. Bug 38745 Summary: redlining / undo document breakage / corruption https://bugs.freedesktop.org/show_bug.cgi?id=38745 What|Old Value |New Value ---

Re: [Libreoffice-qa] Issues with 3.5.0 - ready for release ...

2012-02-07 Thread Petr Mladek
Cor Nouws píše v Út 07. 02. 2012 v 01:08 +0100: > Hi, > > As promised to Thorsten on Sunday, I've been looking at 3.5.0 and issues. > > I looked at issues that I've seen, that are at 37361 and at the 44 > issues filed during our second BugHuntSession (little delay :-\ ) > > Added some comments,

[REVIEW] RTF import: an empty table grid can't have implicit merges

2012-02-07 Thread Miklos Vajna
Hi Cedric, See http://cgit.freedesktop.org/libreoffice/core/commit/?id=75378a82e1a9e921cebe221427baca24cad47baf It fixes a crash when implicit mergeded cells and nested tables are involved. Could you sign-off and push to -3-5, please? Thanks, Miklos

[Bug 37361] LibreOffice 3.5 most annoying bugs

2012-02-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||33791 --- Comment #174 from Petr Mladek 2

Re: [PUSHED] Reduced duplicate code (simian) / l10ntools

2012-02-07 Thread Chr. Rossmanith
Am 06.02.2012 18:30, schrieb Ivan Timofeev: Ok, pushed, the patch is simply brilliant now! ;) Glad to hear that :-) I apologize for my hair-splitting while reviewing it. To be honest, I prefer improving a patch step by step on my own instead of having someone "tweaking it a little". Maybe the