[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on||44208 --- Comment #253 from Rainer Bi

Re: [Libreoffice] [Pushed] [PATCH] Comment translation & removal of commented-out code in svdraw

2012-01-23 Thread Muthu Subramanian K
Hi, Thank you for the cool patch(s). Pushed - except for the code in svx/source/svdraw/svdoole2.cxx - I felt there were some commented code which acts like pointers for the TODOs - would you like to relook at this, please? Thanks a lot! ( and of course, looking for more...:) ) Muthu Subramanian

Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-23 Thread Muthu Subramanian K
Hi, I am somehow not yet convinced. I would want to wait for a second opinion. Thanks! Muthu Subramanian On 01/23/2012 03:38 PM, Marcel Metz wrote: > Hello Muthu, > > On 23.01.2012 09:19, Muthu Subramanian K wrote: >> Before pushing, it would be great to understand the reason behind >> replacin

[Libreoffice] [REVIEW][3-5] Fix pivot table's date and number grouping

2012-01-23 Thread Kohei Yoshida
Hi there, I would like http://cgit.freedesktop.org/libreoffice/core/commit/?id=2c659e692a17cc10d364a2304bead9403fc6bdde to be backported to the 3-5 branch. It fixes https://bugs.freedesktop.org/show_bug.cgi?id=45067 Review and sign-off appreciated. Kohei -- Kohei Yoshida, LibreOffice hacke

[Libreoffice] Build fails for Tail_build

2012-01-23 Thread Anurag Jain
Hello there, I've been building LO and it seems build is failing for me in tail_build for one of the unit test. I asked about if there is any work around other than cleaning and rebuilding this big chunk in the main channel. Didn't get reply there so I'm posting it to the list here. It failed with

Re: [Libreoffice] [PATCH] Fix for bug fdo#44110, New Math symbols issues in Windows

2012-01-23 Thread Olivier Hallot
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Guys I have fixed and pushed in master this issue, but it should be cherry-picked into 3.5 It will look ugly if we don't. https://bugs.freedesktop.org/show_bug.cgi?id=44110 Regards Olivier Em 04-01-2012 13:55, Michael Meeks escreveu: > > On

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #137 from Cor Nouws 2012-01-23 15:53:25 PST --- (In reply to comment #136) > If we need to ensure the same order in an unordered map container, then all > bets are off. I'll leave it at that. No more input from me. pls consider to

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #136 from Kohei Yoshida 2012-01-23 15:47:44 PST --- (In reply to comment #135) > (In reply to comment #134) > > Bug 45084 is not a regression even though it may seem like one to some > > users. > > the bug report currenly shows no

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #135 from Cor Nouws 2012-01-23 15:29:09 PST --- (In reply to comment #134) > Bug 45084 is not a regression even though it may seem like one to some users. the bug report currenly shows no consensus about it being not a regression ..

Re: [Libreoffice] [PATCH] optimized zoom to use more common intervals

2012-01-23 Thread Tim Hardeck
Hi Stefan, thanks for testing. If 25% is an important number the function enforceStep could be used, if my patch gets accepted. But if other/more specific numbers are also important we really should consider using static/preprocessed zooming levels instead like the Adobe Reader seems to have.

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #134 from Kohei Yoshida 2012-01-23 14:43:32 PST --- Bug 45084 is not a regression even though it may seem like one to some users. I gave my reason in that bug report. Please consider removing it from the list. -- Configure bugmai

Re: [Libreoffice] Problems with mozilla build-tools on WindowsXP

2012-01-23 Thread Mat M
Hi Makoto Le Thu, 24 Nov 2011 02:46:53 +0100, Makoto Takizawa a écrit: hi I just success build on windows and wrote a note on wiki. https://wiki.documentfoundation.org/User:Foral/Build_Win Glad you succeed ! I ma still a bit surprised by the fact you had no issue with (x86) in your paths

[Libreoffice] [REVIEW][3-5] Fix for pivot table refresh problem

2012-01-23 Thread Kohei Yoshida
Hi there, I'd like to have http://cgit.freedesktop.org/libreoffice/core/commit/?id=561b044d62f4701e51abb4a7c47ce3b07f788f8e cherry-picked to 3-5. This is a follow-up to my earlier changes in the pivot table code which somewhat changes the way pivot tables are refreshed. In short, Calc current

[Libreoffice] [PUSHED][REVIEW] Re: minor problems with format -> page -> organizer

2012-01-23 Thread Caolán McNamara
On Sat, 2012-01-07 at 21:37 +0200, Lior Kaplan wrote: >Pushed Just marking this thread as pushed and both items apparently resolved. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreo

Re: [Libreoffice] LO and address book wizard

2012-01-23 Thread Caolán McNamara
On Mon, 2011-11-21 at 11:39 -0500, Arno Teigseth wrote: > Hi > > Anyone else having trouble with adding address books to Libreoffice > (File->Wizard->Address book). > > I'm getting "SDBC error" on my system, _git master LO_ on linux mint > 11. Have both thunderbird (repo) and evolution (repo) ins

Re: [Libreoffice] gbuild: variables in user makefiles

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 12:34 PM, Michael Stahl wrote: if you have to define variables in user makefiles (and in officecfg there is a good reason to do that), then please note that they will eventually end up in a single make process for the whose office, so please prevent namespace collisions by prefixing

[Libreoffice] [PUSHED] "Found duplicate branches for if and else" in dbtree.cxx

2012-01-23 Thread julien2412
Pushed on master. Thank you Michael and Caolán for your opinion. Julien. -- View this message in context: http://nabble.documentfoundation.org/Found-duplicate-branches-for-if-and-else-in-dbtree-cxx-tp3677444p3682977.html Sent from the Dev mailing list archive at Nabble.com.

[Libreoffice] Wrong cast to css.table.BorderLine2

2012-01-23 Thread Stephan Bergmann
Valgrind'ing sc_unoapi unearthed Creating: sc.ScAutoFormatFieldObj LOG> Log started 23.00.2012 - 21:27:56 LOG> create Object ... Environment created LOG> Log started 23.00.2012 - 21:28:21 checking: [sc.ScAutoFormatFieldObj::com::sun::star::beans::XPropertySet] is iface: [com.sun.star.beans.XPro

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44040, which changed state. Bug 44040 Summary: VIEWING: Crash when page preview after (data sources) https://bugs.freedesktop.org/show_bug.cgi?id=44040 What|Old Value |New Value

[Libreoffice] Handling ordering problem when properties are set one by one

2012-01-23 Thread Lubos Lunak
Hello, I have a bug that's related to databases in Writer (menu->Edit->Exchange Database and RES_HIDDENTXTFLD). The code that triggers it does a copy of the document in order to do the necessary substitutions there (well, this all is at least how I understand it) and during the copying it co

[Libreoffice] [PUSHED] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-23 Thread julien2412
Pushed on master and 3.5 branch. Julien. Caolán : I didn't succeed in putting you as the git author. Don't hesitate to update it :-) -- View this message in context: http://nabble.documentfoundation.org/PATCH-proposed-fix-for-fdo-44040-seems-iterator-issue-only-tp3659513p3682917.html Sent from

Re: [Libreoffice] sc_unoapi failure

2012-01-23 Thread Eike Rathke
Hi Kohei, On Monday, 2012-01-23 11:55:15 -0500, Kohei Yoshida wrote: > > maItems.erase(maItems.end() - 1); > > Thanking a bit further, maybe changing that to > > maItems.erase(maItems.begin() + nIndex); > > should fix the crash? It did, muchas gracias :-) Eike -- LibreOffice

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 06:51 PM, drew wrote: These are not scriptable tests..but if I can get a daily build with the update I'll do it all against pg and push the tests and results up to the wiki ASAP. FYI, the changes to postgresql-sdbc should be in LO 3.5 rc2 as well as in any master builds that are

[Libreoffice] [REVIEW] rhbz#746174 ODF export: numbering restart lost

2012-01-23 Thread Michael Stahl
the following fix for libreoffice-3.5: seems that under very special circumstances we don't export a list restart if the paragraph has only the restart flag set but no start value set. not a regression as far as i can tell; broken since OOo 3.0.1 at least. fixed on master: http://cgit.freedeskt

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #133 from Petr Mladek 2012-01-23 11:18:55 PST --- (In reply to comment #100) > Possible regression from 3.3.4 if confirmed: > Bug 44829 - Impress EDITING: Undo not works when change master page Nice catch. I see it also with 3.4.5. I

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #132 from Petr Mladek 2012-01-23 10:37:01 PST --- (In reply to comment #102) > possible regression, if confirmed: > Bug 44856 - Calc: font on screen looks corrupted It has been fixed in the meantime. -- Configure bugmail: https://b

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44862, which changed state. Bug 44862 Summary: Writer EDITING: LibO crashes when attempt to copy-paste from Calc and undo results https://bugs.freedesktop.org/show_bug.cgi?id=44862 What|Old Value

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on|44863 | -- Configure bugmail: https://bugs.freed

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||44862 --- Comment #131 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||44863 --- Comment #130 from Petr Mladek 2

[Libreoffice] [Bug 41883] MinGW port Most Annoying Bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41883 --- Comment #12 from Rainer Bielefeld 2012-01-23 10:22:52 PST --- I add "Bug 44489 - MinGW: Will not launch" -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You ar

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread drew
On Mon, 2012-01-23 at 15:28 +0100, Lionel Elie Mamane wrote: > On Mon, Jan 23, 2012 at 02:20:31PM +0100, Stephan Bergmann wrote: > > On 01/23/2012 01:45 PM, Lionel Elie Mamane wrote: > > >> Users loose the feature to use a newer PostgreSQL-SDBC with an > >> older LibreOffice. But Fridrich and you

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #129 from Petr Mladek 2012-01-23 10:16:41 PST --- (In reply to comment #104) > possible regression, if confirmed: > Bug 44863 - Calc EDITING: when recovered after crash, impossible to enter into > cells Great catch. Well, let's leave

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 GerardF changed: What|Removed |Added Depends on||45067 --- Comment #128 from GerardF 2012-01-2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #127 from Petr Mladek 2012-01-23 10:01:22 PST --- (In reply to comment #105) > users from opennet.ru very complain on this bug: > Bug 40540 - FILESAVE During DOC export drawing is lost The objects are somehow special. Normal drawing

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||40539 --- Comment #126 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #125 from Petr Mladek 2012-01-23 09:36:16 PST --- (In reply to comment #114) > Can I nominate Bug 34531 Let's leave it outside the list for now. I am not sure how many users are affected. The bug has already got some attention. It wo

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||44719 --- Comment #124 from Petr Mladek 2

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||33302 --- Comment #123 from Petr Mladek 2

Re: [Libreoffice] [REVIEW][3-5][PUSHED] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 03:41 PM, Fridrich Strba wrote: Go for it ! Pushed now as with a few additional changes: fixed a typo in postgresql/makefile.mk that caused the -impl lib's UNO s

[Libreoffice] gnumake / header install & timestamps ...

2012-01-23 Thread Michael Meeks
Hi Alex, On Sat, 2012-01-21 at 18:01 +0100, Alex Thurgood wrote: > Just reporting back to say that it built fine in the end. Thanks for the report - it's really good to get these confirmations of extraordinary problems. I saw one over the weekend - where clearly code had been partially re

Re: [Libreoffice] sc_unoapi failure

2012-01-23 Thread Kohei Yoshida
On Mon, 2012-01-23 at 11:51 -0500, Kohei Yoshida wrote: > maItems.erase(maItems.end() - 1); Thanking a bit further, maybe changing that to maItems.erase(maItems.begin() + nIndex); should fix the crash? -- Kohei Yoshida, LibreOffice hacker, Calc ___

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Pedro Lino
Hi Rimas, all I think you'd just have to choose which label to use. Correctly matching > key names with the keyboard model is hardly impossible. I would say you'd > just have to choose whether to use Inserir or Insert, and stick to that > choice. Which strings you would choose would be completely

Re: [Libreoffice] [REVIEWED][PUSHED 3-5][PUSHED3-4] resolved rhbz#783556 crash in Calc interpreter

2012-01-23 Thread Kohei Yoshida
On Mon, 2012-01-23 at 16:03 +0100, Eike Rathke wrote: > Hi, > > please review and cherry-pick to 3-5 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=a7769e27849b74102e11540d7753576528323114 > > Resolves https://bugzilla.redhat.com/show_bug.cgi?id=783556 crash in > Calc interpret

Re: [Libreoffice] DisposedException on storeToURL

2012-01-23 Thread Caolán McNamara
On Mon, 2011-11-07 at 11:35 -0500, Grover Blue wrote: > I filed the following bug, but I'm hoping to get some help a bit > sooner. > > https://bugs.freedesktop.org/show_bug.cgi?id=42314 Works for me unfortunately. Would need a standalone reproducer program I think, e.g. backtrace suggests that ta

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] [PUSHED 3-5] fdo#45032 Calc export to HTML

2012-01-23 Thread Kohei Yoshida
On Sun, 2012-01-22 at 20:24 +0100, Eike Rathke wrote: > Hi, > > Please review and cherry-pick to 3.5.0 and 3-4 > http://cgit.freedesktop.org/libreoffice/core/commit/?id=d180de79b82d1a73cfd914dd9a1524109c5e78ee > > Resolves https://bugs.freedesktop.org/show_bug.cgi?id=45032 > Calc export to HTML w

[Libreoffice] REMINDER: Release 3.5.0-rc2 from libreoffice-3-5 branch

2012-01-23 Thread Petr Mladek
Hi, please note that the commit deadline for 3.5.0-rc2 is today, January 23, 2012. The branch libreoffice-3-5-0 is going to be created the day after. It will be used for 3.5.0-rc3 that should be 3.5.0-final. Only commits with 3 reviewers will be allowed for that branch. See also http://wiki.docu

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 04:16 PM, Lionel Elie Mamane wrote: "only fixed" is exaggerated. Maybe "most cleanly fixed". I came rather late to this discussion, so may miss some point completely. If you know of a non-hacky fix that does not require giving up the oxt, I'd be more than happy to not do the ch

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Michael Meeks
On Mon, 2012-01-23 at 12:35 +0100, Michael Stahl wrote: > ah, yes, that's about what i expected; also, for MacOSX gcc 4.0.1 is > used, which is AFAIK the oldest one. Great. > > So, I think that it is perfectly fine to remove support for GCC 2. > > i'd be very, very surprised if anything

Re: [Libreoffice] Blocker in 3.5.0Beta3?

2012-01-23 Thread Andras Timar
Hi Petr, 2012/1/23 Petr Mladek : > [via Document Foundation Mail Archive] píše v St 18. 01. 2012 v 09:00 > -0800: >> Hi all >> >> While installing LO 3.5.0Beta3 today in my Win XP Home x86 pt-PT >> netbook I noticed that the installer only starts in Portuguese for a >> brief second and then switch

Re: [Libreoffice] Build error in helpcontent2

2012-01-23 Thread Andras Timar
Hi Pim, 2012/1/23 Pim Bollen : > On Monday 23 January 2012 10:05:22 David Tardon wrote: >> >> You need to update the help repository. >> >> cd clone/help >> git pull -r >> >> D. > > It does not help for me: > [ pim@laptop-pim 1 ~/work/bootstrap master %]] cd clone/help/ > [ pim@laptop-pim 0 ~/work

Re: [Libreoffice] Blocker in 3.5.0Beta3?

2012-01-23 Thread Petr Mladek
[via Document Foundation Mail Archive] píše v St 18. 01. 2012 v 09:00 -0800: > Hi all > > While installing LO 3.5.0Beta3 today in my Win XP Home x86 pt-PT > netbook I noticed that the installer only starts in Portuguese for a > brief second and then switches to English. > > I had never tried a

Re: [Libreoffice] Build error in helpcontent2

2012-01-23 Thread Pim Bollen
On Monday 23 January 2012 10:05:22 David Tardon wrote: > > You need to update the help repository. > > cd clone/help > git pull -r > > D. It does not help for me: [ pim@laptop-pim 1 ~/work/bootstrap master %]] cd clone/help/ [ pim@laptop-pim 0 ~/work/bootstrap/clone/help master]] git pull -r Cu

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 03:21:30PM +0100, Stephan Bergmann wrote: > * > "postgresql-sdbc doesn't work on LO 3.5RC1 win32" > * > "PostgreSQL-SDBC fails to load on Unix / official binaries: mis

Re: [Libreoffice] [libreoffice-l10n] Re: [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC1 pre-available

2012-01-23 Thread Petr Mladek
Luc Castermans píše v Čt 19. 01. 2012 v 17:45 +0100: > Just yesterday installed beta3, today rc1. Where/how can I find out > the differences ? All commit summaries are listed at http://download.documentfoundation.org/libreoffice/src/commit-log-libreoffice-3-5-release-3.5.0.1.log The commits with

[Libreoffice] [REVIEW][3-5][3-4] resolved rhbz#783556 crash in Calc interpreter

2012-01-23 Thread Eike Rathke
Hi, please review and cherry-pick to 3-5 and 3-4 http://cgit.freedesktop.org/libreoffice/core/commit/?id=a7769e27849b74102e11540d7753576528323114 Resolves https://bugzilla.redhat.com/show_bug.cgi?id=783556 crash in Calc interpreter for external reference matrix. Thanks Eike -- LibreOffice Ca

Re: [Libreoffice] bug in rc1

2012-01-23 Thread Petr Mladek
Cor Nouws píše v Pá 20. 01. 2012 v 20:25 +0100: > Hi Luc, > > Luc Castermans wrote (20-01-12 19:54) > > > Where to put translation bugs? > > all here > http://wiki.documentfoundation.org/BugReport > and info here > http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-2 You might

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

2012-01-23 Thread Markus Mohrhard
Hello Niko, 2012/1/23 Niko Rönkkö : >>        Only one query; I wonder whether we should be using the flat (fods) >> file-type for these tests - so we can read meaningful diffs to them in >> the git history. > > > +1 for this... > ... and I also think that all ODF files in git repos should be in F

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 03:33 PM, Michael Stahl wrote: On 23/01/12 15:21, Stephan Bergmann wrote: The attached 0001-Changed-postgresql-sdbc-from-bundled-oxt-to-proper-o.patch (against recent libreoffice-3-5) does just that. It builds fine on Linux and produces installation sets that properly contain the

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Fridrich Strba
On 23/01/12 15:21, Stephan Bergmann wrote: Feel free to review for inclusion in LO 3.5. (I can do the actual push in case enough reviewers approve.) Go for it ! F. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedeskt

Re: [Libreoffice] "Found duplicate branches for if and else" in dbtree.cxx

2012-01-23 Thread Caolán McNamara
On Fri, 2012-01-20 at 23:53 -0800, julien2412 wrote: > I took a look at the git history, it's been there since the initial commit > on 2000. > > So either the if(bTable) is useless or something's missing. I have no clues, but seeing as its been like that since pre 2000, might as well just remove

Re: [Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Michael Stahl
On 23/01/12 15:21, Stephan Bergmann wrote: > The attached > 0001-Changed-postgresql-sdbc-from-bundled-oxt-to-proper-o.patch (against > recent libreoffice-3-5) does just that. It builds fine on Linux and > produces installation sets that properly contain the various files for > the postgresql-s

Re: [Libreoffice] About fdo#42543

2012-01-23 Thread Caolán McNamara
On Sat, 2011-11-26 at 08:29 -0800, julien2412 wrote: > Hello, > > By taking a look at the bug fdo#42543 (major/high NEW Report Designer Wizard > missing Label display and editing capability) Is this still busted btw ? C. ___ LibreOffice mailing list L

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

2012-01-23 Thread Michael Stahl
On 23/01/12 15:20, Niko Rönkkö wrote: >> Only one query; I wonder whether we should be using the flat (fods) >> file-type for these tests - so we can read meaningful diffs to them in >> the git history. > > +1 for this... > and I also think that all ODF files in git repos should be in Fl

Re: [Libreoffice] [PATCH] proposed fix for fdo#44040 (seems iterator issue only)

2012-01-23 Thread Caolán McNamara
On Tue, 2012-01-17 at 11:40 -0800, julien2412 wrote: > There was an extra semicolon after the while on the patch. Even if i re read > several times the code, I just missed it too and needed gdb to see it ! Now > it works better :-) *groan*, that was dumb of me. > Do you want to commit/push it you

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 02:20:31PM +0100, Stephan Bergmann wrote: > On 01/23/2012 01:45 PM, Lionel Elie Mamane wrote: >> Users loose the feature to use a newer PostgreSQL-SDBC with an >> older LibreOffice. But Fridrich and you agree it fixes all our >> issues, so OK, I consent to it. I'm happy to

Re: [Libreoffice] "Found duplicate branches for if and else" in dbtree.cxx

2012-01-23 Thread Michael Stahl
On 21/01/12 08:53, julien2412 wrote: > Hello, > > Cppcheck reported this : > core/sw/source/ui/dbui/dbtree.cxx > 349 duplicateBranch style Found duplicate branches for if and else. > > if(bTable)<--- Found duplicate branches for if and > else. >

[Libreoffice] [REVIEW][3-5] let postgresql-sdbc find its dependencies

2012-01-23 Thread Stephan Bergmann
As discussed in the recent thread starting at "rpath / ... for extensions (and the case of PostgreSQL-SDBC)," it looks like the two bugs * "postgresql-sdbc doesn't

Re: [Libreoffice] Flat ODF usage in Git [Was: concept for c++ based subsequenttests]

2012-01-23 Thread Niko Rönkkö
Only one query; I wonder whether we should be using the flat (fods) file-type for these tests - so we can read meaningful diffs to them in the git history. +1 for this... ... and I also think that all ODF files in git repos should be in Flat ODFormat so that the Git can track them easily

Re: [Libreoffice] [PUSHED][REVIEW][3-5] artificial italic and vertical/rotated text

2012-01-23 Thread Eike Rathke
Hi Caolán, On Monday, 2012-01-23 12:33:57 +, Caolán McNamara wrote: > I'd like to get > http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f23e9813daae808aa2a81250b5e414dc57a3394 > into 3-5. Fixes (seems to anyway) the out-of-order glyph rotation and > skew-for-artifical-bold, i.e. > ht

Re: [Libreoffice] Easyhack : updating biblio.odb

2012-01-23 Thread Caolán McNamara
On Sat, 2012-01-21 at 12:36 -0800, julien2412 wrote: > Hello again, > > I discussed about it on IRC, there's nothing to do . > I updated the "completed task" page to remove this task. > I must have made something wrong with git or else but I don't want to do > this task again. These were the two

Re: [Libreoffice] Mozldap switch: --with-openldap to go away?

2012-01-23 Thread Rene Engelhard
Hi, On Mon, Jan 23, 2012 at 01:38:45PM +0100, Lionel Elie Mamane wrote: > I'm not sure if Debian configures LO with --with-openldap for a Because we didn't want to link with Mozilas libldap509.so (which evben isn't properly SONAMEd) and have a dependency on Mozilla for that. And that OpenLDAP is

Re: [Libreoffice] [ANN] LibreOffice 3.5.0 RC1 available

2012-01-23 Thread Thorsten Behrens
Pedro wrote: > "WARNING for Windows users: The Release Candidate will uninstall your > current stable build and replace it. If you do not wish this to happen but > still would like to test this Release you should follow the instructions for > installing in parallel > http://wiki.documentfoundation.

Re: [Libreoffice] sc_unoapi failure

2012-01-23 Thread Eike Rathke
Hi Stephan, On Monday, 2012-01-23 11:44:43 +0100, Stephan Bergmann wrote: > On 01/23/2012 11:38 AM, Stephan Bergmann wrote: > >The Linux-RHEL6-x86_64@14-with-check tinderbox is consistently failing > >with a crash in sc_unoapi in all the builds since the one whose failure > >mail is at the end of

Re: [Libreoffice] [PATCH] Removed nonexistent items from unusedcode.easy

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 11:41 +0100, Mariusz Dykierek wrote: > Hi, > > Attached patch removes from "unusedcode.easy" a number of methods that cannot > be found in the > sources within the "core" directory. > > Can someone more experienced than I am confirm that items: > - CIcc*::* > - boost::gre

Re: [Libreoffice] [Pushed] Removed LineListBox methods listed in unusedcode.easy

2012-01-23 Thread Mariusz Dykierek
These should not (as they were actually removed in the source). As for the others, mentioned in other patch: "[PATCH] Removed nonexistent items from unusedcode.easy" A simple "grep -v suppress.list in.txt > unusedcode.easy" should do the trick. One more file to maintain, but false positives would

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Stephan Bergmann
On 01/23/2012 01:45 PM, Lionel Elie Mamane wrote: Users loose the feature to use a newer PostgreSQL-SDBC with an older LibreOffice. But Fridrich and you agree it fixes all our issues, so OK, I consent to it. I'm happy to let you and/or Fridrich do the change. Doing it. Lionel, do you have a re

[Libreoffice] [PUSHED 3-5] Re: Use $(GPERF) not gperf

2012-01-23 Thread Michael Stahl
On 23/01/12 12:15, Baptiste Daroussin wrote: > On Mon, Jan 23, 2012 at 11:31:14AM +0100, Baptiste Daroussin wrote: >> Hi, >> >> With the new gmake build work the bug #32195 has been reintroduce in some >> part: >> >> The folloing fixes the one I have found so far: >> http://people.freebsd.org/~ba

Re: [Libreoffice] [Pushed] Removed LineListBox methods listed in unusedcode.easy

2012-01-23 Thread Niko Rönkkö
Hi! On 23.01.2012 10:26, Muthu Subramanian K wrote: Pushed! Thank you for the patch! The only problem is that these entries will come back when the "call catcher" magician Caolán regenerates the unusedcode.easy list next time. -- RN ___ LibreOffice

[Libreoffice] [PUSHED][REVIEW] fdo#44983 Fix RTF import of \paperh and \paperw

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 21:56 +0100, Miklos Vajna wrote: > Hi, > > See > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c39e891d4dc963d2cac9843b426494e4dc490278 > > Could somebody sign-off and push to -3-5, please? Looks sane to me, pushed to 3-5 now. C.

[Libreoffice] [PUSHED][PATCH] A copy-paste bug detected by cppcheck at sdext/source/presenter/PresenterTimer.cxx:512

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 22:25 +0100, Mariusz Dykierek wrote: > Attached patch fixes a copy-paste error in the condition. > Seconds used twice instead of Hours. Ah indeed, good catch, looks good to me. Pushed now, thanks for this. C. ___ LibreOffice mail

[Libreoffice] [PUSHED]PATCH] Same expression on both sides of || in if condition at libreoffice@lists.freedesktop.org (cppcheck)

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 23:21 +0100, Mariusz Dykierek wrote: > I guess this is what author intended. Yeah, well with Minutes->Nanosec anyway, looks like the intention. Pushed now, thanks for this. C. ___ LibreOffice mailing list LibreOffice@lists.freedes

Re: [Libreoffice] [PUSHED] send-feedback patch

2012-01-23 Thread Ivan Timofeev
Hi Thorsten, 23.01.2012 15:40, Thorsten Behrens пишет: Sorry for the lag - patch is fine as-is I think, let's add the startcenter icon etc. as/when they arrive. Thanks for reviewing/pushing! I was afraid that the hard-coded url is not fine, because I saw another urls in instsetoo_native/util

Re: [Libreoffice] [PATCH] rpath / ... for extensions (and the case of PostgreSQL-SDBC)

2012-01-23 Thread Lionel Elie Mamane
On Mon, Jan 23, 2012 at 09:07:13AM +0100, Stephan Bergmann wrote: > On 01/22/2012 11:02 PM, Lionel Elie Mamane wrote: >> OTOH, even if we find a good way to handle "library load path" >> issue, it still does not solve the problem of how the .oxt will >> work with a LibreOffice compiled with --with

Re: [Libreoffice] validation documents for writer

2012-01-23 Thread Caolán McNamara
On Sun, 2012-01-22 at 12:28 +0200, Noel Grandin wrote: > I thought someone was running a test-bot that downloaded all of the > documents from bugzilla and loaded them? This would be ./bin/get-bugzilla-attachments-by-mimetype but its currently tuned for the mime-types I was interested in collecting

[Libreoffice] [REVIEW][3-5] artificial italic and vertical/rotated text

2012-01-23 Thread Caolán McNamara
I'd like to get http://cgit.freedesktop.org/libreoffice/core/commit/?id=8f23e9813daae808aa2a81250b5e414dc57a3394 into 3-5. Fixes (seems to anyway) the out-of-order glyph rotation and skew-for-artifical-bold, i.e. https://bugs.freedesktop.org/show_bug.cgi?id=44856 Test case of qadevOOo/testdocs/ver

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 38177, which changed state. Bug 38177 Summary: Closing parent Base window leaves wizard generated table, query, report or form window in orphaned state https://bugs.freedesktop.org/show_bug.cgi?id=38177 What

Re: [Libreoffice] [PUSHED] send-feedback patch (was: Re: minutes of ESC call ...)

2012-01-23 Thread Thorsten Behrens
> let me get to that tomorrow first thing! > Sorry for the lag - patch is fine as-is I think, let's add the startcenter icon etc. as/when they arrive. Let's push this to -3-5 after the 3.5.0 branch-off. Cheers, -- Thorsten pgp2HFln1DVu9.pgp Description: PGP signature _

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Stefan Knorr (Astron)
Hi Pedro, > That would be too simple. See my example in the previous email. > You would need to match the keys for EACH keyboard model, regardless of > Locale. Well, that doesn't scale (at least I can't believe it does), as it would probably make adding keyboard layout stuff a full-time job and a

Re: [Libreoffice] .: sal/inc sal/osl

2012-01-23 Thread Michael Stahl
On 23/01/12 10:03, Petr Mladek wrote: > Michael Meeks píše v Pá 20. 01. 2012 v 17:34 +: >> On Fri, 2012-01-20 at 17:06 +0100, Michael Stahl wrote: +#if defined(__GNUC__) && (__GNUC__ < 3) +struct ::stat a_stat, b_stat; +#else +struct stat a_stat, b_stat; +#endif

[Libreoffice] gbuild: variables in user makefiles

2012-01-23 Thread Michael Stahl
hi Stephan, On 21/01/12 22:17, Michael Stahl wrote: > commit e2b3be6416df0c8913b2d6bb32c34fe162a0a019 > Author: Michael Stahl > Date: Sat Jan 21 19:36:01 2012 +0100 > > officecfg: namespace prefix make variable FILES if you have to define variables in user makefiles (and in officecfg ther

Re: [Libreoffice] .: sw/source

2012-01-23 Thread Michael Stahl
On 29/12/11 00:39, Miklos Vajna wrote: > sw/source/filter/ww8/rtfattributeoutput.cxx | 297 > +--- > sw/source/filter/ww8/rtfexport.cxx | 74 +++--- > sw/source/filter/ww8/rtfexportfilter.cxx|2 > sw/source/filter/ww8/rtfimportfilter.cxx|2 >

Re: [Libreoffice] Use $(GPERF) not gperf

2012-01-23 Thread Baptiste Daroussin
On Mon, Jan 23, 2012 at 11:31:14AM +0100, Baptiste Daroussin wrote: > Hi, > > With the new gmake build work the bug #32195 has been reintroduce in some > part: > > The folloing fixes the one I have found so far: > http://people.freebsd.org/~bapt/0001-use-GPERF-instead-of-using-gperf-from-path.p

Re: [Libreoffice] [PUSHED] Use $(GPERF) not gperf

2012-01-23 Thread Miklos Vajna
On Mon, Jan 23, 2012 at 11:31:14AM +0100, Baptiste Daroussin wrote: > With the new gmake build work the bug #32195 has been reintroduce in some > part: > > The folloing fixes the one I have found so far: > http://people.freebsd.org/~bapt/0001-use-GPERF-instead-of-using-gperf-from-path.patch > A

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Pedro Lino
Hi Stefan, all > All we should need is localised versions of key names like Ctrl, Del, > Ins (that are on almost every keyboard [1], but whose names can > change) and global versions of key names for > alphanumeric/script-specific keys (which might not be on every > keyboard, but whose names are

[Libreoffice] Use $(GPERF) not gperf

2012-01-23 Thread Baptiste Daroussin
Hi, With the new gmake build work the bug #32195 has been reintroduce in some part: The folloing fixes the one I have found so far: http://people.freebsd.org/~bapt/0001-use-GPERF-instead-of-using-gperf-from-path.patch As ususal, it respect all the license that fits the best libreoffice :) regar

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Stefan Knorr (Astron)
Hi all, >> That brings several questions to me: how comes the translation of the >> key names is depending on the keyboard model? I have a normal french >> keyboard with en-US locale and en-US libreoffice build. > >        Well - I guess the -idea- is prolly to try to show the user the key > that

Re: [Libreoffice] [Libreoffice-qa] weird shortcut key for repeat action in Writer

2012-01-23 Thread Pedro Lino
Hi Michael, all Well - I guess the -idea- is prolly to try to show the user the key > that is written on their keyboard, rather than a generic 'Ctrl' for > Control - it can show 'Control' (if that is what is written there) or > somesuch. > I think it would make sense for different countri

Re: [Libreoffice] Problem with clipboard paste in 3.5

2012-01-23 Thread Petr Cisar
Hello I did some tests, I tried to put some debug printouts to file clone/libs-gui/dtrans/source/generic/clipboardmanager.cxx, but never seen one while running LO. Also I tried to use gdb, but this file is not among the sources gdb loaded, and libdtrans is not in info sharedlibrary printout whe

Re: [Libreoffice] [PATCH] Replace ENSURE_OR_* macros with regular code.

2012-01-23 Thread Marcel Metz
Hello Muthu, On 23.01.2012 09:19, Muthu Subramanian K wrote: > Before pushing, it would be great to understand the reason behind > replacing the macro with regular code. Sure thing. The reason why I replaced the ENSURE_OR_* macros with regular code was the replacement of the OSL_ENSURE macro with

  1   2   >