Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Noel Grandin
Sorry to waste your time, I'll have another run at this on Wednesday, when I get back from a business trip. On Sat, Jan 14, 2012 at 00:32, Kohei Yoshida wrote: > On Fri, 2012-01-13 at 17:00 -0500, Kohei Yoshida wrote: >> On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote: >> > Let me do a tho

[Libreoffice] [PATCH] proposed fix for fdo#43479

2012-01-13 Thread julien2412
Hello, I tried to help for the fdo#43479 so I runned some tests and try to interpret the results here : https://bugs.freedesktop.org/show_bug.cgi?id=43479#c7 Then I proposed a patch here https://bugs.freedesktop.org/show_bug.cgi?id=43479#c8 Of course, if I'm sure the distinct works for the few t

[Libreoffice] Anita Powell - Tahiti Pen

2012-01-13 Thread Anita Powell
Greetings,   My name is Anita Powell and I would like to show you our new Tahiti Pen to the person who handles the marketing. Please email your logo in EPS format and let me know what type of products you have order before we can provide you with new product ideas with your logo on them. Sincere

[Libreoffice] [PATCH] Bug 33794 - The "Open..." button of the initial screen needs more room for localization fdo#33794

2012-01-13 Thread Tomcsik Bence Tibor
Hello! 2012/1/13 Ivan Timofeev > Hello, > > 13.01.2012 18:15, Tomcsik Bence Tibor пишет: > >> Hi, >> >> Bug 33794 solved. >> > > IMHO it's better to pass some additional parameter to the layoutButton > function ( e.g. int i_nExtraWidth = 0 ) and change: > >nTextWidth += maButtonImageSize.Wid

[Libreoffice] [REVIEW] pls add this to 3.4.6 Re: [Bug 39118] Charts with anchor to cell do not update automatically

2012-01-13 Thread Cor Nouws
bugzilla-dae...@freedesktop.org wrote (13-01-12 23:26) https://bugs.freedesktop.org/show_bug.cgi?id=39118 --- Comment #14 from Kohei Yoshida 2012-01-13 14:26:30 PST --- Cor, please ask someone to sign off of my change. I can't backport my own change. Thanks. commit involved: http://cgit.fr

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
On Fri, 2012-01-13 at 17:00 -0500, Kohei Yoshida wrote: > On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote: > > Let me do a thorough review of your patch one more time, and I'll push > > to master. > > Unfortunately one of the filters-test fails on master, after applying > the patch. The c

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 39118, which changed state. Bug 39118 Summary: Charts with anchor to cell do not update automatically https://bugs.freedesktop.org/show_bug.cgi?id=39118 What|Old Value |New Value

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 41054, which changed state. Bug 41054 Summary: FILESAVE odf file corrupted - cannot save after inserting new sheet https://bugs.freedesktop.org/show_bug.cgi?id=41054 What|Old Value |New

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Cor Nouws changed: What|Removed |Added Depends on||39118 --- Comment #248 from Cor Nouws 2012-

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Cor Nouws changed: What|Removed |Added Depends on||41054 --- Comment #247 from Cor Nouws 2012-

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
On Fri, 2012-01-13 at 15:27 -0500, Kohei Yoshida wrote: > Let me do a thorough review of your patch one more time, and I'll push > to master. Unfortunately one of the filters-test fails on master, after applying the patch. The crash occurs in ScColumn::CloneCell, at line 824 which is switch

[Libreoffice] bugZilla deamon issue with time zone ?

2012-01-13 Thread Cor Nouws
Hi, posts I get from bugzilla-dae...@freedesktop.org seem to vary in time send. Looks as if it (randomly / frequently) switches between UTC and PST. For others too ? Issue ? Cheers, -- - Cor - http://nl.libreoffice.org ___ LibreOffice mailing list

Re: [Libreoffice] unit test concept for draw/impress

2012-01-13 Thread Cor Nouws
Hi Markus, Markus Mohrhard wrote (13-01-12 06:10) I finally found some time working on a unit test concept for draw/impress as promised to Thorsten in Paris. (see [1]) [...] No useful technical comment from me here, just a \\0// ! -- - Cor - http://nl.libreoffice.org _

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Michael Meeks
On Fri, 2012-01-13 at 17:06 +0100, Winfried Donkers wrote: > >What do you mean with "The current format does not look efficient to > >me." Efficient in terms of what? > > Just that the file size caused by the xml-tags exceeds the file size > caused by the data itself. I have nothing against x

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
On Fri, 2012-01-13 at 20:36 +0200, Noel Grandin wrote: > Hi > > Oh no!, I was testing some stuff and accidentally commented out the > critical line in ScColumn::Append(). > > This line > +//aItems.resize(nSize); > should be > +aItems.resize(nSize); I guess you meant ScColumn::Resize()?

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Noel Grandin
Hi Oh no!, I was testing some stuff and accidentally commented out the critical line in ScColumn::Append(). This line +//aItems.resize(nSize); should be +aItems.resize(nSize); We could call reserve() on the vector to allocate extra capacity, but I don't think there is any way to get exac

Re: [Libreoffice] Advice needed about some 3.4 named range related problem

2012-01-13 Thread Markus Mohrhard
Hello Noel, 2012/1/13 Noel Power : > Hi Guys, > > We have a bug here in the suse system that highlights a regression > attempting to resolve a range by name. Note: this is not a problem on > master. > > the failing macro code is something like so; > > Sub test >    ProjectPlanSheet = ThisComponent

Re: [Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

2012-01-13 Thread Ivan Timofeev
forgot to attach the patch. >From bae6b73a56cf4fcfffe21aa9f3f9ccce87e890cd Mon Sep 17 00:00:00 2001 From: Ivan Timofeev Date: Fri, 13 Jan 2012 21:50:55 +0400 Subject: [PATCH] fdo#43932: try to fix paper tray settings --- vcl/source/gdi/print3.cxx | 25 ++--- 1 files change

[Libreoffice] [REVIEW] fdo#43932: try to fix paper tray settings

2012-01-13 Thread Ivan Timofeev
Hi there, https://bugs.freedesktop.org/show_bug.cgi?id=43932 this patch partially reverts http://cgit.freedesktop.org/libreoffice/core/commit/?id=4cc5448ed82f13bb107695b65f39589df1e46cb9 because the following change made the option "[ ] Use only paper tray from printer preferences" useless: @@

[Libreoffice] [REVIEW][3.4.x]fdo#38515 annoying crasher fix

2012-01-13 Thread Cedric Bosdonnat
Hello people, Could someone review / cherry-pick this patch for the 3.4.x branches? http://cgit.freedesktop.org/libreoffice/core/commit/?id=4914b23e7e91b184d69eb00a74ce1c463c5754a7 Thanks, -- Cedric ___ LibreOffice mailing list LibreOffice@lists.freed

[Libreoffice] Advice needed about some 3.4 named range related problem

2012-01-13 Thread Noel Power
Hi Guys, We have a bug here in the suse system that highlights a regression attempting to resolve a range by name. Note: this is not a problem on master. the failing macro code is something like so; Sub test ProjectPlanSheet = ThisComponent.Sheets.getByName( "ProjectPlan" ) chkCellCo

[Libreoffice] [REVIEW][3.5] Writer layout fix for fdo#40438

2012-01-13 Thread Cedric Bosdonnat
Hi all, Could some of the other Writer gurus have a look at this patch: it should fix the crasher though it may not be perfect. I'ld prefer a peer review before cherry-picking it to 3.5 http://cgit.freedesktop.org/libreoffice/core/commit/?id=d83488 Thanks, -- Cedric ___

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 40438, which changed state. Bug 40438 Summary: CRASH in OLE object EDITING https://bugs.freedesktop.org/show_bug.cgi?id=40438 What|Old Value |New Value ---

[Libreoffice] [PUSHED, partial][PATCH] Replace getLength() with isEmpty() in vcl/generic/fontmanager

2012-01-13 Thread Caolán McNamara
On Thu, 2012-01-12 at 15:29 +0100, Chr. Rossmanith wrote: > Hi, > > while replacing ByteString with OString I came across some getLength() > calls which might be replaced with isEmpty() Pushed the bits which aren't OUStringBuffers. C. ___ LibreOffice

Re: [Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 03:33 PM, Michael Stahl wrote: On 13/01/12 15:14, Stephan Bergmann wrote: Given that SwXTextDocument::close is just void SwXTextDocument::close( sal_Bool bDeliverOwnership ) throw( util::CloseVetoException, RuntimeException ) { if(IsValid()&& m_pHiddenViewFrame) l

Re: [Libreoffice] [PATCH] Bug 33794 - The "Open..." button of the initial screen needs more room for localization fdo#33794

2012-01-13 Thread Ivan Timofeev
Hello, 13.01.2012 18:15, Tomcsik Bence Tibor пишет: Hi, Bug 33794 solved. IMHO it's better to pass some additional parameter to the layoutButton function ( e.g. int i_nExtraWidth = 0 ) and change: nTextWidth += maButtonImageSize.Width() + 8; // add some fuzz to be on the safe side t

[Libreoffice] [PATCH][3-5] make building and installing of nsplugin more consistent

2012-01-13 Thread Matúš Kukan
Hi, I was now playing with nsplugin in master, so I created also patch for 3-5. It was installed only in without mozilla case but compiled also in the other case. So now in master and in the patch nsplugin is only for with mozilla case. But be aware that we don't need mozilla for this. (It was b

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Winfried Donkers
>What do you mean with "The current format does not look efficient to >me." Efficient in terms of what? Just that the file size caused by the xml-tags exceeds the file size caused by the data itself. I have nothing against xml and I am no expert. For me there is no need to change it, it's pur

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
On Fri, 2012-01-13 at 10:39 -0500, Kohei Yoshida wrote: > The only thing I'd like to check is that, I believe we had some sort > of > column array resizing policy which controls whether we should increase > its size only to the minimum necessary size or increase it to a size > larger than necessary

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 04:35 PM, Winfried Donkers wrote: However, I would prefer improving configmgr (if need be) over switching the label data to yet another format. What format are you thinking of? As I am doing a lot of rework on the file (the diff file is 1.2MB), it may the the right moment to cha

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Kohei Yoshida
On Fri, 2012-01-13 at 09:06 +0200, Noel Grandin wrote: > Hi > > This patch converts open-coded array management to std::vector in ScColumn Hello Noel, I just took a quick look at your patch, and it looks good & I'm more than willing to push this change verbatim. The only thing I'd like to check

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Winfried Donkers
>However, I would prefer improving configmgr (if need be) over switching >the label data to yet another format. What format are you thinking of? As I am doing a lot of rework on the file (the diff file is 1.2MB), it may the the right moment to change the format. The current format does not loo

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 38515, which changed state. Bug 38515 Summary: LibreOffice crashes in Bibliography dialog when pressing Enter https://bugs.freedesktop.org/show_bug.cgi?id=38515 What|Old Value |New Value

[Libreoffice] new configmgr access API ...

2012-01-13 Thread Michael Meeks
On Fri, 2012-01-13 at 14:15 +0100, Stephan Bergmann wrote: > On 01/13/2012 11:23 AM, Michael Meeks wrote: > > Oooh ! :-) it looks really rather nice; how efficient is the compiled > > representation ? hopefully much more so than the big chunks of in-lined > > UNO-ness that existing code uses :

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #95 from Philipp Gassmann 2012-01-13 06:42:10 PST --- Hi Kohei Why did you remove that bug from the list? Shouldn't I have it added to 3.4 and 3.5, or what's the reason? Regards Philipp Am 12.01.2012 20:13, schrieb bugzilla-dae...

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Khaled Hosny
On Fri, Jan 13, 2012 at 01:42:03PM +, Caolán McNamara wrote: > On Fri, 2012-01-13 at 13:19 +0200, Khaled Hosny wrote: > > XLFD support was removed in commit 269f91c (#i110171) except for parsing > > fonts.dir and fonts.alias. I don't think this makes much sense in > > fontconfig era, and droppi

Re: [Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

2012-01-13 Thread Michael Stahl
On 13/01/12 15:14, Stephan Bergmann wrote: > On 01/12/2012 02:52 PM, Michael Stahl wrote: >> On 12/01/12 14:44, Stephan Bergmann wrote: #12 in SdrPageView::DrawLayer at svx/source/svdraw/svdpagv.cxx:398 #13 in SwViewImp::PaintLayer at sw/source/core/view/vdraw.cxx:148 #14 in SwRootFr

[Libreoffice] [PUSHED][PATCH] Replace (Byte)String with rtl::O(U)String

2012-01-13 Thread Caolán McNamara
On Thu, 2012-01-12 at 15:25 +0100, Chr. Rossmanith wrote: > Hi, > > another bit of replacements for reviewing. Looks fine to me, pushed now. Could quibble about not converting converting xub_StrLen to sal_Int32 while you're at it. C. ___ LibreOffice m

[Libreoffice] [PATCH] Bug 33794 - The "Open..." button of the initial screen needs more room for localization fdo#33794

2012-01-13 Thread Tomcsik Bence Tibor
Hi, Bug 33794 solved. I confirm that this and all my future contributions are under MPL/LGPLv3+ licenses. Bence Tomcsik From 5dacbe2539f17dd23e78caada8264a062d8dfa41 Mon Sep 17 00:00:00 2001 From: Tomcsik Bence Date: Fri, 13 Jan 2012 14:50:06 +0100 Subject: [PATCH] The "Open..." button's more

Re: [Libreoffice] New Tinderbox Linux-RHEL6-x86_64-check

2012-01-13 Thread Stephan Bergmann
On 01/12/2012 02:52 PM, Michael Stahl wrote: On 12/01/12 14:44, Stephan Bergmann wrote: #12 in SdrPageView::DrawLayer at svx/source/svdraw/svdpagv.cxx:398 #13 in SwViewImp::PaintLayer at sw/source/core/view/vdraw.cxx:148 #14 in SwRootFrm::Paint at sw/source/core/layout/paintfrm.cxx:2976 #15 in V

[Libreoffice] [POLL] Find a date for the next LibreOffice hackfest

2012-01-13 Thread Thorsten Behrens
Hi folks, as promised to some of you, we're organizing the next HackFest here in Hamburg. We were able to secure support from Attraktor e.V. again, operators of the Hamburg Hackerspace facilities - a really rather suitable place for our next meet-up: http://www.youtube.com/user/AttraktorHH Trav

[Libreoffice] Doxygen for IDL? (was: Doxygen for C/C++ URE Documentation)

2012-01-13 Thread Stephan Bergmann
On 01/06/2012 12:12 PM, Stephan Bergmann wrote: Yeah, next step I plan to do is get rid of autodoc for IDL, too (after this topic has finally been "forced upon" me via URE gbuildification), and then rid the code base from all that nonsense in one step. Just a quick update on this rather low-pri

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Caolán McNamara
On Fri, 2012-01-13 at 13:19 +0200, Khaled Hosny wrote: > XLFD support was removed in commit 269f91c (#i110171) except for parsing > fonts.dir and fonts.alias. I don't think this makes much sense in > fontconfig era, and dropping it simplifies the font manager a bit (I > don't even think we use serv

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 11:23 AM, Michael Meeks wrote: Oooh ! :-) it looks really rather nice; how efficient is the compiled representation ? hopefully much more so than the big chunks of in-lined UNO-ness that existing code uses :-) It still uses UNO to access configmgr, but through a simplified

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 01:56 PM, Winfried Donkers wrote: As the contents of Labels.xcu are only used when starting the label wizard or business card wizard, woul dit be better if this file is read when starting the wizard, and not when starting LibreOffice? Can't this file be included in the installation

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 12:26 PM, Michael Meeks wrote: Another thing that interests me is that parsing the configuration, despite all Stephan's good work in configmgr to speed it up, still takes real time and space: say 4% of our startup and a chunk of RAM. If we look at the sizes of our config usi

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44147, which changed state. Bug 44147 Summary: inserted calcs in writer accept no more input https://bugs.freedesktop.org/show_bug.cgi?id=44147 What|Old Value |New Value -

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Winfried Donkers
>> Another thing that interests me is that parsing the configuration, >> despite all Stephan's good work in configmgr to speed it up, still takes >> real time and space: say 4% of our startup and a chunk of RAM. If we >> look at the sizes of our config using a simple: As the contents of Label

Re: [Libreoffice] unit test concept for draw/impress

2012-01-13 Thread Markus Mohrhard
Hello Caolan, 2012/1/13 Caolán McNamara : > On Fri, 2012-01-13 at 06:10 +0100, Markus Mohrhard wrote: >> The advantage of the svg file is that it represents the visual >> representation extremely good and we ca easily compare it againts an >> reference svg file. > > How about pdf ? which has the a

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44147, which changed state. Bug 44147 Summary: inserted calcs in writer accept no more input https://bugs.freedesktop.org/show_bug.cgi?id=44147 What|Old Value |New Value -

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #94 from Carlo Strata 2012-01-13 04:03:12 PST --- (In reply to comment #93) > Version LOdev 3.5 beta3 > S.O. Ubuntu 10.04 and Debian Testing. > Leaflet 'writer' with inserted OLE object (Calc). > Opens the object Calc to modify the c

[Libreoffice] [PUSHED] Drop XLFD support from fontmanager

2012-01-13 Thread Michael Meeks
Hi Khaled, On Fri, 2012-01-13 at 13:19 +0200, Khaled Hosny wrote: > XLFD support was removed in commit 269f91c (#i110171) except for parsing > fonts.dir and fonts.alias. I don't think this makes much sense in > fontconfig era, and dropping it simplifies the font manager a bit (I > don't even think

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Markus Mohrhard
Hello Stephan > No idea about that either (I think Michael Stahl has previously been exposed > heavily to locking, maybe he has some input), just two comments on the > patch: > >> +bool IsLockingUsed() >> +{ >> +    bool bLocking = true; >> +    try >> +    { >> + >> +        uno::Reference< uno::

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Michael Meeks
On Fri, 2012-01-13 at 11:26 +, Michael Meeks wrote: > Another thing that interests me is that parsing the configuration, > despite all Stephan's good work in configmgr to speed it up, still takes > real time and space: say 4% of our startup and a chunk of RAM. If we > look at the sizes o

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Felice changed: What|Removed |Added Platform|Other |x86-64 (AMD64) OS/Version|All

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Khaled Hosny
On Fri, Jan 13, 2012 at 01:26:20PM +0200, Tor Lillqvist wrote: > > I don't even think we use server fonts at all). > > Funnily enough, we have a type called ServerFont... > vcl/inc/generic/glyphcache.hxx , but that name is probably historical, > and what it actually means nowadays is the exact opp

Re: [Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Michael Meeks
Hi Winfried, On Fri, 2012-01-13 at 11:55 +0100, Winfried Donkers wrote: > I am adding sheet-dimensions to the label-definitions (Labels.xcu) > used in label wizard and business card wizard. Lovely :-) > Of the 1790 definitions, there are now only 199 to be checked. > Unfortunately, these

Re: [Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Tor Lillqvist
> I don't even think we use server fonts at all). Funnily enough, we have a type called ServerFont... vcl/inc/generic/glyphcache.hxx , but that name is probably historical, and what it actually means nowadays is the exact opposite;) --tml ___ LibreOffic

[Libreoffice] [PATCH] Drop XLFD support from fontmanager

2012-01-13 Thread Khaled Hosny
XLFD support was removed in commit 269f91c (#i110171) except for parsing fonts.dir and fonts.alias. I don't think this makes much sense in fontconfig era, and dropping it simplifies the font manager a bit (I don't even think we use server fonts at all). --- vcl/generic/fontmanager/fontconfig.cxx

[Libreoffice] fdo 44516 label printing misplaced; advise asked

2012-01-13 Thread Winfried Donkers
Hi, I am adding sheet-dimensions to the label-definitions (Labels.xcu) used in label wizard and business card wizard. Of the 1790 definitions, there are now only 199 to be checked. Unfortunately, these can only be checked manually : ( Some labels on pinfeed sheets are discontinued, no longer ava

Re: [Libreoffice] unit test concept for draw/impress

2012-01-13 Thread Thorsten Behrens
Caolan McNamara wrote: > How about pdf ? which has the advantage that all the apps can print to > pdf, so can be generic across apps ? > Well, I had proposed svg, because they're much easier to diff - I had something in mind like sdext/source/pdfimport/test/testdocs/makefile.mk (and disabling glyp

Re: [Libreoffice] FATToVFat_Impl: desktop/source/app/appsys.*: windows

2012-01-13 Thread Michael Meeks
On Thu, 2012-01-12 at 22:22 +, Caolán McNamara wrote: > These can be removed right ?, I mean, I don't see any use of them > anywhere or anything using appsys.hxx, so appsys.hxx and appsys.cxx > could be completely removed as far as I can see. Looks entirely unused and pointless to me

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Michael Meeks
Hi guys, Markus - nice catch - really cool to get that nailed :-) On Fri, 2012-01-13 at 09:05 +0100, Stephan Bergmann wrote: > > bool IsLockingUsed() > > { > > return officecfg::Office::Common::Misc::UseLocking::get( > > comphelper::getProcessComponentContext()); > > } > > (I

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-13 Thread Noel Grandin
But anyway, I'll keep this in the back of my head, and if QA does not find any horrible problems with confining the JDBC driver in LO 3.5, we can probably simplify the code on master. (Would you be interested?) Got something else on my plate right now (moving notes out of ScCell), but once

Re: [Libreoffice] unit test concept for draw/impress

2012-01-13 Thread Michael Meeks
On Fri, 2012-01-13 at 06:10 +0100, Markus Mohrhard wrote: > I finally found some time working on a unit test concept for > draw/impress as promised to Thorsten in Paris. (see [1]) Looks lovely :-) > The attached patch enables the new test concept in sd. The test is > based on calc's filt

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 10:36 AM, Noel Grandin wrote: Yeah, but given that such a re-design is probably a long way off, and that other drivers seem are confined to a single-thread, and seem to have acceptable performance, perhaps we should just live with this limitation, and optimise the easy-case? IIUC,

Re: [Libreoffice] [REVIEW][3-4] date change regression fdo#44385

2012-01-13 Thread Noel Power
On 12/01/12 22:27, Michael Stahl wrote: looking at the change, i notice that now it is independent of the operation being performed, while the code that was originally removed in adcba12537d047f5ad65334b65512615311cf872 checked for addition only (as the comment says): -// #

Re: [Libreoffice] [PATCH] ScColumn - convert array to vector

2012-01-13 Thread Noel Grandin
I forgot to say that the patch passes the unit tests, and a valgrind run (I love that tool). On 2012-01-13 09:06, Noel Grandin wrote: Hi This patch converts open-coded array management to std::vector in ScColumn Regards, Noel Grandin Disclaimer: http://www.peralex.com/disclaimer.html __

Re: [Libreoffice] unit test concept for draw/impress

2012-01-13 Thread Caolán McNamara
On Fri, 2012-01-13 at 06:10 +0100, Markus Mohrhard wrote: > The advantage of the svg file is that it represents the visual > representation extremely good and we ca easily compare it againts an > reference svg file. How about pdf ? which has the advantage that all the apps can print to pdf, so can

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-13 Thread Noel Grandin
Yeah, but given that such a re-design is probably a long way off, and that other drivers seem are confined to a single-thread, and seem to have acceptable performance, perhaps we should just live with this limitation, and optimise the easy-case? On 2012-01-13 11:18, Stephan Bergmann wrote: On

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 09:59 AM, Noel Grandin wrote: Surely now that it's confined to a single thread, it can just call AttachThread() once at startup, and never need to call DetachThread() ? Yes, one could improve it further based on the fact that it is confied now (it also internally uses some mutic

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 35023, which changed state. Bug 35023 Summary: FILEOPEN Base functions extremely slowly with Java 1.6.0_20 and >1.6.0_24 https://bugs.freedesktop.org/show_bug.cgi?id=35023 What|Old Value

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-13 Thread Noel Grandin
Surely now that it's confined to a single thread, it can just call AttachThread() once at startup, and never need to call DetachThread() ? -- Noel Grandin On 2012-01-13 10:54, Stephan Bergmann wrote: On 01/12/2012 02:18 PM, Michael Meeks wrote: On Thu, 2012-01-12 at 10:44 +0100, Stephan Ber

Re: [Libreoffice] Trying to diagnose base running extremely slowly

2012-01-13 Thread Stephan Bergmann
On 01/12/2012 02:18 PM, Michael Meeks wrote: On Thu, 2012-01-12 at 10:44 +0100, Stephan Bergmann wrote: One drawback of using the thread-affine apartment is that all code related to the JDBC driver is effectively serialized, removing any potential performance advantage from accessing the driver

Re: [Libreoffice] Dumping to valgrind.log from soffice shell script needed?

2012-01-13 Thread Stephan Bergmann
On 01/12/2012 05:46 PM, Petr Mladek wrote: Ah, I am sorry for the troubles. I have somehow missed this mail. You probably did not keep me in CC and I overlooked it on the mailing list :-( Sorry, likely I accidentally used "Reply List" instead of "Reply All." I think that the main problem is t

Re: [Libreoffice] prevent the creation of lockfiles during unit tests

2012-01-13 Thread Stephan Bergmann
On 01/13/2012 05:08 AM, Markus Mohrhard wrote: I did not push that patch directly because I'm not sure if we really want to introduce another registry entry for this. No idea about that either (I think Michael Stahl has previously been exposed heavily to locking, maybe he has some input), just