Re: [Libreoffice] [PUSHED] Re: About cppcheck 2 reports for desktop/unx/source/file_image_unx.c

2012-01-09 Thread Stephan Bergmann
size_t k; + // force touching of each page despite the optimizer volatile char c = 0; That patch reminds me of a piece of trivia I'd like to share: Ending with a colon a comment that goes before the code that it comments is a subtle device to make that more obvious: size_t k; + // fo

Re: [Libreoffice] [PATCH] [PUSHED] Removed unused DBG_WARNING{4, 5} macros, replaced DBG_WARNINGFILE.

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 07:01:26PM +0100, Marcel Metz wrote: > Hello lo-devs, > > this patch removes the unused DBG_WARNING4 and DBG_WARNING5 macros and > replaces also the DBG_WARNINGFILE with SAL_INFO as suggested in the > tools/debug.hxx headers. Pushed, thanks! Btw, could you use git format-

Re: [Libreoffice] [PATCH binfilter] [PUSHED] Remove cruft in debug tools.

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 06:42:08PM +0100, Marcel Metz wrote: > --- > binfilter/bf_sfx2/source/bastyp/sfx2_bitset.cxx | 10 -- > binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx |6 -- > 2 files changed, 0 insertions(+), 16 deletions(-) Pushed as well, thank you. D. _

Re: [Libreoffice] [PATCH core] [PUSHED] Remove cruft in debug tools.

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 06:41:52PM +0100, Marcel Metz wrote: > Hello lo-devs, > > the define SV_MEMMGR in tools/source/debug/debug.cxx was commented > out since 2001 and all of the memory related debugging code > depends on this define. These patches removes all of the depending > code. The ini co

[Libreoffice] [PUSHED] Re: About cppcheck 2 reports for desktop/unx/source/file_image_unx.c

2012-01-09 Thread julien2412
On master only, I removed the 2 lines as advised by Stephan and added the comment proposed by Michael. (http://cgit.freedesktop.org/libreoffice/core/commit/?id=05c51d5dfb58549e5bf26cb5c8b9b4f0083dca25) Thank you guys ! :-) Julien. -- View this message in context: http://nabble.documentfoundatio

[Libreoffice] [PUSHED] [PATCH] About enabling Icedove addressbook connection for Base

2012-01-09 Thread julien2412
Commited and pushed on master (http://cgit.freedesktop.org/libreoffice/core/commit/?id=8d7e1a6e13008bd7d35896e676796196038f1105) Julien -- View this message in context: http://nabble.documentfoundation.org/PATCH-About-enabling-Icedove-addressbook-connection-for-Base-tp3639069p3646157.html Sent f

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

2012-01-09 Thread Cor Nouws
Hi Nino, Nino Novak wrote (09-01-12 16:20) Am Sonntag, 8. Januar 2012, 22:52:22 schrieb Cor Nouws: Other hits/remarks of course appreciated as well :-) Just some gut feelings from an occasional tester. First, somehow I'd personally like to have a longer period for Release related QA activit

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

2012-01-09 Thread Cor Nouws
Hi Christian, Christian Lohmaier wrote (09-01-12 02:10) On Sun, Jan 8, 2012 at 10:52 PM, Cor Nouws wrote: So time to prepare bug hunt session two. http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5 and http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5#2nd_Bug-hun

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

2012-01-09 Thread Cor Nouws
Hi Pedro, Thanks for replying. And as we wrote, I reply to the lists too. Pedro Lino wrote (09-01-12 01:34) So time to prepare bug hunt session two. http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5 and http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5#2nd_Bug-hu

Re: [Libreoffice] [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

2012-01-09 Thread Michael Meeks
On Mon, 2012-01-09 at 21:30 +0100, Andras Timar wrote: > > "This document may contain content that cannot be saved in the > > currently selected file format "FORMATNAME". Do you really want to use > > "FORMATNAME"? > > > > To be sure the document is saved correctly, use the ODF format." ... > Than

Re: [Libreoffice] libvisio: how can I help?

2012-01-09 Thread Bruno Girin
On 09/01/12 11:12, Fridrich Strba wrote: Hello, On 09/01/12 11:24, Michael Meeks wrote: I would like to start tackling some of them but as I'm not familiar with the code base, I would welcome suggestions as to which ones are likely to be reasonably easy hacks. I'm not an expert on th

Re: [Libreoffice] [Libreoffice-ux-advise] [PUSHED] Avoid UI bugs in translations

2012-01-09 Thread Andras Timar
Hi Stefan, 2012/1/8 Stefan Knorr (Astron) : > Hi Christoph, William, everyone reading, > > I've made a new patch that does only the following things: > * Correct the [en-US] thing > * Use Christoph's proposal "Confirm File Format" as the window title > * Remove the [en-US-old] text as that would h

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||40438 --- Comment #83 from Rainer Bie

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

2012-01-09 Thread Andras Timar
2012/1/9 Stefan Knorr (Astron) : > Hi Korrawit, > >> For the choice buttons that are too small, IMHO this could be fixed by >> resizing them to be larger, if don't want to change the texts. :-) > > Hm, probably. Could you have a look, though, please, as these labels > are already supposed to get wi

Re: [Libreoffice] [Libreoffice-ux-advise] [PATCH 3.5 and master] Avoid UI bugs in translations

2012-01-09 Thread Stefan Knorr (Astron)
Hi Korrawit, > For the choice buttons that are too small, IMHO this could be fixed by > resizing them to be larger, if don't want to change the texts. :-) Hm, probably. Could you have a look, though, please, as these labels are already supposed to get wider automatically and don't use hard-coded

Re: [Libreoffice] [PUSHED] [PATCH] proposed fix for fdo#44533

2012-01-09 Thread Thorsten Behrens
julien2412 wrote: > Thank you Thorsten for the extra check and the push/commit on master. > Should it be pushed on 3.5 branch too or is it useless ? > It should - just holding off for a round of tinderbox builds, especially for the win32-only changes. Will cherry-pick tomorrow. :) Cheers, -- Tho

Re: [Libreoffice] [PUSHED] [PATCH] proposed fix for fdo#44533

2012-01-09 Thread julien2412
Thank you Thorsten for the extra check and the push/commit on master. Should it be pushed on 3.5 branch too or is it useless ? Julien. -- View this message in context: http://nabble.documentfoundation.org/PATCH-proposed-fix-for-fdo-44533-tp3643134p3645336.html Sent from the Dev mailing list arch

[Libreoffice] [PATCH] Removed unused DBG_WARNING{4, 5} macros, replaced DBG_WARNINGFILE.

2012-01-09 Thread Marcel Metz
Hello lo-devs, this patch removes the unused DBG_WARNING4 and DBG_WARNING5 macros and replaces also the DBG_WARNINGFILE with SAL_INFO as suggested in the tools/debug.hxx headers. regards Marcel --- cui/source/dialogs/iconcdlg.cxx |2 +- sfx2/source/dialog/tabdlg.cxx |4 ++-- tools/in

Re: [Libreoffice] [PUSHED] [PATCH] proposed fix for fdo#44533

2012-01-09 Thread Thorsten Behrens
julien2412 wrote: > I attached a patch for fdo#44533 (SLIDESHOW: CRASH when play particular > presentation with sound). > I attached in the bugtracker the backtrace > (https://bugs.freedesktop.org/attachment.cgi?id=55314) > and console logs (https://bugs.freedesktop.org/attachment.cgi?id=55315) >

[Libreoffice] [PATCH binfilter] Remove cruft in debug tools.

2012-01-09 Thread Marcel Metz
--- binfilter/bf_sfx2/source/bastyp/sfx2_bitset.cxx | 10 -- binfilter/bf_sfx2/source/bastyp/sfx2_minarray.cxx |6 -- 2 files changed, 0 insertions(+), 16 deletions(-) diff --git a/binfilter/bf_sfx2/source/bastyp/sfx2_bitset.cxx b/binfilter/bf_sfx2/source/bastyp/sfx2_bitset.c

[Libreoffice] [PATCH core] Remove cruft in debug tools.

2012-01-09 Thread Marcel Metz
Hello lo-devs, the define SV_MEMMGR in tools/source/debug/debug.cxx was commented out since 2001 and all of the memory related debugging code depends on this define. These patches removes all of the depending code. The ini configuration reader and writer for the debugging configuration now simply

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 36681, which changed state. Bug 36681 Summary: EDITING: after inserting a picture view scrolls to end of document https://bugs.freedesktop.org/show_bug.cgi?id=36681 What|Old Value |New V

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Alexander Thurgood
Le 09/01/12 17:42, Christian Lohmaier a écrit : Hi Christian, > No, you misunderstood. You don't need to install doxygen if you only > want to provide extensions. > > If you want to build & offer the LO SDK itself for download, then (and > only then) you need it. > Ah, OK, sorry, I was a bit c

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Alexander Thurgood
Le 09/01/12 17:40, Norbert Thiebaud a écrit : Hi Norbert, > FYI: > > binary of doxygen for acOSX are available here: > http://www.stack.nl/~dimitri/doxygen/download.html#latestsrc > > after install (assuming a standard drag-and-drop in Applications) > sudo ln -s /Applications/Doxygen.app/Conten

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Christian Lohmaier
Hi Alexander, *, On Mon, Jan 9, 2012 at 5:17 PM, Alexander Thurgood wrote: > > Thanks for that information. If I understand correctly, it means that if > I want to keep on distributing the mysql connector extension on the > extensions site with any associated documentation, then I need to > insta

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Norbert Thiebaud
FYI: binary of doxygen for acOSX are available here: http://www.stack.nl/~dimitri/doxygen/download.html#latestsrc after install (assuming a standard drag-and-drop in Applications) sudo ln -s /Applications/Doxygen.app/Contents/Reources/doxygen /usr/local/bin/doxygen and you're all set :-) Norber

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #82 from Astron 2012-01-09 08:39:21 PST --- I am a bit unsure about these, but I'd like to nominate: Bug 38515 - LibreOffice crashes in Bibliography dialog when pressing Enter – Because it's a crash and has been in LibO at least sinc

Re: [Libreoffice] Updating Italian dictionaries

2012-01-09 Thread Andrea Pescetti
On 05/01/2012 Andrea Pescetti wrote: On 05/01/2012 Andras Timar wrote: Why would you like to pack and distribute files from the legacy folder? Those look useless to end users. Because they allow to see who contributed what and when. They are indeed of little interest for end users (and the con

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Alexander Thurgood
Hi Christian, Le 09/01/12 16:34, Christian Lohmaier a écrit : > Yes, and that's why I wrote it is required for release-builds. But > unless you publish your LibreOffice SDK/ODK package for download, then > you are free to build the ODK without generated documentation. So when > you build you can:

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Bug 37361 depends on bug 44498, which changed state. Bug 44498 Summary: All OpenDocument files created with LibO 3.4 or 3.5 are considered as invalid by Microsoft Office https://bugs.freedesktop.org/show_bug.cgi?id=44498 What|Old

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Christian Lohmaier
On Mon, Jan 9, 2012 at 4:12 PM, Alexander Thurgood wrote: > Le 09/01/12 15:51, Christian Lohmaier a écrit : > > Hi Christian, > >> >> It is only required if you want to build the documentation from the >> source-files. So for release-builds: yes, it is required. For the >> casual developer: No, no

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Stephan Bergmann
On 01/09/2012 04:12 PM, Alexander Thurgood wrote: Ah, thanks for that, most useful, but doesn't the SDK need to be built if you are building extensions, or am I conufusing that with the ODK ? The names "SDK," "ODK," and "UDK" are used somewhat interchangeably. But the SDK is not needed to buil

Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#44442, crash in ScInterpreter::GetDBParam with specific document

2012-01-09 Thread Eike Rathke
Hi Markus, On Sunday, 2012-01-08 21:19:13 +0100, Markus Mohrhard wrote: > > In case this needs to go to the -3-4-5 branch, we'll need 2 more sign-off's. > > I think that 3-4-5 is through and it is not a high priority patch. I > think it only happens in rare circumstances. However, in case we wa

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Alexander Thurgood
Le 09/01/12 15:51, Christian Lohmaier a écrit : Hi Christian, > > It is only required if you want to build the documentation from the > source-files. So for release-builds: yes, it is required. For the > casual developer: No, not required, and you don't usually build the > SDK in that case at al

Re: [Libreoffice] [PATCH] About enabling Icedove addressbook connection for Base

2012-01-09 Thread Caolán McNamara
On Fri, 2012-01-06 at 14:27 -0800, julien2412 wrote: > Last thing : I don't know if the change in > extensions/source/abpilot/abspilot.src is useful or even right. > > Does the patch seem ok ? > > (if yes, i can commit and push it on master) Looks sane to me, go for it. C. ___

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Christian Lohmaier
Hi *, On Mon, Jan 9, 2012 at 3:38 PM, Alexander Thurgood wrote: > Le 05/01/12 20:11, Stephan Bergmann a écrit : > >> I simply sticked to the --with-doxygen scheme for now.  Tinderbox >> maintainers, please remember to install doxygen if not yet present >> (preferred) or add --without-doxygen to a

Re: [Libreoffice] Doxygen for C/C++ URE Documentation

2012-01-09 Thread Alexander Thurgood
Le 05/01/12 20:11, Stephan Bergmann a écrit : Hi Stephan, > I simply sticked to the --with-doxygen scheme for now. Tinderbox > maintainers, please remember to install doxygen if not yet present > (preferred) or add --without-doxygen to autogen.lastrun (which will > cause the C++ documentation to

Re: [Libreoffice] [PUSHED] [PATCH] [RFC] COMPRESSMODE_FULL

2012-01-09 Thread Thorsten Behrens
Hi Matteo, sorry for the lag, hope you had a great holiday season - Matteo Casalin wrote: > just and after-thought: some of the cleaned-up I/Os regard > variables of type "long" (Pair, Rectangle...). I was afraid this > could be platform dependent, but it seems that SvStream casts them > to i

Re: [Libreoffice] [PATCH] ScGlobal::GetAutoFormat not always required to create fresh instance

2012-01-09 Thread Kohei Yoshida
Hi Stephan, On Mon, 2012-01-09 at 09:29 +0100, Stephan Bergmann wrote: > However, whether it actually would be an advantage to not have to > address the other calls to GetAutoFormat, I am not sure. After all, > those calls that afterwards check for null-ness *are* dubious. Indeed. I've gotte

Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff

2012-01-09 Thread Michael Stahl
On 09/01/12 13:04, Christophe Strobbe wrote: > So java_uno_accessbridge is only added when "SOLAR_JAVA" is set to > "TRUE", which AFAICT is something that happens at compile time. > I assume this patch is part of the work to (locate and) reduce Java > dependencies in order to (1) make it easier f

Re: [Libreoffice] [Patch] [Review 3.5 - Late Feature][PUSHED] Improved copying between different calc documents

2012-01-09 Thread Eike Rathke
Hi Markus, On Saturday, 2012-01-07 01:46:53 +0100, Markus Mohrhard wrote: > Pushed it now to 3-5 and resolved all comments from Eike and Kohei. YAY! Great work! Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0

Re: [Libreoffice] Change in addition for date handling (intentional change??)

2012-01-09 Thread Noel Power
On 06/01/12 21:39, Andrew Douglas Pitonyak wrote: Off hand, I might be inclined to simply move the code back to its original location, which would set the behavior back to letting math with dates return dates, rather than just specific operations (which is not even supported now). yeah I agree,

Re: [Libreoffice] [PATCH] If there's no java, don't do the java stuff

2012-01-09 Thread Christophe Strobbe
Hi Korrawit, At 18:24 8-1-2012, Korrawit Pruegsanusak wrote: Hello all, This attached patch fixes build on windows / cygwin. I'm building --without-java, and it breaks because not found "java_uno_accessbridge", which seems java-related. I noticed on the mailing list that David Tardon has alr

Re: [Libreoffice] [PATCH] [PUSHED] Replace Table with std::set.

2012-01-09 Thread Stephan Bergmann
On 01/09/2012 11:56 AM, Stephan Bergmann wrote: (Please consider using "git format-patch" to produce patches in the future. It slightly simplifies things for committers.) Forget it, I failed to notice that the OP apparently was produced with "git send-email" (instead of manually creating an em

Re: [Libreoffice] Bug 39428 (https://bugs.freedesktop.org/show_bug.cgi?id=39428#c1)

2012-01-09 Thread Stephan Bergmann
On 01/06/2012 06:08 PM, Keith McRae wrote: Building tools/ results in errors from tools/inc/fract.o, tools/inc/tools/gen.o, tools/source/generic/fract.o and tools/source/generic/poly.o due to "undefined reference to SvStream::operator>>(long&)" Question: Should I modify these classes to use the

Re: [Libreoffice] UI disaster on Windows: soffice -h

2012-01-09 Thread Fridrich Strba
Hello, On 07/01/12 23:56, Andras Timar wrote: > I've just found this feature, soffice -h displays a dialog box on > Windows with some help text. > Problems: > 1. Dialog is not localisable. Help text comes from const char arrays > in desktop/source/app/cmdlinehelp.cxx > 2. Help text is clipped, the

Re: [Libreoffice] [Libreoffice-ux-advise] UI disaster on Windows: soffice -h

2012-01-09 Thread Jesús Corrius
Hi, > Indeed, there is > helpcontent2/source/text/shared/guide/start_parameters.xhp but it is > outdated. Maybe I can update it quickly... > > I'll also try what Stephan suggested, i.e. if we can print to stdout > in Windows, too. On Windows console applications naturally print parameters to stdo

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

2012-01-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Petr Mladek changed: What|Removed |Added Depends on||43989 --- Comment #81 from Petr Mladek 20

Re: [Libreoffice] UI disaster on Windows: soffice -h

2012-01-09 Thread Pedro
Stephan Bergmann-2 wrote > > Not sure we need either this dialog box or any localization at all: > > On other platforms, soffice -h outputs to stdout (or maybe stderr). > Given that adding command line arguments (what soffice -h educates > about) is presumably done mostly through some terminal

Re: [Libreoffice] libvisio: how can I help?

2012-01-09 Thread Fridrich Strba
Hello, On 09/01/12 11:24, Michael Meeks wrote: >> I would like to start tackling some of them but as I'm not familiar >> with the code base, I would welcome suggestions as to which ones are >> likely to be reasonably easy hacks. > I'm not an expert on this - so treat this with a pinch of sa

Re: [Libreoffice] [MacOS] Starting dev-install is hairy

2012-01-09 Thread Stephan Bergmann
On 01/07/2012 09:07 AM, James C wrote: I've had trouble working out, from the code, what a user installation path is. There are two classes called Bootstrap, and my one reads the details from a map, which I assume is populated somewhere. utl::Bootstrap::locateUserInstallation from unotools/boo

Re: [Libreoffice] [Libreoffice-ux-advise] UI disaster on Windows: soffice -h

2012-01-09 Thread Tor Lillqvist
> I'll also try what Stephan suggested, i.e. if we can print to stdout > in Windows, too. Note that one layer of silly wrapping could probably be dropped by using AttachConsole(ATTACH_PARENT_PROCESS) followed by freopen()ing stdout and stderr to CONOUT$. AttachConsole() is present on XP and later.

Re: [Libreoffice] UI disaster on Windows: soffice -h

2012-01-09 Thread Rainer Bielefeld
Andras Timar schrieb: I've just found this feature, soffice -h Hello, we have a Bug for that: CU Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.or

Re: [Libreoffice] [PATCH] [PUSHED] Replace Table with std::set.

2012-01-09 Thread Stephan Bergmann
On 01/07/2012 10:13 PM, Marcel Metz wrote: this patch removes another use of the tools Table class. Pushed as , thanks. (Please consider using "git format-patch" to produce patches in the futur

Re: [Libreoffice] [Libreoffice-ux-advise] UI disaster on Windows: soffice -h

2012-01-09 Thread Andras Timar
2012/1/9 Michael Meeks : > Hi Andras, > > On Sat, 2012-01-07 at 23:56 +0100, Andras Timar wrote: >> I've just found this feature, soffice -h displays a dialog box on >> Windows with some help text. > >        Heh - what fun :-) > >> Problems: >> 1. Dialog is not localisable. Help text comes from co

Re: [Libreoffice] UI disaster on Windows: soffice -h

2012-01-09 Thread Stephan Bergmann
On 01/07/2012 11:56 PM, Andras Timar wrote: I've just found this feature, soffice -h displays a dialog box on Windows with some help text. Problems: 1. Dialog is not localisable. Help text comes from const char arrays in desktop/source/app/cmdlinehelp.cxx 2. Help text is clipped, there is not eno

Re: [Libreoffice] [Libreoffice-ux-advise] UI disaster on Windows: soffice -h

2012-01-09 Thread Michael Meeks
Hi Andras, On Sat, 2012-01-07 at 23:56 +0100, Andras Timar wrote: > I've just found this feature, soffice -h displays a dialog box on > Windows with some help text. Heh - what fun :-) > Problems: > 1. Dialog is not localisable. Help text comes from const char arrays > in desktop/source/a

Re: [Libreoffice] About cppcheck 2 reports for desktop/unx/source/file_image_unx.c

2012-01-09 Thread Michael Meeks
Hi Julien, On Sun, 2012-01-08 at 03:25 -0800, julien2412 wrote: > For the file desktop/unx/source/file_image_unx.c, cppcheck tells : > line 120 is : w.m_size -= w.m_size; > Either this is right and it could be simplified with w.m_size = 0 > or it's wrong and what should it be ? > (this time no ove

Re: [Libreoffice] About cppcheck 2 reports for desktop/unx/source/file_image_unx.c

2012-01-09 Thread Stephan Bergmann
On 01/08/2012 12:25 PM, julien2412 wrote: For the file desktop/unx/source/file_image_unx.c, cppcheck tells : 120 duplicateExpression style Same expression on both sides of '-'. 93 unreadVariable style Variable 'c' is assigned a value that is never used line 93 is : volatile ch

Re: [Libreoffice] libvisio: how can I help?

2012-01-09 Thread Michael Meeks
Hi Bruno, On Sun, 2012-01-08 at 14:53 +, Bruno Girin wrote: > I've been doing some tests with sample Visio files and I've now added a > grand total of 7 bug reports [1]. Nice work testing ! :-) > I would like to start tackling some of them but as I'm not familiar > with the code ba

Re: [Libreoffice] [Libreoffice-ux-advise] Complete removal of the Windows/Linux quickstarter, was: Re: Removing LibO on Windows ...

2012-01-09 Thread Michael Meeks
On Sun, 2012-01-08 at 16:34 +0100, Regina Henschel wrote: > > It's the OS's domain to (quickly) start applications, and OS's are > > pretty good at that. If you want to start anything particularly > > quickly on... Hey ho ;-) clearly the more cruft we can remove the better, but at least f

Re: [Libreoffice] [PATCH] [PUSHED] msvc doesn't allow dll interface in both class and functions

2012-01-09 Thread Stephan Bergmann
On 01/08/2012 06:20 PM, Korrawit Pruegsanusak wrote: IMHO, the problem is caused by part of the commit [1] Seems msvc doesn't allow us to have SAL_DLLPUBLIC_EXPORT in both class and functions definition. It throws compiler error C2487 [2] So, I tried to fix with 2 methods: 1. Remove dll interfac

Re: [Libreoffice] [PATCH] [PUSHED] If there's no java, don't do the java stuff

2012-01-09 Thread David Tardon
On Mon, Jan 09, 2012 at 12:24:25AM +0700, Korrawit Pruegsanusak wrote: > Hello all, > > This attached patch fixes build on windows / cygwin. > > I'm building --without-java, and it breaks because not found > "java_uno_accessbridge", which seems java-related. > So, I add a check whether we have "S

Re: [Libreoffice] [PATCH] [PUSHED] Also gives BoundListeners a CPPUHELPER_DLLPUBLIC

2012-01-09 Thread Stephan Bergmann
On 01/08/2012 06:04 PM, Korrawit Pruegsanusak wrote: This attached patch gives class BoundListeners a CPPUHELPER_DLLPUBLIC, which resolves "error LNK2019: unresolved external symbol" for the symbols in this class. Although BoundListeners' parent (PropertySetMixinImpl) already has CPPUHELPER_DLLP

Re: [Libreoffice] Does smoketest run on cygwin? or package format another than "archive"?

2012-01-09 Thread Stephan Bergmann
On 01/08/2012 06:47 PM, Korrawit Pruegsanusak wrote: This is a consequence of trying to fix the build on windows / cygwin. I tried to run a smoketest by running `/opt/lo/bin/make check`, and it gives an error http://pastebin.com/EarX4TC0 From an error, IMHO it tried to find an "archive" version

Re: [Libreoffice] Python Bridge on MacOS x64 with python default

2012-01-09 Thread Stephan Bergmann
On 01/08/2012 06:59 PM, Ovnicraft wrote: On Wed, Jan 4, 2012 at 3:05 AM, Stephan Bergmann mailto:sberg...@redhat.com>> wrote: The Python--UNO bridge is included in LO itself (see LibreOffice.app/Contents/__MacOS/py*), the SDK traditionally has little (additional) support for PyUNO.

Re: [Libreoffice] [PATCH] ScGlobal::GetAutoFormat not always required to create fresh instance

2012-01-09 Thread Stephan Bergmann
On 01/09/2012 08:10 AM, Markus Mohrhard wrote: In my opinion we have two bugs here.. The ScGlobal::ppRscStrin is being deleted in the ScModule destructor which means that calc is no longer open. So the question is why do we delete ScAutoFormatObj after ScModule and the second one is that we are c

Re: [Libreoffice] [PATCH] ScGlobal::GetAutoFormat not always required to create fresh instance

2012-01-09 Thread Stephan Bergmann
On 01/07/2012 02:07 AM, Kohei Yoshida wrote: Anyway, it's my understanding that the main problem is that the global ScAutoFormat instance unintentionally get instantiated in the destructor of ScAutoFormatObj during the termination of the cppunit? In that case, what I would do is to add ScGlobal: