Hi Gustavo,
On 2011-12-20 at 16:19 -0200, Gustavo Pacheco wrote:
> Fix for EasyHack FDO42454
> (https://bugs.freedesktop.org/show_bug.cgi?id=42454) in attachment for
> review.
Thank you very much for the patch! :-) - and sorry that it took so long
to apply. I used most of that, please see:
htt
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi
Please find enclosed a patch to fix fdo#44280
The patch was done in master and should be cerry picked in 3.5 ASAP
Kind regards
- --
Olivier Hallot
Founder, Board of Directors Member - The Document Foundation
LibreOffice translation leader for Br
Hi Thorsten,
On 2011-12-13 at 11:39 +0100, Thorsten Behrens wrote:
> > Compared to my request quoted above, this also gets in the loop the
> > committer of the fix. It uselessly spams people that committed since
> > last failure and did not fix the build (but did an unrelated change),
> > but I t
Hello,
Another "Same expression on both sides of '||'"
detected by cppcheck.
I supposed this patch but I made a research of "INVOKE_PROPERTYPUT" on the
file, either it's not the only location where INVOKE_PROPERTYPUTREF should
be used or INVOKE_PROPERTYPUTREF shouldn't be used at all in this cas
Hello Matúš, all,
On Thu, Dec 29, 2011 at 19:37, Matúš Kukan wrote:
> Ah, sorry, it has been already fixed by
> 2d9aac80a17b61f8339b80a4bc1555940255a8ff
> I should have realized that.
Never mind :) This reminds me - that I should ./g pull -r now.
Best Regards,
--
Korrawit Pruegsanusak
___
Hi Cedric, all,
I have been playing recently with the great new header / footer
indicators, and there were 2 things that I considered suboptimal from
the UX point of view:
- Appearing / disappearing of the controls after 1 second
I noticed that most of the time when I am using that, I am terri
Hello Korrawit,
On 29 December 2011 13:15, Korrawit Pruegsanusak
wrote:
> Anyway, I think I've found the cause: hunspell is calling 3 functions
> in icu, but we don't have any icu library to link with => linker
> failed.
> So, I attached a patch to fix this. Could you please review it?
Ah, sorry
Hello Matúš, all,
On Tue, Dec 27, 2011 at 06:36, Matúš Kukan wrote:
> but I think
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=472a7db1ef118147d949b13c66bb86411dbc7a75
> should solve it.
Thanks, but it doesn't help.
Anyway, I think I've found the cause: hunspell is calling 3 functi
Hi,
See attached.
Remove SvStrings definition and obsolete #defines.
Regards,
Brad
>From 38768e0e948d2e18da6aef588c4edaef72b32758 Mon Sep 17 00:00:00 2001
From: Brad Sowden
Date: Thu, 29 Dec 2011 20:55:21 +1300
Subject: [PATCH 8/8] fdo#38831 remove SvStrings definition and obsolete
#defines
Hi,
See attached.
Remove unused variables.
Regards,
Brad
>From 6ffc7eb2a90a83c39785761b7a6add8cbf733cf9 Mon Sep 17 00:00:00 2001
From: Brad Sowden
Date: Thu, 29 Dec 2011 18:28:00 +1300
Subject: [PATCH 7/8] Remove unused variables
---
sc/source/ui/inc/parawin.hxx |8
sfx2/inc/sf
Hi,
See attached.
Note 1
--
With the for loop below Insert(x,nPos) was previously applied but nPos
is initialised to the end of vector and is always incremented in every
loop iteration i.e. Insert(x,nPos) is effectively a push_back(x). Agree?
In "short SvxNumberFormatShell::FillEListWith
Hi,
See attached.
Remove a function contained in unusedcode.easy that includes SvStrings.
Regards,
Brad
>From 71f1914ced8f0d6b5aca26e9e83270d95e4437a1 Mon Sep 17 00:00:00 2001
From: Brad Sowden
Date: Thu, 29 Dec 2011 13:44:52 +1300
Subject: [PATCH 5/8] Remove unusedcode.easy
---
svx/inc/sv
Hi,
See attached.
Regards,
Brad
>From 4108bbb38a77b6552582e1972fc77019ff583a8a Mon Sep 17 00:00:00 2001
From: Brad Sowden
Date: Thu, 29 Dec 2011 12:25:26 +1300
Subject: [PATCH 4/8] fdo#38831 convert SvStrings to std::vector unotbl.cxx
---
sw/source/core/unocore/unotbl.cxx | 19
Hi,
See attached.
Regards,
Brad
>From 664e8e28dfb3eec445a679ca36aa61c0b1582104 Mon Sep 17 00:00:00 2001
From: Brad Sowden
Date: Thu, 29 Dec 2011 10:54:13 +1300
Subject: [PATCH 3/8] fdo#38831 convert SvStrings to std::vector unofield.cxx
---
sw/source/core/unocore/unofield.cxx | 15 +++
Hi,
See attached.
Note 1
--
I made the following change in one place. Is this ok or should I call
reserve(10) to be safe?
-SvStrings aArr( 10, 10 );
+std::vector aArr;
Regards,
Brad
>From 23613a0ae4e80fdda1fcf1c458b55c526f9fdf58 Mon Sep 17 00:00:00 2001
From: Brad Sowde
Hi,
See attached.
Note 1
--
I assume casting from size_t to sal_uInt16 is reasonable in the
following scenario (I didn't want to update all callers in this patch)?
sal_uInt16 SwGlossaries::GetGroupCnt()
{
-return GetNameList()->Count();
+return static_cast(GetNameList()->size()
https://bugs.freedesktop.org/show_bug.cgi?id=37361
--- Comment #65 from Marc Kaulisch 2011-12-29 01:21:43 PST
---
Writer (beta2) crashes after leaving to another program on Win7 64bit
https://bugs.freedesktop.org/show_bug.cgi?id=44260
--
Configure bugmail: https://bugs.freedesktop.org/userpref
Hi,
Following on from the 2 previous patches that I sent to the list, this
series of patches removes all remaining instances of SvStrings.
Patches contributed under LGPLv3+/MPL1.1.
Regards,
Brad
___
LibreOffice mailing list
LibreOffice@lists.freedes
18 matches
Mail list logo
