On Mon, Sep 12, 2011 at 01:50:29AM +0200, Lionel Elie Mamane wrote:
> On Mon, Sep 12, 2011 at 01:07:53AM +0200, Eike Rathke wrote:
>> On Monday, 2011-09-12 00:25:51 +0200, Lionel Elie Mamane wrote:
>>> 0001-fdo-40701-DbGridControl-RemoveColumn-even-if-no-corr.patch
>>> fixes the root cause of the
Commited and pushed on master.
Thanks !
--
View this message in context:
http://nabble.documentfoundation.org/Review-simple-bugfix-too-simple-tp3327833p3328796.html
Sent from the Dev mailing list archive at Nabble.com.
___
LibreOffice mailing list
Libr
On Sun, Sep 11, 2011 at 6:37 PM, Eike Rathke wrote:
> Hi Lionel,
>
> On Monday, 2011-09-12 01:17:32 +0200, Lionel Elie Mamane wrote:
>
>> Looks good & low-risk to me, pushed.
>
> You were 8 minutes faster than me ;)
>
> Please attribute the proper author in commits, either use git am or stg
> impo
P.P.S. Alas, I forgot to patch cppcheck-htmlreport with my local
changes, so next run the page will return to its former sortable glory.
--
Jesse Adelman
Senior Systems Shepherd
ilikelinux Consulting/Bold and Busted, LLC
http://ilikelinux.com/ http://boldandbusted.com/
Brisbane, CA
Tel: (415) 656
Hi *,
I updated cppcheck to the "latest" from the project's git repo. Hope it
works well. :) The first run against this version of cppcheck is in
progress; you should see the page updated in ~2 hours.
http://libreoffice.boldandbusted.com/
BTW, the entire git pull + cppcheck + htmlreport run agai
On Mon, Sep 12, 2011 at 01:07:53AM +0200, Eike Rathke wrote:
> On Monday, 2011-09-12 00:25:51 +0200, Lionel Elie Mamane wrote:
>> 0001-fdo-40701-DbGridControl-RemoveColumn-even-if-no-corr.patch
>> fixes the root cause of the bug, which caused
>> void DbGridControl::EnableHandle(sal_Bool bEnable)
>
Hi Lionel,
On Monday, 2011-09-12 01:17:32 +0200, Lionel Elie Mamane wrote:
> Looks good & low-risk to me, pushed.
You were 8 minutes faster than me ;)
Please attribute the proper author in commits, either use git am or stg
import -m or some such to read in the patch from a mail, or explicitly
s
On Sun, Sep 11, 2011 at 03:58:14PM +0200, Rene Engelhard wrote:
> see http://bugs.debian.org/637829. Basically oosplash relies
> on ../ure/bin being present, which isn't always the case. E.g.
> on Debian we have the whole ure in /usr/lib/ure.
> We should use the proper mechanism (like basis-link/
Hi Lionel,
On Monday, 2011-09-12 00:25:51 +0200, Lionel Elie Mamane wrote:
> 0001-fdo-40701-DbGridControl-RemoveColumn-even-if-no-corr.patch
> fixes the root cause of the bug, which caused
> void DbGridControl::EnableHandle(sal_Bool bEnable)
> {
> RemoveColumn(0);
> m_bHandle = bEnable;
>
On Sun, Sep 11, 2011 at 10:04:52PM +0200, CaStarCo wrote:
> I've created a second (very little too) patch to reduce the scope of a
> variable.
> --- a/sal/osl/w32/file_dirvol.cxx
> +++ b/sal/osl/w32/file_dirvol.cxx
> @@ -60,7 +60,6 @@ extern "C" BOOL TimeValueToFileTime(const TimeValue
> *cpTimeV
Hi Julien,
On Sunday, 2011-09-11 22:53:45 +0200, Julien Nabet wrote:
> @@ -124,7 +124,7 @@ void createSettingsStructure(xmlDoc * document,
> bool * bNeedsSave)
> }
> if (bFound)
> {
> -bNeedsSave = false;
> +*bNeedsSave = false;
> return;
> }
> //
On Sun, Sep 11, 2011 at 10:53:45PM +0200, Julien Nabet wrote:
> Cppcheck detected this :
> core/jvmfwk/source/elements.cxx
> 127assignBoolToPointererrorAssigning bool value to
> pointer (converting bool value to address)
> Here is a simple patch :
> Too simple to be true ? I prefer
The attached patches are backport to 3.4 of my master commits
b71d12fbfdd4aad0b576645a0d7bbf71d1da7a3a
0ef7ce4a234c6649dcca219b96185acb7634fe34
1b6310433280ae4e8439dcbf17dfa763bf2826cc
They are related to fdo#40701.
0001-fdo-40701-DbGridControl-RemoveColumn-even-if-no-corr.patch
fixes the root ca
Hi Marco
Do you mind to write some lines on how you succeded to have the big
source code set under Eclipse CDT?
Thanks in advance
Olivier
Em 11-09-2011 17:14, Marco escreveu:
Hi Thorsten,
I completed the switch to the new unified repository, everything
built smoothly and I also succeeded i
Hello,
Cppcheck detected this :
core/jvmfwk/source/elements.cxx
127assignBoolToPointererrorAssigning bool value to pointer
(converting bool value to address)
Here is a simple patch :
diff --git a/jvmfwk/source/elements.cxx b/jvmfwk/source/elements.cxx
index bb5cf62..b54e380 100644
Marco wrote:
> Now before bringing my project forward I'm going to request a git
> repo account through Freedesktop bugzilla site.
>
Hey Marco, sure, go for it -
http://www.freedesktop.org/wiki/AccountRequests has the details.
Cheers,
-- Thorsten
pgpqx8mPyDtim.pgp
Description: PGP signature
___
On Sun, Sep 11, 2011 at 2:39 PM, CaStarCo wrote:
> Hello, I've created a very little patch to solve the next CppCheck warning (
> http://libreoffice.boldandbusted.com/464.html ) . (This is my first patch in
> LibreOffice)
Welcome to libreoffice and thanks for the patch.
Unfortunately you got the
Hi Thorsten,
I completed the switch to the new unified repository, everything
built smoothly and I also succeeded in configuring eclipse cdt with
the new big source code set. Now before bringing my project forward
I'm going to request a git repo account through Freedesktop bugzilla
site. I create
Ups :( , my patch introduced a bug, it's not valid.
2011/9/11 CaStarCo
> Hello, I've created a very little patch to solve the next CppCheck warning
> ( http://libreoffice.boldandbusted.com/464.html ) . (This is my first
> patch in LibreOffice)
>
>
--
- Per la llibertat del coneixement -
- Per
I've created a second (very little too) patch to reduce the scope of a
variable.
From 7c434fd7af9892fee7b120e00a135d01693265af Mon Sep 17 00:00:00 2001
From: Andreu Correa Casablanca
Date: Sun, 11 Sep 2011 22:01:10 +0200
Subject: [PATCH] Reduced the scope of a variable in core/sal/osl/w32/file_dir
Hello, I've created a very little patch to solve the next CppCheck warning (
http://libreoffice.boldandbusted.com/464.html ) . (This is my first patch in
LibreOffice)
From b7646c6393ae557c9f3e11ea68651fca0589360c Mon Sep 17 00:00:00 2001
From: Andreu Correa Casablanca
Date: Sun, 11 Sep 2011 21:28:
Hi,
Please review and cherry-pick to 3-4
http://cgit.freedesktop.org/libreoffice/core/commit/?id=90e489f068d09aaaf46ab15d35091198ed84bed1
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=39485
Thanks
Eike
--
PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
Key ID:
On 09/09/2011 09:45 PM, Stephan Bergmann wrote:
On 09/07/2011 02:56 PM, Bjoern Michaelsen wrote:
sal/inc/sal/types.h | 16
1 file changed, 16 insertions(+)
New commits:
commit de290e726ed2aa5a4c007d61a7db1042c45d43db
Author: Bjoern Michaelsen
Date: Wed Sep 7 12:37:08 2011 +0200
On Wed, 7 Sep 2011, Stephan Bergmann wrote:
> On 09/07/2011 10:28 AM, Norbert Thiebaud wrote:
> > On Wed, Sep 7, 2011 at 1:47 AM, Stephan Bergmann
> wrote:
> > > On 09/07/2011 03:14 AM, Norbert Thiebaud wrote:
> > > >
> > > > On Tue, Sep 6, 2011 at 5:32 PM, Peter Foley
> wrote:
> > > > >
> > > > >
Hi,
see http://bugs.debian.org/637829. Basically oosplash relies
on ../ure/bin being present, which isn't always the case. E.g.
on Debian we have the whole ure in /usr/lib/ure.
We should use the proper mechanism (like basis-link/ure-link.
I already committed it to master, OK for -3-4?
diff --git
Hi Pierre-André,
On Sunday, 2011-09-11 14:20:57 +0200, Pierre-André Jacquod wrote:
> the struct DdeInstData contains a std::vector, but was initialized
> with memset( pData,0,sizeof(DdeInstData) )
Good catch.
> So I tried to have a consistent initialization with the new struct layout.
That sho
Hi,
Please review and cherry-pick to 3-4
http://cgit.freedesktop.org/libreoffice/core/commit/?id=6f42e4d03b04204b7a864f3c5c9c03548f5e2392
http://cgit.freedesktop.org/libreoffice/core/commit/?id=34c9a01b075788653b89c244eb8b3fcee54bfa68
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=40590
Ei
hello,
I allow me to send also this patch (I should really find out a Windows
box in order to compile / test by myself).
In short: since
a39d4eae Remove DECLARE_LIST(DdeConnections,DdeConnection*)
the struct DdeInstData contains a std::vector, but was initialized with
memset( pData,0,sizeof(D
Hello,
What's the best thing to do :
- to keep objective C++ parts ?
- to replace objective C++ by plain (with or without boost) C++ ?
for me there are already too many languages and flavour of languages. I
would stay with plain C++, not adding objective C++ on top
Just my feelings
regar
Hi,
The small attached patch fixes the compilation in
gtk3salnativewidgets-gtk.cxx, it's just a cast from long int to int.
The errors were:
/media/dev/LibreOffice/gtk3/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx:191:83:
error: narrowing conversion of 'aClipRect.Rectangle::Left()' from 'long
Hello,
I got this comment of a cppcheck developper :
is this objective c++? Can the code be replaced in the tokenizer
with plain C++ somehow?
He seems to be right about objective C++. Then I made a opengrok research, 4
files use "@try". Perhaps, there are other files which use "@ expression",
si
31 matches
Mail list logo
