> The attached patch is an attempt to bring some sanity to the situation:
It seems that you have investigate this quite deeply and I would love to commit
and push your patch. However, I am a bit scared. Could somebody else who
actually understands the issues involved have a look?
> This only do
Hello all,
I have created a patch that adds Trinity Desktop Environment integration
to LibreOffice, and would like to get it included in the upstream
LibreOffice sources if you are interested.
It is based on the old KDE3 integration module, but has been altered to
work with the latest version of
On Wed, Aug 31, 2011 at 10:32:35PM -0400, Kohei Yoshida wrote:
> On Thu, 2011-09-01 at 03:15 +0200, Khaled Hosny wrote:
>
> > BTW, I see you merged the three patches in one commit, though I thought
> > splitting them into more confined changes would be preferred. Is there
> > any general policy fo
On Thu, 2011-09-01 at 03:15 +0200, Khaled Hosny wrote:
> BTW, I see you merged the three patches in one commit, though I thought
> splitting them into more confined changes would be preferred. Is there
> any general policy for this that I can follow in future patches?
Well, I started this page
On Thu, Sep 01, 2011 at 03:07:36AM +0200, Eike Rathke wrote:
> Hi Khaled,
>
> On Thursday, 2011-09-01 02:54:36 +0200, Eike Rathke wrote:
>
> > Nice clean-up, pushed to master
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=6825533b8d93f92a66558a9b6295003ceba52917
>
> Forgot to mentio
On Thu, Sep 01, 2011 at 02:13:34AM +0200, Eike Rathke wrote:
> Hi Khaled,
>
> On Monday, 2011-08-29 20:21:47 +0200, Khaled Hosny wrote:
>
> Wow, way cool stuff! :-)
:)
> > #38683[5] is another example of problems caused by this.
>
> I'll set that bug to fixed with a remark to verify as I don't
Hi Khaled,
On Thursday, 2011-09-01 02:54:36 +0200, Eike Rathke wrote:
> Nice clean-up, pushed to master
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=6825533b8d93f92a66558a9b6295003ceba52917
Forgot to mention [PUSHED] in the subject and that I changed all
+#define isAinChar(c)
Hi Khaled,
On Wednesday, 2011-08-31 03:26:30 +0200, Khaled Hosny wrote:
> `git rebase` is your friend:
> http://help.github.com/rebase/
It never occurred to me that rebase has this squash functionality.
I should read more manpages.. thanks a lot!
Just used it on your three joining type patches
Hi Khaled,
On Thursday, 2011-09-01 01:28:28 +0200, Khaled Hosny wrote:
> While trying to fix the eternal brokenness of Kashida justification code,
> I found some low hanging cleanups. See attached patches.
Nice clean-up, pushed to master
http://cgit.freedesktop.org/libreoffice/core/commit/?id=68
Hi
Changed function lcl_formatPersianWord to be more generic, and added support
for some more numbering types:
English word: one, two, three, ...
English cardinal: first, second, third, ...
English cardinal semi-word: 1st, 2nd, 3rd, ...
Persian cardinal word.
I used C++ macros, but do not know wh
Hi Khaled,
On Monday, 2011-08-29 20:21:47 +0200, Khaled Hosny wrote:
Wow, way cool stuff! :-)
> #38683[5] is another example of problems caused by this.
I'll set that bug to fixed with a remark to verify as I don't have
a usable font for this.
> This only done for 'unx' similar work is needed
Hello all,
While trying to fix the eternal brokenness of Kashida justification code,
I found some low hanging cleanups. See attached patches.
Regards,
Khaled
--
Khaled Hosny
Egyptian
Arab
>From 7c237af83055a9b892e7349ee08af92b7202b09c Mon Sep 17 00:00:00 2001
From: Khaled Hosny
Date: Wed,
Hello,
I took some time to take a look and here is what I found :
When I add "SVX_UNOEDIT_OUTLINER_PROPERTIES" in sd/source/core/stlsheet.cxx
, I hadn't noticed this line :
static SvxItemPropertySet aPropSet( aFullPropertyMap_Impl,
SdrObject::GetGlobalDrawObjectItemPool() );
So the array of SfxIt
One thing that I find is missing from linux is a good ecard program, like
windows office had with their Greetings 99, we were talking about this on
another forum and thought it would be a great add to this program, it could
be made as a standalone but it would make a great add to this already grea
Hi Takashi,
On Thursday, 2011-09-01 01:14:53 +0900, Takashi Nakamoto wrote:
> Yes, I agree that this patch and my further contribution is subject
> to LGPLv3+ and MPL 1.1.
Good :)
> I'm also attaching one more patch which solves a similar problem in
> a different module (pango).
Pushed to mast
Hi Takashi,
On Tuesday, 2011-08-30 00:27:47 +0900, Takashi Nakamoto wrote:
> The attached patch solves a compilation error in libxml2 which occurs on
> Windows with some Asian locales. I would appreciate if someone pushes this.
Pushed to master
http://cgit.freedesktop.org/libreoffice/core/commit
Hi all,
thanks for all your tips. I had a look at 'StGit', it seems to help me,
so I will give it a try.
For the workflow with branches, I will start a new build, when I'm back
from 'Hackfest München'.
Kind regards
Regina
___
LibreOffice mailing l
https://bugs.freedesktop.org/show_bug.cgi?id=37361
Regina Henschel changed:
What|Removed |Added
CC||rb.hensc...@t-online.de
Depend
I apologize for cross-posting this.
;)Frode
2011/8/19, Frode Severin Hatlevik :
> Hi all!
>
> I am a happy user of ODF, and have been so for a long time. I have a
> proposal, though, for a new use of ODF. I believe this can be a good
> advantage in the competition with other file formats.
>
> I
https://bugs.freedesktop.org/show_bug.cgi?id=35673
--- Comment #192 from Aaron Strontsman 2011-08-31
12:05:35 PDT ---
Can we add Bug 39355 ? This can be rather humiliating when you send a PDF to
someone who uses Adobe Reader instead of a free PDF reader.
--
Configure bugmail: https://bugs.free
Hi Kohei
First, let me also CC Thorsten as he is also on the TC and is more
> active than I.
>
OK, thanks.
> Can you explain in detail what actual file format change you propose,
> and how it is to be used with specific use cases, using real world use
> cases. The description you gave above is
Hi Eike,
> Makes sense. Please confirm that you contribute this and possibly
> further patches under LGPLv3+ and MPL 1.1 licenses.
Yes, I agree that this patch and my further contribution is subject to
LGPLv3+ and MPL 1.1.
I'm also attaching one more patch which solves a similar problem in a
Hi
I'm really sorry, but it seems like this is just completely my own fault.
Apparently MS-Windows works around this issue by preventing people from
creating accounts with the same name as the
machine.
When I installed this machine and ran into that, I assumed it was a bug and
found a way to for
Hi
Thanks for the patch, but no, it doesn't fix the problem.
Going home now, but I'll be available tomorrow if you have any more ideas for
me to try out :-)
Thanks, Noel Grandin
Tor Lillqvist wrote:
>> This appears to be a windows weirdity related to the fact that my account
>> name and my mac
> This appears to be a windows weirdity related to the fact that my account
> name and my machine name is the same.
> Under this situation, the LookupAccountName API call will return the wrong
> answer.
Well, "wrong" or "right" is a matter of opinion here, I guess... The
documentation doesn't e
Hi
This appears to be a windows weirdity related to the fact that my account name
and my machine name is the same.
Under this situation, the LookupAccountName API call will return the wrong
answer.
See here:
http://archives.neohapsis.com/archives/ntbugtraq/1998-1999/msg00516.html
Regards, Noel.
> strUserID: S-1-5-21-3395787511-4075999146-953599952
> comes from qa/osl/security/osl_Security.cxx
>
> strID: S-1-5-21-3395787511-4075999146-953599952-1000
> comes from osl/w32/security.c
Hmm, for me, if I add code to just print out the aMessage even if the assertion
doesn't fail, I see:
strUs
HI
> Nah, why bother with abbreviations at all, surely it is not too much to
> expect people to write "LibreOffice" in full in *documentation* ? (online
> chat is another thing)
>
> Committed the patch (and then committed a follow-up that dropped the "LO")
> and pushed. (If anybody feels stron
> I think we use LibO, not LO, as the official abbreviation of
> LibreOffice. So, I would change LO to LibO.
Nah, why bother with abbreviations at all, surely it is not too much to expect
people to write "LibreOffice" in full in *documentation* ? (online chat is
another thing)
Committed the pa
On Wed, 2011-08-31 at 00:12 +0430, Mohammad Elahi wrote:
> Hi Kohei
>
> I was trying to make outline numbering in libreoffice more flexible by
> using a string to format
> numbers based on it. To use some escaped strings to represend number
> from different levels.
> maybe something like %0 for le
I stuck some debug in the relevant code, and
dwSubAuthorities==5 in security.c
dwSubAuthorities==4 in osl_Security.cxx
So this could be some weird Windows thing because the two modules are using
different API calls to retrieve the SID.
Caolán McNamara wrote:
> On Wed, 2011-08-31 at 14:53 +0200
Hi Laurent,
On Wed, 2011-08-31 at 15:45 +0200, Laurent Godard wrote:
> Hi all
>
> here is a patch (master branch) that add "LibreOffice" and "LO" string
> support to @since tag in idl files
>
> this solves a build breakage in odk if an IDL @since tag in offapi
> contains LibreOffice or LO
I thi
> I know it's a lot to review but I can't help it - it's just a lot of German
> comments =)
Yeah... Looked fine to me. Committed and pushed, thanks!
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mai
Hi all
here is a patch (master branch) that add "LibreOffice" and "LO" string
support to @since tag in idl files
this solves a build breakage in odk if an IDL @since tag in offapi
contains LibreOffice or LO
Laurent
>From f98d6dbbcf8fbc98d4a64709c6575ce507024cc0 Mon Sep 17 00:00:00 2001
From: Lau
Patch to make ulfex.exe link correctly.
This patch and any further contributions from me are under MPL 1.1 / GPLv3+ /
LGPLv3+
Regards, Noel Grandin
Noel Grandin wrote:
> Thanks, it's getting further now, but still throwing the same linker error
> when linking "ulfex.exe"
>
> -- Noel
>
> Caolán
On Aug 31, 2011, at 12:04 PM, Caolán McNamara wrote:
> rtl_string_new_WithLength/rtl_uString_new_WithLength create an
> rtl/String/rtl_uString of the given length, but set the full buffer
> contents to 0s[1]
No idea whether specifying that the "values of all characters are set to 0" was
meant to
On Wed, 2011-08-31 at 14:53 +0200, Noel Grandin wrote:
> New build log attached.
strUserID: S-1-5-21-3395787511-4075999146-953599952
comes from qa/osl/security/osl_Security.cxx
strID: S-1-5-21-3395787511-4075999146-953599952-1000
comes from osl/w32/security.c
so its a matter of seeing which one
Wow! thanks for the quick response. New build log attached.
This is a 32-bit Windows7-Ultimate machine (fully up to date), if that makes
any difference.
Thanks, Noel Grandin
Caolán McNamara wrote:
> On Wed, 2011-08-31 at 14:16 +0200, Noel Grandin wrote:
>> I've attached the build log file for t
On Wed, 2011-08-31 at 14:16 +0200, Noel Grandin wrote:
> I've attached the build log file for that subcomponent.
>
> Test name: osl_Security::getUserIdent::getUserIdent_001
> assertion failed
> - Expression: ( sal_True == strUserID.equals( strID ) ) && ( sal_True
> == bRes )
> - #test comment#:
I've attached the build log file for that subcomponent.
Regards, Noel Grandin
Tor Lillqvist wrote:
>> (1) I had to comment out some code in qa\osl\security\osl_Security.cxx
>> because it was trying to run a unit test which
>> failed because I'm not logged in as Administrator.
> Are you sure? Wh
Hello,
only two more days, and we'll all meet again in Munich! Looking forward
to that! :-)
Following up on my previous e-mail
(http://www.mail-archive.com/libreoffice@lists.freedesktop.org/msg15144.html),
I just wanted to add some more information. If you haven't read the
first message fro
> (1) I had to comment out some code in qa\osl\security\osl_Security.cxx
> because it was trying to run a unit test which
> failed because I'm not logged in as Administrator.
Are you sure? What was the exact failure message you got?
> Perhaps it should skip that test if the currently logged in u
Thanks, it's getting further now, but still throwing the same linker error when
linking "ulfex.exe"
-- Noel
Caolán McNamara wrote:
> On Wed, 2011-08-31 at 12:04 +0200, Noel Grandin wrote:
>> (3) Right now I'm struggling to get past a link error in l10ntools
>> helpmerge.obj : error LNK2019: unre
https://bugs.freedesktop.org/show_bug.cgi?id=35673
Bug 35673 depends on bug 32709, which changed state.
Bug 32709 Summary: PPT/PPTX created by LibreOffice can't be opened by MS
PowerPoint Viewer and MS Office Web Apps
https://bugs.freedesktop.org/show_bug.cgi?id=32709
What|Old Va
Hello Eike,
I made the changes you said, and I resolved the no linefeed issue also,
I hope it is ok now, and can be pushed, actually for me worked fine with
all types of comments. Also I tried to follow the principals you said.
So, push it if you think there is no need to correct something.
Hi all
tring to a add a new property to calc document, i had to append it to an
idl file (offapi/com/sun/star/sheet/SpreadsheetDocumentSettings.idl)
one can read for example
/** specifies whether the automatic adjustment of the row height is
enabled.
@since OOo 3.0
*/
On Tue, 2011-08-30 at 15:31 -0700, jumbo444 wrote:
> Thank you for your answer.
>
>
> Caolán McNamara wrote:
> >
> > attaching the replacements (or git binary patch I suppose) to a bug
> > against libreoffice at https://bugs.freedesktop.org/ would work in the
> > interim.
> >
>
> I opened bug
On Wed, 2011-08-31 at 12:04 +0200, Noel Grandin wrote:
> (3) Right now I'm struggling to get past a link error in l10ntools
> helpmerge.obj : error LNK2019: unresolved external symbol
> "__declspec(dllimport) class rtl::OString __cdecl
> comphelper::string::getToken(class rtl::OString const &,long,
So, playing around with the sal string classes I see that...
rtl_string_new_WithLength/rtl_uString_new_WithLength create an
rtl/String/rtl_uString of the given length, but set the full buffer
contents to 0s[1]
meanwhile I see that we have x_rtl_uString_new_WithLength in
inc/i18nutil/x_rtl_ustring
Thanks, you're right, with one repo, the checkout and build process is
definitely much smoother!
(1) I had to comment out some code in qa\osl\security\osl_Security.cxx because
it was trying to run a unit test which
failed because I'm not logged in as Administrator.
Perhaps it should skip that te
On 2011-08-31 at 10:57 +0200, Jan Holesovsky wrote:
> Sounds good, pushed that to libreoffice-3-4 branch.
...and mark it [PUSHED]
K.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffi
Hi Caolán,
On 2011-08-26 at 10:48 +0100, Caolán McNamara wrote:
> potential cherry-pick candidate for 3-4
> "Missing user-defined dictionaries with a specified language attribute
> via "Spelling and Grammar" "
> https://bugs.freedesktop.org/show_bug.cgi?id=36678
>
> http://cgit.freedesktop.org/l
Hello Jesse,
- Git version of cppcheck : OK
- LO sources updated : OK
- only core repository scanned : OK
It's perfect ! Thank you !
Julien.
--
View this message in context:
http://nabble.documentfoundation.org/http-libreoffice-boldandbusted-com-cppcheck-report-jobs-stalled-tp2745270p3297801.h
> Are there up-to-date instructions somewhere for building on Windows with the
> new OneGit repos?
Well, the aspects that changed with the switch from several git repos to just
one (or two, or three, depending on whether you want to include help and
dictionaries or not) don't differ between pla
Di Dmitry
On 2011-08-23 at 13:23 +0400, Dmitry. A. Ashkadov wrote:
> For example, there is small bug corresponding to this problem. See
> function «ImplDrawDropdownArrow» in «toolbox.cxx» («vcl» module).
> A lines
> long x = rDropDownRect.Left() + (rDropDownRect.getWidth() -
> width)/2;
>
Hi Michael,
It already happened two times that an accidental git push --tags or git
push --all tried to re-introduce the _ tags in
core.git. Given that generates huge emails, which end up in the mailbox
of Kendy, we talked on IRC it's better to reject those from the git
hook.
Could you please app
Hi all,
Finally we have a tinderbox that is producing Windows daily builds of
master again:
http://dev-builds.libreoffice.org/daily/Windows_XP_SP3/master/
Unfortunately it is quite a slow machine, so it is configured to provide
English-only builds, but I hope even that is help for QA :-)
Please
57 matches
Mail list logo
