Re: [Libreoffice] Reviewing EasyHacks

2011-08-05 Thread Gerald Leppert
Hi Christoph, thanks for your ideas to improve the EasyHacks system. Below you find some additional thoughts. [...] However, the question was if additional (whiteboard) tags like "UxSimplyGo" or "UxGetAdvice" might help. These tags could be added in QA bug hunting sessions, or by a regular revi

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Gerald Leppert
Hi Friedrich, hi all, thanks for your reply and comments. [...] If not, You are member of a big group of people *assuming* a bug to be an "easy bug". I understand every software engineer to be not amused beeing faced that assumption beeing estimated as a fact. You are right, it is an assumption.

[Libreoffice] [REVIEW] fix for fdo#39792: local range names are only written to the file if changes were made to the sheet

2011-08-05 Thread Markus Mohrhard
Hello, this patch invalidates the input stream if we set the local range name. Otherwise the changes to range names only get saved if we have some other action that invalidated the stream. This patch only applies to the 3-4 branch. Regards, Markus From 34092f9760ddcf141be5029b958d66166b63851b Mo

[Libreoffice] [REVIEW] proposing for 3-4: fdo#39869 Fix memory exhaustion

2011-08-05 Thread Eike Rathke
Hi, Proposing to cherry-pick to 3-4: fdo#39869 Fix memory exhaustion https://bugs.freedesktop.org/show_bug.cgi?id=39869 http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=651568afad1a585c485384ab6d7b65780fb02256 Actually the bug may occur with any cell content of STRLEN_MAX (64k) charac

[Libreoffice] [PUSHED] Re: [PATCH] Fix field values in export to docx

2011-08-05 Thread Jan Holesovsky
Hi Troy, Lubos, Lubos Lunak píše v Pá 29. 07. 2011 v 19:52 +0200: > > > > +sExpand.SearchAndReplaceAll( 0x0A, 0x0B ); > > > > > > This line looks strange. What is the reason for this? > > > > You'll find the same pattern in the binary .doc import/export. Newlines > > embedded in fields a

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Friedrich Strohmaier
Hi Gerald, *, first of all: I'm not a software developer! @all: sorry for double posting on ux-advice. Missed to hit "reply to all", which I usually don't on mailinglists. I think there is a misunderstanding here.. Am 05.08.2011 22:51 schrieb Gerald Leppert: > Hi Kohei, [..] > Thanks for maki

[Libreoffice] Problem with embedded images

2011-08-05 Thread tka0330
Hello everyone. I'm not sure that this is the best place, but I would describe an annoying problem that seems to be a bug. I'm editing a file with a few drawings. After a few sessions, it appears that the file is corrupted and the Libre Office crashes (so does Open Office too). To see what was hap

[Libreoffice] Reviewing EasyHacks (was: Re: [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167)

2011-08-05 Thread Christoph Noack
Hi Jenei! Am Freitag, den 05.08.2011, 22:37 +0200 schrieb Jenei Gábor: > And to avoid the further misunderstandings I recommend to > review all the easyhacks before publishing. I'd like to hijack this thread a bit, since you address something important (to me). So, adding Björn and Rainer to th

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Christoph Noack
Hi Gerald, Kohei, Jenei ... all :-) Disclaimer: My hybrid PDF stuff in LibO seems a bit broken, so some things can't be tested ... please point out things that work already. Am Freitag, den 05.08.2011, 15:22 -0400 schrieb Kohei Yoshida: [...] > I'll leave the specific enhancement request discussi

Re: [Libreoffice] Implementing new symbols in charts

2011-08-05 Thread Kohei Yoshida
Hi Regina, On Fri, 2011-08-05 at 16:22 +0200, Regina Henschel wrote: > Do you agree with my decision? Let me make sure I understand your question correctly. You are asking whether it's okay to keep the bounding box of all symbol types square, even for those horizontal and vertical bars that are

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Gerald Leppert
Hi Kohei, thanks for your reply. I am looking forward to the fruitful discussion regarding bugs 39167 / 39168 / 39169 on the UX mailing list. Thanks for making me understand the matured objectives of the EasyHacks-system. Although I do not share your rough statements about "mis-using", "inje

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Jenei Gábor
Hello Yoshida, Should the patch for the second version of the problem postponed? I am almost done with a patch that could do the job for extensions, I only have the problem that I have already mentioned yesterday. So, should I concentrate on another topic? Thanks: Gabor 2011. 08. 05. 21:22

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Jenei Gábor
To be honest before I started minding with this problem I even didn't know what a HybridPDF could be, so probably it would be great to have some changes on this. And the most of Windows users who I know hate this function of windows, and it's among the first options that is turned of( even for

[Libreoffice] [PATCH] fix for fdo#39678: don't write table:protection-key-digest-algorithm to odf 1.1 or odf 1.0

2011-08-05 Thread Markus Mohrhard
Hello, this patch should ensure that we write the password algorithm only to odf 1.2 and later files. I'm not quite sure how important it is to be 100% standard compliant so I don't know if we should include it into 3-4. Regards, Markus From 0bdea28c21531d6d09858e926915e325dd70212c Mon Sep 17 00

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Kohei Yoshida
Hi Gerald, First of all, thanks for introducing yourself on this list. I've been personally wondering who you were since you've filed several EasyHack bugs and I never saw your name or your email address here before. I'll leave the specific enhancement request discussion to the UX folks, but let

[Libreoffice] Windows SUSE LO-3.4 build for Yi Fan

2011-08-05 Thread Petr Mladek
Hi Fridrich, could you please provide a SUSE Windows build from the suse-3.4 branch and make it available for Yi Fan? We do not want to use the "build" repo. I have just committed few more patches from the "build" repo into the suse-3.4 branch on tim. Feel free to commit some more patches that ar

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Joop Kiefte
I agree with Gerald, and want to add that in Windows (where the problem of hidden extensions plays) the difference is very clear because of the icons. .odt.pdf files normally should have an icon of acrobat or other pdf-software. In the case you link .odt.pdf specifically with LibreOffice this is no

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Gerald Leppert
Hi all, I am using this opportunity to introduce myself. My name is Gerald and I am working at the University of Cologne in Germany in social sciences and economics. I have been intensively using LibreOffice (since 1995 in its first incarnation as StarOffice) and I closely followed its develo

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Thorsten Behrens
Astron wrote: > While I can understand the intention of the bug, to me the proposed > solution sounds like bad English. I am also unsure if the change > proposed expresses the option properly (and if this option can be > explained properly in three words). > I think a better solution would be to ke

Re: [Libreoffice] [PATCH] compiling libreoffice-3-4 sal module with dbglevel=2: init test fails

2011-08-05 Thread Caolán McNamara
On Thu, 2011-08-04 at 12:07 +0200, Lionel Elie Mamane wrote: > A two-day-old clone of branch libreoffice-3-4 fails to build module > sal with dblevel=2, unittest fails: osl_old_test_file.cxx assertion > "#failure 1.1": the failure is that blah/a/.. is not transformed to > "blah", but stays "blah/a/

Re: [Libreoffice] curiosity in OResultSet.cxx

2011-08-05 Thread Caolán McNamara
On Fri, 2011-07-29 at 17:00 +0100, Caolán McNamara wrote: > On Fri, 2011-07-29 at 11:21 -0400, Terrence Enger wrote: > > libs-core/connectivity/source/drivers/odbcbase/OResultSet.cxx > > has a line which raises my suspicions. > > > Is the scalar delete really intended? If so, it might be > > wort

[Libreoffice] [PUSHED] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 16:47 +0200, Lionel Elie Mamane wrote: > I generated it against libreoffice-3-4, but it should apply cleanly > against master, too. Looks sane to me, pushed. Confirm patch is under LGPLv3+/MPL1.1 ?, can do a blanket "all my patches" thing if you wish, sort of common to do th

Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Lionel Elie Mamane
On Fri, Aug 05, 2011 at 03:22:35PM +0100, Caolán McNamara wrote: > On Fri, 2011-08-05 at 16:13 +0200, Lionel Elie Mamane wrote: >> In libreoffice-3-4, file svtools/inc/svtools/fileview.hxx: >> #define FILEVIEW_SHOW_TITLE 0x0010 >> #define FILEVIEW_SHOW_SIZE

Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 16:33 +0200, Markus Mohrhard wrote: > > > 2011/8/5 Caolán McNamara > On Fri, 2011-08-05 at 16:13 +0200, Lionel Elie Mamane wrote: > > In libreoffice-3-4, file svtools/inc/svtools/fileview.hxx: > > > > #define FILEVIEW_SHOW_TITLE

Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Lionel Elie Mamane
On Fri, Aug 05, 2011 at 04:33:53PM +0200, Markus Mohrhard wrote: > 2011/8/5 Caolán McNamara >> On Fri, 2011-08-05 at 16:13 +0200, Lionel Elie Mamane wrote: >>> In libreoffice-3-4, file svtools/inc/svtools/fileview.hxx: >>> #define FILEVIEW_SHOW_TITLE 0x0010 >>> #define FILEVI

Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Markus Mohrhard
2011/8/5 Caolán McNamara > On Fri, 2011-08-05 at 16:13 +0200, Lionel Elie Mamane wrote: > > In libreoffice-3-4, file svtools/inc/svtools/fileview.hxx: > > > > #define FILEVIEW_SHOW_TITLE 0x0010 > > #define FILEVIEW_SHOW_SIZE 0x0020 > > #define FILEVIEW_SHO

Re: [Libreoffice] OneGit migration. Review needed of clean_spaces tool

2011-08-05 Thread Jan Holesovsky
Hi Norbert, On 2011-05-31 at 21:58 -0500, Norbert Thiebaud wrote: > So, I call for as many pair of eyes as possible to make sure that the > code of clean_spaces is sane. So I tested the most recent version of the tooling as much as possible, and I think we are ready to go :-) http://cgit.freede

[Libreoffice] Implementing new symbols in charts

2011-08-05 Thread Regina Henschel
Hi all, I have got a prototype implementation of the new symbols now, that works for me. But it contains a decision for which I want to know your opinion before I work further on it. The current standard symbols are all based on a square. Changing of width or height in the data series or dat

Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 16:13 +0200, Lionel Elie Mamane wrote: > In libreoffice-3-4, file svtools/inc/svtools/fileview.hxx: > > #define FILEVIEW_SHOW_TITLE 0x0010 > #define FILEVIEW_SHOW_SIZE 0x0020 > #define FILEVIEW_SHOW_DATE 0x0040 > #

Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Lionel Elie Mamane
On Fri, Aug 05, 2011 at 02:44:09PM +0100, Caolán McNamara wrote: > On Fri, 2011-08-05 at 00:51 +0200, Lionel Elie Mamane wrote: >> The attached patch solves the error message >> Error: HeaderBar::InsertItem(): ItemId already exists >> that a debug build gives when opening the "Open File" dialog.

[Libreoffice] build error unders Windows 7

2011-08-05 Thread Noel Grandin
Hi I'm getting the following build error under Windows7. I'm running the bash shell with Administrator privileges, so it has enough privileges. Is there something else I need to do, or is there a way to bypass this problem? Thanks, Noel Grandin.

Re: [Libreoffice] LO Custom properties

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 15:39 +0530, swagat sharma wrote: > when i made the build and checked for the problem it was gone. > Can anyone also check for the same? In 3.3.2 if I insert a custom property, save to .doc and reopen it then it appears. If I do the same in master it works, so yes, looks fixe

Re: [Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 00:51 +0200, Lionel Elie Mamane wrote: > The attached patch solves the error message > Error: HeaderBar::InsertItem(): ItemId already exists > that a debug build gives when opening the "Open File" dialog. Hmm, patch doesn't apply. Against what version did you create this ?,

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Kohei Yoshida
On Fri, 2011-08-05 at 14:48 +0200, Andras Timar wrote: > Hi, > > 2011/8/4 Astron : > > > > I am also not too keen on the ".pdf" file extension being changed to > > ".odf.pdf"—there will be enough users who still have the "hide known > > file extensions" option of Windows on and thus will only see

[Libreoffice] LO-3.4.2 SUSE build testing

2011-08-05 Thread Petr Mladek
Hi Yi Fan, the first LO-3.4.2 package for SLED11-SP1, openSUSE-11.1, 11.2, 11.3, and 11.4 are available at http://download.opensuse.org/repositories/LibreOffice:/Unstable/ I hope that the packages for Factory will be ready later today. Note that the repositories include also many obsolete LO-3.3

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

2011-08-05 Thread Andras Timar
Hi, 2011/8/4 Astron : > > I am also not too keen on the ".pdf" file extension being changed to > ".odf.pdf"—there will be enough users who still have the "hide known > file extensions" option of Windows on and thus will only see ".odf". > Additionally, two file extensions look awful. > The general

Re: [Libreoffice] [PUSHED][REVIEW] proposing for 3-4: fix fdo#38956 [RED] and other number format prefixes lost

2011-08-05 Thread Eike Rathke
Hi Caolán, On Friday, 2011-08-05 12:20:39 +0100, Caolán McNamara wrote: > SkipNumberFormatterInStream is declared but not defined or used. Indeed, oversight in merge, removed that. Eike -- PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication. Key ID: 0x293C05FD - 997A 4

Re: [Libreoffice] libreoffice 3.4.2.3

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 12:09 +0200, Jesús J. Guerrero Botella wrote: > checking for sane/sane.h... no > configure: error: sane not found. install sane > > So, is it possible to build libreoffice 3.4.2.3 without installing sane? ./configure --help|grep sane --with-system-sane-header so try --witho

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 10:04 +0530, Marc-André Laverdière wrote: > Hi Eike, Caolan, * > > I recall that some exploits in the past have been done by linking to a > symbol that wasn't hidden but should've... in other words the attackers > bypassed the method/function with the argument validity checks

[Libreoffice] [PUSHED][REVIEW] proposing for 3-4: fix fdo#38956 [RED] and other number format prefixes lost

2011-08-05 Thread Caolán McNamara
On Fri, 2011-08-05 at 12:51 +0200, Eike Rathke wrote: > Hi, > > Please review and cherry-pick for 3-4 a fix for > https://bugs.freedesktop.org/show_bug.cgi?id=38956 > > http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=fbe916fd7dc7ba22b8652bc0c5b8a0d9cb15cc9d SkipNumberFormatterInStrea

Re: [Libreoffice] [PATCH] add missing quotes to bashscript allowing space in variables

2011-08-05 Thread Tomáš Chvátal
Dne 4.8.2011 22:06, Philipp Weissenbacher napsal(a): Hi! You probably forgot to attach your patch ;-). Philipp On Tuesday, 2 August 2011, Tomas Chvatal wrote: Yep, you are right, I sent it off this thread so it is best to reattach again :) Cheers Tom >From 7d855f87054340bf83f822d4ec10222a

[Libreoffice] [REVIEW] proposing for 3-4: fix fdo#38956 [RED] and other number format prefixes lost

2011-08-05 Thread Eike Rathke
Hi, Please review and cherry-pick for 3-4 a fix for https://bugs.freedesktop.org/show_bug.cgi?id=38956 http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=fbe916fd7dc7ba22b8652bc0c5b8a0d9cb15cc9d http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=513e2e78a9bb0861064f73c17000afd7

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-08-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 38956, which changed state. Bug 38956 Summary: FORMATTING: Negative Currency Numbers Don't Show Red and other number format prefixes are lost https://bugs.freedesktop.org/show_bug.cgi?id=38956 What|Old Va

Re: [Libreoffice] problems in number format dialog

2011-08-05 Thread Eike Rathke
Hi Samphan, On Monday, 2011-08-01 18:29:49 +0200, Eike Rathke wrote: > On Monday, 2011-08-01 11:54:31 +0700, Samphan Raruenrom wrote: > > We're reading this discussion and patches. > Great, could you please apply the attached patches and check if that > suits the needs of the Thai community? As

[Libreoffice] [ANN] download site: change in source tarball directory structure

2011-08-05 Thread Thorsten Behrens
Hi *, starting with the imminent publication of 3.3.4, we change the structure of the source tarballs slightly - that's because, with several released versions out there, having it all in one single directory became a bit unwieldy. New structure will look like this: http://download.documentfound

Re: [Libreoffice] LO Custom properties

2011-08-05 Thread swagat sharma
Hi Michael, Glad to come across the fact that Custom Properties issue is solved in the code I git cloned on 26th july. I was having build issues since then, but finally when i made the build and checked for the problem it was gone. Can anyone also check for the same? If it is solved, we can chan

[Libreoffice] libreoffice 3.4.2.3

2011-08-05 Thread Jesús J . Guerrero Botella
Hello. I am a Gentoo user and I just subscribed to this list. Today libreoffice 3.4.2.3 was added to portage and sane-backends appeared as a new dependency. From my research I guessed that this is controlled via the --with-system-sane configure flag, but I tried adding --without-system-sane to the

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-05 Thread Eike Rathke
Hi Marc-André, On Friday, 2011-08-05 10:04:14 +0530, Marc-André Laverdière wrote: > I recall that some exploits in the past have been done by linking to a > symbol that wasn't hidden but should've... in other words the attackers > bypassed the method/function with the argument validity checks. N

Re: [Libreoffice] User directory

2011-08-05 Thread Korrawit Pruegsanusak
Hello Dmitry, On Fri, Aug 5, 2011 at 14:53, Dmitry A. Ashkadov wrote: > I built LibreOffice using «make dev-install» command. LibreOffice creates > «~/.libreoffice/3» directory at startup.  This may cause problem with my > LibreOffice installed from repository. How can I change direcory? Maybe t

[Libreoffice] [PATCH] configure help text incorrect: --with-system-sane(-header)

2011-08-05 Thread Lionel Elie Mamane
Hi, The bootstrap configure help text claims it supports --with-system-sane-header, but when passed this option it says "warning: unrecognized option --with-system-sane-header". The option actually implemented is called --with-system-sane. The attached patch puts the help text in line with the imp

[Libreoffice] [PATCH] mysqlc chicken-and-egg bootstrap

2011-08-05 Thread Lionel Elie Mamane
Hi, When doing a fresh bootstrap clone and ./autogen.sh '--enable-ext-mysql-connector' '--with-system-mysql' configure complains that the directory "mysqlc" does not exist and errors out. But that directory will be created by "make fetch" _after_ configure is finished running, so I'd suggest the

Re: [Libreoffice] [REPUSHED][PATCH] Fix building bridge with -mavx

2011-08-05 Thread Tomas Chvatal
Thanks I wrote the check so it actually checked if the cpu supports the -mavx rather than just check if -mno-avx makes it fail. Not that it would matter anyway, since loo doesn't have any --enable-avx switch or something. Tom ___ LibreOffice mailing l

[Libreoffice] User directory

2011-08-05 Thread Dmitry A. Ashkadov
Hello! I built LibreOffice using «make dev-install» command. LibreOffice creates «~/.libreoffice/3» directory at startup. This may cause problem with my LibreOffice installed from repository. How can I change direcory? -- Best regards, Dmitry <>__

Re: [Libreoffice] make check fails.

2011-08-05 Thread Bjoern Michaelsen
On Thu, 04 Aug 2011 23:27:45 +0200 Julien Nabet wrote: > com.sun.star.lang.DisposedException: java_remote_bridge This most likely means your soffice instance just crashed away, while executing the test. You should be able to debug the soffice instance with gdb as per: http://sweetshark.livejo

[Libreoffice] SfxItemSet reimplementation (was: va_start without va_end)

2011-08-05 Thread Bjoern Michaelsen
Hi Norbert, all, On Thu, 4 Aug 2011 20:47:43 -0500 Norbert Thiebaud wrote: > The va_end manpage, on linux says: > "Each invocation of va_start() must be matched by a corresponding > invocation of va_end() in the _same function_" > (emphasis is mine) > so it's not just ugly, but also 'wrong'...

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

2011-08-05 Thread Bjoern Michaelsen
On Fri, 5 Aug 2011 01:45:35 +0200 Eike Rathke wrote: > Fortunately those split repos will be gone soon :-) Yes, and I will be celebrating in the streets on that day. ;) On a sidenote: Yes, _set_defs has been replaced by _add_defs by Michael Stahl on gnumake4. Best, Bjoern -- https://launchp