[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on||39799 --- Comment #182 from Rainer Bi

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld changed: What|Removed |Added Depends on||39187 --- Comment #2 from Rainer Biel

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi Eike, Caolan, * I recall that some exploits in the past have been done by linking to a symbol that wasn't hidden but should've... in other words the attackers bypassed the method/function with the argument validity checks. So here's my follow-up question :) Anything in that/those module(s) tha

Re: [Libreoffice] va_start without va_end

On Thu, Aug 4, 2011 at 3:33 AM, Caolán McNamara wrote: > On Wed, 2011-08-03 at 23:56 +0200, Julien Nabet wrote: >> Hello, >> >> In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I >> noticed the use of va_start without va_end. >> I read it could create undefined behaviour, so I propo

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi, On Friday, 2011-08-05 01:12:03 +0200, Eike Rathke wrote: > Now I wonder whether gb_Library_add_defs was introduced newly and not > committed to solenv/gbuild/ or I should change all _add_ to _set_ and > add $$(DEFS) at all places. Mystery solved: working with stgit I forgot to invoke stgit r

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi Bjoern, On Friday, 2011-08-05 00:49:57 +0200, Eike Rathke wrote: > note _SET_defs, so I changed that to > > $(eval $(call gb_Library_set_defs,ucbhelper,\ > $$(DEFS) \ > -DUCBHELPER_DLLIMPLEMENTATION \ > )) > > and that works. Apparently all modules newly converted to gbuild have > th

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

Hi Maciej, On Thursday, 2011-08-04 18:57:11 -0400, Kohei Yoshida wrote: > > If I see any sal_Bool (sal_True, sal_False), should I change it to > > standard bool? > > Absolutely! *But* take at least a cursory look to make sure that it is > really used as a boolean value. sal_Bool is a typedef t

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

On Fri, 2011-08-05 at 00:29 +0200, Maciej Rumianowski wrote: > Dnia 2011-08-04, czw o godzinie 23:23 +0200, Maciej Rumianowski pisze: > > Okay so I will work further on SvULongs, there is some in libs-gui, > > and > > than come back to writer. > > Sorry, I meant libs-core. > > If I see any sal_B

[Libreoffice] [PATCH] DbgAssert error: "HeaderBar::InsertItem(): ItemId already exists"

The attached patch solves the error message Error: HeaderBar::InsertItem(): ItemId already exists that a debug build gives when opening the "Open File" dialog. -- Lionel >From 73979f4ff9afacf16a6ca6044985cfe04752 Mon Sep 17 00:00:00 2001 From: Lionel Elie Mamane Date: Fri, 5 Aug 2011 00:49:

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi Bjoern, On Friday, 2011-08-05 00:02:53 +0200, Bjoern Michaelsen wrote: > UCBHELPER_DLLIMPLEMENTATION is set during the compiles. That seems to be the underlying cause: UCBHELPER_DLLIMPLEMENTATION is _not_ set during compilation, Library_ucbhelper.mk has $(eval $(call gb_Library_add_defs,ucbh

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

Dnia 2011-08-04, czw o godzinie 23:23 +0200, Maciej Rumianowski pisze: > Okay so I will work further on SvULongs, there is some in libs-gui, > and > than come back to writer. Sorry, I meant libs-core. If I see any sal_Bool (sal_True, sal_False), should I change it to standard bool? Best, Ma

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi Bjoern, On Friday, 2011-08-05 00:02:53 +0200, Bjoern Michaelsen wrote: > Well, indeed gnumake should only care about the symbols marked via > UCBHELPER_DLLPUBLIC (from ucbhelper/inc/ucbhelper/ucbhelperdllapi.h) > which should expand to >__attribute__((visibility("default"))) > for linux v

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

On Thu, 4 Aug 2011 21:22:54 +0200 Eike Rathke wrote: > But I was lying when I said before the symbols were there, well, they > are, but local, nm gives 't' instead of 'T'. Apparently the gnumake > transition switched visibility to all-off. Looking at the dmake build > there was ucbhelper.flt used

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673 Caolán McNamara changed: What|Removed |Added Depends on|32899 | -- Configure bugmail: https://bugs.f

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi Caolán, On Thursday, 2011-08-04 21:22:54 +0200, Eike Rathke wrote: > > I don't think moving from dmake to gnumake should affect this. > I think it did.. > > But I was lying when I said before the symbols were there, well, they > are, but local, nm gives 't' instead of 'T'. Apparently the gnum

[Libreoffice] [ANN] LibreOffice 3.3.4 RC1 available

Hi *, for 3.3.4 rc1, we're now uploading builds to a public (but non-mirrored - so don't spread news too widely!) place, as soon as they're available. Grab them here: http://dev-builds.libreoffice.org/pre-releases/ If you've a bit of time, please give them a try & report *critical* bugs not yet

[Libreoffice] make check fails.

Hello, I just had this (I'm certainly not the only one). I'm gonna try to debug but I thought it might interest users who compile with less verbose information. LOG> Execute: removeResetListener() LOG> starting required method: reset() LOG> Testing removeResetListener ... com.sun.star.lang.Dis

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

Dnia 2011-08-04, czw o godzinie 12:09 -0400, Kohei Yoshida pisze: > On Thu, 2011-08-04 at 00:40 +0200, Maciej Rumianowski wrote: > > Ok. The new patch looks good (to me). Pushed to master. Thanks :) > > > > Other than that, the rest looks okay to me. I'd prefer someone more > > > experienced

Re: [Libreoffice] va_start without va_end

Le 04/08/2011 10:33, Caolán McNamara a écrit : On Wed, 2011-08-03 at 23:56 +0200, Julien Nabet wrote: Hello, In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I noticed the use of va_start without va_end. I read it could create undefined behaviour, so I propose this simple patch.

Re: [Libreoffice] [PATCH] add missing quotes to bashscript allowing space in variables

Hi! You probably forgot to attach your patch ;-). Philipp On Tuesday, 2 August 2011, Tomas Chvatal wrote: > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/libreoffice > _

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

Hi Caolán, On Thursday, 2011-08-04 09:19:37 +0100, Caolán McNamara wrote: > I don't think moving from dmake to gnumake should affect this. I think it did.. > I think the gnumake one gets copied out into the old solver hierarchy. > Nevertheless that's what I'd check. See how many libucbhelper4gc

[Libreoffice] [EasyHack] HybridPDF 2. strange problem

Hello, I have the following problem: In the present version we may export PDF by clicking on Export To PDF(or something like this) and Export, choosing PDF format and etc. The main difference between the two methods is the order of showing the dialogs. With the first method there isn't too ma

Re: [Libreoffice] [PATCH] [PUSHED] Easy Hack - Get rid ofSvULongs in writer

Marking it [PUSHED]. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REPUSHED][PATCH] Fix building bridge with -mavx

On Thu, 2011-08-04 at 16:02 +0200, Tomáš Chvátal wrote: > Ok I wrote it how I think it should work and triggered the build so I > will have the results of it in 24 hours. > FWIW I am attaching the final patches for now. Basically pushed now. I think there's some overthinking in configure.in, so I

Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer

On Thu, 2011-08-04 at 00:40 +0200, Maciej Rumianowski wrote: Ok. The new patch looks good (to me). Pushed to master. > > Other than that, the rest looks okay to me. I'd prefer someone more > > experienced in Writer's code to sanity-check though. > > O, so by the way there is in wrtww8.hxx a

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #181 from che...@nd.gov 2011-08-04 08:42:47 PDT --- Nominate Bug 32181 - underlining bleed over margin; This bug makes PDF export unusable for certain documents. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=em

[Libreoffice] [PATCH] Bug 39561 (XHTML export filter)

Hi, Attached is a patch for Bug 39561 "Use svg:title, not svg:desc for XHTML img alt attribute [accessibility]" . I am new to Git and LibreOffice development and generated this patch with "git diff ..." (I couldn't figure out how to use for

Re: [Libreoffice] [Libreoffice-ux-advise] Fwd: [PATCH] Bug 39167

Hi. While I can understand the intention of the bug, to me the proposed solution sounds like bad English. I am also unsure if the change proposed expresses the option properly (and if this option can be explained properly in three words). I think a better solution would be to keep "Create hybrid f

[Libreoffice] Minutes of the tech. steering call

+ Present * Caolan, Christian D., David, Kendy, Kohei, Norbert, Petr, Rainer, Thorsten + Finished Action Items: + make the download of the git tarball more prominent on the download page (Thorsten) + Pending Action Items: + in-progress: review Norbert's

[Libreoffice] [REVIEW] mail-merge fixes for 3-4

http://cgit.freedesktop.org/libreoffice/libs-extern-sys/commit/?id=491dab7d62dc42a13d56fe82cc33c2fb312ee30f http://cgit.freedesktop.org/libreoffice/ure/commit/?id=b9f4c91d97aacc5d311c17e43f5cfe408de572dc http://cgit.freedesktop.org/libreoffice/writer/commit/?id=64842a9788227a5a18241ddfb5f0f679f09a0

[Libreoffice] All Sun/Oracle code upgraded to LGPLv3?

Hi, I'm looking into getting postgresql-sdbc working with newer libreoffice; technically I'm making progress on that front, but the files have headers like: * The Contents of this file are made available subject to the terms of * either of the following licenses * * - GNU Lesser Gen

Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx

2011/8/4 Tomáš Chvátal : > Dne 3.8.2011 18:41, Norbert Thiebaud napsal(a): >> >> Ok so now I read the patch... >> >> Did it work for you ? >> >> 1/ it seems to me that it is missing a piece to put that HAVE_GCC_AVX >> in Env.Host.sh (see set_soenv.in) >> without that the second patch will never see

Re: [Libreoffice] [UNPUSHED][PATCH] Fix building bridge with -mavx

Dne 3.8.2011 18:41, Norbert Thiebaud napsal(a): Ok so now I read the patch... Did it work for you ? 1/ it seems to me that it is missing a piece to put that HAVE_GCC_AVX in Env.Host.sh (see set_soenv.in) without that the second patch will never see it 2/ the makefile patches in the second patc

[Libreoffice] Fwd: [PATCH] Bug 39167

Forwarding this to the ux team - since the patch is mostly on UI changes - which I don't know how to review. It would be great if somebody more experienced in this area can review this. Thanks! [PS: The patch is attached in the bugzilla] Date: Fri, 29 Jul 20

Re: [Libreoffice] [GSOC][patch] Multiline inputbar

Hi Anurag, I pushed your patch to the feature branch. I think I noticed is that your commit name is all caps ANURAG JAIN. Could you fix that to properly capped name for your future patches? On Thu, 2011-08-04 at 13:43 +0530, Anurag Jain wrote: > I'll implement these things after returning from

[Libreoffice] [PUSHED] windows dependency tool and GenCxxObjects

On Thu, 2011-08-04 at 14:14 +0200, Bjoern Michaelsen wrote: > On Thu, 04 Aug 2011 11:46:08 +0100 > Caolán McNamara wrote: > > > The attached patch allows me to build build basegfx again anyway under > > windows. Is it right ? > > Looks good to me. Pushed then. C. _

[Libreoffice] [PUSHED] Re: [REVIEW] Fix wrong mimetype in flat ODG export

Done, thanks for your contribution. Looking forward for many more patches :) F. On Thu, 2011-08-04 at 14:07 +0200, Thorsten Behrens wrote: > Hi, > > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=730083a03263e2d78699682736e6ee78650a00b7 > fixes the mimetype written to flat odg fil

Re: [Libreoffice] windows dependency tool and GenCxxObjects

On Thu, 04 Aug 2011 11:46:08 +0100 Caolán McNamara wrote: > The attached patch allows me to build build basegfx again anyway under > windows. Is it right ? Looks good to me. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice

[Libreoffice] [REVIEW] Fix wrong mimetype in flat ODG export

Hi, http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=730083a03263e2d78699682736e6ee78650a00b7 fixes the mimetype written to flat odg files from application/vnd.oasis.opendocument.drawing to the correct application/vnd.oasis.opendocument.graphics. Review & cherry-pick for -3-4 much app

Re: [Libreoffice] Make dev-install without running smoketests

On Wed, 2011-08-03 at 16:51 +0100, Caolán McNamara wrote: > On Wed, 2011-08-03 at 14:49 +0200, Thomas Arnhold wrote: > > > tools->options->security->macro security->low : open > > > libo/smoketestdoc/PLATFORM/bin/smoketestdoc.sxw and click the "run" > > > button. > > > > The error in smoketest is

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37015, which changed state. Bug 37015 Summary: Scripting other than Basic unavailable https://bugs.freedesktop.org/show_bug.cgi?id=37015 What|Old Value |New Value

Re: [Libreoffice] Reporting an error when loading of a component fails

On Wednesday 03 of August 2011, Caolán McNamara wrote: > On Tue, 2011-08-02 at 14:58 +0200, Lubos Lunak wrote: > > - osl_loadModule*() functions are plain C functions from stable API, so > > no overloading to add the extra argument for the error message, the best > > I've come up with was simply a

Re: [Libreoffice] Reporting an error when loading of a component fails

On Wednesday 03 of August 2011, Noel Power wrote: > On 03/08/11 11:08, Noel Power wrote: > > ( /me must remember to reply-all ) Decent mailers have 'Reply-To-List' :). > > hmm I think it would be nicer to handle at least the > > CannotActivateFactoryException problems from the filter instatiatio

[Libreoffice] windows dependency tool and GenCxxObjects

Trying to see why my windows build just loop endlessly in basegfx with unfulfilled dependencies I see that the target in basegfx is a GenCxxObject, now... solenv/gbuild/LinkTarget.mk is... $(call gb_GenCxxObject_get_target,%) : $(call gb_GenCxxObject_get_source,%) $(call gb_CxxObject__c

[Libreoffice] [PUSHED] Re: [PATCH] Add missing libdir path for qt4 detection

On Wednesday 03 of August 2011, Tomáš Chvátal wrote: > 0001-Add-one-more-libdir-path-for-detection-with-qt4-on-3.patch Pushed. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/

[Libreoffice] [PATCH] compiling libreoffice-3-4 sal module with dbglevel=2: init test fails

A two-day-old clone of branch libreoffice-3-4 fails to build module sal with dblevel=2, unittest fails: osl_old_test_file.cxx assertion "#failure 1.1": the failure is that blah/a/.. is not transformed to "blah", but stays "blah/a/.." That's because in my setup symlinks are allowed, and in that set

Re: [Libreoffice] l10n and translations

Hello, 2011/8/4 Dmitry A. Ashkadov : > Hello! > > I don't understand what is a difference between «l10n» and «translations» > repositories. Can You explain me? > l10n is for LibreOffice 3.3.x. translations is for LibreOffice 3.4 and higher. Best regards, Andras __

[Libreoffice] l10n and translations

Hello! I don't understand what is a difference between «l10n» and «translations» repositories. Can You explain me? Thanks! -- Best regards, Dmitry <>___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [Libreoffice] va_start without va_end

On Wed, 2011-08-03 at 23:56 +0200, Julien Nabet wrote: > Hello, > > In svl/source/items/itemset.cxx b/svl/source/items/itemset.cxx, I > noticed the use of va_start without va_end. > I read it could create undefined behaviour, so I propose this simple patch. > ... > +va_end(pArgs); >

Re: [Libreoffice] link error in comhelper with undefined references from ucbhelper

On Thu, 2011-08-04 at 01:40 +0200, Eike Rathke wrote: > I'm currently stuck. Ideas, anyone? I don't think moving from dmake to gnumake should affect this. I think the gnumake one gets copied out into the old solver hierarchy. Nevertheless that's what I'd check. See how many libucbhelper4gcc3.so yo

[Libreoffice] [GSOC][patch] Multiline inputbar

Hello Kohei, I prepared the patch and then realized that you have pushed the recalculating change, it was taking longer to pull because of some problem. Also wanted to inform that I've to leave for college as I've got convocation on 6th Aug. I'll be back on 7th evening and finish things up. Also

Re: [Libreoffice] Make dev-install without running smoketests

On 08/03/2011 05:51 PM, Caolán McNamara wrote: What are your configure options for me to see if I can replicate this ? Looks like evilness which should be fixed. ./autogen.sh --enable-python=internal \ --enable-debug --enable-dbgutil \ --without-junit --without-java \ --with-num-cpus=2 --with-m