Re: [Libreoffice] Litmus testcase structure improvement.

TODO List I could think: 1. Litmus issue of test case manager access control (Thanks for Rimas is working on that) 2. We need to find some place to store test samples attachment of test cases (Need help, didn't follow up yet, maybe in git testing repo)? 3. In DE testgroup, th

Re: [Libreoffice] [PATCH] fix for fdo#32421: set indent for footnotes / endnotes to 0.6cm

Hi Tor, Am 22.06.2011 07:00, schrieb Tor Lillqvist: Patch is attached. It is just setting the indent for Footnote / Endnote styles to 0.6cm (previously 0.5cm). It has not big effect to footnotes <=99 but makes them prettier for numbers>=100. I guess actually fixing it so that the (automatic?)

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

> Attached patch is a fix for fdo#30550 in comment 11-12 Thanks, committed and pushed to 3-3. (With a slightly improved commit message.) --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

[Libreoffice] Litmus testcase structure improvement.

Hi all, Referring to the attached discussion thread initialed by Jean-Baptiste (great thanks!), we are trying to make testcase management tool Litmus (https://tcm.documentfoundation.org/run_tests.cgi) better managed and organized. The following explained all current states. As usual, comments are

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Attached is another patch (in libs-gui repo) that is in 3.4 but not in 3.3 found with lo-commit-stat using: /bin $>perl lo-commit-stat --log-dir='./' --log-suffix='mjWCRL-3.3' --rev-list ../ --until='2010-12-01' --author='Johnsson' origin/libreoffice-3-4 ^origin/libreoffice-3-3 and shown more di

Re: [Libreoffice] [PATCH] fix for fdo#32421: set indent for footnotes / endnotes to 0.6cm

> Patch is attached. It is just setting the indent for Footnote / Endnote > styles to 0.6cm (previously 0.5cm). It has not big effect to footnotes > <=99 but makes them prettier for numbers >=100. I guess actually fixing it so that the (automatic?) indentation depends on the number of footnotes i

Re: [Libreoffice] crash in escherex.cxx in master

Not surprisingly, this was apparently once again the result of a List -> std::vector replacement. From June 16. So it seems "we" aren't getting any better in doing these. I really don't see any way to solve this except to go through all commits that do such "cleanups" and figure out how to actu

Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar

Hi Noel, Actually the problem started from not doing a git pull on my end after Kohei pushing my patch (created using git diff) as I went on making changes. In order to resolve this I ran git stash; git pull; and then git stash pop; And I made some more changes and sent you the same patch generate

Re: [Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hi Korrawit, Cedric, all ... A first, quick reply is that this patch of mine contains the dread redline wipeout: + // make a copy of the text + String& rTextCopy = const_cast(m_Text); The latter needs to be modified to include (or be immediately followed by) Cedric's fix: - String& rTe

Re: [Libreoffice] No Edit entry in context menu of a chart: bug or intentional ?

Hi Jean-Babtiste, Jean-Baptiste Faure schrieb: Hi all, In LibO 3.4.1 rc1 the context menu of a chart inserted in a speadsheet does not show the menu entry Edit as it does in LibO 3.3.x. In addition, the menu Edit> Object is grayed when you select a chart. It is worse. Same error with Math OL

Re: [Libreoffice] crash in escherex.cxx in master

Ok I looked into the corresponding gcc stl function and it seems that the debug function checks if the iterator is incrementable. I haven't checked the macro that performs this check but the iterator might be marked as invalid after an element has been erased. So this crash will only happen during

Re: [Libreoffice] Debug compilation fails in sal module

Le 20/06/2011 21:42, Julien Nabet a écrit : Le 20/06/2011 21:32, Julien Nabet a écrit : Le 20/06/2011 15:19, Caolán McNamara a écrit : On Mon, 2011-06-20 at 10:08 +0100, serv serva wrote: It happens each time. I don't know what element has triggered this. I tried gdb but when I runned it, it m

[Libreoffice] [GSOC] Weekly Report #4

Hello, I'd like to share with you a video i've just recorded where you can see how my work is going. http://www.youtube.com/watch?v=IfHA6gjVsIA There're still 2 issues that don't work properly. - Logo, Date and Subject Line work wierdly because they don't hide the component: As you can see on the

Re: [Libreoffice] crash in escherex.cxx in master

On 21/06/11 18:52, Markus Mohrhard wrote: I did a debug build. And I had some stl debug symbols in my backtrace so it might be that perhaps the compiler won't optimize this out. I attached the backtrace. print it shows: it = {<__gnu_debug::_Safe_iterator_base> = {_M_sequence = 0x29e3678, _M_v

Re: [Libreoffice] [GSoC 2011][svgexport] weekly report #3

On Fri, 17 Jun 2011 15:28:32 +0200, Jan Holesovsky wrote: Hi Marco, Hi Kendy, Marco píše v Po 13. 06. 2011 v 00:33 +0200: == 1 == Any svg document created by exporting an Impress presentation is navigable through the mouse and the keyboard. == 2 == It is possible to export any subset of

[Libreoffice] [GSoC 2011][svgexport] weekly report #4

Hi all, first off, sorry for the late report but I was very busy in completing some new feature. I hope they worth the long wait. So, what's new ? == 1 == Extended presentation navigability: now you have several way to switch forward and backward from a slide. Moreover by pressing down the Home

[Libreoffice] No Edit entry in context menu of a chart: bug or intentional ?

Hi all, In LibO 3.4.1 rc1 the context menu of a chart inserted in a speadsheet does not show the menu entry Edit as it does in LibO 3.3.x. In addition, the menu Edit > Object is grayed when you select a chart. My question is: these menu entries have been removed intentionally or is it a bug? If i

Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar

Hi Anurag On 21/06/11 18:59, Anurag Jain wrote: Hi Noel, Please review the patch I'm sending here. I did not have luck getting the control shown up. Please guide me what I'm missing ? Thanks and regards Sorry I think you need to redo the patch, it doesn't apply for me ( or at least the hunks t

Re: [Libreoffice] Couldn't debug fdo#30550 (WAS: Build failed in sfx2 in -3-3 branch)

Korrawit Pruegsanusak píše v Po 20. 06. 2011 v 23:52 +0700: > Hello Petr, Michael, * > How do I know that libegg module is built and delivered? You should see solver/330/unxlng?6.pro/inc/eggtray/eggtrayicon.h The delivered files are described in libegg/prj/d.lst. They are delivered from libegg/ to

Re: [Libreoffice] [PATCH] Additional fix for bug fdo#33781

Roland Baudin píše v Út 21. 06. 2011 v 09:26 +0200: > Hi Petr, > > I've tested your patch with my test docs and for me it's OK. > I've just noticed a small issue when inserting a chart in Calc : when > switching out from edit mode, the top line of the graphic becomes blurred. > I attach a test fi

[Libreoffice] new build breaker in configure/set_soenv

New build breaker here in ArchLinux: my i686 build in a chroot breaks while native pkg build x86_64 went fine: setting up the build environment variables... checking solver path... default setting up the post_download check script configure: creating ./config.status config.status: creating ooo.lst

[Libreoffice] [GSOC][PATCH] Multiline inputbar

Hi Noel, Please review the patch I'm sending here. I did not have luck getting the control shown up. Please guide me what I'm missing ? Thanks and regards -- Anurag Jain Final yr B.Tech CSE SASTRA University Thanjavur(T.N.)-613402 diff --cc sc/source/ui/app/inputwin.cxx index 0fed037,edffb0a..00

[Libreoffice] [PATCH] Fix for fdo#30550 Character count without spaces

Hello all, Attached patch is a fix for fdo#30550 in comment 11-12 This is specific to -3-3 only, because it was later fixed in -3-4 and master by http://cgit.freedesktop.org/libreoffice/writer/commit/?id=335534df4946437a12cd3c18b4a24beee188317b by John LeMoyne Castle, but not in -3-3. So, it woul

Re: [Libreoffice] crash in escherex.cxx in master

I did a debug build. And I had some stl debug symbols in my backtrace so it might be that perhaps the compiler won't optimize this out. I attached the backtrace. print it shows: it = {<__gnu_debug::_Safe_iterator_base> = {_M_sequence = 0x29e3678, _M_version = 0, _M_prior = 0x0, _M_next = 0x0}, _M

Re: [Libreoffice] Gettext patch

On Tue, 21 Jun 2011 17:39:50 +0100 Michael Meeks wrote: > textdomain sets some sort of global variable (last I looked) > which subsequent gettext calls then work from. That shouldn't work > well in LibreOffice's case where we need to multiplex lots of > catalogs at speed; I strongly recomme

Re: [Libreoffice] crash in escherex.cxx in master

On 21/06/11 15:17, Markus Mohrhard wrote: Hello Noel, all, I have attached a test document and a diff. I don't understand why this still crashs calc even if there is nothing anymore that can create any problems. well it doesn't crash for me ( even worse it doesn't crash without the patch eith

Re: [Libreoffice] Couldn't debug fdo#30550 (WAS: Build failed in sfx2 in -3-3 branch)

Hello Caolán, all, On Tue, Jun 21, 2011 at 15:24, Caolán McNamara wrote: > If you were setting breakpoints by symbolname, then set breakpoints by > sourcefile:linenumber instead, that's a lot more reliable. It works! Many thanks for your answer. Best Regards, -- Korrawit Pruegsanusak ___

Re: [Libreoffice] What does --disable-vba disable?

Hi On 21/06/11 14:34, Andor E wrote: Hi, I'm building my own version of OOo 3.2.1 and I'm wondering what the --disable-vba switch is disabling in detail. disables build of the vba compatibility api shared library ( but not iirc the idl & type libraries ) The Basic function CreateObject no lon

Re: [Libreoffice] Gettext patch

On Tue, 2011-06-21 at 13:13 +0200, Andras Timar wrote: > >Instead of calling textdomain - since (I suspect) we can probably > > call > > lots of these resource mgrs in quick succession - eg. initializing an > > sw/ widget derived from sfx2/ from vcl/ - I suggest we drop the > > textdomain

[Libreoffice] [PATCH] fix for fdo#32421: set indent for footnotes / endnotes to 0.6cm

Hi, as I was trying to get an idea how (and where) the "internal" writer styles are implemented. So I found fdo#32421 a really easy hack :) Patch is attached. It is just setting the indent for Footnote / Endnote styles to 0.6cm (previously 0.5cm). It has not big effect to footnotes <=99 but make

[Libreoffice] [ANNOUNCE] libreoffice-3.4.1.2 tag created (3.4.1-rc2)

Hi, there have been created the libreoffice-3.4.1.2 tag for 3.4.1-rc2 release. The corresponding official builds will be available by the end of the week. If no blocker is found, it will be marked as final the following week. See the attached list of changes against 3.4.1-rc1. You might switch y

[Libreoffice] crash in escherex.cxx in master

Hello Noel, all, I have attached a test document and a diff. I don't understand why this still crashs calc even if there is nothing anymore that can create any problems. How to reproduce: open test document in calc fix formula: =#NAME to =a save with button in the toolbar Regards, Markus xlsx

[Libreoffice] What does --disable-vba disable?

Hi, I'm building my own version of OOo 3.2.1 and I'm wondering what the --disable-vba switch is disabling in detail. The Basic function CreateObject no longer works. Is CreateObject part of the VBA-compatibility package? With regards eymux ___ LibreOffi

Re: [Libreoffice] [REVIEW] [PUSHED:3-4] patch for fdo#31353

> This is low-risk patch which fixes a wrong dialog title (the string > for that was already there but was not used). Can you push it to 3-4? Cherry-picked, thanks. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freed

[Libreoffice] [REVIEW] patch for fdo#31353

Hi, http://cgit.freedesktop.org/libreoffice/components/commit/?id=8a7592cc36019d6d6d81e1a53dd2785213368591 This is low-risk patch which fixes a wrong dialog title (the string for that was already there but was not used). Can you push it to 3-4? Thanks, Andras

Re: [Libreoffice] Gettext patch

Hi Michael, 2011/6/21 Michael Meeks : > On Tue, 2011-06-21 at 11:43 +0200, Andras Timar wrote: >> +    OSL_TRACE( "bindtextdomain(): %s -> %s\n", pPrefixName, p ); >> +    textdomain( pPrefixName ); > >        Instead of calling textdomain - since (I suspect) we can probably call > lots of these r

Re: [Libreoffice] Gettext patch

> I wonder if we want to introduce gettext as an internal / > self-built & packaged dependency on Windows - We (or "they") already do this, the librsvg stack dragged in for example gettext, which gets built on Windows. (Although when using the bundled librsvg stack, that is just a silly depende

Re: [Libreoffice] Gettext patch

Hi Andras, On Tue, 2011-06-21 at 11:43 +0200, Andras Timar wrote: > +OSL_TRACE( "bindtextdomain(): %s -> %s\n", pPrefixName, p ); > +textdomain( pPrefixName ); Instead of calling textdomain - since (I suspect) we can probably call lots of these resource mgrs in quick succession -

Re: [Libreoffice] Gettext patch

2011/6/21 Caolán McNamara : > On Tue, 2011-06-21 at 11:43 +0200, Andras Timar wrote: >> +    setlocale(LC_ALL, ""); > > Is there a way to tell gettext what language you want, without tweaking > setlocale ? > AFAIK LANGUAGE environment variable can be used, and can be selected according to the langu

Re: [Libreoffice] Gettext patch

On Tue, 2011-06-21 at 11:43 +0200, Andras Timar wrote: > +setlocale(LC_ALL, ""); Is there a way to tell gettext what language you want, without tweaking setlocale ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.free

Re: [Libreoffice] Gettext patch

Hi, 2011/6/15 Bjoern Michaelsen : >> I would like to work on "gettextizaton" of LibreOffice. Michael said >> you had an initial patch. Can you share it with me? > > No, I have no patch, I just collected some starting points and design > considerations. You find those here: > > http://wiki.document

Re: [Libreoffice] [REVIEW] [REVIEWED] fix for fdo#38380: local range names must be updated too

I obviously don't know the code in question, but your patch looks sane, and I of course trust you that it compiles and does what you say, so go ahead and commit to master. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://li

Re: [Libreoffice] [GSOC][Report] MultiLine InputBar

On 20/06/11 10:18, Noel Power wrote: hmm, I just built your feature branch on Friday and tried to get my head around the task ( and it is still a little unfamiliar to me ), I am sure though I could help though with your latest problem when I have a patch with your latest work :-) I hope you so

[Libreoffice] [REVIEW] fix for fdo#38380: local range names must be updated too

Hello, here is my next patch for problems around local range names. We need to update local range names like global range names. This patch only fixes some part of it, but updating when the sheet number changes need some more rework for fdo#38204 first. We do a similar update for global range nam

Re: [Libreoffice] Debug compilation fails in sal module

On Mon, 2011-06-20 at 21:42 +0200, Julien Nabet wrote: > I used "export DEBUGCPPUNIT=TRUE" and runned again a build in the sal > directory. > I attached a zip which contains console logs and gdb trace log from > sal/qa/process. > Hope it can give hints. Well, that's odd, that says that std::line

Re: [Libreoffice] Couldn't debug fdo#30550 (WAS: Build failed in sfx2 in -3-3 branch)

On Mon, 2011-06-20 at 23:52 +0700, Korrawit Pruegsanusak wrote: > ...then run swriter > After attaching soffice.bin to gdb using > gdb soffice.bin $LOPID[1] > libo writer was paused (which is normal, isn't it?) Yes, when you attach like that gdb stops the app, type cont to get it to continue. >

Re: [Libreoffice] [REVIEW] patch for fdo#38455

On 21/06/11 09:08, Petr Mladek wrote: Michael Meeks píše v Po 20. 06. 2011 v 21:06 +0100: On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote: The rest of that method seems to assume in several places that pActiveViewSh can be NULL and checks for that: Markus is committing a

Re: [Libreoffice] [REVIEWED][PUSHED: 3-4, 3-4-1] patch for fdo#38455

Petr Mladek píše v Út 21. 06. 2011 v 10:08 +0200: > Michael Meeks píše v Po 20. 06. 2011 v 21:06 +0100: > > On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote: > > > The rest of that method seems to assume in several places that > > > pActiveViewSh can be NULL and checks for that: > > > >

Re: [Libreoffice] [REVIEW] patch for fdo#38455

Michael Meeks píše v Po 20. 06. 2011 v 21:06 +0100: > On Mon, 2011-06-20 at 20:25 +0100, Michael Meeks wrote: > > The rest of that method seems to assume in several places that > > pActiveViewSh can be NULL and checks for that: > > Markus is committing an updated patch to master, that I'

Re: [Libreoffice] [PATCH] Additional fix for bug fdo#33781

Hi Petr, I've tested your patch with my test docs and for me it's OK. I've just noticed a small issue when inserting a chart in Calc : when switching out from edit mode, the top line of the graphic becomes blurred. I attach a test file, so you can judge the issue. Have a nice day, RB Le 20/