Re: [Libreoffice] [PUSHED-3-4] Get nice background image back to Mac also on Tiger dmg folder

2011-05-23 Thread Thorsten Behrens
Christian Lohmaier wrote: > The DS_Store references the backgroud image from outside of thedmg - > namely from Thorsten's home-directory. > But he already created another version (aller guten Dinge sind drei > :-)) and sent it to me for checking, and that iteration is correct, > find it attached. >

Re: [Libreoffice] Removing DLLPOSTFIX

2011-05-23 Thread Francois Tigeot
On Mon, May 23, 2011 at 11:22:28AM -0600, Tor Lillqvist wrote: > > If removing the suffix is too much work for 3.5, > > Nah, why would it be that much work? If it is agreed that those shared > libraries that use those suffixes are ones that binary extensions don't link > to anyway, let's just do

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Alex Thurgood changed: What|Removed |Added Depends on||37487 --- Comment #118 from Alex Thurgoo

Re: [Libreoffice] [REVIEW] build with system bsh breaks

2011-05-23 Thread Andreas Radke
build error is solved with this for me. thanks. -Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 vitriol changed: What|Removed |Added Depends on||37520 --- Comment #117 from vitriol 2011-05-2

Re: [Libreoffice] [PUSHED] Get nice background image back to Mac also on Tiger dmg folder

2011-05-23 Thread Christian Lohmaier
Hi Thorsten, *, On Mon, May 23, 2011 at 12:59 PM, Thorsten Behrens wrote: >> so, it turns out changing those DS_Store files on Snow Leopard makes >> them incompatible for Tiger - re-did the dance there, please review >> another DS_Store update for 3.4.0 preferrably - 3 reviews needed I'm >> afrai

[Libreoffice] Dream to act like a xxxdirector? Attack a magic pilule!

2011-05-23 Thread Sibil
Desire to act like a pornstar? Bang a magic pilule! http://edupod.com.sg/market.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [GOSC][Patch] multi line input bar

2011-05-23 Thread Kohei Yoshida
On Tue, 2011-05-24 at 00:52 +0530, Anurag Jain wrote: > Hello kohei, > > Sorry for the mistake. This is the updated patch. So, just to inform the list... After having IRC chat with him at some length, I have created a feature branch feature/calc-multiline-input for him to allow him to work on th

Re: [Libreoffice] breathing master

2011-05-23 Thread Norbert Thiebaud
On Mon, May 23, 2011 at 2:57 PM, Bjoern Michaelsen wrote: > >> I'd like to see build-break mails with the error actually >> inline in them as a first step. >> This may simply be a outcome of parallel builds ? As a quick-fix maybe >> having the buildbots auto restart with a single proc build would

Re: [Libreoffice] [PATCH][PUHED] Replace List for std::vector in SfxStringItemList

2011-05-23 Thread Joseph Powers
Sorry for the late notice... Joe P. On May 21, 2011, at 5:16 PM, Rafael Dominguez wrote: > > <0001-Remove-uneeded-parameter-for-Sort-functionlibs-gui.patch><0002-Move-GetList-to-implementation-filelibs-gui.patch><0003-Replace-List-for-std-vector-in-SfxStringListlibs-gui.patch><0004-Remove-tool

[Libreoffice] [GSOC] Weekly Report: Wizards....

2011-05-23 Thread Xisco Faulí
Hello everybody, I'm sorry for the one day delay in the weekly report but I had a project deadline today and I was working hard on it. Anyway I spent some time working on the google project last week as well. So far I've already converted ~40 files. I'll still need more time in order to summit the

Re: [Libreoffice] breathing master

2011-05-23 Thread Bjoern Michaelsen
Hi Caolán, On Mon, 23 May 2011 15:50:40 +0100 Caolán McNamara wrote: > I think we have a three things here > a) broken tinderboxes/build > b) overly noisy list > c) unreviewed patches Right, sorry to have mixed those. > The needs-X-reviews is a bit tedious alright. Maybe these can be > bumped o

Re: [Libreoffice] [REVIEW] fix for fdo#37390

2011-05-23 Thread Cedric Bosdonnat
Hi all, On Mon, 2011-05-23 at 14:06 +0200, Cedric Bosdonnat wrote: > Don't apply that one... I had remorse all the week-end for all the > non-conforming documents that may loose that property. I'll hack a > better patch to still read the old property. Here is an augmented patch handling the old a

[Libreoffice] FW: נותרו פחות משבועיים...

2011-05-23 Thread קופון הזהב
אם אינך רואה דואר אלקטרוני זה כרואי לחץ כאן הדילים המשתלמים בכל הארץ! ובנוסף טלויזיה 32 אינצ' של SAMSUNG!

Re: [Libreoffice] [GOSC][Patch] multi line input bar

2011-05-23 Thread Anurag Jain
Hello kohei, Sorry for the mistake. This is the updated patch. On Sun, May 22, 2011 at 4:50 PM, Anurag Jain wrote: > Hello Kohei, > > Please find the patch below and let me know your feedback. > > Thanks and regards. > -- > Anurag Jain > Final yr B.Tech CSE > SASTRA University > Thanjavur(T.N.)-

[Libreoffice] pointless makefile ?

2011-05-23 Thread Norbert Thiebaud
Caolan, in filters:dfb05afaec63e4537a18947695106052574b6593 you removed a 'pointless' makefile... as it turned out that makefile was apparently preventing --enable-werror from being enforced on that particular piece... that is why all the sudden the tinderbox that build with --enable-werror start

Re: [Libreoffice] Platform-specific DLL suffix usefulness

2011-05-23 Thread Tor Lillqvist
> The empty one is from unxiosr.mk and I suspect the platform doesn't build Indeed not, unxiosr is the just started extremely unfinished partial port to iOS ;) Far from ready, if it ever will be. Shared libraries / dynamic modules can't even be used for non-system code on iOS so no "DLL suffix"

Re: [Libreoffice] Platform-specific DLL suffix usefulness

2011-05-23 Thread Francois Tigeot
Hi Michael, On Mon, May 23, 2011 at 04:49:58PM +0100, Michael Meeks wrote: > > If we are talking about the 'li' suffix in libswli.so - then I don't > see much good reason for that really. > Presumably extensions use only the standard, stable UNO APIs - and none > of them use fooli.so

[Libreoffice] Illegal operations in connectivity::OSQLParseNode::impl_parseNodeToString_throw

2011-05-23 Thread Alexander Thurgood
Hi, While attempting to profile a systematic crash on Mac OSX : https://bugs.freedesktop.org/show_bug.cgi?id=37487 I see this in the output of the assembly language instructions : Illegal operations 0x27b72399 0x06 in connectivity::OSQLParseNod

Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

2011-05-23 Thread Kohei Yoshida
On Sun, 2011-05-22 at 23:50 +0200, Markus Mohrhard wrote: > But all in all in my opinion we should rework the whole pDefaultList > part in master. I think it is bad style to create a boost::ptr_vector > with new as long as it is not necessary, so if you agree I would > rewrite these few lines for

Re: [Libreoffice] breathing master

2011-05-23 Thread Norbert Thiebaud
On Mon, May 23, 2011 at 9:50 AM, Caolán McNamara wrote: [...] > IMO with the tinderbox mails, they don't give the actual error. I'd like > to see build-break mails with the error actually inline in them as a > first step. > > This may simply be a outcome of parallel builds ? As a quick-fix maybe >

Re: [Libreoffice] Please, review the patch to baside2b.cxx on 17-Feb-2011

2011-05-23 Thread Clio
23.05.2011 05:17, Noel Power пишет: But, it seems in summary Cntrl+Z didn't enable the toolbar redo, Andreas made some patch and it it didn't fix things completely, I hope that is an accurate. Yes. Now we move onto bug https://bugs.freedesktop.org/show_bug.cgi?id=37405 which you think is someho

Re: [Libreoffice] cppunit test fails in lotuswordpro / breaks the build on Mac/PPC

2011-05-23 Thread Caolán McNamara
On Mon, 2011-05-23 at 16:45 +0100, Michael Meeks wrote: > On Sun, 2011-05-22 at 23:00 +0200, Christian Lohmaier wrote: > > Caolan did push some bigendianfixes for lotuswordpro filter that > > includes the above change, not sure how long it would take to fully > > make it compatible/working on bigen

Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui)

2011-05-23 Thread Tor Lillqvist
> Looks like a beautiful patch to me. And yes, we shouldn't have #ifdef > WIN conditionals in files built only on windows (I hope) ;-) Actually I think OOo uses WIN to mean 16-bit Windows 3.x...(and Win9x?), at least in some contexts. It is WNT that it uses to indicate 32-bit Windows. See for i

Re: [Libreoffice] about ooslapsh.bin

2011-05-23 Thread Michael Meeks
Hi Jean, On Sat, 2011-05-21 at 16:16 +0200, Jean-Baptiste Faure wrote: > I tried to use gdb with my last build for libreoffice-3-4 branch (this > morning). This time, oosplash.bin crashed after a moment of inactivity. > It did not eat 100% CPU, only seemed to do nothing (futex_wait_queue_me) > and

Re: [Libreoffice] Windows installer translations

2011-05-23 Thread Michael Meeks
Hi Plino, On Sat, 2011-05-21 at 10:01 -0700, plino wrote: > May I suggest that all the translation files for the Windows setup (after > unpacking) are placed in a subfolder (e.g. trans) and the setup.ini modified > accordingly? Of course - if you come up with a patch :-) I'd poke around i

Re: [Libreoffice] Platform-specific DLL suffix usefulness

2011-05-23 Thread Michael Meeks
Hi Francois, If we are talking about the 'li' suffix in libswli.so - then I don't see much good reason for that really. On Sun, 2011-05-22 at 20:03 +0200, Francois Tigeot wrote: > Where can I find more about this ? I've found some openoffice.org web pages > about extensions but nothing re

Re: [Libreoffice] cppunit test fails in lotuswordpro / breaks the build on Mac/PPC

2011-05-23 Thread Michael Meeks
On Sun, 2011-05-22 at 23:00 +0200, Christian Lohmaier wrote: > Caolan did push some bigendianfixes for lotuswordpro filter that > includes the above change, not sure how long it would take to fully > make it compatible/working on bigendian.. Ah - yes, I see he has a nice PPC machine somew

Re: [Libreoffice] [LibreOffice][GSoC 2011][svgexport] build issue: "libvcllx.so: undefined symbol: _ZN3utl10ConfigItemC2ERKN3rtl8OUStringEs"

2011-05-23 Thread Michael Meeks
Hi Marco, On Mon, 2011-05-23 at 00:10 +0200, Marco wrote: > after the last "pull -r && make all" when I start soffice I got the > following error: > "libvcllx.so: undefined symbol: _ZN3utl10ConfigItemC2ERKN3rtl8OUStringEs" Ok - nasty. I hope you did a './g pull -r' in the top-level and th

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Kohei Yoshida
On Mon, 2011-05-23 at 17:14 +0200, Bjoern Michaelsen wrote: > > Hi Kohei, > > On Mon, 23 May 2011 10:08:38 -0400 > Kohei Yoshida wrote: > > > Because that's what we decided to do during our TSC meeting IIRC. The > > premise was that we would do merge regularly into master, ~at least > > once p

Re: [Libreoffice] [PATCH] __cdecl -> SAL_CALL (libs-gui)

2011-05-23 Thread Michael Meeks
Hi Christina, On Mon, 2011-05-23 at 10:02 +0200, Chr. Rossmanith wrote: > the attached patch removes __cdecl and uses SAL_CALL instead. For future > work: I suppose that I can omit files having win32 in their path? Looks like a beautiful patch to me. And yes, we shouldn't have #ifdef WIN

Re: [Libreoffice] master & patch review process ...

2011-05-23 Thread Bjoern Michaelsen
Hi Michael, On Mon, 23 May 2011 16:10:06 +0100 Michael Meeks wrote: > Which is bad; no-one denies that - *but* it also seems like > you just saw it was broken, and left it - rather than fixing it: it > also sounds like the problem was extremely trivial - some printf's > left in some module

Re: [Libreoffice] Writer, errors in debug mode

2011-05-23 Thread Caolán McNamara
On Mon, 2011-05-23 at 14:03 +0200, Cedric Bosdonnat wrote: > > 2) I insert a jpg picture from file, i have : > > Error: SolarMutex not locked From File > > /home/maryline/compile-libreoffice/libo/clone/libs-gui/vcl/source/app/dbggui.cxx > > > > at Line 1979 > I never saw those, but it could be

Re: [Libreoffice] [PATCH] change default fall-back font lists for Thai locale in vcl.xcu

2011-05-23 Thread Samphan Raruenrom
On Mon, May 23, 2011 at 9:21 PM, Christian Lohmaier < lohmaier+libreoff...@googlemail.com> wrote: > Hi Sampha, *, > On Mon, May 23, 2011 at 2:36 PM, Samphan Raruenrom > wrote: > > I've done a small research on preferred fonts for Thai in > > Windows/Linux/MacOSX by consulting several communities,

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Petr Mladek changed: What|Removed |Added Depends on||36631 -- Configure bugmail: https://bugs.

Re: [Libreoffice] [REVIEW] fdo#37418, fix layout of Export Text File dialog

2011-05-23 Thread Michael Meeks
On Mon, 2011-05-23 at 03:43 -0600, Tor Lillqvist wrote: > +1 from me And me - picked to the -3-4-0 branch. HTH, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing li

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Bjoern Michaelsen
Hi Kohei, On Mon, 23 May 2011 10:08:38 -0400 Kohei Yoshida wrote: > Because that's what we decided to do during our TSC meeting IIRC. The > premise was that we would do merge regularly into master, ~at least > once per week as we did during the 3.3 release. But for some reason > we haven't mer

Re: [Libreoffice] master & patch review process ...

2011-05-23 Thread Michael Meeks
Hi Bjoern, On Mon, 2011-05-23 at 14:12 +0200, Bjoern Michaelsen wrote: > On Mon, 23 May 2011 12:00:08 +0100 > > Also, my experience of building master is that it is not . > > Of the dozen times I've pulled and updated > > recently - my build has failed perhaps 5 times, of which 3+ have been >

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37317, which changed state. Bug 37317 Summary: Select comments print position in print dialog and closing crashes writer https://bugs.freedesktop.org/show_bug.cgi?id=37317 What|Old Value

Re: [Libreoffice] breathing master

2011-05-23 Thread Caolán McNamara
On Sat, 2011-05-21 at 14:02 +0200, Bjoern Michaelsen wrote: > Hi all, > > here is a proposal to improve our handling of patching and commits on > master. > LibreOffice is aiming for a welcoming and inviting culture to aloow > newcomer get invaolved fast. This is why we have a very lax requirement

Re: [Libreoffice] [PATCH] change default fall-back font lists for Thai locale in vcl.xcu

2011-05-23 Thread Christian Lohmaier
Hi Sampha, *, On Mon, May 23, 2011 at 2:36 PM, Samphan Raruenrom wrote: > I've done a small research on preferred fonts for Thai in > Windows/Linux/MacOSX by consulting several communities, font developers and > authority. Cood to hear, as most of us will not really know Thai fonts and their dif

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Kohei Yoshida
On Mon, 2011-05-23 at 14:56 +0200, Bjoern Michaelsen wrote: > On Mon, 23 May 2011 06:39:52 -0600 > "Tor Lillqvist" > wrote: > > > Well, the policy, at least as some of us (me included) have > > understood it, was that the development branch gets merged into > > master regularly, so no need to com

Re: [Libreoffice] [PUSHED 3-4-0] always request an unversioned lib from gcc in gccinstlib.pl

2011-05-23 Thread Caolán McNamara
On Mon, 2011-05-23 at 16:04 +0200, Thorsten Behrens wrote: > Bjoern Michaelsen wrote: > > pushed on 3-4, still needs one review for 3-4-0 (got another one on > > > ACKed & pushed by Fridrich & me into -3-4-0 This broke my *vanilla* powerpc multiarch build on Fedora 12, i.e libgcc_s.so is just a ld

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Kohei Yoshida
On Mon, 2011-05-23 at 14:29 +0200, Bjoern Michaelsen wrote: > Hi Tor, > > On Mon, 23 May 2011 04:52:26 -0600 > "Tor Lillqvist" > wrote: > > > Seems to be fixed already in a different way in -3-4 > Why that ever been done? Fixing something on the release branch, but not > on the development bran

Re: [Libreoffice] [PUSHED 3-4-0] always request an unversioned lib from gcc in gccinstlib.pl

2011-05-23 Thread Thorsten Behrens
Bjoern Michaelsen wrote: > pushed on 3-4, still needs one review for 3-4-0 (got another one on > ACKed & pushed by Fridrich & me into -3-4-0 -- Thorsten pgpvsuksArioS.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedes

Re: [Libreoffice] [PATCH]: fixes compiler warnings for vcl/workben/svpclient.cxx

2011-05-23 Thread Tor Lillqvist
> Together with svptest, it excersises the headless mode - so you can > watch vcl render to some framebuffer device. Still useful code. OK. So shouldn't we then fix the code to work correctly, not just get rid of compiler warnings? I.e., in +nBytes = write( nSocket, rCommand.getSt

[Libreoffice] REMINDER: Release 3.4.0-rc2 from libreoffice-3-4-0 branch

2011-05-23 Thread Petr Mladek
Hi, please note that the commit deadline for 3.4.0-rc2 is today. We are going to do the libreoffice-3.4.0.2 tag in the libreoffice-3-4-0 branch tomorrow. If no blocker is found, rc2 will be marked as final. Commit rules for the new libreoffice-3-4-0 branch: + commits approved by 3 peopl

[Libreoffice] in-lining more UNO foo ...

2011-05-23 Thread Michael Meeks
Hi Matus, On Sun, 2011-05-22 at 13:58 +0200, Matúš Kukan wrote: > This week I've finished playing with commandimages. Result is about > 70kB (cca 3%) save in size of images*.zip. Nice - so, 3% doesn't sound like much - but the in-memory cost of duplicating all those path strings is quite

Re: [Libreoffice] [PATCH]: fixes compiler warnings for vcl/workben/svpclient.cxx

2011-05-23 Thread Thorsten Behrens
Tor Lillqvist wrote: > Normally, for code that goes into LO. I don't think we want to > introduce perror() calls; they are fairly pointless there. Normal > users will never see the output. > > But yeah, this is for code in a "workben" directory, aren't those > just random old test and whatnot stuf

Re: [Libreoffice] [REVIEW][PUSHED] fdo#37433 German hyph dictionary failure

2011-05-23 Thread Lubos Lunak
On Monday 23 of May 2011, Tor Lillqvist wrote: > > We need 2 more reviews for the libreoffice-3-4-0 branch. > > +1 from me +1, pushed to 3-4-0. -- Lubos Lunak l.lu...@suse.cz ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://list

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37429, which changed state. Bug 37429 Summary: EDITING: Crash when copy / paste table from Writer https://bugs.freedesktop.org/show_bug.cgi?id=37429 What|Old Value |New Value ---

Re: [Libreoffice] [Review] [PUSHED] Patch for fdo#37429: crash when copy/paste table from writer to calc

2011-05-23 Thread Lubos Lunak
On Monday 23 of May 2011, Markus Mohrhard wrote: > Pushed to master. > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=d30c66cb1954103a159 >da2ef82dba4bf9685844f > > Would be nice if we could get 2 additional reviews for 3-4-0. +1, pushed to 3-4-0. -- Lubos Lunak l.lu...@suse.cz _

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Bjoern Michaelsen
On Mon, 23 May 2011 06:39:52 -0600 "Tor Lillqvist" wrote: > Well, the policy, at least as some of us (me included) have > understood it, was that the development branch gets merged into > master regularly, so no need to commit fixes to both. But yeah, it > does now seem safer to commit to both th

Re: [Libreoffice] [REVIEW] build with system bsh breaks

2011-05-23 Thread Norbert Thiebaud
On Mon, May 23, 2011 at 4:36 AM, David Tardon wrote: > On Sun, May 22, 2011 at 01:12:38AM -0500, Norbert Thiebaud wrote: >> On Sun, May 22, 2011 at 1:02 AM, David Tardon wrote: >> > Hi, >> > >> > could someone sign-off this small patch? >> >> David, it would be easier if you actually attach the p

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Tor Lillqvist
Sorry, got my words mixed up. What I mean was obviously: Well, the policy, at least as some of us (me included) have understood it, was that the stable branch gets merged into the development branch (master) regularly, so no need to commit fixes to both. But yeah, it does now seem safer to comm

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Tor Lillqvist
> Fixing something on the release branch, but not > on the development branch is downright stupid. Well, the policy, at least as some of us (me included) have understood it, was that the development branch gets merged into master regularly, so no need to commit fixes to both. But yeah, it does

Re: [Libreoffice] [REVIEW] Compatibility option for old size of small caps text effect

2011-05-23 Thread Lubos Lunak
On Friday 20 of May 2011, Caolán McNamara wrote: > On Fri, 2011-05-20 at 15:30 +0100, Michael Meeks wrote: > > On Fri, 2011-05-20 at 15:33 +0200, Cedric Bosdonnat wrote: > > > > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=450ce7ee526 > > > >72e77c6e5fe601d0ed3c416a60b16 to 3-4 and eve

[Libreoffice] [PATCH] change default fall-back font lists for Thai locale in vcl.xcu

2011-05-23 Thread Samphan Raruenrom
I've done a small research on preferred fonts for Thai in Windows/Linux/MacOSX by consulting several communities, font developers and authority. Here is the modification that the Thai community decide that best for Thai locale. It will help users when exchanging documents between these platform

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Bjoern Michaelsen
Hi Tor, On Mon, 23 May 2011 04:52:26 -0600 "Tor Lillqvist" wrote: > Seems to be fixed already in a different way in -3-4 Why that ever been done? Fixing something on the release branch, but not on the development branch is downright stupid. And it is not getting better (or worse) by Sun/Oracle

Re: [Libreoffice] master & patch review process ...

2011-05-23 Thread Bjoern Michaelsen
Hi Michael, On Mon, 23 May 2011 12:00:08 +0100 Michael Meeks wrote: > Also, my experience of building master is that it is not > -that- bad: by -that- bad, I mean the pre-CWS nightmare of Hamburg > times (as an example). Of the dozen times I've pulled and updated > recently - my build has f

Re: [Libreoffice] Report [GSoC] [helpfiles]

2011-05-23 Thread Jan Holesovsky
Hi Timo, On 2011-05-23 at 01:55 +0200, Timo wrote: > this is what I have done so far: > - Searched several libraries that parse wikicode > - Used a python library which parses wikisyntax > - Used a python library which outputs docbook-files > - Discovered an implementation of CHM-Compiler in free

Re: [Libreoffice] [REVIEW] fix for fdo#37390

2011-05-23 Thread Cedric Bosdonnat
Hi all, Don't apply that one... I had remorse all the week-end for all the non-conforming documents that may loose that property. I'll hack a better patch to still read the old property. On Fri, 2011-05-20 at 17:33 +0200, Cedric Bosdonnat wrote: > Hi all, > > Some people complained about LO not

Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

2011-05-23 Thread Cedric Bosdonnat
On Mon, 2011-05-23 at 04:21 -0600, Tor Lillqvist wrote: > >>> On 2011-05-23 at 00:50, wrote: > > The problem here is that you are not allowed to access any element as long > > as the ptr_vector is empty. > > > I think we should include this patch in 3-4-0. > > Another crash introduced by a "Remo

Re: [Libreoffice] Writer, errors in debug mode

2011-05-23 Thread Cedric Bosdonnat
On Sun, 2011-05-22 at 22:50 +0200, Julien Nabet wrote: > Error: XHierarchicalNameAccess: Other/IsSquaredPageModeOther/ApplyCharUnit > /org.openoffice.Office.Writer/Layout/Other/IsSquaredPageModeOther/ApplyCharUnit > > From File > /home/maryline/compile-libreoffice/libo/unotools/source/config/co

Re: [Libreoffice] about bug fdo 36519 ("writer8" instead of "ODF Text" in options UI)

2011-05-23 Thread Cedric Bosdonnat
Hi Jean-Baptiste, On Mon, 2011-05-23 at 07:30 +0200, Jean-Baptiste Faure wrote: > No suggestion to help me to fix this bug ? > I think this bug is a bad communication about the LibO's involment for ODF. Sure, read below: > Le 15/05/2011 11:31, Jean-Baptiste Faure a écrit : > > Hi, > > > > I try

Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

2011-05-23 Thread Markus Mohrhard
2011/5/23 Tor Lillqvist > >>> On 2011-05-23 at 00:50, wrote: > > The problem here is that you are not allowed to access any element as > long > > as the ptr_vector is empty. > > > I think we should include this patch in 3-4-0. > > Another crash introduced by a "Remove DECLARE_LIST" change, I am

[Libreoffice] dev300-m106 integration

2011-05-23 Thread Jan Holesovsky
Hi Tor, On 2011-05-23 at 05:40 -0600, Tor Lillqvist wrote: > > The current state is in integration/dev300_m106, I'll be grateful for any > > help there. > > Is there any email or wiki writeup on what is the recommended workflow, etc? > I would love to help, but I don't know what to do. I am a

Re: [Libreoffice] [REVIEW] Complete fix for fdo#32684

2011-05-23 Thread Cedric Bosdonnat
Hi Michael, On Mon, 2011-05-23 at 12:20 +0100, Michael Meeks wrote: > On Mon, 2011-05-23 at 12:55 +0200, Cedric Bosdonnat wrote: > > That bug was badly fixed (by me) quite some times ago. Here is a > > correct fix (why did I add that code at all ?). Could you review it > > and push it in 3.4 and 3

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Tor Lillqvist
> The current state is in integration/dev300_m106, I'll be grateful for any > help there. Is there any email or wiki writeup on what is the recommended workflow, etc? I would love to help, but I don't know what to do. --tml ___ LibreOffice mailing l

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Jan Holesovsky
Hi Tor, On 2011-05-23 at 04:52 -0600, Tor Lillqvist wrote: > Seems to be fixed already in a different way in -3-4 (and presumably > -3-4-0) by Kohei in 06b6df6759929073e917ae0fa7e819407d3e2555 , > "fdo#36288: Fixed a crasher on Base" on Apr 20. Why the crash still > happens then, no idea. Anyway,

Re: [Libreoffice] [REVIEW] Complete fix for fdo#32684

2011-05-23 Thread Michael Meeks
Hi there, On Mon, 2011-05-23 at 12:55 +0200, Cedric Bosdonnat wrote: > That bug was badly fixed (by me) quite some times ago. Here is a > correct fix (why did I add that code at all ?). Could you review it > and push it in 3.4 and 3.4.0? Hmm. > More cleanup is needed but it'll end up in

Re: [Libreoffice] VBA link error ...

2011-05-23 Thread Bjoern Michaelsen
On Mon, 23 May 2011 13:08:56 +0200 Thorsten Behrens wrote: > In case that's not solved yet - you want either gnumake 3.82, or a > patched 3.81 - Björn had a helpful list of needed fixes somewhere. Here is a package for ubuntu/debian: https://launchpad.net/~libreoffice/+archive/ppa/+sourcepub/17

Re: [Libreoffice] python / XInvocation snafu ...

2011-05-23 Thread Michael Meeks
On Mon, 2011-05-23 at 10:18 +0200, Bjoern Michaelsen wrote: > I have taken a look at the class and all it does is provide > string resources via the good ol' tools ressource manager. Beautiful :-) I suspect (hope) that this impl. behavioural detail can be tweaked, and that only the wizar

Re: [Libreoffice] VBA link error ...

2011-05-23 Thread Thorsten Behrens
Andreas Radke wrote: > /bin/sh: line 1: 10897 Segmentation fault make -r -j10 > In case that's not solved yet - you want either gnumake 3.82, or a patched 3.81 - Björn had a helpful list of needed fixes somewhere. HTH, -- Thorsten pgpS8hvQmGKWZ.pgp Description: PGP signature __

Re: [Libreoffice] VBA link error ...

2011-05-23 Thread Thorsten Behrens
Andreas Radke wrote: > /bin/sh: line 1: 10897 Segmentation fault make -r -j10 > In case that's not solved yet - you want either gnumake 3.82, or a patched 3.81 - Björn had a helpful list of needed fixes somewhere. HTH, -- Thorsten pgphz10SyfG5v.pgp Description: PGP signature __

Re: [Libreoffice] [REVIEW][PUSHED 3-4] always request an unversioned lib from gcc in gccinstlib.pl

2011-05-23 Thread Bjoern Michaelsen
Hi all, pushed on 3-4, still needs one review for 3-4-0 (got another one on IRC). Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/

[Libreoffice] master & patch review process ...

2011-05-23 Thread Michael Meeks
Hi Bjoern, Lots of interesting ideas in your mail. On Sun, 2011-05-22 at 04:10 +0200, Bjoern Michaelsen wrote: > Kernel style subsystem maintainers would be great IMHO, but I had the > feeling that there is a general opposition against a 'too branchy' > development model. So - he

Re: [Libreoffice] [PUSHED] Get nice background image back to Mac also on Tiger dmg folder

2011-05-23 Thread Thorsten Behrens
> so, it turns out changing those DS_Store files on Snow Leopard makes > them incompatible for Tiger - re-did the dance there, please review > another DS_Store update for 3.4.0 preferrably - 3 reviews needed I'm > afraid. > > Additionally, the Mac language pack .dmg had the OOo icon back since > t

Re: [Libreoffice] Duplicate code: SwDoc::SplitDoc

2011-05-23 Thread David Tardon
On Tue, May 10, 2011 at 10:17:19AM +0200, Chr. Rossmanith wrote: > Hi, > >> (what stands Stt for?) > once again: Stt means what? The answer might help to understand > what's going on in that method. Start :) I guess the original developer of the code wanted to save some typing... D.

Re: [Libreoffice] [PUSHED] Updated galaxy mimetype toolbar icons

2011-05-23 Thread Thorsten Behrens
> Michael Meeks wrote: > > These files changed size from 32x32 to 26x26 in this - that is what you > > wanted ? > > > Yes. > Pushed to 3-4 - two more reviews for -3-4-0 please. Thanks, -- Thorsten pgpcNTsLdvqv0.pgp Description: PGP signature ___

[Libreoffice] [REVIEW] Complete fix for fdo#32684

2011-05-23 Thread Cedric Bosdonnat
Hi all, That bug was badly fixed (by me) quite some times ago. Here is a correct fix (why did I add that code at all ?). Could you review it and push it in 3.4 and 3.4.0? More cleanup is needed but it'll end up in master: some options aren't used at all in that area. Thanks, -- Cédric Bosdonna

Re: [Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Tor Lillqvist
Seems to be fixed already in a different way in -3-4 (and presumably -3-4-0) by Kohei in 06b6df6759929073e917ae0fa7e819407d3e2555 , "fdo#36288: Fixed a crasher on Base" on Apr 20. Why the crash still happens then, no idea. Anyway, cherry-pick fails. I guess a merge of -3-4 to master is long ove

Re: [Libreoffice] [REVIEW][PUSHED-3-4] fdo#37433 German hyph dictionary failure

2011-05-23 Thread Tor Lillqvist
> We need 2 more reviews for the libreoffice-3-4-0 branch. +1 from me ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] build with system bsh breaks

2011-05-23 Thread Tor Lillqvist
>> > could someone sign-off this small patch? +1 from me ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Review] Patch for fdo#37429: crash when copy/paste table from writer to calc

2011-05-23 Thread Tor Lillqvist
>>> On 2011-05-23 at 00:50, wrote: > The problem here is that you are not allowed to access any element as long > as the ptr_vector is empty. > I think we should include this patch in 3-4-0. Another crash introduced by a "Remove DECLARE_LIST" change, I am so not surprised. +1 from me. Push thi

Re: [Libreoffice] [REVIEW][PUSHED-3-4] fdo#37433 German hyph dictionary failure

2011-05-23 Thread Petr Mladek
Andras Timar píše v Po 23. 05. 2011 v 11:50 +0200: > Hi, > > Fix for https://bugs.freedesktop.org/show_bug.cgi?id=37433 > German hyphenation is broken with the bundled German (de-DE) > dictionary, version 2011-05-05 Great. It really helped. Signed off and pushed into the libreoffice-3-4 branch, s

Re: [Libreoffice] [REVIEW] fdo#35728 Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Bjoern Michaelsen
On Mon, 23 May 2011 11:51:59 +0200 Bjoern Michaelsen wrote: > Hi all, > > please review: > http://cgit.freedesktop.org/libreoffice/components/commit/?id=19ed36590e990b5281da9c54bd962031bd56ae82 > http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=f25b836319678ab333a1a997cc7fdadfedad8e

[Libreoffice] [PUSHED] Unifying dev-install

2011-05-23 Thread Bjoern Michaelsen
On Mon, 23 May 2011 11:08:23 +0200 Cedric Bosdonnat wrote: > Simplifying this kind of things is good, +1 from me. Another charming +1 from Fridrich on IRC, pushed. Feel free to revert if problems arise. Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen __

[Libreoffice] [REVIEW] Fix crash from forms.OGridControlModel unoapitests

2011-05-23 Thread Bjoern Michaelsen
Hi all, please review: http://cgit.freedesktop.org/libreoffice/components/commit/?id=19ed36590e990b5281da9c54bd962031bd56ae82 http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=f25b836319678ab333a1a997cc7fdadfedad8e08 * various forms.OGridControlModel tests segfaulted * root cause is t

[Libreoffice] [REVIEW] fdo#37433 German hyph dictionary failure

2011-05-23 Thread Andras Timar
Hi, Fix for https://bugs.freedesktop.org/show_bug.cgi?id=37433 German hyphenation is broken with the bundled German (de-DE) dictionary, version 2011-05-05 Andras >From 2e41ef5cd4ff9f486187501ea5b8fb8a8cd8120f Mon Sep 17 00:00:00 2001 From: Andras Timar Date: Mon, 23 May 2011 11:41:16 +0200 Subje

Re: [Libreoffice] [PATCH]: fixes compiler warnings for vcl/workben/svpclient.cxx

2011-05-23 Thread Tor Lillqvist
Normally, for code that goes into LO. I don't think we want to introduce perror() calls; they are fairly pointless there. Normal users will never see the output. But yeah, this is for code in a "workben" directory, aren't those just random old test and whatnot stuff that aren't even built? What

Re: [Libreoffice] [Patch] build breaks in svx

2011-05-23 Thread Michael Meeks
On Sun, 2011-05-22 at 03:38 +0200, Markus Mohrhard wrote: > Ok, after having a second look at the tinderbox page I pushed this > patch because at least the Linux FC11 x86_64 gcj 1.5.0 tinderbox > failed due this error and it seems to be safe to me. Good work :-) if it is obviously wrong,

Re: [Libreoffice] [REVIEW] fdo#37418, fix layout of Export Text File dialog

2011-05-23 Thread Tor Lillqvist
+1 from me ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Unifying dev-install

2011-05-23 Thread Michael Meeks
On Sun, 2011-05-22 at 16:44 +0200, Bjoern Michaelsen wrote: > Opinions? Looks good to me ;-) but then I always run ooinstall manually myself. I assume that smoketest is headless these days and doesn't flash up annoying GUI windows and/or block for user input on any platform ? ATB

Re: [Libreoffice] [REVIEW] Updated galaxy mimetype toolbar icons

2011-05-23 Thread Thorsten Behrens
Michael Meeks wrote: > These files changed size from 32x32 to 26x26 in this - that is what you > wanted ? > Yes. -- Thorsten pgpm67RUvBXA0.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists

Re: [Libreoffice] [REVIEW] build with system bsh breaks

2011-05-23 Thread David Tardon
On Sun, May 22, 2011 at 01:12:38AM -0500, Norbert Thiebaud wrote: > On Sun, May 22, 2011 at 1:02 AM, David Tardon wrote: > > Hi, > > > > could someone sign-off this small patch? > > David, it would be easier if you actually attach the patch :-) Indeed it would :) D. >From 846010092e0a10c5423a26

Re: [Libreoffice] minutes of tech. steering call ... (Offensive Word Found In Message)

2011-05-23 Thread Noel Power
On 20/05/11 12:53, Norbert Thiebaud wrote: I do agree. but then it should be possible to use a nice review-tools and still have the generated review comment posted in the the ML I mean, when someone add a patch to be review in the tool that can generate a post to the ML with the patch (either i

Re: [Libreoffice] pulling modules prior to compilation

2011-05-23 Thread Michael Meeks
On Sun, 2011-05-22 at 23:04 +0200, Jonathan Aquilina wrote: > hey guys i would like to try and pull all the modules So do: $ ./g pull -r -- michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreO

Re: [Libreoffice] [REVIEW] Updated galaxy mimetype toolbar icons

2011-05-23 Thread Michael Meeks
Hi Thorsten, On Mon, 2011-05-23 at 02:37 +0200, Thorsten Behrens wrote: > sorry folks, what I had running was not what I pushed - another > patch attached, that clamps the galaxy mimetype icons to 26^2 (they > errorneously were 32^2). Sigh - no doubt it is better; you have my approval for

Re: [Libreoffice] Please, review the patch to baside2b.cxx on 17-Feb-2011

2011-05-23 Thread Noel Power
On 20/05/11 15:53, Clio wrote: Please, see here, that the patch actually added 1 line: http://svn.services.openoffice.org/opengrok/diff/DEV300_m106/basctl/source/basicide/baside2b.cxx?r2=%2FDEV300_m106%2Fbasctl%2Fsource%2Fbasicide%2Fbaside2b.cxx%40275666%3Ad11c441ed074&r1=%2FDEV300_m106%2Fbasctl%

  1   2   >