Re: [Libreoffice] bugs from openoffice

2011-05-13 Thread Cor Nouws
Hi Arno, Pls understand the use of this list: http://lists.freedesktop.org/mailman/listinfo/libreoffice Arno Teigseth wrote (14-05-11 07:17) This here very data-destructive bug is also living in libreoffice's fur somewhere: http://openoffice.org/bugzilla/show_bug.cgi?id=89232 [...] So I wond

[Libreoffice] bugs from openoffice

2011-05-13 Thread Arno Teigseth
Hi This might be a stupid question, so I'd better ask it quick and get over with it: This here very data-destructive bug is also living in libreoffice's fur somewhere: http://openoffice.org/bugzilla/show_bug.cgi?id=89232 My version: LibreOffice 3.3.2 OOO330m19 (Build:202) tag libreoffice-3.3.2.

Re: [Libreoffice] ExcelToSc / ExcelToSc8

2011-05-13 Thread Kohei Yoshida
On Fri, 2011-05-13 at 22:38 +0200, Chr. Rossmanith wrote: > Quick answer :-) Thank you! > >> at the moment I'm having a look at ExcelToSc and ExcelToSc8 and have the > >> feeling that there is some amount of duplicate code... > >> > >> During comparison of methods ExcRelToScRel and ExcRelToScRel8

Re: [Libreoffice] ExcelToSc / ExcelToSc8

2011-05-13 Thread Chr. Rossmanith
Quick answer :-) Thank you! at the moment I'm having a look at ExcelToSc and ExcelToSc8 and have the feeling that there is some amount of duplicate code... During comparison of methods ExcRelToScRel and ExcRelToScRel8 I've wondered if it shouldn't be nRow instead of nC in the initialisation of

Re: [Libreoffice] ExcelToSc / ExcelToSc8

2011-05-13 Thread Kohei Yoshida
On Fri, 2011-05-13 at 22:14 +0200, Chr. Rossmanith wrote: > Hi, > > at the moment I'm having a look at ExcelToSc and ExcelToSc8 and have the > feeling that there is some amount of duplicate code... > > During comparison of methods ExcRelToScRel and ExcRelToScRel8 I've > wondered if it shouldn't

[Libreoffice] ExcelToSc / ExcelToSc8

2011-05-13 Thread Chr. Rossmanith
Hi, at the moment I'm having a look at ExcelToSc and ExcelToSc8 and have the feeling that there is some amount of duplicate code... During comparison of methods ExcRelToScRel and ExcRelToScRel8 I've wondered if it shouldn't be nRow instead of nC in the initialisation of bRowRel: void Excel

[Libreoffice] [PATCH] Simplified #define OSL_FILE_TRACE

2011-05-13 Thread Chr. Rossmanith
Hi, if I remember correctly cppcheck complained about some statements in the context of OSL_FILE_TRACE. This patch simplifies the definition of OSL_FILE_TRACE ( => code better readable) and facilitates compiling without warnings. Please review in case there was some magic behind the original

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-13 Thread Kohei Yoshida
On Fri, 2011-05-13 at 23:54 +0700, Korrawit Pruegsanusak wrote: > Hello all, > > Joop Kiefte wrote: > > Maybe worth it to look those places up in the version control history... > > I've annotated this file and found the added version since Sep 2010. > Let's take a look from this link: > http://op

Re: [Libreoffice] cppcheck : Same expression on both sides of '!='

2011-05-13 Thread Korrawit Pruegsanusak
Hello all, Joop Kiefte wrote: > Maybe worth it to look those places up in the version control history... I've annotated this file and found the added version since Sep 2010. Let's take a look from this link: http://opengrok.libreoffice.org/diff/calc/sc/source/core/tool/rangeutl.cxx?r2=%2Fcalc%2Fs

[Libreoffice] [REVIEW] patch for #36684

2011-05-13 Thread Noel Power
Hi, can someone please review ( and cherrypick ) to libreoffice3.4 the following patch http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ea29c4f0d289890fcdb2f12380aa1ccf3d1028c9 from master thanks, Noel ___ LibreOffice mailing list LibreOffi

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36684, which changed state. Bug 36684 Summary: UI: Menu 'View> Toolbars' relations to toolbars messed up https://bugs.freedesktop.org/show_bug.cgi?id=36684 What|Old Value |New Value -

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld changed: What|Removed |Added Depends on|36571 | -- Configure bugmail: https://bugs.

Re: [Libreoffice] [GSOC][PATCH] Multiline inputbar

2011-05-13 Thread Kohei Yoshida
On Thu, 2011-05-12 at 23:27 -0400, Kohei Yoshida wrote: > On Fri, 2011-05-13 at 03:53 +0530, Anurag Jain wrote: > > Hello There, > > > > I'm posting here the git diff of the work I've done till now. > > @Kohei Since I do not want to disturb my master branch I'm here > > pasting the diff only. Plea

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36571, which changed state. Bug 36571 Summary: Find bar does not appear properly at top of screen https://bugs.freedesktop.org/show_bug.cgi?id=36571 What|Old Value |New Value

Re: [Libreoffice] Fwd: LibreOffice 3.4.0 ,DEV300m103 (Build:4)

2011-05-13 Thread Cedric Bosdonnat
Hi Italo, without any more info from that guy I'ld say that this looks like a blocker that has been recently fixed and will be in the next version. On Fri, 2011-05-13 at 15:55 +0200, Italo Vignoli wrote: > I know this is not the right place for bugs, but I am definitely not the > right person to

[Libreoffice] [PUSHED] Re: [REVIEW] Fix for fdo#36826

2011-05-13 Thread Fridrich Strba
Thank you for the patches, valuable contributor. Keep on the good work F. On Fri, 2011-05-13 at 15:30 +0200, Cedric Bosdonnat wrote: > -nLeftHeaderCount = pLeftHeaderFmt->GetClientCount(); > -{ > -int nLeftHeaderCount = 0; > -} > >

[Libreoffice] Fwd: LibreOffice 3.4.0 ,DEV300m103 (Build:4)

2011-05-13 Thread Italo Vignoli
I know this is not the right place for bugs, but I am definitely not the right person to handle a bug warning ;-) Original Message Subject:LibreOffice 3.4.0 ,DEV300m103 (Build:4) Date: Fri, 13 May 2011 15:50:16 +0200 From: Jean-Paul Ghys Reply-To: jp.g...@gma

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-05-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36524, which changed state. Bug 36524 Summary: EDITING: Delete Index causes crash https://bugs.freedesktop.org/show_bug.cgi?id=36524 What|Old Value |New Value

[Libreoffice] [REVIEW] Fix for fdo#36826

2011-05-13 Thread Cedric Bosdonnat
Hi all, Could you review and signoff the attached patches for inclusion in 3.4 branch? The first patch is simply some cleanup to make sw build with debug symbols. The second is the fix for https://bugs.freedesktop.org/show_bug.cgi?id=36826 (paragraph borders hidden by paragraph background) Thank

[Libreoffice] [PATCH] resubmitted: Some more OSL_* love and debug.hxx removal in writer/sw

2011-05-13 Thread Jacek Wolszczak
Resubmitting the mail in case it got lost somewhere in the spam filter. BTW, do you think I should create a bug in bugzilla for align ASSERT (& friends) macro foo easy hack? Jacek Wiadomość przekazywana -- Od: Jacek Wolszczak Do: libreoffice-dev Temat: [Libreoffice] [PATCH] Som

Re: [Libreoffice] Make check now fails on master in smoketest for Mac OSX

2011-05-13 Thread Alexander Thurgood
Le 13/05/11 09:58, Alexander Thurgood a écrit : Here's the first one (line 140) : catch (css::connection::NoConnectException &) {} if (process_ != 0) { TimeValue delay = { 1, 0 }; // 1 sec CPPUNIT_ASSERT_EQUAL( osl_Process_E_TimedOut,

[Libreoffice] [REVIEW] fix for fdo#36951

2011-05-13 Thread Andras Timar
Hi, Could anyone review and sign-off this patch in 3.4 branch? It fixes the layout of password dialog (e.g. File - Properties - Security, File - Export to PDF - Security). It is not critical but it looks ugly. Thanks, Andras >From 4f5b9c060c38d46db0f2df008979fc8e4d9f4d79 Mon Sep 17 00:00:00 2001

Re: [Libreoffice] Make check now fails on master in smoketest for Mac OSX

2011-05-13 Thread Alexander Thurgood
Le 13/05/11 09:49, Alexander Thurgood a écrit : The problem appears to lie in some assertions which fail : : && DYLD_LIBRARY_PATH=/Users/alex/DevHack/git/libo/clone/testing/smoketestoo_native/unxmacxi.pro/lib:/Users/alex/DevHack/git/libo/solver/340/unxmacxi.pro/lib${DYLD_LIBRARY_PATH:+:${DYLD_LIB

[Libreoffice] Make check now fails on master in smoketest for Mac OSX

2011-05-13 Thread Alexander Thurgood
FYI, I built from master on Mac OSX 2 days ago, make check worked, and smoketest successfully did its tests, i.e. I saw the app start, a window opens briefly, then closes again, and this is repeated a couple of times. Note that I built initially with the LANG switch "en-US, de, fr, ru". Now, afte

Re: [Libreoffice] [REVIEW] fix for fdo#36524

2011-05-13 Thread Cedric Bosdonnat
Hi all, I've just seen that there are cases where that change won't fit the original code. I'll need some more thinking to make it clean or check what it breaks. Don't push it now as it may introduce other bugs (potentially blockers) On Thu, 2011-05-12 at 17:14 +0200, Cedric Bosdonnat wrote: > H