Re: [Libreoffice] toplevel make or partial build after modifications?

2011-03-16 Thread Norbert Thiebaud
On Wed, Mar 16, 2011 at 5:01 PM, Christina Roßmanith wrote: > Hi, > > I've edited parhtml.cxx in ./svtools and now I'd like to test if the > modification fixes bug 34666. What do I have to do? Is a partial build in > directory ./svtools enough? Or is there some "install"-step needed? Or do I > hav

[Libreoffice] toplevel make or partial build after modifications?

2011-03-16 Thread Christina Roßmanith
Hi, I've edited parhtml.cxx in ./svtools and now I'd like to test if the modification fixes bug 34666. What do I have to do? Is a partial build in directory ./svtools enough? Or is there some "install"-step needed? Or do I have to do a toplevel make? Christina Rossmanith __

Re: [Libreoffice] Fix Bug 32559

2011-03-16 Thread Caolán McNamara
On Wed, 2011-03-16 at 21:45 +0100, Bálint Dózsa wrote: > Hi, > > Here is a modification. (Shift+F3 is not hardcoded) Cool, this looks good stuff on first glance. Probably a few open questions around handling the e.g. "annotation" shell for using it inside those insert->comment things, and wheth

Re: [Libreoffice] Fix Bug 32559

2011-03-16 Thread Bálint Dózsa
Hi, Here is a modification. (Shift+F3 is not hardcoded) Balint 2011. március 16. 17:56 Bálint Dózsa írta, : > Thanks for helping. > I'm working on it > > Balint > > 2011. március 15. 17:43 Caolán McNamara írta, : > > On Wed, 2011-03-09 at 15:50 +0100, Bálint Dózsa wrote: >> > Hi, >> > >> > Here

[Libreoffice] LibreOffice (hackers) event at Dutch congress March 24

2011-03-16 Thread Cor Nouws
Hi, This is to notify you that I just posted to the marketing list about a event with LibO hackers at a Dutch Congress, March 24. See http://listarchives.libreoffice.org/www/marketing/msg02698.html When there are more people from The Netherlands able to join (part) of that day (I have seen s

[Libreoffice] SwItemPropertySet

2011-03-16 Thread Christina Roßmanith
Hi, during removal of comments it became obvious that SwItemPropertySet::FillItem always returns sal_FALSE. Further searching for SwItemPropertySet with grok only finds it in unomap.hxx and unomap.cxx, ./g grep additionally finds it in binfilter. Does binfilter use the binfilter definition of

Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files

2011-03-16 Thread Thomas Arnhold
On 03/12/2011 11:46 PM, Miklos Vajna wrote: > So far we have 4 .gitattributes files in the root of 4 repos with the > same contents. To have them in the rest of the repos and avoid > duplication, it's better to have a single one in the bootstrap repo and > configure the rest of the repos to use tha

Re: [Libreoffice] nullptr, was: Suggestion: Let's switch to using MSVC2010 on Windows for master

2011-03-16 Thread Tor Lillqvist
> I can't find the exact details since which gcc version this > has been the case, but I assume that if msvc and gcc are the only compilers > we care about, then we could switch to nullptr and #define it ourselves when > not provided by the compiler automatically. Yep. As it turned out, we dec

Re: [Libreoffice] nullptr, was: Suggestion: Let's switch to using MSVC2010 on Windows for master

2011-03-16 Thread Lubos Lunak
On Monday 14 of March 2011, Caolán McNamara wrote: > On Mon, 2011-03-14 at 04:07 -0600, Tor Lillqvist wrote: > > is nullptr supported in the gcc versions used on other platforms? So is > > it better to just use 0 cast to the appropriate pointer type instead? > > AFAIK nullptr is part of c++0x Co

Re: [Libreoffice] Fix Bug 32559

2011-03-16 Thread Bálint Dózsa
Thanks for helping. I'm working on it Balint 2011. március 15. 17:43 Caolán McNamara írta, : > On Wed, 2011-03-09 at 15:50 +0100, Bálint Dózsa wrote: > > Hi, > > > > Here is the correction patch > > This looks reasonable so far, though it might be better to avoid > hardcoding a "case KEY_F3 | KE

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Michaël Lefèvre
Damned misunderstanding ;) I've posted the patches once the compilation succeeds yesterday evening. Michaël 2011/3/16 Michaël Lefèvre : > Actually not tested :( > Just keep compiling. > > Solar.h > #define F_PI 3.14159265358979323846 > > And ftools.h > #define F_PI M_PI > > M_PI defined in OdgEx

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Thorsten Behrens
Michaël Lefèvre wrote: > Just keep compiling. > That's ok in this case. Give us a poke if your build succeeds. Cheers, -- Thorsten pgpidvIb1p5rX.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://list

[Libreoffice] Fwd: Re: ICU Build breakage in master on OSX

2011-03-16 Thread Alexander Thurgood
Below is Caolan's reply to another message of mine, just so it goes on list, but strange that my previous reply did not go to the list... Alex Message original Sujet: Re: ICU Build breakage in master on OSX Date : Wed, 16 Mar 2011 13:32:56 + On Wed, 2

Re: [Libreoffice] l10n based on PO files

2011-03-16 Thread Thorsten Behrens
Caolan McNamara wrote: > On Wed, 2011-03-16 at 08:42 -0600, Tor Lillqvist wrote: > > Or, just have LibreOffice set a LANGUAGE environment variable to > > correspond to its current UI language before invoking the libintl > > functions. > > There's a hack in the gtk fpicker (source/unx/gnome/SalGtkP

Re: [Libreoffice] l10n based on PO files

2011-03-16 Thread Caolán McNamara
On Wed, 2011-03-16 at 08:42 -0600, Tor Lillqvist wrote: > Or, just have LibreOffice set a LANGUAGE environment variable to > correspond to its current UI language before invoking the libintl > functions. There's a hack in the gtk fpicker (source/unx/gnome/SalGtkPicker.cxx) to do the above, we shou

Re: [Libreoffice] l10n based on PO files

2011-03-16 Thread Tor Lillqvist
> Thorsten, Tor, Fridrich, do you know if .mo files (pure gettext > solution) would work on Windows and MAC? You mean at LibreOffice run-time? Sure, libintl (gettext's gettext-runtime/intl) is portable just fine to Windows. After all, all it does is open and read files. Some slight tweaks to th

Re: [Libreoffice] l10n based on PO files

2011-03-16 Thread Petr Mladek
Thorsten, Tor, Fridrich, please read the question at the end of the mail. Christian Lohmaier píše v Po 14. 03. 2011 v 23:06 +0100: > Hi Andras, > > On Mon, Mar 14, 2011 at 6:28 PM, Andras Timar wrote: > > The proposed l10n workflow is the following. I provide en-US.sdf and > > pot files regular

Re: [Libreoffice] [PATCH] remove String with OUString

2011-03-16 Thread Caolán McNamara
On Wed, 2011-03-16 at 13:55 +0100, Xisco Faulí wrote: > Hello, > > It's the first time I do it so I searched for previous commits in > order to get a referent. i couldn't find any example for > String.AssignAscii so I replace it with OUStringBuffer.appendAscii. Yeah, that's probably the best rou

[Libreoffice] development summary: year 2011, week 10

2011-03-16 Thread Petr Mladek
Hi, this time a brief summary of what happened during the 10th week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release + libreoffice-3-3-2: final stabilizatio

Re: [Libreoffice] Compiled still failed in instsetoo_native after compiling a brand new local repository

2011-03-16 Thread Petr Mladek
Hi, I have just come across this mail. It is better to answer it late than newer, Julien Nabet píše v Čt 10. 03. 2011 v 00:03 +0100: > Hello, > > After having removed all my local repository, refetch (from master) and > rebuild the whole thing, i still got this in instsetoo_native : > Package f

Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files

2011-03-16 Thread Miklos Vajna
On Wed, Mar 16, 2011 at 10:31:51AM +0100, Jan Holesovsky wrote: > I would say so :-) Or - we could create links like we do for the hooks? > It would make it more obvious what is going on... Sure, done. :) pgpg7QR54iqzT.pgp Description: PGP signature

Re: [Libreoffice] [REVIEW][PUSHED] de_AT and de_CH dictionary update - fdo#33751

2011-03-16 Thread Petr Mladek
Fridrich Strba píše v Út 15. 03. 2011 v 15:45 +0100: > As I mentioned in the bug, I sign off for this one :) > > F. > > On 15/03/11 14:40, Michael Meeks wrote: > > > > On Sun, 2011-03-13 at 21:49 +0100, Andras Timar wrote: > >> I ask you to cherry-pick this commit to libreoffice-3-3 and > >> libr

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Michaël Lefèvre
Actually not tested :( Just keep compiling. Solar.h #define F_PI 3.14159265358979323846 And ftools.h #define F_PI M_PI M_PI defined in OdgExporter.cxx as #define M_PI 3.14159265358979323846 Same values. The value changed in the other constants F_PI*. In solar.h, these are fixed, where in ftool

Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files

2011-03-16 Thread Jan Holesovsky
Hi Miklos, On 2011-03-12 at 23:46 +0100, Miklos Vajna wrote: > So far we have 4 .gitattributes files in the root of 4 repos with the > same contents. To have them in the rest of the repos and avoid > duplication, it's better to have a single one in the bootstrap repo and > configure the rest of t

Re: [Libreoffice] [PATCH] Remove duplicated constant F_PI and friends

2011-03-16 Thread Cedric Bosdonnat
Hi Michael, Did you test that your patches didn't introduce a regression? As the two F_PI constants don't have the same value, some bugs can be introduced by using a more precise value. I'll try to have a look at it before the end of the week, many thanks for your patches! On Tue, 2011-03-15 at