Re: [Libreoffice] 2 questions

2011-01-20 Thread Norbert Thiebaud
On Fri, Jan 21, 2011 at 1:18 AM, Julien Nabet wrote: > Hello, > > I' ve got these 2 questions : > 1) > After a make, make dev-install. If I found a problem with LO, can I just do > this : > - source Linux... > - go to the module I suppose there's the pb > - make the change > - build && deliver > -

Re: [Libreoffice] [REVIEW] cherry-picking a fix to 3.3

2011-01-20 Thread Norbert Thiebaud
On Thu, Jan 20, 2011 at 10:58 PM, Kohei Yoshida wrote: > Hi there, > > I just fixed this bug on master > > https://bugs.freedesktop.org/show_bug.cgi?id=33155 > > and would like to cherry-pick this to the 3.3 branch.  Here is the > relevant commit on master > > http://cgit.freedesktop.org/libreoffi

[Libreoffice] NEW [PATCH] i#116187: report left/right page margin setting ignored on Unix 64 bit

2011-01-20 Thread Lionel Elie Mamane
On Sat, Jan 15, 2011 at 08:00:05PM +, Caolán McNamara wrote: > On Sat, 2011-01-15 at 05:59 +0100, Lionel Elie Mamane wrote: >> Does not fit release blocker criteria, but would still be *very* nice >> to have for the release, as it easily fixes / papers over a rather >> annoying / stupid (from t

[Libreoffice] 2 questions

2011-01-20 Thread Julien Nabet
Hello, I' ve got these 2 questions : 1) After a make, make dev-install. If I found a problem with LO, can I just do this : - source Linux... - go to the module I suppose there's the pb - make the change - build && deliver - make dev-install ? Or must I : - remove the directory of the install -

[Libreoffice] NEW [PATCH] Unix 64 bits property type / default value mismatch

2011-01-20 Thread Lionel Elie Mamane
On Mon, Jan 17, 2011 at 04:58:28PM +, Caolán McNamara wrote: > On Mon, 2011-01-17 at 15:18 +0100, Lionel Elie Mamane wrote: >> (...) we have to make these three places >> agree. As to whether it is in the direction of "C/C++ long" everywhere >> or in the direction of "uno long == sal_Int32" ev

Re: [Libreoffice] [PATCH] repo base and filters: removal of extra newlines

2011-01-20 Thread Jonathan Aquilina
Fyi that was listed on the easy hack page, which i too started working on, and put down on the wiki that i am working on it. with your permission would it be ok to use the perl script you created to help with this task, or edit the wiki and we can work on this together. What do you think? On

[Libreoffice] [REVIEW] cherry-picking a fix to 3.3

2011-01-20 Thread Kohei Yoshida
Hi there, I just fixed this bug on master https://bugs.freedesktop.org/show_bug.cgi?id=33155 and would like to cherry-pick this to the 3.3 branch. Here is the relevant commit on master http://cgit.freedesktop.org/libreoffice/calc/commit/?id=b6734b453ec636aff3cb14535da24865c9d66d9a Could someo

Re: [Libreoffice] Change executable/sh names

2011-01-20 Thread NoOp
On 01/17/2011 07:24 PM, NoOp wrote: > On 01/17/2011 05:38 PM, NoOp wrote: >> On 01/17/2011 12:59 PM, NoOp wrote: ... >>> Thanks! I've been travelling, but I'm back now and will try to test >>> later this evening on WinXP. >> >> OK. Briefly tested and here is what I've found so far: >> >> 1. LO &

[Libreoffice] [PATCH] repo base and filters: removal of extra newlines

2011-01-20 Thread Michael Koch
Hi there, Attached you will find my first (but not last ;-) ) two patches. I wrote a Perl script to recursively search repos for "suspicious" files. (Files with a lot of "empty line, code line, empty line, code line, ..."). As there are over 100 "suspiciou

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-20 Thread plino
Wow. It took 12 hours for my post to show up... I'm really looking forward to a real Forum... I agree Tor, only an advanced user like me (and apparently you :) ) has an empty All Users Desktop folder. And obvioulsy I wouldn't allow a desktop shortcut if I wasn't testing ;) But what worries me i

Re: [Libreoffice] [PATCH] (Reworked) some translations of comments in sw/inc

2011-01-20 Thread Christoph Herzog
On 01/20/2011 05:50 PM, Michael Meeks wrote: :-) Unfortunately, (I just tried to merge the second patch), it was included in-line with line-wrapping which mangled it utterly (AFAICS): Attachments are probably better. Really sorry this has been a pain to get in - frustr

Re: [Libreoffice] [PATCH] g warper: forcing the recreation of symlinks [RESOLVED]

2011-01-20 Thread Bircher Florian
Hi Seems like M.Meeks did make some changes and PUSHED it to master: "cope with change of path, and broken absolute links this generates" SHA1 ID: 52dc7cfbcdd2b71d789ec1068bebcde44235dcdc My comment to the patch: You don't need to use force for ln if you delete the symlink before. ___

[Libreoffice] [REVIEW] fix for incorrect cell attribute import from xls

2011-01-20 Thread Kohei Yoshida
Hi there, I would like to cherry-pick the following from master to libreoffice-3-3. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=1459e2ba9e441d55c57345130a7c6f3353fa967a This fixes a pretty annoying cell format import bug from Excel documents. To reproduce it, 1) Create a new Excel

Re: [Libreoffice] Base / connectivity / sqlite

2011-01-20 Thread Michael Meeks
Hi there, On Wed, 2011-01-19 at 15:49 +, Wols Lists wrote: > Just announcing I've pushed a feature/sqlite branch to the connectivity > repo. I had a look :-) > It's based on Christian Werner's old code for OOo - note that it's > "copyright sun", and dates from sqlite's version change

Re: [Libreoffice] Fwd: [Libreoffice-bugs] [REVIEW] fdo#33237

2011-01-20 Thread Michael Meeks
Hi Noel, On Wed, 2011-01-19 at 17:15 +, Noel Power wrote: > sent to the wrong list... Code looks unlikely to crash and burn to me; and looks well worth fixing. So, you have my vote. Thanks ! Michael. -- michael.me...@novell.com <><, Pseudo Engineer, iti

Re: [Libreoffice] [PATCH] (Reworked) some translations of comments in sw/inc

2011-01-20 Thread Michael Meeks
Hi Christoph, On Wed, 2011-01-19 at 18:51 +0100, Christoph Herzog wrote: > Oops sorry! I didn't know that /* style comments were deprecated. I > removed them from my patch and reverted everything to proper // style. > As I have only very rudimentary knowledge of how doxigen works I thought > it

Re: [Libreoffice] unicode string literals, "stack" strings etc.

2011-01-20 Thread Michael Meeks
This is about to drop off the end of my mailbox I suppose :-) On Fri, 2010-10-29 at 09:49 +0100, Caolán McNamara wrote: > Taking unostrings.cxx there's some template cunning which generates > objects with the same layout as a OString, but without any constructors, > so that the StaticInit_OString

Re: [Libreoffice] [PATCH] git-hooks: warn about undocumented classes in new hxx files on commit

2011-01-20 Thread Michael Meeks
Hi Lubos, On Thu, 2011-01-20 at 16:26 +0100, Lubos Lunak wrote: > Given that I've pushed for this, I guess I'm the volunteer for this :) ? > Where should it be located, under > http://freedesktop.org/wiki/Software/LibreOffice ? I think we are trying to move all that lot to the document

[Libreoffice] [PUSHED] removal of extra white space lines

2011-01-20 Thread Michael Meeks
Hi there, On Thu, 2011-01-20 at 16:59 +0100, Jonathan Aquilina wrote: > Attached please find my first patch to remove white space lines in the > filter/source/xmlfilteradaptor/genericfilter.cxx Nice :-) > feedback is greatly appreciated. Thanks for that ! > Licensed under LGPL

[Libreoffice] PATCH removal of extra white space lines

2011-01-20 Thread Jonathan Aquilina
Attached please find my first patch to remove white space lines in the filter/source/xmlfilteradaptor/genericfilter.cxx feedback is greatly appreciated. Licensed under LGPLv3 >From 744c48dd358a743118ba8cb1bf2162ca7d243df3 Mon Sep 17 00:00:00 2001 From: jonathan aquilina Date: Tue, 18 Jan 2011

Re: [Libreoffice] [PATCH] git-hooks: warn about undocumented classes in new hxx files on commit

2011-01-20 Thread Lubos Lunak
On Thursday 20 of January 2011, Michael Meeks wrote: > Hi Miklos, > > On Thu, 2011-01-20 at 00:28 +0100, Miklos Vajna wrote: > > I'm attaching a patch that makes the pre-commit hook warn on introducing > > undocumented classes. > > So - being an un-reconstructed code-reader, and documentation

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-20 Thread Tor Lillqvist
> Even worse: if you Uninstall LO and the only item on the All Users Desktop > is the LO lnk, then the uninstaller nicely deletes the folder (which makes > sense because it is empty). I could reproduce this in a freshly installed WS2008R2, and thus the same presumably happens also on Windows 7 an

Re: [Libreoffice] [tdf-discuss] Linux distros and LibO packaging

2011-01-20 Thread Rene Engelhard
On Thu, Jan 20, 2011 at 02:20:45PM +, Michael Meeks wrote: > On the other hand, I think Andrea is right - my hope is that lots of > the distributions on every platform will converge more onto the > LibreOffice core over time, and require fewer patches, and (perhaps) a > few more configura

Re: [Libreoffice] LibreOffice request ...

2011-01-20 Thread Michael Meeks
Hi Kami, On Wed, 2011-01-19 at 08:10 +0100, Kálmán „KAMI” Szalai wrote: > Any news around this topic? None that I recall - it's just down to Coverity I guess :-) perhaps contacting David directly might help. David - previously the OpenOffice.org coverity output was virtually ignored; we c

Re: [Libreoffice] [tdf-discuss] Linux distros and LibO packaging

2011-01-20 Thread Michael Meeks
On Wed, 2011-01-19 at 11:13 +0100, Rene Engelhard wrote: > On Tue, Jan 18, 2011 at 09:13:43PM +0100, Andrea Pescetti wrote: .. > > make me think that fragmentation, while of course allowed by the > > license, should be discouraged when it comes to functionality; I'm not > > questioning desktop int

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-20 Thread plino
Oops.. Sorry, I forgot to mention that this was under Windows XP Pro Sp3. -- View this message in context: http://nabble.documentfoundation.org/Serious-bug-on-LO-Windows-installer-tp2294391p2294709.html Sent from the Dev mailing list archive at Nabble.com. ___

Re: [Libreoffice] Serious bug on LO Windows installer

2011-01-20 Thread Tor Lillqvist
On what Windows version did you notice this? --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Serious bug on LO Windows installer

2011-01-20 Thread plino
I had already detected this and confirmed with the latest installer (for RC4): LO installer somehow modifies the attributes of the All Users Desktop folder when it adds the LibreOffice lnk to the desktop. The All Users Desktop folder is a System Folder and usually can not be modified or deleted.

Re: [Libreoffice] [PATCH] [PUSHED] buildfix for libs-extern-sys/moz

2011-01-20 Thread Tor Lillqvist
> Should I file a bug for this? Nah, your email was enough. Patch committed to master, thanks! --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATH][PUSHED] set bash completion for oo* wrappers when enabled

2011-01-20 Thread Petr Mladek
Rene Engelhard píše v St 19. 01. 2011 v 23:07 +0100: > On Wed, Jan 19, 2011 at 08:31:02PM +0100, Petr Mladek wrote: > > Please, find attached 2nd version of the fix. What do you think about > > it? ;-) > > > > It uses different name for the generated bash function. It works here > > for the oo* an

Re: [Libreoffice] [PATCH] git-hooks: warn about undocumented classes in new hxx files on commit

2011-01-20 Thread Nguyen Vu Hung
On Thu, Jan 20, 2011 at 7:01 PM, Michael Meeks wrote: > Hi Miklos, > > On Thu, 2011-01-20 at 00:28 +0100, Miklos Vajna wrote: >> I'm attaching a patch that makes the pre-commit hook warn on introducing >> undocumented classes. > >        So - being an un-reconstructed code-reader, and documentatio

Re: [Libreoffice] [Patch] Translation of German comments in sfx2/ (part 2/4)

2011-01-20 Thread Michael Meeks
Hi Albert, First - thanks for helping out with this ! as you can see we have big German comment problems, and it is simply great to have help improving the situation: much appreciated :-) On Wed, 2011-01-19 at 16:54 -0700, Tor Lillqvist wrote: > I don't think you need to be that careful h

Re: [Libreoffice] [PATCH] git-hooks: warn about undocumented classes in new hxx files on commit

2011-01-20 Thread Michael Meeks
Hi Miklos, On Thu, 2011-01-20 at 00:28 +0100, Miklos Vajna wrote: > I'm attaching a patch that makes the pre-commit hook warn on introducing > undocumented classes. So - being an un-reconstructed code-reader, and documentation ignorer - it would be great to have a link to a wiki page / te