Re: [Libreoffice] LibreOffice request ...

2011-01-18 Thread Kálmán „KAMI” Szalai
Hi Michael! Any news around this topic? KAMI 2010-10-04 18:27 keltezéssel, Michael Meeks írta: > Hi there, > > It would be wonderful if we could get LibreOffice covered by the > Coverity Scan. LibreOffice ( based on OpenOffice.org [ cf. > http://libreoffice.org/ ] ) is now a vendor neutra

[Libreoffice] Calc crash when save as xls

2011-01-18 Thread Tantai Tanakanok
Hi all, I have successfully built LibreOffice 3.3.0 OOO330m18 (Build:4) on Ubuntu 10.04. I try to save xls from Calc. After clicking the “Keep Current Format” button, the program will crash and show the following error at the terminal. terminate called after throwing an instance of 'boost::bad_

Re: [Libreoffice] LanguageTool (dev) crashes Libreoffice

2011-01-18 Thread Arno Teigseth
On Wed, 2011-01-19 at 01:28 -0500, Arno Teigseth wrote: Hmm I might have been too quick there. Disabled all the extensions and then enabled one by one. It seems that when I have two spanish dictionaries, the one installed system-wide and one in my personal folder, is when this happens. > But whe

Re: [Libreoffice] LanguageTool (dev) crashes Libreoffice

2011-01-18 Thread Jonathan Aquilina
On 01/19/2011 07:28 AM, Arno Teigseth wrote: Hi all I know, it's LanguageTool's fault. I'm developing some rules, and running 1-3 dev. When right-clicking a word in trouble (red/blue underline), I get suggestions to how to fix it. But when I right-click a word that is just fine, then Libreoffi

[Libreoffice] LanguageTool (dev) crashes Libreoffice

2011-01-18 Thread Arno Teigseth
Hi all I know, it's LanguageTool's fault. I'm developing some rules, and running 1-3 dev. When right-clicking a word in trouble (red/blue underline), I get suggestions to how to fix it. But when I right-click a word that is just fine, then Libreoffice crashes entirely with the following to the t

[Libreoffice] To Whom It May Concern!!

2011-01-18 Thread Trevor Nawa
18th Jan. 2011 Trevor Nawa Postal address Plaza De Espa 28805 Alcala De Henares Email: trevorn...@oho.ee Attention: CEO/President Dear Sir/Madam, Before I proceed, I must first apologize for this unsolicited email to you. I am aware that this is certainly not a conventional way of approach to

Re: [Libreoffice] [FIXED] Re: debug build fails because graphite ./configure not up to date

2011-01-18 Thread Keith Stribley
On ၂၀၁၁ ဇန် ၁၆ တနင်္ဂနွေ နံနက် 02:46, Caolán McNamara wrote: Well, we do occasionally patch those "external" modules, but try to avoid it. The ideal place to send patches to graphite would be to the upstream graphite project and poke them to release a new update at some stage and then just upgra

Re: [Libreoffice] [REVIEW] Make --help and --version work even without $DISPLAY

2011-01-18 Thread Kohei Yoshida
On Tue, 2011-01-18 at 19:38 +0100, Lubos Lunak wrote: > Hello, > > could somebody please review the attached patch? While digging for something > else I noticed that --version doesn't work without $DISPLAY, recalled seeing > a bugreport about that somewhere [*] and thought how hard that could b

Re: [Libreoffice] [PUSHED] Re: [PATCH] cursor vs scroll

2011-01-18 Thread Andy Hearn
On 18 January 2011 20:23, Caolán McNamara wrote: > On Mon, 2011-01-17 at 22:13 +, Andy Hearn wrote: > > Hullo, > > > > > > I now think that this patch (identical to the "quasi" one sent a few > > days ago) is the fix for my PostIt cursor vs scroll itch. > > > > > > If I can quickly expand on

Re: [Libreoffice] [PUSHED] WaE patch for sc & filter

2011-01-18 Thread Kohei Yoshida
On Tue, 2011-01-18 at 17:57 +0100, Christian Lohmaier wrote: > Hi againm > forgot one for editeng/ libs-core For this one, I've opted to use the initial value of table::CellVertJustify2::STANDARD. It's probably bit more reader-friendly to use that instead of a raw zero value. With this, the foll

Re: [Libreoffice] WaE patch for sc & filter

2011-01-18 Thread Kohei Yoshida
On Tue, 2011-01-18 at 17:16 +0100, Christian Lohmaier wrote: > Hi *, > > some --enable-werror fixed needed to make the build compile on mac. As > there area multiple ways to solve those "may not be initialized" and > "comparing signed with unsigned" ones, I submit it here for comments > (esp. the

Re: [Libreoffice] Mac Build with lang=ALL

2011-01-18 Thread Norbert Thiebaud
On Tue, Jan 18, 2011 at 1:35 PM, Michael Meeks wrote: > On Wed, 2011-01-12 at 10:47 -0600, Norbert Thiebaud wrote: >> indeed it is a dog. it took 15h20. >> conservatively at least 13 hours of it were in helcontent2, mostly I/O >> bound creating temp files and copying things around over and over. [

[Libreoffice] Compilation failed in sw

2011-01-18 Thread Julien Nabet
Hello, Here what I get after a git update, an autogen.sh + rm -rf unxlng* in sw when I try to build on my Debian (testing updated) Compiling: sw/source/core/doc/docsort.cxx /home/maryline/libreoffice-source/libo/clone/writer/sw/source/core/doc/docsort.cxx: In member function 'virtual double S

[Libreoffice] [PUSHED] Re: [PATCH] cursor vs scroll

2011-01-18 Thread Caolán McNamara
On Mon, 2011-01-17 at 22:13 +, Andy Hearn wrote: > Hullo, > > > I now think that this patch (identical to the "quasi" one sent a few > days ago) is the fix for my PostIt cursor vs scroll itch. > > > If I can quickly expand on this here. I'm convinced, its a real nuisance problem and t

Re: [Libreoffice] [tdf-discuss] Linux distros and LibO packaging

2011-01-18 Thread Andrea Pescetti
On 09/01/2011 Jean-Baptiste Faure wrote: > I think that we should have a webpage where Linux distributions who are > packaging LibO, could list what changes they made compared to the > "official" build by TDF. ... > So, is it a good idea to ask the Linux distributions to publish the > changes they

Re: [Libreoffice] Mac Build with lang=ALL

2011-01-18 Thread Michael Meeks
On Wed, 2011-01-12 at 10:47 -0600, Norbert Thiebaud wrote: > indeed it is a dog. it took 15h20. > conservatively at least 13 hours of it were in helcontent2, mostly I/O > bound creating temp files and copying things around over and over. Wow; that is bad. > based on profiling while this w

Re: [Libreoffice] [PATCHSET] [PUSHED, partial] calc - removal of dead code

2011-01-18 Thread Kohei Yoshida
On Mon, 2011-01-17 at 20:07 +0100, Thomas Arnhold wrote: > Here are some more patches for calc. Have fun! Thanks Thomas. I've reviewed & applied them, though there were parts that I didn't apply. >From the 0001 patch, the first several hunks simply failed to apply, so I only applied from chart2/

[Libreoffice] [REVIEW] Make --help and --version work even without $DISPLAY

2011-01-18 Thread Lubos Lunak
Hello, could somebody please review the attached patch? While digging for something else I noticed that --version doesn't work without $DISPLAY, recalled seeing a bugreport about that somewhere [*] and thought how hard that could be (oh, silly me). I swear this is the simplest and safest pat

Re: [Libreoffice] REVIEW REQUEST: fdo#33088

2011-01-18 Thread Tor Lillqvist
> However - I would like to do the same thing in the toolbar code: I don't notice the same kind of lagginess in the toolbars, so maybe not for 3.3.0. For 3.3 and master, yes, go ahead. --tml ___ LibreOffice mailing list LibreOffice@lists.freede

Re: [Libreoffice] WaE patch for sc & filter

2011-01-18 Thread Christian Lohmaier
Hi againm forgot one for editeng/ libs-core ciao Christian diff --git a/editeng/source/items/justifyitem.cxx b/editeng/source/items/justifyitem.cxx index 31907ec..ac54b4f 100644 --- a/editeng/source/items/justifyitem.cxx +++ b/editeng/source/items/justifyitem.cxx @@ -316,7 +316,7 @@ bool SvxVerJus

Re: [Libreoffice] An image editing extension for writer

2011-01-18 Thread lakmal padmakumara
Hi , First of all Thank you so much for these wonderful comments+Feedback. It is always good to see people make comments on your work whether those are in negative side or positive side .Thanks again ! Really appreciate that . @Wols Yes Wols,I understand that fact very well. As you mentioned thi

[Libreoffice] WaE patch for sc & filter

2011-01-18 Thread Christian Lohmaier
Hi *, some --enable-werror fixed needed to make the build compile on mac. As there area multiple ways to solve those "may not be initialized" and "comparing signed with unsigned" ones, I submit it here for comments (esp. the first one in the lotuswordpro one - casting tag to unsigned (as the only

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Takeshi Abe
On Tue, 18 Jan 2011 07:45:04 -0700, "Tor Lillqvist" wrote: >>> Or am I missing something... >> Yes, we have a miserable trap of fall-through: > > No, I did see the fall-through. But if pDlg is NULL (a bit earlier), we don't > enter the block that contains the switch with the fall-through, wher

Re: [Libreoffice] Added some docs on valgrind/debugging

2011-01-18 Thread Michael Meeks
On Fri, 2011-01-14 at 21:41 +, Caolán McNamara wrote: > I ported over the disable-custom-memory allocator at runtime stuff to > the new allocator that LibreOffice is actually using. Hopefully that > doesn't break anything horribly on e.g. windows. That should make it > easier to valgrind Libre

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Caolán McNamara
On Tue, 2011-01-18 at 07:45 -0700, Tor Lillqvist wrote: > >> Or am I missing something... > > Yes, we have a miserable trap of fall-through: > > No, I did see the fall-through. But if pDlg is NULL (a bit earlier), we > don't enter the block that contains the switch with the fall-through, > wher

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Bug 31865 depends on bug 33088, which changed state. Bug 33088 Summary: Menu rendering problems? https://bugs.freedesktop.org/show_bug.cgi?id=33088 What|Old Value |New Value --

[Libreoffice] [PUSHED] Re: [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Caolán McNamara
On Tue, 2011-01-18 at 23:27 +0900, Takeshi Abe wrote: > Yes, we have a miserable trap of fall-through: > > Please apply the attached patch saving us in future. Done, heh, thanks for this. Dropped the German version of the comment as well. C. ___ Libre

Re: [Libreoffice] [PATCH] Replaced deprecated types in funcdesc

2011-01-18 Thread Kohei Yoshida
On Sun, 2011-01-16 at 23:15 +0100, Soeren Moeller wrote: > Hi > > I have replaced String with OUString, USHORT with sal_uInt16 and ULONG > with sal_uInt32 in sc/inc/funcdesc.hxx and > sc/source/core/funcdesc.cxx. Added a OUString version of > FuncData::getParamDesc in sc/inc/callform.hxx and > sc/

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Tor Lillqvist
>> Or am I missing something... > Yes, we have a miserable trap of fall-through: No, I did see the fall-through. But if pDlg is NULL (a bit earlier), we don't enter the block that contains the switch with the fall-through, where the other (hopefully only other possible) case does set pArgs. --

Re: [Libreoffice] [PUSHED] + review requests i#116187: report left/right page margin setting ignored on Unix 64 bit

2011-01-18 Thread Michael Meeks
On Sat, 2011-01-15 at 20:00 +, Caolán McNamara wrote: > I pushed this to master and to the stable 3-3 branch, thanks for this. > We'd need some more acks for 3-3-0 however, I'm +1 on that. Thirded, and pushed to libreoffice-3-3-0 Thanks ! Michael. -- micha

Re: [Libreoffice] REVIEW REQUEST [PUSHED]: fdo#33088

2011-01-18 Thread Tor Lillqvist
Pushed to libreoffice-3-3 and libreoffice-3-3-0. Not master yet, we should do even bigger cleanups of the related messy places there. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/lib

[Libreoffice] development summary: year 2011, week 2

2011-01-18 Thread Petr Mladek
Hi, this time a brief summary of what happened during the 2nd week in 2011 on LibreOffice repositories and the living branches: + master:hot LO-3.4 development + libreoffice-3-3: fixes for next LO-3.3.x bug fix release + libreoffice-3-3-0: final stabilization

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Fridrich Strba
Hello, So, in that patch, remove also the German comment that says something similar in different words. Cheers F. On Tue, 2011-01-18 at 23:27 +0900, Takeshi Abe wrote: > On Tue, 18 Jan 2011 03:26:14 -0700, "Tor Lillqvist" > wrote: > > Ah OK. I see that now when I pulled a fresher version. >

Re: [Libreoffice] ICU bloat ...

2011-01-18 Thread Michael Meeks
Hi Samphan, On Sun, 2011-01-16 at 10:07 +0700, Samphan Raruenrom wrote: > You can easily minimize the ICU footprint by tweaking the ICU build > options. See http://userguide.icu-project.org/packaging Wonderful :-) so we could halve the size of that and save several megabytes of download e

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Takeshi Abe
On Tue, 18 Jan 2011 03:26:14 -0700, "Tor Lillqvist" wrote: > Ah OK. I see that now when I pulled a fresher version. > > But unless I am mistaken, now then pArgs might in theory be de-references > while NULL? > > Consider this code path: > > const SfxItemSet* pArgs = rReq.GetArgs(); > >

Re: [Libreoffice] REVIEW REQUEST: fdo#33088

2011-01-18 Thread Fridrich Strba
Signoff me :) F. On Tue, 2011-01-18 at 06:36 -0700, Tor Lillqvist wrote: > Thorsten asked for an actual diff, so here: > > diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx > index e4e2716..e269766 > --- a/vcl/source/window/menu.cxx > +++ b/vcl/source/window/menu.cxx > @@ -11

Re: [Libreoffice] REVIEW REQUEST: fdo#33088

2011-01-18 Thread Thorsten Behrens
Tor Lillqvist wrote: > diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx > index e4e2716..e269766 > --- a/vcl/source/window/menu.cxx > +++ b/vcl/source/window/menu.cxx > @@ -1119,9 +1119,6 @@ void Menu::Highlight() > if ( pStartMenu && ( pStartMenu != this ) ) >

Re: [Libreoffice] Idea : container for toolbars

2011-01-18 Thread Michael Meeks
Hi Jean, On Sun, 2011-01-16 at 13:01 +0100, Jean-Baptiste Faure wrote: > I would like to know if it would be easy to modify LibO in order to be > able to dock the toolbars below or above the navigator as we can do with > the stylist. If we had this feature, the user would be able to customize > it

Re: [Libreoffice] REVIEW REQUEST: fdo#33088

2011-01-18 Thread Michael Meeks
On Tue, 2011-01-18 at 06:36 -0700, Tor Lillqvist wrote: > Thorsten asked for an actual diff, so here: You have an approval from me. However - I would like to do the same thing in the toolbar code: diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx index

Re: [Libreoffice] REVIEW REQUEST: fdo#33088

2011-01-18 Thread Caolán McNamara
On Tue, 2011-01-18 at 06:36 -0700, Tor Lillqvist wrote: > Thorsten asked for an actual diff, so here: > > diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx > index e4e2716..e269766 > --- a/vcl/source/window/menu.cxx > +++ b/vcl/source/window/menu.cxx > @@ -1119,9 +1119,6 @@ void

Re: [Libreoffice] css::table::BorderLine vs BorderLine2

2011-01-18 Thread cedric . bosdonnat . ooo
Hello, - "David Tardon" a écrit : > Yes, but css::table::BorderLine is used by css::table::TableBorder. Hum, I wanted to change that css::table::TableBorder type to use the new BorderLine2... but as it's published I couldn't change it. Do you have any idea how to do it better? > I notice

Re: [Libreoffice] REVIEW REQUEST: fdo#33088

2011-01-18 Thread Tor Lillqvist
Thorsten asked for an actual diff, so here: diff --git a/vcl/source/window/menu.cxx b/vcl/source/window/menu.cxx index e4e2716..e269766 --- a/vcl/source/window/menu.cxx +++ b/vcl/source/window/menu.cxx @@ -1119,9 +1119,6 @@ void Menu::Highlight() if ( pStartMenu && ( pStartMenu != this )

[Libreoffice] REVIEW REQUEST: fdo#33088

2011-01-18 Thread Tor Lillqvist
See https://bugs.freedesktop.org/show_bug.cgi?id=33088#c23 I would like to remove two lines of code from Menu::Highlight() in (libs-gui/)vcl/source/window/menu.cxx in the libreoffice-3-3 and libreoffice-3-3-0 branches. (Not maybe in master, yet, in the hope that either the OOO people will fix t

Re: [Libreoffice] An image editing extension for writer

2011-01-18 Thread Fernand Vanrie
Michael, I agree with your comments, specialy to make this tool available to other than Writer. But can you have a look at a important OO and LO 's weakness: there is no way to make some "Print Intentions" par Document. When placing a Graphic, we need to know what resolution is needed to repro

[Libreoffice] [Bug 31865] [Task]: LibreOffice 3.3 release blockers / stoppers

2011-01-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=31865 Bug 31865 depends on bug 33108, which changed state. Bug 33108 Summary: crash in case of an animation associated with a vertical text https://bugs.freedesktop.org/show_bug.cgi?id=33108 What|Old Value |New Value -

Re: [Libreoffice] Doxygen

2011-01-18 Thread Miklos Vajna
On Mon, Jan 17, 2011 at 06:48:53PM -0600, Ed Dean wrote: > All, > > >

[Libreoffice] [PUSHED] [PATCHES] writer ...

2011-01-18 Thread Michael Meeks
Hi Thomas, On Tue, 2011-01-18 at 08:37 +0100, Thomas Arnhold wrote: > Removed #newslistlevelattr#, #refactorlists# and obsolete date and RCS Wonderful :-) I've pushed your patches. Can you confirm that your work is under the LGPLv3+/MPL ? Also - given all this nice cleanup, work

Re: [Libreoffice] An image editing extension for writer

2011-01-18 Thread Michael Meeks
Hi Lakmal, On Tue, 2011-01-18 at 02:32 +0530, lakmal padmakumara wrote: > I'm engaging in developing an extension(OXT) for writer > which allows users to Wow :-) there are some great features here - and lots of good work. I love the effort you've put in :-) Personally - (as other

Re: [Libreoffice] error compiling in libs-gui/canevas

2011-01-18 Thread Michael Meeks
On Mon, 2011-01-17 at 20:23 +0100, Pierre-André Jacquod wrote: > Could someone who understands better than me this part fix it? or give > me a go to just change in Thanks for fixing it in the end :-) Michael. -- michael.me...@novell.com <><, Pseudo Engineer, itinerant

Re: [Libreoffice] [REVIEW] More reviews for fdo#33108 fix please

2011-01-18 Thread Noel Power
On 17/01/11 17:51, Thorsten Behrens wrote: Hi, Lubos fixed an ugly crasher in vcl via fdo#33108 - I've stripped the patch down to the absolute minimum, and would be ok for taking that for -3-3-0 - any further reviews, please? not being familiar with the cairo and vcl stuff but assuming the patch

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Tor Lillqvist
> Caolán has fixed the code around in a way to ensure pPV always initialized. Ah OK. I see that now when I pulled a fresher version. But unless I am mistaken, now then pArgs might in theory be de-references while NULL? Consider this code path: const SfxItemSet* pArgs = rReq.GetArgs();

Re: [Libreoffice] Review request: Typo in binfilter/bf_so3/source/ole/socli.cxx

2011-01-18 Thread Petr Mladek
Jan Holesovsky píše v Út 18. 01. 2011 v 10:37 +0100: > Hi Fridrich, > > On 2011-01-18 at 10:22 +0100, Thorsten Behrens wrote: > > > > -::SolarMuexGuard aGuard; > > > +::SolarMutexGuard aGuard; > > > > > Of course, fine by me. > > You have my OK too. Sure, go for it. Best Regards, Pe

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Takeshi Abe
Hi Tor, Thanks for your reply. On Tue, 18 Jan 2011 01:49:01 -0700, "Tor Lillqvist" wrote: > Thanks for the patch. The code in that method, > sd/source/ui/func/fusnapln.cxx: FuSnapLine::DoExecute( SfxRequest& rReq ), is > indeed interesting. In theory there are code paths through it that lead

Re: [Libreoffice] Review request: Typo in binfilter/bf_so3/source/ole/socli.cxx

2011-01-18 Thread Jan Holesovsky
Hi Fridrich, On 2011-01-18 at 10:22 +0100, Thorsten Behrens wrote: > > -::SolarMuexGuard aGuard; > > +::SolarMutexGuard aGuard; > > > Of course, fine by me. You have my OK too. Regards, Kendy ___ LibreOffice mailing list LibreOffice@lists.f

Re: [Libreoffice] Review request: Typo in binfilter/bf_so3/source/ole/socli.cxx

2011-01-18 Thread Tor Lillqvist
OK from me. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Review request: Typo in binfilter/bf_so3/source/ole/socli.cxx

2011-01-18 Thread Thorsten Behrens
> -::SolarMuexGuard aGuard; > +::SolarMutexGuard aGuard; > Of course, fine by me. -- Thorsten pgpnzEQsJeCI7.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/lis

Re: [Libreoffice] [PATCH] Replaced deprecated types in funcdesc

2011-01-18 Thread Tor Lillqvist
In general the patch looks mostly good. I wouldn't mind a second opinion from Kohei, though, in case there is something calc-specific I haven't thought of. Some comments, though: 1) You also change the spacing style to have just one space separation. I didn't check if you do it consistently in

Re: [Libreoffice] [REVIEW] Fixes for i116318 and i116371

2011-01-18 Thread Radek Doulík
On Tue, 2011-01-18 at 10:01 +0100, Radek Doulik wrote: > Hi Thorsten, > > the patch looks OK and safe to me. I mean both of them. R. > Cheers > Radek > > On Mon, 2011-01-17 at 15:45 +0100, Thorsten Behrens wrote: > > Hi, > > > > would you please review attached patches for 3-3-0 - they're > >

Re: [Libreoffice] [REVIEW] Fixes for i116318 and i116371

2011-01-18 Thread Radek Doulik
Hi Thorsten, the patch looks OK and safe to me. Cheers Radek On Mon, 2011-01-17 at 15:45 +0100, Thorsten Behrens wrote: > Hi, > > would you please review attached patches for 3-3-0 - they're > extracted from OOo's calc65 CWS, which'll go into RC10. > > Both are tested & work fine for me - they

Re: [Libreoffice] [REVIEW] More reviews for fdo#33108 fix please

2011-01-18 Thread Radek Doulik
Hi Thorsten, the patch looks OK to me. Cheers Radek On Mon, 2011-01-17 at 18:51 +0100, Thorsten Behrens wrote: > Hi, > > Lubos fixed an ugly crasher in vcl via fdo#33108 - I've stripped the > patch down to the absolute minimum, and would be ok for taking that > for -3-3-0 - any further reviews,

Re: [Libreoffice] [PATCH] possible null-dereferencing found by cppcheck

2011-01-18 Thread Tor Lillqvist
Thanks for the patch. The code in that method, sd/source/ui/func/fusnapln.cxx: FuSnapLine::DoExecute( SfxRequest& rReq ), is indeed interesting. In theory there are code paths through it that lead to a NULL pPV (and pArgs) pointer de-references, as cppcheck correctly notices. (But clearly, assu

[Libreoffice] Review request: Typo in binfilter/bf_so3/source/ole/socli.cxx

2011-01-18 Thread Fridrich Strba
>From a8b9ca32a544bdd6b6feae334cf3799f15ed6361 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fridrich=20=C5=A0trba?= Date: Tue, 18 Jan 2011 09:38:53 +0100 Subject: [PATCH] Fix a typo SolarMuexGuard -> SolarMutexGuard --- binfilter/bf_so3/source/ole/socli.cxx |2 +- 1 files changed, 1 insertions