Re: [Libreoffice] [PATCH] [PUSHED] new cppcheck cleaning in svx

2011-01-03 Thread David Tardon
On Fri, Dec 31, 2010 at 03:04:29PM +0100, Julien Nabet wrote: > Hello, > > Here is a new patch for cppcheck cleaning in svx > Compiling was ok > > I have no more this pb : > [./svdotxln.cxx:67]: (style) The class 'ImpSdrObjTextLink' does not > have a constructor. > > Julien > (LGPLv3+ / MPL) >

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h

2011-01-03 Thread Norbert Thiebaud
On Mon, Jan 3, 2011 at 10:36 PM, Kohei Yoshida wrote: > On Mon, 2011-01-03 at 21:47 +0100, Soeren Moeller wrote: >> Hi >> >> I have removed dependencies on tools/solar.h in some files in sc >> (according to >> http://wiki.documentfoundation.org/Easy_Hacks#write_tools.2F_pieces_out >> ) please rev

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-03 Thread Pierre-André Jacquod
Hi, > Does setting > #define MDDS_HASH_CONTAINER_STLPORT 1 > before > #include > > help? > > I also saw someone having a similar issue in the same exact spot, which > I haven't been able to reproduce. Maybe this is related. I had also a problem after having upgraded to mds 0.4.0 with an up to d

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in vcl

2011-01-03 Thread David Tardon
On Tue, Jan 04, 2011 at 08:23:36AM +0100, David Tardon wrote: > On Thu, Dec 30, 2010 at 06:43:12PM +0100, Julien Nabet wrote: > > Hello, > > > > Here is a patch for cppcheck cleaning in vcl > > Compiling was ok. > > > > I'm not sure if what I did about realloc pb in the file : > > vcl/unx/source/

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck cleaning in vcl

2011-01-03 Thread David Tardon
On Thu, Dec 30, 2010 at 06:43:12PM +0100, Julien Nabet wrote: > Hello, > > Here is a patch for cppcheck cleaning in vcl > Compiling was ok. > > I'm not sure if what I did about realloc pb in the file : > vcl/unx/source/gdi/xlfd_attr.cxx > was sufficient (even correct !). If Enlarge() failed, Ins

Re: [Libreoffice] [PATCH] [PUSHED] Updates for LightProof extension handling

2011-01-03 Thread David Tardon
On Mon, Dec 20, 2010 at 07:43:51PM +0100, Kálmán „KAMI” Szalai wrote: > Hi All, > > Following the changes introduced by OpenOffice.org 3.3 extension > handling. All extensions have to uncompressed to a folder with same name > as extension itself. > > Patch attached, > Please review it! > Looks

Re: [Libreoffice] Test script patch review request (1)

2011-01-03 Thread Yifan Jiang
Hi Tor, Thanks a lot for reviewing and the comments, I haven't even known the '(un)expand' until you told :) To make it concise, do you think it is enough to replace 'Inital' Tabs with 4 space characters, while change other tabs with 1 space character. In addition the trailing spaces could be remo

[Libreoffice] [Patch] Make SVG filter export text color

2011-01-03 Thread KUROSAWA, Takeshi
Dear LibreOffice community, I wrote patches for SVG export filter. These fix a bug that texts in an exported SVG are invisible. The most of codes come from Flash export filter (filters/filter/source/swfwriter1.cxx). Regards, -- KUROSAWA, Takeshi From e10fcbcc9d95eb24505126e6b9ea0313cccd7434 Mon

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-03 Thread Kohei Yoshida
On Tue, 2011-01-04 at 04:08 +0100, Miklos Vajna wrote: > Hi, > > Looks like there is something similar in sc as well, see the attached > log. I tried guarding > > #include > > using #include "preextstl.h" / #include "postextstl.h" but that does not > seem to help. Any other idea? :) Does setti

Re: [Libreoffice] [PATCH] [PUSHED] cppcheck at writer, performance.

2011-01-03 Thread Kohei Yoshida
On Thu, 2010-12-30 at 13:23 -0200, Kayo Hamid wrote: > So, it's a small patch that I send for review because I do not know if > it's ok to do what the cppcheck says to do. In this case, he says that > for non-primitive types we can do ++test instead test++. My fear is if > in the code really nee

Re: [Libreoffice] [PATCH] Removed dependencies on tools/solar.h

2011-01-03 Thread Kohei Yoshida
On Mon, 2011-01-03 at 21:47 +0100, Soeren Moeller wrote: > Hi > > I have removed dependencies on tools/solar.h in some files in sc > (according to > http://wiki.documentfoundation.org/Easy_Hacks#write_tools.2F_pieces_out > ) please review and commit. Thanks, pushed! BTW, we generally prefer the

Re: [Libreoffice] [PATCH] [PUSHED] Translated comments from German to English.

2011-01-03 Thread Kohei Yoshida
On Mon, 2011-01-03 at 14:22 +0100, Christina Roßmanith wrote: > Hi, > > my first patch... Nicely done for your very first patch. :-) BTW, since you asked the following question -BOOLbDoInsert; // wird fuer das erste Update auf FALSE gesetzt - +BOOLbDoIn

Re: [Libreoffice] [PATCH] [PUSHED] provide the long prefix '--' for options, e.g., --help

2011-01-03 Thread Kohei Yoshida
Hello Takeshi, On Fri, 2010-12-31 at 14:04 +0900, Takeshi Abe wrote: > Hi, > > Here is the patch for providing the long prefix "--" for soffice's > options; this solves the Easy Hack 3.7 [1]. The patch looks good. I just pushed it to master. The only changes I made are just fixing some coding

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-03 Thread Miklos Vajna
On Mon, Jan 03, 2011 at 02:46:53PM +, Luke Dixon <6b8b4...@gmail.com> wrote: > I'm very sorry the code I was playing with has caused problems. > > I guess I wasn't thinking when adding the first header outside the > guards. > > The assertion_traits struct, I was expecting this to be a problem

Re: [Libreoffice] [PATCH] UX New layout Move/Copy sheet in calc

2011-01-03 Thread Kohei Yoshida
Hello Joost, On Tue, 2010-12-28 at 16:45 +0100, Joost Eekhoorn wrote: > Hoi Kohei and all, > > I hope you enjoy the lovely weather. > > Hereby a patch to give a better user experience to the "Move/Copy > sheet" dialog. > > The changes are: > - Removed the "Rename"checkbox. > The "New name

Re: [Libreoffice] [PATCH] De-Java-ise flat XML export

2011-01-03 Thread Peter Jentsch
Hi Jan, I'm attaching a patch I somehow managed to patiently pull out of git :-) As I'm new to C++, libxslt, git and a few other things involved in creating the patch I feel it must be full of warts and cause random crashes, but it seems to work and might be useful anyway. Basically, the patch

Re: [Libreoffice] [libreoffice-l10n] LO Pootle

2011-01-03 Thread Jan Holesovsky
Hi Andras, On 2010-12-30 at 09:13 +0100, Andras Timar wrote: > > BTW - would it help you if we got rid of the sdf files, and instead we > > had .po files in the l10n git repository? [For sure it would help us > > who work with the git repos, because the sdf file format is just > > something incr

Re: [Libreoffice] [libreoffice-l10n] LO Pootle

2011-01-03 Thread Jan Holesovsky
Hi Martin, On 2010-12-30 at 10:36 +0100, Martin Srebotnjak wrote: > The Slovenian team will be working with sdf files (we have our own > localization system that works with sdf, splits to po-s and finalizes > back to sdf), so -1 from me. What exactly your system that works with sdf does? Is it

[Libreoffice] [PATCH] Re: Annoying cursor behavior on sw tables

2011-01-03 Thread Octavio Alvarez
On Mon, 03 Jan 2011 01:52:01 -0800, Cedric Bosdonnat wrote: The thing is that Window::Invalidate() gets called if I move or if I type inside a table cell, which almost any key triggers, which is wrong. bUpdatedTable gets set to True inside SwCallLink::~SwCallLink() after some tests. Another o

Re: [Libreoffice] starmath / cppunit breakage in master

2011-01-03 Thread Luke Dixon
Hello, I'm very sorry the code I was playing with has caused problems. I guess I wasn't thinking when adding the first header outside the guards. The assertion_traits struct, I was expecting this to be a problem, but I didn't know what to do about it, sorry. Apologies, Luke ___

Re: [Libreoffice] Annoying cursor behavior on sw tables

2011-01-03 Thread Cedric Bosdonnat
Hi Octavio, On Wed, 2010-12-29 at 20:58 -0800, Octavio Alvarez wrote: > Now, look at this, this blog post documents the patch: :-O > > http://cedric.bosdonnat.free.fr/wordpress/?p=472 Hum, thanks for poking me on it... I would have skipped the thread otherwise. > The thing is that Window::Inval

Re: [Libreoffice] Test script patch review request (1)

2011-01-03 Thread Tor Lillqvist
> cat /tmp/tabfile | sed 's///' > /tmp/notabfile; Sorry, but just replacing every TAB character with a fixed number (in this case, four) of SPACE characters is incorrect. To properly expand TAB characters, each TAB needs to be replaced with a variable number of SPACE characters,

Re: [Libreoffice] Replacement table enhancement for Braille table

2011-01-03 Thread Cedric Bosdonnat
Hello Sophie, On Tue, 2010-12-28 at 17:12 +0300, Sophie Gautier wrote: > Now would it be possible to enhance the replacement table so that we can > execute the pattern *oe* to be replaced by the pattern *oeu* in each > word containing this first pattern, that could be at the beginning of > the

Re: [Libreoffice] making binfilter aka StarOffice FileFormat read-only

2011-01-03 Thread Jan Holesovsky
Hi Pierre-Andre, On 2010-12-30 at 17:30 +0100, Pierre-André Jacquod wrote: > Thus, there is a major difference: With READONLY, no lock-file is > generated when the file is openend. With filter without the EXPORT, the > lock-file is still generated This comes during the load process, > where t

[Libreoffice] [PATCH] Translated comments from German to English.

2011-01-03 Thread Christina Roßmanith
Hi, my first patch... Christina Rossmanith >From 5967c1f8775734ecf63ac41c8e4766df2147bb7c Mon Sep 17 00:00:00 2001 From: cr Date: Mon, 3 Jan 2011 14:04:34 +0100 Subject: [PATCH] Translated comments from German to English. --- .../source/controller/dialogs/tp_TitleRotation.cxx |2 +- sc/in

Re: [Libreoffice] Formula cursor : bug or feature ?

2011-01-03 Thread Jan Holesovsky
Hi Regina, On 2010-12-31 at 14:21 +0100, Regina Henschel wrote: > >> (Aside from that I have a lot of other wishes, for example: Free choice > >> of color, nice scaling integral sign, easier way to add new symbols, > >> alignment to equal sign in stacks and matrices, inheritance of font size > >>