Thanks for helping.
> Heh, this also confuses cppcheck as well.
cough... cough... ! I am not smarter than a machine... ! A professor I
had told: this not a good point being too smart... I understand what he
meant.
For stepping in, not the easiest way. Once there is no waring any more
when compil
> Quick question wouldn't it be better to have the comments in English
> instead of German?
Sorry, !! I translate then when I can, but I did not the job to the
end for this one.
Not_appropriate_handling_for_me++
regards
___
LibreOffice mailing list
Li
regards
>From d8ca0db19fdc508ebc0bf0ee42107fdea2f498b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Thu, 25 Nov 2010 21:10:27 +0100
Subject: [PATCH 9/9] binfilter sw3io warning fixes
use of not initialized variables
---
binfilter/bf_sw/source/core/sw3io/sw_sw3fm
regards
>From a3757de1170fca97638be7e455b6602b9de228e1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Thu, 25 Nov 2010 20:57:45 +0100
Subject: [PATCH 8/9] waring cleaning in binfilter sw3io
code removed due to compiler warning: (for both if, that is not an error)
sw
Quick question wouldn't it be better to have the comments in English
instead of German?
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
regards
>From 13a33d71df128454159d0e911f55179cddac2d72 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Thu, 25 Nov 2010 20:52:47 +0100
Subject: [PATCH 7/9] warnings removal in binfilter sw_sw3redln.cxx
all code deletion due to compiler warning with message:
sw_sw3red
regards
>From 84e58630f70dc34f71ee34419d9843980b14b723 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Thu, 25 Nov 2010 20:18:10 +0100
Subject: [PATCH 6/9] waring cleaning in sw_sw3redln.cxx
shadowing warning and unused parameters
---
binfilter/bf_sw/source/core/sw3
regards
>From 01e9e819f9dd8f1726ddff7672f27cfcbd44760c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Thu, 25 Nov 2010 20:09:15 +0100
Subject: [PATCH 5/9] waring removal in binfilter core/para
---
binfilter/bf_sw/source/core/para/sw_paratr.cxx | 16 ---
regards
>From f6202b304ca7f0ffdd16cbd2886872465273852a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Tue, 23 Nov 2010 21:58:53 +0100
Subject: [PATCH 4/9] binfilter sc_interpr4.cxx further warnings removal
---
binfilter/bf_sc/source/core/tool/sc_interpr4.cxx | 17
regards
>From 80d6aecfb78de0da70107bd87c4d101942b79d78 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Tue, 23 Nov 2010 21:48:11 +0100
Subject: [PATCH 3/9] warnings in binfilters sc_interpr4.cxx
all changes based on debugger waring:
sc_interpr4.cxx: warning: comparis
regards
>From 32814375a2999afaf0582a682975ae6ec769f6f5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre-Andr=C3=A9=20Jacquod?=
Date: Tue, 23 Nov 2010 21:06:58 +0100
Subject: [PATCH 2/9] remove warnings in binfilter - sc_interpr2.cxx
based on the following compiler warnings:
sc_interpr2.cxx:1729:
Hello,
here some patches in binfilter to remove warnings by compiling...
Since some changes could (will) look strange, I submit it in little
chunks, often with compiler warning in comment. This may help the reviewer.
Hope I did no mistake
regards
Pierre-André
>From c747a9dcc4af190aac1f216a93f7abd4
... add PUSHED to subject...
D.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
On Thu, Nov 25, 2010 at 11:30:20PM +0100, Julien Nabet wrote:
> Hello,
>
> Here's a small patch for shell/source/unix/misc/gnome-open-url.c
>
> Julien.
> (LGPLv3+ / MPL)
> commit 6b768a031280d0c3ad23624dd3a6470c57395a56
> Author: serval
> Date: Thu Nov 25 23:26:39 2010 +0100
>
> correct
On Thu, Nov 25, 2010 at 10:15:52PM +0200, Roth Robert wrote:
> -- Forwarded message --
> From: Roth Robert
> Date: Thu, Nov 25, 2010 at 9:27 PM
> Subject: Extensions code cleanup
> To: libreoffice@lists.freedesktop.org
>
>
> Some more dead code and bogus comments removed from ext
On Thu, Nov 25, 2010 at 01:16:42PM -0800, Kayo Hamid wrote:
> I can't see the commit at cgit, where is? I want to see the changes to
> improve my skills, see the changes. What wrong I'm doing? Better, what are
> wrong remove?
> revol_
Sorry. Should be better now :)
D.
__
Well, the version 4.4.3 of gcc on my system seems to support it.
One way to see when it's available would be to look up gcc's documentation
in the changelog for the 4.4.x series
I took a quick look at gnu's web site and found this:
http://gcc.gnu.org/projects/cxx0x.html
(looks like a little
Hi Kendy,
I'm attaching a patch that updates the cia bot so that you don't need to
manually disable it on each merge. ;)
OK to push? (More importantly, if I push it, it would be nice if you
could restart the bot, as I guess that's not automatic. :) )
Thanks.
From 53a5563a0b4df6a45d73bc80be6927b0
On 25/11/10 16:44, Michael Meeks wrote:
> Hi Wols,
>
> On Thu, 2010-11-25 at 16:31 +, Wols Lists wrote:
>> Have we got a standard LibreOffice header to go into new files ?
> Yes COPYING.NEWFILES in the toplevel has the stock header.
With no place for people who make MAJOR alterations to
Hello,
Here's a small patch for shell/source/unix/misc/gnome-open-url.c
Julien.
(LGPLv3+ / MPL)
commit 6b768a031280d0c3ad23624dd3a6470c57395a56
Author: serval
Date: Thu Nov 25 23:26:39 2010 +0100
correct cppcheck, Memory leak: fallback
diff --git a/shell/source/unix/misc/gnome-open-url.
Hello,
Here is a small patch for ./sal/osl/unx/util.c
Julien.
commit 9b18a955cd7ac4462c68b8113f73cd4dca2ccbbb
Author: serval
Date: Thu Nov 25 23:03:04 2010 +0100
ure : remove unused variables
diff --git a/sal/osl/unx/util.c b/sal/osl/unx/util.c
index dad9934..91b7b0d 100644
--- a/sal/os
I can't see the commit at cgit, where is? I want to see the changes to improve
my skills, see the changes. What wrong I'm doing? Better, what are wrong remove?
revol_
Pushed with some changes.
D.
___
LibreOffice mailing list
LibreOffice@lists
On Thu, 2010-11-25 at 19:41 +0100, Pierre-André Jacquod wrote:
> {
> sal_Int8 nTemp;
> rVal >>= nTemp;
> if(nTemp >=1 && nTemp < 0x7f
> nLines = (BYTE)nTemp;
> }
>
> Well, that's fine for me, nTemp is effectively not initialized. And the
> second line is then the same as: rVal
Hi all, after looking at kcachegrind for a while, I found that a
significant amount of our startuptime comes from allocating string
memory and comparing strings 400k times, much of it reading the
configuration files. I just looked at the .xcd files now and of that I
focused on main.xcd because this
Hi Wol,
On 2010-11-23 at 20:49 +, Wols Lists wrote:
> > String aFoo = String::createFromAscii( "Something" )
> >
> > should be replaced, with
> >
> > String aFoo( RTL_CONSTASCII_USTRINGPARAM( "Something" ) )
>
> Fine. Fixes in base will appear as I spot them :-) Just one important
> little
On Thu, 2010-11-25 at 19:53 +0100, Pierre-André Jacquod wrote:
> Hello,
> thanks, will avoid some errors..
>
> I guess this is not (yet ?) enabled per default / per configure choices?
Not yet.
> Since I am very weak with make and such tools: any possibility to enable
> it per option when running
Hi Jonathan, *,
On Thu, Nov 25, 2010 at 1:50 PM, Jonathan Aquilina
wrote:
> im happy with the way things are done on mac, but the folder that has the
> licenses i didnt even bother looking at that folder hence the suggestion for
> a mac package that would install LO in the app folder.
I agree wi
-- Forwarded message --
From: Roth Robert
Date: Thu, Nov 25, 2010 at 9:27 PM
Subject: Extensions code cleanup
To: libreoffice@lists.freedesktop.org
Some more dead code and bogus comments removed from extensions. The license,
as always is LGPLv3+ / MPL.
From 550313e5020f855fd1a733
Some more dead code and bogus comments removed from extensions. The license,
as always is LGPLv3+ / MPL.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hello,
thanks, will avoid some errors..
I guess this is not (yet ?) enabled per default / per configure choices?
Since I am very weak with make and such tools: any possibility to enable
it per option when running ./autogen.sh ? Activated if possible during
the configure run? Or an other way to l
Hello,
as I said, still in warm up phase and getting back familiar with C++..
So cleaning is a good exercise.
I got a compiler warning:
filters/binfilter/bf_sw/source/core/para/sw_paratr.cxx:214:26: warning:
'nTemp' may be used uninitialized in this function
for this:
case MID_DROPCAP_LINES :
{
Hello Caolán,
> I suggest you cut and paste the header from
> http://www.freedesktop.org/wiki/Software/LibreOffice/LicenseHeader
> into the top of that new file and stick your name in there as the
> original contributor as it is new code.
Thanks, that means a lot to me. I've attached a patch whic
On Fri, 2010-10-15 at 19:23 +0200, André Schnabel wrote:
> Am 15.10.2010 17:21, schrieb Michael Meeks:
> > So - here is my suggestion ;-) hopefully it annoys everybody, and it is
> > two-fold.
..
> (no question on 1. - harden the code for migration)
> ...
> > 2. we continue to do automati
Hi,
yet another cleanup on base.
Cheers,
-- Takeshi Abe
>From dff2f8d6d37863a5517a412ea4f92ebdbee536ff Mon Sep 17 00:00:00 2001
From: Takeshi Abe
Date: Fri, 26 Nov 2010 01:45:21 +0900
Subject: [PATCH] Remove dead codes and undesired comments with fixed typo
---
dbaccess/source/ui/browser/sbagr
Hi Wols,
On Thu, 2010-11-25 at 16:31 +, Wols Lists wrote:
> Have we got a standard LibreOffice header to go into new files ?
Yes COPYING.NEWFILES in the toplevel has the stock header.
> If not, I'm quite happy to craft one, along with a policy that tells people
> what
> to do and h
On 25/11/10 14:47, Sebastian Spaeth wrote:
> Because it makes lifes more complex, see above? Do you really want
> file.cxx to start like this?
>
> /** 45 lines of this code come from Wol, who licensed them under the
> * BSD. But when you are reading this, it has been merged with 10 lines
> * con
On Thu, 25 Nov 2010 13:21:33 +, Wols Lists wrote:
> > and edited. Tracking which line of code is licensed under which license
> > combo is a job for lawyer detectives that nobody wants to pay in the
> > end. And most probably they could not give you definitive answers anyway
> > as that case ha
Hi Caolan,
On Thu, 2010-11-25 at 09:42 +, Caolán McNamara wrote:
> On Fri, 2010-11-19 at 15:37 +, Caolán McNamara wrote:
> > 3) We should probably instead modify InitializeQuickStartMode to
> > effectively || Sfx::ShutdownIcon::GetAutostart() with the IsQuickStart
> > command line argument
On Thu, 2010-11-25 at 13:14 +, Caolán McNamara wrote:
> This seems to work, e.g. the attached.
Looks great to me :-) [ still puzzling over the migration swamp
though ].
Regards,
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
Wols Lists 25/11/2010 14:21:
It's tricky, but imho the rule should be if you make a major
contribution to a file then you add your copyright notice. In general,
patches, fixes, etc shouldn't. And possibly we add a line that says
"copyright assorted contributors - see git history for details".
"
Hi Wols,
On Thu, 2010-11-25 at 13:21 +, Wols Lists wrote:
> But that's the point of using something like git :-)
True.
> Provided we have a policy that says "the project licence is X, all
> contributions must be compatible" I don't see that it matters WHAT
> licence contributors use.
Nice, thanks !
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Miklos,
On Thu, 2010-11-25 at 11:17 +0100, Miklos Vajna wrote:
> OK - I'm attaching an updated patch, containing the license.
Looks great to me; lets get it in ! :-)
Thanks,
Michael.
--
michael.me...@novell.com <><, Pseudo Engineer, itinerant idiot
_
Cheers,
Wol
>From 6642a11fbcfa7f2f4f35f5535ffe8c33fa856309 Mon Sep 17 00:00:00 2001
From: Wol
Date: Thu, 25 Nov 2010 13:04:08 +
Subject: [PATCH 4/4] Dead code deletion
---
dbaccess/source/ui/querydesign/JoinDesignView.cxx |1 -
dbaccess/source/ui/querydesign/QueryDesignView.cxx |1 -
On 23/11/10 15:15, Sebastian Spaeth wrote:
> While I personally don't mind BSD licenses, I don't think this helps
> your goal. The code is bound to be merged, overwritten, copied, moved
> and edited. Tracking which line of code is licensed under which license
> combo is a job for lawyer detectives
On Wed, 2010-11-24 at 20:50 +, Caolán McNamara wrote:
> On Wed, 2010-11-24 at 12:04 +0100, David Tardon wrote:
> > Does anyone have any clever idea how to prevent that?
>
> How about we over-engineer and..
>
> a) use osl_getModuleURLFromFunctionAddress or something of that nature
> to get the
On Mon, 2010-11-22 at 09:47 +0100, Gioele Barabucci wrote:
> in bug #31633 I proposed a patch to one of the export filters.
I've just committed it; sorry for delay.
It's great to have you prodding at this piece of the code. One of the
sad things about the XSLT filters is that the
im happy with the way things are done on mac, but the folder that has the
licenses i didnt even bother looking at that folder hence the suggestion for
a mac package that would install LO in the app folder.
On Thu, Nov 25, 2010 at 1:11 PM, Thorsten Behrens <
t...@documentfoundation.org> wrote:
> J
Chris Makepeace wrote:
> Libre Office (current) and OOo (3.2.1) is repeatedly crashing as I go into
> Preferences (Mac language for 'Options').
>
> The system console reports that the crash is related to JavaNativeFoundation
> and the crash log makes no mention of Java but does spend 771 lines
> r
Jonathan Aquilina wrote:
> hey guys i'm noticing something interesting. wouldn't it be better
> to use an installer to make sure the read me's as well as the
> licenses get installed in the LO directory. currently the way it is
> i don't have to drag either of them into the application directory.
>
Jonathan Aquilina wrote:
> hey guys is it possible to compile LO on mac osx? if so what
> dependencies does one need to satisfy before compiling it.
>
Hi Jonathan,
sure - please read up here for details:
http://wiki.documentfoundation.org/Development/How_to_build#Mac_OS_X
Don't hesitate to ask,
>>> On 2010-11-25 at 12:47, wrote:
> On Thu. 25.11.2010 10:19, Michael Meeks wrote:
>>> prompted by some complaints on too large icons on Mac, switched the
>>> icon size from 'large' to 'auto' for 3.3.
>>
>> Did we ever get some screenshots of the perceived problem ? I asked in
>> some bug, b
Hi Peter,
On Thu, 2010-11-25 at 11:47 +0100, Peter Lairo wrote:
> That's fine, but the large Icons are (about 50%) *too* large. I'm on
> Windows 7, have a 19" monitor, ratio: 4:5, resolution: 1280x1024 and I
> cannot fit the icons I want into the Toolbar.
From your screenshot: you are u
On Thu, Nov 25, 2010 at 03:33:08AM -0700, Tor Lillqvist
wrote:
> Sure, although I think I would prefer to keep OSL_THIS_FUNC as ""
> instead of "(unknown)" in the fallback case.
OK, I just changed that and pushed it.
> So, you think the i#114290 argument that neither __PRETTY_FUNCTION__
> nor _
On Thu. 25.11.2010 10:19, Michael Meeks wrote:
prompted by some complaints on too large icons on Mac, switched the
icon size from 'large' to 'auto' for 3.3.
Did we ever get some screenshots of the perceived problem ? I asked in
some bug, but never got that back AFAIR.
this was already
Michael Meeks wrote:
> > prompted by some complaints on too large icons on Mac, switched the
> > icon size from 'large' to 'auto' for 3.3.
>
> Did we ever get some screenshots of the perceived problem ? I asked in
> some bug, but never got that back AFAIR.
>
Hi Michael,
take my word for it
Hi,
Christian Lohmaier wrote on 2010-11-16 16.22:
Do we want to have a support.libreoffice.org subsite, or do we want to
havewww.libreoffice.org/support?
for now, I'd go with the latter one, but that's just my feeling...
Florian
--
Florian Effenberger
Steering Committee and Founding Member
> Tor was exercised about this at one stage IIRC, does the above work for you ?
Sure, although I think I would prefer to keep OSL_THIS_FUNC as "" instead of
"(unknown)" in the fallback case. Also, we need to find out if there really is
no __func__ or similar even in MSVC2010.
So, you think the
Hi Gert,
On Wed, 2010-11-03 at 18:28 +0100, Gert Faller wrote:
> I have erased the line :
> "m_aActionTbL.SetHelpId( HID_TEMPLDLG_TOOLBOX_LEFT );"
> in the patch file 2.
> A paste© error...
So - I notice this is still not merged; which is bad. Sorry for the
delay - clearly this got killed
On Thu, Nov 25, 2010 at 10:11:40AM +, Michael Meeks
wrote:
> Looks great to me; if we took this chunk of code from boost though - we
> should include the relevant boost license header and copyright statement
> at the end of that file, and separate out the section it applies to
> IMHO.
Hi Miklos,
On Wed, 2010-11-24 at 16:08 +0100, Miklos Vajna wrote:
> Both are just removing the __PRETTY_FUNCTION__ / etc expressions, which
> is not that good, I think.
:-)
> The attached patch tries to solve both problems, and of course
> build-tested.
> Does it look sane - may i push i
On Thu, Nov 25, 2010 at 10:51:05AM +0100, Sebastian Spaeth
wrote:
> On Thu, 25 Nov 2010 10:47:22 +0100, Sebastian Spaeth wrote:
> > > +#define OSL_LOG_PREFIX (OSL_THIS_FILE, ":", OSL_THIS_FUNC, ":",
> > > OSL_MACRO_VALUE_TO_STRING( __LINE__ ), "; ")
> >
> > On OOo there is a bug open to remove
On Thu, 25 Nov 2010 10:47:22 +0100, Sebastian Spaeth wrote:
> > +#define OSL_LOG_PREFIX (OSL_THIS_FILE, ":", OSL_THIS_FUNC, ":",
> > OSL_MACRO_VALUE_TO_STRING( __LINE__ ), "; ")
>
> On OOo there is a bug open to remove OSL_THIS_FUNC (or was it an Easy
> Hack) as it is not doing anyway what it is
On Thu, 21 Oct 2010 09:40:53 +0200, Thomas Klausner wrote:
> -#define OSL_LOG_PREFIX OSL_THIS_FILE ":" OSL_THIS_FUNC ":"
> OSL_MACRO_VALUE_TO_STRING( __LINE__ ) "; "
> +#define OSL_LOG_PREFIX (OSL_THIS_FILE, ":", OSL_THIS_FUNC, ":",
> OSL_MACRO_VALUE_TO_STRING( __LINE__ ), "; ")
On OOo there is
On Fri, 2010-11-19 at 15:37 +, Caolán McNamara wrote:
> 3) We should probably instead modify InitializeQuickStartMode to
> effectively || Sfx::ShutdownIcon::GetAutostart() with the IsQuickStart
> command line argument.
>
> If we were to do all through, the first thing people would notice is
>
Hi Michael,
Michael Meeks wrote (25-11-10 10:19)
I really think the small icons are a usability, and legibility disaster
when used on large screens - and there is a real risk of selecting them;
if the Mac people get their DPI settings together that's great, Linux
doesn't (of course).
[.
On Wed, 2010-11-24 at 16:08 +0100, Miklos Vajna wrote:
> 1) Need to use different exrepssions based on compiler. This is what
> boost/current_function.hpp does, but it's C++ and diagnose.h is used in
> C code as well.
Pity that boost stuffed it in under the c++ namespace directives,
otherwise coul
Hi there,
On Thu, 2010-11-25 at 00:36 +0100, Thorsten Behrens wrote:
> prompted by some complaints on too large icons on Mac, switched the
> icon size from 'large' to 'auto' for 3.3.
Did we ever get some screenshots of the perceived problem ? I asked in
some bug, but never got that back A
On Thu, 2010-11-25 at 00:36 +0100, Thorsten Behrens wrote:
> Hi,
>
> prompted by some complaints on too large icons on Mac, switched the
> icon size from 'large' to 'auto' for 3.3.
Oh good. I don't have any particular feeling for large vs small icons,
but I did want the default to be "auto" and t
Libre Office (current) and OOo (3.2.1) is repeatedly crashing as I go into
Preferences (Mac language for 'Options').
The system console reports that the crash is related to JavaNativeFoundation
and the crash log makes no mention of Java but does spend 771 lines
reporting a lot else.
iMac running
70 matches
Mail list logo
