Re: [Libreoffice] Minor translation, commented code removal

2010-10-18 Thread Kevin Hunter
At 1:55am -0400 Tue, 19 Oct 2010, Kevin Hunter wrote: As this weak coder starts out on a trek to help out, here are 3 minor patches against calc/sc/source/core/data/attarray.cxx. I tried to keep them separated logically, but wasn't quite perfect about it. $ pwd [...]/clone/calc $ git log -3 -p

Re: [Libreoffice] ODF thumbnailer for win32/osx

2010-10-18 Thread Michael Meeks
Hi Jon, On Sun, 2010-10-17 at 04:11 +0200, Jon Nordby wrote: > Does LibreOffice ship an ODF thumbnail implementation for > file-managers on Windows and Mac OSX? If so, where in the sources can > I find it? If not, can anyone point me to other implementations? Not that I know of though we

Re: [Libreoffice] build out of git repos - first steps

2010-10-18 Thread Michael Meeks
Hi Rajesh, First - great to see you again ! and thanks for getting involved with LibreOffice. I believe Cedric was looking into this issue and probably is the best guy to own it, nevertheless let me trample all over his turf - since he's not replied yet (AFAICS) :-) On Sun, 2010-10-17 at

Re: [Libreoffice] [PATCH] replaces elementsof with SAL_N_ELEMENTS

2010-10-18 Thread Michael Meeks
Hi there, On Sun, 2010-10-17 at 11:29 +0200, Kenneth Venken wrote: > these patches removes the elementsof macro, defined in > , and replaces it with the SAL_N_ELEMENTS > macro, defined in I -think- that we merged these as part of a subsequent patch from you ? at least, they seem fixed :-

Re: [Libreoffice] [PATCH] ure: Fix more typos in documentation

2010-10-18 Thread Michael Meeks
Hi there, On Mon, 2010-10-18 at 17:57 +0300, Aurimas Fišeras wrote: > > Much as I hate to say it (being English), we should use the US > > spellings consistently where possible :-) > > OK, here is the remaining part of that patch that changed spelling. Thanks :-) pushed,

Re: [Libreoffice] Changing patches

2010-10-18 Thread Michael Meeks
Hi Thomas, On Mon, 2010-10-18 at 23:40 +0200, Thomas Klausner wrote: > I tried untarring the SampleIcc distfile and then just applying > clone/libs-extern/icc/SampleICC-1.3.2.patch on top of it using patch > -p2 inside the directory, as a first step so that I could change it > and generate a new p

Re: [Libreoffice] Fwd: CLang++ Analysis

2010-10-18 Thread Seo Sanghyeon
2010/10/18 Caolán McNamara : > Looks good, the good news is that the vast majority are in the third > party modules, e.g. mozilla, lpsolve, berkleydb. I was able to fix a few > that belonged to us, e.g. soltools, sal etc. Though there's still a good > few remaining. I think this is because only C

Re: [Libreoffice] [PATCH] replacing elementsof in win32 tree

2010-10-18 Thread Norbert Thiebaud
On Mon, Oct 18, 2010 at 6:51 PM, Bircher Florian wrote: >  some build breakers Pushed, Thanks Florian. Norbert > > #include  has now #include > (commit from shm_get) > > todo: > so a next step would be remove all #include where already > is a #include > > > commint under lgpl v3 > > > > ___

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Thorsten Behrens
Michael Meeks wrote: > Everything except the 'filters' patch has been either pushed, or sent > to the component maintainer for review. > libs-gui parts (basebmp & basegfx) just pushed. Kept a few useful bits in the */test, */workben subdirs, those are often playgrounds / staging areas for co

[Libreoffice] [PATCH] replacing elementsof in win32 tree

2010-10-18 Thread Bircher Florian
some build breakers #include has now #include (commit from shm_get) todo: so a next step would be remove all #include where already is a #include commint under lgpl v3 diff --git a/desktop/win32/source/guistdio/guistdio.inc b/desktop/win32/source/guistdio/guistdio.inc index 7009b24..05

Re: [Libreoffice] Building on gentoo ...

2010-10-18 Thread Norbert Thiebaud
On Mon, Oct 18, 2010 at 5:10 PM, Anthony Youngman wrote: >  Just tried to build libreoffice on gentoo. All the pre-requisites > should be there, given that I've done an "emerge openoffice". But it > falls over ... > > checking for Qt headers... no > configure: error: Qt headers not found.  Please

Re: [Libreoffice] Building on gentoo ...

2010-10-18 Thread René Kjellerup
I've build on gentle, I had to disable kde to do so "--enable-kde=no --enable-kde4=no --without-junit" The Bests René On Oct 19, 2010 12:29 AM, "Anthony Youngman" wrote: > Just tried to build libreoffice on gentoo. All the pre-requisites > should be there, given that I've done an "emerge openoffi

[Libreoffice] Building on gentoo ...

2010-10-18 Thread Anthony Youngman
Just tried to build libreoffice on gentoo. All the pre-requisites should be there, given that I've done an "emerge openoffice". But it falls over ... checking for Qt headers... no configure: error: Qt headers not found. Please specify the root of your Qt installation by exporting QTDIR before ru

Re: [Libreoffice] Changing patches

2010-10-18 Thread Thomas Klausner
On Mon, Oct 18, 2010 at 05:45:56PM +0100, Michael Meeks wrote: > We have to edit the patch; icc is one of our 'external' components, so > we have the pristine source archive, and then patch it with our internal > patch as part of the build. > > So - we would need to alter the patch. Th

[Libreoffice] Turkish translation mailing list

2010-10-18 Thread Gökcen Eraslan
Hello, Can you also create a mailing list[1] for Turkish LibreOffice translations? Thanks. [1] http://wiki.documentfoundation.org/Local_Mailing_Lists -- Gökcen Eraslan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.free

Re: [Libreoffice] [PATCH] SAL_N_ELEMENTS for ure

2010-10-18 Thread Michael Meeks
Hi there, On Mon, 2010-10-18 at 13:50 +0200, Kenneth Venken wrote: > this patch replaces all occurrences of sizeof.*/.*sizeof.*\[ with > SAL_N_ELEMENTS in ure Thanks - there were a few sillies in there: #include an ommitted include, and one other build-break I forgot ;-

Re: [Libreoffice] Changing patches

2010-10-18 Thread Giuseppe Castagno
Hi Michael, Thomas, ... So - we would need to alter the patch. That leads to some diffs of diffs problem, but ... hopefully there is some --with-system-icc variant that could be used, if indeed the patches don't change its behaviour in some unpleasant way. That piece of software (icc

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Kohei Yoshida
On Mon, 2010-10-18 at 16:53 +0100, Michael Meeks wrote: > Everything except the 'filters' patch has been either pushed, > or sent > to the component maintainer for review. And I'm reviewing the calc part of your patch. At first glance there are several hunks that I'd like to keep, but I'

Re: [Libreoffice] Changing patches

2010-10-18 Thread Michael Meeks
Hi Thomas, On Mon, 2010-10-18 at 17:43 +0200, Thomas Klausner wrote: > One of the issues I see is in SampleICC, where Vetters.cpp includes > on Solaris and on all other non-Windows. riight - hmm. > On NetBSD, it also needs to include errno.h to compile. I could add an > #if NetBSD to t

Re: [Libreoffice] [For Review] mer of most vos-removal patches left. and little related houskeeping

2010-10-18 Thread Jan Holesovsky
Hi Norbert, First of all - impressive, thanks a lot! Unfortunately, I wasn't able to review your patches today, but tomorrow I am traveling, and I'll take your branch as the 'reading on the bus' ;-) & come back to you. On 2010-10-18 at 14:57 +0100, Michael Meeks wrote: > > I wonder, is there a

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Povilas Kanapickas
> I was also interested in things like the UI string changes > in binfilters - what was all that about ? :-) That was certainly not intended. It seems my editor has screwed up as it somehow didn't like some files. It couldn't open them using UTF-8, so I forced another encoding. That might be the

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Povilas Kanapickas
> Ok - so, one thing that is helpful is: if you use a script - can you > post the script instead of a patch ? :-) that way we save a lot of > reviewer time. > I used a graphical find/replace manager. I don't remember how exactly the regexp looked, but at first I removed all '/*.*/ ' commen

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Michael Meeks
Hi there, On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote: > I've done some work on entry level tasks. Specifically, I've removed > all #if 0 blocks in the LibreOffice source tree. So - I did some more review; I left a few useful / commented pieces in that were removed, but so

[Libreoffice] Changing patches

2010-10-18 Thread Thomas Klausner
Hi! One of the issues I see is in SampleICC, where Vetters.cpp includes on Solaris and on all other non-Windows. On NetBSD, it also needs to include errno.h to compile. I could add an #if NetBSD to the Solaris case, but I don't think that sys/errno.h is standardized and thus prefer to make it i

Re: [Libreoffice] 3rd week development summary

2010-10-18 Thread Petr Mladek
Michael Meeks píše v Po 18. 10. 2010 v 15:49 +0100: > Hi Petr, > > On Mon, 2010-10-18 at 14:52 +0200, Petr Mladek wrote: > > again a brief summary of what happened the 3rd week on LibreOffice > > repos: > > Are we including commits to the 'build' module ? I think that Thorsten did not incl

Re: [Libreoffice] [PATCH] ure: Fix more typos in documentation

2010-10-18 Thread Aurimas Fišeras
2010.10.18 12:37, Michael Meeks rašė: > Hi Aurimas, > > On Sun, 2010-10-17 at 17:44 +0300, Aurimas Fišeras wrote: >> There are files where both spellings are used in the same file. Which >> spelling should be used in this case? > > Much as I hate to say it (being English), we should use the

Re: [Libreoffice] 3rd week development summary

2010-10-18 Thread Michael Meeks
Hi Petr, On Mon, 2010-10-18 at 14:52 +0200, Petr Mladek wrote: > again a brief summary of what happened the 3rd week on LibreOffice > repos: Are we including commits to the 'build' module ? Thanks, Michael. -- michael.me...@novell.com <><, Pseudo Engineer, it

Re: [Libreoffice] Fwd: CLang++ Analysis

2010-10-18 Thread Caolán McNamara
On Mon, 2010-10-18 at 07:43 -0700, Joseph Powers wrote: > > I placed a copy of my build results at: http://jpowers.me Looks good, the good news is that the vast majority are in the third party modules, e.g. mozilla, lpsolve, berkleydb. I was able to fix a few that belonged to us, e.g. soltools, s

[Libreoffice] Fwd: CLang++ Analysis

2010-10-18 Thread Joseph Powers
Begin forwarded message: > From: Joseph Powers > Date: October 18, 2010 7:32:55 AM PDT > To: libreoffice-requ...@lists.freedesktop.org > Subject: CLang++ Analysis > > The build process is easy: > > Download the CLang analyzer > Unpack it somewhere > Add somewhere to your path. > > I unpacked

Re: [Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Michael Meeks
Hi there, On Mon, 2010-10-18 at 16:06 +0300, Povilas Kanapickas wrote: > I've done some work on entry level tasks. Specifically, I've removed > all #if 0 blocks in the LibreOffice source tree. Wow. > Also, a lot of bogus comments like /*N*/, /*?*/ and so on were > removed. Ok -

Re: [Libreoffice] [PATCH] RTF: fix non-text frames

2010-10-18 Thread Cedric Bosdonnat
Hi Miklos, it seems to be good, go ahead. On Mon, 2010-10-18 at 13:59 +0200, Miklos Vajna wrote: > Hi Cedric, > > I'm attaching a patch that fixes a crash on non-text frames when > exporting as RTF. > > A reproducer is here: > > http://cgit.freedesktop.org/~vmiklos/ooo-gsoc/tree/writer/21976.d

Re: [Libreoffice] PATCH

2010-10-18 Thread Michael Meeks
Hi Julio, On Sun, 2010-10-17 at 17:58 -0300, Júlio Hoffimann wrote: > My first time contributing with an open source project. I hope to help > with a little. Wow - this is a great first contribution ! :-) > Patch2: Cleanup comments and some formatting. So - I had a good go at th

Re: [Libreoffice] [For Review] mer of most vos-removal patches left. and little related houskeeping

2010-10-18 Thread Michael Meeks
On Mon, 2010-10-18 at 06:38 -0500, Norbert Thiebaud wrote: > Worked like a charm... and so much faster that make dev-install and > hand 'testing' Good stuff :-) > I wonder, is there a way to avoid the whole rpm churning at then end > of the build (the 'building module packimages' at the

[Libreoffice] [PATCH] removed a lot of dead code and bogus comments

2010-10-18 Thread Povilas Kanapickas
Hello, I've done some work on entry level tasks. Specifically, I've removed all #if 0 blocks in the LibreOffice source tree. Also, a lot of bogus comments like /*N*/, /*?*/ and so on were removed. As more than thousand of files have been changed I didn't try to make a separate patch for each one.

[Libreoffice] 3rd week development summary

2010-10-18 Thread Petr Mladek
Hi, again a brief summary of what happened the 3rd week on LibreOffice repos: bugfixes-week-41.txt all commits that reference a proper bug id (from a variety of trackers - #i... referring to the OpenOffice issuezilla, fdo# to freedesktop, rhbz# to RedHat bugzilla etc) commit-log-week-41.txt list

Re: [Libreoffice] [LibreOffice][PATCH] Fixes Compiler Warning

2010-10-18 Thread Caolán McNamara
On Sat, 2010-10-16 at 00:11 +0200, Kenneth Venken wrote: > because sequence checking should only be turned on for certain languages > like Thai, Laotian, Khmer or Vietnamese and only when CTL is enabled. > So, if CTL support is checked, we only need to check for sequence > checking if: previously

[Libreoffice] [PATCH] RTF: fix non-text frames

2010-10-18 Thread Miklos Vajna
Hi Cedric, I'm attaching a patch that fixes a crash on non-text frames when exporting as RTF. A reproducer is here: http://cgit.freedesktop.org/~vmiklos/ooo-gsoc/tree/writer/21976.doc?h=ooo-test-files OK to push? :) From 1bcf42ef0f2310a4aee05053a21ad4da6decf3ec Mon Sep 17 00:00:00 2001 From: Mi

[Libreoffice] [PATCH] SAL_N_ELEMENTS for ure

2010-10-18 Thread Kenneth Venken
Hi, this patch replaces all occurrences of sizeof.*/.*sizeof.*\[ with SAL_N_ELEMENTS in ure -- Kenneth diff --git a/sal/inc/systools/win32/uwinapi.h b/sal/inc/systools/win32/uwinapi.h index 6c19788..7fda61e 100644 --- a/sal/inc/systools/win32/uwinapi.h +++ b/sal/inc/systools/win32/uwinapi.h @@ -1

Re: [Libreoffice] [PATCH] Remove bogus version control comments

2010-10-18 Thread Michael Meeks
Hi Mattias, On Mon, 2010-10-18 at 10:22 +1100, Mattias Johnsson wrote: > Second time submitting this patch to the list - the first time I > forgot [Libreoffice] in the subject line and presume it got eaten by > people's spam filters! Nah ! that is fine, it is possible the list is configur

Re: [Libreoffice] [For Review] mer of most vos-removal patches left. and little related houskeeping

2010-10-18 Thread Norbert Thiebaud
On Mon, Oct 18, 2010 at 4:53 AM, Caolán McNamara wrote: > On Sat, 2010-10-16 at 15:21 -0500, Norbert Thiebaud wrote: >> I've pushed the branch 'feature/vos-removal' for review >> I have rebased against master Saturday morning GMT, with relatively >> few conflict. >> >> The resulting build passed a

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Thomas Klausner
On Mon, Oct 18, 2010 at 12:21:52PM +0100, Caolán McNamara wrote: > On Mon, 2010-10-18 at 13:15 +0200, Thomas Klausner wrote: > > On Mon, Oct 18, 2010 at 12:01:15PM +0100, Caolán McNamara wrote: > > > Did you configure with --with-system-boost ? There's a test in > > > configure.in for a broken boos

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Caolán McNamara
On Mon, 2010-10-18 at 13:15 +0200, Thomas Klausner wrote: > On Mon, Oct 18, 2010 at 12:01:15PM +0100, Caolán McNamara wrote: > > Did you configure with --with-system-boost ? There's a test in > > configure.in for a broken boost header. > > Yes, I'm using system boost. I know you're using system b

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Thomas Klausner
On Mon, Oct 18, 2010 at 12:01:15PM +0100, Caolán McNamara wrote: > Did you configure with --with-system-boost ? There's a test in > configure.in for a broken boost header. Yes, I'm using system boost. > Another thing to check is what happens if you add > > $(SLO)$/zforfind.obj > > to the EXCEPT

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Caolán McNamara
On Mon, 2010-10-18 at 12:54 +0200, Thomas Klausner wrote: > On Mon, Oct 18, 2010 at 11:14:25AM +0100, Caolán McNamara wrote: > > Why did you add -fexceptions to the arguments ?, I ask because there are > > places in LibreOffice where its explicitly enabled, and others where its > > explicitly disab

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Thomas Klausner
On Mon, Oct 18, 2010 at 11:14:25AM +0100, Caolán McNamara wrote: > Why did you add -fexceptions to the arguments ?, I ask because there are > places in LibreOffice where its explicitly enabled, and others where its > explicitly disabled, so globally enabling it wouldn't be something > typically tes

Re: [Libreoffice] Croatian translation of LO-3.2.99.2

2010-10-18 Thread Cedric Bosdonnat
On Wed, 2010-10-13 at 10:40 +0200, Robert Sedak wrote: > Hi all, > > I prepaired Croatian translation and gsicgeck of LO-3.2.99.2. > You can get sdf on http://www.roby.hr/libreoffice/ You should work using the po files located in http://cgit.freedesktop.org/libreoffice/build/tree/po Did you try

Re: [Libreoffice] [PATCH] SAL_N_ELEMENTS in testing and sdk

2010-10-18 Thread David Tardon
On Mon, Oct 18, 2010 at 12:18:23PM +0200, Kenneth Venken wrote: > Hi, > > patches replace sizeof/sizeof[0] with SAL_N_ELEMENTS in testing and sdk > > -- Kenneth Thanks! Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://l

Re: [Libreoffice] [PATCH] SAL_N_ELEMENTS for libs-gui

2010-10-18 Thread David Tardon
On Mon, Oct 18, 2010 at 11:54:32AM +0200, Kenneth Venken wrote: > Hi, > > this patch replaces all hits for "sizeof.*/.*sizeof.*\[" with > SAL_N_ELEMENTS in libs-gui. > > -- Kenneth Thanks! Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.free

Re: [Libreoffice] Don't show a perl error when .NET SDK is not found

2010-10-18 Thread Cedric Bosdonnat
Hi Jesus, On Fri, 2010-10-15 at 23:51 +0200, Jesús Corrius wrote: > Hi all, > > This trival patch hides a perl error in oowintool when the .NET SDK is > not found in the system. Where is the patch ;) You may have forgotten to attach it to the email. Regards, -- Cédric Bosdonnat LibreOffice ha

Re: [Libreoffice] The Windows installer

2010-10-18 Thread Michael Meeks
Hi Cesare, On Sun, 2010-10-17 at 15:16 +0200, Cesare Leonardi wrote: > In my opinion: > > * 320 MB for an installer is too much. If you don't have a fast internet > access or if you have a mobile provider that gives you time/data limit, > probably you'd have to find another way to get LibreOffi

[Libreoffice] [PATCH] SAL_N_ELEMENTS in testing and sdk

2010-10-18 Thread Kenneth Venken
Hi, patches replace sizeof/sizeof[0] with SAL_N_ELEMENTS in testing and sdk -- Kenneth diff --git a/odk/examples/OLE/activex/SOComWindowPeer.cpp b/odk/examples/OLE/activex/SOComWindowPeer.cpp index 0b2fabf..a3f4d50 100644 --- a/odk/examples/OLE/activex/SOComWindowPeer.cpp +++ b/odk/examples/OLE/a

Re: [Libreoffice] boost exceptions

2010-10-18 Thread Caolán McNamara
On Sun, 2010-10-17 at 23:36 +0200, Thomas Klausner wrote: > As you can see, I already added "-fexceptions" to the g++ arguments. Why did you add -fexceptions to the arguments ?, I ask because there are places in LibreOffice where its explicitly enabled, and others where its explicitly disabled, so

Re: [Libreoffice] [LibreOffice][PATCH] compiler warnings inftxt.hxx

2010-10-18 Thread Caolán McNamara
On Sat, 2010-10-16 at 01:01 +0200, Kenneth Venken wrote: > some "shadows a member of 'this'" and "unused parameter" warnings. The binfilter is rather unloved, its effectively a copy of older versions of sw/sd/sc and their dependencies, so if you see a warning in binfilter and want to fix it, you c

Re: [Libreoffice] [For Review] mer of most vos-removal patches left. and little related houskeeping

2010-10-18 Thread Caolán McNamara
On Sat, 2010-10-16 at 15:21 -0500, Norbert Thiebaud wrote: > I've pushed the branch 'feature/vos-removal' for review > I have rebased against master Saturday morning GMT, with relatively > few conflict. > > The resulting build passed a trivial 'smoketest' (openining a couple > of spreadsheet, text

Re: [Libreoffice] yum-builddep question ...

2010-10-18 Thread Michael Meeks
Hi Terrell, On Sat, 2010-10-16 at 18:59 -0400, Terrell Prude' Jr. wrote: > Actually, I'm not much of a hacker at all, more a systems engineer who > can shell-script. Great :-) then it should be easy (?) to add some funky script that will detect your system, and check that the right buil

Re: [Libreoffice] [PATCH] ure: Fix more typos in documentation

2010-10-18 Thread Michael Meeks
Hi Aurimas, On Sun, 2010-10-17 at 17:44 +0300, Aurimas Fišeras wrote: > There are files where both spellings are used in the same file. Which > spelling should be used in this case? Much as I hate to say it (being English), we should use the US spellings consistently where possible :-) An

Re: [Libreoffice] The Windows installer

2010-10-18 Thread Tor Lillqvist
> * 320 MB for an installer is too much. If you don't have a fast internet > access or if you have a mobile provider that gives you time/data limit, > probably you'd have to find another way to get LibreOffice. I can see that the size is an issue, but not because of download time. 320 MB is app

Re: [Libreoffice] yum-builddep question ...

2010-10-18 Thread Sebastian Spaeth
On Sat, 16 Oct 2010 18:59:28 -0400, "Terrell Prude' Jr." wrote: > Actually, I'm not much of a hacker at all, more a systems engineer who > can shell-script. But I figure I could do some of the non-sexy, > janitorial "easy tasks" like getting rid of those "don't trust revision > control" comme