Re: [Libreoffice] [PATCH] Fix sc build

2010-10-17 Thread David Tardon
On Sun, Oct 17, 2010 at 09:46:26PM +0200, Miklos Vajna wrote: > Hi David, > > Your recent commit which removed solenv/inc/sc.mk and > solenv/inc/scpre.mk in bootstrap.git breaks the build of sc here. > > Given that the change is in makefile.mk files, tinderbox won't notice > it, I assume. ;) >

[Libreoffice] [PATCH] Remove bogus version control comments

2010-10-17 Thread Mattias Johnsson
Second time submitting this patch to the list - the first time I forgot [Libreoffice] in the subject line and presume it got eaten by people's spam filters! Fairly trivial patch removing bogus version control comments, in order to test and get to know the build / git management / patch generation

Re: [Libreoffice] PATCH

2010-10-17 Thread Norbert Thiebaud
2010/10/17 Júlio Hoffimann : > Hi, > My first time contributing with an open source project. I hope to help with > a little. Hi julio. Thanks for you patches. > Patch1: Some translate. I pushed part of this one. I selected the removal, instead of the translation of some of these comment (Created

Re: [Libreoffice] [Pushed][PATCH] unused macro bufsizeof

2010-10-17 Thread Norbert Thiebaud
On Sun, Oct 17, 2010 at 2:39 PM, Kenneth Venken wrote: > Hi, > > this patch removes the unused bufsizeof macro. Pushed, thanks. Norbert > > BTW, this patch and all other patches submitted by me to be used in > LibreOffice are released under LGPLv3+. > > -- Kenneth > > >

Re: [Libreoffice] [PATCH]replaces ELEMENTS_OF_ARRAY with SAL_N_ELEMENTS

2010-10-17 Thread Norbert Thiebaud
On Sun, Oct 17, 2010 at 2:21 PM, Kenneth Venken wrote: > replaces the ELEMENTS_OF_ARRAY macro, defined in sal/osl/os2/file_url.h, > with the SAL_N_ELEMENTS, defined in sal/macros.h > > Thanks. Pushed except for one chunk: Be careful with 'replace all' :-) @ -48,11 +48,11 @@ #ifdef __MINGW32__

Re: [Libreoffice] [Pushed][PATCH] Filters - Remove unnecessary comments from sw_unotbl.cxx

2010-10-17 Thread Norbert Thiebaud
On Sun, Oct 17, 2010 at 2:59 PM, jgraeme wrote: > A patch to remove commented out code & unnecessary comments. Pushed, Thanks. > > Graeme > > ___ > LibreOffice mailing list > LibreOffice@lists.freedesktop.org > http://lists.freedesktop.org/mailman/lis

[Libreoffice] boost exceptions

2010-10-17 Thread Thomas Klausner
Hi again! Another step ahead; using only ENVLINKFLAGS and not ENVLIBFLAGS, I avoided the ar problem. I'm trying to build against the external boost libraries and see: Compiling: svl/source/numbers/zforfind.cxx g++ -fmessage-length=0 -c -O1 -DENABLE_LAYOUT=0 -DENABLE_LAYOUT_EXPERIMENTAL=0 -fex

Re: [Libreoffice] error in put()

2010-10-17 Thread Thomas Klausner
On Sun, Oct 17, 2010 at 06:13:52PM +0200, Thomas Klausner wrote: > /disk/2/archive/libreoffice/build/libreoffice-3.2.99.2/l10ntools/source/help/HelpLinker.cxx: > In member function 'void HelpKeyword::dump(DB*)': > /disk/2/archive/libreoffice/build/libreoffice-3.2.99.2/l10ntools/source/help/HelpLin

[Libreoffice] [PATCH] Fix sc build

2010-10-17 Thread Miklos Vajna
Hi David, Your recent commit which removed solenv/inc/sc.mk and solenv/inc/scpre.mk in bootstrap.git breaks the build of sc here. Given that the change is in makefile.mk files, tinderbox won't notice it, I assume. ;) I'm attaching a patch that fixes the problem for me. OK to push? Thanks, Mik

[Libreoffice] [PATCH] unused macro bufsizeof

2010-10-17 Thread Kenneth Venken
Hi, this patch removes the unused bufsizeof macro. BTW, this patch and all other patches submitted by me to be used in LibreOffice are released under LGPLv3+. -- Kenneth diff --git a/sal/osl/w32/module.cxx b/sal/osl/w32/module.cxx index 57ec786..ad67487 100644 --- a/sal/osl/w32/module.cxx +++ b

[Libreoffice] [PATCH]replaces ELEMENTS_OF_ARRAY with SAL_N_ELEMENTS

2010-10-17 Thread Kenneth Venken
replaces the ELEMENTS_OF_ARRAY macro, defined in sal/osl/os2/file_url.h, with the SAL_N_ELEMENTS, defined in sal/macros.h diff --git a/sal/osl/os2/file_url.cxx b/sal/osl/os2/file_url.cxx index 04d103a..6ea7490 100644 --- a/sal/osl/os2/file_url.cxx +++ b/sal/osl/os2/file_url.cxx @@ -52,6 +52,7 @@

Re: [Libreoffice] [PATCH, EasyHack] Fix for setup_native win32 SAL_N_ELEMENTS

2010-10-17 Thread Norbert Thiebaud
On Sat, Oct 16, 2010 at 2:51 PM, Michael Meeks wrote: > Hi Florian,. > > On Sat, 2010-10-16 at 17:34 +0200, Bircher Florian wrote: >> Reason: missing #include > >        Looks like someone merged your commit :-) Look like I forgot to reply-to-ALL again :-( Norbert > >        Thanks, > >      

Re: [Libreoffice] Newbie dev question: no "rawbuild" directory after git clone

2010-10-17 Thread David Norton
I've updated http://wiki.documentfoundation.org/Development#Required_Libraries.2FDeps to tell the developer to run make in loroot if rawbuild does not exist. This will create rawbuild. (at least, it did in my test.) Almost done installing LibreOffice on my end. David Norton On Sat, Oct 16, 2

[Libreoffice] error in put()

2010-10-17 Thread Thomas Klausner
On Sun, Oct 17, 2010 at 05:58:23PM +0200, Thomas Klausner wrote: > With some help from Fridrich, we found that it wanted to use the > external one, but still doesn't respect LDFLAGS here. Setting > ENVLINKFLAGS solved this problem. > > Fails later now, though: > Making:libstdstrm.a > ar -r -L/

Re: [Libreoffice] missing libicui18n

2010-10-17 Thread Norbert Thiebaud
On Sun, Oct 17, 2010 at 9:37 AM, Thomas Klausner wrote: > Hi! > > I hacked around a few build issues (I'm not yet sure how to handle the > rpath issues, ignore the -Wl,-R parts below), now the build fails for > me with: > > Entering > /disk/2/archive/libreoffice/build/libreoffice-3.2.99.2/i18npoo

[Libreoffice] ODF thumbnailer for win32/osx

2010-10-17 Thread Jon Nordby
Does LibreOffice ship an ODF thumbnail implementation for file-managers on Windows and Mac OSX? If so, where in the sources can I find it? If not, can anyone point me to other implementations? -- Regards Jon Nordby - www.jonnor.com ___ LibreOffice maili

Re: [Libreoffice] [PATCH] ure: Fix more typos in documentation

2010-10-17 Thread Norbert Thiebaud
On Sun, Oct 17, 2010 at 9:44 AM, Aurimas Fišeras wrote: > 2010.10.17 17:15, Norbert Thiebaud rašė: >> On Sun, Oct 17, 2010 at 6:35 AM, Aurimas Fišeras wrote: >>> >>> Fixes more typos in documentation. >> >> Aurimas, >> >> Thanks for the patch. >> >> I partially merged it, based on the following c

Re: [Libreoffice] missing libicui18n

2010-10-17 Thread Thomas Klausner
On Sun, Oct 17, 2010 at 04:37:29PM +0200, Thomas Klausner wrote: > And it's true, there is no libicui18n* anywhere. How should it have been > built? With some help from Fridrich, we found that it wanted to use the external one, but still doesn't respect LDFLAGS here. Setting ENVLINKFLAGS solved t

Re: [Libreoffice] [PATCH] ure: Fix more typos in documentation

2010-10-17 Thread Aurimas Fišeras
2010.10.17 17:15, Norbert Thiebaud rašė: > On Sun, Oct 17, 2010 at 6:35 AM, Aurimas Fišeras wrote: >> >> Fixes more typos in documentation. > > Aurimas, > > Thanks for the patch. > > I partially merged it, based on the following criteria: > > 1/ we can't have unicode characters in the source c

[Libreoffice] missing libicui18n

2010-10-17 Thread Thomas Klausner
Hi! I hacked around a few build issues (I'm not yet sure how to handle the rpath issues, ignore the -Wl,-R parts below), now the build fails for me with: Entering /disk/2/archive/libreoffice/build/libreoffice-3.2.99.2/i18npool/source/indexentry Making:genindex_data unx g++ -Wl,-z,combreloc

Re: [Libreoffice] [PATCH] ure: Fix more typos in documentation

2010-10-17 Thread Norbert Thiebaud
On Sun, Oct 17, 2010 at 6:35 AM, Aurimas Fišeras wrote: > > Fixes more typos in documentation. Aurimas, Thanks for the patch. I partially merged it, based on the following criteria: 1/ we can't have unicode characters in the source code, so I did not merge "Bézier" which showed up as Bzier.

Re: [Libreoffice] [Pushed] [PATCH]SAL_N_ELEMENTS

2010-10-17 Thread Norbert Thiebaud
On Sat, Oct 16, 2010 at 7:13 PM, Kenneth Venken wrote: > Hi, > > some patches to fix EASY HACK 2.6 Pushed, Thanks. Norbert > > found some equivalent macros: >        - elementsof >        - ELEMENTS_OF_ARRAY >        - bufsizeof > > i'll try and replace them all with SAL_N_ELEMENTS tomorrow. >

Re: [Libreoffice] The Windows installer

2010-10-17 Thread Cesare Leonardi
On 10/14/2010 12:00 PM, Tor Lillqvist wrote: I see that it's an installer that includes all the languages but i wonder if it is really necessary and if the languages are the only cause. Well, there certainly isn't hundreds (or even tens) of megabytes of new code, as far as I know, so yes, it mu

[Libreoffice] [PATCH] Remove bogus version control comments

2010-10-17 Thread Mattias Johnsson
Fairly trivial patch removing bogus version control comments, in order to test and get to know the build / git management / patch generation and submission process. Patch is contributed under the LGPLv3+. If the format is incorrect and should be submitted another way, please let me know! From 34f

[Libreoffice] Fwd: [For Review] merge of most vos-removal patches left. and little related housekeeping

2010-10-17 Thread Norbert Thiebaud
I've pushed the branch 'feature/vos-removal' for review I have rebased against master Saturday morning GMT, with relatively few conflict. The resulting build passed a trivial 'smoketest' (openining a couple of spreadsheet, text document ...) I have NOT built against Win or MacOS... there are almo

[Libreoffice] [PATCH] replaces elementsof with SAL_N_ELEMENTS

2010-10-17 Thread Kenneth Venken
Hi, these patches removes the elementsof macro, defined in , and replaces it with the SAL_N_ELEMENTS macro, defined in Kenneth diff --git a/crashrep/source/win32/soreport.cpp b/crashrep/source/win32/soreport.cpp index f7918ee..bb4821b 100644 --- a/crashrep/source/win32/soreport.cpp +++ b/crashre

[Libreoffice] [For Review] mer of most vos-removal patches left. and little related houskeeping

2010-10-17 Thread Norbert Thiebaud
I've pushed the branch 'feature/vos-removal' for review I have rebased against master Saturday morning GMT, with relatively few conflict. The resulting build passed a trivial 'smoketest' (openining a couple of spreadsheet, text document ...) I have NOT built against Win or MacOS... there are almo

Re: [Libreoffice] [PATCH] More dead code removal under connectivity

2010-10-17 Thread David Tardon
On Sun, Oct 17, 2010 at 08:04:27PM +1300, Luke Symes wrote: > This patch cleans up miscellaneous dead code in libs-core/connectivity/*. Thanks! Pushed. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailma

Re: [Libreoffice] C{,PP}FLAGS ignored in sal

2010-10-17 Thread David Tardon
On Fri, Oct 15, 2010 at 06:48:34PM +0200, Thomas Klausner wrote: > On Fri, Oct 15, 2010 at 01:22:46PM +0200, David Tardon wrote: > > There is ENVCFLAGS for flags to add to $CC and ENVCFLAGSCXX for flags > > to add to $CXX . > > That's a very good tip, thank you. > > Why aren't the environment's C

[Libreoffice] [PATCH] More dead code removal under connectivity

2010-10-17 Thread Luke Symes
This patch cleans up miscellaneous dead code in libs-core/connectivity/*. From 73220a35215bdc6ae195ddf6cd2775dd15c966e4 Mon Sep 17 00:00:00 2001 From: Luke Symes Date: Sun, 17 Oct 2010 20:01:58 +1300 Subject: [PATCH] Cleanup some more dead code under connectivity. --- avmedia/source/gstreamer/gs