ping!
On Fri, Jul 5, 2019 at 9:31 AM Fabiano Fidêncio wrote:
>
> Similarly to what we have for media, let's add the "os" property to the
> trees.
>
> osinfo-detect code is already relying on having an "os" property and,
> since commit 722e7d1d4, it errors out due to the missing property:
>
> (osi
Both trees & medias may return NULL in case no os-variant was found.
Let's check for this and avoid a segmentation fault on calling
osinfo_list_get_length() with a NULL argument.
Signed-off-by: Fabiano Fidêncio
---
tools/osinfo-detect.c | 12
1 file changed, 8 insertions(+), 4 delet
Otherwise we'll end up reaching:
g_task_return_error: assertion 'task->ever_returned' failed.
Signed-off-by: Fabiano Fidêncio
---
This patch fixes the CI breakage with virt-manager and will be pushed
soon.
---
osinfo/osinfo_tree.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --g
On Wednesday, 17 July 2019 12:18:26 CEST Fabiano Fidêncio wrote:
> Otherwise we'll end up reaching:
> g_task_return_error: assertion 'task->ever_returned' failed.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> This patch fixes the CI breakage with virt-manager and will be pushed
> soon.
> ---
> osi
Those patches (partially) the breakage caused on virt-manager's tests
caught by libvirt-jenkins-ci.
There's still an issue happening, which I'm investigating, that I'm
getting a SIGTERM when running testCLI0450virt_convert
It also seems to be related to the latest tree libsoup related patches
on
When calling a g_task_return_error(), we should also cleanup the
CreateFromLocationAsyncData and return immediately after that.
By doing so we avoid errors as:
g_task_return_error: assertion 'task->ever_returned' failed.
Signed-off-by: Fabiano Fidêncio
---
osinfo/osinfo_tree.c | 2 ++
1 file ch
Instead of just free'ing the CreateFromLocationAsyncData, let's just go
to cleanup, which will call create_from_location_async_data_free() and
return after that.
By doing so we avoid errors as:
g_task_return_error: assertion 'task->ever_returned' failed.
Signed-off-by: Fabiano Fidêncio
---
osin
We should check whether the objects are NULL or not before calling
g_object_unref(). Instead of doing so, let's use g_clear_object(), which
doesn't require the check.
Signed-off-by: Fabiano Fidêncio
---
osinfo/osinfo_tree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On Wed, Jul 17, 2019 at 02:24:48PM +0200, Fabiano Fidêncio wrote:
> We should check whether the objects are NULL or not before calling
> g_object_unref(). Instead of doing so, let's use g_clear_object(), which
> doesn't require the check.
>
> Signed-off-by: Fabiano Fidêncio
> ---
> osinfo/osinfo
On Wed, Jul 17, 2019 at 02:24:49PM +0200, Fabiano Fidêncio wrote:
> Instead of just free'ing the CreateFromLocationAsyncData, let's just go
> to cleanup, which will call create_from_location_async_data_free() and
> return after that.
>
> By doing so we avoid errors as:
> g_task_return_error: asser
On Wed, Jul 17, 2019 at 02:24:50PM +0200, Fabiano Fidêncio wrote:
> When calling a g_task_return_error(), we should also cleanup the
> CreateFromLocationAsyncData and return immediately after that.
>
> By doing so we avoid errors as:
> g_task_return_error: assertion 'task->ever_returned' failed.
>
On Wed, Jul 17, 2019 at 02:24:47PM +0200, Fabiano Fidêncio wrote:
> Those patches (partially) the breakage caused on virt-manager's tests
> caught by libvirt-jenkins-ci.
Wonder if there's anything we can add to libosinfo tests tat would
catchthis sooner
>
> There's still an issue happening, whi
---
data/os/suse.com/sle-15.1.xml.in | 65
1 file changed, 65 insertions(+)
create mode 100644 data/os/suse.com/sle-15.1.xml.in
diff --git a/data/os/suse.com/sle-15.1.xml.in b/data/os/suse.com/sle-15.1.xml.in
new file mode 100644
index 000..649f2bf
--
Charles Arnold (2):
Add database support for SLE15-SP1
Add SLE15-SP1 ISO Information
data/os/suse.com/sle-15.1.xml.in | 65 ++
...LE-15-SP1-Installer-DVD-aarch64-GM-DVD1.iso.txt | 29 ++
...LE-15-SP1-Installer-DVD-ppc64le-GM-DVD1.iso.txt | 16 ++
---
...LE-15-SP1-Installer-DVD-aarch64-GM-DVD1.iso.txt | 29 ++
...LE-15-SP1-Installer-DVD-ppc64le-GM-DVD1.iso.txt | 16
.../SLE-15-SP1-Installer-DVD-s390x-GM-DVD1.iso.txt | 29 ++
...SLE-15-SP1-Installer-DVD-x86_64-GM-DVD1.iso.txt | 29
On 7/17/19 8:24 AM, Fabiano Fidêncio wrote:
> Those patches (partially) the breakage caused on virt-manager's tests
> caught by libvirt-jenkins-ci.
>
> There's still an issue happening, which I'm investigating, that I'm
> getting a SIGTERM when running testCLI0450virt_convert
>
> It also seems to
On 7/17/19 3:00 AM, Fabiano Fidêncio wrote:
> ping!
>
> On Fri, Jul 5, 2019 at 9:31 AM Fabiano Fidêncio wrote:
>>
>> Similarly to what we have for media, let's add the "os" property to the
>> trees.
>>
>> osinfo-detect code is already relying on having an "os" property and,
>> since commit 722e7d
On 7/17/19 6:01 AM, Fabiano Fidêncio wrote:
> Both trees & medias may return NULL in case no os-variant was found.
> Let's check for this and avoid a segmentation fault on calling
> osinfo_list_get_length() with a NULL argument.
>
> Signed-off-by: Fabiano Fidêncio
Reviewed-by: Cole Robinson
-
18 matches
Mail list logo
