[Libosinfo] [libosinfo PATCH v3 1/7] media: Fix indentation in create_from_location_asunc_data_free()

2019-07-16 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_media.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/osinfo/osinfo_media.c b/osinfo/osinfo_media.c index cf624d2..493ab95 100644 --- a/osinfo/osinfo_media.c +++ b/osinfo/osinfo_media.c @@ -150,14 +150,14 @@ st

[Libosinfo] [libosinfo PATCH v3 3/7] media: Improve on_location_read error message readability

2019-07-16 Thread Fabiano Fidêncio
Let's add a ": " by the end of the error message, so the prefix doesn't get concatenated with error message, increasing its readability. Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_media.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osinfo/osinfo_media.c b/osinfo/os

[Libosinfo] [libosinfo PATCH v3 7/7] spec: Drop gvfs dependency

2019-07-16 Thread Fabiano Fidêncio
As we rely on libsoup to handle http://, https://, and ftp:// requests there's no need to depend on gvfs anymore. https://gitlab.com/libosinfo/libosinfo/issues/30 Signed-off-by: Fabiano Fidêncio --- libosinfo.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/libosinfo.spec.in b/libosin

[Libosinfo] [libosinfo PATCH v3 2/7] tree: Remove not used Tree from _CreateFromLocationAsyncData struct

2019-07-16 Thread Fabiano Fidêncio
As the OsinfoTree is not used anywhere in our code, let's just remove it. Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_tree.c | 4 1 file changed, 4 deletions(-) diff --git a/osinfo/osinfo_tree.c b/osinfo/osinfo_tree.c index 8a58dd9..227f2c9 100644 --- a/osinfo/osinfo_tree.c +++ b/osi

[Libosinfo] [libosinfo PATCH v3 6/7] tree: Use libsoup for http:// & https:// requests

2019-07-16 Thread Fabiano Fidêncio
As osinfo_tree_create_from_location() handles non-local requests, it'd end up relying on GVFS under the hood, which would cause this API to not work when called from an app running as root. In order to avoid this situation, let's rely on libsoup for this cases. It's important to mention that glib

[Libosinfo] [libosinfo PATCH v3 4/7] media: Use GInpuStream directly in on_location_read()

2019-07-16 Thread Fabiano Fidêncio
Let's do this in order to always deal with a GInputStream directly and avoid dealing with a GFileInputStream or something else when we start using libsoup to deal with non-local files. Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_media.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deleti

[Libosinfo] [libosinfo PATCH v3 5/7] media: Use libsoup for http:// & https:// requests

2019-07-16 Thread Fabiano Fidêncio
As osinfo_media_create_from_location_with_flags_async() can handle non-local cases, they'd end up relying on GVFS under the hood, which would cause those APIs to not work when called from an app running as root. In order to avoid this situation, let's rely on libsoup for these cases. https://gitl

[Libosinfo] [libosinfo PATCH v3 0/7] Drop GVFS dependency in favour of libsoup

2019-07-16 Thread Fabiano Fidêncio
Let's rely on libsoup in order to to http:// and https:// requests. By doing this, GVFS (more specifically, gvfs-http) won't be dragged as a dependency, which caused errors for apps running as root (as GVFS relies on being run in the user's session). https://gitlab.com/libosinfo/libosinfo/issues/

[Libosinfo] [libosinfo PATCH] install-script: Add _generate_*_for_tree()

2019-07-16 Thread Fabiano Fidêncio
Similarly to what we already have for media, let's add APIs for generating both the install-script and the install-script command line for trees. These new APIs take a tree as parameter and, by that, can access tree specific elements as such its URLs. Signed-off-by: Fabiano Fidêncio --- osinfo/

Re: [Libosinfo] [libosinfo PATCH v3 5/7] media: Use libsoup for http:// & https:// requests

2019-07-16 Thread Cole Robinson
On 7/16/19 10:41 AM, Fabiano Fidêncio wrote: > As osinfo_media_create_from_location_with_flags_async() can handle > non-local cases, they'd end up relying on GVFS under the hood, which > would cause those APIs to not work when called from an app running as > root. > > In order to avoid this situat

Re: [Libosinfo] [libosinfo PATCH] install-script: Add _generate_*_for_tree()

2019-07-16 Thread Cole Robinson
On 7/16/19 11:03 AM, Fabiano Fidêncio wrote: > Similarly to what we already have for media, let's add APIs for > generating both the install-script and the install-script command line > for trees. > > These new APIs take a tree as parameter and, by that, can access tree > specific elements as such