Re: [Libosinfo] [libosinfo PATCH v2 1/2] tools, install-script: Add --config-file (-f) option

2019-07-10 Thread Daniel P . Berrangé
On Tue, Jul 09, 2019 at 11:24:49AM +0200, Fabiano Fidêncio wrote: > Let's add a new option so users can set their config from a file, > instead of directly passing the values via command-line. > > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-install-script.c | 103 +++

Re: [Libosinfo] [libosinfo PATCH v2 2/2] tools, install-script: Deprecate --config

2019-07-10 Thread Daniel P . Berrangé
On Tue, Jul 09, 2019 at 11:24:50AM +0200, Fabiano Fidêncio wrote: > Let's deprecate --config and warn out whenever a user or admin password > is passed to osinfo-install-script. > > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-install-script.c | 7 +++ > 1 file changed, 7 insertions(

Re: [Libosinfo] [osinfo-db-tools PATCH v2 08/16] Add support to meson build system

2019-07-10 Thread Fabiano Fidêncio
On Tue, Jul 9, 2019 at 12:47 PM Fabiano Fidêncio wrote: [snip] > +cp $BUILD_ROOT/{mingw-,}osinfo-db-tools.spec $MESON_DIST_ROOT/ I've noticed that the current state of osinfo-db-tools tarball is to just include osinfo-db-tools.spec and not mingw-osinfo-db-tools.spec. Shall we keep it as it is?