[Libosinfo] [libosinfo PATCH] tree: Add "os" property

2019-07-05 Thread Fabiano Fidêncio
Similarly to what we have for media, let's add the "os" property to the trees. osinfo-detect code is already relying on having an "os" property and, since commit 722e7d1d4, it errors out due to the missing property: (osinfo-detect:7808): GLib-GObject-WARNING **: 09:27:58.656: g_object_get_is_val

[Libosinfo] [libosinfo PATCH 0/2] Do not expose user & admin password in the command line

2019-07-05 Thread Fabiano Fidêncio
Those two patches introduce a fix for a low impact CVE where both user & admin password would be passed to the osinfo-install-script via command line. In order to avoid doing so, let's introduce a --config-file and error out whenever a password is passed via --config. Fabiano Fidêncio (2): tool

[Libosinfo] [libosinfo PATCH 1/2] tools, install-script: Add --config-file (-f) option

2019-07-05 Thread Fabiano Fidêncio
Let's add a new option so users can set their config from a file, instead of directly passing the values via command-line. Signed-off-by: Fabiano Fidêncio --- tools/osinfo-install-script.c | 100 +- 1 file changed, 97 insertions(+), 3 deletions(-) diff --git a/to

[Libosinfo] [libosinfo PATCH 2/2] tools, install-script: Do not accept user & admin password via --config

2019-07-05 Thread Fabiano Fidêncio
As passing user & admin password via command line is a low impact CVE, let's error out when it's done and advertise the users to use --config-file instead. Signed-off-by: Fabiano Fidêncio --- tools/osinfo-install-script.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tools/osi

Re: [Libosinfo] [libosinfo PATCH 2/2] tools, install-script: Do not accept user & admin password via --config

2019-07-05 Thread Fabiano Fidêncio
On Fri, Jul 5, 2019 at 10:27 AM Fabiano Fidêncio wrote: > > As passing user & admin password via command line is a low impact CVE, > let's error out when it's done and advertise the users to use > --config-file instead. > > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-install-script.c |

Re: [Libosinfo] [libosinfo PATCH 1/2] tools, install-script: Add --config-file (-f) option

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 10:27:19AM +0200, Fabiano Fidêncio wrote: > Let's add a new option so users can set their config from a file, > instead of directly passing the values via command-line. > > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-install-script.c | 100 +++

Re: [Libosinfo] [libosinfo PATCH 2/2] tools, install-script: Do not accept user & admin password via --config

2019-07-05 Thread Daniel P . Berrangé
On Fri, Jul 05, 2019 at 10:27:20AM +0200, Fabiano Fidêncio wrote: > As passing user & admin password via command line is a low impact CVE, > let's error out when it's done and advertise the users to use > --config-file instead. > > Signed-off-by: Fabiano Fidêncio > --- > tools/osinfo-install-scr