Re: [Libosinfo] [libosinfo PATCH 3/3] README: document "check" for tests

2017-10-19 Thread Pino Toscano
On Tuesday, 17 October 2017 17:40:19 CEST Daniel P. Berrange wrote: > On Tue, Oct 17, 2017 at 05:23:33PM +0200, Pino Toscano wrote: > > "check" is required when building the tests (which are enabled by > > default), so document it. > > > > Signed-off-by: Pino Toscano > > --- > > README | 1 + > >

[Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Pino Toscano
GLib has shipped a testing framework for many years already, so we can make use of it, replacing the external "check". The conversion only switches framework without changing the structure of the tests, making use of the more appropriate assertion in the various places. Signed-off-by: Pino Toscan

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Pino Toscano
On Thursday, 19 October 2017 15:14:24 CEST Pino Toscano wrote: > GLib has shipped a testing framework for many years already, so we can > make use of it, replacing the external "check". > > The conversion only switches framework without changing the structure of > the tests, making use of the more

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 03:33:33PM +0200, Pino Toscano wrote: > On Thursday, 19 October 2017 15:14:24 CEST Pino Toscano wrote: > > GLib has shipped a testing framework for many years already, so we can > > make use of it, replacing the external "check". > > > > The conversion only switches framewo

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 03:14:24PM +0200, Pino Toscano wrote: > GLib has shipped a testing framework for many years already, so we can > make use of it, replacing the external "check". > > The conversion only switches framework without changing the structure of > the tests, making use of the more

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Pino Toscano
On Thursday, 19 October 2017 15:36:28 CEST Daniel P. Berrange wrote: > On Thu, Oct 19, 2017 at 03:14:24PM +0200, Pino Toscano wrote: > > diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c > > index 7214531..97c86c4 100644 > > --- a/tests/test-isodetect.c > > +++ b/tests/test-isodetect.c >

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 03:59:02PM +0200, Pino Toscano wrote: > On Thursday, 19 October 2017 15:36:28 CEST Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 03:14:24PM +0200, Pino Toscano wrote: > > > diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c > > > index 7214531..97c86c4 1006

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Pino Toscano
On Thursday, 19 October 2017 16:02:18 CEST Daniel P. Berrange wrote: > On Thu, Oct 19, 2017 at 03:59:02PM +0200, Pino Toscano wrote: > > On Thursday, 19 October 2017 15:36:28 CEST Daniel P. Berrange wrote: > > > On Thu, Oct 19, 2017 at 03:14:24PM +0200, Pino Toscano wrote: > > > > diff --git a/test