Re: [Libosinfo] [libosinfo] test-isodetect: Improve error message on detection failures

2018-01-10 Thread Daniel P. Berrange
info->filename, info->shortid); > +} > > g_object_get(info->media, "os", &os, NULL); > const gchar *shortid = > osinfo_product_get_short_id(OSINFO_PRODUCT(os)); Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: https://ber

Re: [Libosinfo] [PATCH] Drop redundant 'const' keyword from object parameters

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 11:57:29AM +0100, Christophe Fergeau wrote: > Hey, > > > > It's definitely not used consistently, but removing a 'const' from > > > external API is going to cause breakage in C++ code: > > > > Well that's true but IMHO this breakage is OK, given: > > > > * the unlikelyhoo

Re: [Libosinfo] [PATCH] Drop redundant 'const' keyword from object parameters

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 12:05:57PM +0100, Zeeshan Ali wrote: > On Fri, Nov 17, 2017 at 11:57 AM, Christophe Fergeau > wrote: > > Hey, > > > >> > It's definitely not used consistently, but removing a 'const' from > >> > external API is going to cause breakage in C++ code: > >> > >> Well that's true

Re: [Libosinfo] [PATCH] Drop redundant 'const' keyword from object parameters

2017-11-17 Thread Daniel P. Berrange
On Thu, Nov 16, 2017 at 10:16:22AM +0100, Christophe Fergeau wrote: > Hey, > > On Sun, Nov 12, 2017 at 05:04:19PM +0100, Zeeshan Ali wrote: > > Use of 'const' parameter on object parameters is redundant, inconsistent > > (both internally and against other GObject libraries) and currently breaks >

Re: [Libosinfo] [libosinfo PATCH] tests: get the curl response code every time

2017-11-01 Thread Daniel P. Berrange
On Wed, Nov 01, 2017 at 01:37:52PM +, Daniel P. Berrange wrote: > On Wed, Nov 01, 2017 at 02:35:16PM +0100, Pavel Hrdina wrote: > > This failed on FreeBSD with following error: > > > > ../../tests/test-mediauris.c:47:13: error: variable 'response_code' is used

Re: [Libosinfo] [libosinfo PATCH] tests: get the curl response code every time

2017-11-01 Thread Daniel P. Berrange
s-uninitialized] > > Signed-off-by: Pavel Hrdina > --- > tests/test-mediauris.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Daniel P. Berrange Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |

[Libosinfo] [PATCH osinfo-db-tools] Don't expand entities when parsing XML

2017-10-26 Thread Daniel P. Berrange
download data from the website to refresh its local database, so it is wise to avoid entity expansion as a hardening step. Signed-off-by: Daniel P. Berrange --- tools/osinfo-db-validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/osinfo-db-validate.c b/tools/osinfo-db

Re: [Libosinfo] [PATCH osinfo-db] freebsd: add FreeBSD 10.4 info

2017-10-20 Thread Daniel P. Berrange
On Wed, Oct 18, 2017 at 10:05:36AM +0400, Roman Bogorodskiy wrote: > Christophe Fergeau wrote: > > > Hey, > > > > On Tue, Oct 17, 2017 at 01:00:38PM +0400, Roman Bogorodskiy wrote: > > > Christophe Fergeau wrote: > > > > > > > On Thu, Oct 05, 2017 at 02:38:41PM +0400, Roman Bogorodskiy wrote

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 03:59:02PM +0200, Pino Toscano wrote: > On Thursday, 19 October 2017 15:36:28 CEST Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 03:14:24PM +0200, Pino Toscano wrote: > > > diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c > >

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Daniel P. Berrange
/isodetect/openbsd", test_openbsd); > +g_test_add_func("/isodetect/opensuse", test_opensuse); > +g_test_add_func("/isodetect/centos", test_centos); > + g_test_add_func("/isodetect/gnome", test_gnome); > +g_test_add_func("/isodetect/altl

Re: [Libosinfo] [libosinfo PATCH] tests: convert from check to the GLib testing framework

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 03:33:33PM +0200, Pino Toscano wrote: > On Thursday, 19 October 2017 15:14:24 CEST Pino Toscano wrote: > > GLib has shipped a testing framework for many years already, so we can > > make use of it, replacing the external "check". > > > > The conversion only switches framewo

Re: [Libosinfo] [libosinfo PATCH 3/3] README: document "check" for tests

2017-10-17 Thread Daniel P. Berrange
git a/README b/README > index 1a0fa2e..11063ca 100644 > --- a/README > +++ b/README > @@ -19,6 +19,7 @@ Dependencies > > > - Required: > + - check (for tests only) > - gobject-2.0 >- gio-2.0 >- libxml-2.0 Reviewed-by: Daniel P. Berran

Re: [Libosinfo] [libosinfo PATCH 2/3] build: make curl optional, and only for tests

2017-10-17 Thread Daniel P. Berrange
ally need it. > > As side result, it is possible to drop the curl BuildRequires from the > mingw spec, as it builds with --enable-tests=no. > > Signed-off-by: Pino Toscano Reviewed-by: Daniel P. Berrange If someone feels motivated it would be nice to try and convert our tests to

Re: [Libosinfo] [libosinfo PATCH 1/3] build: fix disabling of tests

2017-10-17 Thread Daniel P. Berrange
if test "x$enable_tests" != "xno" ; then >PKG_CHECK_MODULES([CHECK], [check]) > fi > > +AM_CONDITIONAL([ENABLE_TESTS],[test "x$enable_tests" = "xyes"]) > + > LIBOSINFO_MAJOR_VERSION=`echo $VERSION | awk -F. '{print $1}'` > LIBOSINFO_MIN

Re: [Libosinfo] [PATCH osinfo-db] freebsd: Fix 11.1 i386-dvd1 iso url

2017-10-05 Thread Daniel P. Berrange
On Thu, Oct 05, 2017 at 09:32:05AM +0200, Pierre-Alain TORET wrote: > Hello, > > this is my first try at sending a patch. I'm starting with a small change. > > Best regards, > --- > data/os/freebsd.org/freebsd-11.1.xml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [Libosinfo] [osinfo-db-tools PATCH 0/2] syntax-check portability fixes

2017-09-21 Thread Daniel P. Berrange
Likewise Reviewed-by: Daniel P. Berrange and pushed to git master... On Thu, Sep 21, 2017 at 10:21:34AM +0200, Christophe Fergeau wrote: > For the series: > Acked-by: Christophe Fergeau > > On Mon, Sep 18, 2017 at 03:03:31PM +0200, Andrea Bolognani wrote: > > With these pat

Re: [Libosinfo] [osinfo-db-tools PATCH] maint: Drop autobuild.sh

2017-09-21 Thread Daniel P. Berrange
on > Jenkins with a completely independent setup that doesn't use the > script at all. > > Signed-off-by: Andrea Bolognani > --- > autobuild.sh | 105 > --- > 1 file changed, 105 deletions(-) > delete mode 100755 auto

[Libosinfo] ANNOUNCE: libosinfo 1.1.0 release

2017-08-15 Thread Daniel P. Berrange
I am happy to announce a new release of libosinfo, version 1.1.0: https://releases.pagure.org/libosinfo/libosinfo-1.1.0.tar.gz This is signed with key DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) https://releases.pagure.org/libosinfo/libosinfo-1.1.0.tar.gz.asc All historical

Re: [Libosinfo] [osinfo-db PATCH] ubuntu: fix 16.04 location

2017-08-08 Thread Daniel P. Berrange
On Mon, Aug 07, 2017 at 04:09:18PM -0400, Cole Robinson wrote: > On 08/07/2017 07:24 AM, Pino Toscano wrote: > > Point to the latest release of Ubuntu 16.04 (i.e. 16.04.3). > > --- > > data/os/ubuntu.com/ubuntu-16.04.xml.in | 14 +++--- > > 1 file changed, 7 insertions(+), 7 deletions(-) >

Re: [Libosinfo] [PATCH libosinfo v3] test-isodetect: add Debian's arm flavours

2017-07-13 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 05:49:02PM +0200, Guido Günther wrote: > to avoid "Unknown arch" debug messages > --- > tests/test-isodetect.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c > index c72b8fc..7214531 100644 > -

Re: [Libosinfo] [PATCH libosinfo v2] test-isodetect: add Debian's arm flavours

2017-07-13 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 02:39:47PM +0200, Guido Günther wrote: > to avoid "Unknown arch" debug messages > --- > tests/test-isodetect.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c > index c72b8fc..9306be4 100644 >

Re: [Libosinfo] [PATCH libosinfo] test-isodetect: add Debian's arm flavours

2017-07-13 Thread Daniel P. Berrange
On Thu, Jul 13, 2017 at 05:18:24PM +0200, Christophe Fergeau wrote: > On Thu, Jul 13, 2017 at 02:39:19PM +0200, Guido Günther wrote: > > On Wed, Jul 12, 2017 at 09:35:16AM +0200, Christophe Fergeau wrote: > > > > > > However for this one I'd expect arch = "armv7l" as this is what is in > > > the R

Re: [Libosinfo] [osinfo-db PATCH] debian: fix architecture names to match schema

2017-07-07 Thread Daniel P. Berrange
On Fri, Jul 07, 2017 at 03:59:39PM +0200, Guido Günther wrote: > On Fri, Jul 07, 2017 at 01:36:29PM +0200, Pino Toscano wrote: > > The schema has names for architectures which are closer to the RPM > > naming than the dpkg one -- thus, fix: > > - arm64 -> aarch64 > > - armhf -> armv7l > > Are the

Re: [Libosinfo] [libosinfo] build: Don't use private header for gir/vapi generation

2017-05-30 Thread Daniel P. Berrange
On Tue, May 30, 2017 at 11:20:58AM +0200, Christophe Fergeau wrote: > Using private headers when generating the gir/vapi files mean that they > are listing private methods which are not exported by the shared > library, as well as types which are not present in public headers, and > not meant to be

Re: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata

2017-05-02 Thread Daniel P. Berrange
On Tue, May 02, 2017 at 07:48:52PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > On Tue, May 02, 2017 at 07:22:47PM +0400, Roman Bogorodskiy wrote: > > > Christophe Fergeau wrote: > > > > > > > > > > > Acked-by: Chr

Re: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 isodata

2017-05-02 Thread Daniel P. Berrange
On Tue, May 02, 2017 at 07:22:47PM +0400, Roman Bogorodskiy wrote: > Christophe Fergeau wrote: > > > > > Acked-by: Christophe Fergeau > > and pushed. > > Oops, it looks like it should be moved to 'tests' dir now (I generated > this patch before the rename). I'll sort that. > Also, I've noti

Re: [Libosinfo] [PATCH] configure: add (usb|pci).ids locations on FreeBSD

2017-05-02 Thread Daniel P. Berrange
On Tue, May 02, 2017 at 07:24:55PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > On Fri, Apr 28, 2017 at 07:11:47PM +0400, Roman Bogorodskiy wrote: > > > Add default locations for usb.ids and pci.ids on FreeBSD, > > > i.e. paths used when in

Re: [Libosinfo] [PATCH] configure: add (usb|pci).ids locations on FreeBSD

2017-04-28 Thread Daniel P. Berrange
On Fri, Apr 28, 2017 at 07:11:47PM +0400, Roman Bogorodskiy wrote: > Add default locations for usb.ids and pci.ids on FreeBSD, > i.e. paths used when installing this from misc/usbids > and misc/pciids ports. > > This way users on FreeBSD don't need to explicitly set > these paths using --with-(usb

Re: [Libosinfo] [PATCH] Fix error propagation in DB loader

2017-04-28 Thread Daniel P. Berrange
On Fri, Apr 28, 2017 at 05:57:57PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > When failing to read the pci/usb ID files we failed to > > propagate the reported error. > > > > We also had some dead code which would never be re

Re: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info

2017-04-27 Thread Daniel P. Berrange
On Thu, Apr 27, 2017 at 05:56:59PM +0100, Daniel P. Berrange wrote: > On Thu, Apr 27, 2017 at 07:55:41PM +0400, Roman Bogorodskiy wrote: > > Daniel P. Berrange wrote: > > > > > On Thu, Apr 27, 2017 at 06:56:58PM +0400, Roman Bogorodskiy wrote: > > > > >

[Libosinfo] [PATCH] Fix error propagation in DB loader

2017-04-27 Thread Daniel P. Berrange
When failing to read the pci/usb ID files we failed to propagate the reported error. We also had some dead code which would never be reached due to earlier gotos. Signed-off-by: Daniel P. Berrange --- osinfo/osinfo_loader.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff

Re: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info

2017-04-27 Thread Daniel P. Berrange
On Thu, Apr 27, 2017 at 07:55:41PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > On Thu, Apr 27, 2017 at 06:56:58PM +0400, Roman Bogorodskiy wrote: > > > > Does it work if you make install to the "normal" location and > > > >

Re: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info

2017-04-27 Thread Daniel P. Berrange
On Thu, Apr 27, 2017 at 06:56:58PM +0400, Roman Bogorodskiy wrote: > > Does it work if you make install to the "normal" location and > > unset OSINFO_SYSTEM_DIR ? > > It does not, when I do './tools/osinfo-query os', it shows nothing. > > However, if I use system version of libosinfo (1.0.0), it

Re: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info

2017-04-27 Thread Daniel P. Berrange
On Thu, Apr 27, 2017 at 06:24:20PM +0400, Roman Bogorodskiy wrote: > Christophe Fergeau wrote: > > > On Sun, Apr 16, 2017 at 05:38:10PM +0400, Roman Bogorodskiy wrote: > > > Daniel P. Berrange wrote: > > > > > > > On Wed, Feb 08, 2017 at

Re: [Libosinfo] [osinfo-db] install-script, opensuse: Add omit-xml-declaration to the output format

2017-04-21 Thread Daniel P. Berrange
On Fri, Apr 21, 2017 at 11:20:05AM +0200, Fabiano Fidêncio wrote: > On Fri, Apr 21, 2017 at 11:16 AM, Daniel P. Berrange > wrote: > > On Fri, Apr 21, 2017 at 11:06:42AM +0200, Fabiano Fidêncio wrote: > >> On Fri, Apr 21, 2017 at 10:45 AM, Daniel P. Berrange > >>

Re: [Libosinfo] [osinfo-db] install-script, opensuse: Add omit-xml-declaration to the output format

2017-04-21 Thread Daniel P. Berrange
On Fri, Apr 21, 2017 at 11:06:42AM +0200, Fabiano Fidêncio wrote: > On Fri, Apr 21, 2017 at 10:45 AM, Daniel P. Berrange > wrote: > > On Fri, Apr 21, 2017 at 10:37:37AM +0200, Fabiano Fidêncio wrote: > >> Without this change the output got from the command-line templat

Re: [Libosinfo] [osinfo-db] install-script, opensuse: Add omit-xml-declaration to the output format

2017-04-21 Thread Daniel P. Berrange
On Fri, Apr 21, 2017 at 10:37:37AM +0200, Fabiano Fidêncio wrote: > Without this change the output got from the command-line template will > look like " autoyast=device://sda/autoinst.xml" while > what we actually expect is just "autoyast=device://sda/autoinst.xml". This description looks a bit od

Re: [Libosinfo] [osinfo-db v2] install-script: Use single quotes around passwords set from a shell

2017-04-20 Thread Daniel P. Berrange
On Wed, Apr 19, 2017 at 08:20:58PM +0200, Fabiano Fidêncio wrote: > From: Fabiano Fidêncio > > We have to have single quotes around the passwords set from a shell > otherwise a password like "foo$bar" would be interpreted by the shell as > "foo" value of $bar. > > Reported-by: Rafael Fonseca >

Re: [Libosinfo] [osinfo-db] install-script: Use single quotes around passwords set from a shell

2017-04-19 Thread Daniel P. Berrange
On Wed, Apr 19, 2017 at 12:49:53PM +0200, Fabiano Fidêncio wrote: > We have to have single quotes around the passwords set from a shell > otherwise a password like "foo$bar" would be interpreted by the shell as > "foo" value of $bar. > > Reported-by: Rafael Fonseca > Signed-off-by: Fabiano Fidênc

Re: [Libosinfo] [osinfo-db 00/11] openSUSE's install-scripts improvements & fixes

2017-04-19 Thread Daniel P. Berrange
On Tue, Apr 18, 2017 at 11:29:20PM +0200, Fabiano Fidêncio wrote: > This patchset contains a bunch for improvements & fixes for openSUSE's family > including: > - A workaround that makes the express installation of Leap 42.2 (that has > been >broken since it was added) possible again; > - Fi

Re: [Libosinfo] [osinfo-db v2] Add 'eject-after-install' attribute to RNG

2017-04-19 Thread Daniel P. Berrange
On Tue, Apr 18, 2017 at 11:47:40PM +0200, Fabiano Fidêncio wrote: > From: Fabiano Fidêncio > > Signed-off-by: Fabiano Fidêncio > --- > data/schema/osinfo.rng.in | 5 + > 1 file changed, 5 insertions(+) ACK both Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.co

Re: [Libosinfo] [osinfo-db PATCH 0/2] Add recent RHEL and CentOS releases

2017-04-18 Thread Daniel P. Berrange
On Tue, Apr 11, 2017 at 03:03:06PM +0200, Pino Toscano wrote: > Hi, > > this series adds the latest releases of RHEL and CentOS, and adds ISO > test data for them. > > Thanks, > > Pino Toscano (2): > rhel: add RHEL 6.9 and 7.3 info > centos: add CentOS 6.8 and 6.9 info > > data/os/centos.o

Re: [Libosinfo] [osinfo-db-tools] Fix build with clang

2017-04-18 Thread Daniel P. Berrange
On Sun, Apr 16, 2017 at 04:26:15PM +0400, Roman Bogorodskiy wrote: > The osinfo_db_import_create_reg() function implements error handling > via jumping to cleanup and returning, however, this way the return > value is not initialised. This breaks build with clang and probably > could lead to an und

Re: [Libosinfo] [libosinfo] Add 'persistent' parameter to OsinfoMedia

2017-04-13 Thread Daniel P. Berrange
On Thu, Apr 13, 2017 at 01:26:00PM +0200, Fabiano Fidêncio wrote: > On Thu, Apr 13, 2017 at 11:48 AM, Daniel P. Berrange > wrote: > > On Wed, Apr 12, 2017 at 11:05:47PM +0200, Zeeshan Ali (Khattak) wrote: > >> Hi Fabiano, > >> > >> On 12 April 2017 at 11

Re: [Libosinfo] [libosinfo] Add 'persistent' parameter to OsinfoMedia

2017-04-13 Thread Daniel P. Berrange
On Wed, Apr 12, 2017 at 11:05:47PM +0200, Zeeshan Ali (Khattak) wrote: > Hi Fabiano, > > On 12 April 2017 at 11:09, Fabiano Fidêncio wrote: > > If media is an installer, thus specifies whether the media should be > > persistent accross the final reboot during its installation process. > > Default

Re: [Libosinfo] [libosinfo] Add 'persistent' parameter to OsinfoMedia

2017-04-13 Thread Daniel P. Berrange
On Thu, Apr 13, 2017 at 11:01:06AM +0200, Christophe Fergeau wrote: > On Wed, Apr 12, 2017 at 11:09:34AM +0200, Fabiano Fidêncio wrote: > > If media is an installer, thus specifies whether the media should be > > persistent accross the final reboot during its installation process. > > Default value

Re: [Libosinfo] [osinfo-db PATCH 0/5] Improve release/EOF dates

2017-04-10 Thread Daniel P. Berrange
On Mon, Apr 10, 2017 at 05:03:58PM +0200, Pino Toscano wrote: > Hi, > > this series improves the dates of releases and EOF for a number of > distros of the following families: centos, debian, fedora, freebsd, > and rhel. > > Thanks, > > Pino Toscano (5): > freebsd: fix/add release-date/eol-dat

Re: [Libosinfo] [PATCH v3] Improve Perl-related routines

2017-02-23 Thread Daniel P. Berrange
On Thu, Feb 16, 2017 at 06:40:58PM +0400, Roman Bogorodskiy wrote: > * Add a check for the 'perl' program to configure.ac as >$(PERL) is used in various places > * Do not hardcode '/usr/bin/perl' in perl scripts >because on FreeBSD and maybe some other systems it's installed >in a dif

[Libosinfo] [PATCH] Disable -Wunsafe-loop-optimizations warnings

2017-02-22 Thread Daniel P. Berrange
der.c:2127:11: error: missed loop optimization, the loop counter may overflow [-Werror=unsafe-loop-optimizations] while (tmp && *tmp) { ^ The warning just needs to be turned off since the code is not broken, and we don't care about the optimization level Signed-off

Re: [Libosinfo] [osinfo-db] ubuntu: Add USB tablet device support

2017-02-20 Thread Daniel P. Berrange
On Mon, Feb 20, 2017 at 09:40:08AM +0100, Christophe Fergeau wrote: > On Sun, Feb 19, 2017 at 10:37:12PM +0100, Fabiano Fidêncio wrote: > > As reported by Cole Robinson, none of the ubuntu distro metadat reports > > sypport for the USB tablet device support. > > > > After testing old Ubuntu ISOs,

Re: [Libosinfo] Gentoo/Funtoo entries request

2017-02-10 Thread Daniel P. Berrange
On Fri, Feb 10, 2017 at 01:01:58PM -0500, John Roman wrote: > Greetings, > If possible, I wish to submit a patch to the osinfo tool to provide > information on two distributions of Linux, Funtoo and Gentoo. Without > proper identification in osinfo, users attempting to provision such > systems in

Re: [Libosinfo] [libosinfo] check-symsorting: don't hardcode Perl path

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 07:50:10PM +0400, Roman Bogorodskiy wrote: > Do not hardcode '/usr/bin/perl' because on FreeBSD and maybe some other > systems it's installed in a different prefix, so use '/usr/bin/env perl' > instead. > --- > osinfo/check-symsorting.pl | 2 +- > 1 file changed, 1 insertio

Re: [Libosinfo] [PATCH] freebsd: add FreeBSD 11.0 info

2017-02-08 Thread Daniel P. Berrange
On Wed, Feb 08, 2017 at 07:46:50PM +0400, Roman Bogorodskiy wrote: > Christophe Fergeau wrote: > > > On Wed, Feb 08, 2017 at 05:37:27PM +0400, Roman Bogorodskiy wrote: > > > Roman Bogorodskiy wrote: > > > > > > > --- > > > > data/os/freebsd.org/freebsd-11.0.xml.in | 50 > > > > +

Re: [Libosinfo] [PATCH 0/2] Two trivial fixes

2017-01-23 Thread Daniel P. Berrange
On Sat, Jan 21, 2017 at 04:10:35PM +0100, Fabiano Fidêncio wrote: > On Mon, Jan 16, 2017 at 11:08 AM, Daniel P. Berrange > wrote: > > On Mon, Jan 16, 2017 at 10:52:01AM +0100, Fabiano Fidêncio wrote: > >> On Mon, Jan 16, 2017 at 9:46 AM, Christophe Fergeau > >>

[Libosinfo] [PATCH] Fix volume sizes in F25 server media

2017-01-16 Thread Daniel P. Berrange
The volume size recorded neds to be the result of volume-size multiplied by block size, from the ISO media, not the size of the actual ISO file itself. Signed-off-by: Daniel P. Berrange --- data/os/fedoraproject.org/fedora-25.xml.in | 8 1 file changed, 4 insertions(+), 4 deletions

Re: [Libosinfo] [PATCH 0/2] Two trivial fixes

2017-01-16 Thread Daniel P. Berrange
On Mon, Jan 16, 2017 at 10:52:01AM +0100, Fabiano Fidêncio wrote: > On Mon, Jan 16, 2017 at 9:46 AM, Christophe Fergeau > wrote: > > On Mon, Jan 16, 2017 at 09:06:49AM +0100, Michal Privoznik wrote: > >> BTW: the test-isodetect test is still failing for me (surprisingly). > > > > What is the fail

Re: [Libosinfo] [osinfo-db] fedora: Enable repos when installing a Server ISO

2017-01-09 Thread Daniel P. Berrange
On Mon, Jan 09, 2017 at 11:45:33AM +0100, Zeeshan Ali (Khattak) wrote: > Hi, > > On 8 January 2017 at 19:16, Fabiano Fidêncio wrote: > > On Sun, Jan 8, 2017 at 2:13 PM, Zeeshan Ali (Khattak) > > wrote: > >> Hi, > >> > >> On 6 January 2017 at 21:39, Fabiano Fidêncio wrote: > >>> Fedora installer

Re: [Libosinfo] [libosinfo] win10: Add test cases for recent Windows 10 builds

2016-12-20 Thread Daniel P. Berrange
On Tue, Dec 20, 2016 at 05:41:19PM +0100, Christophe Fergeau wrote: > Recent Windows 10 builds (build 1607) seem to have dropped the J_ at the > beginning of the volume ID. > These additional files make sure we've got test cases for this kind of > win10 ISOs. > --- > ...n_1511_updated_apr_2016_x64

Re: [Libosinfo] [osinfo-db] win10: Fix detection of recent Windows 10 builds

2016-12-20 Thread Daniel P. Berrange
On Tue, Dec 20, 2016 at 05:41:15PM +0100, Christophe Fergeau wrote: > Recent Windows 10 builds (build 1607) seem to have dropped the J_ at the > beginning of the volume ID. While I haven't checked that this was done > for all the ISOs which are listed, it makes sense to do it for all > rather than

Re: [Libosinfo] [PATCH 0/2] Add the missing SLE 10 distros and fix derives from

2016-12-13 Thread Daniel P. Berrange
On Tue, Dec 13, 2016 at 08:08:40AM -0700, Charles Arnold wrote: > Add the missing SLE 10 distros that were omitted in the last > patch set. Update the derives from in SLE 11 to point at 10.4 > > Charles Arnold (2): > Add missing SLE 10 distros > Fix derives from for SLE-11 ACK and pushed Re

Re: [Libosinfo] [PATCH 06/10] Fix SLE derives from information

2016-12-13 Thread Daniel P. Berrange
On Mon, Dec 12, 2016 at 03:43:06PM -0700, Charles Arnold wrote: > diff --git a/data/os/suse.com/sled-11.xml.in b/data/os/suse.com/sled-11.xml.in > index 589de8a..39e3f8c 100644 > --- a/data/os/suse.com/sled-11.xml.in > +++ b/data/os/suse.com/sled-11.xml.in > @@ -8,7 +8,8 @@ > <_vendor>SUSE >

Re: [Libosinfo] [PATCH 00/10] Update SUSE distro database information

2016-12-13 Thread Daniel P. Berrange
On Mon, Dec 12, 2016 at 03:43:00PM -0700, Charles Arnold wrote: > This patch series fixes, updates, and adds missing SUSE distro > database information. Thanks for the comprehensive update ! I'll just trust the data is all correct, so I've pushed all 10. Regards, Daniel -- |: http://berrange.co

Re: [Libosinfo] [PATCH osinfo-db v2] Abort on XML errors

2016-11-09 Thread Daniel P. Berrange
On Tue, Nov 08, 2016 at 07:19:14PM +0100, Guido Günther wrote: > While we abort on XML errors the first time the output XML already gets > written so a subsequent make call will continue with the next file > leading to an incomplete database. Use a temporary file to fix this. > --- > >Changes

Re: [Libosinfo] [PATCH osinfo-db] Abort on XML errors

2016-11-08 Thread Daniel P. Berrange
On Tue, Nov 08, 2016 at 08:14:07AM +0100, Guido Günther wrote: > While we abort on XML errors the first time the output XML already gets > written so a subsequent make call will continue with the next file > leading to an incomplete database. Use a temporary file to fix this. > --- > Makefile | 3

Re: [Libosinfo] [PATCH osinfo-db] Debian: enhance guest agent support

2016-11-08 Thread Daniel P. Berrange
On Tue, Nov 08, 2016 at 08:13:27AM +0100, Guido Günther wrote: > This also only installs qemu-guest-agent on recent Debian since versions > before Jessie don't ship it. > --- > data/install-script/debian.org/debian-preseed-desktop.xml.in | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-

Re: [Libosinfo] [PATCH libosinfo] loader: Fix typo in error message

2016-11-07 Thread Daniel P. Berrange
On Sat, Nov 05, 2016 at 02:00:28PM +0100, Guido Günther wrote: > --- > osinfo/osinfo_loader.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o-

Re: [Libosinfo] [PATCH osinfo-db 0/3] Updates for Debian

2016-11-07 Thread Daniel P. Berrange
On Sun, Nov 06, 2016 at 07:51:03PM +0100, Guido Günther wrote: > Guido Günther (3): > Update virtio device information for Debian Wheezy and Jessie > Remove redundant entries for Debian > Derive Debian testing from the latest stable release > > data/os/debian.org/debian-7.xml.in | 7

Re: [Libosinfo] [PATCH osinfo-db] Unbreak vpath build

2016-11-07 Thread Daniel P. Berrange
On Sun, Nov 06, 2016 at 07:45:51PM +0100, Guido Günther wrote: > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http:/

Re: [Libosinfo] [PATCH libosinfo] examples: avoid PyGIWarning

2016-10-31 Thread Daniel P. Berrange
On Sat, Oct 29, 2016 at 10:42:35PM +0200, Guido Günther wrote: > This fixes > > demo.py:3: PyGIWarning: Libosinfo was imported without specifying a version > first. Use gi.require_version('Libosinfo', '1.0') before import > to ensure that the right version gets loaded. > from gi.repository impo

Re: [Libosinfo] osinfo-db source tarball

2016-10-21 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 07:55:10PM +0200, Guido Günther wrote: > Hi Daniel, > On Tue, Oct 18, 2016 at 09:30:49AM +0100, Daniel P. Berrange wrote: > > On Tue, Oct 11, 2016 at 08:32:05PM +0200, Guido Günther wrote: > > > Hi, > > > I looked into packaging osinf

Re: [Libosinfo] [PATCH db] include COPYING file as license for archive

2016-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 02:09:07PM +0200, Fabiano Fidêncio wrote: > On Wed, Oct 19, 2016 at 11:12 AM, Daniel P. Berrange > wrote: > > When generating the archive of DB files we must include > > the COPYING file as the quoted license. > > > > Sig

Re: [Libosinfo] [osinfo-db-tools PATCH] README: libarchive is required as well

2016-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 01:00:03PM +0200, Guido Günther wrote: > --- > README | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/README b/README > index 6b095ff..0368735 100644 > --- a/README > +++ b/README > @@ -19,6 +19,7 @@ Dependencies > - Required: >- gobject-2.0 >- gio-2.0 >

Re: [Libosinfo] [PATCH osinfo-db-tools] validate: correct help output

2016-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 01:28:10PM +0200, Guido Günther wrote: > We validate files, don't install them > --- > tools/osinfo-db-validate.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o-http://www.flickr.com/photos/dberr

Re: [Libosinfo] [PATCH osinfo-db] Add release and eol dates for Debian 6, 7 and 8

2016-10-20 Thread Daniel P. Berrange
On Thu, Oct 20, 2016 at 01:29:14PM +0200, Guido Günther wrote: > --- > data/os/debian.org/debian-6.xml.in | 3 +++ > data/os/debian.org/debian-7.xml.in | 3 +++ > data/os/debian.org/debian-8.xml.in | 2 ++ > 3 files changed, 8 insertions(+) ACK Regards, Daniel -- |: http://berrange.com -o-

[Libosinfo] [PATCH db] include COPYING file as license for archive

2016-10-19 Thread Daniel P. Berrange
When generating the archive of DB files we must include the COPYING file as the quoted license. Signed-off-by: Daniel P. Berrange --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 53a2ea5..7f5801a 100644 --- a/Makefile +++ b/Makefile

[Libosinfo] [PATCH db-tools] osinfo-db-export: add ability to include a license file

2016-10-19 Thread Daniel P. Berrange
Add a "--license FILE-NAME" option to osinfo-db-export which will add that reference FILE-NAME to the generated archive as a file called "LICENSE" in the top level. Signed-off-by: Daniel P. Berrange --- tools/osinfo-db-export.c | 78

Re: [Libosinfo] osinfo-db source tarball

2016-10-18 Thread Daniel P. Berrange
On Tue, Oct 18, 2016 at 09:30:49AM +0100, Daniel P. Berrange wrote: > On Tue, Oct 11, 2016 at 08:32:05PM +0200, Guido Günther wrote: > > Hi, > > I looked into packaging osinfo-db for Debian and looking at: > > > > https://fedorahosted.org/releases/l/i/libosinf

Re: [Libosinfo] osinfo-db source tarball

2016-10-18 Thread Daniel P. Berrange
On Tue, Oct 11, 2016 at 08:32:05PM +0200, Guido Günther wrote: > Hi, > I looked into packaging osinfo-db for Debian and looking at: > > https://fedorahosted.org/releases/l/i/libosinfo/osinfo-db-20160728.tar.xz > > it looks quit different from https://gitlab.com/libosinfo/osinfo-db > . Would it

[Libosinfo] ANNOUNCE: libosinfo 1.0.0 release

2016-10-07 Thread Daniel P. Berrange
I am happy to announce a new release of libosinfo, version 1.0.0: https://fedorahosted.org/releases/l/i/libosinfo/libosinfo-1.0.0.tar.gz This is signed with key DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) https://fedorahosted.org/releases/l/i/libosinfo/libosinfo-1.0.0.tar.gz

Re: [Libosinfo] Improve the size of default memory for rhel6 guest to 2048M

2016-09-20 Thread Daniel P. Berrange
On Tue, Sep 20, 2016 at 06:25:02AM -0400, Ming Xie wrote: > Hi All, > > I meet a problem that guest can't boot into rhel6 after installation > or rhel6 can't be installed in guest if the guest has only 1GB memory > and has no swap partition, I know this is not bug because rhel6 systems > with low

Re: [Libosinfo] [PATCH osinfo-db] Add support for DESTDIR

2016-09-13 Thread Daniel P. Berrange
rgs used for osinfo-db-tools build > On Tue, Sep 13, 2016 at 11:03 AM, Daniel P. Berrange > wrote: > > The jhbuild system doesn't support plain "make" systems, > > so we need to pretend to be more automake-like. Adding > > DESTDIR support lets jhbuild' auto

[Libosinfo] [PATCH osinfo-db] Add support for DESTDIR

2016-09-13 Thread Daniel P. Berrange
The jhbuild system doesn't support plain "make" systems, so we need to pretend to be more automake-like. Adding DESTDIR support lets jhbuild' automake "make install" step work. Signed-off-by: Daniel P. Berrange --- Makefile | 3 ++- autobuild.sh | 2 +- 2 fil

[Libosinfo] [PATCH osinfo-db] make: add ability to build from non-local dir

2016-09-12 Thread Daniel P. Berrange
Add ability to do a VPATH building by doing mkdir build cd build ln -s ../Makefile . make VPATH=.. Signed-off-by: Daniel P. Berrange --- Makefile | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 2223db3..3cffade 100644 --- a

Re: [Libosinfo] [PATCH] fedora: Install spice-webdavd dependency

2016-09-05 Thread Daniel P. Berrange
On Tue, Aug 30, 2016 at 12:52:09PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > GNOME-Boxes is developing a folder sharing feature which will > need spice-webdavd installed in the guest for it to work. > > Let's make the folder sharing feature available right after > express i

Re: [Libosinfo] [PATCH] fedora: Install spice-webdavd dependency

2016-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2016 at 07:23:19PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > GNOME-Boxes is developing a folder sharing feature which will > need spice-webdavd installed in the guest for it to work. > > Let's make the folder sharing feature available right after > express i

Re: [Libosinfo] [PATCH] fedora: Install spice-webdavd dependency

2016-08-22 Thread Daniel P. Berrange
On Fri, Aug 19, 2016 at 11:44:22PM +0300, Visarion Alexandru wrote: > From: Visarion Alexandru > > GNOME-Boxes is developing a folder sharing feature which will > need spice-webdavd installed in the guest for it to work. > > Let's make the folder sharing feature available right after > express i

[Libosinfo] [PATCH osinfo-db] mageia: remove all download URLs

2016-08-12 Thread Daniel P. Berrange
The download URLs in the mageia data files are not valid, since they just point to HTML pages which use javascript todo a magic redirect to the actual download site. This means that any app trying to fetch ISOs with URLs will just get HTML instead of the actual ISO. Signed-off-by: Daniel P

Re: [Libosinfo] [PATCH 2/6] recognize Mageia 4

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 03:49:33PM +0200, Thierry Vignaud wrote: > On 11 August 2016 at 13:03, Daniel P. Berrange wrote: > > On Thu, Aug 11, 2016 at 11:21:20AM +0200, Thierry Vignaud wrote: > >> --- > >> data/os/mageia.org/mageia-4.xml.in | 77 > >> ++

Re: [Libosinfo] [PATCH 5/6] add support for generic Mageia

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 04:32:43PM +0200, Thierry Vignaud wrote: > On 11 August 2016 at 16:29, Daniel P. Berrange wrote: > >> >> - split netinstall, > >> >> - add variant IDs > >> >> - add kernel/initrd pathes, > >> >> - make live b

Re: [Libosinfo] [PATCH 5/6] add support for generic Mageia

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 03:53:03PM +0200, Thierry Vignaud wrote: > On 11 August 2016 at 13:05, Daniel P. Berrange wrote: > > On Thu, Aug 11, 2016 at 11:21:23AM +0200, Thierry Vignaud wrote: > >> From: Thierry Vignaud > >> > >> v2: > >> - split netinst

Re: [Libosinfo] [PATCH osinfo-db] Fix COPYING file to refer to GPLv2+, not LGPLv2+

2016-08-11 Thread Daniel P. Berrange
On Tue, Aug 02, 2016 at 03:49:55PM +0100, Daniel P. Berrange wrote: > The LGPLv2+ is only applicable for code that needs to be linked > with other non-GPL compatible code. The actual osinfo database > files aren't linked in any traditional sense - they're merely > parsed. As

Re: [Libosinfo] [PATCH 1/6] use the right devices by default

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 11:21:19AM +0200, Thierry Vignaud wrote: > --- > data/os/mageia.org/mageia-1.xml.in | 8 > 1 file changed, 8 insertions(+) > > diff --git a/data/os/mageia.org/mageia-1.xml.in > b/data/os/mageia.org/mageia-1.xml.in > index 3380b1b..262d27f 100644 > --- a/data/os/m

Re: [Libosinfo] [PATCH 6/6] describe HW

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 11:21:24AM +0200, Thierry Vignaud wrote: > --- > data/os/freebsd.org/freebsd-8.0.xml.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/data/os/freebsd.org/freebsd-8.0.xml.in > b/data/os/freebsd.org/freebsd-8.0.xml.in > index e7554a3..0fdbc0b 1006

Re: [Libosinfo] [PATCH 5/6] add support for generic Mageia

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 11:21:23AM +0200, Thierry Vignaud wrote: > From: Thierry Vignaud > > v2: > - split netinstall, > - add variant IDs > - add kernel/initrd pathes, > - make live be x86_64 (same label between ia32 & x86_64 :-( ) > - live matches only mga4+ > --- > data/os/mageia.org/mageia-u

Re: [Libosinfo] [PATCH 3/6] recognize Mageia 4.1

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 11:21:21AM +0200, Thierry Vignaud wrote: > --- > data/os/mageia.org/mageia-4.1.xml.in | 53 > > 1 file changed, 53 insertions(+) > create mode 100644 data/os/mageia.org/mageia-4.1.xml.in Same comments here as the previous patch, and l

Re: [Libosinfo] [PATCH 2/6] recognize Mageia 4

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 11:21:20AM +0200, Thierry Vignaud wrote: > --- > data/os/mageia.org/mageia-4.xml.in | 77 > ++ > 1 file changed, 77 insertions(+) > create mode 100644 data/os/mageia.org/mageia-4.xml.in > > diff --git a/data/os/mageia.org/mageia-4.xml.

Re: [Libosinfo] [PATCH] add support for ReactOS

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 12:02:31PM +0200, Thierry Vignaud wrote: > notes: > - it's not possible to differentiate LiveCD from regular installer > - it's not possible to differentiate between different versions > - network works OK (as in ping) > --- > data/os/reactos/reactos.xml.in | 38 +++

Re: [Libosinfo] [PATCH 0/6] Add Mageia[3-5]+generic support

2016-08-11 Thread Daniel P. Berrange
On Thu, Aug 11, 2016 at 11:15:21AM +0200, Thierry Vignaud wrote: > On 11 August 2016 at 10:44, Daniel P. Berrange wrote: > >> This patch series enables to detect: > >> - stable release Mageia[3-5] > >> - future releases (including Cauldron, the rolling distro) &g

Re: [Libosinfo] [PATCH 0/6] Add Mageia[3-5]+generic support

2016-08-11 Thread Daniel P. Berrange
On Wed, Aug 10, 2016 at 06:19:15PM +0200, Thierry Vignaud wrote: > This patch series enables to detect: > - stable release Mageia[3-5] > - future releases (including Cauldron, the rolling distro) > Last but not least it makes virt-manager to pick the right devices for proper > mouse integration & f

[Libosinfo] [PATCH] configure: fix accidental break in soname

2016-08-10 Thread Daniel P. Berrange
The change in version from 0.3.0 to 1.0.0 triggered a latent bug in our code which sets the library soname. This meant we created libosinfo-1.0.so.1 instead of libosinfo-1.0.so.0 Pull in the fix from libvirt which is where the original logic was copied from. Signed-off-by: Daniel P. Berrange

  1   2   >