Re: [Libosinfo] [libosinfo PATCH] media: Fix usage of application id

2019-04-02 Thread Cole Robinson
On 4/1/19 4:45 PM, Fabiano Fidêncio wrote: > Christophe Fergeau pointed this issue out during the review of 6d789033e > and, even though, the bogus code ended up merged (sorry, mea culpa > here!). > > Signed-off-by: Fabiano Fidêncio > --- > osinfo/osinfo_media.c | 4 ++-- > 1 file changed, 2 ins

Re: [Libosinfo] [osinfo-db PATCH 1/2] freebsd: Remove 10.4, 11.0, and 11.1 dead links

2019-04-02 Thread Cole Robinson
On 4/2/19 5:36 AM, Fabiano Fidêncio wrote: > Those links have been from their website. > You removed the 'removed' here :) Series: Reviewed-by: Cole Robinson - Cole ___ Libosinfo mailing list Libosinfo@redhat.com https://www.redhat.com/mailman/listi

Re: [Libosinfo] [libosinfo PATCH v3 0/6] Use "all" arch as a fallback for media/tree detection

2019-04-02 Thread Cole Robinson
On 4/2/19 6:18 AM, Fabiano Fidêncio wrote: > This series has been written considering: > - https://www.redhat.com/archives/libosinfo/2019-February/msg00247.html > > Let's assume that trees and medias set with architecture "all" will be > treated as fallback, always. > > NOTE: In the v3 a differen

Re: [Libosinfo] [libosinfo PATCH v2] gitignore: remove old entries, simplify existing ones

2019-04-02 Thread Fabiano Fidêncio
On Mon, Apr 1, 2019 at 10:38 AM Pino Toscano wrote: > > Remove patterns referring to old tests, and in general to files that do > not exist anymore. > > Simplify few existing patterns into more general ones. Reviewed-by: Fabiano Fidêncio (and pushed!) Best Regards, -- Fabiano Fidêncio ___

[Libosinfo] [libosinfo PATCH v3 3/6] db: Deal with "all" tree architectures

2019-04-02 Thread Fabiano Fidêncio
Tree with "all" architecture are used as a fallback when guessing an OS from a tree. Knowing that, any entry with "all" architecture should not be considered when first comparing the trees, thus those are skipped and, later on, if no match has been found, those are used. https://gitlab.com/libosi

[Libosinfo] [libosinfo PATCH v3 1/6] db: Rename tree to treeinfo in guess_os_from_tree()

2019-04-02 Thread Fabiano Fidêncio
It'll make clear that we're dealing with the treeinfo attributes and not with the tree ones. https://gitlab.com/libosinfo/libosinfo/issues/20 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_db.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/osi

[Libosinfo] [libosinfo PATCH v3 5/6] db: Deal with "all" media architecture

2019-04-02 Thread Fabiano Fidêncio
Medias with "all" architecture are used as a fallback when guessing an OS from a media. Knowing that, any entry with "all" architecture should not be considered when first comparing the medias, thus those are skipped and, later on, if no match has been found, those are used. https://gitlab.com/li

[Libosinfo] [libosinfo PATCH v3 4/6] test-db: Add test for guessing tree from OS

2019-04-02 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- .../dbdata/os/libosinfo.org/test-db-tree.xml | 26 + tests/test-db.c | 58 +++ 2 files changed, 84 insertions(+) create mode 100644 tests/dbdata/os/libosinfo.org/test-db-tree.xml diff --git a/tests/dbdata

[Libosinfo] [libosinfo PATCH v3 6/6] test-db: Add test to cover identifying a media with "unknown" arch

2019-04-02 Thread Fabiano Fidêncio
Signed-off-by: Fabiano Fidêncio --- .../dbdata/os/libosinfo.org/test-db-media.xml | 13 +++ tests/test-db.c | 22 +++ 2 files changed, 35 insertions(+) diff --git a/tests/dbdata/os/libosinfo.org/test-db-media.xml b/tests/dbdata/os/libosinfo.

[Libosinfo] [libosinfo PATCH v3 2/6] db: Rename os_* to os_treeinfo_* in guess_os_from_tree()

2019-04-02 Thread Fabiano Fidêncio
It'll make clear that we're dealing with the treeinfo attributes and not with the tree ones. https://gitlab.com/libosinfo/libosinfo/issues/20 Signed-off-by: Fabiano Fidêncio --- osinfo/osinfo_db.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/osi

[Libosinfo] [libosinfo PATCH v3 0/6] Use "all" arch as a fallback for media/tree detection

2019-04-02 Thread Fabiano Fidêncio
This series has been written considering: - https://www.redhat.com/archives/libosinfo/2019-February/msg00247.html Let's assume that trees and medias set with architecture "all" will be treated as fallback, always. NOTE: In the v3 a different approach has been taken and there's no explicit check c

[Libosinfo] [osinfo-db PATCH 0/2] Update/remove dead links

2019-04-02 Thread Fabiano Fidêncio
Those 2 patches have been pushed under "test breakage" rule. Fabiano Fidêncio (2): freebsd: Remove 10.4, 11.0, and 11.1 dead links fedora27: Update dead links data/os/fedoraproject.org/fedora-27.xml.in | 12 ++-- data/os/freebsd.org/freebsd-10.4.xml.in| 4 data/os/freebsd.o

[Libosinfo] [osinfo-db PATCH 2/2] fedora27: Update dead links

2019-04-02 Thread Fabiano Fidêncio
Fedora 27 links have been moved to archive. Signed-off-by: Fabiano Fidêncio --- data/os/fedoraproject.org/fedora-27.xml.in | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in ind

[Libosinfo] [osinfo-db PATCH 1/2] freebsd: Remove 10.4, 11.0, and 11.1 dead links

2019-04-02 Thread Fabiano Fidêncio
Those links have been from their website. Signed-off-by: Fabiano Fidêncio --- data/os/freebsd.org/freebsd-10.4.xml.in | 4 data/os/freebsd.org/freebsd-11.0.xml.in | 4 data/os/freebsd.org/freebsd-11.1.xml.in | 4 3 files changed, 12 deletions(-) diff --git a/data/os/freebsd.org/f